RE: [EXT] module refcount issues in the liquidio driver

2021-03-11 Thread Felix Manlunas
he module refcount ...". commit bb54be589c7a8451a0504924703abdffeb06b79f Author: Felix Manlunas Date: Tue Apr 4 19:26:57 2017 -0700 liquidio: fix Octeon core watchdog timeout false alarm Detection of watchdog timeout of Octeon cores is flawed and susceptible to false alarms. Refactor by re

[PATCH V2 net-next 0/6] liquidio: enhanced ethtool --set-channels feature

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha For the ethtool --set-channels feature, the liquidio driver currently accepts max combined value as the queue count configured during driver load time, where max combined count is the total count of input and output queues. This limitation is applicable only when SR-IOV is en

[PATCH V2 net-next 1/6] liquidio: Moved common function if_cfg_callback to lio_core.c

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function if_cfg_callback to lio_core.c and renamed it to lio_if_cfg_callback. Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 32 drivers/net

[PATCH V2 net-next 2/6] liquidio: Moved common function list_delete_head to octeon_network.h

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function list_delete_head to octeon_network.h and renamed it to lio_list_delete_head Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 23 ++-- drivers

[PATCH V2 net-next 3/6] liquidio: Moved common function delete_glists to lio_core.c

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function delete_glists to lio_core.c and renamed it to lio_delete_glists Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 41 ++ drivers/net/ethernet

[PATCH V2 net-next 5/6] liquidio: Moved common function setup_glists to lio_core.c

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function setup_glists to lio_core.c and reamed it to lio_setup_glists Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 83 + drivers/net/ethernet

[PATCH V2 net-next 4/6] liquidio: Moved common definition octnic_gather to octeon_network.h

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moving common definition octnic_gather to octeon_network.h Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 21 - drivers/net/ethernet/cavium/liquidio

[PATCH V2 net-next 6/6] liquidio: enhanced ethtool --set-channels feature

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Enhancing driver to accept max supported queues for ethtool --set-channels Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 6 +- .../ethernet/cavium/liquidio/cn23xx_pf_device.h

[PATCH net-next] liquidio VF: indicate that disabling rx vlan offload is not allowed

2018-05-01 Thread Felix Manlunas
in the VF. Signed-off-by: Raghu Vatsavayi Acked-by: Prasad Kanneganti Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium/liqui

[PATCH net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards

2018-05-03 Thread Felix Manlunas
ethtool_convert_legacy_u32_to_link_mode). Signed-off-by: Weilin Chang Acked-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 196 + drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 193 +--- drivers/net/ethernet/cavium

[PATCH V2 net-next] liquidio: support use of ethtool to set link speed of CN23XX-225 cards

2018-05-04 Thread Felix Manlunas
ethtool_convert_legacy_u32_to_link_mode). Signed-off-by: Weilin Chang Acked-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- Patch Change Log: V1 -> V2: In lio_set_link_ksettings(), set the order of local variable declarations from longest to shortest line. drivers/net/ethernet/cavium/liqui

pull-request Cavium liquidio firmware v1.7.2

2018-05-08 Thread Felix Manlunas
up to d3b6941e1a85cbff895a92aa9e36b50deaeac970: linux-firmware: liquidio: update firmware to v1.7.2 (2018-05-08 19:02:41 -0700) Signed-off-by: Felix Manlunas Felix Manlunas (1): linux-firmware: liquidio: update firmware to

[PATCH net-next] liquidio: monitor all of Octeon's cores in watchdog thread

2018-05-09 Thread Felix Manlunas
The liquidio_watchdog kernel thread is watching over only 12 cores of the Octeon CN23XX; it's neglecting the other 4 cores that are present in the CN2360. Fix it by defining LIO_MAX_CORES as 16. Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_network.h | 2

[PATCH net-next] liquidio: bump up driver version to 1.7.2 to match newer NIC firmware

2018-05-09 Thread Felix Manlunas
Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/liquidio_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/liquidio_common.h b/drivers/net/ethernet/cavium/liquidio/liquidio_common.h index 285b248..690424b

[PATCH net-next] liquidio: Added ndo_get_vf_stats support

2018-04-18 Thread Felix Manlunas
From: Intiyaz Basha Added the ndo to gather VF statistics through the PF. Collect VF statistics via mailbox from VF. Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 54 ++ .../ethernet/cavium/liquidio

Re: [PATCH] liquidio: fix lio_vf_rep_pkt_xmit()'s return type

2018-04-24 Thread Felix Manlunas
-static int > +static netdev_tx_t > lio_vf_rep_pkt_xmit(struct sk_buff *skb, struct net_device *ndev) > { > struct lio_vf_rep_desc *vf_rep = netdev_priv(ndev); > -- > 2.17.0 > Thanks. Acked-by: Felix Manlunas

Re: [PATCH] liquidio: fix liquidio_xmit()'s return type

2018-04-24 Thread Felix Manlunas
mitted to the device okay or not > * (NETDEV_TX_OK or NETDEV_TX_BUSY) > */ > -static int liquidio_xmit(struct sk_buff *skb, struct net_device *netdev) > +static netdev_tx_t liquidio_xmit(struct sk_buff *skb, struct net_device > *netdev) > { > struct octnet_buf_free_info *finfo; > union octnic_cmd_setup cmdsetup; > -- > 2.17.0 > Acked-by: Felix Manlunas

[PATCH net-next] liquidio: Swap VF representor Tx and Rx statistics

2018-04-24 Thread Felix Manlunas
From: Srinivas Jampala Swap VF representor tx and rx interface statistics since it is a virtual switchdev port and tx for VM should be rx for VF representor and vice-versa. Signed-off-by: Srinivas Jampala Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium

[PATCH net-next 0/6] liquidio: enhanced ethtool --set-channels feature

2018-04-25 Thread Felix Manlunas
From: Intiyaz Basha For the ethtool --set-channels feature, the liquidio driver currently accepts max combined value as the queue count configured during driver load time, where max combined count is the total count of input and output queues. This limitation is applicable only when SR-IOV is en

[PATCH net-next 1/6] liquidio: Moved common function if_cfg_callback to lio_core.c

2018-04-25 Thread Felix Manlunas
From: Intiyaz Basha Moved common function if_cfg_callback to lio_core.c and renamed it to lio_if_cfg_callback. Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 32 drivers/net

[PATCH net-next 4/6] liquidio: Moved common definition octnic_gather to octeon_network.h

2018-04-25 Thread Felix Manlunas
From: Intiyaz Basha Moving common definition octnic_gather to octeon_network.h Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 21 - drivers/net/ethernet/cavium/liquidio

[PATCH net-next 2/6] liquidio: Moved common function list_delete_head to octeon_network.h

2018-04-25 Thread Felix Manlunas
From: Intiyaz Basha Moved common function list_delete_head to octeon_network.h and renamed it to lio_list_delete_head Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 23 ++-- drivers

[PATCH net-next 6/6] liquidio: enhanced ethtool --set-channels feature

2018-04-25 Thread Felix Manlunas
From: Intiyaz Basha Enhancing driver to accept max supported queues for ethtool --set-channels Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 6 +- .../ethernet/cavium/liquidio/cn23xx_pf_device.h

[PATCH net-next 5/6] liquidio: Moved common function setup_glists to lio_core.c

2018-04-25 Thread Felix Manlunas
From: Intiyaz Basha Moved common function setup_glists to lio_core.c and reamed it to lio_setup_glists Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 83 + drivers/net/ethernet

[PATCH net-next 3/6] liquidio: Moved common function delete_glists to lio_core.c

2018-04-25 Thread Felix Manlunas
From: Intiyaz Basha Moved common function delete_glists to lio_core.c and renamed it to lio_delete_glists Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 41 ++ drivers/net/ethernet

[PATCH net-next 0/2] liquidio: add support for ndo_get_stats64

2018-04-25 Thread Felix Manlunas
From: Pradeep Nalla Support ndo_get_stats64 instead of ndo_get_stats. Also add stats for multicast and broadcast packets. Pradeep Nalla (2): liquidio: move a couple of functions to lio_core.c liquidio: add support for ndo_get_stats64 instead of ndo_get_stats drivers/net/ethernet/cavium/li

[PATCH net-next 1/2] liquidio: move a couple of functions to lio_core.c

2018-04-25 Thread Felix Manlunas
ction prototype in octeon_network.h. Signed-off-by: Pradeep Nalla Acked-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 152 drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 157 - .../net/eth

[PATCH net-next 2/2] liquidio: add support for ndo_get_stats64 instead of ndo_get_stats

2018-04-25 Thread Felix Manlunas
From: Pradeep Nalla Support ndo_get_stats64 instead of ndo_get_stats. Also add stats for multicast and broadcast packets. Signed-off-by: Pradeep Nalla Acked-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 4 + drivers/net/ethernet

[PATCH V2 net-next] liquidio: Added support for trusted VF

2018-03-21 Thread Felix Manlunas
From: Intiyaz Basha When a VF is trusted, all promiscuous traffic will only be sent to that VF. In normal operation promiscuous traffic is sent to the PF. There can be only one trusted VF per PF Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- Patch Change Log: V1 ->

[PATCH net-next 00/13] liquidio: Tx queue cleanup

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Moved some common function to octeon_network.h Removed some unwanted functions and checks. Intiyaz Basha (13): liquidio: Moved common function txqs_stop to octeon_network.h liquidio: Moved common function txqs_wake to octeon_network.h liquidio: Moved common function txq

[PATCH net-next 01/13] liquidio: Moved common function txqs_stop to octeon_network.h

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Moving common function txqs_stop to octeon_network.h Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 16 drivers/net/ethernet/cavium/liquidio/lio_vf_main.c

[PATCH net-next 02/13] liquidio: Moved common function txqs_wake to octeon_network.h

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Moving common function txqs_wake to octeon_network.h Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 28 -- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c

[PATCH net-next 05/13] liquidio: Removed one line function stop_txq

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Removing one line function stop_txq Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net

[PATCH net-next 03/13] liquidio: Moved common function txqs_start to octeon_network.h

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Moving common function txqs_start to octeon_network.h Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 16 drivers/net/ethernet/cavium/liquidio/lio_vf_main.c

[PATCH net-next 10/13] liquidio: Function call skb_iq for deriving queue from skb

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Using skb_iq function for deriving queue from skb Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 3 +-- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 3 +-- 2 files

[PATCH net-next 06/13] liquidio: Removed start_txq function

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Removing start_txq function from VF and PF files Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 16 +--- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c

[PATCH net-next 08/13] liquidio: Removed one line function stop_q

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Removing one line function stop_q Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 12 +--- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 12 +--- 2 files

[PATCH net-next 04/13] liquidio: Moved common function skb_iq to to octeon_network.h

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Moving common function skb_iq to to octeon_network.h Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 10 -- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 10

[PATCH net-next 12/13] liquidio: Renamed txqs_stop to stop_txqs

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha For consistency renaming txqs_stop to stop_txqs Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 4 ++-- drivers

[PATCH net-next 11/13] liquidio: Renamed txqs_wake to wake_txqs

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha For consistency renaming txqs_wake to wake_txqs Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 ++-- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 4 ++-- drivers

[PATCH net-next 09/13] liquidio: Removed one line function wake_q

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Removing one line function wake_q Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 14 ++ drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 12 +--- 2 files

[PATCH net-next 13/13] liquidio: Renamed txqs_start to start_txqs

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha For consistency renaming txqs_start to start_txqs Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 2 +- drivers

[PATCH net-next 07/13] liquidio: Removed netif_is_multiqueue check

2018-03-23 Thread Felix Manlunas
From: Intiyaz Basha Removing checks for netif_is_multiqueue. Configuring single queue will be a multiqueue netdev with one queues. Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 18 ++--- drivers

[PATCH net-next] liquidio: Removed duplicate Tx queue status check

2018-03-26 Thread Felix Manlunas
: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 28 - drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 29 -- 2 files changed, 57 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet

[PATCH net-next] liquidio: Prioritize control messages

2018-03-27 Thread Felix Manlunas
ned-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/liquidio_common.h | 8 ++-- drivers/net/ethernet/cavium/liquidio/request_manager.c | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cavium/liqui

[PATCH V2 net-next] liquidio: prevent rx queues from getting stalled

2018-03-29 Thread Felix Manlunas
n the code. The DOWN command also waits for any pending packets to be processed by NAPI so that the deadlock will not occur. Signed-off-by: Raghu Vatsavayi Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- Patch Change Log: V1 -> V2: Revised the subject line and patch descr

[PATCH net-next 0/4] liquidio: adding support for ethtool --set-channels feature

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Code reorganization is required for adding ethtool --set-channels feature. First three patches are for code reorganization. The last patch is for adding this feature. Intiyaz Basha (4): liquidio: moved liquidio_msix_intr_handler to lio_core.c liquidio: moved liquidio_leg

[PATCH net-next 1/4] liquidio: moved liquidio_msix_intr_handler to lio_core.c

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Moving common liquidio_msix_intr_handler to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 41 drivers/net/ethernet/cavium/liquidio

[PATCH net-next 2/4] liquidio: moved liquidio_legacy_intr_handler to lio_core.c

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Moving liquidio_legacy_intr_handler to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 55 + drivers/net/ethernet/cavium/liquidio/lio_main.c

[PATCH net-next 4/4] liquidio: added support for ethtool --set-channels feature

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha adding support for ethtool --set-channels feature Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 17 +- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 190

[PATCH net-next 3/4] liquidio: moved octeon_setup_interrupt to lio_core.c

2017-08-15 Thread Felix Manlunas
From: Intiyaz Basha Moving common octeon_setup_interrupt to lio_core.c Signed-off-by: Intiyaz Basha Signed-off-by: Raghu Vatsavayi Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 200 + drivers/net/ethernet/cavium/liquidio

[PATCH net-next] liquidio: update VF's netdev->max_mtu if there's a change in PF's MTU

2017-08-15 Thread Felix Manlunas
From: Veerasenareddy Burru A VF's MTU is capped at the parent PF's MTU. So if there's a change in the PF's MTU, then update the VF's netdev->max_mtu. Also remove duplicate log messages for MTU change. Signed-off-by: Veerasenareddy Burru Signed-off-by: Raghu Vat

[PATCH net-next] liquidio: remove support for deprecated f/w cmd OCTNET_CMD_RESET_PF

2017-08-16 Thread Felix Manlunas
From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 9 - drivers/net/ethernet/cavium/liquidio/liquidio_common.h | 1 - 2 files changed, 10 deletions(-) diff --git a/drivers/net/ethernet/cavium

[PATCH net-next 0/2] liquidio: initialization fixes for embedded firmware

2017-08-17 Thread Felix Manlunas
From: Rick Farrington Fix problems when using an adapter w/embedded f/w (param "fw_type=none"). 1. Add support for PF FLR when exiting. 2. Skip some initialization (don't try to load f/w, activate consoles). 3. Issue credits BEFORE enabling DROQs. Rick Farrington (2): liquidio: with embedded

[PATCH net-next 2/2] liquidio: with embedded f/w, issue droq credits before enablement

2017-08-17 Thread Felix Manlunas
From: Rick Farrington 1. Issue credits BEFORE enabling DROQ's; this prevents PKTPF_ERR interrupt. Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 20 1 file changed, 12 insertions(+), 8 deletions(-)

[PATCH net-next 1/2] liquidio: with embedded f/w, don't reload f/w, issue pf flr at exit

2017-08-17 Thread Felix Manlunas
From: Rick Farrington 1. Add support for PF FLR when exiting (enables CORE_DRV_ACTIVE upon next driver init) 2. Skip some initialization (don't try to load f/w, activate consoles). Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liq

[PATCH net-next 0/2] liquidio: VF driver will notify NIC firmware of MTU change

2017-08-18 Thread Felix Manlunas
From: Veerasenareddy Burru Make VF driver notify NIC firmware of MTU change. Firmware needs this information for MTU propagation and enforcement. The first patch in this series moves a macro definition to a proper place to prevent a build error in the second patch which has the code that sends

[PATCH net-next 1/2] liquidio: move macro definition to a proper place

2017-08-18 Thread Felix Manlunas
The macro LIO_CMD_WAIT_TM is not specific to the PF driver; it can be used by the VF driver too, so move its definition from a PF-specific header file to one that's common to PF and VF. Signed-off-by: Veerasenareddy Burru Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liq

[PATCH net-next 2/2] liquidio: make VF driver notify NIC firmware of MTU change

2017-08-18 Thread Felix Manlunas
Signed-off-by: Veerasenareddy Burru Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b/drivers/net/ethernet/cavium

[PATCH net-next] liquidio: fix Smatch error

2017-08-18 Thread Felix Manlunas
: Dan Carpenter Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c

[PATCH net-next] liquidio: fix use of pf in pass-through mode in a virtual machine

2017-08-18 Thread Felix Manlunas
From: Rick Farrington Fix problem when PF is used in pass-through mode in a VM (w/embedded f/w). If host error reading PF num from CN23XX_PCIE_SRIOV_FDL reg, try to retrieve PF num from SLI_PKT(0)_INPUT_CONTROL (initialized by f/w). Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas

[PATCH V2 net-next 0/2] liquidio: VF driver will notify NIC firmware of MTU change

2017-08-21 Thread Felix Manlunas
From: Veerasenareddy Burru Make VF driver notify NIC firmware of MTU change. Firmware needs this information for MTU propagation and enforcement. The first patch in this series moves a macro definition to a proper place to prevent a build error in the second patch which has the code that sends

[PATCH V2 net-next 1/2] liquidio: move macro definition to a proper place

2017-08-21 Thread Felix Manlunas
From: Veerasenareddy Burru The macro LIO_CMD_WAIT_TM is not specific to the PF driver; it can be used by the VF driver too, so move its definition from a PF-specific header file to one that's common to PF and VF. Signed-off-by: Veerasenareddy Burru Signed-off-by: Felix Manlunas --- dr

[PATCH V2 net-next 2/2] liquidio: make VF driver notify NIC firmware of MTU change

2017-08-21 Thread Felix Manlunas
From: Veerasenareddy Burru Signed-off-by: Veerasenareddy Burru Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 27 ++ 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_vf_main.c b

[PATCH net-next] liquidio: show NIC's U-Boot version in a dev_info() message

2017-08-21 Thread Felix Manlunas
From: Weilin Chang Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- .../net/ethernet/cavium/liquidio/octeon_console.c | 85 ++ .../net/ethernet/cavium/liquidio/octeon_device.h | 5 ++ 2 files changed, 90 insertions(+) diff --git a/drivers/net/ethernet

[PATCH net-next] liquidio: change manner of detecting whether or not NIC firmware is loaded

2017-08-22 Thread Felix Manlunas
ll never give a false negative. Also bump up driver version to match newer NIC firmware. Signed-off-by: Felix Manlunas Signed-off-by: Derek Chickles --- drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c | 15 +-- drivers/net/ethernet/cavium/liquidio/lio_main.c | 6

Re: [PATCH] [net] liquidio: fix timespec64_to_ns typo

2017-10-12 Thread Felix Manlunas
ptp_clock_info > *ptp, > struct lio *lio = container_of(ptp, struct lio, ptp_info); > struct octeon_device *oct = (struct octeon_device *)lio->oct_dev; > > - ns = timespec_to_ns(ts); > + ns = timespec64_to_ns(ts); > > spin_lock_irqsave(&lio->ptp_lock, flags); > lio_pci_writeq(oct, ns, CN6XXX_MIO_PTP_CLOCK_HI); > -- > 2.9.0 > Thanks. Acked-by: Felix Manlunas

[PATCH V2 net-next] liquidio: pass date and time info to NIC firmware

2017-10-18 Thread Felix Manlunas
debugging. Signed-off-by: Veerasenareddy Burru Signed-off-by: Satanand Burla Signed-off-by: Derek Chickles Signed-off-by: Felix Manlunas --- Patch Change Log: V1 -> V2: Follow reviewer's suggestion of periodically updating firmware with date and time info. drivers/net/etherne

[PATCH net-next] liquidio: xmit_more support

2017-10-18 Thread Felix Manlunas
From: Intiyaz Basha Do not write the Tx doorbell if skb->xmit_more is set unless the Tx queue is full or stopped. Signed-off-by: Intiyaz Basha Signed-off-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 6 -- drivers/

[PATCH net-next] liquidio: fix kernel panic when NIC firmware is older than 1.7.2

2018-06-25 Thread Felix Manlunas
at ends in a kernel panic. Fix it by making the sending of the "get speed" command conditional on the firmware version. Signed-off-by: Rick Farrington Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- Note: To avoid checkpatch.pl "WARNING: line over 80 characters",

Re: [PATCH net-next] liquidio: fix kernel panic when NIC firmware is older than 1.7.2

2018-06-27 Thread Felix Manlunas
On Tue, Jun 26, 2018 at 09:03:25AM -0700, Shannon Nelson wrote: > On 6/26/2018 4:58 AM, Felix Manlunas wrote: > > From: Rick Farrington > > > > Pre-1.7.2 NIC firmware does not support (and does not respond to) the "get > > speed" command which is sent by the

[PATCH V2 net-next] liquidio: fix kernel panic when NIC firmware is older than 1.7.2

2018-07-06 Thread Felix Manlunas
d causes a cascade of errors that ends in a kernel panic. Fix it by making the sending of the "get speed" command conditional on the firmware version. Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- Patch Change Log: V1 -> V2: * In the if-statement that chec

Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Felix Manlunas
d]: base: %p basedma: %pad count: > %d\n", > + iq_no, iq->base_addr, &iq->base_addr_dma, iq->max_count); > > iq->txpciq.u64 = txpciq.u64; > iq->fill_threshold = (u32)conf->db_min; Acked-by: Felix Manlunas

[PATCH net-next] liquidio: fix hang when re-binding VF host drv after running DPDK VF driver

2018-07-13 Thread Felix Manlunas
-length packets). This represented an invalid hardware configuration which the driver could not handle. Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c | 3 +++ drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c | 3

[PATCH net-next] liquidio: correct error msg text when removing VLAN ID

2018-07-16 Thread Felix Manlunas
From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 2 +- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet

[PATCH V2 net-next] liquidio: fix ndo_change_mtu to always return correct status to the caller

2018-03-10 Thread Felix Manlunas
. Also moved the common code for MTU change from PF and VF driver files to common file lio_core.c Signed-off-by: Veerasenareddy Burru Signed-off-by: Felix Manlunas --- Patch Change Log: V1 -> V2: Remove unnecessary log message "MTU changed from %d to %d\n" as suggested by

[PATCH net-next] liquidio: Add support for liquidio 10GBase-T NIC

2018-03-13 Thread Felix Manlunas
From: Veerasenareddy Burru Added ethtool changes to show port type as TP (Twisted Pair) for 10GBASE-T ports. Same driver and firmware works for liquidio NIC with SFP+ ports or TP ports. Signed-off-by: Veerasenareddy Burru Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio

[PATCH net-next] liquidio: Allow RX descriptors to be consumed before disabling NAPI.

2018-03-14 Thread Felix Manlunas
From: Raghu Vatsavayi Signed-off-by: Raghu Vatsavayi Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 23 drivers/net/ethernet/cavium/liquidio/lio_main.c| 25 +- drivers/net/ethernet

[PATCH net-next] liquidio: Simplified napi poll

2018-03-16 Thread Felix Manlunas
. Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 7 +- drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 83 -- drivers/net/ethernet/cavium/liquidio/octeon_droq.h | 11 ++- 3 files changed, 35 insertions

[PATCH net-next] liquidio: Added support for trusted VF

2018-03-16 Thread Felix Manlunas
From: Intiyaz Basha When a VF is trusted, all promiscuous traffic will only be sent to that VF. In normal operation promiscuous traffic is sent to the PF. There can be only one trusted VF per PF. Signed-off-by: Intiyaz Basha Acked-by: Satanand Burla Signed-off-by: Felix Manlunas --- drivers

[PATCH net-next] liquidio: Enhanced ethtool stats

2018-04-16 Thread Felix Manlunas
Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 54 ++-- drivers/net/ethernet/cavium/liquidio/lio_main.c| 2 + .../net/ethernet/cavium/liquidio/liquidio_common.h | 75 ++ drivers/net/ethernet/cavium/liquidio/octeon_iq.h

[PATCH net-next] liquidio: Corrected Rx bytes counting

2018-03-02 Thread Felix Manlunas
From: Intiyaz Basha Corrected stats mismatch between Host Tx and its peer Rx stats Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH net-next] liquidio: Added ndo_get_phys_port_id support

2018-03-02 Thread Felix Manlunas
: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c | 13 + drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 1 + drivers/net/ethernet

[PATCH net-next] liquidio: Resolved mbox read issue while reading more than one 64bit data

2018-03-07 Thread Felix Manlunas
From: Intiyaz Basha Corrected length check when data received in the mbox is more than one 64 bit data value Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH net-next] liquidio: avoid doing useless work

2018-03-07 Thread Felix Manlunas
From: Prasad Kanneganti Avoid doing useless work by making sure that the response_list is not empty before scheduling work to process it. Signed-off-by: Prasad Kanneganti Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 5 + drivers/net/ethernet

[PATCH net-next] liquidio: fix ndo_change_mtu to always return correct status to the caller

2018-03-07 Thread Felix Manlunas
. Also moved the common code for MTU change from PF and VF driver files to common file lio_core.c Signed-off-by: Veerasenareddy Burru Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 96 -- drivers/net/ethernet/cavium/liquidio/lio_main.c

[PATCH net-next 0/3] liquidio: firmware loading

2017-09-22 Thread Felix Manlunas
From: Rick Farrington 1. Allow host driver parameter to override auto-loaded firmware (in flash). 2. Verify version of firmware that is auto-loaded from flash. 3. Change value of fw_type module parameter to reflect default firmware image name that is loaded by host driver (in /sys/module/liqui

[PATCH net-next 2/3] liquidio: verify firmware version when auto-loaded from flash.

2017-09-22 Thread Felix Manlunas
From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet

[PATCH net-next 3/3] liquidio: update module parameter fw_type to reflect firmware type loaded

2017-09-22 Thread Felix Manlunas
From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium

[PATCH net-next 1/3] liquidio: allow override of firmware present in flash

2017-09-22 Thread Felix Manlunas
From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 68 ++ .../net/ethernet/cavium/liquidio/liquidio_image.h | 1 + .../net/ethernet/cavium/liquidio/octeon_device.c | 11

[PATCH net-next] liquidio: pass date and time info to NIC firmware

2017-09-22 Thread Felix Manlunas
From: Veerasenareddy Burru Signed-off-by: Veerasenareddy Burru Signed-off-by: Manish Awasthi Signed-off-by: Felix Manlunas --- .../net/ethernet/cavium/liquidio/octeon_console.c | 28 +++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next] liquidio: fix format truncation warning reported by gcc 7.1.1

2017-09-26 Thread Felix Manlunas
43 bytes into a destination of size 32 snprintf(&queue_irq_names[IRQ_NAME_OFF(i)], ^~~ INTRNAMSIZ, "LiquidIO%u-vf%u-rxtx-%u", ~~ oct->octeon_id, oct->vf_num, i); ~~~ Fix them by changing t

Re: GPL compliance issue with liquidio/lio_23xx_vsw.bin firmware

2018-08-27 Thread Felix Manlunas
On Mon, Aug 27, 2018 at 05:01:10PM +0200, Florian Weimer wrote: > liquidio/lio_23xx_vsw.bin contains a compiled MIPS Linux kernel: > > $ tail --bytes=+1313 liquidio/lio_23xx_vsw.bin > elf > $ readelf -aW elf > […] > [ 6] __ksymtab PROGBITS80e495f8 64a5f8 00d130 > 00 A

[PATCH net-next] liquidio: remove unnecessary delay when processing IQ responses

2018-08-28 Thread Felix Manlunas
From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet

[PATCH net-next] liquidio: fix race condition in instruction completion processing

2018-08-28 Thread Felix Manlunas
processed. Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 5 +++-- drivers/net/ethernet/cavium/liquidio/octeon_iq.h | 2 ++ drivers/net/ethernet/cavium/liquidio/request_manager.c | 2 ++ 3 files changed, 7 insertions

[PATCH net-next 0/4] liquidio: improve soft command/response handling

2018-08-28 Thread Felix Manlunas
From: Weilin Chang Change soft command handling to fix the possible race condition when the process handles a response of a soft command that was already freed by an application which got timeout for this request. Weilin Chang (4): liquidio: improve soft command handling liquidio: make soft

[PATCH net-next 2/4] liquidio: make soft command calls synchronous

2018-08-28 Thread Felix Manlunas
ff-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 134 ++--- drivers/net/ethernet/cavium/liquidio/lio_main.c| 42 ++- drivers/net/ethernet/cavium/liquidio/lio_vf_rep.c | 42 ++- drivers/net/ethernet/cavium/liquidio/octeon_main.h

[PATCH net-next 3/4] liquidio: change octnic_ctrl_pkt to do synchronous soft commands

2018-08-28 Thread Felix Manlunas
1. Change struct octnic_ctrl_pkt to support synchronous operation. 2. Change code which use structure octnic_ctrl_pkt to send sc's synchronously. Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 15 ++--- drivers/net/eth

[PATCH net-next 4/4] liquidio: remove obsolete functions and data structures

2018-08-28 Thread Felix Manlunas
1. Remove unused functions and data structures. 2. Change the sending of the remaining soft commands to synchronous. Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 83 +--- drivers/net/ethernet/cavium/liquidio

[PATCH net-next 1/4] liquidio: improve soft command handling

2018-08-28 Thread Felix Manlunas
N_ZOMBIE_SC_LIST response list will be freed when the driver is unloaded. Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 31 +- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 34 +- .../net/ethernet/cavium

  1   2   3   >