Re: ibmvnic: Race condition in remove callback

On 2021-01-17 02:12, Uwe Kleine-König wrote: Hello, while working on some cleanup I stumbled over a problem in the ibmvnic's remove callback. Since commit 7d7195a026ba ("ibmvnic: Do not process device remove during device reset") there is the following code in the remove callback:

Re: [PATCH net] ibmvnic: device remove has higher precedence over reset

On 2021-01-20 22:20, Lijun Pan wrote: Returning -EBUSY in ibmvnic_remove() does not actually hold the removal procedure since driver core doesn't care for the return value (see __device_release_driver() in drivers/base/dd.c calling dev->bus->remove()) though vio_bus_remove (in arch/powerpc/platfo

[PATCH net-next] ibmvnic: fix rx buffer tracking and index management in replenish_rx_pool partial success

uot; count when some batched sends worked but an error was encountered as part of the whole operation. Also track replenish_add_buff_failure for statistic purposes. Fixes: 4f0b6812e9b9a ("ibmvnic: Introduce batched RX buffer descriptor transmission") Signed-off-by: Dwip N. Banerjee Reviewed

Re: [PATCH net-next v2] ibmvnic: process HMC disable command

On 2020-12-02 12:02, drt wrote: On 2020-11-30 10:19, drt wrote: On 2020-11-25 15:55, drt wrote: On 2020-11-25 13:08, Jakub Kicinski wrote: On Mon, 23 Nov 2020 18:58:41 -0500 Dany Madden wrote: Currently ibmvnic does not support the "Disable vNIC" command from the Hardware Manageme

[PATCH net v2 1/9] ibmvnic: handle inconsistent login with reset

Inconsistent login with the vnicserver is causing the device to be removed. This does not give the device a chance to recover from error state. This patch schedules a FATAL reset instead to bring the adapter up. Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol") Signed-of

[PATCH net v2 4/9] ibmvnic: restore adapter state on failed reset

et so linkwatch_event can run") Fixes: 2770a7984db58 ("ibmvnic: Introduce hard reset recovery") Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 67 -- 1 file changed, 36 insertions(+), 31 deletions(-) diff --git a/drivers/net/ether

[PATCH net v2 0/9] ibmvnic: assorted bug fixes

parately to net-next. - Squash V1 "ibmvnic: remove free_all_rwi function" into ibmvnic: stop free_all_rwi on failed reset Dany Madden (7): ibmvnic: handle inconsistent login with reset ibmvnic: stop free_all_rwi on failed reset ibmvnic: avoid memset null scrq msgs ibmvni

[PATCH net v2 8/9] ibmvnic: no reset timeout for 5 seconds after reset

Reset timeout is going off right after adapter reset. This patch ensures that timeout is scheduled if it has been 5 seconds since the last reset. 5 seconds is the default watchdog timeout. Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling") Signed-off-by: Dany Madden --- d

[PATCH net v2 6/9] ibmvnic: track pending login

From: Sukadev Bhattiprolu If after ibmvnic sends a LOGIN it gets a FAILOVER, it is possible that the worker thread will start reset process and free the login response buffer before it gets a (now stale) LOGIN_RSP. The ibmvnic tasklet will then try to access the login response buffer and crash.

[PATCH net v2 5/9] ibmvnic: delay next reset if hard reset fails

From: Sukadev Bhattiprolu If auto-priority failover is enabled, the backing device needs time to settle if hard resetting fails for any reason. Add a delay of 60 seconds before retrying the hard-reset. Fixes: 2770a7984db5 ("ibmvnic: Introduce hard reset recovery") Signed-off-by: Sukadev Bhattip

[PATCH net v2 9/9] ibmvnic: reduce wait for completion time

ine for setting adapter link state") Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 3bfdf9f2edff..63b39744a07a 1006

[PATCH net v2 2/9] ibmvnic: stop free_all_rwi on failed reset

free_all_rwi(). Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling") Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/et

[PATCH net v2 3/9] ibmvnic: avoid memset null scrq msgs

scrq->msgs could be NULL during device reset, causing Linux to crash. So, check before memset scrq->msgs. Fixes: c8b2ad0a4a901 ("ibmvnic: Sanitize entire SCRQ buffer on reset") Signed-off-by: Dany Madden Signed-off-by: Lijun Pan --- drivers/net/ethernet/ib

[PATCH net-next v2] ibmvnic: process HMC disable command

ink to the "down" state on the linux client. Enable support in ibmvnic driver for the Disable vNIC command. Signed-off-by: Dany Madden --- V2 changes based on Jakub Kicinski's feedback: - Broke from "[PATCH net 00/15] ibmvnic: assorted bug fixes" sent by Lijun Pan. - Expan

[PATCH net v2 7/9] ibmvnic: send_login should check for crq errors

we get a PARITALSUCCESS response from the partner. Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol") Signed-off-by: Dany Madden Signed-off-by: Sukadev Bhattiprolu --- drivers/net/ethernet/ibm/ibmvnic.c | 18 -- 1 file changed, 12 insertions(+), 6

[PATCH net v3 0/9] ibmvnic: assorted bug fixes

"ibmvnic: remove free_all_rwi function" into ibmvnic: stop free_all_rwi on failed reset. Dany Madden (7): ibmvnic: handle inconsistent login with reset ibmvnic: stop free_all_rwi on failed reset ibmvnic: avoid memset null scrq msgs ibmvnic: restore adapter state on failed reset

[PATCH net v3 6/9] ibmvnic: track pending login

From: Sukadev Bhattiprolu If after ibmvnic sends a LOGIN it gets a FAILOVER, it is possible that the worker thread will start reset process and free the login response buffer before it gets a (now stale) LOGIN_RSP. The ibmvnic tasklet will then try to access the login response buffer and crash.

[PATCH net v3 3/9] ibmvnic: avoid memset null scrq msgs

scrq->msgs could be NULL during device reset, causing Linux to crash. So, check before memset scrq->msgs. Fixes: c8b2ad0a4a901 ("ibmvnic: Sanitize entire SCRQ buffer on reset") Signed-off-by: Dany Madden Signed-off-by: Lijun Pan --- drivers/net/ethernet/ib

[PATCH net v3 9/9] ibmvnic: reduce wait for completion time

ine for setting adapter link state") Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index a17856be2828..d6b2686aed0f 1006

[PATCH net v3 8/9] ibmvnic: no reset timeout for 5 seconds after reset

Reset timeout is going off right after adapter reset. This patch ensures that timeout is scheduled if it has been 5 seconds since the last reset. 5 seconds is the default watchdog timeout. Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling") Signed-off-by: Dany Madden --- d

[PATCH net v3 4/9] ibmvnic: restore adapter state on failed reset

et so linkwatch_event can run") Fixes: 2770a7984db58 ("ibmvnic: Introduce hard reset recovery") Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 67 -- 1 file changed, 36 insertions(+), 31 deletions(-) diff --git a/drivers/net/ether

[PATCH net v3 5/9] ibmvnic: delay next reset if hard reset fails

From: Sukadev Bhattiprolu If auto-priority failover is enabled, the backing device needs time to settle if hard resetting fails for any reason. Add a delay of 60 seconds before retrying the hard-reset. Fixes: 2770a7984db5 ("ibmvnic: Introduce hard reset recovery") Signed-off-by: Sukadev Bhattipr

[PATCH net v3 2/9] ibmvnic: stop free_all_rwi on failed reset

free_all_rwi(). Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling") Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/et

[PATCH net v3 7/9] ibmvnic: send_login should check for crq errors

we get a PARITALSUCCESS response from the partner. Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol") Signed-off-by: Dany Madden Signed-off-by: Sukadev Bhattiprolu --- drivers/net/ethernet/ibm/ibmvnic.c | 18 -- 1 file changed, 12 insertions(+), 6 deletion

[PATCH net v3 1/9] ibmvnic: handle inconsistent login with reset

Inconsistent login with the vnicserver is causing the device to be removed. This does not give the device a chance to recover from error state. This patch schedules a FATAL reset instead to bring the adapter up. Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol") Signed-of

Re: [PATCH net-next v2 1/7] ibmvnic: restore state in change-param reset

On 2021-01-12 10:14, Sukadev Bhattiprolu wrote: Restore adapter state before returning from change-param reset. In case of errors, caller will try a hard-reset anyway. Fixes: 0cb4bc66ba5e ("ibmvnic: restore adapter state on failed reset") Signed-off-by: Sukadev Bhattiprolu Reviewe

[PATCH net-next] Revert ibmvnic merge do_change_param_reset into do_reset

This reverts commit 16b5f5ce351f8709a6b518cc3cbf240c378305bf where it restructures do_reset. There are patches being tested that would require major rework if this is committed first. We will resend this after the other patches have been applied. Signed-off-by: Dany Madden --- drivers/net

[PATCH V2 net] ibmvnic: Continue with reset if set link down failed

cover. Fixes: ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: Dany Madden Reviewed-by: Rick Lindsley Reviewed-by: Sukadev Bhattiprolu --- Changes in V2: - Update description to clarify background for the patch - Include Reviewed-by tags --- drivers/net/ethernet/ib

[PATCH net] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16

: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue buffers") Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.h b/drivers/net/ethernet/ibm

[PATCH net V2] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16

: f019fb6392e5 ("ibmvnic: Introduce indirect subordinate Command Response Queue buffer") Signed-off-by: Dany Madden --- Changelog[V2]: Fixed fixes tag. Removed an extra s at the end of buffer. --- drivers/net/ethernet/ibm/ibmvnic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH net 1/1] ibmvnic: serialize access to work queue on remove

hen scheduling/flushing work. Fixes: 6954a9e4192b ("ibmvnic: Flush existing work items before device removal") Signed-off-by: Sukadev Bhattiprolu Reviewed-by: Dany Madden Cc:Uwe Kleine-König Cc:Saeed Mahameed --- Changelog An earlier version was reviewed by Saeed Mahmee

[PATCH] ibmvnic: Continue with reset if set link down failed

When an adapter is going thru a reset, it maybe in an unstable state that makes a request to set link down fail. In such a case, the adapter needs to continue on with reset to bring itself back to a stable state. Fixes: ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: D

Re: [PATCH] ibmvnic: Continue with reset if set link down failed

On 2021-04-05 23:46, Lijun Pan wrote: On Apr 5, 2021, at 10:47 PM, Dany Madden wrote: When an adapter is going thru a reset, it maybe in an unstable state that makes a request to set link down fail. In such a case, the adapter needs to continue on with reset to bring itself back to a stable

Re: [PATCH] ibmvnic: Continue with reset if set link down failed

On 2021-04-05 23:46, Lijun Pan wrote: On Apr 5, 2021, at 10:47 PM, Dany Madden wrote: When an adapter is going thru a reset, it maybe in an unstable state that makes a request to set link down fail. In such a case, the adapter needs to continue on with reset to bring itself back to a stable

Re: [PATCH] ibmvnic: Continue with reset if set link down failed

On 2021-04-07 12:03, Dany Madden wrote: On 2021-04-05 23:46, Lijun Pan wrote: On Apr 5, 2021, at 10:47 PM, Dany Madden wrote: When an adapter is going thru a reset, it maybe in an unstable state that makes a request to set link down fail. In such a case, the adapter needs to continue on

Re: [PATCH net 1/2] ibmvnic: fix a race between open and reset

t accordingly (see new comments in the code). Note that only the reset functions and ibmvnic_open() can set the adapter to OPEN state and this must happen under rtnl. Fixes: 7d7195a026ba ("ibmvnic: Do not process device remove during device reset") Signed-off-by: Sukadev Bhattiprolu R

[PATCH net] ibmvnic: update MAINTAINERS

Update supporters for IBM Power SRIOV Virtual NIC Device Driver. Thomas Falcon is moving on to other works. Dany Madden, Lijun Pan and Sukadev Bhattiprolu are the current supporters. Signed-off-by: Dany Madden --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH net] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

reset_rx_pools to safe handle NULL pointer case. Signed-off-by: Mingming Cao Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index

[PATCH net v2] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

to safe handle NULL pointer case. Signed-off-by: Mingming Cao Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index

[PATCH net v3] ibmvnic fix NULL tx_pools and rx_tools issue at do_reset

to safe handle NULL pointer case. Signed-off-by: Mingming Cao Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index

[PATCH net] ibmvnic: continue to init in CRQ reset returns H_CLOSED

Continue the reset path when partner adapter is not ready or H_CLOSED is returned from reset crq. This patch allows the CRQ init to proceed to establish a valid CRQ for traffic to flow after reset. Signed-off-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 9 +++-- 1 file changed