[PATCH] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag on Zynq

2020-12-23 Thread Charles Keepax
afa1d33cc9 ("net: macb: add capability to not set the clock rate") Signed-off-by: Charles Keepax --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/caden

Re: [PATCH] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag on Zynq

2020-12-23 Thread Charles Keepax
On Wed, Dec 23, 2020 at 08:24:41PM +0100, Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 06:41:44PM +0000, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > if

[PATCH v2] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2020-12-30 Thread Charles Keepax
nce of the flag. Update the if statement to this effect, which repairs the existing users. Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate") Suggested-by: Andrew Lunn Signed-off-by: Charles Keepax --- Changes since v1: - Updated flag semantics to skip fun

Re: [PATCH v2] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Charles Keepax
On Wed, Dec 30, 2020 at 05:44:41PM +0100, Andrew Lunn wrote: > On Wed, Dec 30, 2020 at 10:33:09AM +0000, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > - if (

[PATCH net v3] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Charles Keepax
nce of the flag. Update the if statement to this effect, which repairs the existing users. Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate") Suggested-by: Andrew Lunn Signed-off-by: Charles Keepax --- Changes since v1: - Updated flag semantics to skip fun

Re: [PATCH v2] net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag

2021-01-04 Thread Charles Keepax
On Wed, Dec 30, 2020 at 05:44:41PM +0100, Andrew Lunn wrote: > On Wed, Dec 30, 2020 at 10:33:09AM +0000, Charles Keepax wrote: > > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of > > macb_set_tx_clk were gated on the presence of this flag. > > > > - if (

[PATCH] net: macb: Only disable NAPI on the actual error path

2020-06-15 Thread Charles Keepax
macb: disable NAPI on error") Signed-off-by: Charles Keepax --- drivers/net/ethernet/cadence/macb_main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 5b9d7c60eebc0..679

[PATCH] net: macb: Only call GPIO functions if there is a valid GPIO

2016-03-28 Thread Charles Keepax
GPIOlib will print warning messages if we call GPIO functions without a valid GPIO. Change the code to avoid doing so. Signed-off-by: Charles Keepax --- drivers/net/ethernet/cadence/macb.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cadence

Re: [PATCH] net: macb: Only call GPIO functions if there is a valid GPIO

2016-03-29 Thread Charles Keepax
On Mon, Mar 28, 2016 at 08:30:11PM +0300, Sergei Shtylyov wrote: > >@@ -3029,7 +3030,8 @@ static int macb_remove(struct platform_device *pdev) > > mdiobus_free(bp->mii_bus); > > > > /* Shutdown the PHY if there is a GPIO reset */ > >-gpiod_set_value(bp->reset_gpi