Re: [PATCH RFC] net: qualcomm: rmnet: Move common struct definitions to include

2019-05-21 Thread Bjorn Andersson
On Tue 21 May 13:45 PDT 2019, Arnd Bergmann wrote: > On Tue, May 21, 2019 at 9:35 PM Subash Abhinov Kasiviswanathan > wrote: > > > > Create if_rmnet.h and move the rmnet MAP packet structs to this > > common include file. To account for portability, add little and > > big endian bitfield definiti

Re: [PATCH net-next] net: ipa: add config dependency on QCOM_SMEM

2021-01-12 Thread Bjorn Andersson
to build the IPA driver without SMEM. > This avoids a link error for certain configurations. > > Reported-by: Randy Dunlap > Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST") > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bjorn > --- >

Re: [PATCH v13 0/4] userspace MHI client interface driver

2020-12-01 Thread Bjorn Andersson
On Tue 01 Dec 13:29 CST 2020, Jakub Kicinski wrote: > On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar wrote: > > This patch series adds support for UCI driver. UCI driver enables userspace > > clients to communicate to external MHI devices like modem and WLAN. UCI > > driver > > probe creates sta

Re: [PATCH net 1/1] net: ipa: pass the correct size when freeing DMA memory

2020-12-03 Thread Bjorn Andersson
;soc: qcom: ipa: GSI transactions") > Reported-by: Stephen Boyd > Tested-by: Sujit Kautkar > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/net/ipa/gsi_trans.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff

Re: [PATCH v2] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-11-24 Thread Bjorn Andersson
On Mon 23 Nov 04:28 CST 2020, Amit Pundir wrote: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. >

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-11-24 Thread Bjorn Andersson
On Tue 03 Nov 01:48 CST 2020, Amit Pundir wrote: > Hi Rob, Bjorn, Kalle, > > On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson > wrote: > > > > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > > > > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wro

Re: [PATCH net-next 1/3] remoteproc: qcom: expose types for COMPILE_TEST

2021-01-06 Thread Bjorn Andersson
numerated type are defined > whether or not QCOM_RPROC_COMMON is enabled. > Reviewed-by: Bjorn Andersson @Jakub, @Dave, as this is a prerequisite for allowing IPA to be compile tested feel free to merge it together with patch 3. Regards, Bjorn > Signed-off-by: Alex Elder > --- >

Re: [PATCH net-next 2/3] soc: qcom: mdt_loader: define stubs for COMPILE_TEST

2021-01-06 Thread Bjorn Andersson
On Tue 05 Jan 20:38 CST 2021, Alex Elder wrote: > Define stub functions for the exposed MDT functions in case > QCOM_MDT_LOADER is not configured. This allows users of these > functions to link correctly for COMPILE_TEST builds without > QCOM_SCM enabled. > Reviewed-by:

Re: [PATCH net-next 4/4] net: ipa: support COMPILE_TEST

2021-01-07 Thread Bjorn Andersson
On Thu 07 Jan 17:34 CST 2021, Alex Elder wrote: > Arrange for the IPA driver to be built when COMPILE_TEST is enabled. > > Update the help text to reflect that we support two Qualcomm SoCs. > > Suggested-by: Jakub Kicinski > Signed-off-by: Alex Elder Reviewed-by: Bjorn A

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-10-29 Thread Bjorn Andersson
On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote: > > There are firmware versions which do not support host capability > > QMI request. We suspect either the host cap is not implemented or > > there may be firmware specific issues, but

Re: [PATCH 30/33] docs: ABI: cleanup several ABI documents

2020-11-03 Thread Bjorn Andersson
On Wed 28 Oct 09:23 CDT 2020, Mauro Carvalho Chehab wrote: [..] > .../ABI/testing/sysfs-class-remoteproc| 14 +- for this: Acked-by: Bjorn Andersson Thanks, Bjorn

Re: [PATCH] net: qrtr: Fix memory leak on qrtr_tx_wait failure

2021-03-30 Thread Bjorn Andersson
ab ("net: qrtr: Implement outgoing flow control") > Reported-by: syzbot+739016799a89c530b...@syzkaller.appspotmail.com > Signed-off-by: Loic Poulain Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > net/qrtr/qrtr.c | 5 - > 1 file changed, 4 insertions(+), 1 deleti

Re: [PATCH] qrtr: Convert qrtr_ports from IDR to XArray

2021-03-30 Thread Bjorn Andersson
On Tue 30 Mar 13:04 CDT 2021, Manivannan Sadhasivam wrote: > On Fri, Jun 05, 2020 at 05:00:37AM -0700, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > The XArray interface is easier for this driver to use. Also fixes a > > bug reported by the improper use of GFP_ATOMIC. > > >

Re: [PATCH v2] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS

2021-04-02 Thread Bjorn Andersson
On Mon 15 Mar 11:16 CDT 2021, Alex Elder wrote: > On 3/15/21 10:46 AM, Bjorn Andersson wrote: > > Parse and pass IFLA_RMNET_FLAGS to the kernel, to allow changing the > > flags from the default of ingress-aggregate only. > > To be clear, this default is implemented in the

Re: [PATCH] [net-next] ipa: add remoteproc dependency

2021-01-26 Thread Bjorn Andersson
On Mon 25 Jan 05:35 CST 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compile-testing without CONFIG_REMOTEPROC results in a build failure: > > >>> referenced by ipa_main.c > >>> net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a > ld.lld: error: undefined symbol:

Re: Preemptible idr_alloc() in QRTR code

2021-01-27 Thread Bjorn Andersson
On Tue 26 Jan 10:21 CST 2021, Mark Rutland wrote: > On Tue, Jan 26, 2021 at 02:58:33PM +, Matthew Wilcox wrote: > > On Tue, Jan 26, 2021 at 10:47:34AM +, Mark Rutland wrote: > > > Hi, > > > > > > When fuzzing arm64 with Syzkaller, I'm seeing some splats where > > > this_cpu_ptr() is used

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-27 Thread Bjorn Andersson
On Wed 27 Jan 09:15 CST 2021, Greg KH wrote: > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > Hi Greg, > > > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > > This patch series adds support for UCI driver. UCI driver enables > > > userspace > > > c

Re: [PATCH net-next 1/6] net: qualcomm: rmnet: mark trailer field endianness

2021-03-04 Thread Bjorn Andersson
ways assumed to be zero, and the length is > taken from the other packet headers. So making these fields > explicitly big endian has no effect on the behavior of the code. > > Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > include/linux/if_rmne

Re: [PATCH net-next 2/6] net: qualcomm: rmnet: simplify some byte order logic

2021-03-04 Thread Bjorn Andersson
art_offset = htons(offset); > > - offset = htons((__force u16)(skb_transport_header(skb) - Just curious, why does this require a __force, or even a cast? Regardless, your proposed way of writing it is easier to read. Reviewed-by: Bjorn Andersson Regards, Bjorn > -

Re: [PATCH net-next 3/6] net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros

2021-03-04 Thread Bjorn Andersson
al > variable of the map header pointer type to the socket buffer data > pointer, and derereference that pointer variable. > > In "rmnet_map_data.c", use sizeof(object) rather than sizeof(type) > in one spot. Also,there's no need to byte swap 0; it's all zeros >

Re: [PATCH net-next 4/6] net: qualcomm: rmnet: use field masks instead of C bit-fields

2021-03-04 Thread Bjorn Andersson
use the functions defined in , > along with field mask constants to extract or assign values within > that field. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Alex Elder > --- > .../ethernet/qualcomm/rmnet/rmnet_handlers.c | 5 ++-- > .../ethe

Re: [PATCH net-next 5/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > Replace the use of C bit-fields in the rmnet_map_dl_csum_trailer > structure with a single one-byte field, using constant field masks > to encode or get at embedded values. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Sign

Re: [PATCH net-next 6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > Replace the use of C bit-fields in the rmnet_map_ul_csum_header > structure with a single two-byte (big endian) structure member, > and use field masks to encode or get values within it. > > Previously rmnet_map_ipv4_ul_csum_header() would update

[PATCH 1/5] dt-bindings: soc: qcom: wcnss: Add firmware-name property

2021-03-11 Thread Bjorn Andersson
The WCNSS needs firmware which differs between platforms, and possibly boards. Add a new property "firmware-name" to allow the DT to specify the platform/board specific path to this firmware file. Signed-off-by: Bjorn Andersson --- Documentation/devicetree/bindings/soc/qcom/qcom,wcn

[PATCH 2/5] wcn36xx: Allow firmware name to be overridden by DT

2021-03-11 Thread Bjorn Andersson
upload this blob, so rather than specifying the same information in both nodes wcn36xx reads the string from the parent's of_node. Signed-off-by: Bjorn Andersson --- This patch can be applied independently of the others, but relates to the acceptance of the addition to the DT binding (in patc

[PATCH 4/5] soc: qcom: wcnss_ctrl: Allow reading firmware-name from DT

2021-03-11 Thread Bjorn Andersson
the old filename if the property isn't specified. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/wcnss_ctrl.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wcnss_ctrl.c index 358526b9de06..2a06d631e415 1

[PATCH 5/5] arm64: dts: qcom: msm8916: Enable modem and WiFi

2021-03-11 Thread Bjorn Andersson
Enable the modem and WiFi subsystems and specify msm8916 specific firmware path for these and the WCNSS control service. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- 2 files changed, 13

[PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT

2021-03-11 Thread Bjorn Andersson
The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others needs platform-, and perhaps even board-, specific firmware. Add support for providing this in devicetree. Bjorn Andersson (5): dt-bindings: soc: qcom: wcnss: Add firmware-name property wcn36xx: Allow firmware name to

[PATCH 3/5] soc: qcom: wcnss_ctrl: Introduce local variable "dev"

2021-03-11 Thread Bjorn Andersson
Introduce a local variable to carry the struct device *, to reduce the line lengths in the next patch. Signed-off-by: Bjorn Andersson --- drivers/soc/qcom/wcnss_ctrl.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom

Re: [PATCH net] net: ipa: terminate message handler arrays

2021-03-12 Thread Bjorn Andersson
; > Fix this bug, by properly terminating the message handler arrays > provided when QMI handles are set up by the IPA driver. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Fixes: 530f9216a9537 ("soc: qcom: ipa: AP/modem communications") > Reported-by: Sujit Kautkar > Sig

[PATCH] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS

2021-03-12 Thread Bjorn Andersson
Parse and pass IFLA_RMNET_FLAGS to the kernel, to allow changing the flags from the default of ingress-aggregate only. Signed-off-by: Bjorn Andersson --- ip/iplink_rmnet.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/ip/iplink_rmnet.c b/ip

Re: [PATCH] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS

2021-03-15 Thread Bjorn Andersson
On Mon 15 Mar 09:23 CDT 2021, Daniele Palmas wrote: > Hi Bjorn, > > Il giorno sab 13 mar 2021 alle ore 01:02 Bjorn Andersson > ha scritto: > > > > Parse and pass IFLA_RMNET_FLAGS to the kernel, to allow changing the > > flags from the default of ingress-aggrega

[PATCH v2] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS

2021-03-15 Thread Bjorn Andersson
Parse and pass IFLA_RMNET_FLAGS to the kernel, to allow changing the flags from the default of ingress-aggregate only. Signed-off-by: Bjorn Andersson --- Changes since v1: - s/ifla_vlan_flags/ifla_rmnet_flags/ in print_opt ip/iplink_rmnet.c | 42 ++ 1

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Bjorn Andersson
On Wed 03 Feb 12:05 CST 2021, Jakub Kicinski wrote: > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > >> Jakub, Dave, Adding you both to get your reviews on this series. I've > > >> provided an explanation above and in the previous iteration [1]. > > > > > >Let's be clear wha

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-03 Thread Bjorn Andersson
On Wed 03 Feb 12:40 CST 2021, Jakub Kicinski wrote: > On Wed, 3 Feb 2021 19:28:28 +0100 Loic Poulain wrote: > > On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote: > > > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > > > The current patchset only supports QMI channel so I'd

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2021-02-08 Thread Bjorn Andersson
On Mon 08 Feb 11:21 CST 2021, Kalle Valo wrote: > Amit Pundir writes: > > > Hi Kalle, > > > > On Mon, 7 Dec 2020 at 22:25, Kalle Valo wrote: > >> > >> This is firmware version specific, right? There's also enum > >> ath10k_fw_features which is embedded within firmware-N.bin, we could add > >> a

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-10 Thread Bjorn Andersson
On Wed 10 Feb 12:41 CST 2021, Jakub Kicinski wrote: > On Wed, 10 Feb 2021 11:55:31 +0530 Manivannan Sadhasivam wrote: > > On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > > > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > > > This may be a stupid suggestion, but

Re: [PATCH 5/5] arm64: dts: qcom: msm8916: Enable modem and WiFi

2021-03-18 Thread Bjorn Andersson
On Mon 15 Mar 07:01 CDT 2021, Bryan O'Donoghue wrote: > On 12/03/2021 00:33, Bjorn Andersson wrote: > > Enable the modem and WiFi subsystems and specify msm8916 specific > > firmware path for these and the WCNSS control service. > > > > Signed-off-by: Bjorn And

Re: [PATCH 0/5] qcom: wcnss: Allow overriding firmware form DT

2021-03-18 Thread Bjorn Andersson
On Thu 18 Mar 11:56 CDT 2021, Jeffrey Hugo wrote: > form -> from in the subject? > Seems like I only failed in the cover letter, right? Regards, Bjorn > On Thu, Mar 11, 2021 at 5:34 PM Bjorn Andersson > wrote: > > > > The wireless subsystem found in Qualcomm MSM89

[PATCH] net: qrtr: Expose tunneling endpoint to user space

2018-04-18 Thread Bjorn Andersson
r USB link. Signed-off-by: Bjorn Andersson --- net/qrtr/Kconfig | 7 +++ net/qrtr/Makefile | 2 + net/qrtr/tun.c| 162 ++ 3 files changed, 171 insertions(+) create mode 100644 net/qrtr/tun.c diff --git a/net/qrtr/Kconfig b/net/qrtr/Kco

[PATCH v2] net: qrtr: Expose tunneling endpoint to user space

2018-04-23 Thread Bjorn Andersson
r USB link. Signed-off-by: Bjorn Andersson --- Changes since v1: - Dropped queue lock net/qrtr/Kconfig | 7 +++ net/qrtr/Makefile | 2 + net/qrtr/tun.c| 146 ++ 3 files changed, 155 insertions(+) create mode 100644 net/qrtr/tun.c di

[PATCH v3] net: qrtr: Expose tunneling endpoint to user space

2018-04-26 Thread Bjorn Andersson
r USB link. Signed-off-by: Bjorn Andersson --- Changes since v2: - Add support for read poll Changes since v1: - Dropped queue lock net/qrtr/Kconfig | 7 +++ net/qrtr/Makefile | 2 + net/qrtr/tun.c| 161 ++ 3 files changed, 170

Re: [PATCH] net: dsa: Implement flow_dissect callback for tag_qca

2019-03-26 Thread Bjorn Andersson
On Tue 26 Mar 18:32 PDT 2019, xiaofeis wrote: > Add flow_dissect for qca tagged packet to get the right hash. > > Signed-off-by: xiaofeis Hi Xiaofei, Please use your full name (first and last) both as author and in the signed-off tag. Regards, Bjorn > --- > net/dsa/tag_qca.c | 10 ++

Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header

2019-05-20 Thread Bjorn Andersson
hese struct members. > Upcoming patches will reimplement these definitions portably. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Alex Elder > --- > drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

[RESEND PATCH 7/7] net: qrtr: Support decoding incoming v2 packets

2017-10-04 Thread Bjorn Andersson
Add the necessary logic for decoding incoming messages of version 2 as well. Also make sure there's room for the bigger of version 1 and 2 headers in the code allocating skbs for outgoing messages. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c

[RESEND PATCH 6/7] net: qrtr: Use sk_buff->cb in receive path

2017-10-04 Thread Bjorn Andersson
ned-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 70 - 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index a84edba7b1ef..7bca6ec892a5 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -4

[RESEND PATCH 5/7] net: qrtr: Clean up control packet handling

2017-10-04 Thread Bjorn Andersson
that these functions can be folded back into the callers. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 93 ++--- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 82dc83789310

[RESEND PATCH 3/7] net: qrtr: Add control packet definition to uapi

2017-10-04 Thread Bjorn Andersson
-off-by: Bjorn Andersson --- include/uapi/linux/qrtr.h | 32 net/qrtr/qrtr.c | 12 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/include/uapi/linux/qrtr.h b/include/uapi/linux/qrtr.h index 63e8803e4d90..179af64846e0 100644

[RESEND PATCH 2/7] net: qrtr: Move constants to header file

2017-10-04 Thread Bjorn Andersson
The constants are used by both the name server and clients, so clarify their value and move them to the uapi header. Signed-off-by: Bjorn Andersson --- include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include

[RESEND PATCH 4/7] net: qrtr: Pass source and destination to enqueue functions

2017-10-04 Thread Bjorn Andersson
eader just to decode it immediately in qrtr_local_enqueue(). In the future this change also makes it possible to prepend message headers based on the version of each link. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 120 1 file ch

[RESEND PATCH 0/7] net: qrtr: Fixes and support receiving version 2 packets

2017-10-04 Thread Bjorn Andersson
packets continues to be send as version 1, but some groundwork has been done to make this a per-link property. Bjorn Andersson (7): net: qrtr: Invoke sk_error_report() after setting sk_err net: qrtr: Move constants to header file net: qrtr: Add control packet definition to uapi net: qrtr

[RESEND PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err

2017-10-04 Thread Bjorn Andersson
Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notification with its own callback. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 2 +- 1 file

[PATCH v2 6/7] net: qrtr: Use sk_buff->cb in receive path

2017-10-10 Thread Bjorn Andersson
ned-off-by: Bjorn Andersson --- Changes since v1: - None net/qrtr/qrtr.c | 70 - 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index a84edba7b1ef..7bca6ec892a5 100644 --- a/net/qrtr/qrtr.c

[PATCH v2 7/7] net: qrtr: Support decoding incoming v2 packets

2017-10-10 Thread Bjorn Andersson
Add the necessary logic for decoding incoming messages of version 2 as well. Also make sure there's room for the bigger of version 1 and 2 headers in the code allocating skbs for outgoing messages. Signed-off-by: Bjorn Andersson --- Changes since v1: - Dropped __packed from struct qrtr_h

[PATCH v2 5/7] net: qrtr: Clean up control packet handling

2017-10-10 Thread Bjorn Andersson
that these functions can be folded back into the callers. Signed-off-by: Bjorn Andersson --- Changes since v1: - None net/qrtr/qrtr.c | 93 ++--- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c

[PATCH v2 3/7] net: qrtr: Add control packet definition to uapi

2017-10-10 Thread Bjorn Andersson
-off-by: Bjorn Andersson --- Changes since v1: - None include/uapi/linux/qrtr.h | 32 net/qrtr/qrtr.c | 12 2 files changed, 32 insertions(+), 12 deletions(-) diff --git a/include/uapi/linux/qrtr.h b/include/uapi/linux/qrtr.h index

[PATCH v2 2/7] net: qrtr: Move constants to header file

2017-10-10 Thread Bjorn Andersson
The constants are used by both the name server and clients, so clarify their value and move them to the uapi header. Signed-off-by: Bjorn Andersson --- Changes since v1: - None include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions

[PATCH v2 0/7] net: qrtr: Fixes and support receiving version 2 packets

2017-10-10 Thread Bjorn Andersson
packets continues to be send as version 1, but some groundwork has been done to make this a per-link property. Bjorn Andersson (7): net: qrtr: Invoke sk_error_report() after setting sk_err net: qrtr: Move constants to header file net: qrtr: Add control packet definition to uapi net: qrtr

[PATCH v2 4/7] net: qrtr: Pass source and destination to enqueue functions

2017-10-10 Thread Bjorn Andersson
eader just to decode it immediately in qrtr_local_enqueue(). In the future this change also makes it possible to prepend message headers based on the version of each link. Signed-off-by: Bjorn Andersson --- Changes since v1: - None net/qrtr/qrtr.c

[PATCH v2 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err

2017-10-10 Thread Bjorn Andersson
Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notification with its own callback. Signed-off-by: Bjorn Andersson --- Changes since v1: - None net/qrtr

Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed

2017-10-10 Thread Bjorn Andersson
fc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration") > Signed-off-by: Jia-Ju Bai Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/net/wireless/ath/wcn36xx/main.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireles

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

2017-12-26 Thread Bjorn Andersson
On Tue 19 Dec 09:04 PST 2017, Colin King wrote: > From: Colin Ian King > > msg_body.min_ch_time is being assigned twice; remove the redundant > first assignment. > > Detected by CoverityScan, CID#1463042 ("Unused Value") > Happy to see Coverity working for us :) This should have had a: Fix

Re: [PATCH][V2] wcn36xx: fix incorrect assignment to msg_body.min_ch_time

2018-01-04 Thread Bjorn Andersson
On Fri 29 Dec 01:07 PST 2017, Colin King wrote: > From: Colin Ian King > > The second assignment to msg_body.min_ch_time is incorrect, it > should actually be to msg_body.max_ch_time. > > Thanks to Bjorn Andersson for identifying the correct way to fix > this as my origi

[PATCH] brcmfmac: Make sure CLM downloading is optional

2018-01-15 Thread Bjorn Andersson
message before returning. Fixes: fdd0bd88ceae ("brcmfmac: add CLM download support") Cc: sta...@vger.kernel.org Signed-off-by: Bjorn Andersson --- This regression was introduced in v4.15-rc1, but I unfortunately didn't test WiFi until now. Included a Cc to stable@ in case you choose

Re: [PATCH] brcmfmac: Make sure CLM downloading is optional

2018-01-15 Thread Bjorn Andersson
On Mon 15 Jan 11:40 PST 2018, Arend van Spriel wrote: > On 1/15/2018 6:10 PM, Bjorn Andersson wrote: > > The presence of a CLM file is described as optional, but missing the clm > > blob causes the preinit to return unsuccessfully. Fix this by ignoring > > th

[PATCH] net: usb: ax88179_178a: Implement ethtool_ops set_eeprom

2020-04-28 Thread Bjorn Andersson
entation is based on asix_set_eeprom(), from asix_common.c Signed-off-by: Bjorn Andersson --- drivers/net/usb/ax88179_178a.c | 77 ++ 1 file changed, 77 insertions(+) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 93044cf1417a..b05bb

Re: [PATCH net 1/2] net: qrtr: check skb_put_padto() return value

2020-09-09 Thread Bjorn Andersson
; The buggy address is located 0 bytes inside of > 224-byte region [88804d8ab3c0, 88804d8ab4a0) > The buggy address belongs to the page: > page:ea8cccfb refcount:1 mapcount:0 mapping: > index:0x88804d8abb40 pfn:0x4d8ab > flags: 0xfffe000

Re: [PATCH net-next v2 3/7] net: ipa: verify reference flag values

2020-09-12 Thread Bjorn Andersson
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote: > We take a single IPA clock reference to keep the clock running until > we get a system suspend operation, and maintain a flag indicating > whether that reference has been taken. When a suspend request > arrives, we drop that reference and clear th

Re: [PATCH net-next v2 5/7] net: ipa: use device_init_wakeup()

2020-09-12 Thread Bjorn Andersson
> > When we receive a SUSPEND interrupt, call pm_wakeup_dev_event() > with a zero processing time, to simply call for a resume without > any other processing. The ipa_resume() call will take care of > waking things up again, and will handle receiving the packet. > Reviewed-by: Bj

Re: [PATCH net-next v2 4/7] net: ipa: manage endpoints separate from clock

2020-09-12 Thread Bjorn Andersson
a system resume. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Alex Elder > --- > drivers/net/ipa/ipa_clock.c | 14 -- > drivers/net/ipa/ipa_main.c | 8 > 2 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/n

Re: [PATCH net-next v2 6/7] net: ipa: enable wakeup on IPA interrupt

2020-09-12 Thread Bjorn Andersson
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote: > Now that we handle wakeup interrupts properly, arrange for the IPA > interrupt to be treated as a wakeup interrupt. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > drivers/net/ipa/ipa_interrupt.c | 14 +

Re: [PATCH net-next v2 7/7] net: ipa: do not enable GSI interrupt for wakeup

2020-09-12 Thread Bjorn Andersson
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote: > We now trigger a system resume when we receive an IPA SUSPEND > interrupt. We should *not* wake up on GSI interrupts. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > drivers/net/ipa/gsi.c | 17 --

Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

2020-07-27 Thread Bjorn Andersson
On Mon 27 Jul 08:03 PDT 2020, ? wrote: > Currently the qmi_handle is initialized single threaded and strictly > ordered with the active set to 1. This is pretty simple and safe but > sometimes ineffency. So it is better to allow user to decide whether > a high priority workqueue should be

Re: [PATCH 1/2] net: ipa: new notification infrastructure

2020-07-24 Thread Bjorn Andersson
me available. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > David: If you approve, please only ACK; Bjorn will merge. > David, this depends on changes I carry in the rproc-next tree, so if you're okay with it I can pick this patch through my tree. Othe

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-17 Thread Bjorn Andersson
On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. >

Re: [PATCH] net: qrtr: Fix port ID for control messages

2020-09-24 Thread Bjorn Andersson
On Thu 24 Sep 04:53 CDT 2020, Loic Poulain wrote: > The port ID for control messages was uncorrectly set with broadcast > node ID value, causing message to be dropped on remote side since > not passing packet filtering (cb->dst_port != QRTR_PORT_CTRL). > This does indeed make more sense. Unfortu

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-25 Thread Bjorn Andersson
On Mon 21 Sep 05:38 CDT 2020, Amit Pundir wrote: > On Thu, 17 Sep 2020 at 21:35, Bjorn Andersson > wrote: > > > > On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > > > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > > phone. We get a

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-25 Thread Bjorn Andersson
On Thu 24 Sep 11:31 CDT 2020, Kalle Valo wrote: > Amit Pundir writes: > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > > message in ath10k_qmi_host_cap_send_sync(), but we can still > > bring up WiFi services successf

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-25 Thread Bjorn Andersson
QMI request for the firmware versions which do not support this > feature. > > Suggested-by: Bjorn Andersson > Signed-off-by: Amit Pundir > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.txt| 5 + > drivers/net/wireless/ath/ath10k/qmi.c

Re: [PATCH 1/2] net: qrtr: Allow forwarded services

2020-09-29 Thread Bjorn Andersson
> Signed-off-by: Loic Poulain Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > net/qrtr/ns.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c > index d8252fd..d542d8f 100644 > --- a/net/qrtr/ns.c > +++ b/net/q

Re: [PATCH 2/2] net: qrtr: Allow non-immediate node routing

2020-09-29 Thread Bjorn Andersson
orwards node3 service to node1 > - node1 must save node2 as route for reaching node3 > > Signed-off-by: Loic Poulain Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > net/qrtr/qrtr.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH v3] wcn36xx: Set default BTLE coexistence config

2017-11-15 Thread Bjorn Andersson
On Mon 13 Nov 23:23 PST 2017, Ramon Fried wrote: > From: Eyal Ilsar > > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active > WLAN gets 0 bandwidth.

Re: [PATCH v4] wcn36xx: Set default BTLE coexistence config

2017-11-16 Thread Bjorn Andersson
> Signed-off-by: Eyal Ilsar > Signed-off-by: Ramon Fried Looks good, Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/net/wireless/ath/wcn36xx/smd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c > b/driver

Re: [PATCH] net: qrtr: Allocate workqueue before kernel_bind

2020-05-28 Thread Bjorn Andersson
k and workqueue structs are > allocated and initialized before qrtr_ns_data_ready can be called. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from > userspace") > Signed-off-by: Chris Lew > --- > net

Re: [PATCH] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()

2020-05-19 Thread Bjorn Andersson
; eventhough the object is not used. > > So fix this by passing NULL to qrtr_local_enqueue(). > > Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") > Reported-by: kbuild test robot > Reported-by: Julia Lawall Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH net-next v2 3/4] net: ipa: define IMEM memory region for IPA

2020-05-04 Thread Bjorn Andersson
On Mon 04 May 10:58 PDT 2020, Alex Elder wrote: > Define a region of IMEM memory available for use by IPA in the > platform configuration data. Initialize it from ipa_mem_init(). > The memory must be mapped for access through an SMMU. > Reviewed-by: Bjorn Andersson Regards, Bjo

Re: [PATCH net-next v2 1/4] dt-bindings: net: add IPA iommus property

2020-05-04 Thread Bjorn Andersson
- iommus This technically "breaks" backwards compatibility, but the binding is rather new and in limited use, so I think we should do this. Reviewed-by: Bjorn Andersson Regards, Bjorn >- reg >- clocks >- interrupts > @@ -164,6 +171,7 @@ examples: >

Re: [PATCH net-next v2 2/4] net: ipa: redefine struct ipa_mem_data

2020-05-04 Thread Bjorn Andersson
scriptors along with the count of entries in that > array. Pass just an ipa_mem structure pointer to ipa_mem_init(). > > Rename the ipa_mem_data[] array ipa_mem_local_data[] to emphasize > that the memory regions it defines are IPA-local memory. > > Signed-off-by: Alex Elder Revie

Re: [PATCH] wcn36xx: Fix error handling path in 'wcn36xx_probe()'

2020-05-06 Thread Bjorn Andersson
nt drivers from smd to > rpmsg") It seems I introduced this bug in f303a9311065 ("wcn36xx: Transition driver to SMD client"), but your patch should should apply back to your Fixes, so I think it's good. Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Christo

[PATCH] qrtr: Move to postcore_initcall

2017-11-06 Thread Bjorn Andersson
Registering qrtr with module_init makes the ability of typical platform code to create AF_QIPCRTR socket during probe a matter of link order luck. Moving qrtr to postcore_initcall() avoids this. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults

2017-11-13 Thread Bjorn Andersson
On Sun 12 Nov 06:21 PST 2017, Ramon Fried wrote: > From: Eyal Ilsar > > If the value for the firmware configuration parameters BTC_STATIC_LEN_LE_BT > and BTC_STATIC_LEN_LE_WLAN are not set the duty cycle between BT and WLAN > is such that if BT (including BLE) is active WLAN gets 0 bandwidth. >

[PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Bjorn Andersson
From: Loic Poulain Bluetooth BD address can be retrieved in the same way as for wcnss-wlan MAC address. This patch mainly stores the local-mac-address property and sets the BD address during hci device setup. Signed-off-by: Loic Poulain Signed-off-by: Bjorn Andersson --- drivers/bluetooth

[PATCH 0/2] btqcomsmd: Allow specifying board mac address

2017-09-01 Thread Bjorn Andersson
The btqcomsmd hardware lacks persistent storage of its mac address, so this needs to be configured during initialization. The second patch in this series reads the mac address from DT and does this, allowing the boot loader to populate this board specific information. Loic Poulain (2): Bluetooth

[PATCH 1/2] Bluetooth: make baswap src const

2017-09-01 Thread Bjorn Andersson
From: Loic Poulain Signed-off-by: Loic Poulain Signed-off-by: Bjorn Andersson --- include/net/bluetooth/bluetooth.h | 2 +- net/bluetooth/lib.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth

Re: [PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-01 Thread Bjorn Andersson
setup. > > > > Signed-off-by: Loic Poulain > > Signed-off-by: Bjorn Andersson > > --- > > drivers/bluetooth/btqcomsmd.c | 28 > > 1 file changed, 28 insertions(+) > > > > diff --git a/drivers/bluetooth/btqcomsmd

Re: [PATCH 2/2] Bluetooth: btqcomsmd: BD address setup

2017-09-03 Thread Bjorn Andersson
e BD address during > >>> hci device setup. > >>> > >>> Signed-off-by: Loic Poulain > >>> Signed-off-by: Bjorn Andersson > >>> --- > >>> drivers/bluetooth/btqcomsmd.c | 28 > >>> 1 file changed, 28

[PATCH 5/7] net: qrtr: Clean up control packet handling

2017-09-06 Thread Bjorn Andersson
that these functions can be folded back into the callers. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 93 ++--- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index bcec2432b833

[PATCH 6/7] net: qrtr: Use sk_buff->cb in receive path

2017-09-06 Thread Bjorn Andersson
ned-off-by: Bjorn Andersson --- net/qrtr/qrtr.c | 70 - 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index f28ecd7d735b..5042999756ce 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -4

[PATCH 7/7] net: qrtr: Support decoding incoming v2 packets

2017-09-06 Thread Bjorn Andersson
Add the necessary logic for decoding incoming messages of version 2 as well. Also make sure there's room for the bigger of version 1 and 2 headers in the code allocating skbs for outgoing messages. Signed-off-by: Bjorn Andersson --- net/qrtr/qrtr.c

[PATCH 2/7] net: qrtr: Move constants to header file

2017-09-06 Thread Bjorn Andersson
The constants are used by both the name server and clients, so clarify their value and move them to the uapi header. Signed-off-by: Bjorn Andersson --- include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include

  1   2   3   >