Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

On Mon, Jan 11, 2021 at 02:54:06PM +0100, Ahmed S. Darwish wrote: > Hi, > > On Tue, Dec 22, 2020 at 10:03:37AM +0100, Ahmed S. Darwish wrote: > ... > > > > Included is an RFC patch to fix the points above: if the RESET flag is > > encountered, a workqueue is sche

[RFC PATCH 0/1] net: arcnet: Fix RESET sequence

k drivers/net/arcnet/com20020.c. Included is an RFC patch to fix the points above: if the RESET flag is encountered, a workqueue is scheduled to run the generic reset sequence. Note: Only compile-tested, as I do not have the hardware in question. Thanks, 8<------ Ahmed S. Darwish (1): net:

[RFC PATCH 1/1] net: arcnet: Fix RESET flag handling

heck drivers/net/arcnet/com20020.c. Run the device RESET sequence from a scheduled workqueue instead. Signed-off-by: Ahmed S. Darwish --- drivers/net/arcnet/arc-rimi.c | 4 +- drivers/net/arcnet/arcdevice.h| 6 +++ drivers/net/arcnet/arcnet.c | 69

[RFC PATCH 0/3] chelsio: cxgb: Use threaded irqs

vings across the driver, as some workqueues and spinlocks are no longer needed. Note: Only compile-tested. I do not have the hardware in question. Thanks, 8<-- Ahmed S. Darwish (3): chelsio: cxgb: Remove ndo_poll_controller() chelsio: cxgb: Move slow interrupt handling to th

[RFC PATCH 2/3] chelsio: cxgb: Move slow interrupt handling to threaded irqs

) on a timer it has already interrupted, it will loop forever. Move the slow t1 interrupt handling path, t1_slow_intr_handler(), to a threaded-irq task context. Signed-off-by: Ahmed S. Darwish --- drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 6 +++--- drivers/net/ethernet/chelsio/cxgb/sge.c | 13

[RFC PATCH 3/3] chelsio: cxgb: Do not schedule a workqueue for external interrupts

er. Remove all the workqueue code that is now no longer needed, including the spinlock used for synchronizing the workqueue's NIC regsiters access against the irq handler. Signed-off-by: Ahmed S. Darwish --- drivers/net/ethernet/chelsio/cxgb/common.h | 2 -- drivers/net/ethernet/chelsi

[RFC PATCH 1/3] chelsio: cxgb: Remove ndo_poll_controller()

ndo_poll_controller(). Link: https://lkml.kernel.org/r/20180921222752.101307-1-eduma...@google.com Link: https://lkml.kernel.org/r/a782704a-df97-4e85-b10a-d2268a67d...@fb.com References: 822d54b9c2c1 ("netpoll: Drop budget parameter from NAPI polling call hierarchy") Signed-off-by: Ahme

Re: [RFC PATCH 1/3] chelsio: cxgb: Remove ndo_poll_controller()

[[ Actually adding Eric to Cc ]] On Thu, Dec 24, 2020 at 02:11:46PM +0100, Ahmed S. Darwish wrote: > Since commit ac3d9dd034e5 ("netpoll: make ndo_poll_controller() > optional"), networking drivers which use NAPI for clearing their TX > completions should not provide an

Re: [RFC PATCH 0/1] net: arcnet: Fix RESET sequence

Hi, On Tue, Dec 22, 2020 at 10:03:37AM +0100, Ahmed S. Darwish wrote: ... > > Included is an RFC patch to fix the points above: if the RESET flag is > encountered, a workqueue is scheduled to run the generic reset sequence. > ... Kind reminder.

[PATCH v2] net: arcnet: Fix RESET flag handling

heck drivers/net/arcnet/com20020.c. Run the device RESET sequence from a scheduled workqueue instead. Signed-off-by: Ahmed S. Darwish Signed-off-by: Sebastian Andrzej Siewior --- Changelog-v2: - Fix com20020-isa.c compilation error: s/free_ardev()/free_arcdev()/ - Compile-test with an ARCH=i

Re: seqlock lockdep false positives?

Hi Jakub, On Wed, Mar 03, 2021 at 04:40:35PM -0800, Jakub Kicinski wrote: > Hi Ahmed! > > Erhard is reporting a lockdep splat in drivers/net/ethernet/realtek/8139too.c > > https://bugzilla.kernel.org/show_bug.cgi?id=211575 > > I can't quite grasp how that happens it looks like it's the Rx > lock/s

[PATCH v1 0/2] net: xfrm: Use seqcount_spinlock_t

med S. Darwish (2): net: xfrm: Localize sequence counter per network namespace net: xfrm: Use sequence counter with associated spinlock include/net/netns/xfrm.h | 4 +++- net/xfrm/xfrm_state.c| 11 ++- 2 files changed, 9 insertions(+), 6 deletions(-) base-com

[PATCH v1 1/2] net: xfrm: Localize sequence counter per network namespace

ta type from seqcount_t to seqcount_LOCKNAME_t in further commits. Fixes: b65e3d7be06f ("xfrm: state: add sequence count to detect hash resizes") Signed-off-by: Ahmed S. Darwish --- include/net/netns/xfrm.h | 4 +++- net/xfrm/xfrm_state.c| 10 +- 2 files changed, 8 insertio

[PATCH v1 2/2] net: xfrm: Use sequence counter with associated spinlock

neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish --- include/net/netns/xfrm.h | 2 +- net/xfrm/xfrm_state.c| 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/net/netns/xfrm.h b/include/net/netns/xfrm.h index b59d73d529ba..e816b6a3ef2b

Re: [PATCH 1/5] seqlock: s/__SEQ_LOCKDEP/__SEQ_LOCK/g

CKDEP > configs. > > Signed-off-by: Peter Zijlstra (Intel) > --- Acked-by: Ahmed S. Darwish

Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition

ation by a > + * spinlock. The spinlock is associated to the sequence count in the > + * static initializer or init function. This enables lockdep to validate > + * that the write side critical section is properly serialized. ditto, you forgot to change the associated spinlock language to

Re: [PATCH 5/5] seqcount: More consistent seqprop names

On Wed, Jul 29, 2020 at 03:52:54PM +0200, Peter Zijlstra wrote: > Attempt uniformity and brevity. > > Signed-off-by: Peter Zijlstra (Intel) > --- Acked-by: Ahmed S. Darwish

[PATCH v4 15/24] netfilter: nft_set_rbtree: Use sequence counter with associated rwlock

-by: Ahmed S. Darwish --- net/netfilter/nft_set_rbtree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index b6aad3fc46c3..4b2834fd17b2 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter

[PATCH v4 14/24] netfilter: conntrack: Use sequence counter with associated spinlock

. Signed-off-by: Ahmed S. Darwish --- include/net/netfilter/nf_conntrack.h | 2 +- net/netfilter/nf_conntrack_core.c| 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/net/netfilter/nf_conntrack.h b/include/net/netfilter/nf_conntrack.h index 90690e37a56f..ea4e2010b246

[PATCH v4 16/24] xfrm: policy: Use sequence counters with associated lock

for writer serialization is held when the write side critical section is entered. If lockdep is disabled this lock association is compiled out and has neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish --- net/xfrm/xfrm_policy.c | 10 +- 1 file changed, 5

[PATCH v4 00/24] seqlock: Extend seqcount API with associated locks

I explicit. - Make all documentation "RST-lite", for better readability from text editors. - Add additional clean-ups at the start of the series for better overall readability of seqlock.h code, and for future extensibility. Thanks, 8<------ Ahmed S. Darwish (24):

Re: [PATCH v4 00/24] seqlock: Extend seqcount API with associated locks

On Mon, Jul 20, 2020 at 09:49:12AM -0700, Eric Biggers wrote: > On Mon, Jul 20, 2020 at 05:55:06PM +0200, Ahmed S. Darwish wrote: > > Hi, > > > > This is v4 of the seqlock patch series: > > > >[PATCH v1 00/25] > > > > https://lore.k

[PATCH v3 00/20] seqlock: Extend seqcount API with associated locks

nt_t call-sites acked-by tags Thanks, 8<-- Ahmed S. Darwish (20): Documentation: locking: Describe seqlock design and usage seqlock: Properly format kernel-doc code samples seqlock: Add missing kernel-doc annotations lockdep: Add preemption enabled/disabled assertion AP

[PATCH v3 10/20] netfilter: conntrack: Use sequence counter with associated spinlock

. Signed-off-by: Ahmed S. Darwish --- include/net/netfilter/nf_conntrack.h | 2 +- net/netfilter/nf_conntrack_core.c| 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/net/netfilter/nf_conntrack.h b/include/net/netfilter/nf_conntrack.h index 90690e37a56f..ea4e2010b246

[PATCH v3 12/20] xfrm: policy: Use sequence counters with associated lock

for writer serialization is held when the write side critical section is entered. If lockdep is disabled this lock association is compiled out and has neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish --- net/xfrm/xfrm_policy.c | 10 +- 1 file changed, 5

[PATCH v3 11/20] netfilter: nft_set_rbtree: Use sequence counter with associated rwlock

-by: Ahmed S. Darwish --- net/netfilter/nft_set_rbtree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index 62f416bc0579..9f58261ee4c7 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

On Wed, May 20, 2020 at 05:51:27AM -0700, Eric Dumazet wrote: > > On 5/19/20 11:42 PM, Ahmed S. Darwish wrote: > > Hello Eric, > > > > On Tue, May 19, 2020 at 07:01:38PM -0700, Eric Dumazet wrote: > >> > >> On 5/19/20 2:45 PM, Ahmed S. Darwish wrot

[PATCH v2 1/6] net: core: device_rename: Use rwsem instead of a seqcount

orted-by: Dan Carpenter [ v1 missing up_read() on error exit ] Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- net/core/dev.c | 40 ++-- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index

[PATCH v2 2/6] net: phy: fixed_phy: Remove unused seqcount

ite side critical section -- neutralizing its read side retry loop. Remove the unused seqcount. Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- drivers/net/phy/fixed_phy.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/driv

[PATCH v2 3/6] u64_stats: Document writer non-preemptibility requirement

each bullet point, making it easier to follow which side each point is actually for. Clarify the statement "whole thing is a NOOP on 64bit arches or UP kernels". For 32-bit UP kernels, preemption is always disabled for the statistics read side section. Signed-off-by: Ahmed S. Darw

[PATCH v2 4/6] net: mdiobus: Disable preemption upon u64_stats update

is called from process context through mdiobus_read() and mdiobus_write(). Reported-by: kernel test robot Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- drivers/net/phy/mdio_bus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/mdio_bus.c b

[PATCH v2 09/18] netfilter: nft_set_rbtree: Use sequence counter with associated rwlock

-by: Ahmed S. Darwish --- net/netfilter/nft_set_rbtree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index 62f416bc0579..9f58261ee4c7 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter

[PATCH v2 08/18] netfilter: conntrack: Use sequence counter with associated spinlock

. Signed-off-by: Ahmed S. Darwish --- include/net/netfilter/nf_conntrack.h | 2 +- net/netfilter/nf_conntrack_core.c| 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/net/netfilter/nf_conntrack.h b/include/net/netfilter/nf_conntrack.h index 90690e37a56f..ea4e2010b246

[PATCH v2 00/18] seqlock: Extend seqcount API with associated locks

ll, and more concise. Thanks, 8<-- Ahmed S. Darwish (18): Documentation: locking: Describe seqlock design and usage seqlock: Properly format kernel-doc code samples seqlock: Add missing kernel-doc annotations seqlock: Extend seqcount API with associated locks dma-buf: Remo

[PATCH v2 10/18] xfrm: policy: Use sequence counters with associated lock

for writer serialization is held when the write side critical section is entered. If lockdep is disabled this lock association is compiled out and has neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish --- net/xfrm/xfrm_policy.c | 10 +- 1 file changed, 5

[PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

ith interface rename and netdev name retrieval.) Fixes: 30e6c9fa93cf (net: devnet_rename_seq should be a seqcount) Fixes: c91f6df2db49 (sockopt: Change getsockopt() of SO_BINDTODEVICE to return an interface name) Cc: Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- n

[PATCH v1 00/25] seqlock: Extend seqcount API with associated locks

to read_seqbegin_or_lock(). By using the lockdep debugging mechanisms added in this patch series, a number of erroneous seqcount call-sites were discovered across the kernel. The fixes are included at the beginning of the series. Thanks, 8<-- Ahmed S. Darwish (25): net: c

[PATCH v1 05/25] u64_stats: Document writer non-preemptibility requirement

ys disabled for the statistics read side section. Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- include/linux/u64_stats_sync.h | 38 ++ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/include/linux/u64_stats_sync.h b/

[PATCH v1 03/25] net: phy: fixed_phy: Remove unused seqcount

ite side critical section -- neutralizing its read side retry loop. Remove the unused seqcount. Signed-off-by: Ahmed S. Darwish Reviewed-by: Sebastian Andrzej Siewior --- drivers/net/phy/fixed_phy.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/driv

[PATCH v1 15/25] netfilter: conntrack: Use sequence counter with associated spinlock

. Signed-off-by: Ahmed S. Darwish --- include/net/netfilter/nf_conntrack.h | 2 +- net/netfilter/nf_conntrack_core.c| 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/net/netfilter/nf_conntrack.h b/include/net/netfilter/nf_conntrack.h index 9f551f3b69c6..333fd54aec30

[PATCH v1 16/25] netfilter: nft_set_rbtree: Use sequence counter with associated rwlock

-by: Ahmed S. Darwish --- net/netfilter/nft_set_rbtree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_set_rbtree.c b/net/netfilter/nft_set_rbtree.c index 3ffef454d469..f50d986d43c5 100644 --- a/net/netfilter/nft_set_rbtree.c +++ b/net/netfilter

[PATCH v1 17/25] xfrm: policy: Use sequence counters with associated lock

for writer serialization is held when the write side critical section is entered. If lockdep is disabled this lock association is compiled out and has neither storage size nor runtime overhead. Signed-off-by: Ahmed S. Darwish --- net/xfrm/xfrm_policy.c | 10 +- 1 file changed, 5

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

Hello Eric, On Tue, May 19, 2020 at 07:01:38PM -0700, Eric Dumazet wrote: > > On 5/19/20 2:45 PM, Ahmed S. Darwish wrote: > > Sequence counters write paths are critical sections that must never be > > preempted, and blocking, even for CONFIG_PREEMPTION=n, is not allow

Re: [PATCH v1 01/25] net: core: device_rename: Use rwsem instead of a seqcount

ct > net *net, char *name, int ifindex) > 5dbe7c178d3f0a4 Nicolas Schichan 2013-06-26 936 { > 5dbe7c178d3f0a4 Nicolas Schichan 2013-06-26 937 struct net_device *dev; > 5dbe7c178d3f0a4 Nicolas Schichan 2013-06-26 938 > 2354e271ada778b Ahmed S. Darwish 2020-0

Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote: > > From: Ahmed S. Darwish [mailto:[EMAIL PROTECTED] > > > > Hi, > > A kmalloc casting cleanup patch. > > Signed-off-by: Ahmed Darwish <[EMAIL PROTECTED]> [..] > > -

Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote: > > NACK about the 2 clean-ups above. Cast from pointer to integer is > required here. > Hi, here's the modified patch. A patch to switch kmalloc to kzalloc and clean some redundant kmalloc casts. Signed-off-by:

[PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers

+- zorro8390.c|2 +- 27 files changed, 50 insertions(+), 42 deletions(-) Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate

Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c index fb96c87..d21706e 100644 --- a/drivers/net

[PATCH 01/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- [PATCH 01/02] is compile tested. [PATCH 02/02] isn't compile tested cause of missing hard

[PATCH 2.6.20] ipw2100: Use ARRAY_SIZE macro when appropriate

Hi all, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c index b85857a..a9d944a 100644 --- a/drivers/net/wireless/ipw

[PATCH 02/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile-tested due to missing hardware. diff --git a/drivers/net/apne.c b/

[PATCH 2.6.20] misc-wireless: Use ARRAY_SIZE macro when appropriate

Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous wireless drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c

[PATCH 2.6.20] hostap: Use ARRAY_SIZE macro when appropriate

Hi, A patch to use ARRAY_SIZE macro in the Host AP wireless driver. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch is compile tested. diff --git a/drivers/net/wireless/hostap/hostap.h b/drivers/net/wireless/hostap/hostap.h index e89c890..ef37a75 100644 --- a/drivers/net/wi

[PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/drivers/net/ixgb/ixgb_param.c b/drivers/net/ixgb/ixgb_param.c index b27442a..26031fe 100644 --- a/drivers/net/ixgb/ixgb_param.c +++ b/drivers/ne

[PATCH 2.6.20] wavelan: Use ARRAY_SIZE macro when appropriate

Hi, A trivial patch to use ARRAY_SIZE macro. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- diff --git a/drivers/net/wireless/wavelan.p.h b/drivers/net/wireless/wavelan.p.h index 72b646c..fe12c77 100644 --- a/drivers/net/wireless/wavelan.p.h +++ b/drivers/net/wireless/wavel

[PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- Patch isn't compile-tested cause I don't have the needed hardware. diff --git a/drivers/net/ibm_emac/ibm_emac_debug.c b/drivers/net/ibm_emac/ibm_emac_debug

Re: [PATCH 2.6.20] wavelan: Use ARRAY_SIZE macro when appropriate

On Mon, Feb 05, 2007 at 11:17:09PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 05, 2007 at 07:00:44PM +0200, Ahmed S. Darwish wrote: > > A trivial patch to use ARRAY_SIZE macro. > > You're supposed to remove it ans use ARRAY_SIZE where old macro is used. > > &g

Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

On Mon, Feb 05, 2007 at 12:31:26PM -0800, Auke Kok wrote: > Alexey Dobriyan wrote: > >On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: > >>A patch to use ARRAY_SIZE macro already defined in kernel.h. > > > >Remove it and use ARRAY_SIZE instead.

Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

On Mon, Feb 05, 2007 at 11:22:06PM +0300, Alexey Dobriyan wrote: > On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote: > > A patch to use ARRAY_SIZE macro already defined in kernel.h. > > OK, but checks you're changing are strange. idx there is signed so >

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

rnal > + * transciever are really not going to work so don't let the > + * user select them. > + */ > + if (np->ignore_phy && (ecmd->autoneg == AUTONEG_ENABLE || A trivial comment actually, Is there a point to write multi-line comments in two d

Re: [PATCH] net: tun/tap: fixed hw address handling

c 2007-03-25 00:44:20.0 -0700 > @@ -18,6 +18,10 @@ > /* > * Changes: > * > + * Brian Braunstein <[EMAIL PROTECTED]> 2007/03/23 > + *Fixed hw address handling. Now net_device.dev_addr is kept > consistent Your mailer still wrap the long lines mistakenly as it did i

Re: [PATCH] net: tun/tap: fixed hw address handling

till wrap the long lines mistakenly as it did in the first > version of the patch. > It seems a bug in my mutt mail reader (not a feature, it displays other mails long lines without wrapping), sorry. -- Ahmed S. Darwish http://darwish.07.googlepages.com - To unsubscribe from this list

[PATCH BUGFIX 25-rc1] Smack: Don't fail against Nulled sk sockets

Hi!, Appropriately handle sockets with sk = NULL. This is usually the socket case when starting kernel nfsd. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Acked-by: Casey Schaufler <[EMAIL PROTECTED]> Tested-by: Joerg Platte <[EMAIL PROTECTED]> -- diff --git a/security/s