[PATCH net v2 1/2] virtio_net: fix possible dim status unrecoverable

2024-05-23 Thread Heng Qi
When the dim worker is scheduled, if it no longer needs to issue commands, dim may not be able to return to the working state later. For example, the following single queue scenario: 1. The dim worker of rxq0 is scheduled, and the dim status is changed to DIM_APPLY_NEW_PROFILE; 2. dim is

[PATCH net v2 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-23 Thread Heng Qi
This reverts commit 4d4ac2ececd3c42a08dd32a6e3a4aaf25f7efe44. When the following snippet is run, lockdep will report a deadlock[1]. /* Acquire all queues dim_locks */ for (i = 0; i < vi->max_queue_pairs; i++) mutex_lock(&vi->rq[i].dim_lock); There's no deadlock here because the vq

[PATCH net v2 0/2] virtio_net: fix lock warning and unrecoverable state

2024-05-23 Thread Heng Qi
Patch 1 describes and fixes an issue where dim cannot return to normal state in certain scenarios. Patch 2 attempts to resolve lockdep's complaints that holding many nested locks and when there is a maximum number of queues may also be problematic, so try to remove the dim_lock. Changelog ===

Re: How to implement message forwarding from one CID to another in vhost driver

2024-05-23 Thread Stefano Garzarella
On Tue, May 21, 2024 at 08:50:22AM GMT, Alexander Graf wrote: Howdy, On 20.05.24 14:44, Dorjoy Chowdhury wrote: Hey Stefano, Thanks for the reply. On Mon, May 20, 2024, 2:55 PM Stefano Garzarella wrote: Hi Dorjoy, On Sat, May 18, 2024 at 04:17:38PM GMT, Dorjoy Chowdhury wrote: Hi, Hope

Re: [PATCH net v2 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-23 Thread Jiri Pirko
Thu, May 23, 2024 at 09:46:51AM CEST, hen...@linux.alibaba.com wrote: >This reverts commit 4d4ac2ececd3c42a08dd32a6e3a4aaf25f7efe44. > >When the following snippet is run, lockdep will report a deadlock[1]. > > /* Acquire all queues dim_locks */ > for (i = 0; i < vi->max_queue_pairs; i++) >