Re: [PATCH net-next] virtio-net: synchronize operstate with admin state on up/down

2024-05-21 Thread Michael S. Tsirkin
On Mon, May 20, 2024 at 09:03:02AM +0800, Jason Wang wrote: > This patch synchronize operstate with admin state per RFC2863. > > This is done by trying to toggle the carrier upon open/close and > synchronize with the config change work. This allows propagate status > correctly to stacked devices l

Re: [PATCH net-next] virtio-net: synchronize operstate with admin state on up/down

2024-05-21 Thread Paolo Abeni
On Mon, 2024-05-20 at 09:03 +0800, Jason Wang wrote: > This patch synchronize operstate with admin state per RFC2863. > > This is done by trying to toggle the carrier upon open/close and > synchronize with the config change work. This allows propagate status > correctly to stacked devices like: >

[PATCH net 2/2] Revert "virtio_net: Add a lock for per queue RX coalesce"

2024-05-21 Thread Heng Qi
This reverts commit 4d4ac2ececd3c42a08dd32a6e3a4aaf25f7efe44. When the following snippet is run, lockdep will complain[1]. /* Acquire all queues dim_locks */ for (i = 0; i < vi->max_queue_pairs; i++) mutex_lock(&vi->rq[i].dim_lock); At the same time, too many queues will cause lock

[PATCH net 0/2] virtio_net: fix lock warning and unrecoverable state

2024-05-21 Thread Heng Qi
Patch 1 describes and fixes an issue where dim cannot return to normal state in certain scenarios. Patch 2 attempts to resolve lockdep's complaints that holding many nested locks and when there is a maximum number of queues may also be problematic, so try to remove the dim_lock. Heng Qi (2): vi

[PATCH net 1/2] virtio_net: fix possible dim status unrecoverable

2024-05-21 Thread Heng Qi
When the dim worker is scheduled, if it no longer needs to issue commands, dim may not be able to return to the working state later. For example, the following single queue scenario: 1. The dim worker of rxq0 is scheduled, and the dim status is changed to DIM_APPLY_NEW_PROFILE; 2. dim is