Re: [PATCH net-next v4 05/10] xsk: XDP_SETUP_XSK_POOL support option IFF_NOT_USE_DMA_ADDR

2021-04-14 Thread Magnus Karlsson
On Tue, Apr 13, 2021 at 9:58 AM Xuan Zhuo wrote: > > Some devices, such as virtio-net, do not directly use dma addr. These > devices do not initialize dma after completing the xsk setup, so the dma > check is skipped here. > > Signed-off-by: Xuan Zhuo > Reviewed-by: Dust Li Acked-by: Magnus Kar

Re: [PATCH net-next v4 04/10] xsk: support get page by addr

2021-04-14 Thread Magnus Karlsson
On Tue, Apr 13, 2021 at 9:58 AM Xuan Zhuo wrote: > > xsk adds an interface and returns the page corresponding to > data. virtio-net does not initialize dma, so it needs page to construct > scatterlist to pass to vring. > > Signed-off-by: Xuan Zhuo > Reviewed-by: Dust Li Acked-by: Magnus Karlsso

Re: [PATCH 0/4] CAN TRANSCEIVER: Add support for CAN transceivers

2021-04-14 Thread Marc Kleine-Budde
On 09.04.2021 19:10:50, Aswath Govindraju wrote: > The following series of patches add support for CAN transceivers. > > TCAN1042 has a standby signal that needs to be pulled high for > sending/receiving messages[1]. TCAN1043 has a enable signal along with > standby signal that needs to be pulled

[PATCH] atm: idt77252: remove unused function

2021-04-14 Thread Jiapeng Chong
Fix the following clang warning: drivers/atm/idt77252.c:1787:1: warning: unused function 'idt77252_fbq_level' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/atm/idt77252.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/atm/idt77252.c b/

Re: [PATCH] mac80211_hwsim: indicate support for 60GHz channels

2021-04-14 Thread Johannes Berg
On Mon, 2021-04-12 at 22:06 -0300, Ramon Fontes wrote: > Advertise 60GHz channels to mac80211. This is wrong. mac80211 doesn't support 60 GHz operation. johannes

Re: [PATCH v6 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Michael S. Tsirkin
On Wed, Mar 31, 2021 at 04:05:09PM +0800, Xie Yongji wrote: > This series introduces a framework, which can be used to implement > vDPA Devices in a userspace program. The work consist of two parts: > control path forwarding and data path offloading. > > In the control path, the VDUSE driver will

Re: [PATCH net-next v4 08/10] virtio-net: xsk zero copy xmit setup

2021-04-14 Thread Magnus Karlsson
On Tue, Apr 13, 2021 at 9:58 AM Xuan Zhuo wrote: > > xsk is a high-performance packet receiving and sending technology. > > This patch implements the binding and unbinding operations of xsk and > the virtio-net queue for xsk zero copy xmit. > > The xsk zero copy xmit depends on tx napi. So if tx n

[PATCH net] r8169: don't advertise pause in jumbo mode

2021-04-14 Thread Heiner Kallweit
It has been reported [0] that using pause frames in jumbo mode impacts performance. There's no available chip documentation, but vendor drivers r8168 and r8125 don't advertise pause in jumbo mode. So let's do the same, according to Roman it fixes the issue. [0] https://bugzilla.kernel.org/show_bug

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Thierry Reding
On Wed, Apr 14, 2021 at 02:18:58AM +, Joakim Zhang wrote: > > > -Original Message- > > From: Thierry Reding > > Sent: 2021年4月14日 0:07 > > To: David S. Miller ; Jakub Kicinski > > Cc: Joakim Zhang ; Jon Hunter > > ; Giuseppe Cavallaro ; > > Alexandre Torgue ; Jose Abreu > > ; netdev@v

[PATCH net 0/3] ibmvnic: correctly call NAPI APIs

2021-04-14 Thread Lijun Pan
This series correct some misuse of NAPI APIs in the driver. Lijun Pan (3): ibmvnic: avoid calling napi_disable() twice ibmvnic: remove duplicate napi_schedule call in do_reset function ibmvnic: remove duplicate napi_schedule call in open function drivers/net/ethernet/ibm/ibmvnic.c | 14 ++-

[PATCH net 1/3] ibmvnic: avoid calling napi_disable() twice

2021-04-14 Thread Lijun Pan
__ibmvnic_open calls napi_disable without checking whether NAPI polling has already been disabled or not. This could cause napi_disable being called twice, which could generate deadlock. For example, the first napi_disable will spin until NAPI_STATE_SCHED is cleared by napi_complete_done, then set

[PATCH net 2/3] ibmvnic: remove duplicate napi_schedule call in do_reset function

2021-04-14 Thread Lijun Pan
During adapter reset, do_reset/do_hard_reset calls ibmvnic_open(), which will calls napi_schedule if previous state is VNIC_CLOSED (i.e, the reset case, and "ifconfig down" case). So there is no need for do_reset to call napi_schedule again at the end of the function though napi_schedule will negle

[PATCH net 3/3] ibmvnic: remove duplicate napi_schedule call in open function

2021-04-14 Thread Lijun Pan
Remove the unnecessary napi_schedule() call in __ibmvnic_open() since interrupt_rx() calls napi_schedule_prep/__napi_schedule during every receive interrupt. Fixes: ed651a10875f ("ibmvnic: Updated reset handling") Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 5 - 1 file

Re: [PATCH net] r8169: don't advertise pause in jumbo mode

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 09:40:51AM +0200, Heiner Kallweit wrote: > It has been reported [0] that using pause frames in jumbo mode impacts > performance. There's no available chip documentation, but vendor > drivers r8168 and r8125 don't advertise pause in jumbo mode. So let's > do the same, accordi

Re: [PATCH v6 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Jason Wang
在 2021/4/14 下午3:34, Michael S. Tsirkin 写道: On Wed, Mar 31, 2021 at 04:05:09PM +0800, Xie Yongji wrote: This series introduces a framework, which can be used to implement vDPA Devices in a userspace program. The work consist of two parts: control path forwarding and data path offloading. In th

Re: [PATCH net-next v4 08/10] virtio-net: xsk zero copy xmit setup

2021-04-14 Thread Jason Wang
在 2021/4/14 下午3:36, Magnus Karlsson 写道: On Tue, Apr 13, 2021 at 9:58 AM Xuan Zhuo wrote: xsk is a high-performance packet receiving and sending technology. This patch implements the binding and unbinding operations of xsk and the virtio-net queue for xsk zero copy xmit. The xsk zero copy xm

Re: Re: [PATCH v6 00/10] Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Yongji Xie
On Wed, Apr 14, 2021 at 3:35 PM Michael S. Tsirkin wrote: > > On Wed, Mar 31, 2021 at 04:05:09PM +0800, Xie Yongji wrote: > > This series introduces a framework, which can be used to implement > > vDPA Devices in a userspace program. The work consist of two parts: > > control path forwarding and d

Re: [PATCH net] r8169: don't advertise pause in jumbo mode

2021-04-14 Thread Heiner Kallweit
On 14.04.2021 09:49, Greg KH wrote: > On Wed, Apr 14, 2021 at 09:40:51AM +0200, Heiner Kallweit wrote: >> It has been reported [0] that using pause frames in jumbo mode impacts >> performance. There's no available chip documentation, but vendor >> drivers r8168 and r8125 don't advertise pause in ju

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Joakim Zhang
> -Original Message- > From: Thierry Reding > Sent: 2021年4月14日 15:41 > To: Joakim Zhang > Cc: David S. Miller ; Jakub Kicinski ; > Jon Hunter ; Giuseppe Cavallaro > ; Alexandre Torgue ; > Jose Abreu ; netdev@vger.kernel.org; Linux Kernel > Mailing List ; linux-tegra > > Subject: Re: Reg

Re: [PATCH v8 bpf-next 09/14] bpd: add multi-buffer support to xdp copy helpers

2021-04-14 Thread Eelco Chaudron
On 8 Apr 2021, at 23:04, Vladimir Oltean wrote: On Thu, Apr 08, 2021 at 02:51:01PM +0200, Lorenzo Bianconi wrote: From: Eelco Chaudron This patch adds support for multi-buffer for the following helpers: - bpf_xdp_output() - bpf_perf_event_output() Signed-off-by: Eelco Chaudron Signed

[PATCH net v2] net: core: make napi_disable more robust

2021-04-14 Thread Lijun Pan
There are chances that napi_disable can be called twice by NIC driver. This could generate deadlock. For example, the first napi_disable will spin until NAPI_STATE_SCHED is cleared by napi_complete_done, then set it again. When napi_disable is called the second time, it will loop infinitely because

Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-14 Thread Jesper Dangaard Brouer
On Mon, 12 Apr 2021 02:15:32 +0100 Matthew Wilcox wrote: > On Sun, Apr 11, 2021 at 11:33:18AM +0100, Matthew Wilcox wrote: > > Basically, we have three aligned dwords here. We can either alias with > > @flags and the first word of @lru, or the second word of @lru and @mapping, > > or @index and

Re: [PATCH net] r8169: don't advertise pause in jumbo mode

2021-04-14 Thread Greg KH
On Wed, Apr 14, 2021 at 09:56:30AM +0200, Heiner Kallweit wrote: > On 14.04.2021 09:49, Greg KH wrote: > > On Wed, Apr 14, 2021 at 09:40:51AM +0200, Heiner Kallweit wrote: > >> It has been reported [0] that using pause frames in jumbo mode impacts > >> performance. There's no available chip documen

Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-14 Thread Jason Wang
在 2021/4/13 下午12:28, Yongji Xie 写道: On Tue, Apr 13, 2021 at 11:35 AM Jason Wang wrote: 在 2021/4/12 下午5:59, Yongji Xie 写道: On Mon, Apr 12, 2021 at 5:37 PM Jason Wang wrote: 在 2021/4/12 下午4:02, Yongji Xie 写道: On Mon, Apr 12, 2021 at 3:16 PM Jason Wang wrote: 在 2021/4/9 下午4:02, Yongji Xie

Re: [PATCH net v2] net: core: make napi_disable more robust

2021-04-14 Thread Yunsheng Lin
On 2021/4/14 16:08, Lijun Pan wrote: > There are chances that napi_disable can be called twice by NIC driver. > This could generate deadlock. For example, > the first napi_disable will spin until NAPI_STATE_SCHED is cleared > by napi_complete_done, then set it again. > When napi_disable is called t

[PATCH net v2] r8169: don't advertise pause in jumbo mode

2021-04-14 Thread Heiner Kallweit
It has been reported [0] that using pause frames in jumbo mode impacts performance. There's no available chip documentation, but vendor drivers r8168 and r8125 don't advertise pause in jumbo mode. So let's do the same, according to Roman it fixes the issue. [0] https://bugzilla.kernel.org/show_bug

[PATCH v2 4/6] kunit: lib: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Change config names inorder to adhear to the KUNIT *KUNIT_TEST config name format. Add 'if !KUNIT_ALL_TESTS' to the KUNIT config tristates inorder to adhear to the KUNIT standard. add 'default KUNIT_ALL_TESTS' to the KUNIT config options inorder to adhear to the KUNIT standard. Fixes: 6d511020e1

[PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: a00a582203db (mptcp: move crypto test to KUNIT) Signed-off-by: Nico Pache --- net/mptcp/Kconfig | 2 +- net/mptcp/Makefile | 2 +- net/mptcp/crypto.c | 2 +- net/mptcp/token.c |

[PATCH v2 2/6] kunit: software node: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Change CONFIG_KUNIT_DRIVER_PE_TEST to CONFIG_DRIVER_PE_KUNIT_TEST inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: aa811e3cecec (software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST) Signed-off-by: Nico Pache --- drivers/base/test/Kconfig | 2 +- drivers/base/test/Makefile

[PATCH v2 6/6] m68k: update configs to match the proper KUNIT syntax

2021-04-14 Thread Nico Pache
No functional changes other than CONFIG name changes Signed-off-by: Nico Pache --- arch/m68k/configs/amiga_defconfig| 6 +++--- arch/m68k/configs/apollo_defconfig | 6 +++--- arch/m68k/configs/atari_defconfig| 6 +++--- arch/m68k/configs/bvme6000_defconfig | 6 +++--- arch/m68k/configs/

[PATCH v2 0/6] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-14 Thread Nico Pache
There are few instances of KUNIT tests that are not properly defined. This commit focuses on correcting these issues to match the standard defined in the Documentation. Issues Fixed: - tests should end in KUNIT_TEST, some fixes have been applied to correct issues were KUNIT_TESTS is used or KU

[PATCH v2 1/6] kunit: ASoC: topology: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Drop 'S' from end of SND_SOC_TOPOLOGY_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: d52bbf747cfa (ASoC: topology: KUnit: Add KUnit tests passing various...) Signed-off-by: Nico Pache --- sound/soc/Kconfig | 2 +- sound/soc/Makefile | 4 ++-- 2 files changed

[PATCH v2 3/6] kunit: ext4: adhear to KUNIT formatting standard

2021-04-14 Thread Nico Pache
Drop 'S' from end of CONFIG_EXT4_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: 1cbeab1b242d (ext4: add kunit test for decoding extended timestamps) Signed-off-by: Nico Pache --- fs/ext4/.kunitconfig | 2 +- fs/ext4/Kconfig | 2 +- fs/ext4/Makefile |

[PATCH 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk

2021-04-14 Thread Zhu Lingshan
This series enabled Intel FGPA SmartNIC C5000X-PL virtio-blk for vDPA. This series requires: Stefano's vdpa block patchset: https://lkml.org/lkml/2021/3/15/2113 my patchset to enable Intel FGPA SmartNIC C5000X-PL virtio-net for vDPA: https://lkml.org/lkml/2021/3/17/432 Thanks! Zhu Lingshan (3):

[PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-14 Thread Zhu Lingshan
This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 1 + d

[PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-14 Thread Zhu Lingshan
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 17 - drivers/vdpa/ifcvf/ifcvf_main.c | 10 +- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifc

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

2021-04-14 Thread Matthieu Baerts
Hi Nico, On 14/04/2021 10:58, Nico Pache wrote: Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. For MPTCP, we have multiple KUnit tests: crypto and token. That's why we wrote TESTS with a S. I'm fine without S if we need to stick

AW: Possible race in ipv4 routing

2021-04-14 Thread Schmid, Carsten
Hi again, > -Ursprüngliche Nachricht- > Von: Wei Wang [mailto:wei...@google.com] > Gesendet: Montag, 1. Februar 2021 19:53 > An: David Ahern > Cc: Schmid, Carsten ; > da...@davemloft.net; kuz...@ms2.inr.ac.ru; yoshf...@linux-ipv6.org; > netdev@vger.kernel.org > Betreff: Re: Possible race

[PATCH 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-14 Thread Zhu Lingshan
get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c index 9b6a

Re: [PATCH net-next v2] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-14 Thread Jason Wang
在 2021/4/14 上午9:52, Xuan Zhuo 写道: In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO. Here, if the payload of the received packag

FW: IGMP messages leading to MRT_NOCACHE upcalls

2021-04-14 Thread Sietse van Zanen
Hi, IGMP packets are eligible to be forwarded by the kernel, leading to MRT_NOCACHE upcalls to userspace. I decided to check into this, because there was a notable difference in multicast mrt between FreeBSD (which "arguably" has the better network stack) and Linux using the exact same user spa

[PATCH net] doc: move seg6_flowlabel to seg6-sysctl.rst

2021-04-14 Thread Nicolas Dichtel
Let's have all seg6 sysctl at the same place. Fixes: a6dc6670cd7e ("ipv6: sr: Add documentation for seg_flowlabel sysctl") Signed-off-by: Nicolas Dichtel --- Documentation/networking/ip-sysctl.rst | 15 --- Documentation/networking/seg6-sysctl.rst | 13 + 2 files change

Re: arp(7) description of gc_stale_time

2021-04-14 Thread Alejandro Colomar (man-pages)
[CC += netdev] On 4/12/21 12:13 AM, Adam Liddell wrote: Hi, Any opinion on this? Adam On Tue, 16 Feb 2021, at 17:00, Adam Liddell wrote: Hi, The arp(7) page's description of gc_stale_time doesn't quite describe the behaviour correctly, at least as I understand it. The current description s

[PATCH net] vrf: fix a comment about loopback device

2021-04-14 Thread Nicolas Dichtel
This is a leftover of the below commit. Fixes: 4f04256c983a ("net: vrf: Drop local rtable and rt6_info") Signed-off-by: Nicolas Dichtel --- drivers/net/vrf.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index cde8ffd182b0..7

pull request (net-next): ipsec-next 2021-04-14

2021-04-14 Thread Steffen Klassert
Not much this time: 1) Simplification of some variable calculations in esp4 and esp6. From Jiapeng Chong and Junlin Yang. 2) Fix a clang Wformat warning in esp6 and ah6. From Arnd Bergmann. Please pull or let me know if there are problems. Thanks! The following changes since commit 34bb9

[PATCH 2/3] esp6: remove a duplicative condition

2021-04-14 Thread Steffen Klassert
From: Junlin Yang Fixes coccicheck warnings: ./net/ipv6/esp6_offload.c:319:32-34: WARNING !A || A && B is equivalent to !A || B Signed-off-by: Junlin Yang Signed-off-by: Steffen Klassert --- net/ipv6/esp6_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/e

[PATCH 3/3] ipv6: fix clang Wformat warning

2021-04-14 Thread Steffen Klassert
From: Arnd Bergmann When building with 'make W=1', clang warns about a mismatched format string: net/ipv6/ah6.c:710:4: error: format specifies type 'unsigned short' but the argument has type 'int' [-Werror,-Wformat] aalg_desc->uinfo.auth.icv_fullbits/8);

[PATCH 1/3] esp4: Simplify the calculation of variables

2021-04-14 Thread Steffen Klassert
From: Jiapeng Chong Fix the following coccicheck warnings: ./net/ipv4/esp4.c:757:16-18: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Steffen Klassert --- net/ipv4/esp4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] esp6: Simplify the calculation of variables

2021-04-14 Thread Steffen Klassert
On Tue, Apr 13, 2021 at 05:57:15PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./net/ipv6/esp6_offload.c:321:32-34: WARNING !A || A && B is equivalent > to !A || B. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > net/ipv6/esp6_offload.c | 2 +- >

[PATCH net-next] skbuff: revert "skbuff: remove some unnecessary operation in skb_segment_list()"

2021-04-14 Thread Paolo Abeni
the commit 1ddc3229ad3c ("skbuff: remove some unnecessary operation in skb_segment_list()") introduces an issue very similar to the one already fixed by commit 53475c5dd856 ("net: fix use-after-free when UDP GRO with shared fraglist"). If the GSO skb goes though skb_clone() and pskb_expand_head()

Re: [RFC PATCH v8 19/19] af_vsock: serialize writes to shared socket

2021-04-14 Thread Arseny Krasnov
On 13.04.2021 15:47, Arseny Krasnov wrote: > This add logic, that serializes write access to single socket > by multiple threads. It is implemented be adding field with TID > of current writer. When writer tries to send something, it checks > that field is -1(free), else it sleep in the same way

Re: [PATCHv4 bpf-next 4/5] selftests/bpf: Add re-attach test to lsm test

2021-04-14 Thread Jiri Olsa
On Tue, Apr 13, 2021 at 02:57:26PM -0700, Andrii Nakryiko wrote: > On Mon, Apr 12, 2021 at 9:31 AM Jiri Olsa wrote: > > > > Adding the test to re-attach (detach/attach again) lsm programs, > > plus check that already linked program can't be attached again. > > > > Signed-off-by: Jiri Olsa > > ---

Re: [PATCHv4 bpf-next 2/5] selftests/bpf: Add re-attach test to fentry_test

2021-04-14 Thread Jiri Olsa
On Tue, Apr 13, 2021 at 02:54:10PM -0700, Andrii Nakryiko wrote: SNIP > > __u32 duration = 0, retval; > > + struct bpf_link *link; > > __u64 *result; > > > > - fentry_skel = fentry_test__open_and_load(); > > - if (CHECK(!fentry_skel, "fentry_skel_load", "fentry s

Re: [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API

2021-04-14 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Tue, Apr 6, 2021 at 3:06 AM Toke Høiland-Jørgensen wrote: >> >> Andrii Nakryiko writes: >> >> > On Sat, Apr 3, 2021 at 10:47 AM Alexei Starovoitov >> > wrote: >> >> >> >> On Sat, Apr 03, 2021 at 12:38:06AM +0530, Kumar Kartikeya Dwivedi wrote: >> >> > On Sat, Apr 0

Re: [PATCHv4 bpf-next 1/5] bpf: Allow trampoline re-attach for tracing and lsm programs

2021-04-14 Thread Jiri Olsa
On Tue, Apr 13, 2021 at 03:03:27PM -0700, Andrii Nakryiko wrote: > On Mon, Apr 12, 2021 at 9:28 AM Jiri Olsa wrote: > > > > Currently we don't allow re-attaching of trampolines. Once > > it's detached, it can't be re-attach even when the program > > is still loaded. > > > > Adding the possibility

Re: [PATCHv4 bpf-next 3/5] selftests/bpf: Add re-attach test to fexit_test

2021-04-14 Thread Jiri Olsa
On Tue, Apr 13, 2021 at 02:55:32PM -0700, Andrii Nakryiko wrote: > On Mon, Apr 12, 2021 at 9:30 AM Jiri Olsa wrote: > > > > Adding the test to re-attach (detach/attach again) tracing > > fexit programs, plus check that already linked program can't > > be attached again. > > > > Also switching to A

Re: [PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support

2021-04-14 Thread Peter Geis
On Tue, Apr 13, 2021 at 7:37 PM Ezequiel Garcia wrote: > > On Tuesday, April 13, 2021 19:51 -03, Peter Geis wrote: > > > On Tue, Apr 13, 2021 at 5:03 PM Ezequiel Garcia > > wrote: > > > > > > From: David Wu > > > > > > Add constants and callback functions for the dwmac present > > > on RK3566

[PATCH] sfc: Remove duplicate argument

2021-04-14 Thread Wan Jiabing
Fix the following coccicheck warning: ./drivers/net/ethernet/sfc/enum.h:80:7-28: duplicated argument to | Signed-off-by: Wan Jiabing --- drivers/net/ethernet/sfc/enum.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/enum.h b/drivers/net/ethernet/sfc/enum.h index 333

Re: [PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support

2021-04-14 Thread Heiko Stübner
Am Mittwoch, 14. April 2021, 13:03:25 CEST schrieb Peter Geis: > On Tue, Apr 13, 2021 at 7:37 PM Ezequiel Garcia > wrote: > > > > +static void rk3566_set_to_rmii(struct rk_priv_data *bsp_priv) > > > > +{ > > > > + struct device *dev = &bsp_priv->pdev->dev; > > > > + > > > > + if (IS_E

Re: [PATCHv6 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-14 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > This patch adds two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to > extend xdp_redirect_map for broadcast support. > > With BPF_F_BROADCAST the packet will be broadcasted to all the interfaces > in the map. with BPF_F_EXCLUDE_INGRESS the ingress interface will be > excl

[PATCH] [net] cavium/liquidio: Fix duplicate argument

2021-04-14 Thread Wan Jiabing
Fix the following coccicheck warning: ./drivers/net/ethernet/cavium/liquidio/cn66xx_regs.h:413:6-28: duplicated argument to & or | The CN6XXX_INTR_M1UPB0_ERR here is duplicate. Here should be CN6XXX_INTR_M1UNB0_ERR. Signed-off-by: Wan Jiabing --- drivers/net/ethernet/cavium/liquidio/cn66xx_reg

Re: [PATCH v3 net-next] net: multipath routing: configurable seed

2021-04-14 Thread Pavel Balaev
On Tue, Apr 13, 2021 at 08:28:52PM -0700, David Ahern wrote: > On 4/13/21 4:55 AM, Balaev Pavel wrote: > > Ability for a user to assign seed value to multipath route hashes. > > Now kernel uses random seed value to prevent hash-flooding DoS attacks; > > however, it disables some use cases, f.e: > >

Re: [PATCH v3 net-next] net: multipath routing: configurable seed

2021-04-14 Thread Pavel Balaev
On Tue, Apr 13, 2021 at 04:15:21PM -0700, David Miller wrote: > From: Balaev Pavel > Date: Tue, 13 Apr 2021 14:55:04 +0300 > > > @@ -222,6 +230,9 @@ struct netns_ipv4 { > > #ifdef CONFIG_IP_ROUTE_MULTIPATH > > u8 sysctl_fib_multipath_use_neigh; > > u8 sysctl_fib_multipath_hash_policy; >

Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-14 Thread Matthew Wilcox
On Wed, Apr 14, 2021 at 10:10:44AM +0200, Jesper Dangaard Brouer wrote: > Yes, indeed! - And very frustrating. It's keeping me up at night. > I'm dreaming about 32 vs 64 bit data structures. My fitbit stats tell > me that I don't sleep well with these kind of dreams ;-) Then you're going to love

Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-14 Thread Ilias Apalodimas
On Wed, Apr 14, 2021 at 12:50:52PM +0100, Matthew Wilcox wrote: > On Wed, Apr 14, 2021 at 10:10:44AM +0200, Jesper Dangaard Brouer wrote: > > Yes, indeed! - And very frustrating. It's keeping me up at night. > > I'm dreaming about 32 vs 64 bit data structures. My fitbit stats tell > > me that I do

Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe

2021-04-14 Thread Jiri Olsa
On Tue, Apr 13, 2021 at 06:04:05PM -0700, Andrii Nakryiko wrote: > On Tue, Apr 13, 2021 at 7:57 AM Jiri Olsa wrote: > > > > hi, > > sending another attempt on speeding up load of multiple probes > > for bpftrace and possibly other tools (first post in [1]). > > > > This patchset adds support to at

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-14 Thread Joakim Zhang
> -Original Message- > From: Joakim Zhang > Sent: 2021年4月14日 16:07 > To: Thierry Reding > Cc: David S. Miller ; Jakub Kicinski ; > Jon Hunter ; Giuseppe Cavallaro > ; Alexandre Torgue ; > Jose Abreu ; netdev@vger.kernel.org; Linux Kernel > Mailing List ; linux-tegra > > Subject: RE: Reg

[PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-14 Thread Hangbin Liu
From: Jesper Dangaard Brouer This changes the devmap XDP program support to run the program when the bulk queue is flushed instead of before the frame is enqueued. This has a couple of benefits: - It "sorts" the packets by destination devmap entry, and then runs the same BPF program on all the

[PATCHv7 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-14 Thread Hangbin Liu
Hi, This patchset is a new implementation for XDP multicast support based on my previous 2 maps implementation[1]. The reason is that Daniel think the exclude map implementation is missing proper bond support in XDP context. And there is a plan to add native XDP bonding support. Adding a exclude m

[PATCHv7 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-14 Thread Hangbin Liu
This patch adds two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to extend xdp_redirect_map for broadcast support. With BPF_F_BROADCAST the packet will be broadcasted to all the interfaces in the map. with BPF_F_EXCLUDE_INGRESS the ingress interface will be excluded when do broadcasting. When

[PATCHv7 bpf-next 3/4] sample/bpf: add xdp_redirect_map_multi for redirect_map broadcast test

2021-04-14 Thread Hangbin Liu
This is a sample for xdp redirect broadcast. In the sample we could forward all packets between given interfaces. There is also an option -X that could enable 2nd xdp_prog on egress interface. Signed-off-by: Hangbin Liu --- samples/bpf/Makefile | 3 + samples/bpf/xdp_redir

[PATCHv7 bpf-next 4/4] selftests/bpf: add xdp_redirect_multi test

2021-04-14 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test there are 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. Two maps (DEVMAP, DEVMAP_HASH) and two xdp

Re: [PATCh stable 4.19] net: phy: broadcom: Only advertise EEE for supported modes

2021-04-14 Thread Sasha Levin
On Mon, Apr 12, 2021 at 04:30:14PM -0700, Florian Fainelli wrote: commit c056d480b40a68f2520ccc156c7fae672d69d57d upstream We should not be advertising EEE for modes that we do not support, correct that oversight by looking at the PHY device supported linkmodes. Fixes: 99cec8a4dda2 ("net: phy:

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-14 Thread Aswath Govindraju
Hi Marc, On 13/04/21 6:45 pm, Rob Herring wrote: > On Tue, Apr 13, 2021 at 2:41 AM Marc Kleine-Budde wrote: >> >> On 12.04.2021 12:49:56, Rob Herring wrote: >>> On Mon, Apr 12, 2021 at 12:19:30PM +0200, Marc Kleine-Budde wrote: On 4/9/21 3:40 PM, Aswath Govindraju wrote: > Add binding do

Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue

2021-04-14 Thread Julian Wiedmann
On 09.04.21 02:39, Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > The ethernet frame length is calculated incorrectly. Depending on > the value of RX_HEAD_PADDING, this may result in ethernet frames > that are too short (cut off at the end), or too long (garbage added > to the end). > >

Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-14 Thread Michael Walle
Hi Dan, Am 2021-04-14 07:33, schrieb Dan Carpenter: url: https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cc0626c2aaed8e475efdd85fa374b497a7192

Re: [PATCH V4 2/2] net: ethernet: ravb: Enable optional refclk

2021-04-14 Thread Adam Ford
On Tue, Apr 13, 2021 at 2:33 AM Geert Uytterhoeven wrote: > > Hi Adam, > > On Mon, Apr 12, 2021 at 3:27 PM Adam Ford wrote: > > For devices that use a programmable clock for the AVB reference clock, > > the driver may need to enable them. Add code to find the optional clock > > and enable it whe

Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue

2021-04-14 Thread Sven Van Asbroeck
Hi Julian, On Wed, Apr 14, 2021 at 8:53 AM Julian Wiedmann wrote: > > On a cursory glance, using __netdev_alloc_skb_ip_align() here should > allow you to get rid of all the RX_HEAD_PADDING gymnastics. > > And also avoid the need for setting RX_CFG_B_RX_PAD_2_, as the > NET_IP_ALIGN part would no

Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy

2021-04-14 Thread Rob Herring
On Wed, Apr 14, 2021 at 1:49 AM Aswath Govindraju wrote: > > Hi Rob, > > On 12/04/21 11:21 pm, Rob Herring wrote: > > On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: > >> From: Faiz Abbas > >> > >> Some transceivers need a configuration step (for example, pulling the > >> stand

Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue

2021-04-14 Thread Julian Wiedmann
On 14.04.21 15:19, Sven Van Asbroeck wrote: > Hi Julian, > > On Wed, Apr 14, 2021 at 8:53 AM Julian Wiedmann wrote: >> >> On a cursory glance, using __netdev_alloc_skb_ip_align() here should >> allow you to get rid of all the RX_HEAD_PADDING gymnastics. >> >> And also avoid the need for setting R

Re: [PATCH net v1] lan743x: fix ethernet frame cutoff issue

2021-04-14 Thread Sven Van Asbroeck
Hi Julian, On Wed, Apr 14, 2021 at 9:33 AM Julian Wiedmann wrote: > > __netdev_alloc_skb_ip_align() already reserves the NET_IP_ALIGN part. > So when the NIC stores into the dma-mapped skb->data parts, each > fragment will automatically have the required alignment - even when > you only care abou

Re: [PATCH rdma-next v2 0/5] Get rid of custom made module dependency

2021-04-14 Thread Devesh Sharma
On Mon, Apr 12, 2021 at 1:10 PM Leon Romanovsky wrote: > > On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote: > > On Thu, Apr 8, 2021 at 5:14 PM Leon Romanovsky wrote: > > > > > > On Thu, Apr 08, 2021 at 05:06:24PM +0530, Devesh Sharma wrote: > > > > On Sat, Apr 3, 2021 at 5:12 PM Leo

Re: [PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support

2021-04-14 Thread Ezequiel Garcia
Hi Peter, Heiko, On Wed, 2021-04-14 at 13:15 +0200, Heiko Stübner wrote: > Am Mittwoch, 14. April 2021, 13:03:25 CEST schrieb Peter Geis: > > On Tue, Apr 13, 2021 at 7:37 PM Ezequiel Garcia > > wrote: > > > > > +static void rk3566_set_to_rmii(struct rk_priv_data *bsp_priv) > > > > > +{ > > > > >

Re: [PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support

2021-04-14 Thread Ezequiel Garcia
On Wed, 2021-04-14 at 07:03 -0400, Peter Geis wrote: > On Tue, Apr 13, 2021 at 7:37 PM Ezequiel Garcia > wrote: > > > > On Tuesday, April 13, 2021 19:51 -03, Peter Geis > > wrote: > > > > > On Tue, Apr 13, 2021 at 5:03 PM Ezequiel Garcia > > > wrote: > > > > > > > > From: David Wu > > > >

Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-14 Thread Stefan Hajnoczi
On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: > VDUSE (vDPA Device in Userspace) is a framework to support > implementing software-emulated vDPA devices in userspace. This > document is intended to clarify the VDUSE design and usage. > > Signed-off-by: Xie Yongji > --- > Documentat

Re: [PATCHv7 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-14 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > Hi, > > This patchset is a new implementation for XDP multicast support based > on my previous 2 maps implementation[1]. The reason is that Daniel think > the exclude map implementation is missing proper bond support in XDP > context. And there is a plan to add native XDP bo

[PATCH] tools/testing: Remove unused variable

2021-04-14 Thread zuoqilin1
From: zuoqilin Remove unused variable "ret2". Signed-off-by: zuoqilin --- tools/testing/selftests/bpf/progs/test_tunnel_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/progs/test_tunnel_kern.c b/tools/testing/selftests/bpf/progs/test_tunn

Re: [PATCH v2 1/6] kunit: ASoC: topology: adhear to KUNIT formatting standard

2021-04-14 Thread Mark Brown
On Wed, Apr 14, 2021 at 04:58:04AM -0400, Nico Pache wrote: > Drop 'S' from end of SND_SOC_TOPOLOGY_KUNIT_TESTS inorder to adhear to > the KUNIT *_KUNIT_TEST config name format. Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to id

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-14 Thread Tom Talpey
On 4/12/2021 6:48 PM, Jason Gunthorpe wrote: On Mon, Apr 12, 2021 at 04:20:47PM -0400, Tom Talpey wrote: So the issue is only in testing all the providers and platforms, to be sure this new behavior isn't tickling anything that went unnoticed all along, because no RDMA provider ever issued RO.

[PATCH net-next] net: bridge: propagate error code and extack from br_mc_disabled_update

2021-04-14 Thread Vladimir Oltean
From: Florian Fainelli Some Ethernet switches might only be able to support disabling multicast flooding globally, which is an issue for example when several bridges span the same physical device and request contradictory settings. Propagate the return value of br_mc_disabled_update() such that

RE: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-14 Thread David Laight
From: Tom Talpey > Sent: 14 April 2021 15:16 > > On 4/12/2021 6:48 PM, Jason Gunthorpe wrote: > > On Mon, Apr 12, 2021 at 04:20:47PM -0400, Tom Talpey wrote: > > > >> So the issue is only in testing all the providers and platforms, > >> to be sure this new behavior isn't tickling anything that wen

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-14 Thread Jason Gunthorpe
On Wed, Apr 14, 2021 at 10:16:28AM -0400, Tom Talpey wrote: > On 4/12/2021 6:48 PM, Jason Gunthorpe wrote: > > On Mon, Apr 12, 2021 at 04:20:47PM -0400, Tom Talpey wrote: > > > > > So the issue is only in testing all the providers and platforms, > > > to be sure this new behavior isn't tickling an

Re: [PATCH net-next v4 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-14 Thread Richard Cochran
On Wed, Apr 14, 2021 at 08:16:17AM +0800, Wong Vee Khee wrote: > From: Tan Tee Min > > The Synopsis MAC controller supports auxiliary snapshot feature that > allows user to store a snapshot of the system time based on an external > event. > > This patch add supports to the above mentioned featur

[PATCH net-next] net: enetc: fetch MAC address from device tree

2021-04-14 Thread Michael Walle
Normally, the bootloader will already initialize the MAC address registers of the ENETC and the driver will just use them or generate a random one, if it is not initialized. Add a new way to provide the MAC address: via device tree. Besides the usual 'mac-address' property, there is also the possi

Re: [PATCH rdma-next 00/10] Enable relaxed ordering for ULPs

2021-04-14 Thread Jason Gunthorpe
On Wed, Apr 14, 2021 at 02:41:52PM +, David Laight wrote: > So whatever driver initialises the target needs to configure whatever > target-specific register enables the RO transfers themselves. RDMA in general, and mlx5 in particular, is a layered design: mlx5_core <- owns the PCI function,

[Resend RFC PATCH V2 00/12] x86/Hyper-V: Add Hyper-V Isolation VM support

2021-04-14 Thread Tianyu Lan
From: Tianyu Lan "Resend all patches because someone in CC list didn't receive all patchset. Sorry for nosy." Hyper-V provides two kinds of Isolation VMs. VBS(Virtualization-based security) and AMD SEV-SNP unenlightened Isolation VMs. This patchset is to add support for these Isolation VM suppor

[Resend RFC PATCH V2 02/12] x86/HV: Initialize shared memory boundary in Isolation VM

2021-04-14 Thread Tianyu Lan
From: Tianyu Lan Hyper-V exposes shared memory boundary via cpuid HYPERV_ CPUID_ISOLATION_CONFIG and store it in the shared_gpa_ boundary of ms_hyperv struct. This prepares to share memory with host for AMD SEV SNP guest. Signed-off-by: Tianyu Lan --- arch/x86/kernel/cpu/mshyperv.c | 2 ++ in

[Resend RFC PATCH V2 01/12] x86/HV: Initialize GHCB page in Isolation VM

2021-04-14 Thread Tianyu Lan
From: Tianyu Lan Hyper-V exposes GHCB page via SEV ES GHCB MSR for SNP guest to communicate with hypervisor. Map GHCB page for all cpus to read/write MSR register and submit hvcall request via GHCB. Signed-off-by: Tianyu Lan --- arch/x86/hyperv/hv_init.c | 52 +

[Resend RFC PATCH V2 03/12] x86/Hyper-V: Add new hvcall guest address host visibility support

2021-04-14 Thread Tianyu Lan
From: Tianyu Lan Add new hvcall guest address host visibility support. Mark vmbus ring buffer visible to host when create gpadl buffer and mark back to not visible when tear down gpadl buffer. Co-Developed-by: Sunil Muthuswamy Signed-off-by: Tianyu Lan --- arch/x86/hyperv/Makefile |

[Resend RFC PATCH V2 04/12] HV: Add Write/Read MSR registers via ghcb

2021-04-14 Thread Tianyu Lan
From: Tianyu Lan Hyper-V provides GHCB protocol to write Synthetic Interrupt Controller MSR registers and these registers are emulated by Hypervisor rather than paravisor. Hyper-V requests to write SINTx MSR registers twice(once via GHCB and once via wrmsr instruction including the proxy bit 21)

  1   2   3   4   5   >