Re: Broken imx6 to QCA8334 connection since PHYLIB to PHYLINK conversion

2021-04-13 Thread Michal Vokáč
On 12. 04. 21 16:14, Andrew Lunn wrote: [1] https://elixir.bootlin.com/linux/v5.12-rc7/source/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi#L101 &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_

[PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-13 Thread Jonathon Reinhart
Currently, tcp_allowed_congestion_control is global and writable; writing to it in any net namespace will leak into all other net namespaces. tcp_available_congestion_control and tcp_allowed_congestion_control are the only sysctls in ipv4_net_table (the per-netns sysctl table) with a NULL data poi

Re: xen-netback hotplug-status regression bug

2021-04-13 Thread Paul Durrant
On 10/04/2021 19:25, Michael Brown wrote: Commit https://github.com/torvalds/linux/commit/1f25657 ("xen-netback: remove 'hotplug-status' once it has served its purpose") seems to have introduced a regression that prevents a vif frontend from transitioning more than once into Connected state.

Re: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Ivan Bornyakov
On Tue, Apr 13, 2021 at 01:32:12AM +0200, Marek Behún wrote: > On Mon, 12 Apr 2021 15:16:59 +0300 > Ivan Bornyakov wrote: > > > Some SFP modules uses RX_LOS for link indication. In such cases link > > will be always up, even without cable connected. RX_LOS changes will > > trigger link_up()/link_

Re: [PATCH v2 bpf-next 0/2] xsk: introduce generic almost-zerocopy xmit

2021-04-13 Thread Magnus Karlsson
On Tue, Apr 13, 2021 at 3:49 AM Xuan Zhuo wrote: > > On Mon, 12 Apr 2021 16:13:12 +0200, Magnus Karlsson > wrote: > > On Wed, Mar 31, 2021 at 2:27 PM Alexander Lobakin wrote: > > > > > > This series is based on the exceptional generic zerocopy xmit logics > > > initially introduced by Xuan Zhuo

Re: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Ivan Bornyakov
On Tue, Apr 13, 2021 at 01:40:32AM +0200, Andrew Lunn wrote: > On Mon, Apr 12, 2021 at 03:16:59PM +0300, Ivan Bornyakov wrote: > > Some SFP modules uses RX_LOS for link indication. In such cases link > > will be always up, even without cable connected. RX_LOS changes will > > trigger link_up()/link

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-13 Thread Shawn Guo
On Mon, Apr 12, 2021 at 02:54:46PM +0300, Kalle Valo wrote: > Shawn Guo writes: > > > On Sun, Apr 11, 2021 at 10:57:54AM +0300, Kalle Valo wrote: > >> Shawn Guo writes: > >> > >> > Add optional brcm,ccode-map property to support translation from ISO3166 > >> > country code to brcmfmac firmware

Re: [PATCH V4 2/2] net: ethernet: ravb: Enable optional refclk

2021-04-13 Thread Geert Uytterhoeven
Hi Adam, On Mon, Apr 12, 2021 at 3:27 PM Adam Ford wrote: > For devices that use a programmable clock for the AVB reference clock, > the driver may need to enable them. Add code to find the optional clock > and enable it when available. > > Signed-off-by: Adam Ford > Reviewed-by: Andrew Lunn >

Re: [PATCH RFC net] igb: Fix XDP with PTP enabled

2021-04-13 Thread Kurt Kanzenbach
On Mon Apr 12 2021, Jesper Dangaard Brouer wrote: > On Mon, 12 Apr 2021 12:17:13 +0200 > Kurt Kanzenbach wrote: > >> When using native XDP with the igb driver, the XDP frame data doesn't point >> to >> the beginning of the packet. It's off by 16 bytes. Everything works as >> expected >> with XDP

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-13 Thread Marc Kleine-Budde
On 12.04.2021 12:49:56, Rob Herring wrote: > On Mon, Apr 12, 2021 at 12:19:30PM +0200, Marc Kleine-Budde wrote: > > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > > > Add binding documentation for TI TCAN104x CAN transceivers. > > > > > > Signed-off-by: Aswath Govindraju > > > --- > > > .../bindi

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-13 Thread Shawn Guo
On Mon, Apr 12, 2021 at 10:09:38AM +0200, Arend van Spriel wrote: > On 08-04-2021 13:30, Shawn Guo wrote: > > With any regulatory domain requests coming from either user space or > > 802.11 IE (Information Element), the country is coded in ISO3166 > > standard. It needs to be translated to firmwar

[PATCH v2 2/2] Bluetooth: Support the vendor specific debug events

2021-04-13 Thread Joseph Hwang
This patch allows a user space process to enable/disable the vendor specific (vs) debug events dynamically through the set experimental feature mgmt interface if CONFIG_BT_FEATURE_VS_DBG_EVT is enabled. Since the debug event feature needs to invoke the callback function provided by the driver, i.e

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-13 Thread Shawn Guo
On Mon, Apr 12, 2021 at 10:22:47AM +0200, Arend van Spriel wrote: > On 08-04-2021 13:30, Shawn Guo wrote: > > With any regulatory domain requests coming from either user space or > > 802.11 IE (Information Element), the country is coded in ISO3166 > > standard. It needs to be translated to firmwar

Re: [Patch net] smc: disallow TCP_ULP in smc_setsockopt()

2021-04-13 Thread Karsten Graul
On 10/04/2021 20:17, Cong Wang wrote: > From: Cong Wang > > syzbot is able to setup kTLS on an SMC socket, which coincidentally > uses sk_user_data too, later, kTLS treats it as psock so triggers a > refcnt warning. The cause is that smc_setsockopt() simply calls > TCP setsockopt(). I do not thin

RE: [PATCH net-next v2 0/3] introduce skb_for_each_frag()

2021-04-13 Thread David Laight
From: Matteo Croce > Sent: 12 April 2021 01:38 > > Introduce skb_for_each_frag, an helper macro to iterate over the SKB frags. The real question is why, the change is: - for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { + skb_for_each_frag(skb, i) { The existing code isn't complicat

[PATCH net-next 0/5] net: phy: marvell: some HWMON updates

2021-04-13 Thread Marek Behún
Here are some updates for Marvell PHY HWMON, mainly - refactoring for code deduplication - Amethyst PHY support Marek Behún (5): net: phy: marvell: refactor HWMON OOP style net: phy: marvell: fix HWMON enable register for 6390 net: phy: marvell: use assignment by bitwise AND operator net:

[PATCH net-next 1/5] net: phy: marvell: refactor HWMON OOP style

2021-04-13 Thread Marek Behún
Use a structure of Marvell PHY specific HWMON methods to reduce code duplication. Store a pointer to this structure into the PHY driver's driver_data member. Signed-off-by: Marek Behún --- drivers/net/phy/marvell.c | 371 +- 1 file changed, 127 insertions(+),

[PATCH net-next 3/5] net: phy: marvell: use assignment by bitwise AND operator

2021-04-13 Thread Marek Behún
Use the &= operator instead of ret = ret & ... Signed-off-by: Marek Behún --- drivers/net/phy/marvell.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c index bae2a225b550..9eb65898da83 100644 --- a/drivers/net/phy/marvel

[PATCH net-next 5/5] net: phy: marvell: add support for Amethyst internal PHY

2021-04-13 Thread Marek Behún
Add support for Amethyst internal PHY. The only difference from Peridot is HWMON. Signed-off-by: Marek Behún --- drivers/net/phy/marvell.c | 117 +++- include/linux/marvell_phy.h | 1 + 2 files changed, 115 insertions(+), 3 deletions(-) diff --git a/drivers/

RE: [PATCH net-next 6/7] net: stmmac: Enable RX via AF_XDP zero-copy

2021-04-13 Thread Ong, Boon Leong
>+ /* synchronize_rcu() needed for pending XDP buffers to drain */ >+ for (queue = 0; queue < rx_queues_cnt; queue++) { >+ rx_q = &priv->rx_queue[queue]; >+ if (rx_q->xsk_pool) { >+ synchronize_rcu(); > >Are you sure this is safe here, especi

[PATCH net-next 2/5] net: phy: marvell: fix HWMON enable register for 6390

2021-04-13 Thread Marek Behún
Register 27_6.15:14 has the following description in 88E6393X documentation: Temperature Sensor Enable 0x0 - Sample every 1s 0x1 - Sense rate decided by bits 10:8 of this register 0x2 - Use 26_6.5 (One shot Temperature Sample) to enable 0x3 - Disable This is compatible with how t

[PATCH net-next 4/5] net: dsa: mv88e6xxx: simulate Amethyst PHY model number

2021-04-13 Thread Marek Behún
Amethyst internal PHYs also report empty model number in MII_PHYSID2. Fill in switch product number, as is done for Topaz and Peridot. Signed-off-by: Marek Behún --- drivers/net/dsa/mv88e6xxx/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/n

Re: [PATCH net-next 1/1] netfilter: flowtable: Make sure dst_cache is valid before using it

2021-04-13 Thread Roi Dayan
On 2021-04-12 2:42 PM, Pablo Neira Ayuso wrote: On Mon, Apr 12, 2021 at 11:26:35AM +0300, Roi Dayan wrote: On 2021-04-11 1:58 PM, Pablo Neira Ayuso wrote: Hi Roi, On Sun, Apr 11, 2021 at 11:13:34AM +0300, Roi Dayan wrote: It could be dst_cache was not set so check it's not null before us

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-13 Thread Yunsheng Lin
On 2021/4/13 15:12, Hillf Danton wrote: > On Tue, 13 Apr 2021 11:34:27 Yunsheng Lin wrote: >> On 2021/4/13 11:26, Hillf Danton wrote: >>> On Tue, 13 Apr 2021 10:56:42 Yunsheng Lin wrote: On 2021/4/13 10:21, Hillf Danton wrote: > On Mon, 12 Apr 2021 20:00:43 Yunsheng Lin wrote: >>

[PATCH net-next v2 1/1] netfilter: flowtable: Add FLOW_OFFLOAD_XMIT_UNSPEC xmit type

2021-04-13 Thread Roi Dayan
It could be xmit type was not set and would default to FLOW_OFFLOAD_XMIT_NEIGH and in this type the gc expect to have a route info. Fix that by adding FLOW_OFFLOAD_XMIT_UNSPEC which defaults to 0. Fixes: 8b9229d15877 ("netfilter: flowtable: dst_check() from garbage collector path") Signed-off-by:

Re: [RFC v4 net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-13 Thread Marc Zyngier
On Tue, 13 Apr 2021 01:07:23 +0100, Andrew Lunn wrote: > > > > > +static void > > > > +mt7530_setup_mdio_irq(struct mt7530_priv *priv) > > > > +{ > > > > + struct dsa_switch *ds = priv->ds; > > > > + int p; > > > > + > > > > + for (p = 0; p < MT7530_NUM_PHYS; p++) { > > > > +

Re: [PATCH 2/2] brcmfmac: support parse country code map from DT

2021-04-13 Thread Arend van Spriel
On 13-04-2021 09:45, Shawn Guo wrote: On Mon, Apr 12, 2021 at 10:09:38AM +0200, Arend van Spriel wrote: On 08-04-2021 13:30, Shawn Guo wrote: With any regulatory domain requests coming from either user space or 802.11 IE (Information Element), the country is coded in ISO3166 standard. It ne

RE: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-13 Thread David Laight
From: Matthew Wilcox > Sent: 12 April 2021 19:24 > > On Sun, Apr 11, 2021 at 11:43:07AM +0200, Jesper Dangaard Brouer wrote: > > Could you explain your intent here? > > I worry about @index. > > > > As I mentioned in other thread[1] netstack use page_is_pfmemalloc() > > (code copy-pasted below si

RE: [PATCH net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-13 Thread Salil Mehta
Hi Anthony, Thanks for reviewing! > From: Nguyen, Anthony L [mailto:anthony.l.ngu...@intel.com] > Sent: Monday, April 12, 2021 11:41 PM > To: da...@davemloft.net; k...@kernel.org; Salil Mehta > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Brandeburg, Jesse > ; linux...@openeuler.org;

[PATCH net-next v2] ibmvnic: improve failover sysfs entry

2021-04-13 Thread Lijun Pan
The current implementation relies on H_IOCTL call to issue a H_SESSION_ERR_DETECTED command to let the hypervisor to send a failover signal. However, it may not work if there is no backup device or if the vnic is already in error state, e.g., "ibmvnic 3003 env3: rx buffer returned with rc 6". A

[PATCH net-next] ibmvnic: queue reset work in system_long_wq

2021-04-13 Thread Lijun Pan
When the linux system is under stress or the VIOS server is responding slowly, the vnic driver may hit multiple timeouts during the reset process. Instead of queueing the reset requests to system_wq, queueing the relatively slow reset job to the system_long_wq. Suggested-by: Nathan Lynch Signed-o

[PATCH net] ibmvnic: correctly use dev_consume/free_skb_irq

2021-04-13 Thread Lijun Pan
It is more correct to use dev_kfree_skb_irq when packets are dropped, and to use dev_consume_skb_irq when packets are consumed. Fixes: 0d973388185d ("ibmvnic: Introduce xmit_more support using batched subCRQ hcalls") Suggested-by: Thomas Falcon Signed-off-by: Lijun Pan --- drivers/net/ethernet

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Jon Hunter
On 01/04/2021 17:28, Jon Hunter wrote: > > On 31/03/2021 12:41, Joakim Zhang wrote: > > ... > >>> In answer to your question, resuming from suspend does work on this board >>> without your change. We have been testing suspend/resume now on this board >>> since Linux v5.8 and so we have the abi

[PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread stefanc
From: Stefan Chulski Add parser entries for different IPv4 IHL values. Each entry will set the L4 header offset according to the IPv4 IHL field. L3 header offset will set during the parsing of the IPv4 protocol. Suggested-by: Dana Vardi Signed-off-by: Stefan Chulski --- drivers/net/ethernet/m

Re: [PATCH RFC v2 1/4] virtio: fix up virtio_disable_cb

2021-04-13 Thread Jason Wang
在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: virtio_disable_cb is currently a nop for split ring with event index. This is because it used to be always called from a callback when we know device won't trigger more events until we update the index. However, now that we run with interrupts enabled

Re: [PATCH RFC v2 2/4] virtio_net: disable cb aggressively

2021-04-13 Thread Jason Wang
在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: There are currently two cases where we poll TX vq not in response to a callback: start xmit and rx napi. We currently do this with callbacks enabled which can cause extra interrupts from the card. Used not to be a big issue as we run with interrupts

Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Jason Wang
在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: It's unsafe to operate a vq from multiple threads. Unfortunately this is exactly what we do when invoking clean tx poll from rx napi. As a fix move everything that deals with the vq to under tx lock. Signed-off-by: Michael S. Tsirkin --- drivers/ne

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-13 Thread Yunsheng Lin
On 2021/4/13 16:33, Hillf Danton wrote: > On Tue, 13 Apr 2021 15:57:29 Yunsheng Lin wrote: >> On 2021/4/13 15:12, Hillf Danton wrote: >>> On Tue, 13 Apr 2021 11:34:27 Yunsheng Lin wrote: On 2021/4/13 11:26, Hillf Danton wrote: > On Tue, 13 Apr 2021 10:56:42 Yunsheng Lin wrote: >> On 2

Re: [External] [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jorgen Hansen
> On 7 Apr 2021, at 20:25, Jiang Wang . wrote: > > On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: >> >> >>> On 6 Apr 2021, at 20:31, Jiang Wang wrote: >>> >>> From: "jiang.wang" >>> >>> Currently, only VMCI supports dgram sockets. To supported >>> nested VM use case, this patch remo

Re: [PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-13 Thread Christian Brauner
On Tue, Apr 13, 2021 at 03:08:48AM -0400, Jonathon Reinhart wrote: > Currently, tcp_allowed_congestion_control is global and writable; > writing to it in any net namespace will leak into all other net > namespaces. > > tcp_available_congestion_control and tcp_allowed_congestion_control are > the o

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-13 Thread Juergen Gross
On 13.04.21 11:03, Yunsheng Lin wrote: On 2021/4/13 16:33, Hillf Danton wrote: On Tue, 13 Apr 2021 15:57:29 Yunsheng Lin wrote: On 2021/4/13 15:12, Hillf Danton wrote: On Tue, 13 Apr 2021 11:34:27 Yunsheng Lin wrote: On 2021/4/13 11:26, Hillf Danton wrote: On Tue, 13 Apr 2021 10:56:42 Yunsh

Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Russell King - ARM Linux admin
On Tue, Apr 13, 2021 at 11:45:31AM +0300, stef...@marvell.com wrote: > From: Stefan Chulski > > Add parser entries for different IPv4 IHL values. > Each entry will set the L4 header offset according to the IPv4 IHL field. > L3 header offset will set during the parsing of the IPv4 protocol. What

[PATCH] vhost-vdpa: fix vm_flags for virtqueue doorbell mapping

2021-04-13 Thread Jason Wang
The virtqueue doorbell is usually implemented via registeres but we don't provide the necessary vma->flags like VM_PFNMAP. This may cause several issues e.g when userspace tries to map the doorbell via vhost IOTLB, kernel may panic due to the page is not backed by page structure. This patch fixes t

Re: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Russell King - ARM Linux admin
On Tue, Apr 13, 2021 at 10:19:30AM +0300, Ivan Bornyakov wrote: > On Tue, Apr 13, 2021 at 01:40:32AM +0200, Andrew Lunn wrote: > > On Mon, Apr 12, 2021 at 03:16:59PM +0300, Ivan Bornyakov wrote: > > > Some SFP modules uses RX_LOS for link indication. In such cases link > > > will be always up, even

[PATCH net-next v2 0/7] stmmac: add XDP ZC support

2021-04-13 Thread Ong Boon Leong
Hi, This is the v2 patch series to add XDP ZC support to stmmac driver. Summary of v2 patch change:- 6/7: fix synchronize_rcu() is called stmmac_disable_all_queues() that is used by ndo_setup_tc(). Continuous burst

[PATCH net-next v2 3/7] net: stmmac: refactor stmmac_init_rx_buffers for stmmac_reinit_rx_buffers

2021-04-13 Thread Ong Boon Leong
The per-queue RX buffer allocation in stmmac_reinit_rx_buffers() can be made to use stmmac_alloc_rx_buffers() by merging the page_pool alloc checks for "buf->page" and "buf->sec_page" in stmmac_init_rx_buffers(). This is in preparation for XSK pool allocation later. Signed-off-by: Ong Boon Leong

[PATCH net-next v2 1/7] net: stmmac: rearrange RX buffer allocation and free functions

2021-04-13 Thread Ong Boon Leong
This patch restructures the per RX queue buffer allocation from page_pool to stmmac_alloc_rx_buffers(). We also rearrange dma_free_rx_skbufs() so that it can be used in init_dma_rx_desc_rings() during freeing of RX buffer in the event of page_pool allocation failure to replace the more efficient m

[PATCH net-next v2 4/7] net: stmmac: rearrange RX and TX desc init into per-queue basis

2021-04-13 Thread Ong Boon Leong
Below functions are made to be per-queue in preparation of XDP ZC: __init_dma_rx_desc_rings(struct stmmac_priv *priv, u32 queue, gfp_t flags) __init_dma_tx_desc_rings(struct stmmac_priv *priv, u32 queue) The original functions below are stay maintained for all queue usage: init_dma_rx_desc_ri

[PATCH net-next v2 5/7] net: stmmac: Refactor __stmmac_xdp_run_prog for XDP ZC

2021-04-13 Thread Ong Boon Leong
Prepare stmmac_xdp_run_prog() for AF_XDP zero-copy support which will be added by upcoming patches by splitting out the XDP verdict processing into __stmmac_xdp_run_prog() and it callable for XDP ZC path which does not need to verify bpf_prog is not NULL. The stmmac_xdp_run_prog() is used for regu

[PATCH net-next v2 2/7] net: stmmac: introduce dma_recycle_rx_skbufs for stmmac_reinit_rx_buffers

2021-04-13 Thread Ong Boon Leong
Rearrange RX buffer page_pool recycling logics into dma_recycle_rx_skbufs, so that we prepare stmmac_reinit_rx_buffers() for XSK pool expansion. Signed-off-by: Ong Boon Leong --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 44 --- 1 file changed, 27 insertions(+), 17 deletion

[PATCH net-next v2 7/7] net: stmmac: Add TX via XDP zero-copy socket

2021-04-13 Thread Ong Boon Leong
We add the support of XDP ZC TX submission and cleaning into stmmac_tx_clean(). The function is made to clean as many TX complete frames as possible, i.e. limit by priv->dma_tx_size instead of NAPI budget. For TX ring that is associated with XSK pool, the function stmmac_xdp_xmit_zc() is introduced

[PATCH net-next v2 6/7] net: stmmac: Enable RX via AF_XDP zero-copy

2021-04-13 Thread Ong Boon Leong
This patch adds the support for receiving packet via AF_XDP zero-copy mechanism. XDP ZC uses 1:1 mapping of XDP buffer to receive packet, therefore the use of split header is not used currently. The 'xdp_buff' is declared as union together with a struct that contains 'page', 'addr' and 'page_offse

RE: [EXT] Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Stefan Chulski
> -Original Message- > From: Russell King - ARM Linux admin > Sent: Tuesday, April 13, 2021 12:18 PM > To: Stefan Chulski > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan > Markman ; linux-ker...@vger.kernel.org; > k...@kernel.org; m...

[PATCHv5 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-13 Thread Hangbin Liu
Hi, This patchset is a new implementation for XDP multicast support based on my previous 2 maps implementation[1]. The reason is that Daniel think the exclude map implementation is missing proper bond support in XDP context. And there is a plan to add native XDP bonding support. Adding a exclude m

[PATCHv5 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-13 Thread Hangbin Liu
From: Jesper Dangaard Brouer This changes the devmap XDP program support to run the program when the bulk queue is flushed instead of before the frame is enqueued. This has a couple of benefits: - It "sorts" the packets by destination devmap entry, and then runs the same BPF program on all the

[PATCHv5 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-13 Thread Hangbin Liu
This patch adds two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to extend xdp_redirect_map for broadcast support. With BPF_F_BROADCAST the packet will be broadcasted to all the interfaces in the map. with BPF_F_EXCLUDE_INGRESS the ingress interface will be excluded when do broadcasting. When

Re: [PATCH v2 0/7] remove different PHY fixups

2021-04-13 Thread Oleksij Rempel
Hello, On Tue, Mar 30, 2021 at 12:04:50PM -0300, Fabio Estevam wrote: > Hi Andrew, > > On Tue, Mar 30, 2021 at 11:30 AM Andrew Lunn wrote: > > > Hi Fabio > > > > I think it should be merged, and we fixup anything which does break. > > We are probably at the point where more is broken by not mer

[PATCHv5 bpf-next 4/4] selftests/bpf: add xdp_redirect_multi test

2021-04-13 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test there are 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. Two maps (DEVMAP, DEVMAP_HASH) and two xdp

[PATCHv5 bpf-next 3/4] sample/bpf: add xdp_redirect_map_multi for redirect_map broadcast test

2021-04-13 Thread Hangbin Liu
This is a sample for xdp redirect broadcast. In the sample we could forward all packets between given interfaces. There is also an option -X that could enable 2nd xdp_prog on egress interface. Signed-off-by: Hangbin Liu --- samples/bpf/Makefile | 3 + samples/bpf/xdp_redir

[PATCH] nfc: st-nci: remove unnecessary label

2021-04-13 Thread samirweng1979
From: wengjianfeng in st_nci_spi_write function, first assign a value to a variable then goto exit label. return statement just follow the label and exit label just used once, so we should directly return and remove exit label. Signed-off-by: wengjianfeng --- drivers/nfc/st-nci/spi.c | 7 ++---

[PATCH] rsi: remove unused including

2021-04-13 Thread Yang Li
Fix the following versioncheck warning: ./drivers/net/wireless/rsi/rsi_91x_ps.c: 19 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/wireless/rsi/rsi_91x_ps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_ps.c b/d

pull-request: can-next 2021-04-13

2021-04-13 Thread Marc Kleine-Budde
/git/mkl/linux-can-next.git tags/linux-can-next-for-5.13-20210413 for you to fetch changes up to bd573ea5720470d1ea70f3e39fb2e2efad219311: can: peak_usb: pcan_usb: replace open coded endianness conversion of unaligned data (2021-04-13 10:15:44 +0200

[net-next 06/14] can: peak_usb: pcan_usb_pro.h: remove double space in indention

2021-04-13 Thread Marc Kleine-Budde
This patch replaces the double space indention after the u8 with a single space in pcan_usb_pro.h. Link: https://lore.kernel.org/r/20210406111622.1874957-3-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_

[net-next 01/14] dt-bindings: net: can: rcar_can: Document r8a77961 support

2021-04-13 Thread Marc Kleine-Budde
From: Yoshihiro Shimoda Document SoC specific bindings for R-Car M3-W+ (r8a77961) SoC. Also as R8A7796 is now called R8A77960 so that update those references. Link: https://lore.kernel.org/r/2021040920.2317696-1-yoshihiro.shimoda...@renesas.com Signed-off-by: Yoshihiro Shimoda Reviewed-by

[net-next 02/14] can: etas_es58x: add core support for ETAS ES58X CAN USB interfaces

2021-04-13 Thread Marc Kleine-Budde
From: Vincent Mailhol This patch adds the core support for various USB CAN interfaces from ETAS GmbH (https://www.etas.com/en/products/es58x.php). The next patches add the glue code drivers for the individual interfaces. Link: https://lore.kernel.org/r/20210410095948.233305-2-mailhol.vinc...@wa

[net-next 03/14] can: etas_es58x: add support for ETAS ES581.4 CAN USB interface

2021-04-13 Thread Marc Kleine-Budde
From: Vincent Mailhol This patch adds support for the ES581.4 interface from ETAS GmbH (https://www.etas.com/en/products/es58x.php). Link: https://lore.kernel.org/r/20210410095948.233305-3-mailhol.vinc...@wanadoo.fr Co-developed-by: Arunachalam Santhanam Signed-off-by: Arunachalam Santhanam S

[net-next 10/14] can: peak_usb: pcan_usb_{,pro}_get_device_id(): remove unneeded check for device_id

2021-04-13 Thread Marc Kleine-Budde
The callback struct peak_usb_adapter::dev_get_device_id, which is implemented by the functions pcan_usb_{,pro}_get_device_id() is only ever called with a valid device_id pointer. This patch removes the unneeded check if the device_id pointer is valid. Link: https://lore.kernel.org/r/2021040611162

[net-next 07/14] can: peak_usb: remove unused variables from struct peak_usb_device

2021-04-13 Thread Marc Kleine-Budde
This patch removes the unused variables struct peak_usb_device::echo_skb and struct peak_usb_device::bus_load from the driver. Link: https://lore.kernel.org/r/20210406111622.1874957-4-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --

[net-next 08/14] can: peak_usb: remove write only variable struct peak_usb_adapter::ts_period

2021-04-13 Thread Marc Kleine-Budde
The variable struct peak_usb_adapter::ts_period is only ever written to. This patch removes it from the driver. Link: https://lore.kernel.org/r/20210406111622.1874957-5-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/

[net-next 09/14] can: peak_usb: peak_usb_probe(): make use of driver_info

2021-04-13 Thread Marc Kleine-Budde
There's no need to iterate over all supported adapters to find the struct peak_usb_adapter that describes the currently probed devices's capabilities. The driver core gives us the information for free, if we assign it to the struct usb_device_id::driver_info. This patch assigns the usb_device_id::

[net-next 14/14] can: peak_usb: pcan_usb: replace open coded endianness conversion of unaligned data

2021-04-13 Thread Marc Kleine-Budde
This patch replaces the open coded endianness conversion of unaligned data by the appropriate get/put_unaligned_leXX() variants. Link: https://lore.kernel.org/r/20210406111622.1874957-11-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde

[net-next 13/14] can: peak_usb: pcan_usb_get_serial(): unconditionally assign serial_number

2021-04-13 Thread Marc Kleine-Budde
The function serial_number is only called from one location with a valid serial_number pointer. Remove not needed NULL pointer check. Link: https://lore.kernel.org/r/20210406111622.1874957-10-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-B

[net-next 05/14] can: peak_usb: fix checkpatch warnings

2021-04-13 Thread Marc Kleine-Budde
This patch cleans several checkpatch warnings in the peak_usb driver. Link: https://lore.kernel.org/r/20210406111622.1874957-2-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb.c | 4 ++--

[net-next 12/14] can: peak_usb: pcan_usb_get_serial(): make use of le32_to_cpup()

2021-04-13 Thread Marc Kleine-Budde
This patch replaces the memcpy() + le32_to_cpu() by le32_to_cpup(). Link: https://lore.kernel.org/r/20210406111622.1874957-9-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/peak_usb/pcan_usb.c | 8 ++-- 1

[net-next 11/14] can: peak_usb: pcan_usb_get_serial(): remove error message from error path

2021-04-13 Thread Marc Kleine-Budde
The caller of pcan_usb_get_serial() already prints an error message, so remove this one and return immediately. Link: https://lore.kernel.org/r/20210406111622.1874957-8-...@pengutronix.de Acked-by: Stephane Grosjean Tested-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- drivers/net/

[net-next 04/14] can: etas_es58x: add support for the ETAS ES58X_FD CAN USB interfaces

2021-04-13 Thread Marc Kleine-Budde
From: Vincent Mailhol This patch add support for the ES582.1 and ES584.1 interfaces from ETAS GmbH (https://www.etas.com/en/products/es58x.php). Link: https://lore.kernel.org/r/20210410095948.233305-4-mailhol.vinc...@wanadoo.fr Co-developed-by: Arunachalam Santhanam Signed-off-by: Arunachalam

[PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Yang Li
Fix the following coccicheck warnings: ./tools/testing/selftests/bpf/progs/profiler.inc.h:189:7-11: WARNING comparing pointer to 0, suggest !E ./tools/testing/selftests/bpf/progs/profiler.inc.h:361:7-11: WARNING comparing pointer to 0, suggest !E ./tools/testing/selftests/bpf/progs/profiler.inc.h:3

Re: [RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-13 Thread René van Dorst
Quoting DENG Qingfang : On Mon, Apr 12, 2021 at 11:08:36PM +0800, DENG Qingfang wrote: On Mon, Apr 12, 2021 at 07:04:49AM +, René van Dorst wrote: > Hi Qingfang, > > +static void mtk_phy_config_init(struct phy_device *phydev) > > +{ > > + /* Disable EEE */ > > + phy_write_mmd(phydev

RE: [EXT] Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Stefan Chulski
> > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: Tuesday, April 13, 2021 12:18 PM > > To: Stefan Chulski > > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > > da...@davemloft.net; Nadav Haklai ; Yan > Markman > > ; linux-ker...@vger.kernel.org; > k...@

Re: [PATCH v3] dt-bindings: net: can: rcar_can: Document r8a77961 support

2021-04-13 Thread Marc Kleine-Budde
On 4/9/21 2:00 AM, Yoshihiro Shimoda wrote: > Document SoC specific bindings for R-Car M3-W+ (r8a77961) SoC. > > Also as R8A7796 is now called R8A77960 so that update those > references. > > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Geert Uytterhoeven > Acked-by: Rob Herring > Reviewed-b

[PATCH] esp6: Simplify the calculation of variables

2021-04-13 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./net/ipv6/esp6_offload.c:321:32-34: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- net/ipv6/esp6_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/esp6_offload

Re: [EXT] Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Marcin Wojtas
Hi Stefan, wt., 13 kwi 2021 o 11:56 Stefan Chulski napisał(a): > > > > -Original Message- > > > From: Russell King - ARM Linux admin > > > Sent: Tuesday, April 13, 2021 12:18 PM > > > To: Stefan Chulski > > > Cc: netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > > > da...@davemlof

Re: [PATCH v2 0/7] remove different PHY fixups

2021-04-13 Thread Lucas Stach
Hi all, Am Dienstag, dem 09.03.2021 um 12:26 +0100 schrieb Oleksij Rempel: > changes v2: > - rebase against latest kernel > - fix networking on RIoTBoard > > This patch series tries to remove most of the imx6 and imx7 board > specific PHY configuration via fixup, as this breaks the PHYs when > co

RE: [EXT] Re: [PATCH net-next] net: mvpp2: Add parsing support for different IPv4 IHL values

2021-04-13 Thread Stefan Chulski
> -Original Message- > From: Marcin Wojtas > Sent: Tuesday, April 13, 2021 12:59 PM > To: Stefan Chulski > Cc: Russell King - ARM Linux admin ; > netdev@vger.kernel.org; thomas.petazz...@bootlin.com; > da...@davemloft.net; Nadav Haklai ; Yan > Markman ; linux-ker...@vger.kernel.org; > k

Re: [PATCH net-next 1/2] net: phy: marvell-88x2222: check that link is operational

2021-04-13 Thread Ivan Bornyakov
On Tue, Apr 13, 2021 at 10:23:48AM +0100, Russell King - ARM Linux admin wrote: > On Tue, Apr 13, 2021 at 10:19:30AM +0300, Ivan Bornyakov wrote: > > On Tue, Apr 13, 2021 at 01:40:32AM +0200, Andrew Lunn wrote: > > > On Mon, Apr 12, 2021 at 03:16:59PM +0300, Ivan Bornyakov wrote: > > > > Some SFP m

[PATCH v3 2/2] Bluetooth: Support the vendor specific debug events

2021-04-13 Thread Joseph Hwang
This patch allows a user space process to enable/disable the vendor specific (vs) debug events dynamically through the set experimental feature mgmt interface if CONFIG_BT_FEATURE_VS_DBG_EVT is enabled. Since the debug event feature needs to invoke the callback function provided by the driver, i.e

[PATCH] net/sctp: fix race condition in sctp_destroy_sock

2021-04-13 Thread Or Cohen
If sctp_destroy_sock is called without sock_net(sk)->sctp.addr_wq_lock held and sp->do_auto_asconf is true, then an element is removed from the auto_asconf_splist without any proper locking. This can happen in the following functions: 1. In sctp_accept, if sctp_sock_migrate fails. 2. In inet_creat

[net] tls/chtls: fix kernel panic with tls_toe

2021-04-13 Thread Rohit Maheshwari
If tls_toe is supported by any device, tls_toe will be enabled and tls context will be created for listen sockets. But the connections established in stack issue context delete for every connection close, this causes kernel panic. As part of the fix, if tls_toe is supported, don't initialize tcp_

Re: [PATCH net-next v2 1/1] netfilter: flowtable: Add FLOW_OFFLOAD_XMIT_UNSPEC xmit type

2021-04-13 Thread Pablo Neira Ayuso
On Tue, Apr 13, 2021 at 11:06:05AM +0300, Roi Dayan wrote: > It could be xmit type was not set and would default to FLOW_OFFLOAD_XMIT_NEIGH > and in this type the gc expect to have a route info. > Fix that by adding FLOW_OFFLOAD_XMIT_UNSPEC which defaults to 0. Applied, thanks. diff --git a/net/n

[PATCH net-next] ionic: return -EFAULT if copy_to_user() fails

2021-04-13 Thread Dan Carpenter
The copy_to_user() function returns the number of bytes that it wasn't able to copy. We want to return -EFAULT to the user. Fixes: fee6efce565d ("ionic: add hw timestamp support files") Signed-off-by: Dan Carpenter --- drivers/net/ethernet/pensando/ionic/ionic_phc.c | 4 +++- 1 file changed, 3

Re: xen-netback hotplug-status regression bug

2021-04-13 Thread Michael Brown
On 13/04/2021 08:12, Paul Durrant wrote: If the frontend subsequently disconnects and reconnects (e.g. transitions through Closed->Initialising->Connected) then: - Nothing recreates "hotplug-status" - When the frontend re-enters Connected state, connect() sets up a watch on "hotplug-status" a

Re: [PATCH v2 0/7] remove different PHY fixups

2021-04-13 Thread Russell King - ARM Linux admin
On Tue, Apr 13, 2021 at 12:00:45PM +0200, Lucas Stach wrote: > I agree with the opinion that those PHY fixups introduce more harm than > good. Essentially they are pushing board specific configuration values > into the PHY, without any checks that the fixup is even running on the > specific board i

Re: xen-netback hotplug-status regression bug

2021-04-13 Thread Paul Durrant
On 13/04/2021 11:48, Michael Brown wrote: On 13/04/2021 08:12, Paul Durrant wrote: If the frontend subsequently disconnects and reconnects (e.g. transitions through Closed->Initialising->Connected) then: - Nothing recreates "hotplug-status" - When the frontend re-enters Connected state, conne

Re: [PATCH v2 0/7] remove different PHY fixups

2021-04-13 Thread Lucas Stach
Hi Russell, sorry for the noise of this arriving in your inbox twice. Apparently I messed up and replied in private in my last mail. Am Dienstag, dem 13.04.2021 um 11:51 +0100 schrieb Russell King - ARM Linux admin: > On Tue, Apr 13, 2021 at 12:00:45PM +0200, Lucas Stach wrote: > > I agree with

Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS

2021-04-13 Thread Haakon Bugge
> On 13 Apr 2021, at 08:29, Leon Romanovsky wrote: > > On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote: >> On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote: >>> ib_modify_qp() is an expensive operation on some HCAs running >>> virtualized. This series removes two ib_m

Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS

2021-04-13 Thread Leon Romanovsky
On Tue, Apr 13, 2021 at 11:13:38AM +, Haakon Bugge wrote: > > > > On 13 Apr 2021, at 08:29, Leon Romanovsky wrote: > > > > On Mon, Apr 12, 2021 at 07:58:47PM -0300, Jason Gunthorpe wrote: > >> On Wed, Mar 31, 2021 at 08:43:12PM +0200, Håkon Bugge wrote: > >>> ib_modify_qp() is an expensive

[PATCH] can: etas_es58x: fix null pointer dereference when handling error frames

2021-04-13 Thread Vincent Mailhol
During the handling of CAN bus errors, a CAN error SKB is allocated using alloc_can_err_skb(). Even if the allocation of the SKB fails, the function continues in order to do the stats handling. All access to the can_frame pointer (cf) should be guarded by an if statement: if (cf) However,

Re: [PATCH] can: etas_es58x: fix null pointer dereference when handling error frames

2021-04-13 Thread Marc Kleine-Budde
On 13.04.2021 20:42:42, Vincent Mailhol wrote: > During the handling of CAN bus errors, a CAN error SKB is allocated > using alloc_can_err_skb(). Even if the allocation of the SKB fails, > the function continues in order to do the stats handling. > > All access to the can_frame pointer (cf) should

[PATCH v3 net-next] net: multipath routing: configurable seed

2021-04-13 Thread Balaev Pavel
Ability for a user to assign seed value to multipath route hashes. Now kernel uses random seed value to prevent hash-flooding DoS attacks; however, it disables some use cases, f.e: +---++--+++ | |-eth0---| FW0 |---eth0-|| | |+--+

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Joakim Zhang
Hi Jon, > -Original Message- > From: Jon Hunter > Sent: 2021年4月13日 16:41 > To: Joakim Zhang ; Giuseppe Cavallaro > ; Alexandre Torgue ; > Jose Abreu > Cc: netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra ; > Jakub Kicinski > Subject: Re: Regression v5.12-rc3: net: stmm

  1   2   3   4   >