[PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

From: Norman Maurer Support for UDP_GRO was added in the past but the implementation for getsockopt was missed which did lead to an error when we tried to retrieve the setting for UDP_GRO. This patch adds the missing switch case for UDP_GRO Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

> On 1. Apr 2021, at 02:18, David Ahern wrote: > > On 3/31/21 7:10 AM, Norman Maurer wrote: >> Friendly ping… >> >> As this missing change was most likely an oversight in the original commit I >> do think it should go into 5.12 and subsequently stable as well. That’s also >> the reason why

[PATCH] include: net: Remove repeated struct declaration

struct ctl_table_header is declared twice. One is declared at 46th line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- include/net/net_namespace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

在 2021/3/31 下午4:11, Michael S. Tsirkin 写道: On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo wrote: On Wed, 13 Jan 2021 08:18:19 -0800, Eric Dumazet wrote: From: Eric Dumazet Both virtio net and napi_get_frags() allocate skbs with a

[PATCH] linux/bpf.h: Remove repeated struct declaration

struct btf_type is declared twice. One is declared at 35th line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- include/linux/bpf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 3625f019767d..2fd8e775a17e 1006

Re: [PATCH net-next v1 3/3] net: fec: add basic selftest support

On Wed, Mar 31, 2021 at 02:27:19PM +0200, Andrew Lunn wrote: > On Tue, Mar 30, 2021 at 03:54:07PM +0200, Oleksij Rempel wrote: > > Port some parts of the stmmac selftest to the FEC. This patch was tested > > on iMX6DL. > > With this tests it is possible to detect some basic issues like: > > - MAC l

Re: [Patch bpf-next v8 03/16] net: introduce skb_send_sock() for sock_map

On Wed, Mar 31, 2021 at 04:32 AM CEST, Cong Wang wrote: > From: Cong Wang > > We only have skb_send_sock_locked() which requires callers > to use lock_sock(). Introduce a variant skb_send_sock() > which locks on its own, callers do not need to lock it > any more. This will save us from adding a ->

[PATCH] net: smc: Remove repeated struct declaration

struct smc_clc_msg_local is declared twice. One is declared at 301st line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- net/smc/smc_core.h | 1 - 1 file changed, 1 deletion(-) diff --git a/net/smc/smc_core.h b/net/smc/smc_core.h index e8e448771f85..6d6fd1397c

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

On Thu, Apr 01, 2021 at 03:23:05AM +0200, danilokrummr...@dk-develop.de wrote: > On 2021-03-31 20:35, Russell King - ARM Linux admin wrote: > > On Wed, Mar 31, 2021 at 07:58:33PM +0200, danilokrummr...@dk-develop.de > > wrote: > > > For this cited change the only thing happening is that if > > > ge

[PATCH bpf-next] cpumap: bulk skb using netif_receive_skb_list

Rely on netif_receive_skb_list routine to send skbs converted from xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. The proposed patch has been tested running xdp_redirect_cpu bpf sample available in the kernel tree that is used to redirect UDP frames from ixgbe driver to a cpum

Re: [PATCH 05/18] iommu/fsl_pamu: remove support for multiple windows

On Tue, Mar 30, 2021 at 01:22:34PM +0100, Will Deacon wrote: > > * win_arr contains information of the configured > > * windows for a domain. This is allocated only > > * when the number of windows for the domain are > > * set. > > */ > > The last part of this comment is n

Re: [PATCH 06/18] iommu/fsl_pamu: remove ->domain_window_enable

On Tue, Mar 30, 2021 at 01:40:09PM +0100, Will Deacon wrote: > > + ret = pamu_config_ppaace(liodn, geom->aperture_start, > > +geom->aperture_end - 1, ~(u32)0, > > You're passing 'geom->aperture_end - 1' as the size here, but the old code > seemed to _add_ 1: > > > -

Re: [PATCH 08/18] iommu/fsl_pamu: merge pamu_set_liodn and map_liodn

On Tue, Mar 30, 2021 at 01:46:51PM +0100, Will Deacon wrote: > > + ret = pamu_config_ppaace(liodn, geom->aperture_start, > > +geom->aperture_end - 1, ~(u32)0, > > +0, dma_domain->snoop_id, dma_domain->stash_id, > > +

[PATCH] net/rxrpc: Fix a use after free in rxrpc_input_packet

In the case RXRPC_PACKET_TYPE_DATA of rxrpc_input_packet, if skb_unshare(skb,..) failed, it will free the skb and return NULL. But if skb_unshare() return NULL, the freed skb will be used by rxrpc_eaten_skb(skb,..). I see that rxrpc_eaten_skb() is used to drop a ref of skb. As the skb is already f

Re: [PATCH 11/18] iommu/fsl_pamu: remove the snoop_id field

On Tue, Mar 30, 2021 at 01:58:17PM +0100, Will Deacon wrote: > pamu_config_ppaace() takes quite a few useless parameters at this stage, > but anyway: I'll see it it makes sense to throw in another patch at the end to cut it down a bit more. > Acked-by: Will Deacon > > Do you know if this driver

[PATCH] net: hns: Fix some typos

Fix some typos. Reported-by: Hulk Robot Signed-off-by: Lu Wei --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index c66a7a51

Re: [PATCH net] net: fix hangup on napi_disable for threaded napi

On Wed, 2021-03-31 at 18:41 -0700, Jakub Kicinski wrote: > On Thu, 1 Apr 2021 00:46:18 +0200 Paolo Abeni wrote: > > I hit an hangup on napi_disable(), when the threaded > > mode is enabled and the napi is under heavy traffic. > > > > If the relevant napi has been scheduled and the napi_disable()

Re: [PATCH 16/18] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

For now I'll just pass the iommu_domain to iommu_get_dma_strict, so that we can check for it. We can do additional cleanups on top of that later.

Re: [PATCH iproute2] iptoken: Add doc on the conditions of iptoken

On Wed, Mar 31, 2021 at 03:26:02PM -0700, Stephen Hemminger wrote: > It would be better if kernel provided the error messages through external ack > of the netlink message, Agreed. > rather than providing potentially out of date > recommendations on the man page. I still think conditions for ip-

Re: [RFC] add extack errors for iptoken

On Wed, Mar 31, 2021 at 08:49:02PM -0700, Stephen Hemminger wrote: > Perhaps the following (NOT TESTED) kernel patch will show you how such error > messages > could be added. This is an elegant solution. I found extack is extensively used in the other parts of the kernel code for similar purpose

Re: [PATCH for-next v3 1/2] IB/cma: Introduce rdma_set_min_rnr_timer()

On Wed, Mar 31, 2021 at 08:43:13PM +0200, Håkon Bugge wrote: > Introduce the ability for kernel ULPs to adjust the minimum RNR Retry > timer. The INIT -> RTR transition executed by RDMA CM will be used for > this adjustment. This avoids an additional ib_modify_qp() call. > > rdma_set_min_rnr_timer

Re: [PATCHv3 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

Hangbin Liu writes: > On Wed, Mar 31, 2021 at 03:41:17PM +0200, Toke Høiland-Jørgensen wrote: >> > @@ -1491,13 +1492,20 @@ static __always_inline int >> > __bpf_xdp_redirect_map(struct bpf_map *map, u32 ifind >> > */ >> >ri->map_id = INT_MAX; /* Valid map id idr range: [1

Re: [PATCH net 2/2] mptcp: revert "mptcp: provide subflow aware release function"

Paolo Abeni wrote: > This change reverts commit ad98dd37051e ("mptcp: provide subflow aware > release function"). The latter introduced a deadlock spotted by > syzkaller and is not needed anymore after the previous commit. > > Fixes: ad98dd37051e ("mptcp: provide subflow aware release function")

[PATCH 15/20] iommu: remove DOMAIN_ATTR_GEOMETRY

The geometry information can be trivially queried from the iommu_domain struture. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/iommu.c | 20 +++- drivers/vfio/vfio_iommu_type1.c | 26 -- drivers/vho

[PATCH 01/20] iommu: remove the unused domain_window_disable method

domain_window_disable is wired up by fsl_pamu, but never actually called. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/fsl_pamu_domain.c | 48 - include/linux/iommu.h | 2 -- 2 files changed, 50 deletions(

[PATCH 02/20] iommu/fsl_pamu: remove fsl_pamu_get_domain_attr

None of the values returned by this function are ever queried. Also remove the DOMAIN_ATTR_FSL_PAMUV1 enum value that is not otherwise used. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/fsl_pamu_domain.c | 30 -- includ

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

On Wed, Mar 31, 2021 at 07:30:39PM +0800, Xuan Zhuo wrote: > On Wed, 31 Mar 2021 04:11:12 -0400, Michael S. Tsirkin > wrote: > > On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: > > > On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo > > > wrote: > > > > > > > > On Wed, 13 Jan 2021 08:18:

[PATCH 04/20] iommu/fsl_pamu: merge iommu_alloc_dma_domain into fsl_pamu_domain_alloc

Keep the functionality to allocate the domain together. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/fsl_pamu_domain.c | 34 ++--- 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/drivers/iommu/fsl_pamu_do

[PATCH 05/20] iommu/fsl_pamu: remove support for multiple windows

The only domains allocated forces use of a single window. Remove all the code related to multiple window support, as well as the need for qman_portal to force a single window. Remove the now unused DOMAIN_ATTR_WINDOWS iommu_attr. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by:

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

On Wed, Mar 31, 2021 at 08:23:40PM -0500, Bjorn Helgaas wrote: > [+cc Rafael, in case you're interested in the driver core issue here] > > On Wed, Mar 31, 2021 at 07:08:07AM +0300, Leon Romanovsky wrote: > > On Tue, Mar 30, 2021 at 03:41:41PM -0500, Bjorn Helgaas wrote: > > > On Tue, Mar 30, 2021

[PATCH 12/20] iommu/fsl_pamu: remove the rpn and snoop_id arguments to pamu_config_ppaac

These are always wired to fixed values, so don't bother passing them as arguments. Signed-off-by: Christoph Hellwig --- drivers/iommu/fsl_pamu.c| 14 +++--- drivers/iommu/fsl_pamu.h| 3 +-- drivers/iommu/fsl_pamu_domain.c | 6 +++--- 3 files changed, 7 insertions(+), 16

[syzbot] WARNING in bpf_test_run

Hello, syzbot found the following issue on: HEAD commit:36e79851 libbpf: Preserve empty DATASEC BTFs during static.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=1569bb06d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7eff0f22b8563a5f das

[PATCH 19/20] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

Use an explicit set_pgtable_quirks method instead that just passes the actual quirk bitmask instead. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 +- drivers/iommu/arm/arm-smmu/arm-smmu.c | 64 +-

[PATCH 18/20] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

From: Robin Murphy Instead make the global iommu_dma_strict paramete in iommu.c canonical by exporting helpers to get and set it and use those directly in the drivers. This make sure that the iommu.strict parameter also works for the AMD and Intel IOMMU drivers on x86. As those default to lazy

[PATCH net-next 0/3] dpaa2-eth: add rx copybreak support

From: Ioana Ciornei DMA unmapping, allocating a new buffer and DMA mapping it back on the refill path is really not that efficient. Proper buffer recycling (page pool, flipping the page and using the other half) cannot be done for DPAA2 since it's not a ring based controller but it rather deals w

[PATCH 09/20] iommu/fsl_pamu: merge handle_attach_device into fsl_pamu_attach_device

No good reason to split this functionality over two functions. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/fsl_pamu_domain.c | 59 +++-- 1 file changed, 20 insertions(+), 39 deletions(-) diff --git a/drivers/iommu/fsl_

RE: Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-cp110-utmi.o)

Hi, Randy, > -Original Message- > From: Randy Dunlap > Sent: Wednesday, March 31, 2021 18:28 > To: Stephen Rothwell ; Linux Next Mailing List n...@vger.kernel.org> > Cc: Linux Kernel Mailing List ; Kostya > Porotchkin ; netdev@vger.kernel.org > Subject: [EXT] Re: linux-next: Tree for Mar

[PATCH 03/20] iommu/fsl_pamu: remove support for setting DOMAIN_ATTR_GEOMETRY

The default geometry is the same as the one set by qman_port given that FSL_PAMU depends on having 64-bit physical and thus DMA addresses. Remove the support to update the geometry and remove the now pointless geom_size field. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li

Re: [RFC Patch bpf-next] bpf: introduce bpf timer

On Wed, Mar 31, 2021 at 11:38 PM Song Liu wrote: > > > > > On Mar 31, 2021, at 9:26 PM, Cong Wang wrote: > > > > From: Cong Wang > > > > (This patch is still in early stage and obviously incomplete. I am sending > > it out to get some high-level feedbacks. Please kindly ignore any coding > > det

Re: [PATCH net-next 9/9] net: enetc: add support for XDP_REDIRECT

On Thu, Apr 01, 2021 at 01:26:02PM +0200, Toke Høiland-Jørgensen wrote: > > +int enetc_xdp_xmit(struct net_device *ndev, int num_frames, > > + struct xdp_frame **frames, u32 flags) > > +{ > > + struct enetc_tx_swbd xdp_redirect_arr[ENETC_MAX_SKB_FRAGS] = {0}; > > + struct enetc_nde

[PATCH 17/20] iommu: remove iommu_set_cmd_line_dma_api and iommu_cmd_line_dma_api

Don't obsfucate the trivial bit flag check. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon --- drivers/iommu/iommu.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index 58d1d11a8d5c10..052cef11a

Re: [RFC] add extack errors for iptoken

On 3/31/21 9:49 PM, Stephen Hemminger wrote: > @@ -5681,14 +5682,29 @@ static int inet6_set_iftoken(struct inet6_dev *idev, > struct in6_addr *token) > > ASSERT_RTNL(); > > - if (!token) > + if (!token) { You forgot to add a message here. > return -EINVAL; > -

Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-cp110-utmi.o)

On 4/1/21 5:33 AM, Kostya Porotchkin wrote: > Hi, Randy, > >> -Original Message- >> From: Randy Dunlap >> Sent: Wednesday, March 31, 2021 18:28 >> To: Stephen Rothwell ; Linux Next Mailing List > n...@vger.kernel.org> >> Cc: Linux Kernel Mailing List ; Kostya >> Porotchkin ; netdev@vger.k

Re: [RFC] add extack errors for iptoken

On Thu, 1 Apr 2021 08:31:05 -0600 David Ahern wrote: > On 3/31/21 9:49 PM, Stephen Hemminger wrote: > > @@ -5681,14 +5682,29 @@ static int inet6_set_iftoken(struct inet6_dev > > *idev, struct in6_addr *token) > > > > ASSERT_RTNL(); > > > > - if (!token) > > + if (!token) { > > You

RE: [Patch bpf-next v8 13/16] udp: implement udp_bpf_recvmsg() for sockmap

Cong Wang wrote: > From: Cong Wang > > We have to implement udp_bpf_recvmsg() to replace the ->recvmsg() > to retrieve skmsg from ingress_msg. > > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Jakub Sitnicki > Cc: Lorenz Bauer > Signed-off-by: Cong Wang Acked-by: John Fastabend

[PATCH] drivers: net: fix memory leak in peak_usb_create_dev

syzbot reported memory leak in peak_usb. The problem was in case of failure after calling ->dev_init()[2] in peak_usb_create_dev()[1]. The data allocated int dev_init() wasn't freed, so simple ->dev_free() call fix this problem. backtrace: [<79d6542a>] kmalloc include/linux/slab.h:552

[PATCH 10/20] iommu/fsl_pamu: enable the liodn when attaching a device

Instead of a separate call to enable all devices from the list, just enable the liodn once the device is attached to the iommu domain. This also remove the DOMAIN_ATTR_FSL_PAMU_ENABLE iommu_attr. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/fsl_pa

cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver v3

Hi all, there are a bunch of IOMMU APIs that are entirely unused, or only used as a private communication channel between the FSL PAMU driver and it's only consumer, the qbman portal driver. So this series drops a huge chunk of entirely unused FSL PAMU functionality, then drops all kinds of unuse

Re: linux-next: Tree for Mar 31 (drivers/phy/marvell/phy-mvebu-cp110-utmi.o)

On 4/1/21 9:29 AM, Randy Dunlap wrote: > On 4/1/21 5:33 AM, Kostya Porotchkin wrote: >> Hi, Randy, >> >>> -Original Message- >>> From: Randy Dunlap >>> Sent: Wednesday, March 31, 2021 18:28 >>> To: Stephen Rothwell ; Linux Next Mailing List >>> >> n...@vger.kernel.org> >>> Cc: Linux Kerne

Re: [PATCH rdma-next 6/7] RDMA/mlx5: Add support in MEMIC operations

On Thu, Mar 18, 2021 at 01:15:47PM +0200, Leon Romanovsky wrote: > From: Maor Gottlieb > > MEMIC buffer, in addition to regular read and write operations, can > support atomic operations from the host. > > Introduce and implement new UAPI to allocate address space for MEMIC > operations such as

[PATCH net-next] net: phy: broadcom: Add statistics for all Gigabit PHYs

All Gigabit PHYs use the same register layout as far as fetching statistics goes. Fast Ethernet PHYs do not all support statistics, and the BCM54616S would require some switching between the coper and fiber modes to fetch the appropriate statistics which is not supported yet. Signed-off-by: Floria

RE: [Patch bpf-next v8 00/16] sockmap: introduce BPF_SK_SKB_VERDICT and support UDP

Cong Wang wrote: > From: Cong Wang > > We have thousands of services connected to a daemon on every host > via AF_UNIX dgram sockets, after they are moved into VM, we have to > add a proxy to forward these communications from VM to host, because > rewriting thousands of them is not practical. Thi

Re: [PATCH] net: smc: Remove repeated struct declaration

On 01/04/2021 10:40, Wan Jiabing wrote: > struct smc_clc_msg_local is declared twice. One is declared at > 301st line. The blew one is not needed. Remove the duplicate. > > Signed-off-by: Wan Jiabing > --- > net/smc/smc_core.h | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Karsten Graul

Re: [PATCH for-next v3 0/2] Introduce rdma_set_min_rnr_timer() and use it in RDS

On Wed, Mar 31, 2021 at 07:54:17PM +, Santosh Shilimkar wrote: > [...] > > Thanks Haakon. Patchset looks fine by me. > Acked-by: Santosh Shilimkar Jakub/Dave are you OK if I take this RDS patch rdma to rdma's tree? Thanks, Jason

Re: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

On 31/03/2021 12:41, Joakim Zhang wrote: ... >> In answer to your question, resuming from suspend does work on this board >> without your change. We have been testing suspend/resume now on this board >> since Linux v5.8 and so we have the ability to bisect such regressions. So >> it is >> clea

[PATCH 13/20] iommu/fsl_pamu: hardcode the window address and size in pamu_config_ppaace

The win_addr and win_size parameters are always set to 0 and 1 << 36 respectively, so just hard code them. Signed-off-by: Christoph Hellwig --- drivers/iommu/fsl_pamu.c| 23 --- drivers/iommu/fsl_pamu.h| 3 +-- drivers/iommu/fsl_pamu_domain.c | 10 ++

[PATCH 08/20] iommu/fsl_pamu: merge pamu_set_liodn and map_liodn

Merge the two fuctions that configure the ppaace into a single coherent function. I somehow doubt we need the two pamu_config_ppaace calls, but keep the existing behavior just to be on the safe side. Signed-off-by: Christoph Hellwig Acked-by: Li Yang --- drivers/iommu/fsl_pamu_domain.c | 65 ++

[PATCH net-next 3/3] dpaa2-eth: export the rx copybreak value as an ethtool tunable

From: Ioana Ciornei It's useful, especially for debugging purposes, to have the Rx copybreak value changeable at runtime. Export it as an ethtool tunable. Signed-off-by: Ioana Ciornei --- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 +++- .../net/ethernet/freescale/dpaa2/dpaa2-eth.h |

Re: [PATCH net-next 9/9] net: enetc: add support for XDP_REDIRECT

Vladimir Oltean writes: > From: Vladimir Oltean > > The driver implementation of the XDP_REDIRECT action reuses parts from > XDP_TX, most notably the enetc_xdp_tx function which transmits an array > of TX software BDs. Only this time, the buffers don't have DMA mappings, > we need to create them

Re: [PATCH] net/rxrpc: Fix a use after free in rxrpc_input_packet

Lv Yunlong wrote: > In the case RXRPC_PACKET_TYPE_DATA of rxrpc_input_packet, if > skb_unshare(skb,..) failed, it will free the skb and return NULL. > But if skb_unshare() return NULL, the freed skb will be used by > rxrpc_eaten_skb(skb,..). That's not precisely the case: void rxrpc_eat

Re: [PATCH net] net: avoid 32 x truesize under-estimation for tiny skbs

On Wed, Mar 31, 2021 at 10:36:35AM +0200, Eric Dumazet wrote: > On Wed, Mar 31, 2021 at 10:11 AM Michael S. Tsirkin wrote: > > > > On Mon, Mar 29, 2021 at 11:06:09AM +0200, Eric Dumazet wrote: > > > On Mon, Mar 29, 2021 at 10:52 AM Xuan Zhuo > > > wrote: > > > > > > > > On Wed, 13 Jan 2021 08:18

[PATCH 06/20] iommu/fsl_pamu: remove ->domain_window_enable

The only thing that fsl_pamu_window_enable does for the current caller is to fill in the prot value in the only dma_window structure, and to propagate a few values from the iommu_domain_geometry struture into the dma_window. Remove the dma_window entirely, hardcode the prot value and otherwise use

Re: [PATCH net-next 0/9] XDP for NXP ENETC

Vladimir Oltean writes: > On Wed, Mar 31, 2021 at 10:20:18PM +, patchwork-bot+netdev...@kernel.org > wrote: >> Hello: >> >> This series was applied to netdev/net-next.git (refs/heads/master): >> >> On Wed, 31 Mar 2021 23:08:48 +0300 you wrote: >> > From: Vladimir Oltean >> > >> > This serie

[PATCH -next] lan743x: remove redundant semi-colon

Signed-off-by: Yang Yingliang --- drivers/net/ethernet/microchip/lan743x_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index 1c3e204d727c..e7ab5f3f73fd 100644 --- a/drivers/

[PATCH -next] libbpf: remove redundant semi-colon

Signed-off-by: Yang Yingliang --- tools/lib/bpf/linker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c index 46b16cbdcda3..4e08bc07e635 100644 --- a/tools/lib/bpf/linker.c +++ b/tools/lib/bpf/linker.c @@ -1895,7 +1895,7 @@ stat

[PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed

From: Voon Weifeng Intel mgbe supports 2.5G mode operation when PCS is in 1000BASE-X mode. The 2.5G mode of operation is functionally same as 1000BASE-X mode, except that the clock rate is 2.5 times the original rate. In 2.5G mode, the link will operate as 2500Mbps/250Mbps/25Mbps. Hence, 2.5Gbps

[PATCH 07/20] iommu/fsl_pamu: replace DOMAIN_ATTR_FSL_PAMU_STASH with a direct call

Add a fsl_pamu_configure_l1_stash API that qman_portal can call directly instead of indirecting through the iommu attr API. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- arch/powerpc/include/asm/fsl_pamu_stash.h | 12 +++- drivers/iommu/fsl_pamu_domain.c

[PATCH net-next 1/3] dpaa2-eth: rename dpaa2_eth_xdp_release_buf into dpaa2_eth_recycle_buf

From: Ioana Ciornei Rename the dpaa2_eth_xdp_release_buf function into dpaa2_eth_recycle_buf since in the next patches we'll be using the same recycle mechanism for the normal stack path beside for XDP_DROP. Also, rename the array which holds the buffers to be recycled so that it does not have a

[PATCH net-next 2/2] net: pcs: configure xpcs 2.5G speed mode

From: Voon Weifeng Besides setting 2.5G configuration, this patch will also disable automatic speed mode change. This is due to the 2.5G mode is using the same functionality as 1G mode except the clock rate is 2.5 times the original rate. Hence, auto-negotiation is disabled to make sure it will o

[PATCH net-next 0/2] Enable 2.5Gbps speed for stmmac

This patchset enables 2.5Gbps speed mode for stmmac. Link speed mode is detected and configured at serdes power up sequence. For 2.5G, we do not use SGMII in-band AN, we check the link speed mode in the serdes and disable the in-band AN accordingly. iperf3 and ping for 2.5Gbps and regression test

RE: [PATCH net-next v4 0/6] stmmac: Add XDP support

> Hi, > > This is the v4 patch series for adding XDP native support to stmmac. > > Changes in v4: > 5/6: Move TX clean timer setup to the end of NAPI RX process and > group it under stmmac_finalize_xdp_rx(). > Also, fixed stmmac_xdp_xmit_back() returns STMMAC_XDP_CONSUMED > if XDP

Re: [PATCH bpf-next] cpumap: bulk skb using netif_receive_skb_list

On Thu, Apr 1, 2021 at 1:57 AM Lorenzo Bianconi wrote: > > Rely on netif_receive_skb_list routine to send skbs converted from > xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. > The proposed patch has been tested running xdp_redirect_cpu bpf sample > available in the kernel tr

[PATCH net 2/2] mptcp: revert "mptcp: provide subflow aware release function"

This change reverts commit ad98dd37051e ("mptcp: provide subflow aware release function"). The latter introduced a deadlock spotted by syzkaller and is not needed anymore after the previous commit. Fixes: ad98dd37051e ("mptcp: provide subflow aware release function") Signed-off-by: Paolo Abeni --

[PATCH net 1/2] mptcp: forbit mcast-related sockopt on MPTCP sockets

Unrolling mcast state at msk dismantel time is bug prone, as syzkaller reported: == WARNING: possible circular locking dependency detected 5.11.0-syzkaller #0 Not tainted -- syz-executor905/8822

[PATCH net 0/2] mptcp: mptcp: fix deadlock in mptcp{,6}_release

syzkaller has reported a few deadlock triggered by mptcp{,6}_release. These patches address the issue in the easy way - blocking the relevant, multicast related, sockopt options on MPTCP sockets. Note that later on net-next we are going to revert patch 1/2, as a part of a larger MPTCP sockopt imp

[PATCH net-next 1/3] net/mlx5: Add a blank line after declarations.

From: Wenpeng Liang There should be a blank lines after declarations. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li --- drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c| 2 ++ drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c | 1 + 2 files changed, 3 insertions(+) diff --gi

[PATCH net-next 2/3] net/mlx5: Remove return statement exist at the end of void function

From: Wenpeng Liang void function return statements are not generally useful. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li --- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 2 -- drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 1 - drivers/net/ethernet/mellanox/mlx5/core/r

[PATCH net-next 0/3] net/mlx5: Fix some coding-style issues

Just make some cleanups according to the coding style of kernel. Wenpeng Liang (3): net/mlx5: Add a blank line after declarations. net/mlx5: Remove return statement exist at the end of void function net/mlx5: Replace spaces with tab at the start of a line drivers/net/ethernet/mellanox/mlx5

[PATCH net-next 3/3] net/mlx5: Replace spaces with tab at the start of a line

From: Wenpeng Liang There should be no spaces at the start of the line. Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_re

Re: [syzbot] BUG: unable to handle kernel paging request in bpf_trace_run2

syzbot suspects this issue was fixed by commit: commit befe6d946551d65cddbd32b9cb0170b0249fd5ed Author: Steven Rostedt (VMware) Date: Wed Nov 18 14:34:05 2020 + tracepoint: Do not fail unregistering a probe due to memory failure bisection log: https://syzkaller.appspot.com/x/bisect.t

[PATCH 20/20] iommu: remove iommu_domain_{get,set}_attr

Remove the now unused iommu attr infrastructure. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon --- drivers/iommu/iommu.c | 26 -- include/linux/iommu.h | 36 2 files changed, 62 deletions(-) diff --git a/drivers/iommu/iommu.

RE: [Patch bpf-next v8 12/16] skmsg: extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data()

Cong Wang wrote: > From: Cong Wang > > Although these two functions are only used by TCP, they are not > specific to TCP at all, both operate on skmsg and ingress_msg, > so fit in net/core/skmsg.c very well. > > And we will need them for non-TCP, so rename and move them to > skmsg.c and export t

Re: [PATCH net-next 9/9] net: enetc: add support for XDP_REDIRECT

Vladimir Oltean writes: > On Thu, Apr 01, 2021 at 01:39:05PM +0200, Toke Høiland-Jørgensen wrote: >> Vladimir Oltean writes: >> >> > On Thu, Apr 01, 2021 at 01:26:02PM +0200, Toke Høiland-Jørgensen wrote: >> >> > +int enetc_xdp_xmit(struct net_device *ndev, int num_frames, >> >> > +

[PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2021-04-01

This series contains updates to i40e driver only. Arkadiusz fixes warnings for inconsistent indentation. Magnus fixes an issue on xsk receive where single packets over time are batched rather than received immediately. Eryk corrects warnings and reporting of veb-stats. The following are changes

[PATCH net 1/3] i40e: Fix inconsistent indenting

From: Arkadiusz Kubalewski Fixed new static analysis findings: "warn: inconsistent indenting" - introduced lately, reported with lkp and smatch build. Fixes: 4b208eaa8078 ("i40e: Add init and default config of software based DCB") Reported-by: kernel test robot Signed-off-by: Aleksandr Loktiono

Re: [PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

On 4/1/21 12:59 AM, Norman Maurer wrote: > From: Norman Maurer > > Support for UDP_GRO was added in the past but the implementation for > getsockopt was missed which did lead to an error when we tried to > retrieve the setting for UDP_GRO. This patch adds the missing switch > case for UDP_GRO >

[PATCH net 2/3] i40e: fix receiving of single packets in xsk zero-copy mode

From: Magnus Karlsson Fix so that single packets are received immediately instead of in batches of 8. If you sent 1 pps to a system, you received 8 packets every 8 seconds instead of 1 packet every second. The problem behind this was that the work_done reporting from the Tx part of the driver was

[PATCH net 3/3] i40e: Fix display statistics for veb_tc

From: Eryk Rybak If veb-stats was enabled, the ethtool stats triggered a warning due to invalid size: 'unexpected stat size for veb.tc_%u_tx_packets'. This was due to an incorrect structure definition for the statistics. Structures and functions have been improved in line with requirements for th

Re: [PATCH net-next] net: phy: broadcom: Add statistics for all Gigabit PHYs

On Thu, Apr 01, 2021 at 09:42:33AM -0700, Florian Fainelli wrote: > All Gigabit PHYs use the same register layout as far as fetching > statistics goes. Fast Ethernet PHYs do not all support statistics, and > the BCM54616S would require some switching between the coper and fiber > modes to fetch the

Re: [PATCH net-next 9/9] net: enetc: add support for XDP_REDIRECT

Vladimir Oltean writes: > On Thu, Apr 01, 2021 at 01:26:02PM +0200, Toke Høiland-Jørgensen wrote: >> > +int enetc_xdp_xmit(struct net_device *ndev, int num_frames, >> > + struct xdp_frame **frames, u32 flags) >> > +{ >> > + struct enetc_tx_swbd xdp_redirect_arr[ENETC_MAX_SKB_FRAGS] =

Re: [PATCH bpf-next] cpumap: bulk skb using netif_receive_skb_list

> On Thu, Apr 1, 2021 at 1:57 AM Lorenzo Bianconi wrote: > > [...] > > - /* Inject into network stack */ > > - ret = netif_receive_skb_core(skb); > > - if (ret == NET_RX_DROP) > > - drops++; > > I gu

[PATCH 11/20] iommu/fsl_pamu: remove the snoop_id field

The snoop_id is always set to ~(u32)0. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/fsl_pamu_domain.c | 5 ++--- drivers/iommu/fsl_pamu_domain.h | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/fsl_pamu_domain.c b

[PATCH net-next 2/3] dpaa2-eth: add rx copybreak support

From: Ioana Ciornei DMA unmapping, allocating a new buffer and DMA mapping it back on the refill path is really not that efficient. Proper buffer recycling (page pool, flipping the page and using the other half) cannot be done for DPAA2 since it's not a ring based controller but it rather deals w

Re: [PATCH net-next v1 3/3] net: fec: add basic selftest support

On 4/1/21 12:47 AM, Oleksij Rempel wrote: > On Wed, Mar 31, 2021 at 02:27:19PM +0200, Andrew Lunn wrote: >> On Tue, Mar 30, 2021 at 03:54:07PM +0200, Oleksij Rempel wrote: >>> Port some parts of the stmmac selftest to the FEC. This patch was tested >>> on iMX6DL. >>> With this tests it is possible

[PATCH 16/20] iommu: remove DOMAIN_ATTR_NESTING

Use an explicit enable_nesting method instead. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 43 - drivers/iommu/arm/arm-smmu/arm-smmu.c | 30 +++--- drivers/iommu/intel/iommu.c

Re: [PATCH net-next 9/9] net: enetc: add support for XDP_REDIRECT

On Thu, Apr 01, 2021 at 01:39:05PM +0200, Toke Høiland-Jørgensen wrote: > Vladimir Oltean writes: > > > On Thu, Apr 01, 2021 at 01:26:02PM +0200, Toke Høiland-Jørgensen wrote: > >> > +int enetc_xdp_xmit(struct net_device *ndev, int num_frames, > >> > + struct xdp_frame **frames,

[PATCH 14/20] iommu: remove DOMAIN_ATTR_PAGING

DOMAIN_ATTR_PAGING is never used. Signed-off-by: Christoph Hellwig Acked-by: Will Deacon Acked-by: Li Yang --- drivers/iommu/iommu.c | 5 - include/linux/iommu.h | 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index b212bf0261820b..9a4cda3

Re: [PATCH 16/18] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

On Thu, Apr 01, 2021 at 11:59:45AM +0200, Christoph Hellwig wrote: > For now I'll just pass the iommu_domain to iommu_get_dma_strict, > so that we can check for it. We can do additional cleanups on top > of that later. Sounds good to me, cheers! Will

[PATCH net-next v3 0/5] Support for the IOAM Pre-allocated

v3: - Fix warning "unused label 'out_unregister_genl'" by adding conditional macro - Fix lwtunnel output redirect bug: dst cache useless in this case, use orig_output instead v2: - Fix warning with static for __ioam6_fill_trace_data - Fix sparse warning with __force when casting __be64 to _

[PATCH 2/3] PCI/VPD: Remove argument off from pci_vpd_find_tag

All callers pass 0 as offset. Therefore remove the parameter and use a fixed offset 0 in pci_vpd_find_tag(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/broadcom/bnx2.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +-- drivers/net/ethernet/broadcom/bnxt/bn

  1   2   >