[PATCH net-next] mlxsw: spectrum_router: Only perform atomic nexthop bucket replacement when requested

2021-03-30 Thread Ido Schimmel
From: Ido Schimmel When cleared, the 'force' parameter in nexthop bucket replacement notifications indicates that a driver should try to perform an atomic replacement. Meaning, only update the contents of the bucket if it is inactive. Since mlxsw only queries buckets' activity once every second,

Re: [PATCH -next] drivers: net: CONFIG_ATH9K select LEDS_CLASS

2021-03-30 Thread zhangjianhua (E)
hello Pavel,thanks for your reply. for  the a point, I don't know the led lists and cannot find it. for the b point, I look other configs who select LEDS_CLASS, almost all of them select NEW_LEDS,maybe you are right, CONFIG_ATH9K also need select NEW_LEDS too. Best regards, Zhang Jianhua

[PATCH net-next 0/4] net: remove repeated words

2021-03-30 Thread Huazhong Tan
This patch-set removes some repeated words in comments. Peng Li (4): net: i40e: remove repeated words net: bonding: remove repeated word net: phy: remove repeated word net: ipa: remove repeated words drivers/net/bonding/bond_alb.c | 2 +- drivers/net/ethernet/intel/i40e/i40e

[PATCH net-next 3/4] net: phy: remove repeated word

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated word "to". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 8235185..dadf75f 100644 --- a/drivers/ne

[PATCH net-next 4/4] net: ipa: remove repeated words

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated words "that" and "the". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ipa/ipa_endpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 38e83cd..dd

[PATCH net-next 1/4] net: i40e: remove repeated words

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated words "to" and "try". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/in

[PATCH net-next 2/4] net: bonding: remove repeated word

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated word "that". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/bonding/bond_alb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index c3091e0..3455f2c 100644 --

Re: [PATCH net-next 0/4] net: remove repeated words

2021-03-30 Thread Huazhong Tan
Sorry, please ignore this series, will resend later. On 2021/3/30 15:04, Huazhong Tan wrote: This patch-set removes some repeated words in comments. Peng Li (4): net: i40e: remove repeated words net: bonding: remove repeated word net: phy: remove repeated word net: ipa: remove repe

[PATCH 0/6] Clean up obsolete TODO files

2021-03-30 Thread Wang Qing
It is mentioned in the official documents of the Linux Foundation and WIKI that you can participate in its development according to the TODO files of each module. But the TODO files here has not been updated for 15 years, and the function development described in the file have been implemented

[PATCH 4/6] fs/jffs2: Delete obsolete TODO file

2021-03-30 Thread Wang Qing
The TODO file here has not been updated for 14 years, and the function development described in the file have been implemented or abandoned. Its existence will mislead developers seeking to view outdated information. Signed-off-by: Wang Qing --- fs/jffs2/TODO | 37 -

[PATCH 1/6] mips/sgi-ip27: Delete obsolete TODO file

2021-03-30 Thread Wang Qing
The TODO file here has not been updated for 15 years, and the function development described in the file have been implemented or abandoned. Its existence will mislead developers seeking to view outdated information. Signed-off-by: Wang Qing --- arch/mips/sgi-ip27/TODO | 19 ---

[PATCH 3/6] fs/befs: Delete obsolete TODO file

2021-03-30 Thread Wang Qing
The TODO file here has not been updated from 2005, and the function development described in the file have been implemented or abandoned. Its existence will mislead developers seeking to view outdated information. Signed-off-by: Wang Qing --- fs/befs/TODO | 14 -- 1 file changed, 1

[PATCH 2/6] scsi/aacraid: Delete obsolete TODO file

2021-03-30 Thread Wang Qing
The TODO file here has not been updated from 2.6.12 for more than 15 years. Its existence will mislead developers seeking to view outdated information. Signed-off-by: Wang Qing --- drivers/scsi/aacraid/TODO | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 drivers/scsi/aacraid/TODO di

[PATCH 5/6] net/ax25: Delete obsolete TODO file

2021-03-30 Thread Wang Qing
The TODO file here has not been updated for 13 years, and the function development described in the file have been implemented or abandoned. Its existence will mislead developers seeking to view outdated information. Signed-off-by: Wang Qing --- net/ax25/TODO | 20 1 file

[PATCH 6/6] net/decnet: Delete obsolete TODO file

2021-03-30 Thread Wang Qing
The TODO file here has not been updated from 2005, and the function development described in the file have been implemented or abandoned. Its existence will mislead developers seeking to view outdated information. Signed-off-by: Wang Qing --- net/decnet/TODO | 40 --

[RESEND net-next 0/4] net: remove repeated words

2021-03-30 Thread Huazhong Tan
This patch-set removes some repeated words in comments. Peng Li (4): net: i40e: remove repeated words net: bonding: remove repeated word net: phy: remove repeated word net: ipa: remove repeated words drivers/net/bonding/bond_alb.c | 2 +- drivers/net/ethernet/intel/i40e/i40e

[RESEND net-next 1/4] net: i40e: remove repeated words

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated words "to" and "try". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/in

[RESEND net-next 2/4] net: bonding: remove repeated word

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated word "that". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/bonding/bond_alb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index c3091e0..3455f2c 100644 --

[RESEND net-next 3/4] net: phy: remove repeated word

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated word "to". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 8235185..dadf75f 100644 --- a/drivers/ne

[RESEND net-next 4/4] net: ipa: remove repeated words

2021-03-30 Thread Huazhong Tan
From: Peng Li Remove repeated words "that" and "the". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ipa/ipa_endpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 38e83cd..dd

[PATCH bpf-next] bpf: arm64: Redefine MOV consistent with arch insn

2021-03-30 Thread Jianlin Lv
A64_MOV is currently mapped to Add Instruction. Architecturally MOV (register) is an alias of ORR (shifted register) and MOV (to or from SP) is an alias of ADD (immediate). This patch redefines A64_MOV and uses existing functionality aarch64_insn_gen_move_reg() in insn.c to encode MOV (register) in

RE: [PATCH net-next v2 0/5] net: pch: fix and a few cleanups

2021-03-30 Thread Flavio Suligoi
Hi Andy, ... > On Thu, Mar 25, 2021 at 07:34:07PM +0200, Andy Shevchenko wrote: > > The series provides one fix (patch 1) for GPIO to be able to wait for > > the GPIO driver to appear. This is separated from the conversion to > > the GPIO descriptors (patch 2) in order to have a possibility for > >

[syzbot] possible deadlock in ip_mc_drop_socket

2021-03-30 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fb6ec87f net: dsa: Fix type was not set for devlink port git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=12dd978ad0 kernel config: https://syzkaller.appspot.com/x/.config?x=daeff30c2474a60f dashboard li

[PATCH net] nfp: flower: ignore duplicate merge hints from FW

2021-03-30 Thread Simon Horman
From: Yinjun Zhang A merge hint message needs some time to process before the merged flow actually reaches the firmware, during which we may get duplicate merge hints if there're more than one packet that hit the pre-merged flow. And processing duplicate merge hints will cost extra host_ctx's whi

RE: [PATCH net v2] enetc: Avoid implicit sign extension

2021-03-30 Thread David Laight
From: Vladimir Oltean > Sent: 29 March 2021 17:24 > > On Mon, Mar 29, 2021 at 05:14:43PM +0300, Claudiu Manoil wrote: > > Static analysis tool reports: > > "Suspicious implicit sign extension - 'flags' with type u8 (8 bit, > > unsigned) is promoted in 'flags' << 24 to type int (32 bits, signed), >

Re: [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

2021-03-30 Thread Michal Koutný
On Mon, Mar 22, 2021 at 05:02:44PM +0100, Arnd Bergmann wrote: > I'm not sure what is expected to happen for such a configuration, > presumably these functions are never calls in that case. Yes, the functions you patched would only be called from subsystems or there should be no way to obtain a st

Mismatch between tcp_output.c and tcp_fastopen.c in net/ipv4

2021-03-30 Thread Navin P
Hi, I've a question regarding bytes_received and bytes_sent. https://elixir.bootlin.com/linux/latest/source/net/ipv4/tcp_output.c#L1385 In net/ipv4/tcp_output.c if (skb->len != tcp_header_size) { tcp_event_data_sent(tp, sk); tp->data_segs_out += tcp_skb_pcount(skb); tp->bytes_sent += skb->le

Re: [PATCH 06/11] cgroup: fix -Wzero-length-bounds warnings

2021-03-30 Thread Arnd Bergmann
On Tue, Mar 30, 2021 at 10:41 AM Michal Koutný wrote: > > On Mon, Mar 22, 2021 at 05:02:44PM +0100, Arnd Bergmann > wrote: > > I'm not sure what is expected to happen for such a configuration, > > presumably these functions are never calls in that case. > Yes, the functions you patched would onl

Re: [PATCH net v4] net: fix race between napi kthread mode and busy poll

2021-03-30 Thread Martin Zaharinov
Hi Eric and Wei Please check this log : 1584288.951272] napi/eth0-523: page allocation failure: order:0, mode:0x40a20(GFP_ATOMIC|__GFP_COMP), nodemask=(null) [1584289.003674] CPU: 4 PID: 3179 Comm: napi/eth0-523 Tainted: G O 5.11.4 #1 [1584289.055545] Hardware name: Supermicro S

Re: [PATCH bpf-next] bpf: arm64: Redefine MOV consistent with arch insn

2021-03-30 Thread Will Deacon
On Tue, Mar 30, 2021 at 03:42:35PM +0800, Jianlin Lv wrote: > A64_MOV is currently mapped to Add Instruction. Architecturally MOV > (register) is an alias of ORR (shifted register) and MOV (to or from SP) > is an alias of ADD (immediate). > This patch redefines A64_MOV and uses existing functionali

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-30 Thread Lorenz Bauer
On Thu, 25 Mar 2021 at 01:52, Martin KaFai Lau wrote: > > This series adds support to allow bpf program calling kernel function. I think there are more build problems with this. Has anyone hit this before? $ CLANG=clang-12 O=../kbuild/vm ./tools/testing/selftests/bpf/vmtest.sh -j 7 GEN-SKEL [

[PATCH] ppp: deflate: Remove useless call "zlib_inflateEnd"

2021-03-30 Thread Jiapeng Chong
Fix the following whitescan warning: Calling "zlib_inflateEnd(&state->strm)" is only useful for its return value, which is ignored. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/ppp/ppp_deflate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ppp/ppp_def

RE: [PATCH v18 6/7] KVM: arm64: Add support for the KVM PTP service

2021-03-30 Thread Jianyong Wu
Ping ... Any comments? -Original Message- From: Marc Zyngier Sent: Monday, February 8, 2021 9:40 PM To: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; t...@linutronix.de; pbonz...@redhat.com; sea...@google.com; richardcoch...@gmail.com; Mark Rutland ; w...@kernel.or

RE: [PATCH v18 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

2021-03-30 Thread Jianyong Wu
Ping ... -Original Message- From: Marc Zyngier Sent: Monday, February 8, 2021 9:40 PM To: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; t...@linutronix.de; pbonz...@redhat.com; sea...@google.com; richardcoch...@gmail.com; Mark Rutland ; w...@kernel.org; Suzuki Pou

[PATCH] net/rds: Fix a use after free in rds_message_map_pages

2021-03-30 Thread Lv Yunlong
In rds_message_map_pages, the rm is freed by rds_message_put(rm). But rm is still used by rm->data.op_sg in return value. My patch replaces ERR_CAST(rm->data.op_sg) to ERR_PTR(-ENOMEM) to avoid the uaf. Fixes: 7dba92037baf3 ("net/rds: Use ERR_PTR for rds_message_alloc_sgs()") Signed-off-by: Lv Yu

[PATCH net-next v3 4/8] udp: never accept GSO_FRAGLIST packets

2021-03-30 Thread Paolo Abeni
Currently the UDP protocol delivers GSO_FRAGLIST packets to the sockets without the expected segmentation. This change addresses the issue introducing and maintaining a couple of new fields to explicitly accept SKB_GSO_UDP_L4 or GSO_FRAGLIST packets. Additionally updates udp_unexpected_gso() acco

[PATCH net-next v3 3/8] udp: properly complete L4 GRO over UDP tunnel packet

2021-03-30 Thread Paolo Abeni
After the previous patch, the stack can do L4 UDP aggregation on top of a UDP tunnel. In such scenario, udp{4,6}_gro_complete will be called twice. This function will enter its is_flist branch immediately, even though that is only correct on the second call, as GSO_FRAGLIST is only relevant for th

[PATCH net-next v3 6/8] geneve: allow UDP L4 GRO passthrou

2021-03-30 Thread Paolo Abeni
Similar to the previous commit, let even geneve passthrou the L4 GRO packets Signed-off-by: Paolo Abeni --- drivers/net/geneve.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 4ac0373326efd..5d7a2b1469f4c 100644 --- a/drivers/net/geneve.c ++

[PATCH net-next v3 0/8] udp: GRO L4 improvements

2021-03-30 Thread Paolo Abeni
This series improves the UDP L4 - either 'forward' or 'frag_list' - co-existence with UDP tunnel GRO, allowing the first to take place correctly even for encapsulated UDP traffic. The first for patches are mostly bugfixes, addressing some GRO edge-cases when both tunnels and L4 are present, enabl

[PATCH net-next v3 1/8] udp: fixup csum for GSO receive slow path

2021-03-30 Thread Paolo Abeni
When UDP packets generated locally by a socket with UDP_SEGMENT traverse the following path: UDP tunnel(xmit) -> veth (segmentation) -> veth (gro) -> UDP tunnel (rx) -> UDP socket (no UDP_GRO) ip_summed will be set to CHECKSUM_PARTIAL at creation time and such checksum mode will be preser

[PATCH net-next v3 2/8] udp: skip L4 aggregation for UDP tunnel packets

2021-03-30 Thread Paolo Abeni
If NETIF_F_GRO_FRAGLIST or NETIF_F_GRO_UDP_FWD are enabled, and there are UDP tunnels available in the system, udp_gro_receive() could end-up doing L4 aggregation (either SKB_GSO_UDP_L4 or SKB_GSO_FRAGLIST) at the outer UDP tunnel level for packets effectively carrying and UDP tunnel header. That

[PATCH net-next v3 5/8] vxlan: allow L4 GRO passthrough

2021-03-30 Thread Paolo Abeni
When passing up an UDP GSO packet with L4 aggregation, there is no need to segment it at the vxlan level. We can propagate the packet untouched and let it be segmented later, if needed. Introduce an helper to allow let the UDP socket to accept any L4 aggregation and use it in the vxlan driver. v1

[PATCH net-next v3 8/8] selftests: net: add UDP GRO forwarding self-tests

2021-03-30 Thread Paolo Abeni
Create a bunch of virtual topologies and verify that NETIF_F_GRO_FRAGLIST or NETIF_F_GRO_UDP_FWD-enabled devices aggregate the ingress packets as expected. Additionally check that the aggregate packets are segmented correctly when landing on a socket Also test SKB_GSO_FRAGLIST and SKB_GSO_UDP_L4 a

[PATCH net-next v3 7/8] bareudp: allow UDP L4 GRO passthrou

2021-03-30 Thread Paolo Abeni
Similar to the previous commit, let even geneve passthrou the L4 GRO packets Signed-off-by: Paolo Abeni --- drivers/net/bareudp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 7511bca9c15ed..edfad93e7b686 100644 --- a/drivers/net/bareudp.

Re: [PATCH v2 1/1] net: sched: bump refcount for new action in ACT replace mode

2021-03-30 Thread Vlad Buslov
On Tue 30 Mar 2021 at 01:53, Kumar Kartikeya Dwivedi wrote: > Currently, action creation using ACT API in replace mode is buggy. > When invoking for non-existent action index 42, > > tc action replace action bpf obj foo.o sec index 42 > > kernel creates the action, fills up the netlink re

[PATCH net-next] tc-testing: add simple action change test

2021-03-30 Thread Vlad Buslov
Use act_simple to verify that action created with 'tc actions change' command exists after command returns. The goal is to verify internal action API reference counting to ensure that the case when netlink message has NLM_F_REPLACE flag set but action with specified index doesn't exist is handled c

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-30 Thread Hans de Goede
Hi, On 3/22/21 5:02 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/intel_dp.c: In function >

Re: [PATCH net-next] hv_netvsc: Add error handling while switching data path

2021-03-30 Thread Vitaly Kuznetsov
Haiyang Zhang writes: > Add error handling in case of failure to send switching data path message > to the host. > > Reported-by: Shachar Raindel > Signed-off-by: Haiyang Zhang > > --- > drivers/net/hyperv/hyperv_net.h | 6 +- > drivers/net/hyperv/netvsc.c | 35 +++

Re: [RESEND net-next 4/4] net: ipa: remove repeated words

2021-03-30 Thread Alex Elder
On 3/30/21 2:27 AM, Huazhong Tan wrote: From: Peng Li Remove repeated words "that" and "the". Signed-off-by: Peng Li Signed-off-by: Huazhong Tan Acked-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[net-next 01/39] MAINTAINERS: remove Dan Murphy from m_can and tcan4x5x

2021-03-30 Thread Marc Kleine-Budde
Dan Murphy's email address at ti.com doesn't work anymore, mails bounce with: | 550 Invalid recipient (#5.1.1) For now remove all CAN related entries of Dan from the Maintainers file. Link: https://lore.kernel.org/r/20210228094218.40015-1-...@pengutronix.de Signed-off-by: Marc Kleine-Budde ---

pull-request: can-next 2021-03-30

2021-03-30 Thread Marc Kleine-Budde
it/mkl/linux-can-next.git tags/linux-can-next-for-5.13-20210330 for you to fetch changes up to 132f2d45fb2302a582aef617ea766f3fa52a084c: can: c_can: add support to 64 message objects (2021-03-30 11:14:53 +0200) linux-c

[net-next 02/39] MAINTAINERS: Update MCAN MMIO device driver maintainer

2021-03-30 Thread Marc Kleine-Budde
From: Pankaj Sharma Update Chandrasekar Ramakrishnan as maintainer for mcan mmio device driver as I will be moving to a different role. Signed-off-by: Pankaj Sharma Signed-off-by: Marc Kleine-Budde --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS

[net-next 05/39] can: dev: can_free_echo_skb(): extend to return can frame length

2021-03-30 Thread Marc Kleine-Budde
In order to implement byte queue limits (bql) in CAN drivers, the length of the CAN frame needs to be passed into the networking stack even if the transmission failed for some reason. To avoid to calculate this length twice, extend can_free_echo_skb() to return that value. Convert all users of thi

[net-next 06/39] can: add new CAN FD bittiming parameters: Transmitter Delay Compensation (TDC)

2021-03-30 Thread Marc Kleine-Budde
From: Vincent Mailhol At high bit rates, the propagation delay from the TX pin to the RX pin of the transceiver causes measurement errors: the sample point on the RX pin might occur on the previous bit. This issue is addressed in ISO 11898-1 section 11.3.3 "Transmitter delay compensation" (TDC).

[net-next 03/39] can: dev: always create TX echo skb

2021-03-30 Thread Marc Kleine-Budde
So far the creation of the TX echo skb was optional and can be controlled by the local sender of a CAN frame. It turns out that the TX echo CAN skb can be piggybacked to carry information in the driver from the TX- to the TX-complete handler. Several drivers already use the return value of can_ge

[net-next 07/39] can: dev: reorder struct can_priv members for better packing

2021-03-30 Thread Marc Kleine-Budde
From: Vincent Mailhol Save eight bytes of holes on x86-64 architectures by reordering struct can_priv members. Before: $ pahole -C can_priv drivers/net/can/dev/dev.o struct can_priv { struct net_device *dev; /* 0 8 */ struct can_device_statsc

[net-next 04/39] can: dev: can_free_echo_skb(): don't crash the kernel if can_priv::echo_skb is accessed out of bounds

2021-03-30 Thread Marc Kleine-Budde
A out of bounds access to "struct can_priv::echo_skb" leads to a kernel crash. Better print a sensible warning message instead and try to recover. This patch is similar to: | e7a6994d043a ("can: dev: __can_get_echo_skb(): Don't crash the kernel | if can_priv::echo_skb is accessed ou

[net-next 08/39] can: netlink: move '=' operators back to previous line (checkpatch fix)

2021-03-30 Thread Marc Kleine-Budde
From: Vincent Mailhol Fix the warning triggered by having an '=' at the beginning of the line by moving it back to the previous line. Also replace all indentations with a single space so that future entries can be more easily added. Extract of ./scripts/checkpatch.pl -f drivers/net/can/dev/netli

[net-next 10/39] can: bittiming: add CAN_KBPS, CAN_MBPS and CAN_MHZ macros

2021-03-30 Thread Marc Kleine-Budde
From: Vincent Mailhol Add three macro to simplify the readability of big bit timing numbers: - CAN_KBPS: kilobits per second (one thousand) - CAN_MBPS: megabits per second (one million) - CAN_MHZ: megahertz per second (one million) Example: u32 bitrate_max = 8 * CAN_MBPS; s

[net-next 09/39] can: bittiming: add calculation for CAN FD Transmitter Delay Compensation (TDC)

2021-03-30 Thread Marc Kleine-Budde
From: Vincent Mailhol The logic for the tdco calculation is to just reuse the normal sample point: tdco = sp. Because the sample point is expressed in tenth of percent and the tdco is expressed in time quanta, a conversion is needed. At the end, ssp = tdcv + tdco = tdcv + sp. Anot

Re: [BUG / question] in routing rules, some options (e.g. ipproto, sport) cause rules to be ignored in presence of packet marks

2021-03-30 Thread Michal Soltys
On 3/29/21 10:52 PM, Ido Schimmel wrote: On Sun, Mar 28, 2021 at 04:05:29PM +0200, Michal Soltys wrote: Hi, I'm not sure how it behaved in earlier kernels (can check later), but it is / looks bugged in at least recent 5.x+ ones (tests were done with 5.11.8 and 5.10.25). Consider following setu

[net-next 11/39] can: grcan: add missing Kconfig dependency to HAS_IOMEM

2021-03-30 Thread Marc Kleine-Budde
On ARCHs without IOMEM support the grcan driver fails to link due to missing iomem functionality. This patch adds the missing Kconfig dependency to HAS_IOMEM. Link: https://lore.kernel.org/r/20210309140424.3331010-1-...@pengutronix.de Reported-by: kernel test robot Signed-off-by: Marc Kleine-Budd

[net-next 15/39] can: peak_usb: add support of ethtool set_phys_id()

2021-03-30 Thread Marc Kleine-Budde
From: Stephane Grosjean This patch makes it possible to specifically flash the LED of a CAN port of the CAN-USB interfaces of PEAK-System. Link: https://lore.kernel.org/r/20210309122141.3276927-1-...@pengutronix.de Signed-off-by: Stephane Grosjean [mkl: use common prefix PCAN_ for defines] Sign

[net-next 13/39] can: ucan: fix alignment constraints

2021-03-30 Thread Marc Kleine-Budde
From: Arnd Bergmann struct ucan_message_in contains member with 4-byte alignment but is itself marked as unaligned, which triggers a warning: drivers/net/can/usb/ucan.c:249:1: warning: alignment 1 of 'struct ucan_message_in' is less than 4 [-Wpacked-not-aligned] Mark the outer structure to hav

[net-next 18/39] can: m_can: add infrastructure for internal timestamps

2021-03-30 Thread Marc Kleine-Budde
From: Torin Cooper-Bennun Add infrastucture to allow internal timestamps from the M_CAN to be configured and retrieved. Link: https://lore.kernel.org/r/20210308102427.63916-2-to...@maxiluxsystems.com Signed-off-by: Torin Cooper-Bennun Signed-off-by: Marc Kleine-Budde --- drivers/net/can/m_can

[net-next 16/39] can: peak_usb: add support of ONE_SHOT mode

2021-03-30 Thread Marc Kleine-Budde
From: Stephane Grosjean This patch adds "ONE-SHOT" mode support to the following CAN-USB PEAK-System GmbH interfaces: - PCAN-USB X6 - PCAN-USB FD - PCAN-USB Pro FD - PCAN-Chip USB - PCAN-USB Pro Signed-off-by: Stephane Grosjean [mkl: split into two patches] Signed-off-by: Marc Kleine-Budde ---

[net-next 12/39] can: xilinx_can: Simplify code by using dev_err_probe()

2021-03-30 Thread Marc Kleine-Budde
From: Michal Simek Use already prepared dev_err_probe() introduced by commit a787e5400a1c ("driver core: add device probe log helper"). It simplifies EPROBE_DEFER handling. Also unify message format for similar error cases. Link: https://lore.kernel.org/r/91af0945ed7397b08f1af0c829450620bd92b8

[net-next 20/39] can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context

2021-03-30 Thread Marc Kleine-Budde
From: Torin Cooper-Bennun For peripheral devices, m_can sent skbs directly from a threaded irq instead of from a softirq context, breaking the tcan4x5x peripheral driver completely. This patch transitions the driver to use the rx-offload helper for peripherals, ensuring the skbs are sent from the

[net-next 23/39] can: mcp251xfd: simplify UINC handling

2021-03-30 Thread Marc Kleine-Budde
In the patches: | 1f652bb6bae7 can: mcp25xxfd: rx-path: reduce number of SPI core requests to set UINC bit | 68c0c1c7f966 can: mcp251xfd: tef-path: reduce number of SPI core requests to set UINC bit the setting of the UINC bit in the TEF and RX FIFO was batched into a single SPI message consist

[net-next 17/39] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment

2021-03-30 Thread Marc Kleine-Budde
From: Xulin Sun If the CAN net device has been successfully allocated, its private data structure is impossible to be empty, remove this redundant error return judgment. Link: https://lore.kernel.org/r/20210205072559.13241-2-xulin@windriver.com Signed-off-by: Xulin Sun Signed-off-by: Marc K

[net-next 26/39] can: mcp251xfd: add HW timestamp infrastructure

2021-03-30 Thread Marc Kleine-Budde
This patch add the HW timestamping infrastructure. The mcp251xfd has a free running timer of 32 bit width, running at max 40MHz, which wraps around every 107 seconds. The current timestamp is latched into RX and TEF objects automatically be the CAN controller. This patch sets up a cyclecounter, ti

[net-next 24/39] can: mcp251xfd: move netdevice.h to mcp251xfd.h

2021-03-30 Thread Marc Kleine-Budde
The netdevice.h header is needed in mcp251xfd.h, so that it can be included without further headers. Link: https://lore.kernel.org/r/20210304160328.2752293-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 1 - drivers/net/can/spi/mcp251xf

[net-next 14/39] can: peak_usb: pcan_usb_pro_encode_msg(): use macros for flags instead of plain integers

2021-03-30 Thread Marc Kleine-Budde
From: Stephane Grosjean This patch replaces the plain integers used for flags in pcan_usb_pro_encode_msg() by macros which are already defined. Link: https://lore.kernel.org/r/20210309082128.23125-4-s.grosj...@peak-system.com Signed-off-by: Stephane Grosjean [mkl: split into two patches] Signe

[net-next 22/39] can: mcp251xfd: add dev coredump support

2021-03-30 Thread Marc Kleine-Budde
For easier debugging this patch adds dev coredump support to the driver. A dev coredump is generated in case the chip fails to start or an error in the interrupt handler is detected. The dev coredump consists of all chip registers and chip memory, as well as the driver's internal state of the TEF-

[net-next 25/39] can: mcp251xfd: mcp251xfd_get_timestamp(): move to mcp251xfd.h

2021-03-30 Thread Marc Kleine-Budde
This is a preparation patch, it moves the mcp251xfd_get_timestamp() function into the mcp251xfd.h file. Link: https://lore.kernel.org/r/20210304160328.2752293-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 6 -- drivers/net/can/spi/

[net-next 19/39] can: m_can: m_can_chip_config(): enable and configure internal timestamps

2021-03-30 Thread Marc Kleine-Budde
From: Torin Cooper-Bennun This is a prerequisite for transitioning the m_can driver to rx-offload, which works best with TX and RX timestamps. The timestamps provided by M_CAN are 16-bit, timed according to the nominal bit timing, and may be prescaled by a multiplier up to 16. We choose the high

[net-next 28/39] can: c_can: convert block comments to network style comments

2021-03-30 Thread Marc Kleine-Budde
This patch converts all block comments to network subsystem style block comments. Link: https://lore.kernel.org/r/20210304154240.2747987-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 52 ++- drivers/net/can/c_can/c_can_p

[net-next 21/39] can: tcan4x5x: remove duplicate include of regmap.h

2021-03-30 Thread Marc Kleine-Budde
From: Wan Jiabing linux/regmap.h has been included at line 13, so remove the duplicate one at line 14. Fixes: 67def4ef8bb9 ("can: tcan4x5x: move regmap code into seperate file") Link: https://lore.kernel.org/r/20210323021026.140460-1-wanjiab...@vivo.com Signed-off-by: Wan Jiabing Signed-off-by:

[net-next 31/39] can: c_can: fix print formating string

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the print format string in the driver, so that it stays in a single line. Link: https://lore.kernel.org/r/20210304154240.2747987-5-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) d

[net-next 30/39] can: c_can: fix indention

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the indention in the driver. Link: https://lore.kernel.org/r/20210304154240.2747987-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 12 ++-- drivers/net/can/c_can/c_can.h | 10 +- drivers/net/can/c_can/c_can_pci.c

[net-next 35/39] can: c_can: fix indentation

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Link: https://lore.kernel.org/r/20210302215435.18286-3-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kleine-Budde --- dr

[net-next 39/39] can: c_can: add support to 64 message objects

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi D_CAN controller supports 16, 32, 64 or 128 message objects, comparing to 32 on C_CAN. AM335x/AM437x Sitara processors and DRA7 SOC all instantiate a D_CAN controller with 64 message objects, as described in the "DCAN features" subsection of the CAN chapter of their technical

[net-next 38/39] can: c_can: prepare to up the message objects number

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") the "driver casts the 16 message objects in stone, which is completely braindead as contemporary hardware has up to 128 message objects". The patch prepares the module to extend the number of message ob

[net-next 29/39] can: c_can: remove unnecessary blank lines and add suggested ones

2021-03-30 Thread Marc Kleine-Budde
This patch removes unnecessary blank lines and add suggested ones, so that checkpatch doesn't complain anymore. Link: https://lore.kernel.org/r/20210304154240.2747987-3-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 2 -- drivers/net/can/c_can/c_can_p

[net-next 32/39] can: c_can: replace double assignments by two single ones

2021-03-30 Thread Marc Kleine-Budde
This patch replaces the double assignments by two single ones, to make checkpatch happy. Link: https://lore.kernel.org/r/20210304154240.2747987-6-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) dif

[net-next 34/39] can: c_can: remove unused code

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi Commit 9d23a9818cb1 ("can: c_can: Remove unused inline function") left behind C_CAN_MSG_OBJ_TX_LAST constant. Commit fa39b54ccf28 ("can: c_can: Get rid of pointless interrupts") left behind C_CAN_MSG_RX_LOW_LAST and C_CAN_MSG_OBJ_RX_SPLIT constants. The removed code also ma

[net-next 33/39] can: c_can: fix remaining checkpatch warnings

2021-03-30 Thread Marc Kleine-Budde
This patch fixes the remaining checkpatch warnings in the driver. Link: https://lore.kernel.org/r/20210304154240.2747987-7-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/c_can/c_can.c | 3 ++- drivers/net/can/c_can/c_can_pci.c | 2 +- 2 files changed, 3 insertions(+)

[net-next 37/39] can: c_can: use 32-bit write to set arbitration register

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi The arbitration register is already set up with 32-bit writes in the other parts of the code except for this point. Link: https://lore.kernel.org/r/20210302215435.18286-5-dario...@libero.it Signed-off-by: Dario Binacchi Signed-off-by: Marc Kleine-Budde --- drivers/net/can

[net-next 27/39] can: mcp251xfd: add HW timestamp to RX, TX and error CAN frames

2021-03-30 Thread Marc Kleine-Budde
This patch uses the previously added mcp251xfd_skb_set_timestamp() function to convert the timestamp done by the CAN controller into a proper skb hw timestamp. Link: https://lore.kernel.org/r/20210304161209.2754463-1-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- .../net/can/spi/mcp251x

[net-next 36/39] can: c_can: add a comment about IF_RX interface's use

2021-03-30 Thread Marc Kleine-Budde
From: Dario Binacchi After reading the commit 640916db2bf7 ("can: c_can: Make it SMP safe") it may sound strange to see the IF_RX interface used by the can_inval_tx_object function. A comment was added to avoid any misunderstanding. Link: https://lore.kernel.org/r/20210302215435.18286-4-dario...

Re: [PATCH net-next v3 7/7] mld: add mc_lock for protecting per-interface mld data

2021-03-30 Thread Eric Dumazet
On 3/25/21 5:16 PM, Taehee Yoo wrote: > The purpose of this lock is to avoid a bottleneck in the query/report > event handler logic. > > By previous patches, almost all mld data is protected by RTNL. > So, the query and report event handler, which is data path logic > acquires RTNL too. Therefo

Re: [PATCH net-next] net: phy: lan87xx: fix access to wrong register of LAN87xx

2021-03-30 Thread Måns Rullgård
Andre Edich writes: > The function lan87xx_config_aneg_ext was introduced to configure > LAN95xxA but as well writes to undocumented register of LAN87xx. > This fix prevents that access. > > The function lan87xx_config_aneg_ext gets more suitable for the new > behavior name. > > Reported-by: Måns

Re: [PATCH 01/18] iommu: remove the unused domain_window_disable method

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:07PM +0100, Christoph Hellwig wrote: > domain_window_disable is wired up by fsl_pamu, but never actually called. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/fsl_pamu_domain.c | 48 - > include/linux

RE: [PATCH v2 bpf 3/3] libbpf: ignore return values of setsockopt for XDP rings.

2021-03-30 Thread Loftus, Ciara
> > > > > > > > On Fri, Mar 26, 2021 at 02:29:46PM +, Ciara Loftus wrote: > > > > During xsk_socket__create the XDP_RX_RING and XDP_TX_RING > > > setsockopts > > > > are called to create the rx and tx rings for the AF_XDP socket. If the > > > > ring > > > > has already been set up, the setsock

[PATCH -next v2] drivers: net: CONFIG_ATH9K select LEDS_CLASS and NEW_LEDS

2021-03-30 Thread Zhang Jianhua
If CONFIG_ATH9K=y, the following errors will be seen while compiling gpio.c drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds': gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister' gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26 against undef

[PATCH v3 bpf 2/3] libbpf: restore umem state after socket create failure

2021-03-30 Thread Ciara Loftus
If the call to xsk_socket__create fails, the user may want to retry the socket creation using the same umem. Ensure that the umem is in the same state on exit if the call fails by: 1. ensuring the umem _save pointers are unmodified. 2. not unmapping the set of umem rings that were set up with the u

[PATCH v3 bpf 0/3] AF_XDP Socket Creation Fixes

2021-03-30 Thread Ciara Loftus
This series fixes some issues around socket creation for AF_XDP. Patch 1 fixes a potential NULL pointer dereference in xsk_socket__create_shared. Patch 2 ensures that the umem passed to xsk_socket__create(_shared) remains unchanged in event of failure. Patch 3 makes it possible for xsk_socket__c

[PATCH v3 bpf 3/3] libbpf: only create rx and tx XDP rings when necessary

2021-03-30 Thread Ciara Loftus
Prior to this commit xsk_socket__create(_shared) always attempted to create the rx and tx rings for the socket. However this causes an issue when the socket being setup is that which shares the fd with the UMEM. If a previous call to this function failed with this socket after the rings were set up

[PATCH v3 bpf 1/3] libbpf: ensure umem pointer is non-NULL before dereferencing

2021-03-30 Thread Ciara Loftus
Calls to xsk_socket__create dereference the umem to access the fill_save and comp_save pointers. Make sure the umem is non-NULL before doing this. Fixes: 2f6324a3937f ("libbpf: Support shared umems between queues and devices") Acked-by: Magnus Karlsson Signed-off-by: Ciara Loftus --- tools/lib

Re: [PATCH 02/18] iommu/fsl_pamu: remove fsl_pamu_get_domain_attr

2021-03-30 Thread Will Deacon
On Tue, Mar 16, 2021 at 04:38:08PM +0100, Christoph Hellwig wrote: > None of the values returned by this function are ever queried. Also > remove the DOMAIN_ATTR_FSL_PAMUV1 enum value that is not otherwise used. > > Signed-off-by: Christoph Hellwig > Acked-by: Li Yang > --- > drivers/iommu/fsl

  1   2   3   4   >