Re: [PATCH, v2] tools: Remove inclusion of ia64-specific version of errno.h header

2021-03-28 Thread John Paul Adrian Glaubitz
Hello! On 3/23/21 7:04 PM, John Paul Adrian Glaubitz wrote: > There is no longer an ia64-specific version of the errno.h header > below arch/ia64/include/uapi/asm/, so trying to build tools/bpf > fails with: > > CC /usr/src/linux/tools/bpf/bpftool/btf_dumper.o > In file included from /usr

Re: [PATCH] tools: Remove duplicate definition of ia64_mf() on ia64

2021-03-28 Thread John Paul Adrian Glaubitz
Hello! On 3/23/21 7:25 PM, John Paul Adrian Glaubitz wrote: > The ia64_mf() macro defined in tools/arch/ia64/include/asm/barrier.h > is already defined in on ia64 which causes libbpf > failing to build: > > CC /usr/src/linux/tools/bpf/bpftool//libbpf/staticobjs/libbpf.o > In file include

[PATCH] net:tipc: Fix a double free in tipc_sk_mcast_rcv

2021-03-28 Thread Lv Yunlong
In the if(skb_peek(arrvq) == skb) branch, it calls __skb_dequeue(arrvq) to get the skb by skb = skb_peek(arrvq). Then __skb_dequeue() unlinks the skb from arrvq and returns the skb which equals to skb_peek(arrvq). After __skb_dequeue(arrvq) finished, the skb is freed by kfree_skb(__skb_dequeue(arr

[PATCH] drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit

2021-03-28 Thread Lv Yunlong
In pvc_xmit, if __skb_pad(skb, pad, false) failed, it will free the skb in the first time and goto drop. But the same skb is freed by kfree_skb(skb) in the second time in drop. Maintaining the original function unchanged, my patch adds a new label out to avoid the double free if __skb_pad() failed

Re: [PATCH 2/2] enetc: support PTP Sync packet one-step timestamping

2021-03-28 Thread Claudiu Manoil
Hi Yangbo, Pls add the [net-next] prefix to the subject of these patches next time, to avoid the patchwork warnings and let reviewers know where to apply them. On 26.03.2021 10:35, Yangbo Lu wrote: [...]> +netdev_tx_t enetc_xmit(struct sk_buff *skb, struct net_device *ndev) +{ + struct e

[syzbot] bpf-next build error (3)

2021-03-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fddbf4b6 Merge branch 'bpf: Support calling kernel function' git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=11e7a362d0 kernel config: https://syzkaller.appspot.com/x/.config?x=7eff0f22b8563a5f das

Re: [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API

2021-03-28 Thread Kumar Kartikeya Dwivedi
On Sun, Mar 28, 2021 at 10:12:40AM IST, Andrii Nakryiko wrote: > Is there some succinct but complete enough documentation/tutorial/etc > that I can reasonably read to understand kernel APIs provided by TC > (w.r.t. BPF, of course). I'm trying to wrap my head around this and > whether API makes sens

Re: [PATCH v2] net:qrtr: fix atomic idr allocation in qrtr_port_assign()

2021-03-28 Thread Matthew Wilcox
On Sun, Mar 28, 2021 at 08:56:17AM +0200, Greg Kroah-Hartman wrote: > On Sat, Mar 27, 2021 at 03:51:10PM +, Matthew Wilcox wrote: > > On Sat, Mar 27, 2021 at 03:31:18PM +0100, Greg Kroah-Hartman wrote: > > > On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote: > > > > On Sat, Mar 27, 2021

[RFC PATCH bpf-next 0/4] bpf: Tracing programs re-attach

2021-03-28 Thread Jiri Olsa
hi, while adding test for pinning the module while there's trampoline attach to it, I noticed that we don't allow link detach and following re-attach for trampolines. I'm not sure this was on purpose, but seems as natural use of the interface, although the only user is the test for now. You need

[RFC PATCH bpf-next 2/4] selftests/bpf: Add re-attach test to fentry_test

2021-03-28 Thread Jiri Olsa
Adding the test to re-attach (detach/attach again) tracing fentry programs, plus check that already linked program can't be attached again. Fixing the number of check-ed results, which should be 8. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/fentry_test.c| 58 ++---

[RFC PATCH bpf-next 1/4] bpf: Allow trampoline re-attach

2021-03-28 Thread Jiri Olsa
Currently we don't allow re-attaching of trampolines. Once it's detached, it can't be re-attach even when the program is still loaded. Adding the possibility to re-attach the loaded tracing kernel program. Signed-off-by: Jiri Olsa --- kernel/bpf/syscall.c| 25 +++-- kern

[RFC PATCH bpf-next 4/4] selftests/bpf: Test that module can't be unloaded with attached trampoline

2021-03-28 Thread Jiri Olsa
Adding test to verify that once we attach module's trampoline, the module can't be unloaded. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/module_attach.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/module_attach.c

[RFC PATCH bpf-next 3/4] selftests/bpf: Add re-attach test to fexit_test

2021-03-28 Thread Jiri Olsa
Adding the test to re-attach (detach/attach again) tracing fexit programs, plus check that already linked program can't be attached again. Fixing the number of check-ed results, which should be 8. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/fexit_test.c | 58 ++

Re: [PATCH v4 bpf-next 07/12] libbpf: add BPF static linker BTF and BTF.ext support

2021-03-28 Thread Jiri Olsa
On Fri, Mar 19, 2021 at 07:58:13PM +0100, Jiri Olsa wrote: > On Fri, Mar 19, 2021 at 11:39:01AM -0700, Andrii Nakryiko wrote: > > On Fri, Mar 19, 2021 at 9:23 AM Jiri Olsa wrote: > > > > > > On Thu, Mar 18, 2021 at 12:40:31PM -0700, Andrii Nakryiko wrote: > > > > > > SNIP > > > > > > > + > > > > +

[PATCH bpf-next] bpf: tcp: Remove comma which is causing build error

2021-03-28 Thread Atul Gopinathan
Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL enabled is causing a compilation error: "net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before ',' token" Fix this by removing an unnecessary comma. Reported-by: syzbot+0b74d8ec3bf0cc4e4...@syzkaller.appspotmail

[PATCH net-next] qrtr: move to staging

2021-03-28 Thread Greg Kroah-Hartman
There does not seem to be any developers willing to maintain the net/qrtr/ code, so move it to drivers/staging/ so that it can be removed from the kernel tree entirely in a few kernel releases if no one steps up to maintain it. Reported-by: Matthew Wilcox Cc: Du Cheng Signed-off-by: Greg Kroah-H

Re: [PATCH net-next] net/packet: Reset MAC header for direct packet transmission

2021-03-28 Thread Willem de Bruijn
On Fri, Mar 26, 2021 at 11:49 AM Kurt Kanzenbach wrote: > > Reset MAC header in case of using packet_direct_xmit(), e.g. by specifying > PACKET_QDISC_BYPASS. This is needed, because other code such as the HSR layer > expects the MAC header to be correctly set. > > This has been observed using the

[BUG / question] in routing rules, some options (e.g. ipproto, sport) cause rules to be ignored in presence of packet marks

2021-03-28 Thread Michal Soltys
Hi, I'm not sure how it behaved in earlier kernels (can check later), but it is / looks bugged in at least recent 5.x+ ones (tests were done with 5.11.8 and 5.10.25). Consider following setup: # ip -o ad sh 1: loinet 127.0.0.1/8 scope host lo 2: right1inet 10.0.10.2/24 scope global 3

[PATCH net-next] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-28 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

Re: [PATCH net-next 1/3] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol

2021-03-28 Thread Andrew Lunn
On Fri, Mar 26, 2021 at 11:56:46AM +0100, Tobias Waldekranz wrote: > All devices are capable of using regular DSA tags. Support for > Ethertyped DSA tags sort into three categories: > > 1. No support. Older chips fall into this category. > > 2. Full support. Datasheet explicitly supports configur

Re: [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-28 Thread Andrew Lunn
> +static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds) > +{ > + const struct dsa_device_ops *tag_ops = ds->dst->tag_ops; > + struct dsa_switch_tree *dst = ds->dst; > + int port, err; > + > + if (tag_ops->proto == dst->default_proto) > + return 0; > + > +

[PATCH bpf-next] bpf: add 'BPF_RB_MAY_WAKEUP' flag

2021-03-28 Thread Pedro Tammela
The current way to provide a no-op flag to 'bpf_ringbuf_submit()', 'bpf_ringbuf_discard()' and 'bpf_ringbuf_output()' is to provide a '0' value. A '0' value might notify the consumer if it already caught up in processing, so let's provide a more descriptive notation for this value. Signed-off-by:

[PATCH bpf-next] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-03-28 Thread Pedro Tammela
The current code only checks flags in 'bpf_ringbuf_output()'. Signed-off-by: Pedro Tammela --- include/uapi/linux/bpf.h | 8 kernel/bpf/ringbuf.c | 13 +++-- tools/include/uapi/linux/bpf.h | 8 3 files changed, 19 insertions(+), 10 deletions(-) diff -

[PATCH bpf-next] libbpf: Add '_wait()' and '_nowait()' macros for 'bpf_ring_buffer__poll()'

2021-03-28 Thread Pedro Tammela
'bpf_ring_buffer__poll()' abstracts the polling method, so abstract the constants that make the implementation don't wait or wait indefinetly for data. Signed-off-by: Pedro Tammela --- tools/lib/bpf/libbpf.h | 3 +++ tools/testing/selftests/bpf/benchs/bench_ringbu

[PATCH net-next v2] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-28 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

Re: [net-next PATCH 0/8] configuration support for switch headers & phy

2021-03-28 Thread Sunil Kovvuri
On Thu, Mar 25, 2021 at 6:51 PM Andrew Lunn wrote: > > On Thu, Mar 25, 2021 at 06:32:12PM +0530, Sunil Kovvuri wrote: > > On Thu, Mar 25, 2021 at 6:20 PM Andrew Lunn wrote: > > > > > > > > So you completely skipped how this works with mv88e6xxx or > > > > > prestera. If you need this private flag

Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-28 Thread Willem de Bruijn
On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check PROBE messages and call icmp_echo > if a PROBE request is detected. > > Modify the existing icmp_echo function to respond ot both ping and PROBE > requests. > > This was tested using a custom modifica

[PATCH net-next v3] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-28 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

[PATCH net-next 0/7] net: ipa: a few last bits

2021-03-28 Thread Alex Elder
This series incorporates a few last things that didn't fit neatly with patches I've posted recently. The first patch eliminates all remaining kernel-doc warnings. There's still room for kernel-doc improvement, but at least what's there will no longer produce warnings. The next moves the definitio

[PATCH net-next 1/7] net: ipa: fix all kernel-doc warnings

2021-03-28 Thread Alex Elder
Fix all warnings produced when running: scripts/kernel-doc -none drivers/net/ipa/*.[ch] Signed-off-by: Alex Elder --- drivers/net/ipa/gsi_private.h | 2 +- drivers/net/ipa/gsi_trans.h | 5 +++-- drivers/net/ipa/ipa.h | 7 --- drivers/net/ipa/ipa_cmd.h | 19

[PATCH net-next 2/7] net: ipa: store BCR register values in config data

2021-03-28 Thread Alex Elder
The backward compatibility register value is a platform-specific property that is not stored in the platform data. Create a data field where this can be represented, and get rid ipa_reg_bcr_val(). This register is not present starting with IPA v4.5. Signed-off-by: Alex Elder --- drivers/net/ip

[PATCH net-next 5/7] net: ipa: use version based configuration for SC7180

2021-03-28 Thread Alex Elder
Rename the SC7180 configuration data file so that its name is derived from its IPA version. Update a few other references to the code that talk about the SC7180 rather than just IPA v4.2. Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile | 2 +- .../{ipa_data-sc7180.c

[PATCH net-next 3/7] net: ipa: don't define endpoints unnecessarily

2021-03-28 Thread Alex Elder
We don't typically need much information about modem endpoints. Normally we need to specify information about modem endpoints in configuration data in only two cases: - When a modem TX endpoint supports filtering - When another endpoint's configuration refers to it For the first case, the AP i

[PATCH net-next 6/7] net: ipa: DMA addresses are nicely aligned

2021-03-28 Thread Alex Elder
A recent patch avoided doing 64-bit modulo operations by checking the alignment of some DMA allocations using only the lower 32 bits of the address. David Laight pointed out (after the fix was committed) that DMA allocations might already satisfy the alignment requirements. And he was right. Rem

[PATCH net-next 4/7] net: ipa: switch to version based configuration

2021-03-28 Thread Alex Elder
Rename the SDM845 configuration data file so that its name is derived from its IPA version. I am not aware of any special IPA behavior or handling that would be based on a specific SoC (as opposed to a specific version of the IPA it contains). Update a few other references to the code that talk a

[PATCH net-next 7/7] net: ipa: kill IPA_TABLE_ENTRY_SIZE

2021-03-28 Thread Alex Elder
Entries in an IPA route or filter table are 64-bit little-endian addresses, each of which refers to a routing or filtering rule. The format of these table slots are fixed, but IPA_TABLE_ENTRY_SIZE is used to define their size. This symbol doesn't really add value, and I think it unnecessarily obs

Re: [net-next PATCH 0/8] configuration support for switch headers & phy

2021-03-28 Thread Andrew Lunn
> The usecase is simple, unlike DSA tag, this 4byte FDSA tag doesn't > have a ethertype, > so HW cannot recognize this header. If such packers arise, then HW parsing > will > fail and RSS will not work. > > Hypothetically if we introduce some communication between MAC driver > and DSA driver, > w

Re: [PATCH v4 bpf-next 07/12] libbpf: add BPF static linker BTF and BTF.ext support

2021-03-28 Thread Andrii Nakryiko
On Sun, Mar 28, 2021 at 5:03 AM Jiri Olsa wrote: > > On Fri, Mar 19, 2021 at 07:58:13PM +0100, Jiri Olsa wrote: > > On Fri, Mar 19, 2021 at 11:39:01AM -0700, Andrii Nakryiko wrote: > > > On Fri, Mar 19, 2021 at 9:23 AM Jiri Olsa wrote: > > > > > > > > On Thu, Mar 18, 2021 at 12:40:31PM -0700, And

Re: [PATCH bpf-next] bpf: tcp: Remove comma which is causing build error

2021-03-28 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 5:05 AM Atul Gopinathan wrote: > > Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL > enabled is causing a compilation error: > > "net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before > ',' token" > > Fix this by removing an unnecessary

[syzbot] KASAN: slab-out-of-bounds Read in fib6_nh_get_excptn_bucket (3)

2021-03-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7acac4b3 Merge tag 'linux-kselftest-kunit-fixes-5.12-rc5.1.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=102449f6d0 kernel config: https://syzkaller.appspot.com/x/.config?x=5adab0bdee099d7a das

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-28 Thread Bjorn Helgaas
On Sun, Mar 28, 2021 at 12:04:35AM +0100, Heiner Kallweit wrote: > On 26.03.2021 22:26, Bjorn Helgaas wrote: > > [+cc Randy, Andrew (though I'm sure you have zero interest in this > > ancient question :))] > > > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: > >> pci_set_mwi()

Re: [PATCH net-next v5 3/3] smsc95xx: add phylib support

2021-03-28 Thread Måns Rullgård
Andre Edich writes: > Generally, each PHY has their own configuration and it can be done > through an external PHY driver. The smsc95xx driver uses only the > hard-coded internal PHY configuration. > > This patch adds phylib support to probe external PHY drivers for > configuring external PHYs.

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-28 Thread Cong Wang
On Sat, Mar 27, 2021 at 3:54 PM Alexei Starovoitov wrote: > > On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote: > > BTFIDS vmlinux > > FAILED unresolved symbol cubictcp_state > > make: *** [Makefile:1199: vmlinux] Error 255 > > > > I suspect it is related to the kernel config or linker version.

[Patch bpf-next v7 01/13] skmsg: lock ingress_skb when purging

2021-03-28 Thread Cong Wang
From: Cong Wang Currently we purge the ingress_skb queue only when psock refcnt goes down to 0, so locking the queue is not necessary, but in order to be called during ->close, we have to lock it here. Cc: John Fastabend Cc: Daniel Borkmann Cc: Lorenz Bauer Acked-by: Jakub Sitnicki Signed-of

[Patch bpf-next v7 02/13] skmsg: introduce a spinlock to protect ingress_msg

2021-03-28 Thread Cong Wang
From: Cong Wang Currently we rely on lock_sock to protect ingress_msg, it is too big for this, we can actually just use a spinlock to protect this list like protecting other skb queues. __tcp_bpf_recvmsg() is still special because of peeking, it still has to use lock_sock. Cc: John Fastabend C

[Patch bpf-next v7 03/13] net: introduce skb_send_sock() for sock_map

2021-03-28 Thread Cong Wang
From: Cong Wang We only have skb_send_sock_locked() which requires callers to use lock_sock(). Introduce a variant skb_send_sock() which locks on its own, callers do not need to lock it any more. This will save us from adding a ->sendmsg_locked for each protocol. To reuse the code, pass function

[Patch bpf-next v7 06/13] skmsg: use GFP_KERNEL in sk_psock_create_ingress_msg()

2021-03-28 Thread Cong Wang
From: Cong Wang This function is only called in process context. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- net/core/skmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skmsg.c b/net/core/skmsg.c

[Patch bpf-next v7 04/13] skmsg: avoid lock_sock() in sk_psock_backlog()

2021-03-28 Thread Cong Wang
From: Cong Wang We do not have to lock the sock to avoid losing sk_socket, instead we can purge all the ingress queues when we close the socket. Sending or receiving packets after orphaning socket makes no sense. We do purge these queues when psock refcnt reaches zero but here we want to purge t

[Patch bpf-next v7 07/13] sock_map: introduce BPF_SK_SKB_VERDICT

2021-03-28 Thread Cong Wang
From: Cong Wang Reusing BPF_SK_SKB_STREAM_VERDICT is possible but its name is confusing and more importantly we still want to distinguish them from user-space. So we can just reuse the stream verdict code but introduce a new type of eBPF program, skb_verdict. Users are not allowed to set stream_v

[Patch bpf-next v7 10/13] skmsg: extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data()

2021-03-28 Thread Cong Wang
From: Cong Wang Although these two functions are only used by TCP, they are not specific to TCP at all, both operate on skmsg and ingress_msg, so fit in net/core/skmsg.c very well. And we will need them for non-TCP, so rename and move them to skmsg.c and export them to modules. Cc: John Fastabe

[Patch bpf-next v7 00/13] sockmap: introduce BPF_SK_SKB_VERDICT and support UDP

2021-03-28 Thread Cong Wang
From: Cong Wang We have thousands of services connected to a daemon on every host via AF_UNIX dgram sockets, after they are moved into VM, we have to add a proxy to forward these communications from VM to host, because rewriting thousands of them is not practical. This proxy uses an AF_UNIX socke

[Patch bpf-next v7 13/13] selftests/bpf: add a test case for udp sockmap

2021-03-28 Thread Cong Wang
From: Cong Wang Add a test case to ensure redirection between two UDP sockets work. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- .../selftests/bpf/prog_tests/sockmap_listen.c | 136 ++ .../selftests/bpf/progs/test_s

[Patch bpf-next v7 11/13] udp: implement udp_bpf_recvmsg() for sockmap

2021-03-28 Thread Cong Wang
From: Cong Wang We have to implement udp_bpf_recvmsg() to replace the ->recvmsg() to retrieve skmsg from ingress_msg. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- net/ipv4/udp_bpf.c | 64

[Patch bpf-next v7 05/13] skmsg: use rcu work for destroying psock

2021-03-28 Thread Cong Wang
From: Cong Wang The RCU callback sk_psock_destroy() only queues work psock->gc, so we can just switch to rcu work to simplify the code. Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Acked-by: John Fastabend Signed-off-by: Cong Wang --- include/linux/skmsg.h | 5 + net/core/s

[Patch bpf-next v7 08/13] sock: introduce sk->sk_prot->psock_update_sk_prot()

2021-03-28 Thread Cong Wang
From: Cong Wang Currently sockmap calls into each protocol to update the struct proto and replace it. This certainly won't work when the protocol is implemented as a module, for example, AF_UNIX. Introduce a new ops sk->sk_prot->psock_update_sk_prot(), so each protocol can implement its own way

[Patch bpf-next v7 12/13] sock_map: update sock type checks for UDP

2021-03-28 Thread Cong Wang
From: Cong Wang Now UDP supports sockmap and redirection, we can safely update the sock type checks for it accordingly. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- net/core/sock_map.c | 5 - 1 file changed, 4 insertions(+), 1

[Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-28 Thread Cong Wang
From: Cong Wang This is similar to tcp_read_sock(), except we do not need to worry about connections, we just need to retrieve skb from UDP receive queue. Note, the return value of ->read_sock() is unused in sk_psock_verdict_data_ready(). Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitni

Re: [PATCH net-next v5 3/3] smsc95xx: add phylib support

2021-03-28 Thread Heiner Kallweit
On 28.03.2021 21:59, Måns Rullgård wrote: > Andre Edich writes: > >> Generally, each PHY has their own configuration and it can be done >> through an external PHY driver. The smsc95xx driver uses only the >> hard-coded internal PHY configuration. >> >> This patch adds phylib support to probe ext

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-28 Thread Hsu, Chiahao
Leon Romanovsky 於 2021/3/22 08:13 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Mar 22, 2021 at 08:01:17AM +0100, Jürgen Groß wrote: On 22.03.21 07:48, Le

Re: [PATCH net-next v5 3/3] smsc95xx: add phylib support

2021-03-28 Thread Måns Rullgård
Heiner Kallweit writes: > On 28.03.2021 21:59, Måns Rullgård wrote: >> Andre Edich writes: >> >>> Generally, each PHY has their own configuration and it can be done >>> through an external PHY driver. The smsc95xx driver uses only the >>> hard-coded internal PHY configuration. >>> >>> This pat

[PATCH] mac80211: remove redundant assignment of variable result

2021-03-28 Thread Colin King
From: Colin Ian King The variable result is being assigned a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- net/mac80211/tx.c | 2 +- 1 file chan

[PATCH] lan743x: remove redundant intializations of pointers adapter and phydev

2021-03-28 Thread Colin King
From: Colin Ian King The pointers adapter and phydev are being initialized with values that are never read and are being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/ethern

Re: [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-28 Thread Vladimir Oltean
On Sun, Mar 28, 2021 at 05:52:43PM +0200, Andrew Lunn wrote: > > +static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds) > > +{ > > + const struct dsa_device_ops *tag_ops = ds->dst->tag_ops; > > + struct dsa_switch_tree *dst = ds->dst; > > + int port, err; > > + > > + if (tag_ops->

Re: [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-28 Thread Andrew Lunn
On Mon, Mar 29, 2021 at 12:53:09AM +0300, Vladimir Oltean wrote: > On Sun, Mar 28, 2021 at 05:52:43PM +0200, Andrew Lunn wrote: > > > +static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds) > > > +{ > > > + const struct dsa_device_ops *tag_ops = ds->dst->tag_ops; > > > + struct dsa_switch_

[PATCH net-next v4] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-28 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

rtlwifi/rtl8192cu AP mode broken with PS STA

2021-03-28 Thread Maciej S. Szmigiero
Hi, It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS, since the driver does not update its beacon to account for TIM changes, so a station that is sleeping will never learn that it has packets buffered at the AP. Looking at the code, the rtl8192cu driver implements neithe

Re: [Patch bpf-next v7 00/13] sockmap: introduce BPF_SK_SKB_VERDICT and support UDP

2021-03-28 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 01:20:00PM -0700, Cong Wang wrote: > From: Cong Wang > > We have thousands of services connected to a daemon on every host > via AF_UNIX dgram sockets, after they are moved into VM, we have to > add a proxy to forward these communications from VM to host, because > rewriti

Re: [PATCH] ia64: tools: add generic errno.h definition

2021-03-28 Thread Sergei Trofimovich
On Sat, 27 Mar 2021 10:18:18 + Sergei Trofimovich wrote: > On Fri, Mar 12, 2021 at 07:51:35AM +, Sergei Trofimovich wrote: > > Noticed missing header when build bpfilter helper: > > > > CC [U] net/bpfilter/main.o > > In file included from /usr/include/linux/errno.h:1, > >

[PATCH bpf-next] bpf: tcp: Fix an error in the bpf_tcp_ca_kfunc_ids list

2021-03-28 Thread Martin KaFai Lau
There is a typo in the bbr function, s/even/event/. This patch fixes it. Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for bpf-tcp-cc") Signed-off-by: Martin KaFai Lau --- net/ipv4/bpf_tcp_ca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ip

Re: [PATCH] ncsi: internal.h: Fix a spello

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:47 +0530 you wrote: > s/Firware/Firmware/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/ncsi/internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the summary

Re: [PATCH] mptcp: subflow.c: Fix a typo

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:46 +0530 you wrote: > s/concerened/concerned/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/mptcp/subflow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the sum

Re: [PATCH] ipv4: ip_output.c: Couple of typo fixes

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:38 +0530 you wrote: > s/readibility/readability/ > s/insufficent/insufficient/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/ipv4/ip_output.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [PATCH] bearer.h: Spellos fixed

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:37 +0530 you wrote: > s/initalized/initialized/ ...three different places > > Signed-off-by: Bhaskar Chowdhury > --- > net/tipc/bearer.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH] ipv6: addrconf.c: Fix a typo

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:40 +0530 you wrote: > s/Identifers/Identifiers/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/ipv6/addrconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the s

Re: [PATCH v2 0/7] remove different PHY fixups

2021-03-28 Thread Shawn Guo
On Wed, Mar 24, 2021 at 06:54:24AM +0100, Oleksij Rempel wrote: > Hi Shawn, > > ping, do this patches need some ACK from some one? As this will break existing DTBs, I need more ACKs from people to see the consensus that this is the right thing to do. Shawn > > Regards, > Oleksij > > On Tue, M

Re: [PATCH net-next 0/2] selftest: add tests for packet per second

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 14:09:36 +0100 you wrote: > Add self tests for the recently added packet per second rate limiting > feature of the TC policer action[1]. > > The forwarding selftest (patch 2/2) depends on iproute2 supp

Re: [PATCH] drivers: net: smc91x: remove redundant initialization of pointer gpio

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 19:28:47 + you wrote: > From: Colin Ian King > > The pointer gpio is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redu

Re: [PATCH net-next] net: hns3: no return statement in hclge_clear_arfs_rules

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 12:33:39 +0800 you wrote: > From: Liu Jian > > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c: In function > 'hclge_clear_arfs_rules': > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.

Re: [PATCH -next 0/3] Fix some typos

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 10:27:21 +0800 you wrote: > Lu Wei (3): > net: rds: Fix a typo > net: sctp: Fix some typos > net: vsock: Fix a typo > > net/rds/send.c | 2 +- > net/sctp/sm_make_chunk.c | 2 +- > net/

Re: [PATCH 0/9] net: Correct function names in the kerneldoc comments

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 16:15:47 +0800 you wrote: > Xiongfeng Wang (9): > l3mdev: Correct function names in the kerneldoc comments > netlabel: Correct function name netlbl_mgmt_add() in the kerneldoc > comments > net

Re: [PATCH net-next,v2] net: dsa: mt7530: clean up core and TRGMII clock setup

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 23:07:52 -0700 you wrote: > Three minor changes: > > - When disabling PLL, there is no need to call core_write_mmd_indirect > directly, use the core_write wrapper instead like the rest of the code >

Re: [PATCH net-next] nexthop: Rename artifacts related to legacy multipath nexthop groups

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 14:20:22 +0100 you wrote: > After resilient next-hop groups have been added recently, there are two > types of multipath next-hop groups: the legacy "mpath", and the new > "resilient". Calling the legacy

Re: [PATCH net-next v2] net: moxa: remove redundant dev_err call in moxart_mac_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 18:37:54 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 18:31:51 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 17:56:18 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH] mt76: Convert to DEFINE_SHOW_ATTRIBUTE

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 17:56:17 +0800 you wrote: > From: Junlin Yang > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Junlin Yang > --- > .../net/wireless/mediatek/mt76/mt7915/debugfs.c| 36

Re: [PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 18:07:18 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH -next] net: stmmac: fix missing unlock on error in stmmac_suspend()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 17:33:22 +0800 you wrote: > Add the missing unlock before return from stmmac_suspend() > in the error handling case. > > Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver") > Repo

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-28 Thread Alexei Starovoitov
On Fri, Mar 26, 2021 at 9:44 AM Andrii Nakryiko wrote: > > Because they double the maintenance cost now and double the support forever. > > We never needed to worry about skeleton without BTF and now it would be > > a thing ? So all tests realistically need to be doubled: with and without > > BTF

Re: [PATCH bpf-next] bpf: tcp: Fix an error in the bpf_tcp_ca_kfunc_ids list

2021-03-28 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 5:32 PM Martin KaFai Lau wrote: > > There is a typo in the bbr function, s/even/event/. > This patch fixes it. > > Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for > bpf-tcp-cc") > Signed-off-by: Martin KaFai Lau Applied.

Re: [PATCH] drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 28 Mar 2021 00:50:08 -0700 you wrote: > In pvc_xmit, if __skb_pad(skb, pad, false) failed, it will free > the skb in the first time and goto drop. But the same skb is freed > by kfree_skb(skb) in the second time in drop.

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-28 Thread Martin KaFai Lau
On Sun, Mar 28, 2021 at 01:13:35PM -0700, Cong Wang wrote: > On Sat, Mar 27, 2021 at 3:54 PM Alexei Starovoitov > wrote: > > > > On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote: > > > BTFIDS vmlinux > > > FAILED unresolved symbol cubictcp_state > > > make: *** [Makefile:1199: vmlinux] Error 25

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-28 Thread Alexei Starovoitov
On Sat, Mar 27, 2021 at 04:17:16PM +0100, Toke Høiland-Jørgensen wrote: > Alexei Starovoitov writes: > > > On Thu, Mar 25, 2021 at 05:30:03PM +0530, Kumar Kartikeya Dwivedi wrote: > >> This adds some basic tests for the low level bpf_tc_* API and its > >> bpf_program__attach_tc_* wrapper on top.

linux-next: manual merge of the net-next tree with the bpf tree

2021-03-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/linux/bpf.h between commit: 861de02e5f3f ("bpf: Take module reference for trampoline in module") from the bpf tree and commit: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper") from the net-next tre

[PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/mdio/mdio-mux-bcm-iproc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-28 Thread Alexei Starovoitov
On Sat, Mar 27, 2021 at 09:32:58PM -0700, Andrii Nakryiko wrote: > > I think it's better to start with new library for tc/xdp and have > > libbpf as a dependency on that new lib. > > For example we can add it as subdir in tools/lib/bpf/. > > > > Similarly I think integerating static linking into li

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-28 Thread Kumar Kartikeya Dwivedi
On Mon, Mar 29, 2021 at 06:56:02AM IST, Alexei Starovoitov wrote: > This is up to you. I'm trying to understand the motivation for *_block() apis. > I'm not taking a stance for/against them. The block APIs simply attach to a different shared filter block, so in that sense they just forward to the

[PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - 1 file changed, 1 deletion(-) diff -

[PATCH net-next v2] net: stmmac: remove redundant dev_err call in qcom_ethqos_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 - 1 file changed, 1 deletion(-) dif

[PATCH net-next v2] net: mscc: ocelot: remove redundant dev_err call in vsc9959_mdio_bus_alloc()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/dsa/ocelot/felix_vsc9959.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

  1   2   >