Fix the following W=1 kernel build warning(s):
net/core/netevent.c:45: warning: expecting prototype for
netevent_unregister_notifier(). Prototype was for
unregister_netevent_notifier() instead
Reported-by: Hulk Robot
Signed-off-by: Xiongfeng Wang
---
net/core/netevent.c | 2 +-
1 file chang
Fix the following W=1 kernel build warning(s):
net/core/dev_addr_lists.c:732: warning: expecting prototype for
dev_uc_flush(). Prototype was for dev_uc_init() instead
Reported-by: Hulk Robot
Signed-off-by: Xiongfeng Wang
---
net/core/dev_addr_lists.c | 2 +-
1 file changed, 1 insertion(+), 1
Fix the following W=1 kernel build warning(s):
net/nfc/digital_core.c:473: warning: expecting prototype for start_poll
operation(). Prototype was for digital_start_poll() instead
Reported-by: Hulk Robot
Signed-off-by: Xiongfeng Wang
---
net/nfc/digital_core.c | 2 +-
1 file changed, 1 insert
Fix the following W=1 kernel build warning(s):
net/9p/error.c:207: warning: expecting prototype for errstr2errno(). Prototype
was for p9_errstr2errno() instead
Reported-by: Hulk Robot
Signed-off-by: Xiongfeng Wang
---
net/9p/error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Fix the following W=1 kernel build warning(s):
net/netlabel/netlabel_mgmt.c:78: warning: expecting prototype for
netlbl_mgmt_add(). Prototype was for netlbl_mgmt_add_common() instead
Reported-by: Hulk Robot
Signed-off-by: Xiongfeng Wang
---
net/netlabel/netlabel_mgmt.c | 2 +-
1 file changed
Fix the following W=1 kernel build warning(s):
net/l3mdev/l3mdev.c:111: warning: expecting prototype for
l3mdev_master_ifindex(). Prototype was for l3mdev_master_ifindex_rcu() instead
net/l3mdev/l3mdev.c:145: warning: expecting prototype for
l3mdev_master_upper_ifindex_by_index(). Prototype wa
Fix the following W=1 kernel build warning(s):
net/ipv6/ip6_tunnel.c:401: warning: expecting prototype for
parse_tvl_tnl_enc_lim(). Prototype was for ip6_tnl_parse_tlv_enc_lim() instead
Reported-by: Hulk Robot
Signed-off-by: Xiongfeng Wang
---
net/ipv6/ip6_tunnel.c | 2 +-
1 file changed, 1
Xiongfeng Wang (9):
l3mdev: Correct function names in the kerneldoc comments
netlabel: Correct function name netlbl_mgmt_add() in the kerneldoc
comments
net: core: Correct function name dev_uc_flush() in the kerneldoc
net: core: Correct function name netevent_unregister_notifier() in th
Fix the following W=1 kernel build warning(s):
net/9p/client.c:133: warning: expecting prototype for parse_options().
Prototype was for parse_opts() instead
net/9p/client.c:269: warning: expecting prototype for p9_req_alloc().
Prototype was for p9_tag_alloc() instead
Reported-by: Hulk Robot
Fix the following W=1 kernel build warning(s):
net/9p/trans_fd.c:881: warning: expecting prototype for p9_mux_destroy().
Prototype was for p9_conn_destroy() instead
Reported-by: Hulk Robot
Signed-off-by: Xiongfeng Wang
---
net/9p/trans_fd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
> -Original Message-
> From: Alexei Starovoitov
> Sent: Friday, March 26, 2021 10:25 PM
> To: Jianlin Lv
> Cc: bpf ; David S. Miller ;
> Jakub Kicinski ; Alexei Starovoitov ;
> Daniel Borkmann ; Andrii Nakryiko
> ; Martin KaFai Lau ; Song Liu
> ; Yonghong Song ; John Fastabend
> ; KP Si
+ netfilter-de...@vger.kernel.org
On Sat, Mar 27, 2021 at 04:42:48AM +0530, Bhaskar Chowdhury wrote:
> s/registerd/registered/
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
+ netfilter-de...@vger.kernel.org
On Sat, Mar 27, 2021 at 04:43:01AM +0530, Bhaskar Chowdhury wrote:
> s/registerd/registered/
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> d
From: kernel test robot
Opportunity for min()
Generated by: scripts/coccinelle/misc/minmax.cocci
CC: Denis Efremov
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
sit.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@
Add the missing unlock before return from stmmac_suspend()
in the error handling case.
Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver")
Reported-by: Hulk Robot
Signed-off-by: Yang Yingliang
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +++-
1 file changed,
Hi Samudrala,
On Fri, Mar 26, 2021 at 11:45 PM Samudrala, Sridhar
wrote:
> On 3/26/2021 1:06 AM, Geert Uytterhoeven wrote:
> > On Thu, Mar 25, 2021 at 11:29 PM Tony Nguyen
> > wrote:
> > From: Norbert Ciosek
> >
> > Remove padding from RSS structures. Previous layout
> > could lead to unwanted
From: Guobin Huang
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot
Signed-off-by: Guobin Huang
---
drivers/net/wireless/mediatek/mt76/mt7615/soc.c | 4 +---
1 file changed, 1 insertion(+), 3 de
From: Guobin Huang
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().
Reported-by: Hulk Robot
Signed-off-by: Guobin Huang
---
drivers/net/wireless/mac80211_hwsim.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
dif
From: Junlin Yang
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Junlin Yang
---
.../net/wireless/mediatek/mt76/mt7915/debugfs.c| 36 --
.../net/wireless/mediatek/mt76/mt7921/debugfs.c| 18 ++-
2 files changed, 9 insertions(+), 45 delet
From: Guobin Huang
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot
Signed-off-by: Guobin Huang
---
drivers/net/dsa/hirschmann/hellcreek.c | 8 ++--
1 file changed, 2 insertions(+), 6 deleti
On Fri, Mar 12, 2021 at 07:51:35AM +, Sergei Trofimovich wrote:
> Noticed missing header when build bpfilter helper:
>
> CC [U] net/bpfilter/main.o
> In file included from /usr/include/linux/errno.h:1,
>from /usr/include/bits/errno.h:26,
>from /us
From: Guobin Huang
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot
Signed-off-by: Guobin Huang
-
From: Guobin Huang
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot
Signed-off-by: Guobin Huang
---
drivers/net/ethernet/lantiq_xrx200.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From: Guobin Huang
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot
Signed-off-by: Guobin Huang
---
drivers/net/ethernet/moxa/moxart_ether.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/dr
On Sat, Mar 27, 2021 at 09:44:37AM +0800, Du Cheng wrote:
> On Fri, Mar 26, 2021 at 10:31:57AM +0100, Greg Kroah-Hartman wrote:
> > On Fri, Mar 26, 2021 at 11:33:45AM +0800, Du Cheng wrote:
> > > change the allocator flag of idr_alloc_u32 from GFP_ATOMIC to
> > > GFP_KERNEL, as GFP_ATOMIC caused BU
On Fri, Mar 26, 2021 at 2:11 PM Borislav Petkov wrote:
>
> On Fri, Mar 26, 2021 at 09:57:43AM +0100, Sedat Dilek wrote:
> > The commit b90829704780 "bpf: Use NOP_ATOMIC5 instead of
> > emit_nops(&prog, 5) for BPF_TRAMP_F_CALL_ORIG" is now in Linus Git
> > (see [1]).
> >
> > Where will Stephen's fi
On Fri, Mar 26, 2021 at 02:36:31PM -0500, Bjorn Helgaas wrote:
> On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote:
>
> > I almost wonder if it wouldn't make sense to just partition this up to
> > handle flexible resources in the future. Maybe something like having
> > the directory
On Fri, Mar 26, 2021 at 02:09:36PM -0700, Don Bollinger wrote:
> > You keep missing the point. I always refer to the KAPI. The driver we can
> > rework and rework, throw away and reimplement, as much as we want.
> > The KAPI cannot be changed, it is ABI. It is pretty much frozen the day
> the
> > c
`ip token set suffix dev interface' may be unsuccessful
with only the error 'RTNETLINK answers: Invalid argument'
prompted. For users this is mysterious and hard to debug.
Hence a more user-friendly prompt is added.
This commit adds doc for conditions for setting the token and
making the token tak
add idr_preload() and idr_preload_end() around idr_alloc_u32(GFP_ATOMIC)
due to internal use of per_cpu variables, which requires preemption
disabling/enabling.
reported as "BUG: "using smp_processor_id() in preemptible" by syzkaller
Reported-by: syzbot+3eec59e770685e3dc...@syzkaller.appspotmail.
Adding the xarray maintainer...
On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Cheng wrote:
> add idr_preload() and idr_preload_end() around idr_alloc_u32(GFP_ATOMIC)
> due to internal use of per_cpu variables, which requires preemption
> disabling/enabling.
>
> reported as "BUG: "using smp_process
On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote:
> Adding the xarray maintainer...
>
> On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Cheng wrote:
> > add idr_preload() and idr_preload_end() around idr_alloc_u32(GFP_ATOMIC)
> > due to internal use of per_cpu variables, which requi
On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote:
> On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote:
> > Adding the xarray maintainer...
> >
> > On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Cheng wrote:
> > > add idr_preload() and idr_preload_end() around idr_alloc_u32(G
On Fri, Mar 26, 2021 at 11:07:52PM -0700, Ilya Lipnitskiy wrote:
> Three minor changes:
>
> - When disabling PLL, there is no need to call core_write_mmd_indirect
> directly, use the core_write wrapper instead like the rest of the code
> in the function does. This change helps with consistency
Alexei Starovoitov writes:
> On Thu, Mar 25, 2021 at 05:30:03PM +0530, Kumar Kartikeya Dwivedi wrote:
>> This adds some basic tests for the low level bpf_tc_* API and its
>> bpf_program__attach_tc_* wrapper on top.
>
> *_block() apis from patch 3 and 4 are not covered by this selftest.
> Why were
On Sat, Mar 27, 2021 at 1:19 AM Jianlin Lv wrote:
>
> > On Fri, Mar 26, 2021 at 5:40 AM Jianlin Lv wrote:
> > >
> > > When CONFIG_BPF_JIT_ALWAYS_ON is enabled, the value of
> > bpf_jit_enable
> > > in /proc/sys is limited to SYSCTL_ONE. This is not convenient for
> > > debugging.
> > > This patc
> What I have works. Your consumers get quirk handling, mine don't need it.
> No compromise.
Hi Don
All this discussion is now a mute point. GregKH has spoken.
But i'm sure there are some on the side lines, eating popcorn, maybe
learning from the discussion.
Would you think it is O.K. to add a
On Sat, Mar 27, 2021 at 03:31:18PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote:
> > On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote:
> > > Adding the xarray maintainer...
> > >
> > > On Sat, Mar 27, 2021 at 10:07:02PM +0800, Du Che
Arch linux-lts-5.10.25-1 to linux-lts 5.10.26-1
This is on a wireless bonding setup with fallback to wired ethernet.
Everything with the interfaces looks fine, except, for instance, ping returns
the error message "ping: sendmsg: Invalid argument". Of course, networking
becomes unusable.
Remo
On Fri, Mar 26, 2021 at 11:56:48AM +0100, Tobias Waldekranz wrote:
> The 'dsa,tag-protocol' is used to force a switch tree to use a
> particular tag protocol, typically because the Ethernet controller
> that it is connected to is not compatible with the default one.
>
> Signed-off-by: Tobias Walde
Accessing SGE_QBASE_MAP[0-3] and SGE_QBASE_INDEX registers can lead
to SGE missing doorbells under heavy traffic. So, only collect them
when adapter is idle. Also update the regdump range to skip collecting
these registers.
Fixes: 80a95a80d358 ("cxgb4: collect SGE PF/VF queue map")
Signed-off-by:
> Downgrading the kernel resolves the problem, but I don't see any bonding
> commits between linux-lts-5.10.25 and linux-lts 5.10.26.
My mistake - 9392b8219b62b0536df25c9de82b33f8a00881ef *was* included in
5.10.26. Thus the "Invalid argument" message.
https://git.kernel.org/pub/scm/linux/k
On 27.03.2021 19:32, James Feeney wrote:
>
>> Downgrading the kernel resolves the problem, but I don't see any bonding
>> commits between linux-lts-5.10.25 and linux-lts 5.10.26.
>
> My mistake - 9392b8219b62b0536df25c9de82b33f8a00881ef *was* included in
> 5.10.26. Thus the "Invalid argument"
On 3/27/21 3:29 AM, Julia Lawall wrote:
> From: kernel test robot
>
> Opportunity for min()
>
> Generated by: scripts/coccinelle/misc/minmax.cocci
>
> CC: Denis Efremov
> Reported-by: kernel test robot
> Signed-off-by: kernel test robot
> ---
>
> sit.c |2 +-
> 1 file changed, 1 insert
On 3/27/21 2:15 AM, Xiongfeng Wang wrote:
> Fix the following W=1 kernel build warning(s):
>
> net/l3mdev/l3mdev.c:111: warning: expecting prototype for
> l3mdev_master_ifindex(). Prototype was for l3mdev_master_ifindex_rcu() instead
> net/l3mdev/l3mdev.c:145: warning: expecting prototype for
On 3/27/21 2:15 AM, Xiongfeng Wang wrote:
> Fix the following W=1 kernel build warning(s):
>
> net/ipv6/ip6_tunnel.c:401: warning: expecting prototype for
> parse_tvl_tnl_enc_lim(). Prototype was for ip6_tnl_parse_tlv_enc_lim() instead
>
> Reported-by: Hulk Robot
> Signed-off-by: Xiongfeng Wan
> > What I have works. Your consumers get quirk handling, mine don't need
it.
> > No compromise.
>
> Hi Don
>
> All this discussion is now a mute point. GregKH has spoken.
Ack. I actually checked in with Greg a couple of days ago and got that
answer. I just thought the discussion was going in
Hi,
On Wed, Mar 24, 2021 at 8:40 PM Martin KaFai Lau wrote:
> Martin KaFai Lau (14):
> bpf: Simplify freeing logic in linfo and jited_linfo
> bpf: Refactor btf_check_func_arg_match
> bpf: Support bpf program calling kernel function
> bpf: Support kernel function call in x86-32
> tcp: Re
Hi Sedat,
On Sat, 27 Mar 2021 12:50:55 +0100 Sedat Dilek wrote:
>
> I wonder why Stephen's fixup-patch was not carried in recent
> Linux-next releases.
It is part of the tip tree merge commit. So it is not an explicit
commit on its own, but the needed change is there.
> Wild speculation - no r
On Sat, Mar 27, 2021 at 2:25 PM Cong Wang wrote:
>
> Hi,
>
> On Wed, Mar 24, 2021 at 8:40 PM Martin KaFai Lau wrote:
> > Martin KaFai Lau (14):
> > bpf: Simplify freeing logic in linfo and jited_linfo
> > bpf: Refactor btf_check_func_arg_match
> > bpf: Support bpf program calling kernel fun
On Sat, Mar 27, 2021 at 2:28 PM Alexei Starovoitov
wrote:
>
> On Sat, Mar 27, 2021 at 2:25 PM Cong Wang wrote:
> >
> > Hi,
> >
> > On Wed, Mar 24, 2021 at 8:40 PM Martin KaFai Lau wrote:
> > > Martin KaFai Lau (14):
> > > bpf: Simplify freeing logic in linfo and jited_linfo
> > > bpf: Refact
From: Colin Ian King
The variable force is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/mellanox/
On Fri 2021-03-26 16:13:51, Zhang Jianhua wrote:
> If CONFIG_ATH9K=y, the following errors will be seen while compiling
> gpio.c
>
> drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds':
> gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister'
> gpio.c:(.text+0x604)
On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote:
> BTFIDS vmlinux
> FAILED unresolved symbol cubictcp_state
> make: *** [Makefile:1199: vmlinux] Error 255
>
> I suspect it is related to the kernel config or linker version.
>
> # grep TCP_CONG .config
> CONFIG_TCP_CONG_ADVANCED=y
> CONFIG_TCP_CO
From: Colin Ian King
Variable err is assigned -ENODEV followed by an error return path
via label error_out that does not access the variable and returns
with the -ENODEV error return code. The assignment to err is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by:
On 26.03.2021 22:26, Bjorn Helgaas wrote:
> [+cc Randy, Andrew (though I'm sure you have zero interest in this
> ancient question :))]
>
> On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote:
>> pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the
>> former one is dec
The rsi_resume() does access the bus to enable interrupts on the RSI
SDIO WiFi card, however when calling sdio_claim_host() in the resume
path, it is possible the bus is already claimed and sdio_claim_host()
spins indefinitelly. Enable the SDIO card interrupts in resume_noirq
instead to prevent any
On 2021-03-26 9:09 a.m., Simon Horman wrote:
From: Baowen Zheng
Add selftest cases in action police for packets per second.
These tests depend on corresponding iproute2 command support.
Signed-off-by: Baowen Zheng
Signed-off-by: Simon Horman
Gracias.
Reviewed-by: Jamal Hadi Salim
cheers
On Sat, Mar 27, 2021 at 11:19 PM Alexei Starovoitov
wrote:
>
> On Sat, Mar 27, 2021 at 1:19 AM Jianlin Lv wrote:
> >
> > > On Fri, Mar 26, 2021 at 5:40 AM Jianlin Lv wrote:
> > > >
> > > > When CONFIG_BPF_JIT_ALWAYS_ON is enabled, the value of
> > > bpf_jit_enable
> > > > in /proc/sys is limited
syzbot has found a reproducer for the following issue on:
HEAD commit:0f4498ce Merge tag 'for-5.12/dm-fixes-2' of git://git.kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16d734aad0
kernel config: https://syzkaller.appspot.com/x/.config?x=d4e9add
On Fri, Mar 26, 2021 at 7:15 PM Alexei Starovoitov
wrote:
>
> On Thu, Mar 25, 2021 at 05:30:03PM +0530, Kumar Kartikeya Dwivedi wrote:
> > This adds some basic tests for the low level bpf_tc_* API and its
> > bpf_program__attach_tc_* wrapper on top.
>
> *_block() apis from patch 3 and 4 are not co
On Thu, Mar 25, 2021 at 5:02 AM Kumar Kartikeya Dwivedi
wrote:
>
> This adds functions that wrap the netlink API used for adding,
> manipulating, and removing filters and actions. These functions operate
> directly on the loaded prog's fd, and return a handle to the filter and
> action using an ou
On Fri, Mar 26, 2021 at 9:05 AM Lorenz Bauer wrote:
>
> Invoking BPF_OBJ_GET on a pinned bpf_link checks the path access
> permissions based on file_flags, but the returned fd ignores flags.
> This means that any user can acquire a "read-write" fd for a pinned
> link with mode 0664 by invoking BPF
On Fri, Mar 26, 2021 at 1:14 PM Song Liu wrote:
>
> On Fri, Mar 26, 2021 at 9:07 AM Lorenz Bauer wrote:
> >
> > As for bpf_link, refuse creating a non-O_RDWR fd. Since program fds
> > currently don't allow modifications this is a precaution, not a
> > straight up bug fix.
> >
> > Signed-off-by: L
When creating an action in replace mode, in tcf_action_add, the refcount
of existing actions is rightly raised during tcf_idr_check_alloc call,
but for new actions a dummy placeholder entry is created. This is then
replaced with the actual action during tcf_idr_insert_many, but between
this and the
On Sat, Mar 27, 2021 at 03:51:10PM +, Matthew Wilcox wrote:
> On Sat, Mar 27, 2021 at 03:31:18PM +0100, Greg Kroah-Hartman wrote:
> > On Sat, Mar 27, 2021 at 10:25:20PM +0800, Du Cheng wrote:
> > > On Sat, Mar 27, 2021 at 03:12:14PM +0100, Greg Kroah-Hartman wrote:
> > > > Adding the xarray mai
66 matches
Mail list logo
