[PATCH v2] CIPSO: Fix unaligned memory access in cipso_v4_gentag_hdr

2021-03-05 Thread Sergey Nazarov
We need to use put_unaligned when writing 32-bit DOI value in cipso_v4_gentag_hdr to avoid unaligned memory access. v2: unneeded type cast removed as Ondrej Mosnacek suggested. Signed-off-by: Sergey Nazarov --- net/ipv4/cipso_ipv4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-05 Thread Yongji Xie
On Fri, Mar 5, 2021 at 3:37 PM Jason Wang wrote: > > > On 2021/3/5 3:27 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: > >> > >> On 2021/3/5 2:36 下午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: > On 2021/3/5 11:30 上午, Yongji Xie wrot

[PATCH RESEND][next] netfilter: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Acked-by: Florian Westphal Signed-off-by: Gustavo A. R. Si

[PATCH RESEND][next] net/mlx4: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Reviewed-by: Tariq Toukan Signed-off-by: Gustavo A. R. Silva --- drivers

[PATCH RESEND][next] ice: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/ice/ice

[PATCH RESEND][next] fm10k: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding a couple of break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/eth

[PATCH RESEND][next] qed: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding a couple of break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Reviewed-by: Igor Russkikh Signed-off-by: Gustavo A. R.

[PATCH RESEND][next] ixgbe: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethern

[PATCH RESEND][next] ipv4: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/ipv4/ah4.c

Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang

2021-03-05 Thread Paul Menzel
Dear Gustavo, Thank you for working on that. Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva: In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. It would be nice to h

[PATCH RESEND][next] igb: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethern

[PATCH RESEND][next] rds: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/rds/tcp_connect.c |

[PATCH RESEND][next] sctp: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a break statement and replacing a comment with a goto statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo

[PATCH] net: dsa: bcm_sf2: simplify optional reset handling

2021-03-05 Thread Philipp Zabel
As of commit bb475230b8e5 ("reset: make optional functions really optional"), the reset framework API calls use NULL pointers to describe optional, non-present reset controls. This allows to unconditionally return errors from devm_reset_control_get_optional_exclusive. Signed-off-by: Philipp Zabel

[PATCH RESEND][next] qlcnic: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding a break and a goto statements instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/et

[PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/rxrpc/af_rxrpc.c | 1 + 1 file chan

[PATCH RESEND][next] net: netrom: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/netrom/nr_route.c |

[PATCH RESEND][next] xfrm: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/xfrm/xfrm_interface.c | 1 + 1 file

[PATCH RESEND][next] tipc: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/tipc/link.c | 1 + 1 file changed,

[PATCH] net: xdp: fix error return code of xsk_generic_xmit()

2021-03-05 Thread Jia-Ju Bai
When err is zero but xskq_prod_reserve() fails, no error return code of xsk_generic_xmit() is assigned. To fix this bug, err is assigned with the return value of xskq_prod_reserve(), and then err is checked. The spinlock is only used to protect the call to xskq_prod_reserve(). Reported-by: TOTE Ro

[PATCH] selftest/net/ipsec.c: Remove unneeded semicolon

2021-03-05 Thread Xu Wang
fix semicolon.cocci warning: tools/testing/selftests/net/ipsec.c:1788:2-3: Unneeded semicolon Signed-off-by: Xu Wang --- tools/testing/selftests/net/ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/ipsec.c b/tools/testing/selftests/net/ipse

[PATCH net] r8169: fix r8168fp_adjust_ocp_cmd function

2021-03-05 Thread Hayes Wang
The (0xBAF7 & 0x00FFF000) << 6 should be (0xf70 << 18). Fixes: 561535b0f239 ("r8169: fix OCP access on RTL8117") Signed-off-by: Hayes Wang --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169_main

[PATCH bpf-next v2 1/2] xsk: update rings for load-acquire/store-release barriers

2021-03-05 Thread Björn Töpel
From: Björn Töpel Currently, the AF_XDP rings uses general smp_{r,w,}mb() barriers on the kernel-side. On most modern architectures load-acquire/store-release barriers perform better, and results in simpler code for circular ring buffers. This change updates the XDP socket rings to use load-acqu

[PATCH bpf-next v2 2/2] libbpf, xsk: add libbpf_smp_store_release libbpf_smp_load_acquire

2021-03-05 Thread Björn Töpel
From: Björn Töpel Now that the AF_XDP rings have load-acquire/store-release semantics, move libbpf to that as well. The library-internal libbpf_smp_{load_acquire,store_release} are only valid for 32-bit words on ARM64. Also, remove the barriers that are no longer in use. Signed-off-by: Björn T

[PATCH bpf-next v2 0/2] load-acquire/store-release barriers for AF_XDP rings

2021-03-05 Thread Björn Töpel
This two-patch series introduces load-acquire/store-release barriers for the AF_XDP rings. For most contemporary architectures, this is more effective than a SPSC ring based on smp_{r,w,}mb() barriers. More importantly, load-acquire/store-release semantics make the ring code easier to follow. Thi

[PATCH RESEND][next] net/packet: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/packet/af_packet.c | 1 + 1 file ch

[PATCH RESEND][next] netxen_nic: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a goto statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/qlogic/netxen/

[PATCH RESEND][next] ixgbevf: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/ixgbevf

[PATCH RESEND][next] vxge: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a return statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/neterion/vxge/vxg

[PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by replacing /* fall through */ comments with the new pseudo-keyword macro fallthrough; instead of letting the code fall through to the next case. Notice that Clang doesn't recognize /* fall through */ comments as imp

[PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/netronome/nfp/nfp_

[PATCH RESEND][next] bnxt_en: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/broadcom/bnxt

[PATCH RESEND][next] e1000: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/e1000/e

Re: [Freedreno] [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-05 Thread Will Deacon
On Thu, Mar 04, 2021 at 03:11:08PM -0800, Rob Clark wrote: > On Thu, Mar 4, 2021 at 7:48 AM Robin Murphy wrote: > > > > On 2021-03-01 08:42, Christoph Hellwig wrote: > > > Signed-off-by: Christoph Hellwig > > > > Moreso than the previous patch, where the feature is at least relatively > > generic

[PATCH] net: smc: fix error return code of smc_diag_dump_proto()

2021-03-05 Thread Jia-Ju Bai
When the list of head is empty, no error return code of smc_diag_dump_proto() is assigned. To fix this bug, rc is assigned with -ENOENT as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- net/smc/smc_diag.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[PATCH v6 net-next] virtio-net: support XDP when not more queues

2021-03-05 Thread Xuan Zhuo
The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to allocate a separate queue for XDP_TX/XDP_REDIRECT, then xdp cannot be loaded to work, even xdp does not use the XDP_TX/XDP_REDIRECT. Th

Re: [PATCH] net: smc: fix error return code of smc_diag_dump_proto()

2021-03-05 Thread Karsten Graul
On 05/03/2021 11:13, Jia-Ju Bai wrote: > When the list of head is empty, no error return code of > smc_diag_dump_proto() is assigned. > To fix this bug, rc is assigned with -ENOENT as error return code. Your change would break smc_diag_dump(). When there are no IPv4 sockets (SMCPROTO_SMC) in the l

Re: INFO: task hung in rsvp_delete_filter_work

2021-03-05 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 396d7f23adf9e8c436dd81a69488b5b6a865acf8 Author: Vlad Buslov Date: Tue Feb 16 16:22:00 2021 + net: sched: fix police ext initialization bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13dc3caed0 start commit: 14

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-05 Thread Naveen N. Rao
On 2021/03/04 04:55PM, Jiri Olsa wrote: > On Thu, Mar 04, 2021 at 11:46:27AM +1100, Michael Ellerman wrote: > > "Naveen N. Rao" writes: > > > On 2021/03/02 11:35AM, Jiri Olsa wrote: > > >> On Mon, Mar 01, 2021 at 02:58:53PM -0800, Yonghong Song wrote: > > >> > > > >> > > > >> > On 3/1/21 11:04 A

Query on new ethtool RSS hashing options

2021-03-05 Thread Sunil Kovvuri
Hi, We have a requirement where in we want RSS hashing to be done on packet fields which are not currently supported by the ethtool. Current options: ehtool -n rx-flow-hash tcp4|udp4|ah4|esp4|sctp4|tcp6|udp6|ah6|esp6|sctp6 m|v|t|s|d|f|n|r Specifically our requirement is to calculate hash with D

Re: [PATCH v4 5/6] can: c_can: prepare to up the message objects number

2021-03-05 Thread Dario Binacchi
> Il 04/03/2021 16:26 Marc Kleine-Budde ha scritto: > > > On 02.03.2021 22:54:34, Dario Binacchi wrote: > > diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c > > index 77b9aee56154..0052ba5197e0 100644 > > --- a/drivers/net/can/c_can/c_can.c > > +++ b/drivers/net/can/

Re: [PATCH v2] can: c_can: move runtime PM enable/disable to c_can_platform

2021-03-05 Thread Uwe Kleine-König
On Mon, Mar 01, 2021 at 09:55:40PM -0500, Tong Zhang wrote: > Currently doing modprobe c_can_pci will make kernel complain > "Unbalanced pm_runtime_enable!", this is caused by pm_runtime_enable() > called before pm is initialized. > This fix is similar to 227619c3ff7c, move those pm_enable/disable

Re: [PATCH net] r8169: fix r8168fp_adjust_ocp_cmd function

2021-03-05 Thread Heiner Kallweit
On 05.03.2021 10:34, Hayes Wang wrote: > The (0xBAF7 & 0x00FFF000) << 6 should be (0xf70 << 18). > > Fixes: 561535b0f239 ("r8169: fix OCP access on RTL8117") > Signed-off-by: Hayes Wang > --- > drivers/net/ethernet/realtek/r8169_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] net: xdp: fix error return code of xsk_generic_xmit()

2021-03-05 Thread Magnus Karlsson
On Fri, Mar 5, 2021 at 10:28 AM Jia-Ju Bai wrote: > > When err is zero but xskq_prod_reserve() fails, no error return code of > xsk_generic_xmit() is assigned. > To fix this bug, err is assigned with the return value of > xskq_prod_reserve(), and then err is checked. This error is ignored by desi

Re: [PATCH RESEND][next] nfp: Fix fall-through warnings for Clang

2021-03-05 Thread Simon Horman
On Fri, Mar 05, 2021 at 03:49:37AM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 >

Re: [PATCH] selftests_bpf: extend test_tc_tunnel test with vxlan

2021-03-05 Thread Xuesen Huang
> 2021年3月4日 下午10:02,Willem de Bruijn 写道: > > On Thu, Mar 4, 2021 at 1:42 AM Xuesen Huang wrote: >> >> From: Xuesen Huang >> >> Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which >> encapsulates the ethernet as the inner l2 header. >> >> Update a vxlan encapsulation test case

[PATCH 5.10 035/102] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-05 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fails. The former is using wpa_supplicant during association, the later is set up using hostapd: iwl$ cat hostapd.conf int

[PATCH 5.10 036/102] rsi: Move card interrupt handling to RX thread

2021-03-05 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 287431463e786766e05e4dc26d0a11d5f8ac8815 ] The interrupt handling of the RS911x is particularly heavy. For each RX packet, the card does three SDIO transactions, one to read interrupt status register, one to RX buffer length, one to read the RX packet(s). This

[PATCH bpf-next] selftests_bpf: extend test_tc_tunnel test with vxlan

2021-03-05 Thread Xuesen Huang
From: Xuesen Huang Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which encapsulates the ethernet as the inner l2 header. Update a vxlan encapsulation test case. Signed-off-by: Xuesen Huang Signed-off-by: Li Wang Signed-off-by: Willem de Bruijn --- tools/testing/selftests/bpf/pr

[PATCH 5.4 25/72] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-05 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fails. The former is using wpa_supplicant during association, the later is set up using hostapd: iwl$ cat hostapd.conf int

[PATCH 5.4 26/72] rsi: Move card interrupt handling to RX thread

2021-03-05 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 287431463e786766e05e4dc26d0a11d5f8ac8815 ] The interrupt handling of the RS911x is particularly heavy. For each RX packet, the card does three SDIO transactions, one to read interrupt status register, one to RX buffer length, one to read the RX packet(s). This

[PATCH 4.19 20/52] rsi: Move card interrupt handling to RX thread

2021-03-05 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 287431463e786766e05e4dc26d0a11d5f8ac8815 ] The interrupt handling of the RS911x is particularly heavy. For each RX packet, the card does three SDIO transactions, one to read interrupt status register, one to RX buffer length, one to read the RX packet(s). This

[PATCH 4.19 19/52] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-05 Thread Greg Kroah-Hartman
From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fails. The former is using wpa_supplicant during association, the later is set up using hostapd: iwl$ cat hostapd.conf int

[PATCH] iavf: do not override the adapter state in the watchdog task

2021-03-05 Thread Stefan Assmann
The iavf watchdog task overrides adapter->state to __IAVF_RESETTING when it detects a pending reset. Then schedules iavf_reset_task() which takes care of the reset. The reset task is capable of handling the reset without changing adapter->state. In fact we lose the state information when the watch

Re: [regression] Kernel panic on resume from sleep

2021-03-05 Thread Zbynek Michl
On Thu, Mar 4, 2021 at 6:51 PM Jakub Kicinski wrote: > Depends if kernel attempts to try to send a packet before __alx_open() > finishes. You can probably make it more likely by running trafgen, iperf > or such while suspending and resuming? I've tried "ping -f " first, but there was no effect -

Re: [PATCH net-next 6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

2021-03-05 Thread Alex Elder
t; https://github.com/0day-ci/linux/commits/Alex-Elder/net-qualcomm-rmnet-stop-using-C-bit-fields/20210305-064128 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > d310ec03a34e92a77302edb804f7d68ee4f01ba0 > config: riscv-randconfig-s031-20210305 (attached as

[PATCH] bonding: 3ad: fix a use-after-free in bond_3ad_state_machine_handle

2021-03-05 Thread zhudi
From: Di Zhu I use the similar test method described in link below with KASAN enabled: https://lore.kernel.org/netdev/4c5e467e07fb410ab4135b391d663...@huawei.com/ soon after, KASAN reports: [ 9041.977110] == [ 9041.977151] BUG: KASA

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-05 Thread Jiri Olsa
On Thu, Mar 04, 2021 at 07:04:59AM +0530, Naveen N. Rao wrote: SNIP > > > static inline unsigned long ppc_function_entry(void *func) > > > { > > > #ifdef PPC64_ELF_ABI_v2 > > > u32 *insn = func; > > > > > > /* > > >* A PPC64 ABIv2 function may have a local and a global entry > > >* p

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-03-05 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > In preparation to enable -Wimplicit-fallthrough for Clang, fix > multiple warnings by replacing /* fall through */ comments with > the new pseudo-keyword macro fallthrough; instead of letting the > code fall through to the next case. > > Notice that Clang doesn't r

[PATCHv2 bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-05 Thread Jiri Olsa
When testing uprobes we the test gets GEP (Global Entry Point) address from kallsyms, but then the function is called locally so the uprobe is not triggered. Fixing this by adjusting the address to LEP (Local Entry Point) for powerpc arch plus instruction check stolen from ppc_function_entry funct

Re: [PATCH bpf-next v2 0/2] load-acquire/store-release barriers for AF_XDP rings

2021-03-05 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > This two-patch series introduces load-acquire/store-release barriers > for the AF_XDP rings. > > For most contemporary architectures, this is more effective than a > SPSC ring based on smp_{r,w,}mb() barriers. More importantly, > load-acquire/store-release semantics make the

[syzbot] WARNING in carl9170_usb_send_rx_irq_urb/usb_submit_urb

2021-03-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fe07bfda Linux 5.12-rc1 git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=12020056d0 kernel config: https://syzkaller.appspot.com/x/

[PATCH 1/3] vDPA/ifcvf: get_vendor_id returns a device specific vendor id

2021-03-05 Thread Zhu Lingshan
In this commit, ifcvf_get_vendor_id() will return a device specific vendor id of the probed pci device than a hard code. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drive

[PATCH 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-net

2021-03-05 Thread Zhu Lingshan
This series enabled Intel FGPA SmartNIC C5000X-PL virtio-net for vDPA Zhu Lingshan (3): vDPA/ifcvf: get_vendor_id returns a device specific vendor id vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA vDPA/ifcvf: bump version string to 1.0 drivers/vdpa/ifcvf/ifcvf_base.h | 13 +

[PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-net for vDPA

2021-03-05 Thread Zhu Lingshan
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-net for vDPA. C5000X-PL vendor id 0x1AF4, device id 0x1000, subvendor id 0x8086, sub device id 0x0001 To distinguish C5000X-PL from other ifcvf driven devices, the original ifcvf device is named "N3000". Signed-off-by: Zhu Lingshan --- dr

[PATCH 3/3] vDPA/ifcvf: bump version string to 1.0

2021-03-05 Thread Zhu Lingshan
This commit bumps ifcvf driver version string to 1.0 Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c index fd5befc5cbcc..56a0974cf93c 100644 --- a

[PATCH] ethernet: ucc_geth: Use kmemdup instead of kmalloc and memcpy

2021-03-05 Thread angkery
From: Junlin Yang Fixes coccicheck warnings: ./drivers/net/ethernet/freescale/ucc_geth.c:3594:11-18: WARNING opportunity for kmemdup Signed-off-by: Junlin Yang --- drivers/net/ethernet/freescale/ucc_geth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethern

[PATCH] net/hamradio/6pack: remove redundant check in sp_encaps()

2021-03-05 Thread Denis Efremov
"len > sp->mtu" checked twice in a row in sp_encaps(). Remove the second check. Signed-off-by: Denis Efremov --- drivers/net/hamradio/6pack.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index 71d6629e65c9..9f5b5614a150 10064

[PATCH] iwlwifi: mvm: Use kmemdup instead of kzalloc and memcpy

2021-03-05 Thread angkery
From: Junlin Yang Fixes coccicheck warnings: ./drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:110:8-15: WARNING opportunity for kmemdup Signed-off-by: Junlin Yang --- drivers/net/wireless/intel/iwlwifi/mvm/rfi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/w

Re: [PATCH bpf] veth: store queue_mapping independently of XDP prog presence

2021-03-05 Thread Toshiaki Makita
On 2021/03/04 0:29, Maciej Fijalkowski wrote: Currently, veth_xmit() would call the skb_record_rx_queue() only when there is XDP program loaded on peer interface in native mode. If peer has XDP prog in generic mode, then netif_receive_generic_xdp() has a call to netif_get_rxqueue(skb), so for mu

[PATCH] sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count

2021-03-05 Thread Denis Efremov
RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row in niu_xmac_interrupt(). Remove the second addition. Signed-off-by: Denis Efremov --- I don't know the code of the dirver, but this looks like a real bug. Otherwise, it's more readable as: mp->rx_bcasts += RXMAC_BC_FRM_CNT_COUNT * 2;

Re: [PATCH bpf-next] selftests_bpf: extend test_tc_tunnel test with vxlan

2021-03-05 Thread Willem de Bruijn
On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote: > > From: Xuesen Huang > > Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which > encapsulates the ethernet as the inner l2 header. > > Update a vxlan encapsulation test case. > > Signed-off-by: Xuesen Huang > Signed-off-by: Li Wang

Re: VRF leaking doesn't work

2021-03-05 Thread David Ahern
On 3/2/21 3:57 AM, Greesha Mikhalkin wrote: > Hi. I need a help to understand why VRF leaking doesn’t work in my situation. > I want to set up leaking between 2 VRFs, that are set up by following > commands: > > # Setup bridge > sudo ip link add bridge type bridge > > # Setup V

Re: [PATCH bpf-next v5 2/2] bpf, xdp: restructure redirect actions

2021-03-05 Thread Daniel Borkmann
On 2/27/21 1:21 PM, Björn Töpel wrote: [...] diff --git a/include/linux/filter.h b/include/linux/filter.h index 008691fd3b58..a7752badc2ec 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -646,11 +646,20 @@ struct bpf_redirect_info { u32 flags; u32 tgt_index;

Re: [PATCH bpf-next v5 1/2] bpf, xdp: make bpf_redirect_map() a map operation

2021-03-05 Thread Daniel Borkmann
On 2/27/21 1:21 PM, Björn Töpel wrote: [...] Look good. Small nits inline I had originally fixed up locally before glancing at 2/2: diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 4c730863fa77..3d3e89a37e62 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -118,6 +118,

Re: [PATCH bpf-next] selftests_bpf: extend test_tc_tunnel test with vxlan

2021-03-05 Thread Daniel Borkmann
On 3/5/21 4:08 PM, Willem de Bruijn wrote: On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote: From: Xuesen Huang Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which encapsulates the ethernet as the inner l2 header. Update a vxlan encapsulation test case. Signed-off-by: Xuesen

Re: [PATCH/v5] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 4 Mar 2021 14:40:46 +0800 you wrote: > From: Xuesen Huang > > bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets > encapsulation. But that is not appropriate when pushing Ethernet header. > >

Re: [PATCH bpf-next] selftests_bpf: extend test_tc_tunnel test with vxlan

2021-03-05 Thread Willem de Bruijn
On Fri, Mar 5, 2021 at 11:10 AM Daniel Borkmann wrote: > > On 3/5/21 4:08 PM, Willem de Bruijn wrote: > > On Fri, Mar 5, 2021 at 7:34 AM Xuesen Huang wrote: > >> > >> From: Xuesen Huang > >> > >> Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which > >> encapsulates the ethernet as t

[PATCH v1] ibmvnic: remove excessive irqsave

2021-03-05 Thread angkery
From: Junlin Yang ibmvnic_remove locks multiple spinlocks while disabling interrupts: spin_lock_irqsave(&adapter->state_lock, flags); spin_lock_irqsave(&adapter->rwi_lock, flags); As reported by coccinelle, the second _irqsave() overwrites the value saved in 'flags' by the first _irqsave(), th

Re: [PATCH v2] CIPSO: Fix unaligned memory access in cipso_v4_gentag_hdr

2021-03-05 Thread Paul Moore
On Fri, Mar 5, 2021 at 3:05 AM Sergey Nazarov wrote: > > We need to use put_unaligned when writing 32-bit DOI value > in cipso_v4_gentag_hdr to avoid unaligned memory access. > > v2: unneeded type cast removed as Ondrej Mosnacek suggested. > > Signed-off-by: Sergey Nazarov > --- > net/ipv4/cipso

Re: [PATCH RESEND][next] rtl8xxxu: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
On 3/5/21 07:40, Kalle Valo wrote: > "Gustavo A. R. Silva" writes: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix >> multiple warnings by replacing /* fall through */ comments with >> the new pseudo-keyword macro fallthrough; instead of letting the >> code fall through to

Re: [PATCH bpf-next v5 2/2] bpf, xdp: restructure redirect actions

2021-03-05 Thread Björn Töpel
On 2021-03-05 16:44, Daniel Borkmann wrote: On 2/27/21 1:21 PM, Björn Töpel wrote: [...] diff --git a/include/linux/filter.h b/include/linux/filter.h index 008691fd3b58..a7752badc2ec 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -646,11 +646,20 @@ struct bpf_redirect_info {

Re: [PATCH bpf-next v5 1/2] bpf, xdp: make bpf_redirect_map() a map operation

2021-03-05 Thread Björn Töpel
On 2021-03-05 16:55, Daniel Borkmann wrote: On 2/27/21 1:21 PM, Björn Töpel wrote: [...] Look good. Small nits inline I had originally fixed up locally before glancing at 2/2: diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 4c730863fa77..3d3e89a37e62 100644 --- a/include/linux/b

Re: [PATCH net] ipv6: drop incoming packets having a v4mapped source address

2021-03-05 Thread Jakub Kicinski
On Wed, 2 Oct 2019 09:38:55 -0700 Eric Dumazet wrote: > This began with a syzbot report. syzkaller was injecting > IPv6 TCP SYN packets having a v4mapped source address. > > After an unsuccessful 4-tuple lookup, TCP creates a request > socket (SYN_RECV) and calls reqsk_queue_hash_req() > > reqsk

Re: [RFC PATCH net] ibmvnic: complete dev->poll nicely during adapter reset

2021-03-05 Thread Sukadev Bhattiprolu
Lijun Pan [l...@linux.ibm.com] wrote: > The reset path will call ibmvnic_cleanup->ibmvnic_napi_disable > ->napi_disable(). This is supposed to stop the polling. > Commit 21ecba6c48f9 ("ibmvnic: Exit polling routine correctly > during adapter reset") reported that the during device reset, > polling

Re: [RFC PATCH net] ibmvnic: complete dev->poll nicely during adapter reset

2021-03-05 Thread Lijun Pan
On Fri, Mar 5, 2021 at 12:44 PM Sukadev Bhattiprolu wrote: > > Lijun Pan [l...@linux.ibm.com] wrote: > > The reset path will call ibmvnic_cleanup->ibmvnic_napi_disable > > ->napi_disable(). This is supposed to stop the polling. > > Commit 21ecba6c48f9 ("ibmvnic: Exit polling routine correctly > >

Re: [RFC PATCH net] ibmvnic: complete dev->poll nicely during adapter reset

2021-03-05 Thread Sukadev Bhattiprolu
Lijun Pan [lijunp...@gmail.com] wrote: > On Fri, Mar 5, 2021 at 12:44 PM Sukadev Bhattiprolu > wrote: > > > > Lijun Pan [l...@linux.ibm.com] wrote: > > > The reset path will call ibmvnic_cleanup->ibmvnic_napi_disable > > > ->napi_disable(). This is supposed to stop the polling. > > > Commit 21ecba

RE: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-05 Thread Don Bollinger
On Mon, Mar 1, 2021 at 12:46 PM-0800, Andrew Lunn wrote: > > To be more specific, optoe is only replacing the functionality of > > drivers/net/phy/sfp.c, the functions of sfp_i2c_read() and sfp_i2c_write(). > > These are the routines at the very bottom of the ethtool stack that > > actually execute

Re: [PATCH v1 6/7] dt-bindings: net: qcom-ipa: Document qcom,sc7180-ipa compatible

2021-03-05 Thread Rob Herring
On Thu, Feb 11, 2021 at 06:50:14PM +0100, AngeloGioacchino Del Regno wrote: > The driver supports SC7180, but the binding was not documented. > Just add it. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +- > 1 file changed,

Re: [PATCH v1 7/7] dt-bindings: net: qcom-ipa: Document qcom,msm8998-ipa compatible

2021-03-05 Thread Rob Herring
On Thu, Feb 11, 2021 at 06:50:15PM +0100, AngeloGioacchino Del Regno wrote: > MSM8998 support has been added: document the new compatible. > > Signed-off-by: AngeloGioacchino Del Regno > > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [PATCH resend] netlink.7: note not reliable if NETLINK_NO_ENOBUFS

2021-03-05 Thread Alexander Ahring Oder Aring
Hi Pablo, I appreciate your very detailed response. Thank you. On Thu, Mar 4, 2021 at 10:04 PM Pablo Neira Ayuso wrote: > > Hi Alexander, > > On Thu, Mar 04, 2021 at 03:57:28PM -0500, Alexander Aring wrote: > > This patch adds a note to the netlink manpage that if NETLINK_NO_ENOBUFS > > is set t

Re: [PATCH 045/141] net: mscc: ocelot: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
Hi Vladimir, On 3/4/21 17:01, Vladimir Oltean wrote: > Hi Gustavo, > > On Thu, Mar 04, 2021 at 04:53:18PM -0600, Gustavo A. R. Silva wrote: >> Hi all, >> >> It's been more than 3 months; who can take this, please? :) >> >> Thanks >> -- >> Gustavo >> >> On Fri, Nov 20, 2020 at 12:31:13PM -0600, Gu

Re: [PATCH resend] netlink.7: note not reliable if NETLINK_NO_ENOBUFS

2021-03-05 Thread Pablo Neira Ayuso
On Fri, Mar 05, 2021 at 02:43:05PM -0500, Alexander Ahring Oder Aring wrote: > Hi Pablo, > > I appreciate your very detailed response. Thank you. > > On Thu, Mar 4, 2021 at 10:04 PM Pablo Neira Ayuso wrote: > > > > Hi Alexander, > > > > On Thu, Mar 04, 2021 at 03:57:28PM -0500, Alexander Aring w

Re: [BUG] hitting bug when running spinlock test

2021-03-05 Thread Roman Gushchin
On Thu, Mar 04, 2021 at 08:03:33PM +0100, Jiri Olsa wrote: > hi, > I'm getting attached BUG/crash when running in parralel selftests, like: > > while :; do ./test_progs -t spinlock; done > while :; do ./test_progs ; done > > it's the latest bpf-next/master, I can send the .config if needed, >

Re: [PATCH net-next 6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

2021-03-05 Thread Alex Elder
On 3/4/21 11:26 PM, Bjorn Andersson wrote: On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: Replace the use of C bit-fields in the rmnet_map_ul_csum_header structure with a single two-byte (big endian) structure member, and use field masks to encode or get values within it. Previously rmnet_map

Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

2021-03-05 Thread David Miller
Please resubmit these again when net-next opens back up, thank you.

[syzbot] net-next boot error: WARNING in kvm_wait

2021-03-05 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:d310ec03 Merge tag 'perf-core-2021-02-17' of git://git.ker.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1532e4c6d0 kernel config: https://syzkaller.appspot.com/x/.config?x=66df2ca4f2dd3022 das

Re: [PATCH net-next 2/6] net: qualcomm: rmnet: simplify some byte order logic

2021-03-05 Thread Alex Elder
On 3/4/21 10:07 PM, Bjorn Andersson wrote: On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: In rmnet_map_ipv4_ul_csum_header() and rmnet_map_ipv6_ul_csum_header() the offset within a packet at which checksumming should commence is calculated. This calculation involves byte swapping and a forced

Re: [PATCH] sun/niu: fix wrong RXMAC_BC_FRM_CNT_COUNT count

2021-03-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 5 Mar 2021 20:02:12 +0300 you wrote: > RXMAC_BC_FRM_CNT_COUNT added to mp->rx_bcasts twice in a row > in niu_xmac_interrupt(). Remove the second addition. > > Signed-off-by: Denis Efremov > --- > I don't know the code

Re: [PATCH] net: tehuti: fix error return code in bdx_probe()

2021-03-05 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 4 Mar 2021 18:06:48 -0800 you wrote: > When bdx_read_mac() fails, no error return code of bdx_probe() > is assigned. > To fix this bug, err is assigned with -EFAULT as error return code. > > Reported-by: TOTE Robot >

  1   2   >