[PATCH net-next RFC] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-04 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

[PATCH net 1/1] net: stmmac: Fix VLAN filter delete timeout issue in Intel mGBE SGMII

2021-03-04 Thread Ong Boon Leong
For Intel mGbE controller, MAC VLAN filter delete operation will time-out if serdes power-down sequence happened first during driver remove() with below message. [82294.764958] intel-eth-pci :00:1e.4 eth2: stmmac_dvr_remove: removing driver [82294.778677] intel-eth-pci :00:1e.4 eth2: Time

[PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread angkery
From: Junlin Yang ibmvnic_remove locks multiple spinlocks while disabling interrupts: spin_lock_irqsave(&adapter->state_lock, flags); spin_lock_irqsave(&adapter->rwi_lock, flags); there is no need for the second irqsave,since interrupts are disabled at that point, so remove the second irqsave: s

Re: [PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread Christophe Leroy
Le 05/03/2021 à 02:43, angkery a écrit : From: Junlin Yang ibmvnic_remove locks multiple spinlocks while disabling interrupts: spin_lock_irqsave(&adapter->state_lock, flags); spin_lock_irqsave(&adapter->rwi_lock, flags); there is no need for the second irqsave,since interrupts are disabled

[PATCH net 1/1] stmmac: intel: Fixes clock registration error seen for multiple interfaces

2021-03-04 Thread Ong Boon Leong
From: Wong Vee Khee Issue seen when enumerating multiple Intel mGbE interfaces in EHL. [6.898141] intel-eth-pci :00:1d.2: enabling device ( -> 0002) [6.900971] intel-eth-pci :00:1d.2: Fail to register stmmac-clk [6.906434] intel-eth-pci :00:1d.2: User ID: 0x51, Synops

Re: [PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread Lijun Pan
> On Mar 4, 2021, at 11:49 PM, Christophe Leroy > wrote: > > > > Le 05/03/2021 à 02:43, angkery a écrit : >> From: Junlin Yang >> ibmvnic_remove locks multiple spinlocks while disabling interrupts: >> spin_lock_irqsave(&adapter->state_lock, flags); >> spin_lock_irqsave(&adapter->rwi_lock,

Re: [RFC PATCH 1/12] x86/Hyper-V: Add visibility parameter for vmbus_establish_gpadl()

2021-03-04 Thread Tianyu Lan
Hi Vitaly: Thanks for your review. On 3/4/2021 12:27 AM, Vitaly Kuznetsov wrote: Tianyu Lan writes: From: Tianyu Lan Add visibility parameter for vmbus_establish_gpadl() and prepare to change host visibility when create gpadl for buffer. "No functional change" as you don't actually

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:36 AM Jason Wang wrote: > > > On 2021/3/4 1:12 下午, Yongji Xie wrote: > > On Thu, Mar 4, 2021 at 12:21 PM Jason Wang wrote: > >> > >> On 2021/2/23 7:50 下午, Xie Yongji wrote: > >>> This implements a MMU-based IOMMU driver to support mapping > >>> kernel dma buffer into use

Re: [PATCH net-next 6/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header

2021-03-04 Thread kernel test robot
Hi Alex, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Alex-Elder/net-qualcomm-rmnet-stop-using-C-bit-fields/20210305-064128 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.gi

Re: [RFC PATCH 2/12] x86/Hyper-V: Add new hvcall guest address host visibility support

2021-03-04 Thread Tianyu Lan
On 3/4/2021 12:58 AM, Vitaly Kuznetsov wrote: Tianyu Lan writes: From: Tianyu Lan Add new hvcall guest address host visibility support. Mark vmbus ring buffer visible to host when create gpadl buffer and mark back to not visible when tear down gpadl buffer. Signed-off-by: Sunil Muthuswamy

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: > > > On 2021/3/5 11:30 上午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: > >> > >> On 2021/3/4 4:58 下午, Yongji Xie wrote: > >>> On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: > On 2021/2/23 7:50 下午, Xie Yongji wr

Re: WARNING in ieee802154_get_llsec_params

2021-03-04 Thread syzbot
: f5427c24 Add linux-next specific files for 20210304 git tree: linux-next final oops: https://syzkaller.appspot.com/x/report.txt?x=120b11b0d0 console output: https://syzkaller.appspot.com/x/log.txt?x=140b11b0d0 kernel config: https://syzkaller.appspot.com/x/.config?x

Re: Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 11:44 AM Jason Wang wrote: > > > On 2021/3/5 11:37 上午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 11:11 AM Jason Wang wrote: > >> > >> On 2021/3/4 4:19 下午, Yongji Xie wrote: > >>> On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: > On 2021/2/23 7:50 下午, Xie Yongji wr

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下午, Yongji Xie wrote: On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: On 2021/2/23 7:50 下

Re: [PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread angkery
On Fri, 5 Mar 2021 06:49:14 +0100 Christophe Leroy wrote: > Le 05/03/2021 ?? 02:43, angkery a ??crit?0?2: > > From: Junlin Yang > > > > ibmvnic_remove locks multiple spinlocks while disabling interrupts: > > spin_lock_irqsave(&adapter->state_lock, flags); > > spin_lock_irqsave(&adapter->rwi_loc

Re: [PATCH v5 net-next] virtio-net: support XDP when not more queues

2021-03-04 Thread Jason Wang
On 2021/3/1 11:22 上午, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to allocate a separate queue for XDP_TX/XDP_REDIRECT, then xdp cannot be loaded to work, even xd

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: > > > On 2021/3/5 2:15 下午, Yongji Xie wrote: > > Sorry if I've asked this before. > > But what's the reason for maintaing a dedicated IOTLB here? I think we > could reuse vduse_dev->iommu since the device can not be used by both > virtio and vhost i

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: > > > On 2021/3/5 2:36 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: > >> > >> On 2021/3/5 11:30 上午, Yongji Xie wrote: > >>> On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: > On 2021/3/4 4:58 下午, Yongji Xie wro

Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Jason Wang
On 2021/3/5 3:13 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: On 2021/3/5 2:15 下午, Yongji Xie wrote: Sorry if I've asked this before. But what's the reason for maintaing a dedicated IOTLB here? I think we could reuse vduse_dev->iommu since the device can not be us

[PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Vladimir Oltean --- driv

[PATCH][next] net: 3c509: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/3com/3c509.c

[PATCH][next] net: cassini: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of just letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/sun/cassini.c

Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Jason Wang
On 2021/3/5 3:27 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 3:01 PM Jason Wang wrote: On 2021/3/5 2:36 下午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:42 AM Jason Wang wrote: On 2021/3/5 11:30 上午, Yongji Xie wrote: On Fri, Mar 5, 2021 at 11:05 AM Jason Wang wrote: On 2021/3/4 4:58 下午

[PATCH][next] decnet: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/decnet/dn_route.c | 2 +- 1 file ch

[PATCH][next] net: ax25: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/ax25/af_ax25.c | 1 + 1 file change

[PATCH][next] net: bridge: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Acked-by: Nikolay Aleksandrov Signed-off-by: Gustavo A. R. Silva --- net/brid

[PATCH][next] net: core: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/core/dev.c | 1 + 1 file changed, 1

[PATCH][next] net: rose: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- net/rose/rose_route.c |

[RFC PATCH net] ibmvnic: complete dev->poll nicely during adapter reset

2021-03-04 Thread Lijun Pan
The reset path will call ibmvnic_cleanup->ibmvnic_napi_disable ->napi_disable(). This is supposed to stop the polling. Commit 21ecba6c48f9 ("ibmvnic: Exit polling routine correctly during adapter reset") reported that the during device reset, polling routine never completed and napi_disable slept i

[PATCH][next] net: plip: Fix fall-through warnings for Clang

2021-03-04 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple warnings by explicitly adding multiple break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/net/plip/plip.c

Re: Re: [RFC v4 06/11] vduse: Implement an MMU-based IOMMU driver

2021-03-04 Thread Yongji Xie
On Fri, Mar 5, 2021 at 3:27 PM Jason Wang wrote: > > > On 2021/3/5 3:13 下午, Yongji Xie wrote: > > On Fri, Mar 5, 2021 at 2:52 PM Jason Wang wrote: > >> > >> On 2021/3/5 2:15 下午, Yongji Xie wrote: > >> > >> Sorry if I've asked this before. > >> > >> But what's the reason for maintaing a dedicated

<    1   2   3