Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk

2021-03-04 Thread Geert Uytterhoeven
On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > The AVB refererence clock assumes an external clock that runs reference > automatically. Because the Versaclock is wired to provide the > AVB refclock, the device tree needs to reference it in order for the > driver to start the clock. > > Sig

Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

2021-03-04 Thread Geert Uytterhoeven
Hi Adam, On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > For devices that use a programmable clock for the AVB reference clock, > the driver may need to enable them. Add code to find the optional clock > and enable it when available. > > Signed-off-by: Adam Ford Thanks for your patch! > -

Re: Re: [RFC v4 07/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 2:27 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This VDUSE driver enables implementing vDPA devices in userspace. > > Both control path and data path of vDPA devices will be able to > > be handled in userspace. > > > > In the control path, the VDU

Re: Re: [RFC v4 11/11] vduse: Support binding irq to the specified cpu

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 3:30 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > Add a parameter for the ioctl VDUSE_INJECT_VQ_IRQ to support > > injecting virtqueue's interrupt to the specified cpu. > > > How userspace know which CPU is this irq for? It looks to me we need to >

Re: [PATCH net] docs: networking: drop special stable handling

2021-03-04 Thread Leon Romanovsky
On Wed, Mar 03, 2021 at 05:00:07PM +, patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This patch was applied to netdev/net.git (refs/heads/master): > > On Tue, 2 Mar 2021 18:46:43 -0800 you wrote: > > Leave it to Greg. > > > > Signed-off-by: Jakub Kicinski > > --- > > Documentation/n

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Jason Wang
On 2021/3/3 4:29 下午, Cornelia Huck wrote: On Wed, 3 Mar 2021 12:01:01 +0800 Jason Wang wrote: On 2021/3/2 8:08 下午, Cornelia Huck wrote: On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wa

Re: BUG: soft lockup in ieee80211_tasklet_handler

2021-03-04 Thread Johannes Berg
On Tue, 2021-03-02 at 20:01 +0100, Dmitry Vyukov wrote: > > Looking at the reproducer that mostly contains just perf_event_open, > It may be the old known issue of perf_event_open with some extreme > parameters bringing down kernel. > +perf maintainers > And as far as I remember +Peter had some pa

Re: [PATCH net 1/3] sh_eth: fix TRSCER mask for SH771x

2021-03-04 Thread Geert Uytterhoeven
On Sun, Feb 28, 2021 at 9:54 PM Sergey Shtylyov wrote: > According to the SH7710, SH7712, SH7713 Group User's Manual: Hardware, > Rev. 3.00, the TRSCER register actually has only bit 7 valid (and named > differently), with all the other bits reserved. Apparently, this was not > the case with som

Re: [PATCH net 2/3] sh_eth: fix TRSCER mask for R7S72100

2021-03-04 Thread Geert Uytterhoeven
On Sun, Feb 28, 2021 at 9:54 PM Sergey Shtylyov wrote: > According to the RZ/A1H Group, RZ/A1M Group User's Manual: Hardware, > Rev. 4.00, the TRSCER register has bit 9 reserved, hence we can't use > the driver's default TRSCER mask. Add the explicit initializer for > sh_eth_cpu_data::trscer_er

Re: [PATCH net 3/3] sh_eth: fix TRSCER mask for R7S9210

2021-03-04 Thread Geert Uytterhoeven
On Sun, Feb 28, 2021 at 9:56 PM Sergey Shtylyov wrote: > According to the RZ/A2M Group User's Manual: Hardware, Rev. 2.00, > the TRSCER register has bit 9 reserved, hence we can't use the driver's > default TRSCER mask. Add the explicit initializer for sh_eth_cpu_data:: > trscer_err_mask for R7S

Re: [PATCH intel-net 1/3] i40e: move headroom initialization to i40e_configure_rx_ring

2021-03-04 Thread Jesper Dangaard Brouer
On Wed, 3 Mar 2021 16:39:26 +0100 Maciej Fijalkowski wrote: > i40e_rx_offset(), that is supposed to initialize the Rx buffer headroom, > relies on I40E_RXR_FLAGS_BUILD_SKB_ENABLED flag. > > Currently, the callsite of mentioned function is placed incorrectly > within i40e_setup_rx_descriptors()

Re: Re: [RFC v4 10/11] vduse: Introduce a workqueue for irq injection

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 2:59 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > This patch introduces a workqueue to support injecting > > virtqueue's interrupt asynchronously. This is mainly > > for performance considerations which makes sure the push() > > and pop() for used v

[PATCH net 0/2] nexthop: Do not flush blackhole nexthops when loopback goes down

2021-03-04 Thread Ido Schimmel
From: Ido Schimmel Patch #1 prevents blackhole nexthops from being flushed when the loopback device goes down given that as far as user space is concerned, these nexthops do not have a nexthop device. Patch #2 adds a test case. There are no regressions in fib_nexthops.sh with this change: # .

[PATCH net 2/2] selftests: fib_nexthops: Test blackhole nexthops when loopback goes down

2021-03-04 Thread Ido Schimmel
From: Ido Schimmel Test that blackhole nexthops are not flushed when the loopback device goes down. Output without previous patch: # ./fib_nexthops.sh -t basic Basic functional tests -- TEST: List with nothing defined [ OK ] TEST: Ne

[PATCH net 1/2] nexthop: Do not flush blackhole nexthops when loopback goes down

2021-03-04 Thread Ido Schimmel
From: Ido Schimmel As far as user space is concerned, blackhole nexthops do not have a nexthop device and therefore should not be affected by the administrative or carrier state of any netdev. However, when the loopback netdev goes down all the blackhole nexthops are flushed. This happens becaus

[PATCH net] ethtool: Add indicator field for link_mode validity to link_ksettings

2021-03-04 Thread Danielle Ratson
Some drivers clear the 'ethtool_link_ksettings' struct in their get_link_ksettings() callback, before populating it with actual values. Such drivers will set the new 'link_mode' field to zero, resulting in user space receiving wrong link mode information given that zero is a valid value for the fie

Re: [PATCH] net: mac802154: Fix null pointer dereference

2021-03-04 Thread Pavel Skripkin
Hi, thanks for your reply! On Wed, 2021-03-03 at 21:40 -0500, Alexander Aring wrote: > Hi, > > On Wed, 3 Mar 2021 at 11:28, Pavel Skripkin > wrote: > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > > It was caused by wrong clean up loop in llsec_key_alloc(). > > If one of t

Re: [Patch bpf-next v2 2/9] sock: introduce sk_prot->update_proto()

2021-03-04 Thread Lorenz Bauer
On Wed, 3 Mar 2021 at 18:21, Cong Wang wrote: > > Yeah, I am not surprised we can change tcp_update_ulp() too, but > why should I bother kTLS when I do not have to? What you suggest > could at most save us a bit of code size, not a big gain. So, I'd keep > its return value as it is, unless you see

[PATCH] i40e: improve locking of mac_filter_hash

2021-03-04 Thread Stefan Assmann
i40e_config_vf_promiscuous_mode() calls i40e_getnum_vf_vsi_vlan_filters() without acquiring the mac_filter_hash_lock spinlock. This is unsafe because mac_filter_hash may get altered in another thread while i40e_getnum_vf_vsi_vlan_filters() traverses the hashes. Simply adding the spinlock in i40e_

Re: [PATCH v2 1/1] xfrm: Use actual socket sk instead of skb socket for xfrm_output_resume

2021-03-04 Thread Steffen Klassert
On Tue, Mar 02, 2021 at 08:00:04AM +1300, Evan Nimmo wrote: > A situation can occur where the interface bound to the sk is different > to the interface bound to the sk attached to the skb. The interface > bound to the sk is the correct one however this information is lost inside > xfrm_output2 and

RE: [PATCH] gianfar: fix jumbo packets+napi+rx overrun crash

2021-03-04 Thread Claudiu Manoil
>-Original Message- >From: michael-...@fami-braun.de >Sent: Thursday, March 4, 2021 5:13 AM >To: Claudiu Manoil >Cc: netdev@vger.kernel.org; Michael Braun >Subject: [PATCH] gianfar: fix jumbo packets+napi+rx overrun crash > >From: Michael Braun > >When using jumbo packets and overrunnin

[PATCH -next] iwlwifi: mvm: fix old-style static const declaration

2021-03-04 Thread 'Wei Yongjun
From: Wei Yongjun GCC reports warning as follows: drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] 14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = { | ^ Move static to th

net: mscc: ocelot: issue with uninitialized pointer read in ocelot_flower_parse_key

2021-03-04 Thread Colin Ian King
Hi, Static analysis with Coverity had detected an uninitialized pointer read in function ocelot_flower_parse_key in drivers/net/ethernet/mscc/ocelot_flower.c introduced by commit: commit 75944fda1dfe836fdd406bef6cb3cc8a80f7af83 Author: Xiaoliang Yang Date: Fri Oct 2 15:02:23 2020 +0300 ne

[PATCH net] net: mscc: ocelot: properly reject destination IP keys in VCAP IS1

2021-03-04 Thread Vladimir Oltean
From: Vladimir Oltean An attempt is made to warn the user about the fact that VCAP IS1 cannot offload keys matching on destination IP (at least given the current half key format), but sadly that warning fails miserably in practice, due to the fact that it operates on an uninitialized "match" vari

Re: [PATCH net] net: mscc: ocelot: properly reject destination IP keys in VCAP IS1

2021-03-04 Thread Colin Ian King
On 04/03/2021 10:29, Vladimir Oltean wrote: > From: Vladimir Oltean > > An attempt is made to warn the user about the fact that VCAP IS1 cannot > offload keys matching on destination IP (at least given the current half > key format), but sadly that warning fails miserably in practice, due to > th

Re: Re: [RFC v4 09/11] Documentation: Add documentation for VDUSE

2021-03-04 Thread Yongji Xie
On Thu, Mar 4, 2021 at 2:40 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > VDUSE (vDPA Device in Userspace) is a framework to support > > implementing software-emulated vDPA devices in userspace. This > > document is intended to clarify the VDUSE design and usage. > > > > S

[PATCH net 1/2] net: dsa: sja1105: fix SGMII PCS being forced to SPEED_UNKNOWN instead of SPEED_10

2021-03-04 Thread Vladimir Oltean
From: Vladimir Oltean When using MLO_AN_PHY or MLO_AN_FIXED, the MII_BMCR of the SGMII PCS is read before resetting the switch so it can be reprogrammed afterwards. This works for the speeds of 1Gbps and 100Mbps, but not for 10Mbps, because SPEED_10 is actually 0, so AND-ing anything with 0 is fa

[PATCH net 2/2] net: dsa: sja1105: fix ucast/bcast flooding always remaining enabled

2021-03-04 Thread Vladimir Oltean
From: Vladimir Oltean In the blamed patch I managed to introduce a bug while moving code around: the same logic is applied to the ucast_egress_floods and bcast_egress_floods variables both on the "if" and the "else" branches. This is clearly an unintended change compared to how the code used to

Re: cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver

2021-03-04 Thread Joerg Roedel
On Mon, Mar 01, 2021 at 09:42:40AM +0100, Christoph Hellwig wrote: > Diffstat: > arch/powerpc/include/asm/fsl_pamu_stash.h | 12 > drivers/gpu/drm/msm/adreno/adreno_gpu.c |2 > drivers/iommu/amd/iommu.c | 23 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 85 -

[PATCH 01/18] thunderbolt: Disable retry logic for intra-domain control packets

2021-03-04 Thread Mika Westerberg
In most cases the response packet is lost because the router in question was disconnected by the user. Resending the control packet in that case just adds unnecessary delays, so disable that for intra-domain control packets. For inter-domain (XDomain) packets we continue retrying. This also aligns

[PATCH 04/18] Documentation / thunderbolt: Drop speed/lanes entries for XDomain

2021-03-04 Thread Mika Westerberg
These are actually not needed as we already have similar entries that apply to all devices on the Thunderbolt bus. Cc: Isaac Hazan Signed-off-by: Mika Westerberg --- .../ABI/testing/sysfs-bus-thunderbolt | 28 --- 1 file changed, 28 deletions(-) diff --git a/Documentati

[PATCH 05/18] thunderbolt: Add more logging to XDomain connections

2021-03-04 Thread Mika Westerberg
Currently the driver is pretty quiet when another host is connected which makes debugging possible issues harder. For this reason add more logging on debug level that can be turned on as needed. While there log the host-to-host connection on info level analogous to routers and retimers. Signed-of

[PATCH 03/18] thunderbolt: Decrease control channel timeout for software connection manager

2021-03-04 Thread Mika Westerberg
When the firmware connection manager is not proxying between the software and the hardware we can decrease the timeout for control packets significantly. The USB4 spec recommends 10 ms +- 1 ms but we use slightly larger value (100 ms) which is recommendation from Intel Thunderbolt firmware folks. W

[PATCH 07/18] thunderbolt: Use pseudo-random number as initial property block generation

2021-03-04 Thread Mika Westerberg
As recommended by USB4 inter-domain service spec use pseudo-random value instead of zero as initial XDomain property block generation value. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/xdomain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/thunderbolt/xdomain.c b/driv

[PATCH 13/18] thunderbolt: Allow multiple DMA tunnels over a single XDomain connection

2021-03-04 Thread Mika Westerberg
Currently we have had an artificial limitation of a single DMA tunnel per XDomain connection. However, hardware wise there is no such limit and software based connection manager can take advantage of all the DMA rings available on the host to establish tunnels. For this reason make the tb_xdomain_

[PATCH 00/18] thunderbolt: Align with USB4 inter-domain and DROM specs

2021-03-04 Thread Mika Westerberg
Hi all, The latest USB4 spec [1] also includes inter-domain (peer-to-peer, XDomain) and DROM (per-device ROM) specs. There are sligth differences between what the driver is doing now and what the spec say so this series tries to align the driver(s) with that. We also improve the "service" stack so

[PATCH 10/18] thunderbolt: Add support for maxhopid XDomain property

2021-03-04 Thread Mika Westerberg
USB4 inter-domain spec mandates that the compatible hosts expose a new property "maxhopid" that tells the connection manager on the other side what is the maximum supported input HopID over the connection. Since this is depend on the lane adapter the cable is connected it needs to be filled in dyna

[PATCH 15/18] thunderbolt: Add KUnit tests for XDomain properties

2021-03-04 Thread Mika Westerberg
This adds KUnit tests for parsing, formatting and copying of XDomain properties. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/test.c | 252 + 1 file changed, 252 insertions(+) diff --git a/drivers/thunderbolt/test.c b/drivers/thunderbolt/test.c inde

[PATCH 11/18] thunderbolt: Use dedicated flow control for DMA tunnels

2021-03-04 Thread Mika Westerberg
The USB4 inter-domain service spec recommends using dedicated flow control scheme so update the driver accordingly. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/tunnel.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/thunderbolt/tunnel

[PATCH 08/18] thunderbolt: Align XDomain protocol timeouts with the spec

2021-03-04 Thread Mika Westerberg
The USB4 inter-domain service spec has slightly different recommended timeouts for the XDomain protocol so align the driver with those. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/xdomain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thunderbolt/xdo

[PATCH 09/18] thunderbolt: Add tb_property_copy_dir()

2021-03-04 Thread Mika Westerberg
This function takes a deep copy of the properties. We need this in order to support more dynamic properties per XDomain connection as required by the USB4 inter-domain service spec. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/property.c | 71 ++ include

[PATCH 14/18] net: thunderbolt: Align the driver to the USB4 networking spec

2021-03-04 Thread Mika Westerberg
The USB4 networking spec (USB4NET) recommends different timeouts, and also suggest that the driver sets the 64k frame support flag in the properties block. Make the networking driver to honor this. Signed-off-by: Mika Westerberg --- drivers/net/thunderbolt.c | 7 --- 1 file changed, 4 insert

[PATCH 02/18] thunderbolt: Do not pass timeout for tb_cfg_reset()

2021-03-04 Thread Mika Westerberg
There is only one user for this function and it passes the default timeout to it anyway, so remove the parameter completely. This is also needed in the subsequent patch where we allow connection manager implementations to use different timeout for non-raw control channel messages. Signed-off-by: M

[PATCH 16/18] thunderbolt: Add KUnit tests for DMA tunnels

2021-03-04 Thread Mika Westerberg
Add a couple of tests to check DMA tunneling functionality. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/test.c | 240 + 1 file changed, 240 insertions(+) diff --git a/drivers/thunderbolt/test.c b/drivers/thunderbolt/test.c index 4e1e7ae2d90d..5ff5a

[PATCH 17/18] thunderbolt: Check quirks in tb_switch_add()

2021-03-04 Thread Mika Westerberg
This makes it more visible on the main path of adding router. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/eeprom.c | 1 - drivers/thunderbolt/switch.c | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c inde

[PATCH 12/18] thunderbolt: Drop unused tb_port_set_initial_credits()

2021-03-04 Thread Mika Westerberg
This function is not used anymore in the driver so we can remove it. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/switch.c | 22 -- drivers/thunderbolt/tb.h | 1 - 2 files changed, 23 deletions(-) diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt

[PATCH 18/18] thunderbolt: Add support for USB4 DROM

2021-03-04 Thread Mika Westerberg
USB4 router DROM differs sligthly from Thunderbolt 1-3 DROM. For instance it does not include UID and CRC8 in the header section, and it has product descriptor genereric entry to describe the product IDs and related information. If the "Version" field in the DROM header section reads 3 it means the

[PATCH 06/18] thunderbolt: Do not re-establish XDomain DMA paths automatically

2021-03-04 Thread Mika Westerberg
This step is actually not needed. The service drivers themselves will handle this once they have negotiated the service up and running again with the remote side. Also dropping this makes it easier to add support for multiple DMA tunnels over a single XDomain connection. Signed-off-by: Mika Wester

Re: [regression] Kernel panic on resume from sleep

2021-03-04 Thread Zbynek Michl
Looks good so far, but need to wait some more time as the issue was irregular. Do you have any explanation why the calls disorder caused the panic just occasionally? Also, the same (wrong) order I can see in the 3.16 kernel code, but it has worked fine with this kernel in all cases. So what is di

stmmac driver timeout issue

2021-03-04 Thread Joakim Zhang
Hello Andrew, Hello Jakub, You may can give some suggestions based on your great networking knowledge, thanks in advance! I found that add vlan id hw filter (stmmac_vlan_rx_add_vid) have possibility timeout when accessing VLAN Filter registers during ifup/ifdown stress test, and restore vlan

[PATCH 1/1] net: usb: qmi_wwan: allow qmimux add/del with master up

2021-03-04 Thread Daniele Palmas
There's no reason for preventing the creation and removal of qmimux network interfaces when the underlying interface is up. This makes qmi_wwan mux implementation more similar to the rmnet one, simplifying userspace management of the same logical interfaces. Fixes: c6adf77953bc ("net: usb: qmi_ww

Re: [PATCH net 1/2] net: dsa: sja1105: fix SGMII PCS being forced to SPEED_UNKNOWN instead of SPEED_10

2021-03-04 Thread Andrew Lunn
On Thu, Mar 04, 2021 at 12:56:53PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > When using MLO_AN_PHY or MLO_AN_FIXED, the MII_BMCR of the SGMII PCS is > read before resetting the switch so it can be reprogrammed afterwards. > This works for the speeds of 1Gbps and 100Mbps, but not f

Re: [PATCH net 2/2] net: dsa: sja1105: fix ucast/bcast flooding always remaining enabled

2021-03-04 Thread Andrew Lunn
On Thu, Mar 04, 2021 at 12:56:54PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > In the blamed patch I managed to introduce a bug while moving code > around: the same logic is applied to the ucast_egress_floods and > bcast_egress_floods variables both on the "if" and the "else" branch

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-04 Thread Cornelia Huck
On Thu, 4 Mar 2021 16:24:16 +0800 Jason Wang wrote: > On 2021/3/3 4:29 下午, Cornelia Huck wrote: > > On Wed, 3 Mar 2021 12:01:01 +0800 > > Jason Wang wrote: > > > >> On 2021/3/2 8:08 下午, Cornelia Huck wrote: > >>> On Mon, 1 Mar 2021 11:51:08 +0800 > >>> Jason Wang wrote: > >>> > On

Re: [PATCH/v5] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-03-04 Thread Willem de Bruijn
On Thu, Mar 4, 2021 at 1:41 AM Xuesen Huang wrote: > > From: Xuesen Huang > > bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets > encapsulation. But that is not appropriate when pushing Ethernet header. > > Add an option to further specify encap L2 type and set the inner_pr

Re: [PATCH] selftests_bpf: extend test_tc_tunnel test with vxlan

2021-03-04 Thread Willem de Bruijn
On Thu, Mar 4, 2021 at 1:42 AM Xuesen Huang wrote: > > From: Xuesen Huang > > Add BPF_F_ADJ_ROOM_ENCAP_L2_ETH flag to the existing tests which > encapsulates the ethernet as the inner l2 header. > > Update a vxlan encapsulation test case. > > Signed-off-by: Xuesen Huang > Signed-off-by: Li Wang

[PATCH] net: mellanox: mlx5: fix error return code in mlx5_fpga_device_start()

2021-03-04 Thread Jia-Ju Bai
When mlx5_is_fpga_lookaside() returns a non-zero value, no error return code is assigned. To fix this bug, err is assigned with -EINVAL as error return code. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c | 4 +++- 1 file changed, 3 in

Re: [PATCH 10/11] pragma once: delete few backslashes

2021-03-04 Thread Edward Cree
On 28/02/2021 17:05, Alexey Dobriyan wrote: > From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 > From: Alexey Dobriyan > Date: Fri, 19 Feb 2021 13:37:24 +0300 > Subject: [PATCH 10/11] pragma once: delete few backslashes > > Some macros contain one backslash too many and end

Re: [PATCH] net: mac802154: Fix null pointer dereference

2021-03-04 Thread Alexander Aring
Hi, On Thu, 4 Mar 2021 at 04:23, Pavel Skripkin wrote: ... > > > > I think this need to be: > > > > if (!IS_ERR_OR_NULL(key->tfm[i])) > > > > otherwise we still run into issues for the current iterator when > > key->tfm[i] is in range of IS_ERR(). > > Oh... I got it completly wrong, I'm sorry. If

Re: WARNING in carl9170_usb_submit_cmd_urb/usb_submit_urb

2021-03-04 Thread syzbot
syzbot has bisected this issue to: commit 6a66a7ded12baa6ebbb2e3e82f8cb91382814839 Author: zhangyi (F) Date: Thu Feb 13 06:38:20 2020 + jbd2: move the clearing of b_modified flag to the journal_unmap_buffer() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14bd498ed0

Re: [PATCH v4 0/6] can: c_can: add support to 64 message objects

2021-03-04 Thread Marc Kleine-Budde
On 02.03.2021 22:54:29, Dario Binacchi wrote: > > The D_CAN controller supports up to 128 messages. Until now the driver > only managed 32 messages although Sitara processors and DRA7 SOC can > handle 64. > > The series was tested on a beaglebone board. > > Note: > I have not changed the type of

Re: [PATCH 14/17] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-04 Thread Robin Murphy
On 2021-03-01 08:42, Christoph Hellwig wrote: Use explicit methods for setting and querying the information instead. Now that everyone's using iommu-dma, is there any point in bouncing this through the drivers at all? Seems like it would make more sense for the x86 drivers to reflect their pr

[PATCH v2] net: mac802154: Fix general protection fault

2021-03-04 Thread Pavel Skripkin
syzbot found general protection fault in crypto_destroy_tfm()[1]. It was caused by wrong clean up loop in llsec_key_alloc(). If one of the tfm array members is in IS_ERR() range it will cause general protection fault in clean up function [1]. Call Trace: crypto_free_aead include/crypto/aead.h:191

Re: [PATCH v4 5/6] can: c_can: prepare to up the message objects number

2021-03-04 Thread Marc Kleine-Budde
On 02.03.2021 22:54:34, Dario Binacchi wrote: > diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c > index 77b9aee56154..0052ba5197e0 100644 > --- a/drivers/net/can/c_can/c_can.c > +++ b/drivers/net/can/c_can/c_can.c [...] > -struct net_device *alloc_c_can_dev(void) > +struc

Re: [Patch bpf-next] skmsg: add function doc for skb->_sk_redir

2021-03-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 1 Mar 2021 10:48:05 -0800 you wrote: > From: Cong Wang > > This should fix the following warning: > > include/linux/skbuff.h:932: warning: Function parameter or member > '_sk_redir' not described in 'sk_buff' > >

Re: [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-04 Thread Robin Murphy
On 2021-03-01 08:42, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig Moreso than the previous patch, where the feature is at least relatively generic (note that there's a bunch of in-flight development around DOMAIN_ATTR_NESTING), I'm really not convinced that it's beneficial to b

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-04 Thread Jiri Olsa
On Thu, Mar 04, 2021 at 11:46:27AM +1100, Michael Ellerman wrote: > "Naveen N. Rao" writes: > > On 2021/03/02 11:35AM, Jiri Olsa wrote: > >> On Mon, Mar 01, 2021 at 02:58:53PM -0800, Yonghong Song wrote: > >> > > >> > > >> > On 3/1/21 11:04 AM, Jiri Olsa wrote: > >> > > When testing uprobes we t

Re: [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk

2021-03-04 Thread Bjorn Helgaas
[+cc Rafael, linux-pm] On Thu, Mar 04, 2021 at 02:07:18PM +0800, Kai-Heng Feng wrote: > On Sat, Feb 27, 2021 at 2:17 AM Bjorn Helgaas wrote: > > On Fri, Feb 26, 2021 at 02:31:31PM +0100, Heiner Kallweit wrote: > > > On 26.02.2021 13:18, Kai-Heng Feng wrote: > > > > On Fri, Feb 26, 2021 at 8:10 PM

[PATCH net] ibmvnic: always store valid MAC address

2021-03-04 Thread Jiri Wiesner
The last change to ibmvnic_set_mac(), 8fc3672a8ad3, meant to prevent users from setting an invalid MAC address on an ibmvnic interface that has not been brought up yet. The change also prevented the requested MAC address from being stored by the adapter object for an ibmvnic interface when the stat

Re: [PATCH] scsi: target: vhost-scsi: remove redundant initialization of variable ret

2021-03-04 Thread Stefan Hajnoczi
On Wed, Mar 03, 2021 at 01:43:39PM +, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused v

Minor update to bridge-utils

2021-03-04 Thread Stephen Hemminger
Small changes to bridge-utils to address some minor issues. 1. The default branch is main not master 2. Fixed some compiler warnings because Gcc 10 and Clang now do checks for string overflow. 3. Made a backup repository mirror at github. 4. Fixed version string printed This is not a requir

Re: [PATCH 1/1] net: usb: qmi_wwan: allow qmimux add/del with master up

2021-03-04 Thread Bjørn Mork
Daniele Palmas writes: > There's no reason for preventing the creation and removal > of qmimux network interfaces when the underlying interface > is up. > > This makes qmi_wwan mux implementation more similar to the > rmnet one, simplifying userspace management of the same > logical interfaces. >

Re: [regression] Kernel panic on resume from sleep

2021-03-04 Thread Jakub Kicinski
On Thu, 4 Mar 2021 13:50:01 +0100 Zbynek Michl wrote: > Looks good so far, but need to wait some more time as the issue was irregular. > > Do you have any explanation why the calls disorder caused the panic > just occasionally? Depends if kernel attempts to try to send a packet before __alx_open(

[PATCH net] netdevsim: init u64 stats for 32bit hardware

2021-03-04 Thread Jakub Kicinski
From: Hillf Danton Init the u64 stats in order to avoid the lockdep prints on the 32bit hardware like INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 4695 Comm: syz-executor.0 Not tainted 5.11.

[PATCH] net: sched: avoid duplicates in classes dump

2021-03-04 Thread Maximilian Heyne
This is a follow up of commit ea3274695353 ("net: sched: avoid duplicates in qdisc dump") which has fixed the issue only for the qdisc dump. The duplicate printing also occurs when dumping the classes via tc class show dev eth0 Fixes: 59cc1f61f09c ("net: sched: convert qdisc linked list to hash

Re: [PATCH net] ethtool: Add indicator field for link_mode validity to link_ksettings

2021-03-04 Thread Jakub Kicinski
On Thu, 4 Mar 2021 11:09:33 +0200 Danielle Ratson wrote: > Some drivers clear the 'ethtool_link_ksettings' struct in their > get_link_ksettings() callback, before populating it with actual values. > Such drivers will set the new 'link_mode' field to zero, resulting in > user space receiving wrong l

Re: [PATCH net 1/3] net: ethernet: ixgbe: don't propagate -ENODEV from ixgbe_mii_bus_init()

2021-03-04 Thread Jakub Kicinski
On Wed, 3 Mar 2021 17:06:47 -0800 Tony Nguyen wrote: > From: Bartosz Golaszewski > > It's a valid use-case for ixgbe_mii_bus_init() to return -ENODEV - we > still want to finalize the registration of the ixgbe device. Check the > error code and don't bail out if err == -ENODEV. > > This fixes a

Re: [PATCH bpf-next v4 1/5] bpf: consolidate shared test timing code

2021-03-04 Thread Andrii Nakryiko
On Wed, Mar 3, 2021 at 2:18 AM Lorenz Bauer wrote: > > Share the timing / signal interruption logic between different > implementations of PROG_TEST_RUN. There is a change in behaviour > as well. We check the loop exit condition before checking for > pending signals. This resolves an edge case whe

[RFC PATCH V2 net-next 0/5] ethtool: Extend module EEPROM dump API

2021-03-04 Thread Moshe Shemesh
Ethtool supports module EEPROM dumps via the `ethtool -m ` command. But in current state its functionality is limited - offset and length parameters, which are used to specify a linear desired region of EEPROM data to dump, is not enough, considering emergence of complex module EEPROM layouts such

[RFC PATCH V2 net-next 3/5] net/mlx5: Implement get_module_eeprom_data_by_page()

2021-03-04 Thread Moshe Shemesh
From: Vladyslav Tarasiuk Implement ethtool_ops::get_module_eeprom_data_by_page() to enable support of new SFP standards. Signed-off-by: Vladyslav Tarasiuk --- .../ethernet/mellanox/mlx5/core/en_ethtool.c | 42 +++ .../net/ethernet/mellanox/mlx5/core/port.c| 33

[RFC PATCH V2 net-next 2/5] net/mlx5: Refactor module EEPROM query

2021-03-04 Thread Moshe Shemesh
From: Vladyslav Tarasiuk Prepare for ethtool_ops::get_module_eeprom_data() implementation by extracting common part of mlx5_query_module_eeprom() into a separate function. Signed-off-by: Vladyslav Tarasiuk --- .../net/ethernet/mellanox/mlx5/core/port.c| 79 +++ include/linu

[RFC PATCH V2 net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data

2021-03-04 Thread Moshe Shemesh
From: Vladyslav Tarasiuk Define get_module_eeprom_data_by_page() ethtool callback and implement netlink infrastructure. get_module_eeprom_data_by_page() allows network drivers to dump a part of module's EEPROM specified by page and bank numbers along with offset and length. It is effectively a n

[RFC PATCH V2 net-next 4/5] net/mlx5: Add support for DSFP module EEPROM dumps

2021-03-04 Thread Moshe Shemesh
From: Vladyslav Tarasiuk Allow the driver to recognise DSFP transceiver module ID and therefore allow its EEPROM dumps using ethtool. Signed-off-by: Vladyslav Tarasiuk --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 3 ++- include/linux/mlx5/port.h | 1 + 2 files chan

[RFC PATCH V2 net-next 5/5] ethtool: Add fallback to get_module_eeprom from netlink command

2021-03-04 Thread Moshe Shemesh
From: Vladyslav Tarasiuk In case netlink get_module_eeprom_data_by_page() callback is not implemented by the driver, try to call old get_module_info() and get_module_eeprom() pair. Recalculate parameters to get_module_eeprom() offset and len using page number and their sizes. Return error if this

Re: [PATCH net 1/3] net: ethernet: ixgbe: don't propagate -ENODEV from ixgbe_mii_bus_init()

2021-03-04 Thread Nguyen, Anthony L
On Thu, 2021-03-04 at 10:50 -0800, Jakub Kicinski wrote: > On Wed, 3 Mar 2021 17:06:47 -0800 Tony Nguyen wrote: > > From: Bartosz Golaszewski > > > > It's a valid use-case for ixgbe_mii_bus_init() to return -ENODEV - > > we > > still want to finalize the registration of the ixgbe device. Check >

[BUG] hitting bug when running spinlock test

2021-03-04 Thread Jiri Olsa
hi, I'm getting attached BUG/crash when running in parralel selftests, like: while :; do ./test_progs -t spinlock; done while :; do ./test_progs ; done it's the latest bpf-next/master, I can send the .config if needed, but I don't think there's anything special about it, because I saw the bug

Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-04 Thread Jakub Kicinski
On Thu, 4 Mar 2021 13:51:15 +0100 Eric Dumazet wrote: > I think we are over thinking this really (especially if the fix needs > a change in core networking or drivers) > > We can reuse TSQ logic to have a chance to recover when the clone is > eventually freed. > This will be more generic, not only

Re: [PATCH net] net: usb: cdc_ncm: don't spew notifications

2021-03-04 Thread Grant Grundler
On Wed, Jan 20, 2021 at 5:04 PM Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 03:38:32 + Hayes Wang wrote: > > Grant Grundler > > > Sent: Wednesday, January 20, 2021 9:12 AM > > > Subject: [PATCH net] net: usb: cdc_ncm: don't spew notifications > > > > > > RTL8156 sends notifications about ev

[PATCH net v2 0/2][pull request] Intel Wired LAN Driver Updates 2021-03-04

2021-03-04 Thread Tony Nguyen
This series contains updates to ixgbe and ixgbevf drivers. Antony Antony adds a check to fail for non transport mode SA with offload as this is not supported for ixgbe and ixgbevf. Dinghao Liu fixes a memory leak on failure to program a perfect filter for ixgbe. v2: - Dropped patch 1 The follow

[PATCH net v2 2/2] ixgbe: Fix memleak in ixgbe_configure_clsu32

2021-03-04 Thread Tony Nguyen
From: Dinghao Liu When ixgbe_fdir_write_perfect_filter_82599() fails, input allocated by kzalloc() has not been freed, which leads to memleak. Signed-off-by: Dinghao Liu Reviewed-by: Paul Menzel Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_

[PATCH net v2 1/2] ixgbe: fail to create xfrm offload of IPsec tunnel mode SA

2021-03-04 Thread Tony Nguyen
From: Antony Antony Based on talks and indirect references ixgbe IPsec offlod do not support IPsec tunnel mode offload. It can only support IPsec transport mode offload. Now explicitly fail when creating non transport mode SA with offload to avoid false performance expectations. Fixes: 63a67fe22

[PATCHv2] gianfar: fix jumbo packets+napi+rx overrun crash

2021-03-04 Thread michael-dev
From: Michael Braun When using jumbo packets and overrunning rx queue with napi enabled, the following sequence is observed in gfar_add_rx_frag: | lstatus | | skb | t | lstatus, size, flags| first | len, data_len, *ptr |

Re: [PATCH] net: mellanox: mlx5: fix error return code in mlx5_fpga_device_start()

2021-03-04 Thread Heiner Kallweit
On 04.03.2021 15:18, Jia-Ju Bai wrote: > When mlx5_is_fpga_lookaside() returns a non-zero value, no error > return code is assigned. > To fix this bug, err is assigned with -EINVAL as error return code. > To me it looks like the current behavior is intentional. Did you verify that it's actually a

Re: [PATCHv2] gianfar: fix jumbo packets+napi+rx overrun crash

2021-03-04 Thread Vladimir Oltean
Hi Michael, On Thu, Mar 04, 2021 at 08:52:52PM +0100, michael-...@fami-braun.de wrote: > From: Michael Braun > > When using jumbo packets and overrunning rx queue with napi enabled, > the following sequence is observed in gfar_add_rx_frag: > >| lstatus | | s

Re: [PATCH AUTOSEL 5.10 050/217] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-04 Thread Sasha Levin
On Tue, Mar 02, 2021 at 08:25:49PM +0100, Marek Vasut wrote: On 12/23/20 3:13 AM, Sasha Levin wrote: Hello Sasha, From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fail

Re: [PATCH] net: sched: avoid duplicates in classes dump

2021-03-04 Thread Cong Wang
On Thu, Mar 4, 2021 at 6:44 AM Maximilian Heyne wrote: > > This is a follow up of commit ea3274695353 ("net: sched: avoid > duplicates in qdisc dump") which has fixed the issue only for the qdisc > dump. > > The duplicate printing also occurs when dumping the classes via > tc class show dev eth0

[PATCH] netlink.7: note not reliable if NETLINK_NO_ENOBUFS

2021-03-04 Thread Alexander Aring
This patch adds a note to the netlink manpage that if NETLINK_NO_ENOBUFS is set there is no additional handling to make netlink reliable. It just disables the error notification. The used word "avoid" receiving ENOBUFS errors can be interpreted that netlink tries to do some additional queue handlin

[PATCH resend] netlink.7: note not reliable if NETLINK_NO_ENOBUFS

2021-03-04 Thread Alexander Aring
This patch adds a note to the netlink manpage that if NETLINK_NO_ENOBUFS is set there is no additional handling to make netlink reliable. It just disables the error notification. The used word "avoid" receiving ENOBUFS errors can be interpreted that netlink tries to do some additional queue handlin

Re: [PATCH AUTOSEL 5.10 050/217] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-04 Thread Marek Vasut
On 3/4/21 9:47 PM, Sasha Levin wrote: On Tue, Mar 02, 2021 at 08:25:49PM +0100, Marek Vasut wrote: On 12/23/20 3:13 AM, Sasha Levin wrote: Hello Sasha, From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Inte

Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-04 Thread Jonathan Lemon
On Thu, Mar 04, 2021 at 08:41:45PM +0100, Eric Dumazet wrote: > On Thu, Mar 4, 2021 at 8:06 PM Jakub Kicinski wrote: > > > > On Thu, 4 Mar 2021 13:51:15 +0100 Eric Dumazet wrote: > > > I think we are over thinking this really (especially if the fix needs > > > a change in core networking or driver

  1   2   3   >