Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-02 Thread Eric Dumazet
On Tue, Mar 2, 2021 at 7:08 AM Jakub Kicinski wrote: > > When receiver does not accept TCP Fast Open it will only ack > the SYN, and not the data. We detect this and immediately queue > the data for (re)transmission in tcp_rcv_fastopen_synack(). > > In DC networks with very low RTT and without RFS

Re: [Patch bpf-next] skmsg: add function doc for skb->_sk_redir

2021-03-02 Thread Lorenz Bauer
On Mon, 1 Mar 2021 at 18:48, Cong Wang wrote: > > From: Cong Wang > > This should fix the following warning: > > include/linux/skbuff.h:932: warning: Function parameter or member > '_sk_redir' not described in 'sk_buff' Thanks! Acked-by: Lorenz Bauer -- Lorenz Bauer | Systems Engineer 6th

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-02 Thread Michael S. Tsirkin
On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: > > On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: > > On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: > > > > Detecting it isn't enough though, we will need a new ioctl to notify > > > > the kernel that it's a legacy guest. U

Re: [PATCH bpf 2/4] nsfs: add an ioctl to discover the network namespace cookie

2021-03-02 Thread Lorenz Bauer
On Mon, 1 Mar 2021 at 10:04, Christian Brauner wrote: > > Hey Lorenz, > > Just to make sure: is it intentional that any user can retrieve the > cookie associated with any network namespace, i.e. you don't require any > form of permission checking in the owning user namespace of the network > names

Re: [PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Michael S. Tsirkin
On Tue, Mar 02, 2021 at 04:14:18AM -0500, Jason Wang wrote: > When CAP_IPC_LOCK is set we should not check locked memory against > rlimit as what has been implemented in mlock(). > > Signed-off-by: Jason Wang Indeed and it's not just mlock. Documentation/admin-guide/perf-security.rst: RLIMIT_M

[v2 PATCH 0/1] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

2021-03-02 Thread Biao Huang
V2: update the comment for unmapping the old skb Biao Huang (1): net: ethernet: mtk-star-emac: fix wrong unmap in RX handling drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1

[v2 PATCH] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

2021-03-02 Thread Biao Huang
mtk_star_dma_unmap_rx() should unmap the dma_addr of old skb rather than that of new skb. Assign new_dma_addr to desc_data.dma_addr after all handling of old skb ends to avoid unexpected receive side error. Fixes: f96e9641e92b ("net: ethernet: mtk-star-emac: fix error path in RX handling") Acked-

Re: [PATCH bpf 2/4] nsfs: add an ioctl to discover the network namespace cookie

2021-03-02 Thread Christian Brauner
On Tue, Mar 02, 2021 at 09:47:10AM +, Lorenz Bauer wrote: > On Mon, 1 Mar 2021 at 10:04, Christian Brauner > wrote: > > > > Hey Lorenz, > > > > Just to make sure: is it intentional that any user can retrieve the > > cookie associated with any network namespace, i.e. you don't require any > > f

Re: Re: [RFC v4 02/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-03-02 Thread Yongji Xie
On Tue, Mar 2, 2021 at 2:47 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > Use vhost_dev->mutex to protect vhost device iotlb from > > concurrent access. > > > > Fixes: 4c8cf318("vhost: introduce vDPA-based backend") > > Signed-off-by: Xie Yongji > > --- > > drivers/vhos

Re: [PATCH bpf-next v3 0/4] selftests/bpf: xsk improvements and new stats tests

2021-03-02 Thread Björn Töpel
On Tue, 23 Feb 2021 at 17:53, Ciara Loftus wrote: > > This series attempts to improve the xsk selftest framework by: > 1. making the default output less verbose > 2. adding an optional verbose flag to both the test_xsk.sh script and > xdpxceiver app. > 3. renaming the debug option in the app to t

Re: [PATCH bpf-next 1/2] xsk: update rings for load-acquire/store-release semantics

2021-03-02 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > On 2021-03-01 17:08, Toke Høiland-Jørgensen wrote: >> Björn Töpel writes: >> >>> From: Björn Töpel >>> >>> Currently, the AF_XDP rings uses smp_{r,w,}mb() fences on the >>> kernel-side. By updating the rings for load-acquire/store-release >>> semantics, the full barrier o

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-02 Thread Jiri Olsa
On Mon, Mar 01, 2021 at 02:58:53PM -0800, Yonghong Song wrote: > > > On 3/1/21 11:04 AM, Jiri Olsa wrote: > > When testing uprobes we the test gets GEP (Global Entry Point) > > address from kallsyms, but then the function is called locally > > so the uprobe is not triggered. > > > > Fixing this

Re: Re: [RFC v4 01/11] eventfd: Increase the recursion depth of eventfd_signal()

2021-03-02 Thread Yongji Xie
On Tue, Mar 2, 2021 at 2:44 PM Jason Wang wrote: > > > On 2021/2/23 7:50 下午, Xie Yongji wrote: > > Increase the recursion depth of eventfd_signal() to 1. This > > is the maximum recursion depth we have found so far. > > > > Signed-off-by: Xie Yongji > > > Acked-by: Jason Wang > > It might be use

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-02 Thread Dario Binacchi
Hi Marc, > Il 01/03/2021 20:45 Marc Kleine-Budde ha scritto: > > > On 01.03.2021 18:21:42, Dario Binacchi wrote: > > > > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev) > > > > while ((idx = ffs(pend))) { > > > > idx--; > > > > pend &

[PATCH V2] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock() and documented in Documentation/admin-guide/perf-security.rst: " RLIMIT_MEMLOCK and perf_event_mlock_kb resource constraints are ignored for processes with the CAP_IPC_LOCK capability.

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-02 Thread Jason Wang
On 2021/3/2 5:47 下午, Michael S. Tsirkin wrote: On Mon, Mar 01, 2021 at 11:56:50AM +0800, Jason Wang wrote: On 2021/3/1 5:34 上午, Michael S. Tsirkin wrote: On Wed, Feb 24, 2021 at 10:24:41AM -0800, Si-Wei Liu wrote: Detecting it isn't enough though, we will need a new ioctl to notify the kerne

Re: [PATCH] vhost-vdpa: honor CAP_IPC_LOCK

2021-03-02 Thread Jason Wang
On 2021/3/2 5:51 下午, Michael S. Tsirkin wrote: On Tue, Mar 02, 2021 at 04:14:18AM -0500, Jason Wang wrote: When CAP_IPC_LOCK is set we should not check locked memory against rlimit as what has been implemented in mlock(). Signed-off-by: Jason Wang Indeed and it's not just mlock. Documentat

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-02 Thread Marc Kleine-Budde
On 3/2/21 11:50 AM, Dario Binacchi wrote: > Hi Marc, > >> Il 01/03/2021 20:45 Marc Kleine-Budde ha scritto: >> >> >> On 01.03.2021 18:21:42, Dario Binacchi wrote: > @@ -730,7 +728,7 @@ static void c_can_do_tx(struct net_device *dev) > while ((idx = ffs(pend))) { > idx--;

VRF leaking doesn't work

2021-03-02 Thread Greesha Mikhalkin
Hi. I need a help to understand why VRF leaking doesn’t work in my situation. I want to set up leaking between 2 VRFs, that are set up by following commands: # Setup bridge sudo ip link add bridge type bridge # Setup VLANs ip link add link bridge name vlan1 type vlan id 1

WARNING: refcount bug in sctp_transport_put (3)

2021-03-02 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:2c87f7a3 Merge tag 'pwm/for-5.12-rc1' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=155a6632d0 kernel config: https://syzkaller.appspot.com/x/.config?x=eb762f1df8da5074 das

KASAN: use-after-free Read in cipso_v4_genopt

2021-03-02 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5695e516 Merge tag 'io_uring-worker.v3-2021-02-25' of git:.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=168c27f2d0 kernel config: https://syzkaller.appspot.com/x/.config?x=e33ab2de74f48295 das

Re: [PATCH] vdpa/mlx5: Fix wrong use of bit numbers

2021-03-02 Thread Michael S. Tsirkin
On Tue, Mar 02, 2021 at 07:23:06AM +0200, Eli Cohen wrote: > On Mon, Mar 01, 2021 at 10:33:14AM -0500, Michael S. Tsirkin wrote: > > On Mon, Mar 01, 2021 at 03:52:45PM +0800, Jason Wang wrote: > > > > > > On 2021/3/1 2:28 下午, Eli Cohen wrote: > > > > VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL

Re: dsa_master_find_slave()'s time complexity and potential performance hit

2021-03-02 Thread Vladimir Oltean
On Tue, Mar 02, 2021 at 01:51:42PM +0800, DENG Qingfang wrote: > Since commit 7b9a2f4bac68 ("net: dsa: use ports list to find slave"), > dsa_master_find_slave() has been iterating over a linked list instead > of accessing arrays, making its time complexity O(n). > The said function is called freque

Re: [PATCH v3 net 0/8] Fixes for NXP ENETC driver

2021-03-02 Thread Vladimir Oltean
On Mon, Mar 01, 2021 at 09:40:07PM +, patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This series was applied to netdev/net.git (refs/heads/master): > > On Mon, 1 Mar 2021 13:18:10 +0200 you wrote: > > From: Vladimir Oltean > > > > This contains an assorted set of fixes collected o

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-02 Thread Jiri Olsa
On Mon, Mar 01, 2021 at 04:34:24PM -0800, Andrii Nakryiko wrote: > On Mon, Mar 1, 2021 at 11:11 AM Jiri Olsa wrote: > > > > When testing uprobes we the test gets GEP (Global Entry Point) > > address from kallsyms, but then the function is called locally > > so the uprobe is not triggered. > > > >

[PATCH net] octeontx2-af: cn10k: fix an array overflow in is_lmac_valid()

2021-03-02 Thread Dan Carpenter
The value of "lmac_id" can be controlled by the user and if it is larger then the number of bits in long then it reads outside the bitmap. The highest valid value is less than MAX_LMAC_PER_CGX (4). Fixes: 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support") Signed-off-by: Dan Carpenter ---

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-03-02 Thread Cornelia Huck
On Mon, 1 Mar 2021 11:51:08 +0800 Jason Wang wrote: > On 2021/3/1 5:25 上午, Michael S. Tsirkin wrote: > > On Fri, Feb 26, 2021 at 04:19:16PM +0800, Jason Wang wrote: > >> On 2021/2/26 2:53 上午, Michael S. Tsirkin wrote: > >>> Confused. What is wrong with the above? It never reads the > >>> fie

[PATCH AUTOSEL 4.19 17/21] i40e: Fix memory leak in i40e_probe

2021-03-02 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit 58cab46c622d6324e47bd1c533693c94498e4172 ] Struct i40e_veb is allocated in function i40e_setup_pf_switch, and stored to an array field veb inside struct i40e_pf. However when i40e_setup_misc_vector fails, this memory leaks. Fix this by calling exit and teard

[PATCH AUTOSEL 5.10 38/47] i40e: Fix memory leak in i40e_probe

2021-03-02 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit 58cab46c622d6324e47bd1c533693c94498e4172 ] Struct i40e_veb is allocated in function i40e_setup_pf_switch, and stored to an array field veb inside struct i40e_pf. However when i40e_setup_misc_vector fails, this memory leaks. Fix this by calling exit and teard

[PATCH net] can: dev: Move device back to init netns on owning netns delete

2021-03-02 Thread Martin Willi
When a non-initial netns is destroyed, the usual policy is to delete all virtual network interfaces contained, but move physical interfaces back to the initial netns. This keeps the physical interface visible on the system. CAN devices are somewhat special, as they define rtnl_link_ops even if the

[PATCH AUTOSEL 5.11 42/52] i40e: Fix memory leak in i40e_probe

2021-03-02 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit 58cab46c622d6324e47bd1c533693c94498e4172 ] Struct i40e_veb is allocated in function i40e_setup_pf_switch, and stored to an array field veb inside struct i40e_pf. However when i40e_setup_misc_vector fails, this memory leaks. Fix this by calling exit and teard

Re: [PATCH 1/2] Bluetooth: Notify suspend on le conn failed

2021-03-02 Thread Marcel Holtmann
Hi Abhishek, > When suspending, Bluetooth disconnects all connected peers devices. If > an LE connection is started but isn't completed, we will see an LE > Create Connection Cancel instead of an HCI disconnect. This just adds > a check to see if an LE cancel was the last disconnected device and w

[PATCH AUTOSEL 5.4 27/33] i40e: Fix memory leak in i40e_probe

2021-03-02 Thread Sasha Levin
From: Keita Suzuki [ Upstream commit 58cab46c622d6324e47bd1c533693c94498e4172 ] Struct i40e_veb is allocated in function i40e_setup_pf_switch, and stored to an array field veb inside struct i40e_pf. However when i40e_setup_misc_vector fails, this memory leaks. Fix this by calling exit and teard

Re: [PATCH wpan 02/17] net: ieee802154: fix memory leak when deliver monitor skbs

2021-03-02 Thread Stefan Schmidt
Hello Alex. On 01.03.21 04:16, Alexander Aring wrote: Hi Stefan, On Sun, 28 Feb 2021 at 10:21, Alexander Aring wrote: This patch adds a missing consume_skb() when deliver a skb to upper monitor interfaces of a wpan phy. Reported-by: syzbot+44b651863a17760a8...@syzkaller.appspotmail.com Sign

Re: BUG: soft lockup in ieee80211_tasklet_handler

2021-03-02 Thread Johannes Berg
On Wed, 2021-02-24 at 10:30 +0800, Hillf Danton wrote: > > Add budget for the 80211 softint handler - it's feasible not to try to > build the giant pyramid in a week. > > --- x/net/mac80211/main.c > +++ y/net/mac80211/main.c > @@ -224,9 +224,15 @@ static void ieee80211_tasklet_handler(un > { >

Re: [PATCH 2/2] Bluetooth: Remove unneeded commands for suspend

2021-03-02 Thread Marcel Holtmann
Hi Abhishek, > During suspend, there are a few scan enable and set event filter > commands that don't need to be sent unless there are actual BR/EDR > devices capable of waking the system. Check the HCI_PSCAN bit before > writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED > to

Re: [PATCH net-next v3 1/8] ethtool: Add support for configuring frame preemption

2021-03-02 Thread Vladimir Oltean
Hi Vinicius, On Fri, Jan 22, 2021 at 02:44:46PM -0800, Vinicius Costa Gomes wrote: > Frame preemption (described in IEEE 802.3br-2016) defines the concept > of preemptible and express queues. It allows traffic from express > queues to "interrupt" traffic from preemptible queues, which are > "resum

[RESEND PATCH v11 1/3] dt-bindings: vendor-prefixes: Add asix prefix

2021-03-02 Thread Łukasz Stelmach
Add the prefix for ASIX Electronics Corporation. Signed-off-by: Łukasz Stelmach Reviewed-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefi

[RESEND PATCH v11 0/3] AX88796C SPI Ethernet Adapter

2021-03-02 Thread Łukasz Stelmach
This is a driver for AX88796C Ethernet Adapter connected in SPI mode as found on ARTIK5 evaluation board. The driver has been ported from a v3.10.9 vendor kernel for ARTIK5 board. Changes in v11: - changed stat counters to 64-bit - replaced WARN_ON(!mutex_is_locked()) with lockdep_assert_held(

[RESEND PATCH v11 2/3] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2021-03-02 Thread Łukasz Stelmach
Add bindings for AX88796C SPI Ethernet Adapter. Signed-off-by: Łukasz Stelmach Reviewed-by: Rob Herring Acked-by: Krzysztof Kozlowski --- .../bindings/net/asix,ax88796c.yaml | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindin

[RESEND PATCH v11 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2021-03-02 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-02 Thread Lorenzo Bianconi
> On Mon, 1 Mar 2021 13:23:06 +0200 > Shay Agroskin wrote: > > > Jesper Dangaard Brouer writes: > > > > > On Sun, 28 Feb 2021 23:27:25 +0100 > > > Lorenzo Bianconi wrote: > > > > > >> > > drops = bq->count - sent; > > >> > > -out: > > >> > > -bq->count = 0; > > >> > > +if (unlik

[PATCH] rtnetlink: using dev_base_seq from target net

2021-03-02 Thread zhang kai
Signed-off-by: zhang kai --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 0edc0b2ba..1bdcb33fb 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2147,7 +2147,7 @@ static int rtnl_dump_ifin

[PATCH][next] net: fddi: skfp: smt: Replace one-element array with flexible-array member

2021-03-02 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. Refacto

Re: [RFC net-next] net: dsa: rtl8366rb: support bridge offloading

2021-03-02 Thread Linus Walleij
On Tue, Mar 2, 2021 at 4:58 AM DENG Qingfang wrote: > On Mon, Mar 1, 2021 at 9:48 PM Linus Walleij wrote: > > With my minor changes: > > Tested-by: Linus Walleij > > How about using a mutex lock in port_bridge_{join,leave} ? > In my opinion all functions that access multiple registers should be

Re: KASAN: use-after-free Read in cipso_v4_genopt

2021-03-02 Thread Paul Moore
On Tue, Mar 2, 2021 at 6:03 AM Dmitry Vyukov wrote: > ... > Besides these 2 crashes, we've also seen one on a 4.19 based kernel, see > below. > Based on the reports with mismatching stacks, it looks like > cipso_v4_genopt is doing some kind of wild pointer access (uninit > pointer?). Hmm, inte

Re: [Patch bpf-next v2 2/9] sock: introduce sk_prot->update_proto()

2021-03-02 Thread Lorenz Bauer
On Tue, 2 Mar 2021 at 02:37, Cong Wang wrote: ... > @@ -350,25 +351,12 @@ static inline void sk_psock_cork_free(struct sk_psock > *psock) > } > } > > -static inline void sk_psock_update_proto(struct sock *sk, > -struct sk_psock *psock, > -

Re: [Patch bpf-next v2 9/9] selftests/bpf: add a test case for udp sockmap

2021-03-02 Thread Lorenz Bauer
On Tue, 2 Mar 2021 at 02:38, Cong Wang wrote: > > From: Cong Wang > > Add a test case to ensure redirection between two UDP sockets work. I basically don't understand how splicing works, but watching from the sidelines makes me think it'd be good to have more thorough tests. tools/testing/selfte

Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-02 Thread Jakub Kicinski
On Tue, 2 Mar 2021 10:38:46 +0100 Eric Dumazet wrote: > On Tue, Mar 2, 2021 at 7:08 AM Jakub Kicinski wrote: > > > > When receiver does not accept TCP Fast Open it will only ack > > the SYN, and not the data. We detect this and immediately queue > > the data for (re)transmission in tcp_rcv_fastope

Re: MACSEC configuration - is CONFIG_MACSEC enough?

2021-03-02 Thread Tom Cook
Never mind, I found commit b3bdc3acbb44d74d0b7ba4d97169577a2b46dc88 that fixed this in 4.10-rc9 or so. Sorry for wasting your time. Regards, Tom Cook On Mon, Mar 1, 2021 at 3:00 PM Tom Cook wrote: > > I'm trying to use MACSEC on an arm64 embedded platform; I'm trying to > create an encrypted ch

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-02 Thread Yonghong Song
On 3/2/21 3:14 AM, Jiri Olsa wrote: On Mon, Mar 01, 2021 at 04:34:24PM -0800, Andrii Nakryiko wrote: On Mon, Mar 1, 2021 at 11:11 AM Jiri Olsa wrote: When testing uprobes we the test gets GEP (Global Entry Point) address from kallsyms, but then the function is called locally so the uprobe

Re: [RFC net-next] net: dsa: rtl8366rb: support bridge offloading

2021-03-02 Thread Linus Walleij
On Tue, Mar 2, 2021 at 5:11 PM Vladimir Oltean wrote: > On Tue, Mar 02, 2021 at 05:05:00PM +0100, Linus Walleij wrote: > > On Tue, Mar 2, 2021 at 4:58 AM DENG Qingfang wrote: > > > On Mon, Mar 1, 2021 at 9:48 PM Linus Walleij > > > wrote: > > > > With my minor changes: > > > > Tested-by: Linus

[PATCH net-next v2] tcp: make TCP Fast Open retransmission ignore Tx status

2021-03-02 Thread Jakub Kicinski
When receiver does not accept TCP Fast Open it will only ack the SYN, and not the data. We detect this and immediately queue the data for (re)transmission in tcp_rcv_fastopen_synack(). In DC networks with very low RTT and without RFS the SYN-ACK may arrive before NIC driver reported Tx completion

Re: [Patch bpf-next v2 5/9] udp: add ->read_sock() and ->sendmsg_locked() to ipv6

2021-03-02 Thread Lorenz Bauer
On Tue, 2 Mar 2021 at 02:38, Cong Wang wrote: ... > diff --git a/include/net/ipv6.h b/include/net/ipv6.h > index bd1f396cc9c7..48b6850dae85 100644 > --- a/include/net/ipv6.h > +++ b/include/net/ipv6.h > @@ -1119,6 +1119,7 @@ int inet6_hash_connect(struct inet_timewait_death_row > *death_row, >

Re: [PATCH net-next v2] tcp: make TCP Fast Open retransmission ignore Tx status

2021-03-02 Thread Jakub Kicinski
On Tue, 2 Mar 2021 09:52:59 -0800 Jakub Kicinski wrote: > When receiver does not accept TCP Fast Open it will only ack > the SYN, and not the data. We detect this and immediately queue > the data for (re)transmission in tcp_rcv_fastopen_synack(). > > In DC networks with very low RTT and without R

Re: [Patch bpf-next v2 5/9] udp: add ->read_sock() and ->sendmsg_locked() to ipv6

2021-03-02 Thread Cong Wang
On Tue, Mar 2, 2021 at 8:23 AM Lorenz Bauer wrote: > > On Tue, 2 Mar 2021 at 02:38, Cong Wang wrote: > > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > > index 54f24b1d4f65..717c543aaec3 100644 > > --- a/net/ipv4/udp.c > > +++ b/net/ipv4/udp.c > > @@ -1831,6 +1831,7 @@ int udp_read_sock(struct so

Re: [Patch bpf-next v2 9/9] selftests/bpf: add a test case for udp sockmap

2021-03-02 Thread Cong Wang
On Tue, Mar 2, 2021 at 8:32 AM Lorenz Bauer wrote: > > On Tue, 2 Mar 2021 at 02:38, Cong Wang wrote: > > > > From: Cong Wang > > > > Add a test case to ensure redirection between two UDP sockets work. > > I basically don't understand how splicing works, but watching from the > sidelines makes me

Re: [Patch bpf-next v2 2/9] sock: introduce sk_prot->update_proto()

2021-03-02 Thread Cong Wang
On Tue, Mar 2, 2021 at 8:22 AM Lorenz Bauer wrote: > > On Tue, 2 Mar 2021 at 02:37, Cong Wang wrote: > > ... > > static inline void sk_psock_restore_proto(struct sock *sk, > > struct sk_psock *psock) > > { > > sk->sk_prot->unhash = psock->saved_

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-02 Thread Andrii Nakryiko
On Tue, Mar 2, 2021 at 3:14 AM Jiri Olsa wrote: > > On Mon, Mar 01, 2021 at 04:34:24PM -0800, Andrii Nakryiko wrote: > > On Mon, Mar 1, 2021 at 11:11 AM Jiri Olsa wrote: > > > > > > When testing uprobes we the test gets GEP (Global Entry Point) > > > address from kallsyms, but then the function i

[PATCH] iwlwifi: ensure that DMI scan table is properly terminated

2021-03-02 Thread Jens Axboe
My laptop crashes at boot, and I ran the same kernel with KASAN enabled. Turns out the DMI addition for iwlwifi is broken (and untested?), since it doesn't properly terminate the scan table. Ensure that we do so. == BUG: KASAN: global

Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-03-02 Thread Coelho, Luciano
On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote: > Nathan Chancellor writes: > > > On Tue, Feb 23, 2021 at 02:00:39PM +, Wei Yongjun wrote: > > > Make sure dmi_system_id tables are NULL terminated. > > > > > > Fixes: a2ac0f48a07c ("iwlwifi: mvm: implement approved list for the PPAG > >

Re: [PATCH] iwlwifi: ensure that DMI scan table is properly terminated

2021-03-02 Thread Coelho, Luciano
On Tue, 2021-03-02 at 11:20 -0700, Jens Axboe wrote: > My laptop crashes at boot, and I ran the same kernel with KASAN enabled. > Turns out the DMI addition for iwlwifi is broken (and untested?), since > it doesn't properly terminate the scan table. Ensure that we do so. > > ==

Re: [PATCH 4/5] net: page_pool: refactor dma_map into own function page_pool_dma_map

2021-03-02 Thread Ilias Apalodimas
Hi Mel, Can you please CC me in future revisions. I almost missed that! On Mon, Mar 01, 2021 at 04:11:59PM +, Mel Gorman wrote: > From: Jesper Dangaard Brouer > > In preparation for next patch, move the dma mapping into its own > function, as this will make it easier to follow the changes.

Re: [PATCH net 0/3] Fix TRSCER masks in the Ether driver

2021-03-02 Thread Geert Uytterhoeven
On Mon, Mar 1, 2021 at 10:38 PM wrote: > This series was applied to netdev/net.git (refs/heads/master): > > On Sun, 28 Feb 2021 23:24:16 +0300 you wrote: > > Here are 3 patches against DaveM's 'net' repo. I'm fixing the TRSCER masks > > in > > the driver to match the manuals... > > > > [1/3] sh_e

[PATCH v2 0/1] Bluetooth: Suspend improvements

2021-03-02 Thread Abhishek Pandit-Subedi
Hi Marcel (and linux bluetooth), Here are a few suspend improvements based on user reports we saw on ChromeOS and feedback from Hans de Goede on the mailing list. I have tested this using our ChromeOS suspend/resume automated tests (full SRHealth test coverage and some suspend resume stress tes

[PATCH v2 1/1] Bluetooth: Remove unneeded commands for suspend

2021-03-02 Thread Abhishek Pandit-Subedi
During suspend, there are a few scan enable and set event filter commands that don't need to be sent unless there are actual BR/EDR devices capable of waking the system. Check the HCI_PSCAN bit before writing scan enable and use a new dev flag, HCI_EVENT_FILTER_CONFIGURED to control whether to clea

Re: [PATCH bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

2021-03-02 Thread Jiri Olsa
On Tue, Mar 02, 2021 at 10:31:41AM -0800, Andrii Nakryiko wrote: > On Tue, Mar 2, 2021 at 3:14 AM Jiri Olsa wrote: > > > > On Mon, Mar 01, 2021 at 04:34:24PM -0800, Andrii Nakryiko wrote: > > > On Mon, Mar 1, 2021 at 11:11 AM Jiri Olsa wrote: > > > > > > > > When testing uprobes we the test gets

Re: [PATCH 10/11] pragma once: delete few backslashes

2021-03-02 Thread Vineet Gupta
On 2/28/21 9:05 AM, Alexey Dobriyan wrote: From 251ca5673886b5bb0a42004944290b9d2b267a4a Mon Sep 17 00:00:00 2001 From: Alexey Dobriyan Date: Fri, 19 Feb 2021 13:37:24 +0300 Subject: [PATCH 10/11] pragma once: delete few backslashes Some macros contain one backslash too many and end up being t

Re: [PATCH 5/5] net: page_pool: use alloc_pages_bulk in refill code path

2021-03-02 Thread Ilias Apalodimas
On Mon, Mar 01, 2021 at 04:12:00PM +, Mel Gorman wrote: > From: Jesper Dangaard Brouer > > There are cases where the page_pool need to refill with pages from the > page allocator. Some workloads cause the page_pool to release pages > instead of recycling these pages. > > For these workload i

Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-03-02 Thread Jakub Kicinski
On Tue, 2 Mar 2021 18:31:11 + Coelho, Luciano wrote: > On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote: > > Nathan Chancellor writes: > > > We received a report about a crash in iwlwifi when compiled with LTO and > > > this fix resolves it. > > > > That information should be added to th

Re: [PATCH v3 5/6] can: c_can: prepare to up the message objects number

2021-03-02 Thread Kurt Van Dijck
On Sun, 28 Feb 2021 11:38:54 +0100, Dario Binacchi wrote: > Date: Sun, 28 Feb 2021 11:38:54 +0100 > From: Dario Binacchi > To: linux-ker...@vger.kernel.org > Cc: Federico Vaga , Alexander Stein > , Dario Binacchi > , "David S. Miller" , Jakub > Kicinski , Marc Kleine-Budde , Oliver > Hartkop

Re: [PATCH v3 3/6] can: c_can: fix control interface used by c_can_do_tx

2021-03-02 Thread Kurt Van Dijck
On Sun, 28 Feb 2021 11:38:52 +0100, Dario Binacchi wrote: > According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use > IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX). > > Signed-off-by: Dario Binacchi > --- > > (no changes since v1) > > drivers/net/can/c_can/c_can.c | 2 +- >

[PATCH] iwlwifi: ensure that DMI scan table is properly terminated

2021-03-02 Thread Jens Axboe
My laptop crashes at boot, and I ran the same kernel with KASAN enabled. Turns out the DMI addition for iwlwifi is broken (and untested?), since it doesn't properly terminate the scan table. Ensure that we do so. == BUG: KASAN: global

Re: [PATCH AUTOSEL 5.10 050/217] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2021-03-02 Thread Marek Vasut
On 12/23/20 3:13 AM, Sasha Levin wrote: Hello Sasha, From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fails. The former is using wpa_supplicant during association, the

Re: [RFC net-next] net: dsa: rtl8366rb: support bridge offloading

2021-03-02 Thread Vladimir Oltean
On Tue, Mar 02, 2021 at 05:05:00PM +0100, Linus Walleij wrote: > On Tue, Mar 2, 2021 at 4:58 AM DENG Qingfang wrote: > > On Mon, Mar 1, 2021 at 9:48 PM Linus Walleij > > wrote: > > > With my minor changes: > > > Tested-by: Linus Walleij > > > > How about using a mutex lock in port_bridge_{join,

Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-03-02 Thread Kalle Valo
Jakub Kicinski writes: > On Tue, 2 Mar 2021 18:31:11 + Coelho, Luciano wrote: >> On Sat, 2021-02-27 at 08:39 +0200, Kalle Valo wrote: >> > Nathan Chancellor writes: >> > > We received a report about a crash in iwlwifi when compiled with LTO and >> > > this fix resolves it. >> > >> > That

Re: [PATCH] ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.

2021-03-02 Thread Sukadev Bhattiprolu
Michal Suchanek [msucha...@suse.de] wrote: > GCC 7.5 reports: > ../drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset_init': > ../drivers/net/ethernet/ibm/ibmvnic.c:5373:51: warning: 'old_num_tx_queues' > may be used uninitialized in this function [-Wmaybe-uninitialized] > ../drivers/n

Re: KASAN: use-after-free Read in cipso_v4_genopt

2021-03-02 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:7a7fd0de Merge branch 'kmap-conversion-for-5.12' of git://.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13693866d0 kernel config: https://syzkaller.appspot.com/x/.config?x=779a256

[PATCH] ibmvnic: Fix possibly uninitialized old_num_tx_queues variable warning.

2021-03-02 Thread Michal Suchanek
GCC 7.5 reports: ../drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_reset_init': ../drivers/net/ethernet/ibm/ibmvnic.c:5373:51: warning: 'old_num_tx_queues' may be used uninitialized in this function [-Wmaybe-uninitialized] ../drivers/net/ethernet/ibm/ibmvnic.c:5373:6: warning: 'old_num_r

Re: [PATCH wpan 01/17] net: ieee802154: make shift exponent unsigned

2021-03-02 Thread Stefan Schmidt
Hello Alex. On 28.02.21 16:18, Alexander Aring wrote: This patch changes the iftype type variable to unsigned that it can never be reach a negative value. Reported-by: syzbot+7bf7b22759195c9a2...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 2 +-

Re: [PATCH wpan 03/17] net: ieee802154: nl-mac: fix check on panid

2021-03-02 Thread Stefan Schmidt
Hello. On 28.02.21 16:18, Alexander Aring wrote: This patch fixes a null pointer derefence for panid handle by move the check for the netlink variable directly before accessing them. Reported-by: syzbot+d4c07de0144f6f63b...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/iee

Re: [PATCH] iwlwifi: mvm: add terminate entry for dmi_system_id tables

2021-03-02 Thread Jakub Kicinski
On Tue, 02 Mar 2021 21:50:18 +0200 Kalle Valo wrote: > > if Wei doesn't respond could you please step in to make sure this > > fix is part of Dave's next PR to Linus? > > Will do. Related to this, what's your pull request schedule to Linus > nowadays? Do you submit it every Thursday? Fair quest

Re: [PATCH wpan 04/17] net: ieee802154: forbid monitor for set llsec params

2021-03-02 Thread Stefan Schmidt
Hello Alex. On 28.02.21 16:18, Alexander Aring wrote: This patch forbids to set llsec params for monitor interfaces which we don't support yet. Reported-by: syzbot+8b6719da8a04beeaf...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file cha

[PATCH v4 5/6] can: c_can: prepare to up the message objects number

2021-03-02 Thread Dario Binacchi
As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") the "driver casts the 16 message objects in stone, which is completely braindead as contemporary hardware has up to 128 message objects". The patch prepares the module to extend the number of message objects beyond the 32 cur

[PATCH v4 6/6] can: c_can: add support to 64 message objects

2021-03-02 Thread Dario Binacchi
D_CAN controller supports 16, 32, 64 or 128 message objects, comparing to 32 on C_CAN. AM335x/AM437x Sitara processors and DRA7 SOC all instantiate a D_CAN controller with 64 message objects, as described in the "DCAN features" subsection of the CAN chapter of their technical reference manuals. Th

[PATCH v4 1/6] can: c_can: remove unused code

2021-03-02 Thread Dario Binacchi
Commit 9d23a9818cb1 ("can: c_can: Remove unused inline function") left behind C_CAN_MSG_OBJ_TX_LAST constant. Commit fa39b54ccf28 ("can: c_can: Get rid of pointless interrupts") left behind C_CAN_MSG_RX_LOW_LAST and C_CAN_MSG_OBJ_RX_SPLIT constants. The removed code also made a comment useless an

[PATCH v4 3/6] can: c_can: add a comment about IF_RX interface's use

2021-03-02 Thread Dario Binacchi
After reading the commit 640916db2bf7 ("can: c_can: Make it SMP safe") it may sound strange to see the IF_RX interface used by the can_inval_tx_object function. A comment was added to avoid any misunderstanding. Signed-off-by: Dario Binacchi --- Changes in v4: - Restore IF_RX interface. - Add a

Re: [PATCH net] net: tcp: don't allocate fast clones for fastopen SYN

2021-03-02 Thread Jakub Kicinski
On Tue, 2 Mar 2021 12:52:14 -0800 Yuchung Cheng wrote: > On Tue, Mar 2, 2021 at 11:58 AM Eric Dumazet wrote: > > On Tue, Mar 2, 2021 at 7:08 AM Jakub Kicinski wrote: > > > When receiver does not accept TCP Fast Open it will only ack > > > the SYN, and not the data. We detect this and immediatel

[PATCH v4 2/6] can: c_can: fix indentation

2021-03-02 Thread Dario Binacchi
Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v4 0/6] can: c_can: add support to 64 message objects

2021-03-02 Thread Dario Binacchi
The D_CAN controller supports up to 128 messages. Until now the driver only managed 32 messages although Sitara processors and DRA7 SOC can handle 64. The series was tested on a beaglebone board. Note: I have not changed the type of tx_field (belonging to the c_can_priv structure) to atomic64_t

Re: [RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET

2021-03-02 Thread Steven Rostedt
On Thu, 18 Feb 2021 08:42:15 +0300 Arseny Krasnov wrote: Not sure if this was pulled in yet, but I do have a small issue with this patch. > @@ -69,14 +82,19 @@ TRACE_EVENT(virtio_transport_alloc_pkt, > __entry->type = type; > __entry->op = op; > __entry-

[PATCH v4 4/6] can: c_can: use 32-bit write to set arbitration register

2021-03-02 Thread Dario Binacchi
The arbitration register is already set up with 32-bit writes in the other parts of the code except for this point. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/

Re: [PATCH] netdevsim: init u64 stats for 32bit hardware

2021-03-02 Thread Jakub Kicinski
On Tue, 2 Mar 2021 12:55:47 +0100 Dmitry Vyukov wrote: > On Tue, Mar 2, 2021 at 10:06 AM Hillf Danton wrote: > > On Mar 2, 2021 at 16:40 Dmitry Vyukov wrote: > > >I hoped this would get at least into 5.12. syzbot can't start testing > > >arm32 because of this. FWIW the submission never got in

Re: [PATCH v3] net: usb: qmi_wwan: support ZTE P685M modem

2021-03-02 Thread Jakub Kicinski
On Mon, 1 Mar 2021 22:13:08 +0100 Lech Perczak wrote: > On 2021-02-24 at 19:10, patchwork-bot+netdev...@kernel.org wrote: > > Hello: > > > > This patch was applied to netdev/net.git (refs/heads/master): > > > > On Tue, 23 Feb 2021 19:34:56 +0100 you wrote: > >> Now that interface 3 in "option" dr

Re: [PATCH net 1/1] stmmac: intel: Fix mdio bus registration issue for TGL-H/ADL-S

2021-03-02 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Mar 2021 16:57:21 +0800 you wrote: > On Intel platforms which consist of two Ethernet Controllers such as > TGL-H and ADL-S, a unique MDIO bus id is required for MDIO bus to be > successful registered: > > [ 13.076

Re: KASAN: use-after-free Read in cipso_v4_genopt

2021-03-02 Thread Paul Moore
On Tue, Mar 2, 2021 at 2:15 PM Dmitry Vyukov wrote: ... > Not sure if it's the root cause or not, but I am looking at this > reference drop in cipso_v4_doi_remove: > https://elixir.bootlin.com/linux/v5.12-rc1/source/net/ipv4/cipso_ipv4.c#L522 > The thing is that it does not remove from the list

Re: [PATCH net v3] net: fix race between napi kthread mode and busy poll

2021-03-02 Thread Jakub Kicinski
On Mon, 1 Mar 2021 17:21:13 -0800 Wei Wang wrote: > Currently, napi_thread_wait() checks for NAPI_STATE_SCHED bit to > determine if the kthread owns this napi and could call napi->poll() on > it. However, if socket busy poll is enabled, it is possible that the > busy poll thread grabs this SCHED b

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-03-02 Thread Jakub Kicinski
On Tue, 02 Mar 2021 08:04:20 +0100 Martin Schiller wrote: > On 2021-03-01 09:56, Xie He wrote: > > On Sun, Feb 28, 2021 at 10:56 PM Martin Schiller wrote: > >> I mean the change from only one hdlc interface to both hdlc and > >> hdlc_x25. > >> > >> I can't estimate how many users are out there

Re: [PATCH net-next v3 1/8] ethtool: Add support for configuring frame preemption

2021-03-02 Thread Vinicius Costa Gomes
Hi Vladimir, Vladimir Oltean writes: > Hi Vinicius, > > On Fri, Jan 22, 2021 at 02:44:46PM -0800, Vinicius Costa Gomes wrote: >> Frame preemption (described in IEEE 802.3br-2016) defines the concept >> of preemptible and express queues. It allows traffic from express >> queues to "interrupt" tra

[PATCH bpf-next] tools/runqslower: allow substituting custom vmlinux.h for the build

2021-03-02 Thread Andrii Nakryiko
Just like was done for bpftool and selftests in ec23eb705620 ("tools/bpftool: Allow substituting custom vmlinux.h for the build") and ca4db6389d61 ("selftests/bpf: Allow substituting custom vmlinux.h for selftests build"), allow to provide pre-generated vmlinux.h for runqslower build. Cc: Martin L

<    1   2   3   >