Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

2021-02-25 Thread Marcus Folkesson
Hi, On Thu, Feb 25, 2021 at 09:09:30AM +0200, Kalle Valo wrote: > writes: > > > On 24/02/21 10:13 pm, Kalle Valo wrote: > >> EXTERNAL EMAIL: Do not click links or open attachments unless you > >> know the content is safe > >> > >> Marcus Folkesson writes: > >> > >>> Write the value instead of

[PATCH] perf/core: make perf_pmu_snapshot_aux static

2021-02-25 Thread Jiapeng Chong
Fix the following sparse warning: kernel/events/core.c:6539:6: warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static? Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kerne

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: > From: Florian Fainelli > > Hi Greg, Sasha, Jaakub and David, > > This patch series contains backports for a change that recently made it > upstream as: > > commit f3f9be9c58085d11f4448ec199bf49dc2f9b7fb9 > Merge: 18755e270666 f

Re: [PATCH stable-5.9.y] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Wed, Feb 24, 2021 at 05:09:54PM -0800, Florian Fainelli wrote: > Standalone ports should not have learning enabled since all the frames > are always copied to the CPU port. This is particularly important in > case an user-facing port intentionally spoofs the CPU port's MAC > address. With learni

Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 09:54:06AM +0900, Punit Agrawal wrote: > From: Corinna Vinschen > > commit 2643e6e90210e16c978919617170089b7c2164f7 upstream > > TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP > every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 > secs

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

2021-02-25 Thread Jakub Kicinski
On Wed, 24 Feb 2021 18:31:55 -0800 Wei Wang wrote: > On Wed, Feb 24, 2021 at 6:03 PM Jakub Kicinski wrote: > > > > On Thu, 25 Feb 2021 01:22:08 + Alexander Duyck wrote: > > > Yeah, that was the patch Wei had done earlier. Eric complained about the > > > extra set_bit atomic operation in the

[PATCH v2 net-next] virtio-net: support XDP_TX when not more queues

2021-02-25 Thread Xuan Zhuo
The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to allocate a separate queue for XDP_TX. This patch allows XDP_TX to run by reuse the existing SQ with __netif_tx_lock() hold when there a

[PATCH V5 net 1/5] net: stmmac: stop each tx channel independently

2021-02-25 Thread Joakim Zhang
If clear GMAC_CONFIG_TE bit, it would stop all tx channels, but users may only want to stop specific tx channel. Fixes: 48863ce5940f ("stmmac: add DMA support for GMAC 4.xx") Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 4 1 file changed, 4 deletions(-)

[PATCH V5 net 0/5] ethernet: fixes for stmmac driver

2021-02-25 Thread Joakim Zhang
Fixes for stmmac driver. --- ChangeLogs: V1->V2: * subject prefix: ethernet: stmmac: -> net: stmmac: * use dma_addr_t instead of unsigned int for physical address * use cpu_to_le32() V2->V3: * fix the build issue pointed out by kbuild bot. * add error handli

[PATCH V5 net 3/5] net: stmmac: fix dma physical address of descriptor when display ring

2021-02-25 Thread Joakim Zhang
Driver uses dma_alloc_coherent to allocate dma memory for descriptors, dma_alloc_coherent will return both the virtual address and physical address. AFAIK, virt_to_phys could not convert virtual address to physical address, for which memory is allocated by dma_alloc_coherent. dwmac4_display_ring()

[PATCH V5 net 5/5] net: stmmac: re-init rx buffers when mac resume back

2021-02-25 Thread Joakim Zhang
During suspend/resume stress test, we found descriptor write back by DMA could exhibit unusual behavior, e.g.: 003 [0xc4310030]: 0x0 0x40 0x0 0xb5010040 We can see that desc3 write back is 0xb5010040, it is still ownd by DMA, so application would not recycle this buffer. It will trigger fa

[PATCH V5 net 4/5] net: stmmac: fix wrongly set buffer2 valid when sph unsupport

2021-02-25 Thread Joakim Zhang
In current driver, buffer2 available only when hardware supports split header. Wrongly set buffer2 valid in stmmac_rx_refill when refill buffer address. You can see that desc3 is 0x8100 after initialization, but turn out to be 0x8300 after refill. Fixes: 67afd6d1cfdf ("net: stmmac: Add Spl

[PATCH V5 net 2/5] net: stmmac: fix watchdog timeout during suspend/resume stress test

2021-02-25 Thread Joakim Zhang
stmmac_xmit() call stmmac_tx_timer_arm() at the end to modify tx timer to do the transmission cleanup work. Imagine such a situation, stmmac enters suspend immediately after tx timer modified, it's expire callback stmmac_tx_clean() would not be invoked. This could affect BQL, since netdev_tx_sent_q

Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

2021-02-25 Thread Ajay.Kathat
On 24/02/21 10:13 pm, Kalle Valo wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Marcus Folkesson writes: > >> Write the value instead of reading it twice. >> >> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for functio

Re: [PATCH] qtnfmac: remove meaningless goto statement and labels

2021-02-25 Thread kernel test robot
Hi samirweng1979, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on wireless-drivers/master sparc-next/master v5.11 next-20210225] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v2] perf machine: Use true and false for bool variable

2021-02-25 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./tools/perf/util/machine.c:2000:9-10: WARNING: return of 0/1 in function 'symbol__match_regex' with return type bool. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- Changes in v2: - Simplified logic. tools/perf/util/machine.c | 4 +--- 1 fi

Re: [PATCH] qtnfmac: remove meaningless goto statement and labels

2021-02-25 Thread kernel test robot
Hi samirweng1979, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on wireless-drivers/master sparc-next/master v5.11 next-20210225] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [RFC PATCH 4/4] i40e: don't open i40iw client for kdump

2021-02-25 Thread Bhupesh SHARMA
Hello Coiby, On Mon, Feb 22, 2021 at 12:40 PM Coiby Xu wrote: > > i40iw consumes huge amounts of memory. For example, on a x86_64 machine, > i40iw consumed 1.5GB for Intel Corporation Ethernet Connection X722 for > for 1GbE while "craskernel=auto" only reserved 160M. With the module > parameter "

Re: [PATCH] kallsyms: make arch_get_kallsym static

2021-02-25 Thread kernel test robot
Hi Jiapeng, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.11 next-20210225] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as doc

Re: [PATCH] qtnfmac: remove meaningless goto statement and labels

2021-02-25 Thread Kalle Valo
kernel test robot writes: > Hi samirweng1979, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on wireless-drivers-next/master] > [also build test ERROR on wireless-drivers/master sparc-next/master v5.11 > next-20210225] > [If your patch

Re: [PATCH] qtnfmac: remove meaningless goto statement and labels

2021-02-25 Thread wengjianfeng
RROR on wireless-drivers/master sparc-next/master > > v5.11 next-20210225] [If your patch is applied to the wrong git > > tree, kindly drop us a note. And when submitting patch, we suggest > > to use '--base' as documented in > > https://git-scm.com/docs/git-format-pa

[PATCH net 0/6] Fixes for NXP ENETC driver

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean This contains an assorted set of fixes collected over the past week on the enetc driver. Some are related to VLAN processing, some to physical link settings, some are fixups of previous hardware workarounds. Vladimir Oltean (6): net: enetc: don't overwrite the RSS indirec

[PATCH net 1/6] net: enetc: don't overwrite the RSS indirection table when initializing

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean After the blamed patch, all RX traffic gets hashed to CPU 0 because the hashing indirection table set up in: enetc_pf_probe -> enetc_alloc_si_resources -> enetc_configure_si -> enetc_setup_default_rss_table is overwritten later in: enetc_pf_probe -> enetc_init_po

[PATCH net 2/6] net: enetc: initialize RFS/RSS memories for unused ports too

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean Michael reports that since linux-next-20210211, the AER messages for ECC errors have started reappearing, and this time they can be reliably reproduced with the first ping on one of his LS1028A boards. $ ping 1[ 33.258069] pcieport :00:1f.0: AER: Multiple Corrected er

[PATCH net 3/6] net: enetc: take the MDIO lock only once per NAPI poll cycle

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean The workaround for the ENETC MDIO erratum caused a performance degradation of 82 Kpps (seen with IP forwarding of two 1Gbps streams of 64B packets). This is due to excessive locking and unlocking in the fast path, which can be avoided. By taking the MDIO read-side lock only

[PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean The ENETC port 0 MAC supports in-band status signaling coming from a PHY when operating in RGMII mode, and this feature is enabled by default. It has been reported that RGMII is broken in fixed-link, and that is not surprising considering the fact that no PHY is attached to

[PATCH net 4/6] net: enetc: fix incorrect TPID when receiving 802.1ad tagged packets

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean When the enetc ports have rx-vlan-offload enabled, they report a TPID of ETH_P_8021Q regardless of what was actually in the packet. When rx-vlan-offload is disabled, packets have the proper TPID. Fix this inconsistency by finishing the TODO left in the code. Fixes: d4fd0404

[PATCH net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean Quoting from the blamed commit: In promiscuous mode, it is more intuitive that all traffic is received, including VLAN tagged traffic. It appears that it is necessary to set the flag in PSIPVMR for that to be the case, so VLAN promiscuous mode is also tempor

Re: [PATCH RFC net-next 3/3] mm: make zone->free_area[order] access faster

2021-02-25 Thread Mel Gorman
As a side-node, I didn't pick up the other patches as there is review feedback and I didn't have strong opinions either way. Patch 3 is curious though, it probably should be split out and sent separetly but still; On Wed, Feb 24, 2021 at 07:56:51PM +0100, Jesper Dangaard Brouer wrote: > Avoid mult

Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

2021-02-25 Thread Russell King - ARM Linux admin
On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote: > static void enetc_pl_mac_link_up(struct phylink_config *config, >struct phy_device *phy, unsigned int mode, >phy_interface_t interface, int speed, > @@ -945,6 +981,10

Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

2021-02-25 Thread Ajay.Kathat
On 25/02/21 12:39 pm, Kalle Valo wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > writes: > >> On 24/02/21 10:13 pm, Kalle Valo wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you >>> know the content is safe >>

RE: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-25 Thread Joakim Zhang
> -Original Message- > From: Andrew Lunn > Sent: 2021年2月25日 10:34 > To: Joakim Zhang > Cc: netdev > Subject: Re: [PATCH V1 net-next 0/3] net: stmmac: implement clocks > > > Hi Andrew, > > > > > I don't have experience with Ethernet switch, according to your > > points, you mean we can

Re: [PATCH v2] vio: make remove callback return void

2021-02-25 Thread Michael Ellerman
Uwe Kleine-König writes: > The driver core ignores the return value of struct bus_type::remove() > because there is only little that can be done. To simplify the quest to > make this function return void, let struct vio_driver::remove() return > void, too. All users already unconditionally return

[RFC V2 net-next 0/3] net: stmmac: implement clocks management

2021-02-25 Thread Joakim Zhang
This patch set tries to implement clocks management, and takes i.MX platform as an example. --- ChangeLogs: V1->V2: * change to pm runtime mechanism. * rename function: _enable() -> _config() * take MDIO bus into account, it needs clocks when interface is closed. J

[RFC V2 net-next 2/3] net: stmmac: add platform level clocks management

2021-02-25 Thread Joakim Zhang
This patch intends to add platform level clocks management. Some platforms may have their own special clocks, they also need to be managed dynamically. If you want to manage such clocks, please implement clks_config callback. Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/st

[RFC V2 net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-02-25 Thread Joakim Zhang
This patch intends to add clocks management for stmmac driver: If CONFIG_PM enabled: 1. Keep clocks disabled after driver probed. 2. Enable clocks when up the net device, and disable clocks when down the net device. If CONFIG_PM disabled: Keep clocks always enabled after driver probed. Note: 1.

[RFC V2 net-next 3/3] net: stmmac: add platform level clocks management for i.MX

2021-02-25 Thread Joakim Zhang
Split clocks settings from init callback into clks_config callback, which could support platform level clocks management. Signed-off-by: Joakim Zhang --- .../net/ethernet/stmicro/stmmac/dwmac-imx.c | 60 +++ 1 file changed, 36 insertions(+), 24 deletions(-) diff --git a/driver

RE: [PATCH v3] seccomp: Improve performace by optimizing rmb()

2021-02-25 Thread Wanghongzhe (Hongzhe, EulerOS)
> > On Feb 24, 2021, at 12:03 AM, wanghongzhe > wrote: > > > > As Kees haved accepted the v2 patch at a381b70a1 which just replaced > > rmb() with smp_rmb(), this patch will base on that and just adjust the > > smp_rmb() to the correct position. > > > > As the original comment shown (and indeed i

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-25 Thread Paul Durrant
On 25/02/2021 07:33, Jan Beulich wrote: On 24.02.2021 17:39, Paul Durrant wrote: On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR to the f

URGENT REPLY

2021-02-25 Thread martin collins
I am Mr. Martin Collins Bank manager still waiting for your reply to my many unanswered emails to you about the transfer

Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

2021-02-25 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 11:29:42AM +, Russell King - ARM Linux admin wrote: > On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote: > > static void enetc_pl_mac_link_up(struct phylink_config *config, > > struct phy_device *phy, unsigned int mode, > >

[PATCH v2 net 2/6] net: enetc: initialize RFS/RSS memories for unused ports too

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean Michael reports that since linux-next-20210211, the AER messages for ECC errors have started reappearing, and this time they can be reliably reproduced with the first ping on one of his LS1028A boards. $ ping 1[ 33.258069] pcieport :00:1f.0: AER: Multiple Corrected er

[PATCH v2 net 1/6] net: enetc: don't overwrite the RSS indirection table when initializing

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean After the blamed patch, all RX traffic gets hashed to CPU 0 because the hashing indirection table set up in: enetc_pf_probe -> enetc_alloc_si_resources -> enetc_configure_si -> enetc_setup_default_rss_table is overwritten later in: enetc_pf_probe -> enetc_init_po

[PATCH v2 net 3/6] net: enetc: take the MDIO lock only once per NAPI poll cycle

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean The workaround for the ENETC MDIO erratum caused a performance degradation of 82 Kpps (seen with IP forwarding of two 1Gbps streams of 64B packets). This is due to excessive locking and unlocking in the fast path, which can be avoided. By taking the MDIO read-side lock only

[PATCH v2 net 0/6] Fixes for NXP ENETC driver

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean This contains an assorted set of fixes collected over the past week on the enetc driver. Some are related to VLAN processing, some to physical link settings, some are fixups of previous hardware workarounds. Vladimir Oltean (6): net: enetc: don't overwrite the RSS indirec

[PATCH v2 net 4/6] net: enetc: fix incorrect TPID when receiving 802.1ad tagged packets

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean When the enetc ports have rx-vlan-offload enabled, they report a TPID of ETH_P_8021Q regardless of what was actually in the packet. When rx-vlan-offload is disabled, packets have the proper TPID. Fix this inconsistency by finishing the TODO left in the code. Fixes: d4fd0404

[PATCH v2 net 5/6] net: enetc: don't disable VLAN filtering in IFF_PROMISC mode

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean Quoting from the blamed commit: In promiscuous mode, it is more intuitive that all traffic is received, including VLAN tagged traffic. It appears that it is necessary to set the flag in PSIPVMR for that to be the case, so VLAN promiscuous mode is also tempor

[PATCH v2 net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

2021-02-25 Thread Vladimir Oltean
From: Vladimir Oltean The ENETC port 0 MAC supports in-band status signaling coming from a PHY when operating in RGMII mode, and this feature is enabled by default. It has been reported that RGMII is broken in fixed-link, and that is not surprising considering the fact that no PHY is attached to

[PATCH net v2] ethtool: fix the check logic of at least one channel for RX/TX

2021-02-25 Thread Simon Horman
From: Yinjun Zhang The command "ethtool -L combined 0" may clean the RX/TX channel count and skip the error path, since the attrs tb[ETHTOOL_A_CHANNELS_RX_COUNT] and tb[ETHTOOL_A_CHANNELS_TX_COUNT] are NULL in this case when recent ethtool is used. Tested using ethtool v5.10. Fixes: 7be92514b9

[PATCH] net/mlx5e: fix mlx5e_tc_tun_update_header_ipv6 dummy definition

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann The alternative implementation of this function in a header file is declared as a global symbol, and gets added to every .c file that includes it, which leads to a link error: arm-linux-gnueabi-ld: drivers/net/ethernet/mellanox/mlx5/core/en_rx.o: in function `mlx5e_tc_tun_up

Re: [PATCH V1 net-next 0/3] net: stmmac: implement clocks

2021-02-25 Thread Andrew Lunn
> Hi Andrew, > > Thanks for you explanation, I still don't quite understand what the use case > it is, could you give me more details, thanks a lot! > AFAIK now, there are two connections methods, we can abstract the layer: > MAC <-> MAC, there is no PHY attached. It seems to know as Fixed

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-25 Thread Cornelia Huck
On Thu, 25 Feb 2021 12:36:07 +0800 Jason Wang wrote: > On 2021/2/24 7:12 下午, Cornelia Huck wrote: > > On Wed, 24 Feb 2021 17:29:07 +0800 > > Jason Wang wrote: > > > >> On 2021/2/23 6:58 下午, Cornelia Huck wrote: > >>> On Tue, 23 Feb 2021 18:31:07 +0800 > >>> Jason Wang wrote: > The pro

Re: [RFC V2 net-next 1/3] net: stmmac: add clocks management for gmac driver

2021-02-25 Thread Andrew Lunn
> @@ -248,9 +296,15 @@ static int stmmac_mdio_write(struct mii_bus *bus, int > phyaddr, int phyreg, > unsigned int mii_address = priv->hw->mii.addr; > unsigned int mii_data = priv->hw->mii.data; > u32 value = MII_BUSY; > - int data = phydata; > + int ret, data = phydata;

Re: [RFC PATCH net-next 10/12] Documentation: networking: dsa: add paragraph for the HSR/PRP offload

2021-02-25 Thread George McCollister
On Wed, Feb 24, 2021 at 7:42 PM Andrew Lunn wrote: > > > +IEC 62439-3 (HSR/PRP) > > +- > > + > > +The Parallel Redundancy Protocol (PRP) is a network redundancy protocol > > which > > +works by duplicating and sequence numbering packets through two > > independent L2 > > +net

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-25 Thread Heiko Thiery
Hi Richard, Am Di., 23. Feb. 2021 um 17:11 Uhr schrieb Richard Cochran : > > On Tue, Feb 23, 2021 at 04:04:16PM +0100, Heiko Thiery wrote: > > It is not only the PHC clock that stops. Rather, it is the entire > > ethernet building block in the SOC that is disabled, including the > > PHC. > > Sure,

Re: [PATCH] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Andrew Lunn
On Wed, Feb 24, 2021 at 03:56:08PM +0100, Daniel González Cabanelas wrote: > The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > result of this it works in polling mode. > > Fix it using the phy_device structure to assign the platform IRQ. > > Tested under a BCM6348 board.

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Andrew Lunn
On Wed, Feb 24, 2021 at 04:44:18PM +0100, Daniel González Cabanelas wrote: > The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > result of this it works in polling mode. > > Fix it using the phy_device structure to assign the platform IRQ. > > Tested under a BCM6348 board.

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-25 Thread Jan Beulich
On 25.02.2021 13:11, Paul Durrant wrote: > On 25/02/2021 07:33, Jan Beulich wrote: >> On 24.02.2021 17:39, Paul Durrant wrote: >>> On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB

Re: [PATCH v2] vio: make remove callback return void

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 12:52 PM Michael Ellerman wrote: > > Uwe Kleine-König writes: > > The driver core ignores the return value of struct bus_type::remove() > > because there is only little that can be done. To simplify the quest to > > make this function return void, let struct vio_driver::re

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

2021-02-25 Thread Heiko Thiery
Hi Richard, Am Do., 25. Feb. 2021 um 14:49 Uhr schrieb Heiko Thiery : > > Hi Richard, > > Am Di., 23. Feb. 2021 um 17:11 Uhr schrieb Richard Cochran > : > > > > On Tue, Feb 23, 2021 at 04:04:16PM +0100, Heiko Thiery wrote: > > > It is not only the PHC clock that stops. Rather, it is the entire > >

Re: [RFC PATCH v5 02/19] af_vsock: separate wait data loop

2021-02-25 Thread Jorgen Hansen
> On 18 Feb 2021, at 06:36, Arseny Krasnov wrote: > > This moves wait loop for data to dedicated function, because later > it will be used by SEQPACKET data receive loop. > > Signed-off-by: Arseny Krasnov > --- > net/vmw_vsock/af_vsock.c | 155 +-- > 1 file

[PATCH] iwlwifi: fix link error without CONFIG_IWLMVM

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann A runtime check that was introduced recently failed to check for the matching Kconfig symbol: ld.lld: error: undefined symbol: iwl_so_trans_cfg >>> referenced by drv.c >>> net/wireless/intel/iwlwifi/pcie/drv.o:(iwl_pci_probe) Fixes: 930be4e76f26 ("iwlwifi: add

[PATCH 1/3] net: mscc: ocelot: select NET_DEVLINK

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann Without this option, the driver fails to link: ld.lld: error: undefined symbol: devlink_sb_register >>> referenced by ocelot_devlink.c >>> >>> net/ethernet/mscc/ocelot_devlink.o:(ocelot_devlink_sb_register) in archive >>> drivers/built-in.a >>> referenced by o

[PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann When the ocelot driver code is in a library, the dsa tag code cannot be built-in: ld.lld: error: undefined symbol: ocelot_can_inject >>> referenced by tag_ocelot_8021q.c >>> dsa/tag_ocelot_8021q.o:(ocelot_xmit) in archive net/built-in.a ld.lld: error: undefined

[PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann The new gpio support may be optional at runtime, but it requires building against gpiolib: ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] undefined! ERROR: modpost: "devm_gpiochip_add_data_with_key" [drivers/net/dsa/mt7530.ko] undefined! Add a Kconfig depen

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-25 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When the ocelot driver code is in a library, the dsa tag > code cannot be built-in: > > ld.lld: error: undefined symbol: ocelot_can_inject > >>> referenced by tag_ocelot_8021q.c > >>> dsa/tag_o

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 3:43 PM Vladimir Oltean wrote: > > On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When the ocelot driver code is in a library, the dsa tag > > code cannot be built-in: > > > > ld.lld: error: undefined symbol: ocelot_can_injec

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 3:47 PM Arnd Bergmann wrote: > On Thu, Feb 25, 2021 at 3:43 PM Vladimir Oltean wrote: > > On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > When the ocelot driver code is in a library, the dsa tag I see the problem now,

[PATCH] net: phy: make mdio_bus_phy_suspend/resume as __maybe_unused

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_PM_SLEEP is disabled, the compiler warns about unused functions: drivers/net/phy/phy_device.c:273:12: error: unused function 'mdio_bus_phy_suspend' [-Werror,-Wunused-function] static int mdio_bus_phy_suspend(struct device *dev) drivers/net/phy/phy_device.c:293:12

[PATCH 1/2] mt76: mt7915: fix unused 'mode' variable

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann clang points out a possible corner case in the mt7915_tm_set_tx_cont() function if called with invalid arguments: drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable 'mode' is used uninitialized whenever switch default is taken [-Wsometimes-uniniti

[PATCH 2/2] mt76: mt7921: remove incorrect error handling

2021-02-25 Thread Arnd Bergmann
From: Arnd Bergmann Clang points out a mistake in the error handling in mt7921_mcu_tx_rate_report(), which tries to dereference a pointer that cannot be initialized because of the error that is being handled: drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:409:3: warning: variable 'stats' is un

[PATCH net] r8169: fix jumbo packet handling on RTL8168e

2021-02-25 Thread Heiner Kallweit
Josef reported [0] that using jumbo packets fails on RTL8168e. Aligning the values for register MaxTxPacketSize with the vendor driver fixes the problem. [0] https://bugzilla.kernel.org/show_bug.cgi?id=211827 Fixes: d58d46b5d851 ("r8169: jumbo fixes.") Reported-by: Josef Oškera Tested-by: Josef

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-25 Thread Vladimir Oltean
On Thu, Feb 25, 2021 at 03:49:08PM +0100, Arnd Bergmann wrote: > On Thu, Feb 25, 2021 at 3:47 PM Arnd Bergmann wrote: > > On Thu, Feb 25, 2021 at 3:43 PM Vladimir Oltean wrote: > > > On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > When t

Re: [PATCH RFC net-next 3/3] mm: make zone->free_area[order] access faster

2021-02-25 Thread Jesper Dangaard Brouer
On Thu, 25 Feb 2021 11:28:49 + Mel Gorman wrote: > As a side-node, I didn't pick up the other patches as there is review > feedback and I didn't have strong opinions either way. Patch 3 is curious > though, it probably should be split out and sent separetly but still; > > On Wed, Feb 24, 202

Re: bug report: WARNING in bonding

2021-02-25 Thread Tariq Toukan
On 2/18/2021 7:10 PM, Tariq Toukan wrote: On 11/12/2020 6:33 PM, Ido Schimmel wrote: On Thu, Nov 12, 2020 at 05:54:30PM +0200, Tariq Toukan wrote: On 11/12/2020 5:46 PM, Ido Schimmel wrote: On Thu, Nov 12, 2020 at 05:38:44PM +0200, Tariq Toukan wrote: Hi all, In the past ~2-3 weeks, w

Re: [PATCH net-next v3 2/3] net: ethernet: rmnet: Support for downlink MAPv5 checksum offload

2021-02-25 Thread Alex Elder
On 2/24/21 12:23 PM, Jakub Kicinski wrote: On Wed, 24 Feb 2021 01:32:50 +0530 Sharath Chandra Vurukala wrote: +/* MAP CSUM headers */ +struct rmnet_map_v5_csum_header { +#if defined(__LITTLE_ENDIAN_BITFIELD) + u8 next_hdr:1; + u8 header_type:7; + u8 hw_reserved:7; + u8

Re: [PATCH RFC net-next 3/3] mm: make zone->free_area[order] access faster

2021-02-25 Thread Mel Gorman
On Thu, Feb 25, 2021 at 04:16:33PM +0100, Jesper Dangaard Brouer wrote: > > On Wed, Feb 24, 2021 at 07:56:51PM +0100, Jesper Dangaard Brouer wrote: > > > Avoid multiplication (imul) operations when accessing: > > > zone->free_area[order].nr_free > > > > > > This was really tricky to find. I was p

[PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating

2021-02-25 Thread Jan Beulich
shinfo already holds the result of skb_shinfo(skb) at this point - no need to re-invoke the construct even twice. Signed-off-by: Jan Beulich --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -557,8 +557,8 @@ check_frags: } if (skb_has_frag_list(

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 4:07 PM Vladimir Oltean wrote: > On Thu, Feb 25, 2021 at 03:49:08PM +0100, Arnd Bergmann wrote: > > On Thu, Feb 25, 2021 at 3:47 PM Arnd Bergmann wrote: > > > On Thu, Feb 25, 2021 at 3:43 PM Vladimir Oltean wrote: > > > > On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Ber

Re: [RFC net-next] net: dsa: mt7530: support MDB and bridge flag operations

2021-02-25 Thread DENG Qingfang
Hi Vladimir, On Wed, Feb 24, 2021 at 4:42 PM Vladimir Oltean wrote: > > I think the comment is incorrect and this _enables_ flooding (which btw > is ok until we get the address filtering thing sorted out). The initial value of these FFP fields is all 1's (0xFF). Writing the CPU port bit here wil

Re: [PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency

2021-02-25 Thread DENG Qingfang
Hi Arnd, On Thu, Feb 25, 2021 at 10:40 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The new gpio support may be optional at runtime, but it requires > building against gpiolib: > > ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] undefined! > ERROR: modpost: "devm_gpiochip_

Re: [PATCH 1/2] mt76: mt7915: fix unused 'mode' variable

2021-02-25 Thread Kalle Valo
Arnd Bergmann writes: > From: Arnd Bergmann > > clang points out a possible corner case in the mt7915_tm_set_tx_cont() > function if called with invalid arguments: > > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable > 'mode' is used uninitialized whenever switch de

Re: [PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency

2021-02-25 Thread Arnd Bergmann
On Thu, Feb 25, 2021 at 4:52 PM DENG Qingfang wrote: > > Hi Arnd, > > On Thu, Feb 25, 2021 at 10:40 PM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > The new gpio support may be optional at runtime, but it requires > > building against gpiolib: > > > > ERROR: modpost: "gpiochip_get_dat

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

2021-02-25 Thread Paul Durrant
On 25/02/2021 14:00, Jan Beulich wrote: On 25.02.2021 13:11, Paul Durrant wrote: On 25/02/2021 07:33, Jan Beulich wrote: On 24.02.2021 17:39, Paul Durrant wrote: On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerati

Re: [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

2021-02-25 Thread Jorgen Hansen
On 18 Feb 2021, at 06:37, Arseny Krasnov wrote: > > This adds receive loop for SEQPACKET. It looks like receive loop for > STREAM, but there is a little bit difference: > 1) It doesn't call notify callbacks. > 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because > there is n

RE: [External] Re: High (200+) XFRM interface count performance problem (throughput)

2021-02-25 Thread Vinš Karel
Hi Eyal, with kernel 5.10 it work very well. Tested with 10 000 interfaces. Thank you once more. Regards, Karel -Original Message- From: Vinš Karel Sent: Wednesday, February 24, 2021 12:02 PM To: 'Eyal Birger' Cc: netdev@vger.kernel.org Subject: [External] RE: [External] Re: High (200

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

2021-02-25 Thread Daniel González Cabanelas
El jue, 25 feb 2021 a las 8:22, Heiner Kallweit () escribió: > > On 25.02.2021 00:54, Daniel González Cabanelas wrote: > > El mié, 24 feb 2021 a las 23:01, Florian Fainelli > > () escribió: > >> > >> > >> > >> On 2/24/2021 1:44 PM, Heiner Kallweit wrote: > >>> On 24.02.2021 16:44, Daniel González C

general protection fault in ieee802154_llsec_parse_dev_addr

2021-02-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:fcb30073 Merge branch 'wireguard-fixes-for-5-12-rc1' git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=148f1646d0 kernel config: https://syzkaller.appspot.com/x/.config?x=2b8307379601586a dashboard link:

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Florian Fainelli
On 2/25/2021 12:15 AM, Greg KH wrote: > On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: >> From: Florian Fainelli >> >> Hi Greg, Sasha, Jaakub and David, >> >> This patch series contains backports for a change that recently made it >> upstream as: >> >> commit f3f9be9c58085d11

Re: [PATCH] kallsyms: make arch_get_kallsym static

2021-02-25 Thread Christoph Hellwig
On Thu, Feb 25, 2021 at 03:08:37PM +0800, Jiapeng Chong wrote: > Fix the following sparse warning: > > kernel/kallsyms.c:457:12: warning: symbol 'arch_get_kallsym' was not > declared. Should it be static? > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Please just remove the functi

[PATCH net 1/3] selftests: forwarding: Fix race condition in mirror installation

2021-02-25 Thread Ido Schimmel
From: Danielle Ratson When mirroring to a gretap in hardware the device expects to be programmed with the egress port and all the encapsulating headers. This requires the driver to resolve the path the packet will take in the software data path and program the device accordingly. If the path can

[PATCH net 0/3] mlxsw: Various fixes

2021-02-25 Thread Ido Schimmel
From: Ido Schimmel This patchset contains various fixes for mlxsw. Patch #1 fixes a race condition in a selftest. The race and fix are explained in detail in the changelog. Patch #2 re-adds a link mode that was wrongly removed, resulting in a regression in some setups. Patch #3 fixes a race co

WARNING in __alloc_skb

2021-02-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:291009f6 Merge tag 'pm-5.11-rc8' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1481fbacd0 kernel config: https://syzkaller.appspot.com/x/.config?x=1106b4b91e8dfab8 das

[PATCH net 3/3] mlxsw: spectrum_router: Ignore routes using a deleted nexthop object

2021-02-25 Thread Ido Schimmel
From: Ido Schimmel Routes are currently processed from a workqueue whereas nexthop objects are processed in system call context. This can result in the driver not finding a suitable nexthop group for a route and issuing a warning [1]. Fix this by ignoring such routes earlier in the process. The

[PATCH net 2/3] mlxsw: spectrum_ethtool: Add an external speed to PTYS register

2021-02-25 Thread Ido Schimmel
From: Danielle Ratson Currently, only external bits are added to the PTYS register, whereas there is one external bit that is wrongly marked as internal, and so was recently removed from the register. Add that bit to the PTYS register again, as this bit is no longer internal. Its removal result

Re: [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

2021-02-25 Thread Arseny Krasnov
On 25.02.2021 19:27, Jorgen Hansen wrote: > On 18 Feb 2021, at 06:37, Arseny Krasnov wrote: >> This adds receive loop for SEQPACKET. It looks like receive loop for >> STREAM, but there is a little bit difference: >> 1) It doesn't call notify callbacks. >> 2) It doesn't care about 'SO_SNDLOWAT' a

Re: [RFC PATCH v5 02/19] af_vsock: separate wait data loop

2021-02-25 Thread Arseny Krasnov
On 25.02.2021 17:24, Jorgen Hansen wrote: >> On 18 Feb 2021, at 06:36, Arseny Krasnov >> wrote: >> >> This moves wait loop for data to dedicated function, because later >> it will be used by SEQPACKET data receive loop. >> >> Signed-off-by: Arseny Krasnov >> --- >> net/vmw_vsock/af_vsock.c | 1

Re: [PATCH v2 net-next] virtio-net: support XDP_TX when not more queues

2021-02-25 Thread Jesper Dangaard Brouer
On Thu, 25 Feb 2021 16:22:29 +0800 Xuan Zhuo wrote: > The number of queues implemented by many virtio backends is limited, > especially some machines have a large number of CPUs. In this case, it > is often impossible to allocate a separate queue for XDP_TX. > > This patch allows XDP_TX to run b

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

2021-02-25 Thread Greg KH
On Thu, Feb 25, 2021 at 08:53:22AM -0800, Florian Fainelli wrote: > > > On 2/25/2021 12:15 AM, Greg KH wrote: > > On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: > >> From: Florian Fainelli > >> > >> Hi Greg, Sasha, Jaakub and David, > >> > >> This patch series contains backpor

Re: [PATCH v2 net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

2021-02-25 Thread Russell King - ARM Linux admin
On Thu, Feb 25, 2021 at 02:18:35PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > The ENETC port 0 MAC supports in-band status signaling coming from a PHY > when operating in RGMII mode, and this feature is enabled by default. > > It has been reported that RGMII is broken in fixed-lin

  1   2   >