On Fri, Feb 19, 2021 at 09:52:12AM +0200, Leon Romanovsky wrote:
> On Thu, Feb 18, 2021 at 04:39:50PM -0600, Bjorn Helgaas wrote:
> > On Thu, Feb 18, 2021 at 12:15:51PM +0200, Leon Romanovsky wrote:
> > > On Wed, Feb 17, 2021 at 12:02:39PM -0600, Bjorn Helgaas wrote:
> > > > [+cc Greg in case he wa
On Fri, 2021-02-19 at 05:15 +, Srinivasan Raju wrote:
> Hi,
>
> Please find a few responses to the comments , We will fix rest of the
> comments and submit v14 of the patch.
>
> > Also, you *really* need some validation here, rather than blindly
> > trusting that the file is well-formed, oth
On Thu, Feb 18, 2021 at 6:06 PM : George McCollister
wrote:
>
> On Thu, Feb 18, 2021 at 9:01 AM Marco Wenzel eberle.de> wrote:
> >
> > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When
> > a node does not send any frame within this time, the sequence number
> > check for ca
Hi all,
On Fri, 19 Feb 2021 07:52:56 +1100 Stephen Rothwell
wrote:
>
> After merging the net-next tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> Documentation/networking/filter.rst:1053: WARNING: Inline emphasis
> start-string without end-string.
> Documentation/netwo
On 2021/2/18 11:50 下午, Willem de Bruijn wrote:
On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote:
For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
set) based on the type in the virtio net hdr, but the skb could contain
anything since it could come from packet_snd th
U1/U2 shoued be enabled for USB 3.0 or later. The USB 2.0 doesn't
support it.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 2d7cc63bef89..4bfee289aa6f 100644
Some messages are before calling register_netdev(), so replace
netif_err() with dev_err().
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index baa63ea2590a..82a129264
These patches are used to adjust the code.
Hayes Wang (4):
r8152: enable U1/U2 for USB_SPEED_SUPER
r8152: check if the pointer of the function exists
r8152: replace netif_err with dev_err
r8152: spilt rtl_set_eee_plus and r8153b_green_en
drivers/net/usb/r8152.c | 67 +
Add rtl_eee_plus_en() and rtl_green_en().
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 43 ++---
1 file changed, 27 insertions(+), 16 deletions(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 82a129264e31..b246817f3405 10064
Return error code if autosuspend_en, eee_get, or eee_set don't exist.
Signed-off-by: Hayes Wang
---
drivers/net/usb/r8152.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 4bfee289aa6f..baa63ea2590a 100644
--- a/drivers/n
On Thu, Feb 18, 2021 at 06:38:07PM +, Shai Malin wrote:
> So, as there are no more comments / questions, we understand the direction
> is acceptable and will proceed to the full series.
I do not think we should support offloads at all, and certainly not onces
requiring extra drivers. Those d
Hello,
syzbot found the following issue on:
HEAD commit:c4762993 Merge branch 'skbuff-introduce-skbuff_heads-bulki..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=151e6df4d0
kernel config: https://syzkaller.appspot.com/x/.config?x=dbc1ca9e55dc1f9f
das
Move calling r8153_mac_clk_spd() from r8153_first_init() to rtl8153_up(),
and from r8153_enter_oob() to rtl8153_down().
r8153_mac_clk_spd() is used for RTL8153A. However, RTL8153B use
r8153_first_init() and r8153_enter_oob(), too. Therefore,
r8153_mac_clk_spd() needs to be moved.
Signed-off-by: H
Fix the following sparse warnings:
net/xfrm/xfrm_policy.c:1303:22: warning: incorrect type in assignment
(different address spaces)
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
net/xfrm/xfrm_policy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_policy
Network namespaces have a globally unique non-zero identifier aka a
cookie, in line with socket cookies. Add an ioctl to retrieve the
cookie from user space without going via BPF.
Signed-off-by: Lorenz Bauer
---
fs/nsfs.c | 8
include/uapi/linux/nsfs.h | 2 ++
2 files ch
We need to distinguish which network namespace a socket belongs to.
BPF has the useful bpf_get_netns_cookie helper for this, but accessing
it from user space isn't possible. Add a read-only socket option that
returns the netns cookie, similar to SO_COOKIE. If network namespaces
are disabled, SO_NET
Check that NS_GET_COOKIE returns a non-zero value, and that distinct
network namespaces have different cookies.
Signed-off-by: Lorenz Bauer
---
tools/testing/selftests/nsfs/.gitignore | 1 +
tools/testing/selftests/nsfs/Makefile | 2 +-
tools/testing/selftests/nsfs/config | 1 +
tools/t
We're working on a user space control plane for the BPF sk_lookup
hook [1]. The hook attaches to a network namespace and allows
control over which socket receives a new connection / packet.
Roughly, applications can give a socket to our user space component
to participate in custom bind semantics.
Make sure that SO_NETNS_COOKIE returns a non-zero value, and
that sockets from different namespaces have a distinct cookie
value.
Signed-off-by: Lorenz Bauer
---
tools/testing/selftests/net/.gitignore| 1 +
tools/testing/selftests/net/Makefile | 2 +-
tools/testing/selftests/n
The value of "sec" comes from the user. Negative values will lead to
shift wrapping inside the perout_conf_real_time() function and triggger
a UBSan warning.
Add a check and return -EINVAL to prevent that from happening.
Fixes: 432119de33d9 ("net/mlx5: Add cyc2time HW translation mode support")
This code does not allocate enough memory for the NUL terminator so it
ends up putting it one character beyond the end of the buffer.
Fixes: 8756828a8148 ("octeontx2-af: Add NPA aura and pool contexts to debugfs")
Signed-off-by: Dan Carpenter
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_deb
The comments to phy_select_page() say that "phy_restore_page() must
always be called after this, irrespective of success or failure of this
call." If we don't call phy_restore_page() then we are still holding
the phy_lock_mdio_bus() so it eventually leads to a dead lock.
Fixes: 32ab60e53920 ("net
> -Original Message-
> From: Camelia Alexandra Groza
> Sent: 18 February 2021 20:21
> To: k...@kernel.org; da...@davemloft.net; s.ha...@pengutronix.de
> Cc: bro...@redhat.com; Madalin Bucur (OSS) ;
> netdev@vger.kernel.org; Camelia Alexandra Groza
> Subject: [PATCH net] dpaa_eth: fix the
Am 2021-02-19 11:10, schrieb Dan Carpenter:
The comments to phy_select_page() say that "phy_restore_page() must
always be called after this, irrespective of success or failure of this
call." If we don't call phy_restore_page() then we are still holding
the phy_lock_mdio_bus() so it eventually le
On Fri, Feb 19, 2021 at 11:46:23AM +0100, Michael Walle wrote:
> Am 2021-02-19 11:10, schrieb Dan Carpenter:
> > The comments to phy_select_page() say that "phy_restore_page() must
> > always be called after this, irrespective of success or failure of this
> > call." If we don't call phy_restore_p
On Fri, Feb 19, 2021 at 01:10:44PM +0300, Dan Carpenter wrote:
> The comments to phy_select_page() say that "phy_restore_page() must
> always be called after this, irrespective of success or failure of this
> call." If we don't call phy_restore_page() then we are still holding
> the phy_lock_mdio_
On 2/19/21 10:51 AM, Lorenz Bauer wrote:
> We need to distinguish which network namespace a socket belongs to.
> BPF has the useful bpf_get_netns_cookie helper for this, but accessing
> it from user space isn't possible. Add a read-only socket option that
> returns the netns cookie, similar to S
Commit 452639a64ad8 ("vdpa: make sure set_features is invoked
for legacy") made an exception for legacy guests to reset
features to 0, when config space is accessed before features
are set. We should relieve the verify_min_features() check
and allow features reset to 0 for this case.
It's worth no
On Fri, 19 Feb 2021 at 11:49, Eric Dumazet wrote:
>
> > + case SO_NETNS_COOKIE:
> > + lv = sizeof(u64);
> > + if (len < lv)
> > + return -EINVAL;
>
> if (len != lv)
> return -EINVAL;
>
> (There is no reason to support bigger v
On Wed, Feb 17, 2021 at 5:36 PM Ciara Loftus wrote:
>
> Launching xdpxceiver with -D enables debug mode. Make it possible
Would be clearer if the option was the same both in the shell and in
the xdpreceiver app, so please pick -d or -D and stick with it. And
how about calling the mode "dump packe
On Fri, Feb 19, 2021 at 2:27 AM Wenzel, Marco wrote:
>
> On Thu, Feb 18, 2021 at 6:06 PM : George McCollister
> wrote:
> >
> > On Thu, Feb 18, 2021 at 9:01 AM Marco Wenzel > eberle.de> wrote:
> > >
> > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When
> > > a node does no
On Thu, 18 Feb 2021 20:21:06 +0200
Camelia Groza wrote:
> The current use of container_of is flawed and unnecessary. Obtain
> the dpaa_napi_portal reference from the private percpu data instead.
>
> Fixes: a1e031ffb422 ("dpaa_eth: add XDP_REDIRECT support")
> Reported-by: Sascha Hauer
> Signed-
Yang Li wrote:
> Fix the following sparse warnings:
> net/xfrm/xfrm_policy.c:1303:22: warning: incorrect type in assignment
> (different address spaces)
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
> ---
> net/xfrm/xfrm_policy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Fri, Feb 19, 2021 at 3:53 AM Jason Wang wrote:
>
>
> On 2021/2/18 11:50 下午, Willem de Bruijn wrote:
> > On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote:
> >> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't
> >> set) based on the type in the virtio net hdr, but the
Stephen Rothwell writes:
> Hi all,
>
> On Fri, 19 Feb 2021 07:52:56 +1100 Stephen Rothwell
> wrote:
>>
>> After merging the net-next tree, today's linux-next build (htmldocs)
>> produced these warnings:
>>
>> Documentation/networking/filter.rst:1053: WARNING: Inline emphasis
>> start-string w
Hi XDP-folks,
This two patch series contain two optimizations for the
bpf_redirect_map() helper and the xdp_do_redirect() function.
The bpf_redirect_map() optimization is about avoiding the map lookup
dispatching. Instead of having a switch-statement and selecting the
correct lookup function, we
From: Björn Töpel
Currently the bpf_redirect_map() implementation dispatches to the
correct map-lookup function via a switch-statement. To avoid the
dispatching, this change adds one bpf_redirect_map() implementation per
map. Correct function is automatically selected by the BPF verifier.
rfc->v
From: Björn Töpel
The XDP_REDIRECT implementations for maps and non-maps are fairly
similar, but obviously need to take different code paths depending on
if the target is using a map or not. Today, the redirect targets for
XDP either uses a map, or is based on ifindex.
Here, an explicit redirect
On Thu, Feb 18, 2021 at 9:25 PM Jason A. Donenfeld wrote:
>
> The icmp{,v6}_send functions make all sorts of use of skb->cb, casting
> it with IPCB or IP6CB, assuming the skb to have come directly from the
> inet layer. But when the packet comes from the ndo layer, especially
> when forwarded, the
On 2/19/21 1:23 PM, Lorenz Bauer wrote:
> On Fri, 19 Feb 2021 at 11:49, Eric Dumazet wrote:
>>
>>> + case SO_NETNS_COOKIE:
>>> + lv = sizeof(u64);
>>> + if (len < lv)
>>> + return -EINVAL;
>>
>> if (len != lv)
>> return -EI
The first four patches are fixes for XSA-332. The avoid WARN splats
and a performance issue with interdomain events.
Patches 5 and 6 are some additions to event handling in order to add
some per pv-device statistics to sysfs and the ability to have a per
backend device spurious event delay control
In case of a common event for rx and tx queue the event should be
regarded to be spurious if no rx and no tx requests are pending.
Unfortunately the condition for testing that is wrong causing to
decide a event being spurious if no rx OR no tx requests are
pending.
Fix that plus using local varia
In order to support the possibility of per-device event channel
settings (e.g. lateeoi spurious event thresholds) add a xenbus device
pointer to struct irq_info() and modify the related event channel
binding interfaces to take the pointer to the xenbus device as a
parameter instead of the domain id
We need to distinguish which network namespace a socket belongs to.
BPF has the useful bpf_get_netns_cookie helper for this, but accessing
it from user space isn't possible. Add a read-only socket option that
returns the netns cookie, similar to SO_COOKIE. If network namespaces
are disabled, SO_NET
Network namespaces have a globally unique non-zero identifier aka a
cookie, in line with socket cookies. Add an ioctl to retrieve the
cookie from user space without going via BPF.
Signed-off-by: Lorenz Bauer
---
fs/nsfs.c | 7 +++
include/uapi/linux/nsfs.h | 2 ++
2 files cha
We're working on a user space control plane for the BPF sk_lookup
hook [1]. The hook attaches to a network namespace and allows
control over which socket receives a new connection / packet.
I'm proposing to add a new getsockopt and a netns ioctl to retrieve
netns cookies, which allows identifying
Check that NS_GET_COOKIE returns a non-zero value, and that distinct
network namespaces have different cookies.
Signed-off-by: Lorenz Bauer
---
tools/testing/selftests/nsfs/.gitignore | 1 +
tools/testing/selftests/nsfs/Makefile | 2 +-
tools/testing/selftests/nsfs/config | 1 +
tools/t
Make sure that SO_NETNS_COOKIE returns a non-zero value, and
that sockets from different namespaces have a distinct cookie
value.
Signed-off-by: Lorenz Bauer
---
tools/testing/selftests/net/.gitignore| 1 +
tools/testing/selftests/net/Makefile | 2 +-
tools/testing/selftests/n
On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Feb 19, 2021 at 09:52:12AM +0200, Leon Romanovsky wrote:
> > On Thu, Feb 18, 2021 at 04:39:50PM -0600, Bjorn Helgaas wrote:
> > > On Thu, Feb 18, 2021 at 12:15:51PM +0200, Leon Romanovsky wrote:
> > > > On Wed, Feb 17, 20
Björn Töpel writes:
> From: Björn Töpel
>
> Currently the bpf_redirect_map() implementation dispatches to the
> correct map-lookup function via a switch-statement. To avoid the
> dispatching, this change adds one bpf_redirect_map() implementation per
> map. Correct function is automatically sele
Hi "Björn,
I love your patch! Perhaps something to improve:
[auto build test WARNING on 7b1e385c9a488de9291eaaa412146d3972e9dec5]
url:
https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210219-230349
Björn Töpel writes:
> From: Björn Töpel
>
> The XDP_REDIRECT implementations for maps and non-maps are fairly
> similar, but obviously need to take different code paths depending on
> if the target is using a map or not. Today, the redirect targets for
> XDP either uses a map, or is based on ifi
Frag needed should only be sent if the header enables DF.
This fix allows packets larger than MTU to pass the xfrm interface
and be fragmented after encapsulation, aligning behavior with
non-interface xfrm.
Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
Signed-off-by: Eyal Birger
---
On Thu, 18 Feb 2021 15:25:03 -0800 Tony Nguyen wrote:
> From: Mateusz Palczewski
>
> Fix insufficient distinction between IPv4 and IPv6 addresses
> when creating a filter.
> IPv4 and IPv6 are kept in the same memory area. If IPv6 is added,
> then it's caught by IPv4 check, which leads to err -95.
If the msk is closed before sending or receiving any data,
no DATA_FIN is generated, instead an MPC ack packet is
crafted out.
In the above scenario, the MPTCP protocol creates and sends a
pure ack and such packets matches also the criteria for an
MPC ack and the protocol tries first to insert MPC
This series bundle a few MPTCP fixes for the current net tree.
They have been detected via syzkaller and packetdrill
Patch 1 fixes a slow close for orphaned sockets
Patch 2 fixes another hangup at close time, when no
data was actually transmitted before close
Patch 3 fixes a memory leak with unu
From: Florian Westphal
mptcp re-used inet(6)_release, so the subflow sockets are ignored.
Need to invoke ip(v6)_mc_drop_socket function to ensure mcast join
resources get free'd.
Fixes: 717e79c867ca5 ("mptcp: Add setsockopt()/getsockopt() socket operations")
Closes: https://github.com/multipath-
MPJ subflows are not exposed as fds to user spaces. As such,
incoming MPJ subflows are removed from the accept queue by
tcp_check_req()/tcp_get_cookie_sock().
Later tcp_child_process() invokes subflow_data_ready() on the
parent socket regardless of the subflow kind, leading to poll
wakeups even if
Currently we move orphaned msk sockets directly from FIN_WAIT2
state to CLOSE, with the rationale that incoming additional
data could be just dropped by the TCP stack/TW sockets.
Anyhow we miss sending MPTCP-level ack on incoming DATA_FIN,
and that may hang the peers.
Fixes: e16163b6e2b7 ("mptcp:
On 2021-02-19 18:05, Toke Høiland-Jørgensen wrote:
Björn Töpel writes:
[...]
@@ -4110,22 +4094,17 @@ static const struct bpf_func_proto
bpf_xdp_redirect_proto = {
.arg2_type = ARG_ANYTHING,
};
-BPF_CALL_3(bpf_xdp_redirect_map, struct bpf_map *, map, u32, ifindex,
-
On 2021-02-19 18:10, Toke Høiland-Jørgensen wrote:
+ case XDP_REDIR_DEV_MAP: {
struct bpf_dtab_netdev *dst = fwd;
I thought the braces around the case body looked a bit odd. I guess
that's to get a local scope for the dst var (and xs var below), right?
This is basically a c
On Fri, 2021-02-19 at 09:31 -0800, Jakub Kicinski wrote:
> On Thu, 18 Feb 2021 15:25:03 -0800 Tony Nguyen wrote:
> > From: Mateusz Palczewski
> >
> > Fix insufficient distinction between IPv4 and IPv6 addresses
> > when creating a filter.
> > IPv4 and IPv6 are kept in the same memory area. If IPv
Hi "Björn,
I love your patch! Yet something to improve:
[auto build test ERROR on 7b1e385c9a488de9291eaaa412146d3972e9dec5]
url:
https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210219-230349
base: 7b1e385c9a488de9291eaaa412146d3972e
On Fri, 19 Feb 2021 17:38:03 +0800 Hayes Wang wrote:
> Move calling r8153_mac_clk_spd() from r8153_first_init() to rtl8153_up(),
> and from r8153_enter_oob() to rtl8153_down().
>
> r8153_mac_clk_spd() is used for RTL8153A. However, RTL8153B use
> r8153_first_init() and r8153_enter_oob(), too. Ther
On Tue, Feb 16, 2021 at 07:42 AM CET, Cong Wang wrote:
> From: Cong Wang
>
> As suggested by John, clean up sockmap related Kconfigs:
>
> Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream
> parser, to reflect its name.
>
> Make the rest sockmap code simply depend on CONFIG_BPF_SYSCAL
On Fri, 19 Feb 2021 12:56:32 +0300 Dan Carpenter wrote:
> This code does not allocate enough memory for the NUL terminator so it
> ends up putting it one character beyond the end of the buffer.
>
> Fixes: 8756828a8148 ("octeontx2-af: Add NPA aura and pool contexts to
> debugfs")
> Signed-off-by:
On Fri, Feb 19, 2021 at 3:31 PM Dan Carpenter wrote:
>
> This code does not allocate enough memory for the NUL terminator so it
> ends up putting it one character beyond the end of the buffer.
>
> Fixes: 8756828a8148 ("octeontx2-af: Add NPA aura and pool contexts to
> debugfs")
> Signed-off-by: D
On Thu, 18 Feb 2021 12:23:28 -0800 Xie He wrote:
> On Thu, Feb 18, 2021 at 12:06 PM Xie He wrote:
> >
> > On Thu, Feb 18, 2021 at 11:55 AM Leon Romanovsky wrote:
> > >
> > > This is how we write code, we use defines instead of constant numbers,
> > > comments to describe tricky parts and assign
On Fri, Feb 19, 2021 at 10:25 AM Jakub Sitnicki wrote:
>
> On Tue, Feb 16, 2021 at 07:42 AM CET, Cong Wang wrote:
> > From: Cong Wang
> >
> > As suggested by John, clean up sockmap related Kconfigs:
> >
> > Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream
> > parser, to reflect its
Before commit 5ee759cda51b ("l2tp: use standard API for warning log
messages"), it was possible for userspace applications to use their own
control protocols on the backing sockets of an L2TP kernel device, and as
long as a packet didn't look like a proper L2TP data packet, it would be
passed up to
Hi Matthias,
Thanks for your patch!
On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote:
> Before commit 5ee759cda51b ("l2tp: use standard API for warning log
> messages"), it was possible for userspace applications to use their own
> control protocols on the backing sockets of an L2
syzbot has bisected this issue to:
commit 40947e13997a1cba4e875893ca6e5d5e61a0689d
Author: Florian Westphal
Date: Fri Feb 12 23:59:56 2021 +
mptcp: schedule worker when subflow is closed
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1541a434d0
start commit: 773dc5
On Fri, Feb 19, 2021 at 10:39 AM Jakub Kicinski wrote:
>
> Not entirely sure what the argument is about but adding constants would
> certainly help.
Leon wants me to replace this:
dev->needed_headroom = 3 - 1;
with this:
/* 2 is the result of 3 - 1 */
dev->needed_headroom = 2;
But I don't fee
The feature is supported by the kernel since 5.11-net-next,
let's allow user-space to use it.
Just parse and dump an additional, per endpoint, u16 attribute
Signed-off-by: Paolo Abeni
---
ip/ipmptcp.c| 16 ++--
man/man8/ip-mptcp.8 | 8
2 files changed, 22 insertion
> On Thu, Feb 18, 2021 at 06:38:07PM +, Shai Malin wrote:
> > So, as there are no more comments / questions, we understand the
> > direction is acceptable and will proceed to the full series.
>
> I do not think we should support offloads at all, and certainly not onces
> requiring extra driver
This series contains updates to i40e driver only.
Slawomir resolves an issue with the IPv6 extension headers being
processed incorrectly.
Keita Suzuki fixes a memory leak on probe failure.
Mateusz initializes AQ command structures to zero to comply with
spec, fixes FW flow control settings being
From: Keita Suzuki
Struct i40e_veb is allocated in function i40e_setup_pf_switch, and
stored to an array field veb inside struct i40e_pf. However when
i40e_setup_misc_vector fails, this memory leaks.
Fix this by calling exit and teardown functions.
Signed-off-by: Keita Suzuki
Tested-by: Tony B
From: Norbert Ciosek
Fixes the following sparse warnings:
i40e_main.c:5953:32: warning: cast from restricted __le16
i40e_main.c:8008:29: warning: incorrect type in assignment (different base
types)
i40e_main.c:8008:29:expected unsigned int [assigned] [usertype] ipa
i40e_main.c:8008:29:go
From: Mateusz Palczewski
Fix insufficient distinction between IPv4 and IPv6 addresses
when creating a filter.
IPv4 and IPv6 are kept in the same memory area. If IPv6 is added,
then it's caught by IPv4 check, which leads to err -95.
Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower")
From: Mateusz Palczewski
Zero-initialize AQ command data structures to comply with
API specifications.
Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower")
Fixes: f4492db16df8 ("i40e: Add NPAR BW get and set functions")
Signed-off-by: Andrzej Sawuła
Signed-off-by: Mateusz Palczewski
From: Mateusz Palczewski
Fix addition of VLAN filter for PF after enabling FW LLDP agent.
Changing LLDP Agent causes FW to re-initialize per NVM settings.
Remove default PF filter and move "Enable/Disable" to currently used
reset flag.
Without this patch PF would try to add MAC VLAN filter with d
From: Sylwester Dziedziuch
When creating VFs they were sometimes not getting resources.
It was caused by not executing i40e_reset_all_vfs due to
flag __I40E_VF_DISABLE being set on PF. Because of this
IAVF was never able to finish setup sequence never
getting reset indication from PF.
Changed tes
From: Mateusz Palczewski
During driver loading flow control settings were written to FW
using a variable which was always zero, since it was being set
only by ethtool. This behavior has been corrected and driver
no longer overwrites the default FW/NVM settings.
Fixes: 373149fc99a0 ("i40e: Decrea
From: Slawomir Laba
When a packet contains an IPv6 header with next header which is
an extension header and not a protocol one, the kernel function
skb_transport_header called with such sk_buff will return a
pointer to the extension header and not to the TCP one.
The above explained call caused
On Fri, Feb 19, 2021 at 07:46 PM CET, Cong Wang wrote:
> On Fri, Feb 19, 2021 at 10:25 AM Jakub Sitnicki wrote:
>>
>> On Tue, Feb 16, 2021 at 07:42 AM CET, Cong Wang wrote:
>> > From: Cong Wang
>> >
>> > As suggested by John, clean up sockmap related Kconfigs:
>> >
>> > Reduce the scope of CONFIG
From: Cong Wang
Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly
does not work for any other non-TCP protocols. We can move them to
skb ext, but it introduces a memory allocation on fast path.
Fortunately, we only need to a word-size to store all the information,
because the flag
From: Cong Wang
It is only used within skmsg.c so can become static.
Cc: Jakub Sitnicki
Cc: Daniel Borkmann
Cc: Lorenz Bauer
Cc: John Fastabend
Signed-off-by: Cong Wang
---
include/linux/skmsg.h | 2 --
net/core/skmsg.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --g
From: Cong Wang
It is only used within sock_map.c so can become static.
Suggested-by: Jakub Sitnicki
Cc: Daniel Borkmann
Cc: Lorenz Bauer
Cc: John Fastabend
Signed-off-by: Cong Wang
---
include/linux/bpf.h | 9 -
net/core/sock_map.c | 7 +--
2 files changed, 5 insertions(+), 11
From: Cong Wang
This patchset is the first series of patches separated out from
the original large patchset, to make reviews easier. This patchset
does not add any new feature or change any functionality but merely
cleans up the existing sockmap and skmsg code and refactors it, to
prepare for the
From: Cong Wang
struct sk_psock_parser is embedded in sk_psock, it is
unnecessary as skb verdict also uses ->saved_data_ready.
We can simply fold these fields into sk_psock, and get rid
of ->enabled.
Cc: Daniel Borkmann
Cc: Lorenz Bauer
Acked-by: John Fastabend
Acked-by: Jakub Sitnicki
Signe
From: Cong Wang
It is now nearly identical to bpf_prog_run_pin_on_cpu() and
it has an unused parameter 'psock', so we can just get rid
of it and call bpf_prog_run_pin_on_cpu() directly.
Cc: Jakub Sitnicki
Cc: Daniel Borkmann
Cc: Lorenz Bauer
Cc: John Fastabend
Signed-off-by: Cong Wang
---
From: Cong Wang
Currently, we compute ->data_end with a compile-time constant
offset of skb. But as Jakub pointed out, we can actually compute
it in eBPF JIT code at run-time, so that we can competely get
rid of ->data_end. This is similar to skb_shinfo(skb) computation
in bpf_convert_shinfo_acce
From: Cong Wang
These two eBPF programs are tied to BPF_SK_SKB_STREAM_PARSER
and BPF_SK_SKB_STREAM_VERDICT, rename them to reflect the fact
they are only used for TCP. And save the name 'skb_verdict' for
general use later.
Cc: Daniel Borkmann
Cc: Jakub Sitnicki
Reviewed-by: Lorenz Bauer
Acked
From: Cong Wang
As suggested by John, clean up sockmap related Kconfigs:
Reduce the scope of CONFIG_BPF_STREAM_PARSER down to TCP stream
parser, to reflect its name.
Make the rest sockmap code simply depend on CONFIG_BPF_SYSCALL.
And leave CONFIG_NET_SOCK_MSG untouched, as it is used by
non-soc
From: Enke Chen
TCP keepalive does not timeout under the condition that network connection
is lost and data remain undelivered (incl. retransmit). A very simple
scenarios of the failure is to write data to a tcp socket after the network
connection is lost.
Under the specified condition the keepa
On 2/18/2021 7:10 PM, Jason Wang wrote:
On 2021/2/18 8:43 下午, Si-Wei Liu wrote:
On 2/17/2021 8:44 PM, Jason Wang wrote:
On 2021/2/10 下午4:59, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/8/2021 10:37 PM, Jason Wang wrote:
On 2021/2/20 10:05 上午, Si-Wei Liu wrote:
On 2/18/2021 7:10 PM, Jason Wang wrote:
On 2021/2/18 8:43 下午, Si-Wei Liu wrote:
On 2/17/2021 8:44 PM, Jason Wang wrote:
On 2021/2/10 下午4:59, Si-Wei Liu wrote:
On 2/9/2021 7:53 PM, Jason Wang wrote:
On 2021/2/10 上午10:30, Si-Wei Liu wrote:
On 2/17/2021 11:42 AM, Si-Wei Liu wrote:
On 2/16/2021 8:20 AM, Eli Cohen wrote:
When we suspend the VM, the VDPA interface will be reset. When the VM is
resumed again, clear_virtqueues() will clear the available and used
indices resulting in hardware virqtqueue objects becoming out of sync.
On 2/19/2021 6:38 PM, Jason Wang wrote:
Right now the value is exposed to userspace via GET_VRING_BASE, so
only last_avail_idx is synced. If we need sync last_used_idx, we
should also sync pending indices which requires more thoughts.
Technically it doesn't sound right - crossing the bound
Fix the following sparse warnings:
net/xfrm/xfrm_policy.c:1303:22: warning: incorrect type in assignment
(different address spaces)
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
net/xfrm/xfrm_policy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_poli
1 - 100 of 116 matches
Mail list logo
