Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override

2021-02-16 Thread Nathan Rossi
On Tue, 16 Feb 2021 at 01:58, Marek Behun wrote: > > On Mon, 15 Feb 2021 15:29:44 + > Russell King - ARM Linux admin wrote: > > > On Mon, Feb 15, 2021 at 04:16:27PM +0100, Marek Behun wrote: > > > On Mon, 15 Feb 2021 14:57:57 + > > > Russell King - ARM Linux admin wrote: > > > > > > > On

[PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c

2021-02-16 Thread Du Cheng
align * in block comments on each line changes v3: - add SUBSYSTEM in subject line - add explanation to past version of this patch changes v2: - move closing of comment to the same line changes v1: - align * in block comments Signed-off-by: Du Cheng --- drivers/staging/qlge/qlge_main.c | 3 +-

Re: [Patch bpf-next v3 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-16 Thread Lorenz Bauer
On Mon, 15 Feb 2021 at 19:20, John Fastabend wrote: > > Cong Wang wrote: > > From: Cong Wang > > > > Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly > > does not work for any other non-TCP protocols. We can move them to > > skb ext instead of playing with skb cb, which is harder

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-16 Thread Björn Töpel
On 2021-02-16 03:01, Maciej Fijalkowski wrote: On Mon, Feb 15, 2021 at 08:35:29PM +0100, Toke Høiland-Jørgensen wrote: Björn Töpel writes: [...] I'd say it's depending on the libbpf 1.0/libxdp merge timeframe. If we're months ahead, then I'd really like to see this in libbpf until the merg

Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c

2021-02-16 Thread Heiner Kallweit
On 16.02.2021 09:53, Du Cheng wrote: > align * in block comments on each line > > changes v3: > - add SUBSYSTEM in subject line > - add explanation to past version of this patch > > changes v2: > - move closing of comment to the same line > > changes v1: > - align * in block comments > > Signed

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-16 Thread Björn Töpel
On 2021-02-15 21:49, John Fastabend wrote: Maciej Fijalkowski wrote: Currently, if there are multiple xdpsock instances running on a single interface and in case one of the instances is terminated, the rest of them are left in an inoperable state due to the fact of unloaded XDP prog from interfa

Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c

2021-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote: > align * in block comments on each line > > changes v3: > - add SUBSYSTEM in subject line > - add explanation to past version of this patch > > changes v2: > - move closing of comment to the same line > > changes v1: > - align * in block

Re: [PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock

2021-02-16 Thread Björn Töpel
On 2021-02-15 21:24, John Fastabend wrote: Maciej Fijalkowski wrote: With the introduction of bpf_link in xsk's libbpf part, there's no further need for explicit unload of prog on xdpsock's termination. When process dies, the bpf_link's refcount will be decremented and resources will be unloaded

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-16 Thread Björn Töpel
On 2021-02-16 03:23, Maciej Fijalkowski wrote: On Mon, Feb 15, 2021 at 04:18:28PM -0800, John Fastabend wrote: [...] Once again, is libxdp going to land in th kernel? Still not clear to me. No, libxdp does not live in the kernel tree. Björn [...]

[PATCH net-next v2 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-16 Thread Maxime Chevallier
According to Errata #23 "The per-CPU GbE interrupt is limited to Core 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 familly. This is correctly checked for RSS configuration, but the initial queue mapping is still done by having the queues spread across all the CPUs in the sys

[PATCH net-next v2 0/2] net: mvneta: implement basic MQPrio support

2021-02-16 Thread Maxime Chevallier
Hi everyone, This is V2 for the MQPrio support in mvneta. This small series adds basic support for mqprio offloading, by having the rx queueing mirroring the TCs based on VLAN prio fields. This was tested on Armada 3700, and proves useful to make sure high-priority traffic has a better chance no

[PATCH net-next v2 2/2] net: mvneta: Implement mqprio support

2021-02-16 Thread Maxime Chevallier
Implement a basic MQPrio support, inserting rules in RX that translate the TC to prio mapping into vlan prio to queues. The TX logic stays the same as when we don't offload the qdisc. Signed-off-by: Maxime Chevallier --- V2 : Fixed the reverse xmas tree, as per Andrew's review. Fixed a comp

Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c

2021-02-16 Thread Dan Carpenter
On Tue, Feb 16, 2021 at 10:20:22AM +0100, Heiner Kallweit wrote: > On 16.02.2021 09:53, Du Cheng wrote: > > align * in block comments on each line > > > > changes v3: > > - add SUBSYSTEM in subject line > > - add explanation to past version of this patch > > > > changes v2: > > - move closing of

[PATCH v4] staging: qlge: fix comment style in qlge_main.c

2021-02-16 Thread Du Cheng
align * in block comments on each line This series of patches is for Task 10 of the Eudyptula Challenge Signed-off-by: Du Cheng --- changes v4: - move "changes" after triple-tiret changes v3: - add SUBSYSTEM in subject line - add explanation to past version of this patch changes v2: - move clo

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-16 Thread Calvin Johnson
On Mon, Feb 15, 2021 at 05:15:36PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 5:13 PM Andy Shevchenko > wrote: > > > > On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson > > wrote: > > > On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin > > > wrote: > > > > ... >

Re: [PATCH v4] staging: qlge: fix comment style in qlge_main.c

2021-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 05:40:12PM +0800, Du Cheng wrote: > align * in block comments on each line That says _what_ you did, not _why_ you did it. And "each line"? You only did this once. > This series of patches is for Task 10 of the Eudyptula Challenge This isn't a "series" of patches, it is

Re: linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-16 Thread Arnd Bergmann
On Tue, Feb 16, 2021 at 3:20 AM wrote: > > > > I fixed it up (see below) and can carry the fix as necessary. This > > is now fixed as far as linux-next is concerned, but any non trivial > > conflicts should be mentioned to your upstream maintainer when your tree > > is submitted for merging. You

[PATCH net] net: enetc: fix destroyed phylink dereference during unbind

2021-02-16 Thread Vladimir Oltean
From: Vladimir Oltean The following call path suggests that calling unregister_netdev on an interface that is up will first bring it down. enetc_pf_remove -> unregister_netdev -> unregister_netdevice_queue -> unregister_netdevice_many -> dev_close_many -> __dev_clos

[PATCH v5] staging: qlge: fix comment style in qlge_main.c

2021-02-16 Thread Du Cheng
fix the closing of a one-line block comment, marked incorrect by scripts/checkpatch.pl. Signed-off-by: Du Cheng --- changes v5: - improve description changes v4: - move "changes" after triple-tiret changes v3: - add SUBSYSTEM in subject line - add explanation to past version of this patch chan

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-16 Thread Kishon Vijay Abraham I
Hi, On 16/02/21 2:07 pm, Steen Hegelund wrote: > Hi Andrew and Kishon, > > On Mon, 2021-02-15 at 15:07 +0100, Andrew Lunn wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you >> know the content is safe >> >> On Mon, Feb 15, 2021 at 05:25:10PM +0530, Kishon Vijay Abraham I

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-16 Thread Toke Høiland-Jørgensen
Maciej Fijalkowski writes: > On Mon, Feb 15, 2021 at 08:35:29PM +0100, Toke Høiland-Jørgensen wrote: >> Björn Töpel writes: >> >> > On 2021-02-15 18:07, Toke Høiland-Jørgensen wrote: >> >> Maciej Fijalkowski writes: >> >> >> >>> Currently, if there are multiple xdpsock instances running on a

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-16 Thread Toke Høiland-Jørgensen
John Fastabend writes: > Toke Høiland-Jørgensen wrote: >> John Fastabend writes: >> >> >> > However, in libxdp we can solve the original problem in a different way, >> >> > and in fact I already suggested to Magnus that we should do this (see >> >> > [1]); so one way forward could be to address

Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link

2021-02-16 Thread Toke Høiland-Jørgensen
Björn Töpel writes: > On 2021-02-15 21:49, John Fastabend wrote: >> Maciej Fijalkowski wrote: >>> Currently, if there are multiple xdpsock instances running on a single >>> interface and in case one of the instances is terminated, the rest of >>> them are left in an inoperable state due to the fa

[PATCH bpf-next 0/8] PROG_TEST_RUN support for sk_lookup programs

2021-02-16 Thread Lorenz Bauer
We don't have PROG_TEST_RUN support for sk_lookup programs at the moment. So far this hasn't been a problem, since we can run our tests in a separate network namespace. For benchmarking it's nice to have PROG_TEST_RUN, so I've gone and implemented it. Multiple sk_lookup programs can be attached at

[PATCH bpf-next 1/8] bpf: consolidate shared test timing code

2021-02-16 Thread Lorenz Bauer
Share the timing / signal interruption logic between different implementations of PROG_TEST_RUN. There is a change in behaviour as well. We check the loop exit condition before checking for pending signals. This resolves an edge case where a signal arrives during the last iteration. Instead of abor

[PATCH bpf-next 2/8] bpf: add for_each_bpf_prog helper

2021-02-16 Thread Lorenz Bauer
Add a helper to iterate bpf_prog_arrays, which are a hybrid between and array and a linked list. Hide this behind a for each macro. Signed-off-by: Lorenz Bauer --- include/linux/bpf.h| 11 +-- include/linux/filter.h | 4 +--- 2 files changed, 6 insertions(+), 9 deletions(-) diff --

[PATCH bpf-next 3/8] bpf: allow multiple programs in BPF_PROG_TEST_RUN

2021-02-16 Thread Lorenz Bauer
The sk_lookup hook allows installing multiple BPF programs simultaneously and has defined semantics. We therefore need to be able to test multiple programs with one PROG_TEST_RUN call. Extend the UAPI to include a prog_fds array which enables this case. Passing an array with a single fd falls back

[PATCH bpf-next 4/8] bpf: add PROG_TEST_RUN support for sk_lookup programs

2021-02-16 Thread Lorenz Bauer
Allow to pass (multiple) sk_lookup programs to PROG_TEST_RUN. User space provides the full bpf_sk_lookup struct as context. Since the context includes a socket pointer that can't be exposed to user space we define that PROG_TEST_RUN returns the cookie of the selected socket or zero in place of the

[PATCH bpf-next 5/8] tools: libbpf: allow testing program types with multi-prog semantics

2021-02-16 Thread Lorenz Bauer
Add a wrapper bpf_prog_test_run_array that allows testing multiple programs for supported program types. Signed-off-by: Lorenz Bauer --- tools/lib/bpf/bpf.c | 16 +++- tools/lib/bpf/bpf.h | 3 +++ tools/lib/bpf/libbpf.map | 1 + 3 files changed, 19 insertions(+), 1 deleti

[PATCH bpf-next 8/8] selftests: bpf: check that PROG_TEST_RUN repeats as requested

2021-02-16 Thread Lorenz Bauer
Extend a simple prog_run test to check that PROG_TEST_RUN adheres to the requested repetitions. Convert it to use BPF skeleton. Signed-off-by: Lorenz Bauer --- .../selftests/bpf/prog_tests/prog_run_xattr.c | 51 +++ 1 file changed, 42 insertions(+), 9 deletions(-) diff --git a/t

[PATCH bpf-next 7/8] selftests: bpf: convert sk_lookup ctx access tests to PROG_TEST_RUN

2021-02-16 Thread Lorenz Bauer
Convert the selftests for sk_lookup narrow context access to use PROG_TEST_RUN instead of creating actual sockets. This ensures that ctx is populated correctly when using PROG_TEST_RUN. Assert concrete values since we now control remote_ip and remote_port. Signed-off-by: Lorenz Bauer --- .../se

[PATCH bpf-next 6/8] selftests: bpf: convert sk_lookup multi prog tests to PROG_TEST_RUN

2021-02-16 Thread Lorenz Bauer
Make the tests for multi program sk_lookup semantics use bpf_prog_run_array. This simplifies the test a bit and adds coverage to the new libbpf function. Signed-off-by: Lorenz Bauer --- .../selftests/bpf/prog_tests/sk_lookup.c | 100 -- 1 file changed, 65 insertions(+), 35 d

[PATCH net] net: dsa: felix: don't deinitialize unused ports

2021-02-16 Thread Vladimir Oltean
From: Vladimir Oltean ocelot_init_port is called only if dsa_is_unused_port == false, however ocelot_deinit_port is called unconditionally. This causes a warning in the skb_queue_purge inside ocelot_deinit_port saying that the spin lock protecting ocelot_port->tx_skbs was not initialized. Fixes:

Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA

2021-02-16 Thread Vignesh Raghavendra
Hi, On 2/12/21 8:10 PM, Vladimir Oltean wrote: > On Fri, Feb 12, 2021 at 08:01:33PM +0530, Vignesh Raghavendra wrote: >> Hi Vladimir, >> >> On 2/12/21 7:47 PM, Grygorii Strashko wrote: >>> >>> >>> On 12/02/2021 03:05, Vladimir Oltean wrote: From: Vladimir Oltean >> [...] >>> >>> Sorry, but w

[PATCH net-next] net: dsa: felix: perform teardown on error in felix_setup

2021-02-16 Thread Vladimir Oltean
From: Vladimir Oltean If the driver fails to probe, it would be nice to not leak memory. Signed-off-by: Vladimir Oltean --- I've decided to target this patch towards net-next because: - no user has complained about this being an issue - in theory there should be a Fixes: 56051948773e ("net: dsa

[PATCH v4 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
This series introduces XSK generic zerocopy xmit by adding XSK umem pages as skb frags instead of copying data to linear space. The only requirement for this for drivers is to be able to xmit skbs with skb_headlen(skb) == 0, i.e. all data including hard headers starts from frag 0. To indicate wheth

[PATCH v4 bpf-next 2/6] netdevice: check for net_device::priv_flags bitfield overflow

2021-02-16 Thread Alexander Lobakin
We almost ran out of unsigned int bitwidth. Define priv flags and check for potential overflow in the fashion of netdev_features_t. Defined this way, priv_flags can be easily expanded later with just changing its typedef. Signed-off-by: Alexander Lobakin --- include/linux/netdevice.h | 135 +

[PATCH v4 bpf-next 1/6] netdev_priv_flags: add missing IFF_PHONY_HEADROOM self-definition

2021-02-16 Thread Alexander Lobakin
This is harmless for now, but comes fatal for the subsequent patch. Fixes: 871b642adebe3 ("netdev: introduce ndo_set_rx_headroom") Signed-off-by: Alexander Lobakin --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevic

[PATCH v4 bpf-next 3/6] net: add priv_flags for allow tx skb without linear

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support this operation. For exampl

[PATCH v4 bpf-next 5/6] xsk: respect device's headroom and tailroom on generic xmit path

2021-02-16 Thread Alexander Lobakin
xsk_generic_xmit() allocates a new skb and then queues it for xmitting. The size of new skb's headroom is desc->len, so it comes to the driver/device with no reserved headroom and/or tailroom. Lots of drivers need some headroom (and sometimes tailroom) to prepend (and/or append) some headers or dat

[PATCH v4 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo This patch is used to construct skb based on page to save memory copy overhead. This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to directly construct skb. If this feature is not supported, it

[PATCH RESEND net-next 1/2] net: dsa: sja1105: fix configuration of source address learning

2021-02-16 Thread Vladimir Oltean
From: Vladimir Oltean Due to a mistake, the driver always sets the address learning flag to the previously stored value, and not to the currently configured one. The bug is visible only in standalone ports mode, because when the port is bridged, the issue is masked by .port_stp_state_set which ov

[PATCH v4 bpf-next 4/6] virtio-net: support IFF_TX_SKB_NO_LINEAR

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo Virtio net supports the case where the skb linear space is empty, so add priv_flags. Signed-off-by: Xuan Zhuo Acked-by: Michael S. Tsirkin Signed-off-by: Alexander Lobakin --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

[net-next v2] octeontx2-af: cn10k: Fixes CN10K RPM reference issue

2021-02-16 Thread Geetha sowjanya
This patch fixes references to uninitialized variables and debugfs entry name for CN10K platform and HW_TSO flag check. Fixes: 3ad3f8f93c81 ("octeontx2-af: cn10k: MAC internal loopback support"). Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham v1-v2 - Clear HW_TSO flag for 96xx B0 v

[PATCH RESEND net-next 0/2] Fix buggy brport flags offload for SJA1105 DSA

2021-02-16 Thread Vladimir Oltean
From: Vladimir Oltean I am resending this series because the title and the patches were mixed up and these patches were lost. This series' cover letter was used as the merge commit for the unrelated "Fixing build breakage after "Merge branch 'Propagate-extack-for-switchdev-LANs-from-DSA'"" series

[PATCH RESEND net-next 2/2] net: dsa: sja1105: fix leakage of flooded frames outside bridging domain

2021-02-16 Thread Vladimir Oltean
From: Vladimir Oltean Quite embarrasingly, I managed to fool myself into thinking that the flooding domain of sja1105 source ports is restricted by the forwarding domain, which it isn't. Frames which match an FDB entry are forwarded towards that entry's DESTPORTS restricted by REACH_PORT[SRC_PORT

RE: linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-16 Thread Yoshihiro Shimoda
708-rm-mbrc.dts > @@@ -42,11 -42,20 +42,29 @@@ > clock-names = "apb_pclk"; > }; > > +&wdt { > +status = "okay"; > +clocks = <&wdt_clk>; > +}; > + > +&gpio { > +status = "okay"; > ++};` T

Re: [net-next v2] octeontx2-af: cn10k: Fixes CN10K RPM reference issue

2021-02-16 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 05:09:36PM +0530, Geetha sowjanya wrote: > This patch fixes references to uninitialized variables and > debugfs entry name for CN10K platform and HW_TSO flag check. > > Fixes: 3ad3f8f93c81 ("octeontx2-af: cn10k: MAC internal loopback support"). > Signed-off-by: Geetha sowjan

Re: linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-16 Thread Naresh Kamboju
; > +clocks = <&wdt_clk>; > > +}; > > + > > +&gpio { > > +status = "okay"; > > ++};` > LKFT builders also found this problem while building arm64 dtb. > This ` causes the following build error on the next-20210216. >

Re: [PATCH v4 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller

2021-02-16 Thread Naresh Kamboju
th", "phy_ref_clk"; > + > + mdio0 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + phy0: ethernet-phy@1 { > + device_type = "

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-16 Thread Steen Hegelund
Hi Andrew and Kishon, On Mon, 2021-02-15 at 15:07 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On Mon, Feb 15, 2021 at 05:25:10PM +0530, Kishon Vijay Abraham I > wrote: > > Okay. Is it going to be some sort of manual

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-16 Thread Eli Cohen
On Tue, Feb 16, 2021 at 09:37:34AM +0200, Leon Romanovsky wrote: > On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote: > > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > > > On Tue, Feb 16, 2021 at 07:50:22AM +0200, Eli Cohen wrote: > > > > struct mlx5_vdpa_net pointer wa

Re: [PATCH] of: of_mdio: Handle properties for non-phy mdio devices

2021-02-16 Thread Andrew Lunn
On Mon, Feb 15, 2021 at 07:02:18AM +, Nathan Rossi wrote: > From: Nathan Rossi > > The documentation for MDIO bindings describes the "broken-turn-around", > "reset-assert-us", and "reset-deassert-us" properties such that any MDIO > device can define them. Other MDIO devices may require these

Re: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-02-16 Thread Andrew Lunn
On Mon, Feb 15, 2021 at 08:33:19PM +, Stefan Chulski wrote: > > > > > > I discussed it with Andrew earlier last year, and his response was: > > > > > > > > > > > > DT configuration of pause for fixed link probably is > > > > > > sufficient. I don't remember it ever been really discussed for >

Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data

2021-02-16 Thread Leon Romanovsky
On Tue, Feb 16, 2021 at 02:45:40PM +0200, Eli Cohen wrote: > On Tue, Feb 16, 2021 at 09:37:34AM +0200, Leon Romanovsky wrote: > > On Tue, Feb 16, 2021 at 08:42:26AM +0200, Eli Cohen wrote: > > > On Tue, Feb 16, 2021 at 08:35:51AM +0200, Leon Romanovsky wrote: > > > > On Tue, Feb 16, 2021 at 07:50:2

RE: linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-16 Thread nobuhiro1.iwamatsu
Hi, Thnaks for your report. > LKFT builders also found this problem while building arm64 dtb. > > > This ` causes the following build error on the next-20210216. > > > > DTC arch/arm64/boot/dts/toshiba/tmpv7708-rm-mbrc.dtb > > Error: arch/arm64/boot/dts/toshi

Re: [PATCH v4 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Magnus Karlsson
On Tue, Feb 16, 2021 at 12:44 PM Alexander Lobakin wrote: > > From: Xuan Zhuo > > This patch is used to construct skb based on page to save memory copy > overhead. > > This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the > network card priv_flags supports IFF_TX_SKB_NO_LINEAR will

Re: [PATCH v4 bpf-next 5/6] xsk: respect device's headroom and tailroom on generic xmit path

2021-02-16 Thread Magnus Karlsson
On Tue, Feb 16, 2021 at 12:44 PM Alexander Lobakin wrote: > > xsk_generic_xmit() allocates a new skb and then queues it for > xmitting. The size of new skb's headroom is desc->len, so it comes > to the driver/device with no reserved headroom and/or tailroom. > Lots of drivers need some headroom (a

Re: [PATCH rdma-next 0/2] Real time/free running timestamp support

2021-02-16 Thread Leon Romanovsky
On Sun, Feb 14, 2021 at 08:41:03AM +0200, Leon Romanovsky wrote: > On Fri, Feb 12, 2021 at 05:21:53PM -0400, Jason Gunthorpe wrote: > > On Fri, Feb 12, 2021 at 01:19:09PM -0800, Saeed Mahameed wrote: > > > On Fri, 2021-02-12 at 17:14 -0400, Jason Gunthorpe wrote: > > > > On Fri, Feb 12, 2021 at 01:

Re: [PATCH v4 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
From: Magnus Karlsson Date: Tue, 16 Feb 2021 15:08:26 +0100 > On Tue, Feb 16, 2021 at 12:44 PM Alexander Lobakin wrote: > > > > From: Xuan Zhuo > > > > This patch is used to construct skb based on page to save memory copy > > overhead. > > > > This function is implemented based on IFF_TX_SKB_NO

RE: linux-next: manual merge of the net-next tree with the arm-soc tree

2021-02-16 Thread nobuhiro1.iwamatsu
the net-next tree with the arm-soc > tree > > Hi, > > Thnaks for your report. > > > LKFT builders also found this problem while building arm64 dtb. > > > > > This ` causes the following build error on the next-20210216. > > > > > > DTC

Re: [PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock

2021-02-16 Thread Maciej Fijalkowski
On Tue, Feb 16, 2021 at 10:22:15AM +0100, Björn Töpel wrote: > On 2021-02-15 21:24, John Fastabend wrote: > > Maciej Fijalkowski wrote: > > > With the introduction of bpf_link in xsk's libbpf part, there's no > > > further need for explicit unload of prog on xdpsock's termination. When > > > proces

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2021-02-16 Thread Toke Høiland-Jørgensen
Marek Majtyka writes: > On Fri, Feb 12, 2021 at 3:05 AM Alexei Starovoitov > wrote: >> >> On Thu, Feb 11, 2021 at 5:26 PM Jakub Kicinski wrote: >> > >> > Perhaps I had seen one too many vendor incompatibility to trust that >> > adding a driver API without a validation suite will result in somet

[PATCH v5 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
This series introduces XSK generic zerocopy xmit by adding XSK umem pages as skb frags instead of copying data to linear space. The only requirement for this for drivers is to be able to xmit skbs with skb_headlen(skb) == 0, i.e. all data including hard headers starts from frag 0. To indicate wheth

[PATCH v5 bpf-next 2/6] netdevice: check for net_device::priv_flags bitfield overflow

2021-02-16 Thread Alexander Lobakin
We almost ran out of unsigned int bitwidth. Define priv flags and check for potential overflow in the fashion of netdev_features_t. Defined this way, priv_flags can be easily expanded later with just changing its typedef. Signed-off-by: Alexander Lobakin Reported-by: kernel test robot # Inverted

[PATCH v5 bpf-next 3/6] net: add priv_flags for allow tx skb without linear

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support this operation. For exampl

[PATCH v5 bpf-next 4/6] virtio-net: support IFF_TX_SKB_NO_LINEAR

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo Virtio net supports the case where the skb linear space is empty, so add priv_flags. Signed-off-by: Xuan Zhuo Acked-by: Michael S. Tsirkin Signed-off-by: Alexander Lobakin --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH v5 bpf-next 1/6] netdev_priv_flags: add missing IFF_PHONY_HEADROOM self-definition

2021-02-16 Thread Alexander Lobakin
This is harmless for now, but comes fatal for the subsequent patch. Fixes: 871b642adebe3 ("netdev: introduce ndo_set_rx_headroom") Signed-off-by: Alexander Lobakin --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevic

[PATCH v5 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo This patch is used to construct skb based on page to save memory copy overhead. This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to directly construct skb. If this feature is not supported, it

[PATCH v5 bpf-next 5/6] xsk: respect device's headroom and tailroom on generic xmit path

2021-02-16 Thread Alexander Lobakin
xsk_generic_xmit() allocates a new skb and then queues it for xmitting. The size of new skb's headroom is desc->len, so it comes to the driver/device with no reserved headroom and/or tailroom. Lots of drivers need some headroom (and sometimes tailroom) to prepend (and/or append) some headers or dat

Re: [PATCH net-next v2 1/7] mld: convert from timer to delayed work

2021-02-16 Thread Taehee Yoo
[...] >> By the way, I think the 'delay' is from the >> unsolicited_report_interval() and it just return value of >> idev->cnf.mldv{1 | 2}_unsolicited_report_interval. >> I think this value is msecs, not jiffies. >> So, It should be converted to use msecs_to_jiffies(), I think. >> How do you thi

Re: [PATCH net-next v2 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-16 Thread Bjarni.Jonasson
On Mon, 2021-02-15 at 18:25 +0100, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On 15.02.2021 17:57, Bjarni Jonasson wrote: > > At Power-On Reset, transients may cause the LCPLL to lock onto a > > clock that is momentaril

Re: [PATCH net-next v2 2/3] net: phy: mscc: improved serdes calibration applied to VSC8514

2021-02-16 Thread Bjarni.Jonasson
On Mon, 2021-02-15 at 18:27 +0100, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On 15.02.2021 17:57, Bjarni Jonasson wrote: > > The current IB serdes calibration algorithm (performed by the > > onboard 8051) > > has prove

Re: [PATCH net-next v2 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-16 Thread Bjarni.Jonasson
On Mon, 2021-02-15 at 18:25 +0100, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On 15.02.2021 17:57, Bjarni Jonasson wrote: > > At Power-On Reset, transients may cause the LCPLL to lock onto a > > clock that is momentaril

Re: [PATCH net-next v2 3/3] net: phy: mscc: coma mode disabled for VSC8514

2021-02-16 Thread Bjarni.Jonasson
On Mon, 2021-02-15 at 21:08 +0100, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > On 15.02.2021 17:58, Bjarni Jonasson wrote: > > The 'coma mode' (configurable through sw or hw) provides an > > optional feature that may be

Re: [PATCH v2 3/3] vdpa/mlx5: defer clear_virtqueues to until DRIVER_OK

2021-02-16 Thread Eli Cohen
On Thu, Feb 11, 2021 at 09:33:14AM +0200, Eli Cohen wrote: > On Wed, Feb 10, 2021 at 01:48:00PM -0800, Si-Wei Liu wrote: > > While virtq is stopped, get_vq_state() is supposed to > > be called to get sync'ed with the latest internal > > avail_index from device. The saved avail_index is used >

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-16 Thread Shuah Khan
On 2/16/21 12:53 AM, Felix Fietkau wrote: On 2021-02-16 08:03, Kalle Valo wrote: Shuah Khan wrote: ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() return pointer (sta) outside null check. Fix it by moving the code block under the null check. This problem was found while re

Re: [PATCH iproute2-rc] rdma: Fix statistics bind/unbing argument handling

2021-02-16 Thread David Ahern
On 2/15/21 11:16 PM, Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 06:56:26PM -0700, David Ahern wrote: >> On 2/14/21 10:40 PM, Leon Romanovsky wrote: >>> On Sun, Feb 14, 2021 at 08:26:16PM -0700, David Ahern wrote: what does iproute2-rc mean? >>> >>> Patch target is iproute2.git: >>> https

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-16 Thread Bjorn Helgaas
Proposed subject: PCI/IOV: Add dynamic MSI-X vector assignment sysfs interface On Tue, Feb 16, 2021 at 09:33:44AM +0200, Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 03:01:06PM -0600, Bjorn Helgaas wrote: > > On Tue, Feb 09, 2021 at 03:34:42PM +0200, Leon Romanovsky wrote: > > > From: Leon

Re: KASAN: null-ptr-deref Read in tcf_idrinfo_destroy

2021-02-16 Thread Vlad Buslov
On Tue 16 Feb 2021 at 01:22, Cong Wang wrote: > On Wed, Feb 10, 2021 at 9:53 PM syzbot > wrote: >> >> syzbot has found a reproducer for the following issue on: >> >> HEAD commit:291009f6 Merge tag 'pm-5.11-rc8' of git://git.kernel.org/p.. >> git tree: upstream >> console output: https:/

[PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-16 Thread Eli Cohen
When we suspend the VM, the VDPA interface will be reset. When the VM is resumed again, clear_virtqueues() will clear the available and used indices resulting in hardware virqtqueue objects becoming out of sync. We can avoid this function alltogether since qemu will clear them if required, e.g. whe

Re: [PATCH net-next 3/3] net: axienet: Support dynamic switching between 1000BaseX and SGMII

2021-02-16 Thread Robert Hancock
On Sat, 2021-02-13 at 17:43 +0100, Andrew Lunn wrote: > On Fri, Feb 12, 2021 at 06:23:56PM -0600, Robert Hancock wrote: > > Newer versions of the Xilinx AXI Ethernet core (specifically version 7.2 or > > later) allow the core to be configured with a PHY interface mode of "Both", > > Hi Robert > >

[PATCH 2/2] vdpa/mlx5: Enable user to add/delete vdpa device

2021-02-16 Thread Eli Cohen
Allow to control vdpa device creation and destruction using the vdpa management tool. Examples: 1. List the management devices $ vdpa mgmtdev show pci/:3b:00.1: supported_classes net 2. Create vdpa instance $ vdpa dev add mgmtdev pci/:3b:00.1 name vdpa0 3. Show vdpa devices $ vdpa dev

[PATCH net] net: sched: fix police ext initialization

2021-02-16 Thread Vlad Buslov
When police action is created by cls API tcf_exts_validate() first conditional that calls tcf_action_init_1() directly, the action idr is not updated according to latest changes in action API that require caller to commit newly created action to idr with tcf_idr_insert_many(). This results such act

[PATCH iproute2] ip: xfrm: add NUL character to security context name before printing

2021-02-16 Thread Sabrina Dubroca
Security context names are not guaranteed to be NUL-terminated by the kernel, so we can't just print them using %s directly. The length of the string is capped by the size of the netlink attribute (u16), so it will always fit within 65535 bytes. While at it, factor that out to a separate function,

Re: [PATCH net-next v2 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-16 Thread Robert Hancock
On Sat, 2021-02-13 at 10:45 +, Russell King - ARM Linux admin wrote: > On Fri, Feb 12, 2021 at 08:18:40PM -0600, Robert Hancock wrote: > > + if (!phydev->sfp_bus && > > + (!phydev->attached_dev || !phydev->attached_dev->sfp_bus)) { > > First, do we want this to be repeated in every dri

WARNING in slave_kobj_release

2021-02-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f40ddce8 Linux 5.11 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15e8b204d0 kernel config: https://syzkaller.appspot.com/x/.config?x=4b919ebed7b4902 dashboard link: https://syzkaller.appspot.com

INFO: task hung in disconnect_work

2021-02-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f40ddce8 Linux 5.11 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1644919cd0 kernel config: https://syzkaller.appspot.com/x/.config?x=51ab7ccac30c dashboard link: https://syzkaller.appspot.co

Re: [PATCH net-next v2 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-16 Thread Florian Fainelli
On 2/16/2021 9:04 AM, Russell King - ARM Linux admin wrote: > On Tue, Feb 16, 2021 at 04:52:13PM +, Robert Hancock wrote: >> On Sat, 2021-02-13 at 10:45 +, Russell King - ARM Linux admin wrote: >>> On Fri, Feb 12, 2021 at 08:18:40PM -0600, Robert Hancock wrote: + if (!phydev->sfp_b

Re: [PATCH net-next v2 2/2] net: phy: broadcom: Do not modify LED configuration for SFP module PHYs

2021-02-16 Thread Russell King - ARM Linux admin
On Tue, Feb 16, 2021 at 04:52:13PM +, Robert Hancock wrote: > On Sat, 2021-02-13 at 10:45 +, Russell King - ARM Linux admin wrote: > > On Fri, Feb 12, 2021 at 08:18:40PM -0600, Robert Hancock wrote: > > > + if (!phydev->sfp_bus && > > > + (!phydev->attached_dev || !phydev->attached_dev-

Re: [PATCH RESEND net-next 1/2] net: dsa: sja1105: fix configuration of source address learning

2021-02-16 Thread Florian Fainelli
On 2/16/2021 3:41 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Due to a mistake, the driver always sets the address learning flag to > the previously stored value, and not to the currently configured one. > The bug is visible only in standalone ports mode, because when the port > is

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-16 Thread Min Li
> > > > If I come up with a new file and move all the abstraction code there, > > does that work? > > I think so, but it's more important to figure out a good user space interface > first. The ioctl interfaces should be written on a higher-level abstraction, > to > ensure they can work with any h

Re: [PATCH v5 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
From: Alexander Lobakin Date: Tue, 16 Feb 2021 14:35:02 + > From: Xuan Zhuo > > This patch is used to construct skb based on page to save memory copy > overhead. > > This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the > network card priv_flags supports IFF_TX_SKB_NO_LINEAR

[PATCH v6 bpf-next 1/6] netdev_priv_flags: add missing IFF_PHONY_HEADROOM self-definition

2021-02-16 Thread Alexander Lobakin
This is harmless for now, but comes fatal for the subsequent patch. Fixes: 871b642adebe3 ("netdev: introduce ndo_set_rx_headroom") Signed-off-by: Alexander Lobakin --- include/linux/netdevice.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevic

[PATCH v6 bpf-next 2/6] netdevice: check for net_device::priv_flags bitfield overflow

2021-02-16 Thread Alexander Lobakin
We almost ran out of unsigned int bitwidth. Define priv flags and check for potential overflow in the fashion of netdev_features_t. Defined this way, priv_flags can be easily expanded later with just changing its typedef. Signed-off-by: Alexander Lobakin Reported-by: kernel test robot # Inverted

[PATCH v6 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
This series introduces XSK generic zerocopy xmit by adding XSK umem pages as skb frags instead of copying data to linear space. The only requirement for this for drivers is to be able to xmit skbs with skb_headlen(skb) == 0, i.e. all data including hard headers starts from frag 0. To indicate wheth

[PATCH v6 bpf-next 3/6] net: add priv_flags for allow tx skb without linear

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo In some cases, we hope to construct skb directly based on the existing memory without copying data. In this case, the page will be placed directly in the skb, and the linear space of skb is empty. But unfortunately, many the network card does not support this operation. For exampl

[PATCH v6 bpf-next 4/6] virtio-net: support IFF_TX_SKB_NO_LINEAR

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo Virtio net supports the case where the skb linear space is empty, so add priv_flags. Signed-off-by: Xuan Zhuo Acked-by: Michael S. Tsirkin Signed-off-by: Alexander Lobakin --- drivers/net/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH v6 bpf-next 5/6] xsk: respect device's headroom and tailroom on generic xmit path

2021-02-16 Thread Alexander Lobakin
xsk_generic_xmit() allocates a new skb and then queues it for xmitting. The size of new skb's headroom is desc->len, so it comes to the driver/device with no reserved headroom and/or tailroom. Lots of drivers need some headroom (and sometimes tailroom) to prepend (and/or append) some headers or dat

[PATCH v6 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-16 Thread Alexander Lobakin
From: Xuan Zhuo This patch is used to construct skb based on page to save memory copy overhead. This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to directly construct skb. If this feature is not supported, it

  1   2   3   >