Re: [RFC PATCH v4 00/17] virtio/vsock: introduce SOCK_SEQPACKET support

2021-02-12 Thread Stefano Garzarella
On Fri, Feb 12, 2021 at 09:11:50AM +0300, Arseny Krasnov wrote: On 11.02.2021 17:57, Stefano Garzarella wrote: Hi Arseny, On Mon, Feb 08, 2021 at 09:32:59AM +0300, Arseny Krasnov wrote: On 07.02.2021 19:20, Michael S. Tsirkin wrote: On Sun, Feb 07, 2021 at 06:12:56PM +0300, Arseny Krasnov wr

Proposal for a new protocol family - AF_MCTP

2021-02-12 Thread Jeremy Kerr
Hi all, I'm currently working on implementing support for the Management Controller Transport Protocol (MCTP). Briefly, MCTP is a protocol for intra-system communication between a management controller (typically a BMC), and the devices it manages. If you're after the full details, the DMTF have a

Re: [PATCH v4 net-next 6/9] net: dsa: act as ass passthrough for bridge port flags

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 03:05:28AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > There are multiple ways in which a PORT_BRIDGE_FLAGS attribute can be > expressed by the bridge through switchdev, and not all of them can be > emulated by DSA mid-layer API at the same time. Oops, odd t

Re: [PATCH 1/3] cfg80211: Add wiphy flag to trigger STA disconnect after hardware restart

2021-02-12 Thread Johannes Berg
On Tue, 2020-12-15 at 23:00 +0530, Youghandhar Chintala wrote: > > * @WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK: The device supports bigger kek and kck > keys > + * @WIPHY_FLAG_STA_DISCONNECT_ON_HW_RESTART: The device needs a trigger to > + * disconnect STA after target hardware restart. This flag shou

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-12 Thread Johannes Berg
On Fri, 2021-02-05 at 13:51 -0800, Abhishek Kumar wrote: > Since using DELBA frame to APs to re-establish BA session has a > dependency on APs and also some APs may not honour the DELBA frame. That's completely out of spec ... Can you say which AP this was? You could also try sending a BAR that

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-12 Thread Johannes Berg
On Tue, 2020-12-15 at 22:53 +0530, Youghandhar Chintala wrote: > The right fix would be to pull the entire data path into the host > +++ b/net/mac80211/ieee80211_i.h > @@ -748,6 +748,8 @@ struct ieee80211_if_mesh { > * back to wireless media and to the local net stack. > * @IEEE80211_SDATA_D

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-12 Thread Johannes Berg
On Fri, 2021-02-12 at 09:42 +0100, Johannes Berg wrote: > On Tue, 2020-12-15 at 22:53 +0530, Youghandhar Chintala wrote: > > The right fix would be to pull the entire data path into the host > > +++ b/net/mac80211/ieee80211_i.h > > @@ -748,6 +748,8 @@ struct ieee80211_if_mesh { > > * back to wire

RE: [EXT] Re: [PATCH v13 net-next 00/15] net: mvpp2: Add TX Flow Control support

2021-02-12 Thread Stefan Chulski
> -- > Hello: > > This series was applied to netdev/net-next.git (refs/heads/master): > > On Thu, 11 Feb 2021 12:48:47 +0200 you wrote: > > From: Stefan Chulski > > > > Armada hardware has a pause generation mechanism in GOP (MA

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Arnd Bergmann
On Fri, Feb 12, 2021 at 2:40 AM Min Li wrote: > > There should probably be a description of the purpose of the hardware both > > here and in the patch description. > > > > In particular, please explain how it relates to the existing clockmatrix > > driver. > > I just uploaded v2 patch to provide

Re: [PATCH v2 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller

2021-02-12 Thread Arnd Bergmann
On Fri, Feb 12, 2021 at 4:03 AM Nobuhiro Iwamatsu wrote: > @@ -384,6 +398,16 @@ spi6: spi@28146000 { > #size-cells = <0>; > status = "disabled"; > }; > + > + piether: ethernet@2800 { > + compati

Re: Potential invalid ~ operator in net/mac80211/cfg.c

2021-02-12 Thread Johannes Berg
On Fri, 2021-02-05 at 18:20 +, Colin Ian King wrote: > > > > https://lore.kernel.org/linux-wireless/516c0c7f.3000...@openwrt.org/ > > > > > > But maybe that isn't actually quite right due to integer promotion? > > > OTOH, that's a u8, so it should do the ~ in u8 space, and then compare > > >

[RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

2021-02-12 Thread Vadim Fedorenko
As udp_port_cfg struct changes its members with dependency on IPv6 configuration, the code in rxrpc should also check for IPv6. Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket") Reported-by: kernel test robot Signed-off-by: Vadim Fedorenko --- net/rxr

Re: [Patch bpf-next v2 3/5] bpf: compute data_end dynamically with JIT code

2021-02-12 Thread Lorenz Bauer
On Wed, 10 Feb 2021 at 02:22, Cong Wang wrote: > > From: Cong Wang > > Currently, we compute ->data_end with a compile-time constant > offset of skb. But as Jakub pointed out, we can actually compute > it in eBPF JIT code at run-time, so that we can competely get > rid of ->data_end. This is simi

Re: [Patch bpf-next v2 2/5] skmsg: get rid of struct sk_psock_parser

2021-02-12 Thread Lorenz Bauer
On Wed, 10 Feb 2021 at 02:21, Cong Wang wrote: > > From: Cong Wang > > struct sk_psock_parser is embedded in sk_psock, it is > unnecessary as skb verdict also uses ->saved_data_ready. > We can simply fold these fields into sk_psock, and get rid > of ->enabled. Looks nice, can you use sk_psock_st

Re: [Patch bpf-next v2 4/5] skmsg: use skb ext instead of TCP_SKB_CB

2021-02-12 Thread Lorenz Bauer
On Wed, 10 Feb 2021 at 02:22, Cong Wang wrote: > > From: Cong Wang > > Currently TCP_SKB_CB() is hard-coded in skmsg code, it certainly > does not work for any other non-TCP protocols. We can move them to > skb ext instead of playing with skb cb, which is harder to make > correct. Reviewed-by: L

Re: [Patch bpf-next v2 5/5] sock_map: rename skb_parser and skb_verdict

2021-02-12 Thread Lorenz Bauer
On Wed, 10 Feb 2021 at 02:22, Cong Wang wrote: > > From: Cong Wang > > These two eBPF programs are tied to BPF_SK_SKB_STREAM_PARSER > and BPF_SK_SKB_STREAM_VERDICT, rename them to reflect the fact > they are only used for TCP. And save the name 'skb_verdict' for > general use later. Reviewed-by:

pull-request: wireless-drivers-next-2021-02-12

2021-02-12 Thread Kalle Valo
Hi, here's a pull request to net-next tree, more info below. Please let me know if there are any problems. Kalle The following changes since commit badc6ac3212294bd37304c56ddf573c9ba3202e6: Merge branch '100GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue (2021-02-06 1

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-12 Thread Kishon Vijay Abraham I
Hi Steen, On 10/02/21 2:22 pm, Steen Hegelund wrote: > Provide new phy configuration interfaces for media type and speed that > allows allows e.g. PHYs used for ethernet to be configured with this > information. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-by: Andr

[PATCH][next] ath11k: debugfs: Fix spelling mistake "Opportunies" -> "Opportunities"

2021-02-12 Thread Colin King
From: Colin Ian King There is a spelling mistake in some debug text, fix this. Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/debugfs_htt_stats.c b/driver

[PATCH][next] octeontx2-af: Fix spelling mistake "recievd" -> "received"

2021-02-12 Thread Colin King
From: Colin Ian King There is a spelling mistake in the text in array rpm_rx_stats_fields, fix it. Signed-off-by: Colin Ian King --- drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx

Re: [PATCH] net/qrtr: restrict user-controlled length in qrtr_tun_write_iter()

2021-02-12 Thread Eric Dumazet
On 2/2/21 10:20 AM, Sabyrzhan Tasbolatov wrote: > syzbot found WARNING in qrtr_tun_write_iter [1] when write_iter length > exceeds KMALLOC_MAX_SIZE causing order >= MAX_ORDER condition. > > Additionally, there is no check for 0 length write. > > [1] > WARNING: mm/page_alloc.c:5011 > [..] > Cal

[PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices

2021-02-12 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in ARM

[PATCH][next] octeontx2-pf: Fix out-of-bounds read in otx2_get_fecparam()

2021-02-12 Thread Gustavo A. R. Silva
Code at line 967 implies that rsp->fwdata.supported_fec may be up to 4: 967: if (rsp->fwdata.supported_fec <= FEC_MAX_INDEX) If rsp->fwdata.supported_fec evaluates to 4, then there is an out-of-bounds read at line 971 because fec is an array with a maximum of 4 elements: 954 const int

Re: [PATCH v4 net-next 7/9] net: mscc: ocelot: use separate flooding PGID for broadcast

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 03:05:29AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > In preparation of offloading the bridge port flags which have > independent settings for unknown multicast and for broadcast, we should > also start reserving one destination Port Group ID for the floodin

[RFC PATCH net v2] net: introduce CAN specific pointer in the struct net_device

2021-02-12 Thread Oleksij Rempel
Since 20dd3850bcf8 ("can: Speed up CAN frame receiption by using ml_priv") the CAN framework uses per device specific data in the AF_CAN protocol. For this purpose the struct net_device->ml_priv is used. Later the ml_priv usage in CAN was extended for other users, one of them being CAN_J1939. Late

Re: [PATCH bpf-next 4/4] kbuild: Add resolve_btfids clean to root clean target

2021-02-12 Thread Jiri Olsa
On Fri, Feb 12, 2021 at 12:30:45PM +0900, Masahiro Yamada wrote: SNIP > > I expected this kind of mess > when I saw 33a57ce0a54d498275f432db04850001175dfdfa > > > The tools/ directory is a completely different world > governed by a different build system > (no, not a build system, but a collec

Re: [PATCH] [v13] wireless: Initial driver submission for pureLiFi STA devices

2021-02-12 Thread Johannes Berg
Hi, Thanks for your patience, and thanks for sticking around! I'm sorry I haven't reviewed this again in a long time, but I was able to today. > +PUREILIFI USB DRIVER Did you mistype "PURELIFI" here, or was that intentional? > +PUREILIFI USB DRIVER > +M: Srinivasan Raju Probably would be

Re: [RFC PATCH net v2] net: introduce CAN specific pointer in the struct net_device

2021-02-12 Thread Oliver Hartkopp
Hello Oleksij, nice cleanup - and I like the removal of the notifier in af_can.c :-) Two questions/hints from my side: On 12.02.21 13:52, Oleksij Rempel wrote: diff --git a/drivers/net/can/dev/dev.c b/drivers/net/can/dev/dev.c index d9281ae853f8..912401788d93 100644 --- a/drivers/net/can/dev/

[PATCH net-next V1] net: followup adjust net_device layout for cacheline usage

2021-02-12 Thread Jesper Dangaard Brouer
As Eric pointed out in response to commit 28af22c6c8df ("net: adjust net_device layout for cacheline usage") the netdev_features_t members wanted_features and hw_features are only used in control path. Thus, this patch reorder the netdev_features_t to let more members that are used in fast path in

Re: [EXT] Re: [PATCH v12 net-next 12/15] net: mvpp2: add BM protection underrun feature support

2021-02-12 Thread Andrew Lunn
> > Or we have also found out, that pushing back on parameters like this, > > the developers goes back and looks at the code, and sometimes figures > > out a way to automatically do the right thing, removing the > > configuration knob, and just making it all simpler for the user to > > use. > > I

pull-request: mac80211-next 2021-02-12

2021-02-12 Thread Johannes Berg
Hi, This is almost certainly a last update for net-next, and it's not very big - the biggest chunk here is minstrel improvements from Felix, to lower overhead. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 3c5a2fd042d0bfac71a2dfb995157

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread Alex Elder
On 2/11/21 8:04 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: +/* MAP CSUM headers */ +struct rmnet_map_v5_csum_header { + u8 next_hdr:1; + u8 header_type:7; + u8 hw_reserved:5; + u8 priority:1; + u8 hw_reserved_bi

Re: phy_attach_direct()'s use of device_bind_driver()

2021-02-12 Thread Andrew Lunn
> So the plan to fix this warning is, when device_bind_driver() is called: > 1. Delete all device links from the device (in this case, the PHY) to > suppliers that haven't probed yet because there's no probe function > that can defer at this point. Just because it currently does not happen, does n

Re: [PATCH v4 net-next 21/21] Documentation: add TCP DDP offload documentation

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 07:20, Boris Pismenny wrote: > Signed-off-by: Boris Pismenny > Signed-off-by: Ben Ben-Ishay > Signed-off-by: Or Gerlitz > Signed-off-by: Yoray Zack > --- > Documentation/networking/index.rst | 1 + > Documentation/networking/tcp-ddp-offload.rst | 296 +

Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 03:05, Vladimir Oltean wrote: From: Vladimir Oltean The initial goal of this series was to have better support for standalone ports mode on the DSA drivers like ocelot/felix and sja1105. This turned out to require some API adjustments in both directions: to the information pres

Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread Vignesh Raghavendra
Hi Vladimir, On 2/12/21 7:47 PM, Grygorii Strashko wrote: > > > On 12/02/2021 03:05, Vladimir Oltean wrote: >> From: Vladimir Oltean [...] > > Sorry, but we seems just added more work for you. > https://lore.kernel.org/patchwork/cover/1379380/ > Could you squash these when you post new versi

[PATCH v3 net-next 0/5] net: ipa: some more cleanup

2021-02-12 Thread Alex Elder
Version 3 of this series uses dev_err_probe() in the second patch, as suggested by Heiner Kallweit. Version 2 was sent to ensure the series was based on current net-next/master, and added copyright updates to files touched. The original introduction is below.

[PATCH v3 net-next 1/5] net: ipa: use a separate pointer for adjusted GSI memory

2021-02-12 Thread Alex Elder
This patch actually fixes a bug, though it doesn't affect the two platforms supported currently. The fix implements GSI memory pointers a bit differently. For IPA version 4.5 and above, the address space for almost all GSI registers is adjusted downward by a fixed amount. This is currently handl

[PATCH v3 net-next 2/5] net: ipa: use dev_err_probe() in ipa_clock.c

2021-02-12 Thread Alex Elder
When initializing the IPA core clock and interconnects, it's possible we'll get an EPROBE_DEFER error. This isn't really an error, it's just means we need to be re-probed later. Use dev_err_probe() to report the error rather than dev_err(). This avoids polluting the log with these "error" message

[PATCH v3 net-next 3/5] net: ipa: fix register write command validation

2021-02-12 Thread Alex Elder
In ipa_cmd_register_write_valid() we verify that values we will supply to a REGISTER_WRITE IPA immediate command will fit in the fields that need to hold them. This patch fixes some issues in that function and ipa_cmd_register_write_offset_valid(). The dev_err() call in ipa_cmd_register_write_off

[PATCH v3 net-next 4/5] net: ipa: introduce ipa_table_hash_support()

2021-02-12 Thread Alex Elder
Introduce a new function to abstract the knowledge of whether hashed routing and filter tables are supported for a given IPA instance. IPA v4.2 is the only one that doesn't support hashed tables (now and for the foreseeable future), but the name of the helper function is better for explaining what

[PATCH v3 net-next 5/5] net: ipa: introduce gsi_channel_initialized()

2021-02-12 Thread Alex Elder
Create a simple helper function that indicates whether a channel has been initialized. This abstacts/hides the details of how this is determined. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drive

Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 08:01:33PM +0530, Vignesh Raghavendra wrote: > Hi Vladimir, > > On 2/12/21 7:47 PM, Grygorii Strashko wrote: > > > > > > On 12/02/2021 03:05, Vladimir Oltean wrote: > >> From: Vladimir Oltean > [...] > > > > Sorry, but we seems just added more work for you. > > https://

[PATCH][next] octeontx2-pf: Fix out-of-bounds read in otx2_get_fecparam()

2021-02-12 Thread Hariprasad Kelam
Hi Gustavo , Please see inline, > -Original Message- > From: Gustavo A. R. Silva > Sent: Friday, February 12, 2021 5:53 PM > To: Sunil Kovvuri Goutham ; Geethasowjanya > Akula ; Subbaraya Sundeep Bhatta > ; Hariprasad Kelam ; David > S. Miller ; Jakub Kicinski ; Jesse > Brandeburg ; Chri

Re: [PATCH v2 4/4] arm: dts: visconti: Add DT support for Toshiba Visconti5 ethernet controller

2021-02-12 Thread Nobuhiro Iwamatsu
Hi, Thanks for your review. On Fri, Feb 12, 2021 at 10:32:09AM +0100, Arnd Bergmann wrote: > On Fri, Feb 12, 2021 at 4:03 AM Nobuhiro Iwamatsu > wrote: > > @@ -384,6 +398,16 @@ spi6: spi@28146000 { > > #size-cells = <0>; > > status = "disabled"; >

[PATCH v2][next] octeontx2-pf: Fix out-of-bounds read warning in otx2_get_fecparam()

2021-02-12 Thread Gustavo A. R. Silva
Line at 967 implies that rsp->fwdata.supported_fec may be up to 4: if (rsp->fwdata.supported_fec <= FEC_MAX_INDEX) which would cause an out-of-bounds read at line 971: fecparam->fec = fec[rsp->fwdata.supported_fec]; However, the range of values for rsp->fwdata.supported_fec is 0 to 3. Fix the i

[PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700

2021-02-12 Thread Maxime Chevallier
According to Errata #23 "The per-CPU GbE interrupt is limited to Core 0", we can't use the per-cpu interrupt mechanism on the Armada 3700 familly. This is correctly checked for RSS configuration, but the initial queue mapping is still done by having the queues spread across all the CPUs in the sys

[PATCH net-next 2/2] net: mvneta: Implement mqprio support

2021-02-12 Thread Maxime Chevallier
Implement a basic MQPrio support, inserting rules in RX that translate the TC to prio mapping into vlan prio to queues. The TX logic stays the same as when we don't offload the qdisc. Signed-off-by: Maxime Chevallier --- drivers/net/ethernet/marvell/mvneta.c | 65 +++ 1

[PATCH net] flow_dissector: fix TTL and TOS dissection on IPv4 fragments

2021-02-12 Thread Davide Caratti
the following command: # tc filter add dev $h2 ingress protocol ip pref 1 handle 101 flower \ $tcflags dst_ip 192.0.2.2 ip_ttl 63 action drop doesn't drop all IPv4 packets that match the configured TTL / destination address. In particular, if "fragment offset" or "more fragments" have non zer

[PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support

2021-02-12 Thread Maxime Chevallier
Hi everyone, This small series adds basic support for mqprio offloading, by having the rx queueing mirroring the TCs based on VLAN prio fields. This was tested on Armada 3700, and proves useful to make sure high-priority traffic has a better chance not getting dropped when there's lots of packets

[PATCH v5 net-next 00/10] Cleanup in brport flags switchdev offload for DSA

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The initial goal of this series was to have better support for standalone ports mode on the DSA drivers like ocelot/felix and sja1105. This turned out to require some API adjustments in both directions: to the information presented to and by the switchdev notifier, and to th

[PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean If for example this command: ip link set swp0 type bridge_slave flood off mcast_flood off learning off succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at BR_LEARNING, there would be no attempt to revert the partial state in any way. Arguably, if the user chang

[PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean When a struct switchdev_attr is notified through switchdev, there is no way to report informational messages, unlike for struct switchdev_obj. Signed-off-by: Vladimir Oltean Reviewed-by: Ido Schimmel Reviewed-by: Florian Fainelli --- Changes in v5: Rebased on top of AM65

[PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean For the netlink interface, propagate errors through extack rather than simply printing them to the console. For the sysfs interface, we still print to the console, but at least that's one layer higher than in switchdev, which also allows us to silently ignore the offloading

[PATCH v5 net-next 04/10] net: dsa: configure better brport flags when ports leave the bridge

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean For a DSA switch port operating in standalone mode, address learning doesn't make much sense since that is a bridge function. In fact, address learning even breaks setups such as this one: +-+ |

[PATCH v5 net-next 06/10] net: dsa: act as passthrough for bridge port flags

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean There are multiple ways in which a PORT_BRIDGE_FLAGS attribute can be expressed by the bridge through switchdev, and not all of them can be emulated by DSA mid-layer API at the same time. One possible configuration is when the bridge offloads the port flags using a mask tha

[PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean This switchdev attribute offers a counterproductive API for a driver writer, because although br_switchdev_set_port_flag gets passed a "flags" and a "mask", those are passed piecemeal to the driver, so while the PRE_BRIDGE_FLAGS listener knows what changed because it has the

[PATCH v5 net-next 08/10] net: mscc: ocelot: use separate flooding PGID for broadcast

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean In preparation of offloading the bridge port flags which have independent settings for unknown multicast and for broadcast, we should also start reserving one destination Port Group ID for the flooding of broadcast packets, to allow configuring it individually. Signed-off-b

[PATCH v5 net-next 07/10] net: dsa: felix: restore multicast flood to CPU when NPI tagger reinitializes

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean ocelot_init sets up PGID_MC to include the CPU port module, and that is fine, but the ocelot-8021q tagger removes the CPU port module from the unknown multicast replicator. So after a transition from the default ocelot tagger towards ocelot-8021q and then again towards ocelo

[PATCH v5 net-next 09/10] net: mscc: ocelot: offload bridge port flags to device

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean We should not be unconditionally enabling address learning, since doing that is actively detrimential when a port is standalone and not offloading a bridge. Namely, if a port in the switch is standalone and others are offloading the bridge, then we could enter a situation wh

[PATCH v5 net-next 10/10] net: dsa: sja1105: offload bridge port flags to device

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean The chip can configure unicast flooding, broadcast flooding and learning. Learning is per port, while flooding is per {ingress, egress} port pair and we need to configure the same value for all possible ingress ports towards the requested one. While multicast flooding is no

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-12 Thread Andrew Lunn
On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote: > +static u32 vsc85xx_csr_read(struct phy_device *phydev, > + enum csr_target target, u32 reg); > +static int vsc85xx_csr_write(struct phy_device *phydev, > + enum csr_target target, u3

[PATCH 5.12] net: broadcom: bcm4908_enet: set MTU on open & on request

2021-02-12 Thread Rafał Miłecki
From: Rafał Miłecki Hardware comes up with default max frame size set to 1518. When using it with switch it results in actual Ethernet MTU 1492: 1518 - 14 (Ethernet header) - 4 (Broadcom's tag) - 4 (802.1q) - 4 (FCS) Above means hardware in its default state can't handle standard Ethernet traffi

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-12 Thread Steen Hegelund
Hi David, On Wed, 2021-02-10 at 15:32 -0800, David Miller wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > From: Steen Hegelund > Date: Wed, 10 Feb 2021 09:52:53 +0100 > > > Provide new phy configuration interfaces for media type and spee

Re: [PATCH net-next 1/2] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.

2021-02-12 Thread Richard Cochran
On Thu, Feb 11, 2021 at 11:38:44PM -0500, vincent.cheng...@renesas.com wrote: > +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm) > +{ > + char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL state %d"; Probably you want: const char *fmt > diff --git a/drivers/ptp/ptp_cloc

Re: [PATCH net-next 2/2] ptp: ptp_clockmatrix: Add alignment of 1 PPS to idtcm_perout_enable.

2021-02-12 Thread Richard Cochran
On Thu, Feb 11, 2021 at 11:38:45PM -0500, vincent.cheng...@renesas.com wrote: > From: Vincent Cheng > > When enabling output using PTP_CLK_REQ_PEROUT, need to align the output > clock to the internal 1 PPS clock. > > Signed-off-by: Vincent Cheng Acked-by: Richard Cochran

Re: [PATCH net] net: phy: consider that suspend2ram may cut off PHY power

2021-02-12 Thread Claudiu.Beznea
On 11.02.2021 23:32, Heiner Kallweit wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Claudiu reported that on his system S2R cuts off power to the PHY and > after resuming certain PHY settings are lost. The PM folks confirmed > that cuttin

Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage

2021-02-12 Thread Jesper Dangaard Brouer
On Fri, 29 Jan 2021 15:00:58 +0100 Jesper Dangaard Brouer wrote: > On Fri, 29 Jan 2021 14:33:02 +0100 > Eric Dumazet wrote: > > > On 1/26/21 6:39 PM, Jesper Dangaard Brouer wrote: > > > The current layout of net_device is not optimal for cacheline usage. > > > [...] > > > @@ -1877,6 +1876,23

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-12 Thread Andrew Lunn
On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote: > At Power-On Reset, transients may cause the LCPLL to lock onto a > clock that is momentarily unstable. This is normally seen in QSGMII > setups where the higher speed 6G SerDes is being used. > This patch adds an initial LCPLL Reset

Re: [PATCH net-next V1] net: adjust net_device layout for cacheline usage

2021-02-12 Thread Jesper Dangaard Brouer
On Fri, 29 Jan 2021 12:07:23 -0800 Jakub Kicinski wrote: > On Fri, 29 Jan 2021 20:47:41 +0100 Eric Dumazet wrote: > > On 1/29/21 8:35 PM, Jakub Kicinski wrote: > > > > > kdoc didn't complain, and as you say it's already a mess, plus it's > > > two screen-fulls of scrolling away... > > > > >

Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 17:15, Vladimir Oltean wrote: > From: Vladimir Oltean > > If for example this command: > > ip link set swp0 type bridge_slave flood off mcast_flood off learning off > > succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at > BR_LEARNING, there would be no attempt to reve

Re: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 17:15, Vladimir Oltean wrote: > From: Vladimir Oltean > > For the netlink interface, propagate errors through extack rather than > simply printing them to the console. For the sysfs interface, we still > print to the console, but at least that's one layer higher than in > switchdev,

Re: [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 17:15, Vladimir Oltean wrote: > From: Vladimir Oltean > > When a struct switchdev_attr is notified through switchdev, there is no > way to report informational messages, unlike for struct switchdev_obj. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Ido Schimmel > Reviewed-by:

Re: [PATCH bpf-next] libbpf: use AF_LOCAL instead of AF_INET in xsk.c

2021-02-12 Thread sdf
On 02/12, Bj�rn T�pel wrote: On Tue, 9 Feb 2021 at 23:50, Stanislav Fomichev wrote: > > We have the environments where usage of AF_INET is prohibited > (cgroup/sock_create returns EPERM for AF_INET). Let's use > AF_LOCAL instead of AF_INET, it should perfectly work with SIOCETHTOOL. > > Signed-o

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-12 Thread Min Li
> > Ah, so if this is for a PTP related driver, it should probably be integrated > into > the PTP subsystem rather than being a separate class. > I was trying to add these functions to PHC subsystem but was not accepted because the functions are specific to Renesas device and there is no place

[PATCH net] ibmvnic: change IBMVNIC_MAX_IND_DESCS to 16

2021-02-12 Thread Dany Madden
The supported indirect subcrq entries on Power8 is 16. Power9 supports 128. Redefined this value to 16 to minimize the driver from having to reset when migrating between Power9 and Power8. In our rx/tx performance testing, we found no performance difference between 16 and 128 at this time. Fixes:

[PATCH v2][next] octeontx2-pf: Fix out-of-bounds read warning in otx2_get_fecparam()

2021-02-12 Thread Hariprasad Kelam
Looks good to me. Thanks, Hariprasad k > -Original Message- > From: Gustavo A. R. Silva > Sent: Friday, February 12, 2021 8:36 PM > To: Sunil Kovvuri Goutham ; Geethasowjanya > Akula ; Subbaraya Sundeep Bhatta > ; Hariprasad Kelam ; David > S. Miller ; Jakub Kicinski ; Jesse > Brandebu

Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote: > At Power-On Reset, transients may cause the LCPLL to lock onto a > clock that is momentarily unstable. This is normally seen in QSGMII > setups where the higher speed 6G SerDes is being used. > This patch adds an initial LCPLL Reset

Re: [PATCH net v1 2/3] net: phy: mscc: improved serdes calibration applied to VSC8514

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 03:06:42PM +0100, Bjarni Jonasson wrote: > The current IB serdes calibration algorithm (performed by the onboard 8051) > has proven to be unstable for the VSC8514 QSGMII phy. > A new algorithm has been developed based on > 'Frequency-offset Jittered-Injection' or 'FoJi' meth

Re: [PATCH net v1 3/3] net: phy: mscc: coma mode disabled for VSC8514

2021-02-12 Thread Vladimir Oltean
On Fri, Feb 12, 2021 at 03:06:43PM +0100, Bjarni Jonasson wrote: > The 'coma mode' (configurable through sw or hw) provides an > optional feature that may be used to control when the PHYs become active. > The typical usage is to synchronize the link-up time across > all PHY instances. This patch re

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-12 Thread Jiri Olsa
On Thu, Feb 11, 2021 at 11:59:02AM -0800, Andrii Nakryiko wrote: SNIP > > So in my previous example I assumed we have address ranges for ftrace > section, which is exactly the opposite from what we have. So this > binary search should be a bit different. start <= addr seems wrong > here as well.

Regressions with VMBus/VSCs hardening changes

2021-02-12 Thread Andrea Parri
Hi all, I'm reporting two regressions following certain VMBus/VSCs hardening changes we've been discussing 'recently', unfortunately the first regression already touched/affects mainline while the second one is in hyperv-next: 1) [mainline] The first regression manifests with the following messa

Re: [PATCH net-next V1] net: followup adjust net_device layout for cacheline usage

2021-02-12 Thread Eric Dumazet
On 2/12/21 2:50 PM, Jesper Dangaard Brouer wrote: > As Eric pointed out in response to commit 28af22c6c8df ("net: adjust > net_device layout for cacheline usage") the netdev_features_t members > wanted_features and hw_features are only used in control path. > > Thus, this patch reorder the netd

Re: [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 17:15, Vladimir Oltean wrote: From: Vladimir Oltean When a struct switchdev_attr is notified through switchdev, there is no way to report informational messages, unlike for struct switchdev_obj. Signed-off-by: Vladimir Oltean Reviewed-by: Ido Schimmel Reviewed-by: Florian Fa

Re: [PATCH v14 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-12 Thread Steen Hegelund
Hi Kishon, On Fri, 2021-02-12 at 17:02 +0530, Kishon Vijay Abraham I wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > Hi Steen, > > On 10/02/21 2:22 pm, Steen Hegelund wrote: > > Provide new phy configuration interfaces for media type and

Re: [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes

2021-02-12 Thread Grygorii Strashko
On 12/02/2021 17:15, Vladimir Oltean wrote: From: Vladimir Oltean This switchdev attribute offers a counterproductive API for a driver writer, because although br_switchdev_set_port_flag gets passed a "flags" and a "mask", those are passed piecemeal to the driver, so while the PRE_BRIDGE_FLA

Re: [PATCH] mt76: hold RCU lock when calling ieee80211_find_sta_by_ifaddr()

2021-02-12 Thread Shuah Khan
On 2/11/21 10:36 PM, Felix Fietkau wrote: On 2021-02-12 03:13, Shuah Khan wrote: ieee80211_find_sta_by_ifaddr() must be called under the RCU lock and the resulting pointer is only valid under RCU lock as well. Fix mt76_check_sta() to hold RCU read lock before it calls ieee80211_find_sta_by_ifa

Re: [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config

2021-02-12 Thread David Howells
Vadim Fedorenko wrote: > As udp_port_cfg struct changes its members with dependency on IPv6 > configuration, the code in rxrpc should also check for IPv6. > > Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in > rxrpc_open_socket") > Reported-by: kernel test robot > Signe

[PATCH net-next 0/2] Let phylink manage in-band AN for the PHY

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean This small series creates a configuration knob for PHY drivers which use serial MII-side interfaces and support clause 37 in-band auto-negotiation there. Vladimir Oltean (2): net: phylink: explicitly configure in-band autoneg for PHYs that support it net: phy: mscc:

[PATCH net-next 1/2] net: phylink: explicitly configure in-band autoneg for PHYs that support it

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean Currently Linux has no control over whether a MAC-to-PHY interface uses in-band signaling or not, even though phylink has the managed = "in-band-status"; property which denotes that the MAC expects in-band signaling to be used. The problem is really that if the in-b

[PATCH net-next 2/2] net: phy: mscc: configure in-band auto-negotiation for VSC8514

2021-02-12 Thread Vladimir Oltean
From: Vladimir Oltean Add the in-band configuration knob for the VSC8514 quad PHY. Tested with QSGMII in-band AN both on and off on NXP LS1028A-RDB and T1040-RDB. Signed-off-by: Vladimir Oltean --- drivers/net/phy/mscc/mscc.h | 2 ++ drivers/net/phy/mscc/mscc_main.c | 13 + 2

Re: [PATCH 2/3] net:ethernet:rmnet:Support for downlink MAPv5 csum offload

2021-02-12 Thread subashab
On 2021-02-12 07:01, Alex Elder wrote: On 2/11/21 8:04 PM, Jakub Kicinski wrote: On Fri, 12 Feb 2021 03:05:23 +0530 Sharath Chandra Vurukala wrote: +/* MAP CSUM headers */ +struct rmnet_map_v5_csum_header { + u8 next_hdr:1; + u8 header_type:7; + u8 hw_reserved:5; + u8

[PATCH][next] i40e: Fix incorrect argument in call to ipv6_addr_any()

2021-02-12 Thread Gustavo A. R. Silva
It seems that the right argument to be passed is &tcp_ip6_spec->ip6dst, not &tcp_ip6_spec->ip6src, when calling function ipv6_addr_any(). Addresses-Coverity-ID: 1501734 ("Copy-paste error") Fixes: efca91e89b67 ("i40e: Add flow director support for IPv6") Signed-off-by: Gustavo A. R. Silva --- dr

Re: [PATCH net-next 2/2] net: mvneta: Implement mqprio support

2021-02-12 Thread kernel test robot
Hi Maxime, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Maxime-Chevallier/net-mvneta-Implement-basic-MQPrio-support/20210212-231937 base: https://git.kernel.org/pub/scm/linux/kernel/git

[PATCH 4/4] amd-xgbe: Fix network fluctuations when using 1G BELFUSE SFP

2021-02-12 Thread Shyam Sundar S K
Frequent link up/down events can happen when a Bel Fuse SFP part is connected to the amd-xgbe device. Try to avoid the frequent link issues by resetting the PHY as documented in Bel Fuse SFP datasheets. Signed-off-by: Sudheesh Mavila Signed-off-by: Shyam Sundar S K --- drivers/net/ethernet/amd/

[PATCH 0/4] Bug fixes to amd-xgbe driver

2021-02-12 Thread Shyam Sundar S K
General fixes on amd-xgbe driver are addressed in this series, mostly on the mailbox communication failures and improving the link stability of the amd-xgbe device. Shyam Sundar S K (4): amd-xgbe: Reset the PHY rx data path when mailbox command timeout amd-xgbe: Fix NETDEV WATCHDOG transmit qu

[PATCH 2/4] amd-xgbe: Fix NETDEV WATCHDOG transmit queue timeout warning

2021-02-12 Thread Shyam Sundar S K
Current driver calls the netif_carrier_off() during the later point in time to tear down the link which causes the netdev watchdog to timeout. Calling netif_carrier_off() immediately after netif_tx_stop_all_queues() would avoids the warning. [ cut here ] NETDEV WATCHDOG:

[PATCH 1/4] amd-xgbe: Reset the PHY rx data path when mailbox command timeout

2021-02-12 Thread Shyam Sundar S K
Sometimes mailbox commands timeout when the RX data path becomes unresponsive. This prevents the submission of new mailbox commands to DXIO. This patch identifies the timeout and resets the RX data path so that the next message can be submitted properly. Signed-off-by: Sudheesh Mavila Signed-off-

[PATCH 3/4] amd-xgbe: Reset link when the link never comes back

2021-02-12 Thread Shyam Sundar S K
Normally, auto negotiation and reconnect should be automatically done by the hardware. But there seems to be an issue where auto negotiation has to be restarted manually. This happens because of link training and so even though still connected to the partner the link never "comes back". This would

Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Florian Fainelli
On 2/12/2021 7:15 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > If for example this command: > > ip link set swp0 type bridge_slave flood off mcast_flood off learning off > > succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at > BR_LEARNING, there would be no attempt to

  1   2   3   >