[RFC PATCH 6/7] tun: populate hash in virtio-net header when needed

2021-01-12 Thread Yuri Benditovich
If the BPF program populated the hash in the skb the tun propagates the hash value and hash report type to the respective fields of virtio-net header. Signed-off-by: Yuri Benditovich --- drivers/net/tun.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --gi

[RFC PATCH 7/7] tun: report new tun feature IFF_HASH

2021-01-12 Thread Yuri Benditovich
IFF_HASH feature indicates that the tun supports TUNSETHASHPOPULATION ioctl and can propagate the hash data to the virtio-net packet. Signed-off-by: Yuri Benditovich --- drivers/net/tun.c | 2 +- include/uapi/linux/if_tun.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff -

Re: [PATCH bpf 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

2021-01-12 Thread Andrii Nakryiko
On Tue, Jan 12, 2021 at 1:14 AM Gilad Reti wrote: > > Add support for pointer to mem register spilling, to allow the verifier > to track pointer to valid memory addresses. Such pointers are returned > for example by a successful call of the bpf_ringbuf_reserve helper. > > This patch was suggested

Re: [RFC PATCH 3/7] tun: allow use of BPF_PROG_TYPE_SCHED_CLS program type

2021-01-12 Thread Alexei Starovoitov
On Tue, Jan 12, 2021 at 11:42 AM Yuri Benditovich wrote: > > This program type can set skb hash value. It will be useful > when the tun will support hash reporting feature if virtio-net. > > Signed-off-by: Yuri Benditovich > --- > drivers/net/tun.c | 2 ++ > 1 file changed, 2 insertions(+) > > d

Re: [PATCH net-next v2 3/7] ibmvnic: avoid allocating rwi entries

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > Whenever we need to schedule a reset, we allocate an rwi (reset work > item?) entry and add to the list of pending resets. > > Since we only add one rwi for a given reason type to the list (no > duplicates). > we will only have a hand

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Yuri Benditovich
On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich wrote: > > Existing TUN module is able to use provided "steering eBPF" to > calculate per-packet hash and derive the destination queue to > place the packet to. The eBPF uses mapped configuration data > containing a key for hash calculation and indi

[PATCH net-next v15 1/6] dt-bindings: net: Add 5GBASER phy interface

2021-01-12 Thread Marek Behún
From: Pavana Sharma Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma Reviewed-by: Andrew Lunn Acked-by: Rob Herring Signed-off-by: Marek Behún --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/de

[PATCH net-next v15 0/6] Add support for mv88e6393x family of Marvell

2021-01-12 Thread Marek Behún
Hello, this is version 15 of patches adding support for Amethyst family to mv88e6xxx. It should apply cleanly on net-next. This series is tested on Marvell CN9130-CRB. Changes from v14: - added my Signed-off-by tags to Pavana's patches, since I am sending them (as suggested by Andrew) - added

[PATCH net-next v15 3/6] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

2021-01-12 Thread Marek Behún
From: Pavana Sharma Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma Reviewed-by: Andrew Lunn Reviewed-by: Vladimir

[PATCH net-next v15 2/6] net: phy: Add 5GBASER interface mode

2021-01-12 Thread Marek Behún
From: Pavana Sharma Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma Reviewed-by: Andrew Lunn Signed-off-by: Marek Behún --- Documentation/networking/phy.rst | 6 ++ include/linux/phy.h | 4 2 files changed, 10 insertions(+) diff --git a/Documentation/netwo

[PATCH net-next v15 4/6] net: dsa: mv88e6xxx: wrap .set_egress_port method

2021-01-12 Thread Marek Behún
There are two implementations of the .set_egress_port method, and both of them, if successful, set chip->*gress_dest_port variable. To avoid code repetition, wrap this method into mv88e6xxx_set_egress_port. Signed-off-by: Marek Behún Reviewed-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chi

[PATCH net-next v15 6/6] net: dsa: mv88e6xxx: implement .port_set_policy for Amethyst

2021-01-12 Thread Marek Behún
The 16-bit Port Policy CTL register from older chips is on 6393x changed to Port Policy MGMT CTL, which can access more data, but indirectly and via 8-bit registers. The original 16-bit value is divided into first two 8-bit register in the Port Policy MGMT CTL. We can therefore use the previous c

RE: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-12 Thread Praveen Chaudhary
Hi Jakub Thanks for the review, Sure, I will reraise the patch (again v0i, sonce no code changes) after adding space before '<'. This patch adds lines in 'include/uapi/', that requires ABI version changes for debian build. I am not sure, if we need any such changes to avoid breaking allmodcon

Re: [PATCH net-next v15 1/6] dt-bindings: net: Add 5GBASER phy interface

2021-01-12 Thread Florian Fainelli
On 1/12/21 11:54 AM, Marek Behún wrote: > From: Pavana Sharma > > Add 5gbase-r PHY interface mode. > > Signed-off-by: Pavana Sharma > Reviewed-by: Andrew Lunn > Acked-by: Rob Herring > Signed-off-by: Marek Behún Reviewed-by: Florian Fainelli -- Florian

[PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Marek Behún
From: Pavana Sharma The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X). T

Re: [PATCH net-next v15 2/6] net: phy: Add 5GBASER interface mode

2021-01-12 Thread Florian Fainelli
On 1/12/21 11:54 AM, Marek Behún wrote: > From: Pavana Sharma > > Add 5GBASE-R phy interface mode > > Signed-off-by: Pavana Sharma > Reviewed-by: Andrew Lunn > Signed-off-by: Marek Behún Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > The work queue is used to queue reset requests like CHANGE-PARAM or > FAILOVER resets for the worker thread. When the adapter is being > removed > the adapter state is set to VNIC_REMOVING and the work queue is > flushed > so no new wo

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Andrew Lunn
> +/* RollBall SFPs do not access internal PHY via I2C address 0x56, but > + * instead via address 0x51, when SFP page is set to 0x03 and password to > + * 0x. > + * Since current SFP code does not modify SFP_PAGE, we set it to 0x03 only at > + * bus creation time, and expect it to remain s

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Andrew Lunn
> > > +static int i2c_mii_read_rollball(struct mii_bus *bus, int phy_id, int > > > reg) > > > +{ > > > + u8 buf[4], res[6]; > > > + int bus_addr, ret; > > > + u16 val; > > > + > > > + if (!(reg & MII_ADDR_C45)) > > > + return -EOPNOTSUPP; > > > + > > > + bus_addr = i2c_mii_phy_addr(phy_id)

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > > Jarod Wilson wrote: > > > > >This comes from an end-user request, where they're running multiple VMs on > > >hosts with bonded interfaces connected to some interest sw

Re: [PATCH net-next] net: ipa: add config dependency on QCOM_SMEM

2021-01-12 Thread Randy Dunlap
On 1/12/21 11:21 AM, Alex Elder wrote: > The IPA driver depends on some SMEM functionality (qcom_smem_init(), > qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not > reflected in the configuration dependencies. Add a dependency on > QCOM_SMEM to avoid attempts to build the IPA driver

Re: [PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Vladimir Oltean
On Tue, Jan 12, 2021 at 10:16:32PM +0100, Marek Behún wrote: > On Tue, 12 Jan 2021 22:38:08 +0200 > Vladimir Oltean wrote: > > > > + phylink_set(mask, 1baseT_Full); > > > + phylink_set(mask, 1baseCR_Full); > > > + phylink_set(mask, 1baseSR_Full); > > > +

RE: [PATCH v2 0/3] hv_netvsc: Prevent packet loss during VF add/remove

2021-01-12 Thread Long Li
> Subject: Re: [PATCH v2 0/3] hv_netvsc: Prevent packet loss during VF > add/remove > > On Fri, 8 Jan 2021 16:53:40 -0800 Long Li wrote: > > From: Long Li > > > > This patch set fixes issues with packet loss on VF add/remove. > > These patches are for net-next? They just optimize the amount of

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Russell King - ARM Linux admin
On Tue, Jan 12, 2021 at 09:54:24PM +0100, Andrew Lunn wrote: > > +static int i2c_transfer_rollball(struct i2c_adapter *i2c, > > +struct i2c_msg *msgs, int num) > > +{ > > + u8 saved_page; > > + int ret; > > + > > + i2c_lock_bus(i2c, I2C_LOCK_SEGMENT); > > + > > +

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-12 Thread rohit maheshwari
On 07/01/21 12:47 AM, Jakub Kicinski wrote: On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. And it broke tls offload feature for the drivers, which are still using NETIF_F_IP_CSUM or NETIF_F_IPV6_CSUM. We should use N

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Marek Behún
On Tue, 12 Jan 2021 21:54:24 +0100 Andrew Lunn wrote: > > +static int i2c_transfer_rollball(struct i2c_adapter *i2c, > > +struct i2c_msg *msgs, int num) > > +{ > > + u8 saved_page; > > + int ret; > > + > > + i2c_lock_bus(i2c, I2C_LOCK_SEGMENT); > > + > > + /* s

[PATCH net-next] udp: allow forwarding of plain (non-fraglisted) UDP GRO packets

2021-01-12 Thread Alexander Lobakin
Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") actually not only added a support for fraglisted UDP GRO, but also tweaked some logics the way that non-fraglisted UDP GRO started to work for forwarding too. Tests showed that currently forwarding and NATing of plain UDP GRO packets are pe

Re: [PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Marek Behún
On Tue, 12 Jan 2021 22:38:08 +0200 Vladimir Oltean wrote: > > + phylink_set(mask, 1baseT_Full); > > + phylink_set(mask, 1baseCR_Full); > > + phylink_set(mask, 1baseSR_Full); > > + phylink_set(mask, 1baseLR_Full); > > + phylink_set(

Re: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-12 Thread Alexander Duyck
On Mon, Jan 11, 2021 at 6:54 PM Li,Rongqing wrote: > > > > > -Original Message- > > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > > Sent: Tuesday, January 12, 2021 4:54 AM > > To: Li,Rongqing > > Cc: Netdev ; intel-wired-lan > > ; Björn Töpel > > Subject: Re: [PATCH] igb: av

Re: [MPTCP] [PATCH net 2/2] mptcp: better msk-level shutdown.

2021-01-12 Thread Mat Martineau
On Tue, 12 Jan 2021, Paolo Abeni wrote: Instead of re-implementing most of inet_shutdown, re-use such helper, and implement the MPTCP-specific bits at the 'proto' level. The msk-level disconnect() can now be invoked, lets provide a suitable implementation. As a side effect, this fixes bad stat

Re: [MPTCP] [PATCH net 1/2] mptcp: more strict state checking for acks

2021-01-12 Thread Mat Martineau
On Tue, 12 Jan 2021, Paolo Abeni wrote: Syzkaller found a way to trigger division by zero in mptcp_subflow_cleanup_rbuf(). The current checks implemented into tcp_can_send_ack() are too week, let's be more accurate. Reported-by: Christoph Paasch Fixes: ea4ca586b16f ("mptcp: refine MPTCP-level

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jay Vosburgh
Jarod Wilson wrote: >On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: >> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: >> > Jarod Wilson wrote: >> > >> > >This comes from an end-user request, where they're running multiple VMs on >> > >hosts with bonded interfaces c

Re: [RFC PATCH 3/7] tun: allow use of BPF_PROG_TYPE_SCHED_CLS program type

2021-01-12 Thread Yuri Benditovich
On Tue, Jan 12, 2021 at 10:40 PM Yuri Benditovich wrote: > > On Tue, Jan 12, 2021 at 9:42 PM Yuri Benditovich > wrote: > > > > This program type can set skb hash value. It will be useful > > when the tun will support hash reporting feature if virtio-net. > > > > Signed-off-by: Yuri Benditovich >

Re: [RFC PATCH 3/7] tun: allow use of BPF_PROG_TYPE_SCHED_CLS program type

2021-01-12 Thread Yuri Benditovich
On Tue, Jan 12, 2021 at 9:42 PM Yuri Benditovich wrote: > > This program type can set skb hash value. It will be useful > when the tun will support hash reporting feature if virtio-net. > > Signed-off-by: Yuri Benditovich > --- > drivers/net/tun.c | 2 ++ > 1 file changed, 2 insertions(+) > > di

Re: mlx5 error when the skb linear space is empty

2021-01-12 Thread Saeed Mahameed
On Mon, 2021-01-11 at 09:02 +0100, Magnus Karlsson wrote: > On Tue, Jan 5, 2021 at 9:51 PM Saeed Mahameed > wrote: > > On Mon, 2021-01-04 at 18:59 +0800, Xuan Zhuo wrote: > > > hi > > > > > > In the process of developing xdp socket, we tried to directly use > > > page to > > > construct skb direc

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Marek Behún
On Tue, 12 Jan 2021 21:43:29 +0100 Andrew Lunn wrote: > > +/* RollBall SFPs do not access internal PHY via I2C address 0x56, but > > + * instead via address 0x51, when SFP page is set to 0x03 and password to > > + * 0x. > > + * Since current SFP code does not modify SFP_PAGE, we set it to

Re: [PATCH net-next 4/4] tcp: remove limit on initial receive window

2021-01-12 Thread Heath Caldwell
On 2021-01-12 21:26 (+0100), Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 8:25 PM Heath Caldwell wrote: > > > > On 2021-01-12 18:05 (+0100), Eric Dumazet wrote: > > > On Tue, Jan 12, 2021 at 5:02 PM Heath Caldwell > > > wrote: > > > > > > > > On 2021-01-12 09:30 (+0100), Eric Dumazet wrote:

Re: [PATCH v3 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-12 Thread Andrii Nakryiko
On Tue, Jan 12, 2021 at 8:27 AM Daniel Borkmann wrote: > > On 1/12/21 8:55 AM, Andrii Nakryiko wrote: > > Add support for directly accessing kernel module variables from BPF programs > > using special ldimm64 instructions. This functionality builds upon vmlinux > > ksym support, but extends ldimm6

Re: [PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Vladimir Oltean
On Tue, Jan 12, 2021 at 08:54:04PM +0100, Marek Behún wrote: > From: Pavana Sharma > > The Marvell 88E6393X device is a single-chip integration of a 11-port > Ethernet switch with eight integrated Gigabit Ethernet (GbE) > transceivers and three 10-Gigabit interfaces. > > This patch adds function

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Andrew Lunn
> +static int i2c_transfer_rollball(struct i2c_adapter *i2c, > + struct i2c_msg *msgs, int num) > +{ > + u8 saved_page; > + int ret; > + > + i2c_lock_bus(i2c, I2C_LOCK_SEGMENT); > + > + /* save original page */ > + ret = __i2c_rollball_get_page(i2c,

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Yuri Benditovich
On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich wrote: > > On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich > wrote: > > > > Existing TUN module is able to use provided "steering eBPF" to > > calculate per-packet hash and derive the destination queue to > > place the packet to. The eBPF uses map

Re: [PATCH bpf 2/2] libbpf: allow loading empty BTFs

2021-01-12 Thread Andrii Nakryiko
On Tue, Jan 12, 2021 at 12:17 PM Daniel Borkmann wrote: > > On 1/12/21 7:41 AM, Andrii Nakryiko wrote: > > On Mon, Jan 11, 2021 at 5:16 PM Yonghong Song wrote: > >> On 1/11/21 12:51 PM, Andrii Nakryiko wrote: > >>> On Mon, Jan 11, 2021 at 10:13 AM Yonghong Song wrote: > On 1/9/21 11:03 PM,

Re: [RFC PATCH 3/7] tun: allow use of BPF_PROG_TYPE_SCHED_CLS program type

2021-01-12 Thread Yuri Benditovich
On Tue, Jan 12, 2021 at 9:46 PM Alexei Starovoitov wrote: > > On Tue, Jan 12, 2021 at 11:42 AM Yuri Benditovich > wrote: > > > > This program type can set skb hash value. It will be useful > > when the tun will support hash reporting feature if virtio-net. > > > > Signed-off-by: Yuri Benditovich

Re: [PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Marek Behún
On Tue, 12 Jan 2021 23:30:48 +0200 Vladimir Oltean wrote: > On Tue, Jan 12, 2021 at 10:16:32PM +0100, Marek Behún wrote: > > On Tue, 12 Jan 2021 22:38:08 +0200 > > Vladimir Oltean wrote: > > > > > > + phylink_set(mask, 1baseT_Full); > > > > + phylink_set(mask,

Re: [PATCH net-next v15 4/6] net: dsa: mv88e6xxx: wrap .set_egress_port method

2021-01-12 Thread Vladimir Oltean
On Tue, Jan 12, 2021 at 08:54:03PM +0100, Marek Behún wrote: > There are two implementations of the .set_egress_port method, and both > of them, if successful, set chip->*gress_dest_port variable. > > To avoid code repetition, wrap this method into > mv88e6xxx_set_egress_port. > > Signed-off-by:

Re: [PATCH bpf 1/2] bpf: support PTR_TO_MEM{,_OR_NULL} register spilling

2021-01-12 Thread Daniel Borkmann
On 1/12/21 8:46 PM, Andrii Nakryiko wrote: On Tue, Jan 12, 2021 at 1:14 AM Gilad Reti wrote: Add support for pointer to mem register spilling, to allow the verifier to track pointer to valid memory addresses. Such pointers are returned for example by a successful call of the bpf_ringbuf_reserv

Re: [PATCH net-next 0/3] r8169: further improvements

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 09:27 +0100, Heiner Kallweit wrote: > Series includes further smaller improvements. > > Heiner Kallweit (3): > r8169: align rtl_wol_suspend_quirk with vendor driver and rename it > r8169: improve rtl8169_rx_csum > r8169: improve DASH support > > drivers/net/ethernet/r

Re: [PATCH net-next v4 1/4] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2021-01-12 Thread Andrew Lunn
> -struct mii_bus *mdio_i2c_alloc(struct device *parent, struct i2c_adapter > *i2c) > +/* RollBall SFPs do not access internal PHY via I2C address 0x56, but > + * instead via address 0x51, when SFP page is set to 0x03 and password to > + * 0x. > + * Since current SFP code does not modify S

Re: [PATCH bpf 1/2] bpf: allow empty module BTFs

2021-01-12 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf.git (refs/heads/master): On Sat, 9 Jan 2021 23:03:40 -0800 you wrote: > Some modules don't declare any new types and end up with an empty BTF, > containing only valid BTF header and no types or strings sections. This > currently causes BTF validation erro

Re: [PATCH bpf-next 1/2] trace: bpf: Allow bpf to attach to bare tracepoints

2021-01-12 Thread Yonghong Song
On 1/11/21 10:20 AM, Qais Yousef wrote: Some subsystems only have bare tracepoints (a tracepoint with no associated trace event) to avoid the problem of trace events being an ABI that can't be changed. From bpf presepective, bare tracepoints are what it calls RAW_TRACEPOINT(). Since bpf ass

Re: [PATCH bpf 2/2] libbpf: allow loading empty BTFs

2021-01-12 Thread Daniel Borkmann
On 1/12/21 7:41 AM, Andrii Nakryiko wrote: On Mon, Jan 11, 2021 at 5:16 PM Yonghong Song wrote: On 1/11/21 12:51 PM, Andrii Nakryiko wrote: On Mon, Jan 11, 2021 at 10:13 AM Yonghong Song wrote: On 1/9/21 11:03 PM, Andrii Nakryiko wrote: Empty BTFs do come up (e.g., simple kernel modules wit

Re: [PATCH v6 net-next 14/15] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 16:37 +0200, Vladimir Oltean wrote: > On Mon, Jan 11, 2021 at 03:38:49PM -0800, Saeed Mahameed wrote: > > GFP_ATOMIC is a little bit aggressive especially when user daemons > > are > > periodically reading stats. This can be avoided. > > > > You can pre-allocate with GFP_KERN

Re: [PATCH bpf v2] bpf: don't leak memory in bpf getsockopt when optlen == 0

2021-01-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Tue, 12 Jan 2021 08:28:29 -0800 you wrote: > optlen == 0 indicates that the kernel should ignore BPF buffer > and use the original one from the user. We, however, forget > to free the temporary buffer that we've allocated for BP

Re: [PATCH bpf-next 2/2] selftests: bpf: Add a new test for bare tracepoints

2021-01-12 Thread Andrii Nakryiko
On Tue, Jan 12, 2021 at 11:27 AM Qais Yousef wrote: > > On 01/11/21 23:26, Andrii Nakryiko wrote: > > On Mon, Jan 11, 2021 at 10:20 AM Qais Yousef wrote: > > > > > > Reuse module_attach infrastructure to add a new bare tracepoint to check > > > we can attach to it as a raw tracepoint. > > > > > >

Re: [PATCH v6 net-next 03/15] net: procfs: hold netif_lists_lock when retrieving device statistics

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 15:44 +0200, Vladimir Oltean wrote: > On Mon, Jan 11, 2021 at 03:46:32PM -0800, Saeed Mahameed wrote: > > This can be very costly, holding a mutex while traversing the whole > > netedv lists and reading their stats, we need to at least allow > > multiple readers to enter as it

Re: [PATCH net-next v2 0/7] ibmvnic: Use more consistent locking

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > Use more consistent locking when reading/writing the adapter->state > field. This patch set fixes a race condition during ibmvnic_open() > where the adapter could be left in the PROBED state if a reset occurs > at the wrong time. This

Re: [PATCH mlx5-next v1 2/5] PCI: Add SR-IOV sysfs entry to read number of MSI-X vectors

2021-01-12 Thread Alexander Duyck
On Mon, Jan 11, 2021 at 10:56 PM Leon Romanovsky wrote: > > On Mon, Jan 11, 2021 at 11:30:39AM -0800, Alexander Duyck wrote: > > On Sun, Jan 10, 2021 at 7:10 AM Leon Romanovsky wrote: > > > > > > From: Leon Romanovsky > > > > > > Some SR-IOV capable devices provide an ability to configure specif

Re: [PATCH net-next v14 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Vladimir Oltean
On Tue, Jan 12, 2021 at 07:06:29PM +0100, Marek Behún wrote: > On Tue, 12 Jan 2021 16:29:09 + > Russell King - ARM Linux admin wrote: > > > I'm seriously thinking about changing the phylink_validate() interface > > such that the question of which link _modes_ are supported no longer > > comes

Re: [PATCH mlx5-next v1 1/5] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-01-12 Thread Alexander Duyck
On Mon, Jan 11, 2021 at 10:39 PM Leon Romanovsky wrote: > > On Mon, Jan 11, 2021 at 11:30:33AM -0800, Alexander Duyck wrote: > > On Sun, Jan 10, 2021 at 7:12 AM Leon Romanovsky wrote: > > > > > > From: Leon Romanovsky > > > > > > Extend PCI sysfs interface with a new callback that allows configu

[PATCH net 3/3] netfilter: nf_nat: Fix memleak in nf_nat_init

2021-01-12 Thread Pablo Neira Ayuso
From: Dinghao Liu When register_pernet_subsys() fails, nf_nat_bysource should be freed just like when nf_ct_extend_register() fails. Fixes: 1cd472bf036ca ("netfilter: nf_nat: add nat hook register functions to nf_nat") Signed-off-by: Dinghao Liu Acked-by: Florian Westphal Signed-off-by: Pablo

[PATCH net 2/3] netfilter: conntrack: fix reading nf_conntrack_buckets

2021-01-12 Thread Pablo Neira Ayuso
From: Jesper Dangaard Brouer The old way of changing the conntrack hashsize runtime was through changing the module param via file /sys/module/nf_conntrack/parameters/hashsize. This was extended to sysctl change in commit 3183ab8997a4 ("netfilter: conntrack: allow increasing bucket size via sysct

[PATCH net 0/3] Netfilter fixes for net

2021-01-12 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Pass conntrack -f to specify family in netfilter conntrack helper selftests, from Chen Yi. 2) Honor hashsize modparam from nf_conntrack_buckets sysctl, from Jesper D. Brouer. 3) Fix memleak in nf_nat_init() error path, from D

[PATCH net 1/3] selftests: netfilter: Pass family parameter "-f" to conntrack tool

2021-01-12 Thread Pablo Neira Ayuso
From: Chen Yi Fix nft_conntrack_helper.sh false fail report: 1) Conntrack tool need "-f ipv6" parameter to show out ipv6 traffic items. 2) Sleep 1 second after background nc send packet, to make sure check is after this statement executed. False report: FAIL: ns1-lkjUemYw did not show attached

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-12 Thread Marek Vasut
On 1/11/21 3:47 PM, Andrew Lunn wrote: On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote: Unless the internal PHY is connected and started, the phylib will not poll the PHY for state and produce state updates. Connect the PHY and start/stop it. Hi Marek Please continue the conversio

Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

2021-01-12 Thread Marek Vasut
On 1/11/21 3:43 PM, Heiner Kallweit wrote: On 11.01.2021 15:10, Marek Vasut wrote: On 1/11/21 2:50 PM, Heiner Kallweit wrote: On 11.01.2021 14:38, Marek Vasut wrote: On 1/11/21 2:26 PM, Heiner Kallweit wrote: [...] LGTM. When having a brief look at the driver I stumbled across two things: 1

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2021-01-12 Thread Jarod Wilson
On Tue, Jan 12, 2021 at 01:39:10PM -0800, Jay Vosburgh wrote: > Jarod Wilson wrote: > > >On Thu, Jan 07, 2021 at 07:03:40PM -0500, Jarod Wilson wrote: > >> On Fri, Dec 18, 2020 at 04:18:59PM -0800, Jay Vosburgh wrote: > >> > Jarod Wilson wrote: > >> > > >> > >This comes from an end-user request

Re: [PATCH net-next v15 5/6] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2021-01-12 Thread Marek Behún
On Tue, 12 Jan 2021 20:54:04 +0100 Marek Behún wrote: > + /* mv88e6393x family errata 3.7 : > + * When changing cmode on SERDES port from any other mode to 1000BASE-X > + * mode the link may not come up due to invalid 1000BASE-X > + * advertisement. > + * Workaround: Corre

Re: [PATCH net-next] net: ipa: add config dependency on QCOM_SMEM

2021-01-12 Thread Bjorn Andersson
On Tue 12 Jan 13:21 CST 2021, Alex Elder wrote: > The IPA driver depends on some SMEM functionality (qcom_smem_init(), > qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not > reflected in the configuration dependencies. Add a dependency on > QCOM_SMEM to avoid attempts to build the

[PATCH net-next] net: phy: ar803x: disable extended next page bit

2021-01-12 Thread Russell King
This bit is enabled by default and advertises support for extended next page support. XNP is only needed for 10GBase-T and MultiGig support which is not supported. Additionally, Cisco MultiGig switches will read this bit and attempt 10Gb negotiation even though Next Page support is disabled. This

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 04:17:44 + Geethasowjanya Akula wrote: > Hi All, > > Any feedback on this patch. I think Dave merged it already, see commit 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") in net-next.

Re: [net] net: feature check mandating HW_CSUM is wrong

2021-01-12 Thread Jakub Kicinski
On Wed, 13 Jan 2021 02:47:51 +0530 rohit maheshwari wrote: > On 07/01/21 12:47 AM, Jakub Kicinski wrote: > > On Wed, 6 Jan 2021 23:23:27 +0530 Rohit Maheshwari wrote: > >> Mandating NETIF_F_HW_CSUM to enable TLS offload feature is wrong. > >> And it broke tls offload feature for the drivers, whi

Re: [PATCH net-next 0/7] a set of fixes of coding style

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 00:42 -0600, Lijun Pan wrote: > This series address several coding style problems. > > Lijun Pan (7): > ibmvnic: prefer 'unsigned long' over 'unsigned long int' > ibmvnic: fix block comments > ibmvnic: fix braces > ibmvnic: avoid multiple line dereference > ibmvnic:

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

2021-01-12 Thread Saeed Mahameed
On Mon, 2021-01-04 at 12:50 +0530, Geetha sowjanya wrote: > Hardware supports 8 RSS groups per interface. Currently we are using > only group '0'. This patch allows user to create new RSS > groups/contexts > and use the same as destination for flow steering rules. > > usage: > To steer the traffic

Re: [PATCv4 net-next] octeontx2-pf: Add RSS multi group support

2021-01-12 Thread Saeed Mahameed
On Tue, 2021-01-12 at 15:16 -0800, Saeed Mahameed wrote: > On Mon, 2021-01-04 at 12:50 +0530, Geetha sowjanya wrote: > > Hardware supports 8 RSS groups per interface. Currently we are > > using > > only group '0'. This patch allows user to create new RSS > > groups/contexts > > and use the same as

Re: [PATCH v3 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-12 Thread Alexei Starovoitov
On Tue, Jan 12, 2021 at 8:30 AM Daniel Borkmann wrote: > > On 1/12/21 8:55 AM, Andrii Nakryiko wrote: > > Add support for directly accessing kernel module variables from BPF programs > > using special ldimm64 instructions. This functionality builds upon vmlinux > > ksym support, but extends ldimm6

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

2021-01-12 Thread Roman Gushchin
On Tue, Jan 12, 2021 at 01:41:05PM -0800, Shakeel Butt wrote: > From: Arjun Roy > > TCP zerocopy receive is used by high performance network applications to > further scale. For RX zerocopy, the memory containing the network data > filled by network driver is directly mapped into the address spac

Re: (subset) [PATCH 00/10] Remove support for TX49xx

2021-01-12 Thread Alexandre Belloni
On Tue, 5 Jan 2021 15:02:45 +0100, Thomas Bogendoerfer wrote: > I couldn't find any buyable product other than reference boards using > TX49xx CPUs. And since nobody showed interest in keeping support for > it, it's time to remove it. > > I've split up the removal into seperate parts for different

Re: [PATCH] tcp: keepalive fixes

2021-01-12 Thread Enke Chen
Hi, Yuchung: I have attached the python script that reproduces the keepalive issues. The script is a slight modification of the one written by Marek Majkowski: https://github.com/cloudflare/cloudflare-blog/blob/master/2019-09-tcp-keepalives/test-zero.py Please note that only the TCP keepalive is

Re: [PATCH] kernel: trace: uprobe: Fix word to the correct spelling

2021-01-12 Thread Randy Dunlap
On 1/11/21 8:50 PM, Bhaskar Chowdhury wrote: > s/controling/controlling/p > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap Thanks. > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/tra

mv88e6xxx: 2500base-x inband AN is broken on Amethyst? what to do?

2021-01-12 Thread Marek Behún
Hello, it seems that inband AN is broken on Amethyst when on 2500base-x mode. Even SERDES scripts for Amethyst from Marvell has autonegotiation disabled for 2500base-x mode. For all the other supported Serdes modes autonegotiation is enabled in these scripts. The current implementation in mv88e6

Re: [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue

2021-01-12 Thread Sukadev Bhattiprolu
Saeed Mahameed [sa...@kernel.org] wrote: > On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > > @@ -5467,7 +5472,15 @@ static int ibmvnic_remove(struct vio_dev *dev) > > return -EBUSY; > > } > > > > + /* If ibmvnic_reset() is scheduling a reset, wait for it to > >

Re: [PATCH net] net: dcb: Accept RTM_GETDCB messages carrying set-like DCB commands

2021-01-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 11 Jan 2021 18:07:07 +0100 you wrote: > In commit 826f328e2b7e ("net: dcb: Validate netlink message in DCB > handler"), Linux started rejecting RTM_GETDCB netlink messages if they > contained a set-like DCB_CMD_ command.

Re: [PATCH net-next 0/7] a set of fixes of coding style

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 00:42:58 -0600 Lijun Pan wrote: > This series address several coding style problems. Erm, are you sure this series will not conflict with the fixes Sukadev is sending?

Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy

2021-01-12 Thread Roman Gushchin
On Tue, Jan 12, 2021 at 03:36:18PM -0800, Arjun Roy wrote: > On Tue, Jan 12, 2021 at 3:31 PM Roman Gushchin wrote: > > > > On Tue, Jan 12, 2021 at 01:41:05PM -0800, Shakeel Butt wrote: > > > From: Arjun Roy > > > > > > TCP zerocopy receive is used by high performance network applications to > > >

Re: [RFC PATCH 0/7] Support for virtio-net hash reporting

2021-01-12 Thread Willem de Bruijn
On Tue, Jan 12, 2021 at 3:29 PM Yuri Benditovich wrote: > > On Tue, Jan 12, 2021 at 9:49 PM Yuri Benditovich > wrote: > > > > On Tue, Jan 12, 2021 at 9:41 PM Yuri Benditovich > > wrote: > > > > > > Existing TUN module is able to use provided "steering eBPF" to > > > calculate per-packet hash and

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-12 Thread Sedat Dilek
On Mon, Jan 11, 2021 at 7:06 PM Nathan Chancellor wrote: > > After commit da5fb18225b4 ("bpf: Support pre-2.25-binutils objcopy for > vmlinux BTF"), having CONFIG_DEBUG_INFO_BTF enabled but lacking a valid > copy of pahole results in a kernel that will fully compile but fail to > link. The user th

Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 11:55:11 -0800 Praveen Chaudhary wrote: > Hi Jakub > > Thanks for the review, > > Sure, I will reraise the patch (again v0i, sonce no code changes) after > adding space before '<'. > > This patch adds lines in 'include/uapi/', that requires ABI version changes > for debian

[PATCH bpf-next] bpf: reject too big ctx_size_in for raw_tp test run

2021-01-12 Thread Song Liu
syzbot reported a WARNING for allocating too big memory: WARNING: CPU: 1 PID: 8484 at mm/page_alloc.c:4976 __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5011 Modules linked in: CPU: 1 PID: 8484 Comm: syz-executor862 Not tainted 5.11.0-rc2-syzkaller #0 Hardware name: Google Google Compute Eng

Re: [PATCH net-next 0/5] skbuff: introduce skbuff_heads bulking and reusing

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 13:23:16 +0100 Eric Dumazet wrote: > On Tue, Jan 12, 2021 at 12:08 PM Alexander Lobakin wrote: > > > > From: Edward Cree > > Date: Tue, 12 Jan 2021 09:54:04 + > > > > > Without wishing to weigh in on whether this caching is a good idea... > > > > Well, we already have

Re: [PATCH net-next v2 3/7] ibmvnic: avoid allocating rwi entries

2021-01-12 Thread Sukadev Bhattiprolu
Saeed Mahameed [sa...@kernel.org] wrote: > > -struct ibmvnic_rwi { > > - enum ibmvnic_reset_reason reset_reason; > > - struct list_head list; > > -}; > > + VNIC_RESET_CHANGE_PARAM, > > + VNIC_RESET_MAX}; // must be last >this is not the pref

RE: [PATCH v2] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-12 Thread ashid...@fujitsu.com
> > I think it's possible to return a Master/Slave configuration. > > Great. It would be good to add it. OK. I think it will take some time to implement this feature, as we prioritize investigating comments from Russell. > > By the way, do you need the cable test function as implementedin > > nx

Re: [PATCH bpf-next v2 1/2] bpf: allow to retrieve sol_socket opts from sock_addr progs

2021-01-12 Thread Alexei Starovoitov
On Mon, Jan 11, 2021 at 3:09 PM Daniel Borkmann wrote: > > The _bpf_setsockopt() is able to set some of the SOL_SOCKET level options, > however, _bpf_getsockopt() has little support to actually retrieve them. > This small patch adds few misc options such as SO_MARK, SO_PRIORITY and > SO_BINDTOIFIN

Re: [PATCH v3 bpf-next 7/7] selftests/bpf: test kernel module ksym externs

2021-01-12 Thread Alexei Starovoitov
On Tue, Jan 12, 2021 at 3:41 AM Andrii Nakryiko wrote: > > Add per-CPU variable to bpf_testmod.ko and use those from new selftest to > validate it works end-to-end. > > Acked-by: Yonghong Song > Acked-by: Hao Luo > Signed-off-by: Andrii Nakryiko Applied. FYI for everyone. This test needs the

RE: [PATCH] igb: avoid premature Rx buffer reuse

2021-01-12 Thread Li,Rongqing
> -Original Message- > From: Alexander Duyck [mailto:alexander.du...@gmail.com] > Sent: Wednesday, January 13, 2021 5:23 AM > To: Li,Rongqing > Cc: Netdev ; intel-wired-lan > ; Björn Töpel > Subject: Re: [PATCH] igb: avoid premature Rx buffer r > Okay, this explanation makes much more

Re: [Patch net] cls_flower: call nla_ok() before nla_next()

2021-01-12 Thread Jakub Kicinski
On Mon, 11 Jan 2021 18:55:48 -0800 Cong Wang wrote: > From: Cong Wang > > fl_set_enc_opt() simply checks if there are still bytes left to parse, > but this is not sufficent as syzbot seems to be able to generate > malformatted netlink messages. nla_ok() is more strict so should be > used to valid

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > tx timestamp gets attached on the skb. > > > > There two main reasons to include this call in can_put_echo_skb(): >

Re: [PATCH v4 1/1] can: dev: add software tx timestamps

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 17:46:25 -0800 Jakub Kicinski wrote: > On Tue, 12 Jan 2021 11:03:00 +0100 Marc Kleine-Budde wrote: > > On 1/12/21 10:54 AM, Vincent Mailhol wrote: > > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > > tx timestamp gets attached on the skb. > > > > >

[PATCH v1 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-12 Thread Praveen Chaudhary
For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config etc/network/interfaces. But for IPv6, default route can be learned via RA, for which, currently a fixed metric value 1024 is used. Ideally, user should be able to configure metric on default route for I

[PATCH v1 net-next 0/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-12 Thread Praveen Chaudhary
Allow user to set metric on default route learned via Router Advertisement. Note: RFC 4191 does not say anything for metric for IPv6 default route. Fix: For IPv4, default route is learned via DHCPv4 and user is allowed to change metric using config in etc/network/interfaces. But for IPv6, default

Re: [PATCH net-next v2 5/7] ibmvnic: serialize access to work queue

2021-01-12 Thread Jakub Kicinski
On Tue, 12 Jan 2021 16:40:49 -0800 Sukadev Bhattiprolu wrote: > Saeed Mahameed [sa...@kernel.org] wrote: > > On Tue, 2021-01-12 at 10:14 -0800, Sukadev Bhattiprolu wrote: > > > > > @@ -5467,7 +5472,15 @@ static int ibmvnic_remove(struct vio_dev *dev) > > > return -EBUSY; > > > } > >

  1   2   3   4   5   >