Re: [PATCH 1/1] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 21:27:27 +0100 Leon Schuermann wrote: > This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to > work with the cdc_ether driver. When you say "used to work" do you mean there was a regression where the older kernels would work fine and newer don't? Or just "it wo

Re: [PATCH net-next 0/2] Update register/bit definitions in the EtherAVB driver

2021-01-08 Thread Jakub Kicinski
On Wed, 6 Jan 2021 23:30:42 +0300 Sergey Shtylyov wrote: > Here are 2 patches against DaveM's 'net-next' repo. I'm updating the driver > to match > the recent R-Car gen2/3 manuals... Applied, thanks, but I dropped the Fixes tag from patch 1. Patch which makes no functional changes can't be fixing

Re: [PATCH net] net: ipa: modem: add missing SET_NETDEV_DEV() for proper sysfs links

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 6 Jan 2021 11:07:55 +0100 you wrote: > At the moment it is quite hard to identify the network interface > provided by IPA in userspace components: The network interface is > created as virtual device, without any link t

[PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-08 Thread Charlie Somerville
This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents the allocation of additional send queues for XDP programs. Included in this patch series is an implementation of XDP_FLAGS_NO_TX for the virtio_net driver. This flag is intended to be advisory - not all drivers must implement s

[PATCH net-next 2/2] virtio_net: Implement XDP_FLAGS_NO_TX support

2021-01-08 Thread Charlie Somerville
No send queues will be allocated for XDP filters. Attempts to transmit packets when no XDP send queues exist will fail with EOPNOTSUPP. Signed-off-by: Charlie Somerville --- drivers/net/virtio_net.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/ne

[PATCH net-next 1/2] xdp: Add XDP_FLAGS_NO_TX flag

2021-01-08 Thread Charlie Somerville
Some network interfaces must allocate additional hardware resources to support XDP filters retransmitting packets with XDP_TX. However not all XDP filters do use XDP_TX, and there may not be any additional send queues available for use. XDP filters can indicate that they will never transmit by se

[PATCH net V2] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-08 Thread Ayush Sawal
TID stuck is seen when there is a race in CPL_PASS_ACCEPT_RPL/CPL_ABORT_REQ and abort is arriving before the accept reply, which sets the queue number. In this case HW ends up sending CPL_ABORT_RPL_RSS to an incorrect ingress queue. V1->V2: - Removed the unused variable len in chtls_set_quiesce_ct

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-08 Thread Don Dutile
On 1/8/21 4:09 PM, Bjorn Helgaas wrote: On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: On 1/7/21 7:57 PM, Bjorn Helgaas wrote: On Sun, Jan 03, 2021 at 10:24:37AM +0200, Leon Romanovsky wrote: + **/ +int pci_set_msix_vec_count(struct pci_dev *dev, int numb) +{ + struct pci_de

Re: [PATCH net v3] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 11:18:39 +0100 Daniel Borkmann wrote: > On 1/8/21 3:28 AM, Dongseok Yi wrote: > > skbs in fraglist could be shared by a BPF filter loaded at TC. If TC > > writes, it will call skb_ensure_writable -> pskb_expand_head to create > > a private linear section for the head_skb. And the

Re: [PATCH] udp: Prevent reuseport_select_sock from reading uninitialized socks

2021-01-08 Thread Jakub Kicinski
On Thu, 7 Jan 2021 00:27:07 -0500 Willem de Bruijn wrote: > On Thu, Jan 7, 2021 at 12:11 AM Baptiste Lepers > wrote: > > > > reuse->socks[] is modified concurrently by reuseport_add_sock. To > > prevent reading values that have not been fully initialized, only read > > the array up until the last

Re: [PATCH V2 net-next 3/3] MAINTAINERS: add bgmac section entry

2021-01-08 Thread Jakub Kicinski
On Thu, 7 Jan 2021 12:08:58 -0800 Florian Fainelli wrote: > On 1/7/21 10:00 AM, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > This driver exists for years but was missing its MAINTAINERS entry. > > > > Signed-off-by: Rafał Miłecki > > Acked-by: Florian Fainelli Applied, thanks!

Re: [PATCH net v3] ppp: fix refcount underflow on channel unbridge

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 21:57:50 +0100 Guillaume Nault wrote: > On Thu, Jan 07, 2021 at 06:13:15PM +, Tom Parkin wrote: > > When setting up a channel bridge, ppp_bridge_channels sets the > > pch->bridge field before taking the associated reference on the bridge > > file instance. > > > > This opens

Re: [PATCH net-next] ppp: clean up endianness conversions

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 7 Jan 2021 15:39:56 +0100 you wrote: > sparse complains about some harmless endianness issues: > > > drivers/net/ppp/pptp.c:281:21: warning: incorrect type in assignment > > (different base types) > > drivers/net

Re: [PATCH net-next] net: ip_tunnel: clean up endianness conversions

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 7 Jan 2021 15:40:08 +0100 you wrote: > sparse complains about some harmless endianness issues: > > > net/ipv4/ip_tunnel_core.c:225:43: warning: cast to restricted __be16 > > net/ipv4/ip_tunnel_core.c:225:43: warni

Re: [PATCH net 0/3] net: fix issues around register_netdevice() failures

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 6 Jan 2021 10:40:04 -0800 you wrote: > This series attempts to clean up the life cycle of struct > net_device. Dave has added dev->needs_free_netdev in the > past to fix double frees, we can lean on that mechanism > a

Re: [PATCH v3 net-next 09/10] net: mscc: ocelot: initialize watermarks to sane defaults

2021-01-08 Thread Florian Fainelli
On 1/8/2021 9:59 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This is meant to be a gentle introduction into the world of watermarks > on ocelot. The code is placed in ocelot_devlink.c because it will be > integrated with devlink, even if it isn't right now. > > My first step was in

Re: [PATCH v3 net-next 10/10] net: mscc: ocelot: configure watermarks using devlink-sb

2021-01-08 Thread Florian Fainelli
On 1/8/2021 9:59 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Using devlink-sb, we can configure 12/16 (the important 75%) of the > switch's controlling watermarks for congestion drops, and we can monitor > 50% of the watermark occupancies (we can monitor the reservation > watermarks

Re: [PATCH v4 net-next 02/11] net: dsa: mv88e6xxx: deny vid 0 on the CPU port and DSA links too

2021-01-08 Thread Florian Fainelli
On 1/8/2021 4:01 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > mv88e6xxx apparently has a problem offloading VID 0, which the 8021q > module tries to install as part of commit ad1afb003939 ("vlan_dev: VLAN > 0 should be treated as "no vlan tag" (802.1p packet)"). That mv88e6xxx > rest

Re: [PATCH v4 net-next 01/11] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

2021-01-08 Thread Florian Fainelli
On 1/8/2021 4:01 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The call path of a switchdev VLAN addition to the bridge looks something > like this today: > > nbp_vlan_init > | __br_vlan_set_default_pvid > | | | > | |br_afs

RE

2021-01-08 Thread General Leigh Ann Hester
Hi, How are you doing, i hope all is well with you? I would like to hear from you very urgently because I have an important issue to discuss with you. So contact me with this email address as follows: (hesterleighann...@gmail.com) for more information. Thanks, General Leigh Ann Hester.

Re: [PATCH] bus: mhi: Add inbound buffers allocation flag

2021-01-08 Thread Hemant Kumar
On 1/8/21 7:30 AM, Manivannan Sadhasivam wrote: On Fri, Jan 08, 2021 at 03:01:59PM +0100, Loic Poulain wrote: Hi Mani, On Fri, 8 Jan 2021 at 14:44, Manivannan Sadhasivam < manivannan.sadhasi...@linaro.org> wrote: On Wed, Jan 06, 2021 at 02:43:43PM +0100, Loic Poulain wrote: Currently, the

[PATCH] Revert "tcp: simplify window probe aborting on USER_TIMEOUT"

2021-01-08 Thread Enke Chen
From: Enke Chen This reverts commit 9721e709fa68ef9b860c322b474cfbd1f8285b0f. With the commit 9721e709fa68 ("tcp: simplify window probe aborting on USER_TIMEOUT"), the TCP session does not terminate with TCP_USER_TIMEOUT when data remain untransmitted due to zero window. The number of unanswere

[PATCH net-next] net: marvell: prestera: Correct typo

2021-01-08 Thread Florian Fainelli
The function was incorrectly named with a trailing 'r' at the end of prestera. Signed-off-by: Florian Fainelli --- Jakub, David, This patch is on top of Vladimir's series: [PATCH v4 net-next 00/11] Get rid of the switchdev transactional model .../net/ethernet/marvell/prestera/prestera_switchde

Re: [PATCH v4 net-next 01/11] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

2021-01-08 Thread Kurt Kanzenbach
On Sat Jan 09 2021, Vladimir Oltean wrote: > From: Vladimir Oltean > > The call path of a switchdev VLAN addition to the bridge looks something > like this today: > > nbp_vlan_init > | __br_vlan_set_default_pvid > | | | > | |br_afspec

<    1   2   3