Re: [PATCH 2/3] vhost/vsock: support for SOCK_SEQPACKET socket.

2020-12-30 Thread Michael S. Tsirkin
On Wed, Dec 30, 2020 at 03:56:03PM -0500, Michael S. Tsirkin wrote: > On Tue, Dec 29, 2020 at 02:06:33PM +0300, Arseny Krasnov wrote: > > This patch simply adds transport ops and removes > > ignore of non-stream type of packets. > > > > Signed-off-by: Arseny Krasnov > > How is this supposed

Re: [PATCH 1/3] vsock/virtio: support for SOCK_SEQPACKET socket.

2020-12-30 Thread Michael S. Tsirkin
On Tue, Dec 29, 2020 at 02:04:51PM +0300, Arseny Krasnov wrote: > To preserve message boundaries, new packet operation was added: > to mark start of record(with record length in header). To send record, > packet with start marker is sent first, then all data is transmitted as > 'RW' packets

Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

2020-12-30 Thread Jakub Kicinski
On Mon, 28 Dec 2020 16:14:17 -0500 Konstantin Ryabitsev wrote: > On Mon, Dec 28, 2020 at 01:05:26PM -0800, Florian Fainelli wrote: > > On 12/28/2020 12:23 PM, Konstantin Ryabitsev wrote: > > > On Thu, Dec 24, 2020 at 01:57:40PM -0800, Florian Fainelli wrote: > > Konstantin, would you be wi

Re: [PATCH] ibmvnic: fix: NULL pointer dereference.

2020-12-30 Thread Lijun Pan
On Wed, Dec 30, 2020 at 1:25 AM YANG LI wrote: > > The error is due to dereference a null pointer in function > reset_one_sub_crq_queue(): > > if (!scrq) { > netdev_dbg(adapter->netdev, >"Invalid scrq reset. irq (%d) or msgs(%p).\n", > scrq->irq, scrq->msgs); >

[PATCH] neighbour: Disregard DEAD dst in neigh_update

2020-12-30 Thread Tong Zhu
In 4.x kernel a dst in DST_OBSOLETE_DEAD state is associated with loopback net_device and leads to loopback neighbour. It leads to an ethernet header with all zero addresses. A very troubling case is working with mac80211 and ath9k. A packet with all zero source MAC address to mac80211 will eventu

Re: [PATCH v5 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-30 Thread Daniel Borkmann
On 12/29/20 7:09 PM, Lorenzo Bianconi wrote: + hard_start = page_address(rx_buffer->page) + + rx_buffer->page_offset - offset; + xdp_prepare_buff(&xdp, hard_start, offset, size, true); #if (PAGE_SIZE > 4096)

Re: [PATCH 2/2] net: ks8851: Register MDIO bus and the internal PHY

2020-12-30 Thread kernel test robot
suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Vasut/net-phy-micrel-Add-KS8851-PHY-support/20201230-210003 base: https://git.kernel.org/pub/scm/linux/kernel/git/dav

Re: [PATCH 12/21] vhost-vdpa: introduce uAPI to get the number of virtqueue groups

2020-12-30 Thread Jason Wang
On 2020/12/30 下午6:05, Eli Cohen wrote: On Wed, Dec 16, 2020 at 02:48:09PM +0800, Jason Wang wrote: Follows the vDPA support for multiple address spaces, this patch introduce uAPI for the userspace to know the number of virtqueue groups supported by the vDPA device. Signed-off-by: Jason Wang -

Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-30 Thread Jason Wang
On 2020/12/30 下午6:12, Yongji Xie wrote: On Wed, Dec 30, 2020 at 4:41 PM Jason Wang wrote: On 2020/12/30 下午3:09, Yongji Xie wrote: On Wed, Dec 30, 2020 at 2:11 PM Jason Wang wrote: On 2020/12/29 下午6:26, Yongji Xie wrote: On Tue, Dec 29, 2020 at 5:11 PM Jason Wang wrote: - Original M

[PATCH net-next v2] net: nfc: nci: Change the NCI close sequence

2020-12-30 Thread Bongsu Jeon
From: Bongsu Jeon If there is a NCI command in work queue after closing the NCI device at nci_unregister_device, The NCI command timer starts at flush_workqueue function and then NCI command timeout handler would be called 5 second after flushing the NCI command work queue and destroying the qu

[PATCH net] net: suggest L2 discards be counted towards rx_dropped

2020-12-30 Thread Jakub Kicinski
>From the existing definitions it's unclear which stat to use to report filtering based on L2 dst addr in old broadcast-medium Ethernet. Signed-off-by: Jakub Kicinski --- include/uapi/linux/if_link.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/if_l

[PATCH net] net: vlan: avoid leaks on register_vlan_dev() failures

2020-12-30 Thread Jakub Kicinski
VLAN checks for NETREG_UNINITIALIZED to distinguish between registration failure and unregistration in progress. Since commit cb626bf566eb ("net-sysfs: Fix reference count leak") registration failure may, however, result in NETREG_UNREGISTERED as well as NETREG_UNINITIALIZED. This fix is similer

[PATCH net] net: bareudp: add missing error handling for bareudp_link_config()

2020-12-30 Thread Jakub Kicinski
.dellink does not get called after .newlink fails, bareudp_newlink() must undo what bareudp_configure() has done if bareudp_link_config() fails. Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.") Signed-off-by: Jakub Kicinski -

[PATCH net] docs: net: fix documentation on .ndo_get_stats

2020-12-30 Thread Jakub Kicinski
Fix calling context. Signed-off-by: Jakub Kicinski --- Documentation/networking/netdevices.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst index 5a85fcc80c76..a80676f5477d 100644 --- a/

Re: Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-30 Thread Yongji Xie
On Thu, Dec 31, 2020 at 10:49 AM Jason Wang wrote: > > > On 2020/12/30 下午6:12, Yongji Xie wrote: > > On Wed, Dec 30, 2020 at 4:41 PM Jason Wang wrote: > >> > >> On 2020/12/30 下午3:09, Yongji Xie wrote: > >>> On Wed, Dec 30, 2020 at 2:11 PM Jason Wang wrote: > On 2020/12/29 下午6:26, Yongji Xie

Re: [PATCH net-next] nfc: Add a virtual nci device driver

2020-12-30 Thread Bongsu Jeon
On Tue, Dec 29, 2020 at 6:16 AM Jakub Kicinski wrote: > > On Mon, 28 Dec 2020 18:45:07 +0900 Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > A NCI virtual device can be made to simulate a NCI device in user space. > > Using the virtual NCI device, The NCI module and application can be > > valida

[PATCH iproute2-next] rdma: Add support for the netlink extack

2020-12-30 Thread Leon Romanovsky
From: Patrisious Haddad Add support in rdma for extack errors to be received in userspace when sent from kernel, so now netlink extack error messages sent from kernel would be printed for the user. Signed-off-by: Patrisious Haddad Signed-off-by: Leon Romanovsky --- Kernel part: https://lore.ke

Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-30 Thread Jason Wang
On 2020/12/31 下午1:15, Yongji Xie wrote: On Thu, Dec 31, 2020 at 10:49 AM Jason Wang wrote: On 2020/12/30 下午6:12, Yongji Xie wrote: On Wed, Dec 30, 2020 at 4:41 PM Jason Wang wrote: On 2020/12/30 下午3:09, Yongji Xie wrote: On Wed, Dec 30, 2020 at 2:11 PM Jason Wang wrote: On 2020/12/29 下

Re: [PATCH bpf-next 1/2] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt

2020-12-30 Thread Martin KaFai Lau
On Mon, Dec 21, 2020 at 02:22:41PM -0800, Song Liu wrote: > On Thu, Dec 17, 2020 at 9:24 AM Stanislav Fomichev wrote: > > > > When we attach a bpf program to cgroup/getsockopt any other getsockopt() > > syscall starts incurring kzalloc/kfree cost. While, in general, it's > > not an issue, sometime

Re: [PATCH bpf-next 1/2] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt

2020-12-30 Thread Martin KaFai Lau
On Tue, Dec 22, 2020 at 07:09:33PM -0800, s...@google.com wrote: > On 12/22, Martin KaFai Lau wrote: > > On Thu, Dec 17, 2020 at 09:23:23AM -0800, Stanislav Fomichev wrote: > > > When we attach a bpf program to cgroup/getsockopt any other getsockopt() > > > syscall starts incurring kzalloc/kfree co

Re: Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-30 Thread Yongji Xie
On Thu, Dec 31, 2020 at 1:50 PM Jason Wang wrote: > > > On 2020/12/31 下午1:15, Yongji Xie wrote: > > On Thu, Dec 31, 2020 at 10:49 AM Jason Wang wrote: > >> > >> On 2020/12/30 下午6:12, Yongji Xie wrote: > >>> On Wed, Dec 30, 2020 at 4:41 PM Jason Wang wrote: > On 2020/12/30 下午3:09, Yongji Xie

Re: [RFC v2 09/13] vduse: Add support for processing vhost iotlb message

2020-12-30 Thread Jason Wang
On 2020/12/31 下午2:52, Yongji Xie wrote: On Thu, Dec 31, 2020 at 1:50 PM Jason Wang wrote: On 2020/12/31 下午1:15, Yongji Xie wrote: On Thu, Dec 31, 2020 at 10:49 AM Jason Wang wrote: On 2020/12/30 下午6:12, Yongji Xie wrote: On Wed, Dec 30, 2020 at 4:41 PM Jason Wang wrote: On 2020/12/30 下

<    1   2