[PATCH net 2/3] net: ipa: use state to determine channel command success

2020-12-22 Thread Alex Elder
The result of issuing a channel control command should be that the channel changes state. If enabled, a completion interrupt signals that the channel state has changed. This interrupt is enabled by gsi_channel_command() and disabled again after the command has completed (or we time out). There i

[PATCH net 1/3] net: ipa: clear pending interrupts before enabling

2020-12-22 Thread Alex Elder
We enable the completion interrupt for channel or event ring commands only when we issue them. The interrupt is disabled after the interrupt has fired, or after we have timed out waiting for it. If we time out, the command could complete after the interrupt has been disabled, causing a state chan

Re: [PATCH 09/12 v2 RFC] skbuff: add zc_flags to ubuf_info for ubuf setup

2020-12-22 Thread Jonathan Lemon
On Tue, Dec 22, 2020 at 10:00:37AM -0500, Willem de Bruijn wrote: > On Mon, Dec 21, 2020 at 7:09 PM Jonathan Lemon > wrote: > > > > From: Jonathan Lemon > > > > Currently, an ubuf is attached to a new skb, the skb zc_flags > > is initialized to a fixed value. Instead of doing this, set > > the

Re: [PATCH 09/12 v2 RFC] skbuff: add zc_flags to ubuf_info for ubuf setup

2020-12-22 Thread Willem de Bruijn
On Tue, Dec 22, 2020 at 1:17 PM Jonathan Lemon wrote: > > On Tue, Dec 22, 2020 at 10:00:37AM -0500, Willem de Bruijn wrote: > > On Mon, Dec 21, 2020 at 7:09 PM Jonathan Lemon > > wrote: > > > > > > From: Jonathan Lemon > > > > > > Currently, an ubuf is attached to a new skb, the skb zc_flags >

Re: [PATCH] net/ncsi: Use real net-device for response handler

2020-12-22 Thread Samuel Mendoza-Jonas
On Tue, 2020-12-22 at 06:13 +, Joel Stanley wrote: > On Sun, 20 Dec 2020 at 12:40, John Wang < > wangzhiqiang...@bytedance.com> wrote: > > > > When aggregating ncsi interfaces and dedicated interfaces to bond > > interfaces, the ncsi response handler will use the wrong net device > > to > > fi

Re: [RFC PATCH v2 4/8] net: sparx5: add port module support

2020-12-22 Thread Bjarni Jonasson
On Mon, 2020-12-21 at 00:35 +0100, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > > + /* Aneg complete provides more information */ > > + if (DEV2G5_PCS1G_ANEG_STATUS_ANEG_COMPLETE_GET(value)) { > > + if (p

Re: [PATCH bpf-next V10 7/7] bpf/selftests: tests using bpf_check_mtu BPF-helper

2020-12-22 Thread Andrii Nakryiko
On Tue, Dec 22, 2020 at 8:23 AM Jesper Dangaard Brouer wrote: > > Adding selftest for BPF-helper bpf_check_mtu(). Making sure > it can be used from both XDP and TC. > > V10: > - Remove errno non-zero test in CHECK_ATTR() > - Addresse comments from Andrii Nakryiko > > Signed-off-by: Jesper Dangaa

Re: [PATCH bpf-next 1/2] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt

2020-12-22 Thread Martin KaFai Lau
On Thu, Dec 17, 2020 at 09:23:23AM -0800, Stanislav Fomichev wrote: > When we attach a bpf program to cgroup/getsockopt any other getsockopt() > syscall starts incurring kzalloc/kfree cost. While, in general, it's > not an issue, sometimes it is, like in the case of TCP_ZEROCOPY_RECEIVE. > TCP_ZERO

[PATCH bpf] selftests/bpf: work-around EBUSY errors from hashmap update/delete

2020-12-22 Thread Andrii Nakryiko
20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked") introduced a possibility of getting EBUSY error on lock contention, which seems to happen very deterministically in test_maps when running 1024 threads on low-CPU machine. In libbpf CI case, it's a 2 CPU VM and it's hitting this 100% of t

[Aspeed, v2 0/2] net: ftgmac100: Change the order of getting MAC address

2020-12-22 Thread Hongwei Zhang
Dear Reviewer, Use native MAC address is preferred over other choices, thus change the order of reading MAC address, try to read it from MAC chip first, if it's not availabe, then try to read it from device tree. Thanks, --Hongwei Changelog: v2: - Corrected comments in the patch v1: https://pa

[Aspeed, v2 2/2] net: ftgmac100: Change the order of getting MAC address

2020-12-22 Thread Hongwei Zhang
Dear Reviewer, Use native MAC address is preferred over other choices, thus change the order of reading MAC address, try to read it from MAC chip first, if it's not availabe, then try to read it from device tree. Hi Heiner, > From: Heiner Kallweit > Sent: Monday, December 21, 2020 4:37 PM > >

[Aspeed, v2 1/2] net: ftgmac100: Change the order of getting MAC address

2020-12-22 Thread Hongwei Zhang
Change the order of reading MAC address, try to read it from MAC chip first, if it's not availabe, then try to read it from device tree. Fixes: 35c54922dc97 ("ARM: dts: tacoma: Add reserved memory for ramoops") Signed-off-by: Hongwei Zhang --- drivers/net/ethernet/faraday/ftgmac100.c | 22 ++

Re: [Aspeed, v2 2/2] net: ftgmac100: Change the order of getting MAC address

2020-12-22 Thread Heiner Kallweit
On 22.12.2020 21:14, Hongwei Zhang wrote: > Dear Reviewer, > > Use native MAC address is preferred over other choices, thus change the order > of reading MAC address, try to read it from MAC chip first, if it's not > availabe, then try to read it from device tree. > > > Hi Heiner, > >> From:

Re: [Aspeed, v2 2/2] net: ftgmac100: Change the order of getting MAC address

2020-12-22 Thread Andrew Lunn
On Tue, Dec 22, 2020 at 09:46:52PM +0100, Heiner Kallweit wrote: > On 22.12.2020 21:14, Hongwei Zhang wrote: > > Dear Reviewer, > > > > Use native MAC address is preferred over other choices, thus change the > > order > > of reading MAC address, try to read it from MAC chip first, if it's not > >

Re: [PATCH v3 09/24] wfx: add hwio.c/hwio.h

2020-12-22 Thread Jérôme Pouiller
On Tuesday 22 December 2020 16:27:01 CET Greg Kroah-Hartman wrote: > > On Tue, Dec 22, 2020 at 05:10:11PM +0200, Kalle Valo wrote: > > Jerome Pouiller writes: > > > > > +/* > > > + * Internal helpers. > > > + * > > > + * About CONFIG_VMAP_STACK: > > > + * When CONFIG_VMAP_STACK is enabled, it is

Re: [PATCH v3 12/24] wfx: add hif_api_*.h

2020-12-22 Thread Jérôme Pouiller
On Tuesday 22 December 2020 16:20:46 CET Kalle Valo wrote: > Jerome Pouiller writes: > > > --- /dev/null > > +++ b/drivers/net/wireless/silabs/wfx/hif_api_general.h > > @@ -0,0 +1,267 @@ > > +/* SPDX-License-Identifier: Apache-2.0 */ > > +/* > > + * WFx hardware interface definitions > > + * > >

[PATCH v5 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-22 Thread Lorenzo Bianconi
Introduce xdp_prepare_buff utility routine to initialize per-descriptor xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff() in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 7 +++ drivers/net/ethernet/broadcom/b

[PATCH v5 bpf-next 0/2] introduce xdp_init_buff/xdp_prepare_buff

2020-12-22 Thread Lorenzo Bianconi
Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize xdp_buff data structure and remove duplicated code in all XDP capable drivers. Changes since v4: - fix xdp_init_buff/xdp_prepare_buff (natural order is xdp_init_buff() first and then xdp_prepare_buff()) Changes since v3

[PATCH v5 bpf-next 1/2] net: xdp: introduce xdp_init_buff utility routine

2020-12-22 Thread Lorenzo Bianconi
Introduce xdp_init_buff utility routine to initialize xdp_buff fields const over NAPI iterations (e.g. frame_sz or rxq pointer). Rely on xdp_init_buff in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c| 3 +-- drivers/net/ethernet

Re: [PATCH v3 03/24] wfx: add Makefile/Kconfig

2020-12-22 Thread Jérôme Pouiller
On Tuesday 22 December 2020 16:02:38 CET Kalle Valo wrote: > Jerome Pouiller writes: > > > From: Jérôme Pouiller > > > > Signed-off-by: Jérôme Pouiller > > [...] > > > +wfx-$(CONFIG_SPI) += bus_spi.o > > +wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdio.o > > Why this subst? And why only for MMC?

[PATCH net] net: dcb: Validate netlink message in DCB handler

2020-12-22 Thread Petr Machata
DCB uses the same handler function for both RTM_GETDCB and RTM_SETDCB messages. dcb_doit() bounces RTM_SETDCB mesasges if the user does not have the CAP_NET_ADMIN capability. However, the operation to be performed is not decided from the DCB message type, but from the DCB command. Thus DCB_CMD_*_G

Re: kernel BUG at lib/string.c:LINE! (6)

2020-12-22 Thread Linus Torvalds
On Tue, Dec 22, 2020 at 6:44 AM syzbot wrote: > > The issue was bisected to: > > commit 2f78788b55ba ("ilog2: improve ilog2 for constant arguments") That looks unlikely, although possibly some constant folding improvement might make the fortify code notice something with it. > detected buffer ov

Re: kernel BUG at lib/string.c:LINE! (6)

2020-12-22 Thread Florian Westphal
Linus Torvalds wrote: > On Tue, Dec 22, 2020 at 6:44 AM syzbot > wrote: > > > > The issue was bisected to: > > > > commit 2f78788b55ba ("ilog2: improve ilog2 for constant arguments") > > That looks unlikely, although possibly some constant folding > improvement might make the fortify code notice

Re: [PATCH v5 bpf-next 0/2] introduce xdp_init_buff/xdp_prepare_buff

2020-12-22 Thread Alexander Duyck
On Tue, Dec 22, 2020 at 1:09 PM Lorenzo Bianconi wrote: > > Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize > xdp_buff data structure and remove duplicated code in all XDP capable > drivers. > > Changes since v4: > - fix xdp_init_buff/xdp_prepare_buff (natural order is

[PATCH nf] netfilter: xt_RATEEST: reject non-null terminated string from userspace

2020-12-22 Thread Florian Westphal
syzbot reports: detected buffer overflow in strlen [..] Call Trace: strlen include/linux/string.h:325 [inline] strlcpy include/linux/string.h:348 [inline] xt_rateest_tg_checkentry+0x2a5/0x6b0 net/netfilter/xt_RATEEST.c:143 strlcpy assumes src is a c-string. Check info->name before its used. Re

[PATCH 0/4] Add support for Qualcomm QCA807x PHYs

2020-12-22 Thread Robert Marko
This patch series adds support for Qualcomm QCA807x PHYs. These are really common companion PHYs on boards featuring Qualcomm IPQ40xx, IPQ60xx and IPQ807x SoCs. They are 2 or 5 port IEEE 802.3 clause 22 compliant 10BASE-Te, 100BASE-TX and 1000BASE-T PHY-s. They feature 2 SerDes, one for PSGMII o

[PATCH 1/4] dt-bindings: net: Add QCA807x PHY

2020-12-22 Thread Robert Marko
Add DT bindings for Qualcomm QCA807x PHY series. Signed-off-by: Robert Marko Cc: Luka Perkov --- include/dt-bindings/net/qcom-qca807x.h | 45 ++ 1 file changed, 45 insertions(+) create mode 100644 include/dt-bindings/net/qcom-qca807x.h diff --git a/include/dt-bindings/

[PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x

2020-12-22 Thread Robert Marko
Add DT bindings for Qualcomm QCA807x PHYs. Signed-off-by: Robert Marko Cc: Luka Perkov --- .../devicetree/bindings/net/qcom,qca807x.yaml | 88 +++ 1 file changed, 88 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/qcom,qca807x.yaml diff --git a/Documenta

[PATCH 3/4] net: phy: Add Qualcomm QCA807x driver

2020-12-22 Thread Robert Marko
This adds driver for the Qualcomm QCA8072 and QCA8075 PHY-s. They are 2 or 5 port IEEE 802.3 clause 22 compliant 10BASE-Te, 100BASE-TX and 1000BASE-T PHY-s. They feature 2 SerDes, one for PSGMII or QSGMII connection with MAC, while second one is SGMII for connection to MAC or fiber. Both models

[PATCH 4/4] MAINTAINERS: Add entry for Qualcomm QCA807x PHY driver

2020-12-22 Thread Robert Marko
Add maintainers entry for the Qualcomm QCA807x PHY driver. Signed-off-by: Robert Marko Cc: Luka Perkov --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 281de213ef47..a86731f86292 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14546,6 +

Re: [PATCH 01/12 v2 RFC] net: group skb_shinfo zerocopy related bits together.

2020-12-22 Thread Willem de Bruijn
On Tue, Dec 22, 2020 at 12:22 PM Jonathan Lemon wrote: > > On Tue, Dec 22, 2020 at 09:43:15AM -0500, Willem de Bruijn wrote: > > On Mon, Dec 21, 2020 at 7:09 PM Jonathan Lemon > > wrote: > > > > > > From: Jonathan Lemon > > > > > > In preparation for expanded zerocopy (TX and RX), move > > > th

Re: [PATCH nf] netfilter: xt_RATEEST: reject non-null terminated string from userspace

2020-12-22 Thread Linus Torvalds
On Tue, Dec 22, 2020 at 2:24 PM Florian Westphal wrote: > > strlcpy assumes src is a c-string. Check info->name before its used. If strlcpy is the only problem, then the fix is to use strscpy(), which doesn't have the design mistake that strlcpy has. Of course, if the size limit of the source an

Re: [PATCH] virtio_net: Fix recursive call to cpus_read_lock()

2020-12-22 Thread Michael S. Tsirkin
On Mon, Dec 21, 2020 at 10:36:48PM -0500, Jeff Dike wrote: > virtnet_set_channels can recursively call cpus_read_lock if CONFIG_XPS > and CONFIG_HOTPLUG are enabled. > > The path is: > virtnet_set_channels - calls get_online_cpus(), which is a trivial > wrapper around cpus_read_lock() > ne

Re: [PATCH 3/3] ath10k: Set wiphy flag to trigger sta disconnect on hardware restart

2020-12-22 Thread Abhishek Kumar
On Tue, Dec 15, 2020 at 9:24 AM Youghandhar Chintala wrote: > > From: Rakesh Pillai > > Currently after the hardware restart triggered from the driver, > the station interface connection remains intact, since a disconnect > trigger is not sent to userspace. This can lead to a problem in > hardwar

Re: [PATCH 05/12 v2 RFC] skbuff: replace sock_zerocopy_put() with skb_zcopy_put()

2020-12-22 Thread Willem de Bruijn
On Tue, Dec 22, 2020 at 12:19 PM Jonathan Lemon wrote: > > On Tue, Dec 22, 2020 at 09:42:40AM -0500, Willem de Bruijn wrote: > > On Mon, Dec 21, 2020 at 7:09 PM Jonathan Lemon > > wrote: > > > > > > From: Jonathan Lemon > > > > > > Replace sock_zerocopy_put with the generic skb_zcopy_put() > >

Re: [PATCH 04/12 v2 RFC] skbuff: Push status and refcounts into sock_zerocopy_callback

2020-12-22 Thread Willem de Bruijn
On Tue, Dec 22, 2020 at 12:48 PM Jonathan Lemon wrote: > > On Tue, Dec 22, 2020 at 09:43:39AM -0500, Willem de Bruijn wrote: > > On Mon, Dec 21, 2020 at 7:09 PM Jonathan Lemon > > wrote: > > > > > > From: Jonathan Lemon > > > > > > Before this change, the caller of sock_zerocopy_callback would

Re: [PATCH 01/12 v2 RFC] net: group skb_shinfo zerocopy related bits together.

2020-12-22 Thread Jonathan Lemon
On Tue, Dec 22, 2020 at 05:26:15PM -0500, Willem de Bruijn wrote: > On Tue, Dec 22, 2020 at 12:22 PM Jonathan Lemon > wrote: > > > > On Tue, Dec 22, 2020 at 09:43:15AM -0500, Willem de Bruijn wrote: > > > On Mon, Dec 21, 2020 at 7:09 PM Jonathan Lemon > > > wrote: > > > > > > > > From: Jonathan

Re: [PATCH nf] netfilter: xt_RATEEST: reject non-null terminated string from userspace

2020-12-22 Thread Florian Westphal
Linus Torvalds wrote: > On Tue, Dec 22, 2020 at 2:24 PM Florian Westphal wrote: > > > > strlcpy assumes src is a c-string. Check info->name before its used. > > If strlcpy is the only problem, then the fix is to use strscpy(), > which doesn't have the design mistake that strlcpy has. It would s

Re: [PATCH 01/12 v2 RFC] net: group skb_shinfo zerocopy related bits together.

2020-12-22 Thread Willem de Bruijn
On Tue, Dec 22, 2020 at 5:40 PM Jonathan Lemon wrote: > > On Tue, Dec 22, 2020 at 05:26:15PM -0500, Willem de Bruijn wrote: > > On Tue, Dec 22, 2020 at 12:22 PM Jonathan Lemon > > wrote: > > > > > > On Tue, Dec 22, 2020 at 09:43:15AM -0500, Willem de Bruijn wrote: > > > > On Mon, Dec 21, 2020 at

Re: [PATCH bpf] selftests/bpf: work-around EBUSY errors from hashmap update/delete

2020-12-22 Thread Song Liu
> On Dec 22, 2020, at 11:53 AM, Andrii Nakryiko wrote: > > 20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked") introduced > a possibility of getting EBUSY error on lock contention, which seems to happen > very deterministically in test_maps when running 1024 threads on low-CPU > machi

Re: [PATCH bpf] selftests/bpf: work-around EBUSY errors from hashmap update/delete

2020-12-22 Thread Andrii Nakryiko
On Tue, Dec 22, 2020 at 3:58 PM Song Liu wrote: > > > > > On Dec 22, 2020, at 11:53 AM, Andrii Nakryiko wrote: > > > > 20b6cc34ea74 ("bpf: Avoid hashtab deadlock with map_locked") introduced > > a possibility of getting EBUSY error on lock contention, which seems to > > happen > > very determini

Re: [PATCH 2/4] dt-bindings: net: Add bindings for Qualcomm QCA807x

2020-12-22 Thread Andrew Lunn
> + gpio-controller: true > + "#gpio-cells": > +const: 2 > + > + qcom,single-led-1000: > +description: | > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > + This is a workround for boards with a single LED instead of two. > +type: boolean > + > + qco

UBSAN: shift-out-of-bounds in sfq_init

2020-12-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a409ed15 Merge tag 'gpio-v5.11-1' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=164f512350 kernel config: https://syzkaller.appspot.com/x/.config?x=f7c39e7211134bc0 das

Re: [PATCH 3/4] net: phy: Add Qualcomm QCA807x driver

2020-12-22 Thread Andrew Lunn
> +++ b/drivers/net/phy/Kconfig > @@ -264,6 +264,16 @@ config QSEMI_PHY > help > Currently supports the qs6612 > > +config QCA807X_PHY > + tristate "Qualcomm QCA807X PHYs" Kconfig is sorted based on the tristate string. So this should be after AT803X_PHY. > + depends on OF

[PATCH wireless v2 -next] wcn36xx: Remove unnecessary memset

2020-12-22 Thread Zheng Yongjun
memcpy operation is next to memset code, and the size to copy is equals to the size to memset, so the memset operation is unnecessary, remove it. Signed-off-by: Zheng Yongjun --- drivers/net/wireless/ath/wcn36xx/smd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/w

[PATCH AUTOSEL 5.10 050/217] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2020-12-22 Thread Sasha Levin
From: Marek Vasut [ Upstream commit 65277100caa2f2c62b6f3c4648b90d6f0435f3bc ] In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fails. The former is using wpa_supplicant during association, the later is set up using hostapd: iwl$ cat hostapd.conf int

[PATCH AUTOSEL 5.4 107/130] iwlwifi: validate MPDU length against notification length

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit efc0ec5afb6e1488b3bdc4bbf85533d79d7e5f9f ] The MPDU contained in a notification shouldn't be larger than the notification size itself is, validate this. Reported-by: Haggai Abramovsky Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https:/

[PATCH AUTOSEL 4.19 57/87] bridge: switchdev: Notify about VLAN protocol changes

2020-12-22 Thread Sasha Levin
From: Danielle Ratson [ Upstream commit 22ec19f3aee327806c37c9fa1188741574bc6445 ] Drivers that support bridge offload need to be notified about changes to the bridge's VLAN protocol so that they could react accordingly and potentially veto the change. Add a new switchdev attribute to communica

[PATCH AUTOSEL 5.4 118/130] cfg80211: Save the regulatory domain when setting custom regulatory

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit beee246951571cc5452176f3dbfe9aa5a10ba2b9 ] When custom regulatory was set, only the channels setting was updated, but the regulatory domain was not saved. Fix it by saving it. Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho Link: https://lore.kernel.org/

[PATCH AUTOSEL 4.19 84/87] mac80211: Update rate control on channel change

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit 44b72ca8163b8cf94384a11fdec716f5478411bf ] A channel change or a channel bandwidth change can impact the rate control logic. However, the rate control logic was not updated before/after such a change, which might result in unexpected behavior. Fix this by updat

[PATCH AUTOSEL 4.14 17/66] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer

2020-12-22 Thread Sasha Levin
From: Alexander Lobakin [ Upstream commit 8be33ecfc1ffd2da20cc29e957e4cb6eb99310cb ] Similar to commit fda55eca5a33f ("net: introduce skb_transport_header_was_set()"), avoid resetting transport offsets that were already set by GRO layer. This not only mirrors the behavior of __netif_receive_skb_

[PATCH AUTOSEL 4.9 23/48] rxrpc: Don't leak the service-side session key to userspace

2020-12-22 Thread Sasha Levin
From: David Howells [ Upstream commit d2ae4e918218f543214fbd906db68a6c580efbbb ] Don't let someone reading a service-side rxrpc-type key get access to the session key that was exchanged with the client. The server application will, at some point, need to be able to read the information in the t

[PATCH AUTOSEL 4.4 11/38] Bluetooth: hidp: use correct wait queue when removing ctrl_wait

2020-12-22 Thread Sasha Levin
From: Ole Bjørn Midtbø [ Upstream commit cca342d98bef68151a80b024f7bf5f388d1fbdea ] A different wait queue was used when removing ctrl_wait than when adding it. This effectively made the remove operation without locking compared to other operations on the wait queue ctrl_wait was part of. This c

[PATCH AUTOSEL 4.9 30/48] brcmsmac: ampdu: Check BA window size before checking block ack

2020-12-22 Thread Sasha Levin
From: Dmitry Safonov [ Upstream commit 01c195de620bb6c3ecda0dbf295fe685d8232e10 ] bindex can be out of BA window (64): tid 0 seq 2983, start_seq 2915, bindex 68, index 39 tid 0 seq 2984, start_seq 2915, bindex 69, index 40 tid 0 seq 2985, start_seq 2915, bindex 70, index 41 tid 0 seq 298

[PATCH AUTOSEL 4.9 37/48] mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start

2020-12-22 Thread Sasha Levin
From: Zhang Xiaohui [ Upstream commit 5c455c5ab332773464d02ba17015acdca198f03d ] mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code. Fix

[PATCH AUTOSEL 4.4 29/38] net/lapb: fix t1 timer handling for LAPB_STATE_0

2020-12-22 Thread Sasha Levin
From: Martin Schiller [ Upstream commit 62480b992ba3fb1d7260b11293aed9d6557831c7 ] 1. DTE interface changes immediately to LAPB_STATE_1 and start sending SABM(E). 2. DCE interface sends N2-times DM and changes to LAPB_STATE_1 afterwards if there is no response in the meantime. Signed-off

[PATCH AUTOSEL 4.4 25/38] brcmsmac: ampdu: Check BA window size before checking block ack

2020-12-22 Thread Sasha Levin
From: Dmitry Safonov [ Upstream commit 01c195de620bb6c3ecda0dbf295fe685d8232e10 ] bindex can be out of BA window (64): tid 0 seq 2983, start_seq 2915, bindex 68, index 39 tid 0 seq 2984, start_seq 2915, bindex 69, index 40 tid 0 seq 2985, start_seq 2915, bindex 70, index 41 tid 0 seq 298

[PATCH AUTOSEL 4.9 44/48] mac80211: Fix calculation of minimal channel width

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit bbf31e88df2f5da20ce613c340ce508d732046b3 ] When calculating the minimal channel width for channel context, the current operation Rx channel width of a station was used and not the overall channel width capability of the station, i.e., both for Tx and Rx. Fix ie

[PATCH AUTOSEL 4.4 36/38] mac80211: don't filter out beacons once we start CSA

2020-12-22 Thread Sasha Levin
From: Emmanuel Grumbach [ Upstream commit 189a164d0fc6c59a22c4486d641d0a0a0d33387a ] I hit a bug in which we started a CSA with an action frame, but the AP changed its mind and didn't change the beacon. The CSA wasn't cancelled and we lost the connection. The beacons were ignored because they n

[PATCH AUTOSEL 4.4 21/38] rxrpc: Don't leak the service-side session key to userspace

2020-12-22 Thread Sasha Levin
From: David Howells [ Upstream commit d2ae4e918218f543214fbd906db68a6c580efbbb ] Don't let someone reading a service-side rxrpc-type key get access to the session key that was exchanged with the client. The server application will, at some point, need to be able to read the information in the t

[PATCH AUTOSEL 4.9 34/48] net/lapb: fix t1 timer handling for LAPB_STATE_0

2020-12-22 Thread Sasha Levin
From: Martin Schiller [ Upstream commit 62480b992ba3fb1d7260b11293aed9d6557831c7 ] 1. DTE interface changes immediately to LAPB_STATE_1 and start sending SABM(E). 2. DCE interface sends N2-times DM and changes to LAPB_STATE_1 afterwards if there is no response in the meantime. Signed-off

[PATCH AUTOSEL 4.4 35/38] mac80211: disallow band-switch during CSA

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 3660944a37ce73890292571f44f04891834f9044 ] If the AP advertises a band switch during CSA, we will not have the right information to continue working with it, since it will likely (have to) change its capabilities and we don't track any capability changes at

[PATCH AUTOSEL 4.9 39/48] iwlwifi: trans: consider firmware dead after errors

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 152fdc0f698896708f9d7889a4ba4da6944b74f7 ] If we get an error, no longer consider the firmware to be in IWL_TRANS_FW_ALIVE state. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20201209231352.a9d01e79c1c7.

[PATCH AUTOSEL 4.4 33/38] iwlwifi: trans: consider firmware dead after errors

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 152fdc0f698896708f9d7889a4ba4da6944b74f7 ] If we get an error, no longer consider the firmware to be in IWL_TRANS_FW_ALIVE state. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20201209231352.a9d01e79c1c7.

[PATCH AUTOSEL 4.4 34/38] iwlwifi: add an extra firmware state in the transport

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit b2ed841ed070ccbe908016537f429a3a8f0221bf ] Start tracking not just if the firmware is dead or alive, but also if it's starting. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20201209231352.33e50d40b688.I8

[PATCH AUTOSEL 4.4 03/38] staging: wimax: depends on NET

2020-12-22 Thread Sasha Levin
From: Randy Dunlap [ Upstream commit 9364a2cf567187c0a075942c22d1f434c758de5d ] Fix build errors when CONFIG_NET is not enabled. E.g. (trimmed): ld: drivers/staging/wimax/op-msg.o: in function `wimax_msg_alloc': op-msg.c:(.text+0xa9): undefined reference to `__alloc_skb' ld: op-msg.c:(.text+0xc

[PATCH AUTOSEL 4.4 31/38] mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start

2020-12-22 Thread Sasha Levin
From: Zhang Xiaohui [ Upstream commit 5c455c5ab332773464d02ba17015acdca198f03d ] mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code. Fix

[PATCH AUTOSEL 4.9 46/48] mac80211: Update rate control on channel change

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit 44b72ca8163b8cf94384a11fdec716f5478411bf ] A channel change or a channel bandwidth change can impact the rate control logic. However, the rate control logic was not updated before/after such a change, which might result in unexpected behavior. Fix this by updat

[PATCH AUTOSEL 4.9 45/48] mac80211: don't filter out beacons once we start CSA

2020-12-22 Thread Sasha Levin
From: Emmanuel Grumbach [ Upstream commit 189a164d0fc6c59a22c4486d641d0a0a0d33387a ] I hit a bug in which we started a CSA with an action frame, but the AP changed its mind and didn't change the beacon. The CSA wasn't cancelled and we lost the connection. The beacons were ignored because they n

[PATCH AUTOSEL 4.9 41/48] nl80211: always accept scan request with the duration set

2020-12-22 Thread Sasha Levin
From: Avraham Stern [ Upstream commit c837cbad40d949feaff86734d637c7602ae0b56b ] Accept a scan request with the duration set even if the driver does not support setting the scan dwell. The duration can be used as a hint to the driver, but the driver may use its internal logic for setting the sca

[PATCH AUTOSEL 4.4 12/38] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer

2020-12-22 Thread Sasha Levin
From: Alexander Lobakin [ Upstream commit 8be33ecfc1ffd2da20cc29e957e4cb6eb99310cb ] Similar to commit fda55eca5a33f ("net: introduce skb_transport_header_was_set()"), avoid resetting transport offsets that were already set by GRO layer. This not only mirrors the behavior of __netif_receive_skb_

[PATCH AUTOSEL 4.9 43/48] mac80211: disallow band-switch during CSA

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 3660944a37ce73890292571f44f04891834f9044 ] If the AP advertises a band switch during CSA, we will not have the right information to continue working with it, since it will likely (have to) change its capabilities and we don't track any capability changes at

Re: [PATCH] virtio_net: Fix recursive call to cpus_read_lock()

2020-12-22 Thread Jakub Kicinski
On Tue, 22 Dec 2020 11:49:04 +0800 Jason Wang wrote: > On 2020/12/22 上午11:36, Jeff Dike wrote: > > virtnet_set_channels can recursively call cpus_read_lock if CONFIG_XPS > > and CONFIG_HOTPLUG are enabled. > > > > The path is: > > virtnet_set_channels - calls get_online_cpus(), which is a triv

Re: [PATCH] net/ncsi: Use real net-device for response handler

2020-12-22 Thread Jakub Kicinski
On Tue, 22 Dec 2020 10:38:21 -0800 Samuel Mendoza-Jonas wrote: > On Tue, 2020-12-22 at 06:13 +, Joel Stanley wrote: > > On Sun, 20 Dec 2020 at 12:40, John Wang wrote: > > > When aggregating ncsi interfaces and dedicated interfaces to bond > > > interfaces, the ncsi response handler will use the

[PATCH AUTOSEL 4.9 40/48] iwlwifi: add an extra firmware state in the transport

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit b2ed841ed070ccbe908016537f429a3a8f0221bf ] Start tracking not just if the firmware is dead or alive, but also if it's starting. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20201209231352.33e50d40b688.I8

[PATCH AUTOSEL 4.9 13/48] net: skb_vlan_untag(): don't reset transport offset if set by GRO layer

2020-12-22 Thread Sasha Levin
From: Alexander Lobakin [ Upstream commit 8be33ecfc1ffd2da20cc29e957e4cb6eb99310cb ] Similar to commit fda55eca5a33f ("net: introduce skb_transport_header_was_set()"), avoid resetting transport offsets that were already set by GRO layer. This not only mirrors the behavior of __netif_receive_skb_

[PATCH AUTOSEL 4.9 42/48] cfg80211: Save the regulatory domain when setting custom regulatory

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit beee246951571cc5452176f3dbfe9aa5a10ba2b9 ] When custom regulatory was set, only the channels setting was updated, but the regulatory domain was not saved. Fix it by saving it. Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho Link: https://lore.kernel.org/

[PATCH AUTOSEL 4.9 12/48] Bluetooth: hidp: use correct wait queue when removing ctrl_wait

2020-12-22 Thread Sasha Levin
From: Ole Bjørn Midtbø [ Upstream commit cca342d98bef68151a80b024f7bf5f388d1fbdea ] A different wait queue was used when removing ctrl_wait than when adding it. This effectively made the remove operation without locking compared to other operations on the wait queue ctrl_wait was part of. This c

[PATCH AUTOSEL 4.14 55/66] iwlwifi: trans: consider firmware dead after errors

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 152fdc0f698896708f9d7889a4ba4da6944b74f7 ] If we get an error, no longer consider the firmware to be in IWL_TRANS_FW_ALIVE state. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20201209231352.a9d01e79c1c7.

[PATCH AUTOSEL 4.19 80/87] mac80211: support Rx timestamp calculation for all preamble types

2020-12-22 Thread Sasha Levin
From: Avraham Stern [ Upstream commit da3882331a55ba8c8eda0cfc077ad3b88c257e22 ] Add support for calculating the Rx timestamp for HE frames. Since now all frame types are supported, allow setting the Rx timestamp regardless of the frame type. Signed-off-by: Avraham Stern Signed-off-by: Luca Co

[PATCH AUTOSEL 4.19 74/87] iwlwifi: add an extra firmware state in the transport

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit b2ed841ed070ccbe908016537f429a3a8f0221bf ] Start tracking not just if the firmware is dead or alive, but also if it's starting. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20201209231352.33e50d40b688.I8

[PATCH AUTOSEL 4.19 79/87] mac80211: disallow band-switch during CSA

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 3660944a37ce73890292571f44f04891834f9044 ] If the AP advertises a band switch during CSA, we will not have the right information to continue working with it, since it will likely (have to) change its capabilities and we don't track any capability changes at

[PATCH AUTOSEL 4.14 60/66] cfg80211: Save the regulatory domain when setting custom regulatory

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit beee246951571cc5452176f3dbfe9aa5a10ba2b9 ] When custom regulatory was set, only the channels setting was updated, but the regulatory domain was not saved. Fix it by saving it. Signed-off-by: Ilan Peer Signed-off-by: Luca Coelho Link: https://lore.kernel.org/

[PATCH AUTOSEL 4.19 82/87] mac80211: Fix calculation of minimal channel width

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit bbf31e88df2f5da20ce613c340ce508d732046b3 ] When calculating the minimal channel width for channel context, the current operation Rx channel width of a station was used and not the overall channel width capability of the station, i.e., both for Tx and Rx. Fix ie

[PATCH AUTOSEL 4.9 04/48] staging: wimax: depends on NET

2020-12-22 Thread Sasha Levin
From: Randy Dunlap [ Upstream commit 9364a2cf567187c0a075942c22d1f434c758de5d ] Fix build errors when CONFIG_NET is not enabled. E.g. (trimmed): ld: drivers/staging/wimax/op-msg.o: in function `wimax_msg_alloc': op-msg.c:(.text+0xa9): undefined reference to `__alloc_skb' ld: op-msg.c:(.text+0xc

[PATCH AUTOSEL 4.14 64/66] mac80211: Update rate control on channel change

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit 44b72ca8163b8cf94384a11fdec716f5478411bf ] A channel change or a channel bandwidth change can impact the rate control logic. However, the rate control logic was not updated before/after such a change, which might result in unexpected behavior. Fix this by updat

[PATCH AUTOSEL 4.14 40/66] hv_netvsc: Validate number of allocated sub-channels

2020-12-22 Thread Sasha Levin
From: "Andrea Parri (Microsoft)" [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ] Lack of validation could lead to out-of-bound reads and information leaks (cf. usage of nvdev->chan_table[]). Check that the number of allocated sub-channels fits into the expected range. Suggested-by

[PATCH AUTOSEL 4.14 62/66] mac80211: Fix calculation of minimal channel width

2020-12-22 Thread Sasha Levin
From: Ilan Peer [ Upstream commit bbf31e88df2f5da20ce613c340ce508d732046b3 ] When calculating the minimal channel width for channel context, the current operation Rx channel width of a station was used and not the overall channel width capability of the station, i.e., both for Tx and Rx. Fix ie

[PATCH AUTOSEL 4.14 59/66] nl80211: always accept scan request with the duration set

2020-12-22 Thread Sasha Levin
From: Avraham Stern [ Upstream commit c837cbad40d949feaff86734d637c7602ae0b56b ] Accept a scan request with the duration set even if the driver does not support setting the scan dwell. The duration can be used as a hint to the driver, but the driver may use its internal logic for setting the sca

[PATCH AUTOSEL 4.14 63/66] mac80211: don't filter out beacons once we start CSA

2020-12-22 Thread Sasha Levin
From: Emmanuel Grumbach [ Upstream commit 189a164d0fc6c59a22c4486d641d0a0a0d33387a ] I hit a bug in which we started a CSA with an action frame, but the AP changed its mind and didn't change the beacon. The CSA wasn't cancelled and we lost the connection. The beacons were ignored because they n

[PATCH AUTOSEL 4.14 48/66] bridge: switchdev: Notify about VLAN protocol changes

2020-12-22 Thread Sasha Levin
From: Danielle Ratson [ Upstream commit 22ec19f3aee327806c37c9fa1188741574bc6445 ] Drivers that support bridge offload need to be notified about changes to the bridge's VLAN protocol so that they could react accordingly and potentially veto the change. Add a new switchdev attribute to communica

[PATCH AUTOSEL 4.14 56/66] iwlwifi: add an extra firmware state in the transport

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit b2ed841ed070ccbe908016537f429a3a8f0221bf ] Start tracking not just if the firmware is dead or alive, but also if it's starting. Signed-off-by: Johannes Berg Signed-off-by: Luca Coelho Link: https://lore.kernel.org/r/iwlwifi.20201209231352.33e50d40b688.I8

[PATCH AUTOSEL 4.14 61/66] mac80211: disallow band-switch during CSA

2020-12-22 Thread Sasha Levin
From: Johannes Berg [ Upstream commit 3660944a37ce73890292571f44f04891834f9044 ] If the AP advertises a band switch during CSA, we will not have the right information to continue working with it, since it will likely (have to) change its capabilities and we don't track any capability changes at

[PATCH AUTOSEL 4.14 53/66] mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start

2020-12-22 Thread Sasha Levin
From: Zhang Xiaohui [ Upstream commit 5c455c5ab332773464d02ba17015acdca198f03d ] mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code. Fix

[PATCH AUTOSEL 4.14 39/66] brcmsmac: ampdu: Check BA window size before checking block ack

2020-12-22 Thread Sasha Levin
From: Dmitry Safonov [ Upstream commit 01c195de620bb6c3ecda0dbf295fe685d8232e10 ] bindex can be out of BA window (64): tid 0 seq 2983, start_seq 2915, bindex 68, index 39 tid 0 seq 2984, start_seq 2915, bindex 69, index 40 tid 0 seq 2985, start_seq 2915, bindex 70, index 41 tid 0 seq 298

[PATCH AUTOSEL 4.14 32/66] rxrpc: Don't leak the service-side session key to userspace

2020-12-22 Thread Sasha Levin
From: David Howells [ Upstream commit d2ae4e918218f543214fbd906db68a6c580efbbb ] Don't let someone reading a service-side rxrpc-type key get access to the session key that was exchanged with the client. The server application will, at some point, need to be able to read the information in the t

Re: [PATCH AUTOSEL 4.4 03/38] staging: wimax: depends on NET

2020-12-22 Thread Jakub Kicinski
On Tue, 22 Dec 2020 21:24:41 -0500 Sasha Levin wrote: > From: Randy Dunlap > > [ Upstream commit 9364a2cf567187c0a075942c22d1f434c758de5d ] > > Fix build errors when CONFIG_NET is not enabled. E.g. (trimmed): This one can be dropped, before wimax moved to staging the dependency was met thru the

[PATCH AUTOSEL 4.14 45/66] net/lapb: fix t1 timer handling for LAPB_STATE_0

2020-12-22 Thread Sasha Levin
From: Martin Schiller [ Upstream commit 62480b992ba3fb1d7260b11293aed9d6557831c7 ] 1. DTE interface changes immediately to LAPB_STATE_1 and start sending SABM(E). 2. DCE interface sends N2-times DM and changes to LAPB_STATE_1 afterwards if there is no response in the meantime. Signed-off

[PATCH AUTOSEL 4.14 18/66] mwifiex: pcie: skip cancel_work_sync() on reset failure path

2020-12-22 Thread Sasha Levin
From: Tsuchiya Yuto [ Upstream commit 4add4d988f95f47493500a7a19c623827061589b ] If a reset is performed, but even the reset fails for some reasons (e.g., on Surface devices, the fw reset requires another quirks), cancel_work_sync() hangs in mwifiex_cleanup_pcie(). # firmware went into a ba

[PATCH AUTOSEL 4.19 77/87] nl80211: always accept scan request with the duration set

2020-12-22 Thread Sasha Levin
From: Avraham Stern [ Upstream commit c837cbad40d949feaff86734d637c7602ae0b56b ] Accept a scan request with the duration set even if the driver does not support setting the scan dwell. The duration can be used as a hint to the driver, but the driver may use its internal logic for setting the sca

<    1   2   3   >