Re: [PATCH net] net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE

2020-12-18 Thread Florian Fainelli
On 12/18/20 1:14 PM, Vladimir Oltean wrote: > On Fri, Dec 18, 2020 at 01:08:58PM -0800, Florian Fainelli wrote: >> On 12/18/20 1:02 PM, Vladimir Oltean wrote: >>> On Fri, Dec 18, 2020 at 12:54:33PM -0800, Florian Fainelli wrote: On 12/18/20 12:52 PM, Vladimir Oltean wrote: > On Fri, Dec 18

Re: [PATCH 1/1] Bluetooth: Remove hci_req_le_suspend_config

2020-12-18 Thread Marcel Holtmann
Hi Abhishek, > Add a missing SUSPEND_SCAN_ENABLE in passive scan, remove the separate > function for configuring le scan during suspend and update the request > complete function to clear both enable and disable tasks. > > Fixes: dce0a4be8054 ("Bluetooth: Set missing suspend task bits") > Reviewe

Re: [PATCH] Bluetooth: Pause service discovery for suspend

2020-12-18 Thread Marcel Holtmann
Hi Abhishek, > Just like MGMT_OP_START_DISCOVERY, we should reject > MGMT_OP_START_SERVICE_DISCOVERY with MGMT_STATUS_BUSY when we are paused > for suspend. > > Signed-off-by: Abhishek Pandit-Subedi > --- > On ChromeOS, we started getting reports of scanning failing after > resuming from suspend

Re: [PATCH v2 1/4] Bluetooth: Keep MSFT ext info throughout a hci_dev's life cycle

2020-12-18 Thread Marcel Holtmann
Hi Miao-chen, > This moves msft_do_close() from hci_dev_do_close() to > hci_unregister_dev() to avoid clearing MSFT extension info. This also > avoids retrieving MSFT info upon every msft_do_open() if MSFT extension > has been initialized. what is the actual benefit of this? It is fundamentally

[PATCH net] ionic: account for vlan tag len in rx buffer len

2020-12-18 Thread Shannon Nelson
Let the FW know we have enough receive buffer space for the vlan tag if it isn't stripped. Fixes: 0f3154e6bcb3 ("ionic: Add Tx and Rx handling") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH iproute2] tc: flower: fix json output with mpls lse

2020-12-18 Thread Guillaume Nault
The json output of the TCA_FLOWER_KEY_MPLS_OPTS attribute was invalid. Example: $ tc filter add dev eth0 ingress protocol mpls_uc flower mpls \ lse depth 1 label 100 \ lse depth 2 label 200 $ tc -json filter show dev eth0 ingress ...{"eth_t

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-18 Thread Dan Williams
On Fri, Dec 18, 2020 at 1:17 PM Alexandre Belloni wrote: > > On 18/12/2020 16:58:56-0400, Jason Gunthorpe wrote: > > On Fri, Dec 18, 2020 at 08:32:11PM +, Mark Brown wrote: > > > > > > So, I strongly suspect, MFD should create mfd devices on a MFD bus > > > > type. > > > > > > Historically peo

[RFC PATCH net-next 1/4] net: dsa: move the Broadcom tag information in a separate header file

2020-12-18 Thread Vladimir Oltean
It is a bit strange to see something as specific as Broadcom SYSTEMPORT bits in the main DSA include file. Move these away into a separate header, and have the tagger and the SYSTEMPORT driver include them. Signed-off-by: Vladimir Oltean --- MAINTAINERS| 1 + dri

[RFC PATCH net-next 0/4] Reduce coupling between DSA and Broadcom SYSTEMPORT driver

2020-12-18 Thread Vladimir Oltean
Upon a quick inspection, it seems that there is some code in the generic DSA layer that is somehow specific to the Broadcom SYSTEMPORT driver. The challenge there is that the hardware integration is very tight between the switch and the DSA master interface. However this does not mean that the driv

[RFC PATCH net-next 4/4] net: dsa: remove the DSA specific notifiers

2020-12-18 Thread Vladimir Oltean
This effectively reverts commit 60724d4bae14 ("net: dsa: Add support for DSA specific notifiers"). The reason is that since commit 2f1e8ea726e9 ("net: dsa: link interfaces with the DSA master to get rid of lockdep warnings"), it appears that there is a generic way to achieve the same purpose. The o

[RFC PATCH net-next 3/4] net: systemport: use standard netdevice notifier to detect DSA presence

2020-12-18 Thread Vladimir Oltean
The SYSTEMPORT driver maps each port of the embedded Broadcom DSA switch port to a certain queue of the master Ethernet controller. For that it currently uses a dedicated notifier infrastructure which was added in commit 60724d4bae14 ("net: dsa: Add support for DSA specific notifiers"). However, s

[RFC PATCH net-next 2/4] net: dsa: export dsa_slave_dev_check

2020-12-18 Thread Vladimir Oltean
Using the NETDEV_CHANGEUPPER notifications, drivers can be aware when they are enslaved to e.g. a bridge by calling netif_is_bridge_master(). Export this helper from DSA to get the equivalent functionality of determining whether the upper interface of a CHANGEUPPER notifier is a DSA switch interfa

Re: [PATCH iproute2 1/2] lib/fs: avoid double call to mkdir on make_path()

2020-12-18 Thread Phil Sutter
Hi Andrea, On Fri, Dec 18, 2020 at 08:09:22PM +0100, Andrea Claudi wrote: > make_path() function calls mkdir two times in a row. The first one it > stores mkdir return code, and then it calls it again to check for errno. To me it rather seems like I rebased the original commit into a mess. Or I g

Re: [PATCH iproute2 2/2] lib/fs: Fix single return points for get_cgroup2_*

2020-12-18 Thread Phil Sutter
On Fri, Dec 18, 2020 at 08:09:23PM +0100, Andrea Claudi wrote: > Functions get_cgroup2_id() and get_cgroup2_path() uncorrectly performs > cleanup on the single return point. Both of them may get to use close() > with a negative argument, if open() fails. > > Fix this adding proper labels and gotos

Re: [PATCH iproute2 2/2] lib/fs: Fix single return points for get_cgroup2_*

2020-12-18 Thread Andrea Claudi
On Sat, Dec 19, 2020 at 12:08 AM Phil Sutter wrote: > > On Fri, Dec 18, 2020 at 08:09:23PM +0100, Andrea Claudi wrote: > > Functions get_cgroup2_id() and get_cgroup2_path() uncorrectly performs > > cleanup on the single return point. Both of them may get to use close() > > with a negative argument

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-18 Thread Jason Gunthorpe
On Fri, Dec 18, 2020 at 10:16:58PM +0100, Alexandre Belloni wrote: > But then again, what about non-enumerable devices on the PCI device? I > feel this would exactly fit MFD. This is a collection of IPs that exist > as standalone but in this case are grouped in a single device. So, if mfd had a m

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-18 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: ... > >The addition of a case BOND_LINK_BACK in bond_miimon_commit() is somewhat > >separate from the fix for the actual hang, but it eliminates a constant > >"invalid new link 3 on slave" message seen related to this issu

[PATCH bpf-next 3/3] selftests/bpf: add tests for user- and non-CO-RE BPF_CORE_READ() variants

2020-12-18 Thread Andrii Nakryiko
Add selftests validating that newly added variations of BPF_CORE_READ(), for use with user-space addresses and for non-CO-RE reads, work as expected. Signed-off-by: Andrii Nakryiko --- .../bpf/prog_tests/core_read_macros.c | 64 +++ .../bpf/progs/test_core_read_macros.c

[PATCH bpf-next 0/3] Add user-space and non-CO-RE variants of BPF_CORE_READ()

2020-12-18 Thread Andrii Nakryiko
Add two sets of BPF_CORE_READ()-like macros. One is for reading kernel data from user address space (e.g., UAPI data structs for syscalls). Another one is non-CO-RE variants, which don't emit CO-RE relocations and thus won't fail on kernels without BTF. The latter one still provides much shorter wa

[PATCH bpf-next 2/3] libbpf: add non-CO-RE variants of BPF_CORE_READ() macro family

2020-12-18 Thread Andrii Nakryiko
BPF_CORE_READ(), in addition to handling CO-RE relocations, also allows much nicer way to read data structures with nested pointers. Instead of writing a sequence of bpf_probe_read() calls to follow links, one can just write BPF_CORE_READ(a, b, c, d) to effectively do a->b->c->d read. This is a wel

[PATCH bpf-next 1/3] libbpf: add user-space variants of BPF_CORE_READ() family of macros

2020-12-18 Thread Andrii Nakryiko
Add BPF_CORE_READ_USER(), BPF_CORE_READ_USER_STR() and their _INTO() variations to allow reading CO-RE-relocatable kernel data structures from the user-space. One of such cases is reading input arguments of syscalls, while reaping the benefits of CO-RE relocations w.r.t. handling 32/64 bit conversi

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-18 Thread Alexander Duyck
On Fri, Dec 18, 2020 at 12:18 PM Jason Gunthorpe wrote: > > On Fri, Dec 18, 2020 at 11:22:12AM -0800, Alexander Duyck wrote: > > > Also as far as the patch count complaints I have seen in a few threads > > I would be fine with splitting things up so that the devlink and aux > > device creation get

Re: [RFC PATCH net-next 1/4] net: dsa: move the Broadcom tag information in a separate header file

2020-12-18 Thread Florian Fainelli
On 12/18/2020 2:38 PM, Vladimir Oltean wrote: > It is a bit strange to see something as specific as Broadcom SYSTEMPORT > bits in the main DSA include file. Move these away into a separate > header, and have the tagger and the SYSTEMPORT driver include them. > > Signed-off-by: Vladimir Oltean

Re: [RFC PATCH net-next] bonding: add a vlan+srcmac tx hashing option

2020-12-18 Thread Jay Vosburgh
Jarod Wilson wrote: >This comes from an end-user request, where they're running multiple VMs on >hosts with bonded interfaces connected to some interest switch topologies, >where 802.3ad isn't an option. They're currently running a proprietary >solution that effectively achieves load-balancing of

Re: [RFC PATCH net-next 2/4] net: dsa: export dsa_slave_dev_check

2020-12-18 Thread Florian Fainelli
On 12/18/2020 2:38 PM, Vladimir Oltean wrote: > Using the NETDEV_CHANGEUPPER notifications, drivers can be aware when > they are enslaved to e.g. a bridge by calling netif_is_bridge_master(). > > Export this helper from DSA to get the equivalent functionality of > determining whether the upper

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-18 Thread Alexandre Belloni
On 18/12/2020 19:36:08-0400, Jason Gunthorpe wrote: > On Fri, Dec 18, 2020 at 10:16:58PM +0100, Alexandre Belloni wrote: > > > But then again, what about non-enumerable devices on the PCI device? I > > feel this would exactly fit MFD. This is a collection of IPs that exist > > as standalone but in

Re: [RFC PATCH net-next 4/4] net: dsa: remove the DSA specific notifiers

2020-12-18 Thread Florian Fainelli
On 12/18/2020 2:38 PM, Vladimir Oltean wrote: > This effectively reverts commit 60724d4bae14 ("net: dsa: Add support for > DSA specific notifiers"). The reason is that since commit 2f1e8ea726e9 > ("net: dsa: link interfaces with the DSA master to get rid of lockdep > warnings"), it appears that

Re: [RFC PATCH net-next 3/4] net: systemport: use standard netdevice notifier to detect DSA presence

2020-12-18 Thread Florian Fainelli
On 12/18/2020 2:38 PM, Vladimir Oltean wrote: > The SYSTEMPORT driver maps each port of the embedded Broadcom DSA switch > port to a certain queue of the master Ethernet controller. For that it > currently uses a dedicated notifier infrastructure which was added in > commit 60724d4bae14 ("net: d

Re: [PATCH net 1/4] net-sysfs: take the rtnl lock when storing xps_cpus

2020-12-18 Thread Jakub Kicinski
On Thu, 17 Dec 2020 17:25:18 +0100 Antoine Tenart wrote: > Callers to netif_set_xps_queue should take the rtnl lock. Failing to do > so can lead to race conditions between netdev_set_num_tc and > netif_set_xps_queue, triggering various oops: > > - netif_set_xps_queue uses dev->tc_num as one of the

Re: [PATCH] tcp: remove obsolete paramter sysctl_tcp_low_latency

2020-12-18 Thread Jakub Kicinski
On Fri, 18 Dec 2020 14:11:16 +0800 lyl wrote: > Remove tcp_low_latency, since it is not functional After commit > e7942d0633c4 (tcp: remove prequeue support) > > Signed-off-by: lyl I don't think we can remove sysctls, even if they no longer control the behavior of the kernel. The existence of t

Re: [net 0/2][pull request] Intel Wired LAN Driver Updates 2020-12-17

2020-12-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 17 Dec 2020 14:34:16 -0800 you wrote: > This series contains updates to i40e and iavf drivers. > > Sylwester fixes an issue where PF was not properly being rebuilt > following VF removal for i40e. > > Jakub Kicinski f

Re: [PATCH net] net/sched: sch_taprio: ensure to reset/destroy all child qdiscs

2020-12-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 17 Dec 2020 22:29:46 +0100 you wrote: > taprio_graft() can insert a NULL element in the array of child qdiscs. As > a consquence, taprio_reset() might not reset child qdiscs completely, and > taprio_destroy() might leak

Re: [PATCH net 1/4] net-sysfs: take the rtnl lock when storing xps_cpus

2020-12-18 Thread Alexander Duyck
On Fri, Dec 18, 2020 at 4:30 PM Jakub Kicinski wrote: > > On Thu, 17 Dec 2020 17:25:18 +0100 Antoine Tenart wrote: > > Callers to netif_set_xps_queue should take the rtnl lock. Failing to do > > so can lead to race conditions between netdev_set_num_tc and > > netif_set_xps_queue, triggering variou

[PATCH] staging: qlge: Removed duplicate word in comment.

2020-12-18 Thread Daniel West
This patch fixes the checkpatch warning: WARNING: Possible repeated word: 'and' Signed-off-by: Daniel West --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index e6b7baa12

Re: [PATCH net-next V9] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-12-18 Thread Jakub Kicinski
It'd be great if someone more familiar with our IPv6 code could take a look. Adding some folks to the CC. On Wed, 16 Dec 2020 23:01:29 +0100 Dmytro Shytyi wrote: > Variable SLAAC [Can be activated via sysctl]: > SLAAC with prefixes of arbitrary length in PIO (randomly > generated hostID or stable

Re: [PATCH net 1/4] netfilter: nftables: fix incorrect increment of loop counter

2020-12-18 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 18 Dec 2020 13:04:06 +0100 you wrote: > From: Colin Ian King > > The intention of the err_expr cleanup path is to iterate over the > allocated expr_array objects and free them, starting from i - 1 and > working down t

Re: [RFC PATCH net-next 3/4] net: systemport: use standard netdevice notifier to detect DSA presence

2020-12-18 Thread Florian Fainelli
On 12/18/2020 2:38 PM, Vladimir Oltean wrote: > The SYSTEMPORT driver maps each port of the embedded Broadcom DSA switch > port to a certain queue of the master Ethernet controller. For that it > currently uses a dedicated notifier infrastructure which was added in > commit 60724d4bae14 ("net: d

RE: [net-next v5 03/15] devlink: Introduce PCI SF port flavour and port attribute

2020-12-18 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Saturday, December 19, 2020 1:18 AM > So the SF is always created from the eswitch controller side? > How does the host side look? > Host side creates the auxiliary device for the SF. $ ls -l /sys/bus/auxiliary/devices/ mlx5_core.sf.4 -> ../../../devices/pci

RE: [net-next v5 07/15] net/mlx5: SF, Add auxiliary device support

2020-12-18 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Saturday, December 19, 2020 1:29 AM > > On Thu, 17 Dec 2020 05:23:10 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Thursday, December 17, 2020 5:42 AM > > > > > > On Wed, 16 Dec 2020 05:19:15 + Parav Pandit wrote: > > > > > From: Jakub Kic

RE: [net-next v5 05/15] devlink: Support get and set state of port function

2020-12-18 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Saturday, December 19, 2020 1:21 AM > > On Thu, 17 Dec 2020 05:46:45 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Thursday, December 17, 2020 5:39 AM > > > > > > On Wed, 16 Dec 2020 05:15:04 + Parav Pandit wrote: > > > > > From: Jakub Kici

Re: KASAN: slab-out-of-bounds Read in lock_sock_nested

2020-12-18 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:a409ed15 Merge tag 'gpio-v5.11-1' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=174778a750 kernel config: https://syzkaller.appspot.com/x/.config?x=20efebc

<    1   2