Re: [PATCH net-next v2 01/12] gtp: set initial MTU

2020-12-12 Thread Harald Welte
On Fri, Dec 11, 2020 at 01:26:01PM +0100, Jonas Bonn wrote: > The GTP link is brought up with a default MTU of zero. This can lead to > some rather unexpected behaviour for users who are more accustomed to > interfaces coming online with reasonable defaults. > > This patch sets an initial MTU for

Re: [PATCH] net: check skb partial checksum offset after trim

2020-12-12 Thread Vasily Averin
On 12/11/20 6:37 PM, Vasily Averin wrote: > It seems for me the similar problem can happen in __skb_trim_rcsum(). > Also I doubt that that skb_checksum_start_offset(skb) checks in > __skb_postpull_rcsum() and skb_csum_unnecessary() are correct, > becasue they do not guarantee that skb have correct

Re: [kbuild-all] Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-12 Thread Philip Li
On Thu, Dec 10, 2020 at 12:41:32PM +, Geva, Erez wrote: > > On 10/12/2020 04:11, kernel test robot wrote: > > Hi Erez, > > > > Thank you for the patch! Yet something to improve: > > > Thanks for the robot, > as we rarely use clang for kernel. It is very helpful. > > > [auto build test ERROR

Re: [PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop

2020-12-12 Thread Harald Welte
On Fri, Dec 11, 2020 at 01:26:04PM +0100, Jonas Bonn wrote: > The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). I must be blind, can you please point out where exactly this happens? I don't see any skb_dst_drop in udp_tunnel_xmit_skb, and in iptunnel_xmit() there's only a

Re: [PATCH net-next v2 05/12] gtp: set device type

2020-12-12 Thread Harald Welte
On Fri, Dec 11, 2020 at 01:26:05PM +0100, Jonas Bonn wrote: > Set the devtype to 'gtp' when setting up the link. > > Signed-off-by: Jonas Bonn Acked-by: Harald Welte -- - Harald Weltehttp://laforge.gnumonks.org/ =

INFO: task can't die in connmark_exit_net

2020-12-12 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:15ac8fdb Add linux-next specific files for 20201207 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=15fbf86b50 kernel config: https://syzkaller.appspot.com/x/.config?x=3696b8138207d24d dashboard

Re: [PATCH net-next v2 03/12] gtp: really check namespaces before xmit

2020-12-12 Thread Harald Welte
On Fri, Dec 11, 2020 at 01:26:03PM +0100, Jonas Bonn wrote: > Blindly assuming that packet transmission crosses namespaces results in > skb marks being lost in the single namespace case. > > Signed-off-by: Jonas Bonn Acked-by: Harald Welte -- - Harald Weltehttp://laforge.gnumonks.

Re: [PATCH net-next v2 10/12] gtp: add IPv6 support

2020-12-12 Thread Jonas Bonn
Hi Pravin, On 12/12/2020 06:51, Pravin Shelar wrote: On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote: This patch adds support for handling IPv6. Both the GTP tunnel and the tunneled packets may be IPv6; as they constitute independent streams, both v4-over-v6 and v6-over-v4 are supported, as

Re: [PATCH net-next v2 02/12] gtp: include role in link info

2020-12-12 Thread Harald Welte
Hi Jonas, On Fri, Dec 11, 2020 at 01:26:02PM +0100, Jonas Bonn wrote: > Querying link info for the GTP interface doesn't reveal in which "role" the > device is set to operate. Include this information in the info query > result. > > Signed-off-by: Jonas Bonn Acked-by: Harald Welte -- - Hara

Re: [PATCH net-next v2 08/12] gtp: set dev features to enable GSO

2020-12-12 Thread Jonas Bonn
On 12/12/2020 06:31, Pravin Shelar wrote: On Fri, Dec 11, 2020 at 4:28 AM Jonas Bonn wrote: Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 236ebbcb37bf..7bbeec173113 1

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-12 Thread Harald Welte
Hi Jonas, On Fri, Dec 11, 2020 at 01:26:07PM +0100, Jonas Bonn wrote: > From 3GPP TS 29.281: > "...the UDP Source Port or the Flow Label field... should be set dynamically > by the sending GTP-U entity to help balancing the load in the transport > network." You unfortuantely didn't specifiy which

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Yonatan Linik
On Fri, Dec 11, 2020 at 11:00 PM Arnd Bergmann wrote: > > Another option would be to just ignore the return code here > and continue without a procfs file, regardless of whether procfs > is enabled or not. > >Arnd Yes I thought about that, but I didn't want to make changes to the way it b

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-12 Thread Jonas Bonn
On 12/12/2020 06:35, Pravin Shelar wrote: On Fri, Dec 11, 2020 at 4:29 AM Jonas Bonn wrote: /* Read the IP destination address and resolve the PDP context. @@ -527,6 +527,10 @@ static int gtp_xmit_ip4(struct sk_buff *skb, struct net_device *dev) return -EMSGSIZE;

[PATCH] xfrm: redact SA secret with lockdown confidentiality

2020-12-12 Thread Steffen Klassert
From: Antony Antony redact XFRM SA secret in the netlink response to xfrm_get_sa() or dumpall sa. Enable lockdown, confidentiality mode, at boot or at run time. e.g. when enabled: cat /sys/kernel/security/lockdown none integrity [confidentiality] ip xfrm state src 172.16.1.200 dst 172.16.1.100

pull request (net-next): ipsec-next 2020-12-12

2020-12-12 Thread Steffen Klassert
Just one patch this time: 1) Redact the SA keys with kernel lockdown confidentiality. If enabled, no secret keys are sent to uuserspace. From Antony Antony. Please pull or let me know if there are problems. Thanks! The following changes since commit 8be33ecfc1ffd2da20cc29e957e4cb6eb99310c

Re: [PATCH net-next v2 10/12] gtp: add IPv6 support

2020-12-12 Thread Harald Welte
Hi Jonas, On Sat, Dec 12, 2020 at 08:05:40AM +0100, Jonas Bonn wrote: > Yes, you're probably right. Given that IPv6 isn't really optional in > contexts where this driver is relevant, [...] I strongly contest this statement. GTP is used in a lot of legacy contexts without any IPv6 requirements wh

Re: [PATCH net-next v2 11/12] gtp: netlink update for ipv6

2020-12-12 Thread Harald Welte
On Fri, Dec 11, 2020 at 01:26:11PM +0100, Jonas Bonn wrote: > This patch adds the netlink changes required to support IPv6. See my related comment to the other IPv6 patch in this series. It is not legal to assume that v4/v6 are an either-or decision, but it can be either v4-only, v6-only or v4 an

Re: [PATCH net-next v2 04/12] gtp: drop unnecessary call to skb_dst_drop

2020-12-12 Thread Jonas Bonn
On 12/12/2020 10:50, Harald Welte wrote: On Fri, Dec 11, 2020 at 01:26:04PM +0100, Jonas Bonn wrote: The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). I must be blind, can you please point out where exactly this happens? It's in skb_scrub_packet() which is called by

Re: [PATCH net-next v2 10/12] gtp: add IPv6 support

2020-12-12 Thread Harald Welte
Hi Jonas, thanks again for your patches, they are very much appreciated. However, I don't think that it is "that easy". PDP contexts (at least) in GPRS/EDGE and UMTS come in three flavors: * IPv4 only * IPv6 only * IPv4v6 (i.e. both an IPv4 and an IPv6 address within the same tunnel) See for ex

Re: [patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-12 Thread Andy Shevchenko
On Sat, Dec 12, 2020 at 12:07 AM Thomas Gleixner wrote: > > On Fri, Dec 11 2020 at 22:08, Thomas Gleixner wrote: > > > On Fri, Dec 11 2020 at 19:53, Andy Shevchenko wrote: > > > >> On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner > >> wrote: > >>> > >>> irq_set_lockdep_class() is used from modul

Re: [PATCH v2] net: dsa: qca: ar9331: fix sleeping function called from invalid context bug

2020-12-12 Thread Vladimir Oltean
On Fri, Dec 11, 2020 at 12:03:17PM +0100, Oleksij Rempel wrote: > With lockdep enabled, we will get following warning: > > ar9331_switch ethernet.1:10 lan0 (uninitialized): PHY > [!ahb!ethernet@1a00!mdio!switch@10:00] driver [Qualcomm Atheros AR9331 > built-in PHY] (irq=13) > BUG: sleeping

Re: [PATCH net-next v2 07/12] gtp: use ephemeral source port

2020-12-12 Thread Jonas Bonn
Hi Harald, On 12/12/2020 11:07, Harald Welte wrote: Hi Jonas, On Fri, Dec 11, 2020 at 01:26:07PM +0100, Jonas Bonn wrote: From 3GPP TS 29.281: "...the UDP Source Port or the Flow Label field... should be set dynamically by the sending GTP-U entity to help balancing the load in the transport n

Re: [PATCH v5 2/2] net: dsa: qca: ar9331: export stats64

2020-12-12 Thread Vladimir Oltean
On Fri, Dec 11, 2020 at 11:53:22AM +0100, Oleksij Rempel wrote: > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/dsa/qca/ar9331.c | 256 ++- > 1 file changed, 255 insertions(+), 1 deletion(-) > > diff --git a/driver

Re: [PATCH v5 1/2] net: dsa: add optional stats64 support

2020-12-12 Thread Vladimir Oltean
On Fri, Dec 11, 2020 at 11:53:21AM +0100, Oleksij Rempel wrote: > Allow DSA drivers to export stats64 > > Signed-off-by: Oleksij Rempel > Reviewed-by: Vladimir Oltean > --- > include/net/dsa.h | 3 +++ > net/dsa/slave.c | 14 +- > 2 files changed, 16 insertions(+), 1 deletion(-)

Re: [PATCH net-next v2 10/12] gtp: add IPv6 support

2020-12-12 Thread Jonas Bonn
Hi Harald, On 12/12/2020 12:22, Harald Welte wrote: Hi Jonas, thanks again for your patches, they are very much appreciated. However, I don't think that it is "that easy". PDP contexts (at least) in GPRS/EDGE and UMTS come in three flavors: * IPv4 only * IPv6 only * IPv4v6 (i.e. both an IPv4

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-12 Thread Vladimir Oltean
On Fri, Dec 11, 2020 at 09:50:24PM +0100, Tobias Waldekranz wrote: > On Tue, Dec 08, 2020 at 13:23, Vladimir Oltean wrote: > > Sorry it took so long. I wanted to understand: > > (a) where are the challenged for drivers to uniformly support software > > bridging when they already have code for

Re: [PATCH] net/netconsole: Support VLAN for netconsole

2020-12-12 Thread Vladimir Oltean
On Thu, Dec 10, 2020 at 09:55:16AM -0800, Florian Fainelli wrote: > > > On 12/10/2020 2:07 AM, Libing Zhou wrote: > > During kernel startup phase, current netconsole doesn’t support VLAN > > since there is no VLAN interface setup already. > > > > This patch provides VLAN ID and PCP as optional b

Re: [PATCH v2 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-12 Thread Lorenzo Bianconi
On Dec 11, Saeed Mahameed wrote: > On Fri, 2020-12-11 at 20:28 +0100, Lorenzo Bianconi wrote: > > Introduce xdp_prepare_buff utility routine to initialize per- > > descriptor > > xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff() > > in > > all XDP capable drivers. > > > > Signed

[PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Victor Stewart
RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO cmsgs" thread... https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81...@mail.gmail.com/ here are the patches we discussed. Victor Stewart (3): net/socket.c: add PROTO_CMSG_DATA_ONLY to __sys_sendm

[PATCH 2/3] add PROTO_CMSG_DATA_ONLY to inet_dgram_ops

2020-12-12 Thread Victor Stewart
add PROTO_CMSG_DATA_ONLY to inet_dgram_ops Signed-off by: Victor Stewart --- net/ipv4/af_inet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index b7260c8cef2e..c9fd5e7cfd6e 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1052,6 +1052,7 @

[PATCH 3/3] add PROTO_CMSG_DATA_ONLY to inet6_dgram_ops

2020-12-12 Thread Victor Stewart
add PROTO_CMSG_DATA_ONLY to inet6_dgram_ops Signed-off by: Victor Stewart --- net/ipv6/af_inet6.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index e648fbebb167..560f45009d06 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@ -695,6 +695

[PATCH 1/3] add PROTO_CMSG_DATA_ONLY to __sys_sendmsg_sock

2020-12-12 Thread Victor Stewart
add PROTO_CMSG_DATA_ONLY whitelisting to __sys_sendmsg_sock Signed-off by: Victor Stewart --- net/socket.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/socket.c b/net/socket.c index 6e62104f..6995835d6355 100644 --- a/net/socket.c +++ b/net/socket.c @@ -241

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-12 Thread Jon Nettleton
On Fri, Dec 11, 2020 at 5:56 PM Ioana Ciornei wrote: > > On Fri, Dec 11, 2020 at 04:29:14PM +, Daniel Thompson wrote: > > On Fri, Dec 11, 2020 at 02:01:28PM +, Ioana Ciornei wrote: > > > On Thu, Dec 10, 2020 at 08:06:36PM +0200, Ioana Ciornei wrote: > > > > [Added also the netdev mailing l

[PATCH AUTOSEL 4.14 4/8] vxlan: Add needed_headroom for lower device

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit 0a35dc41fea67ac4495ce7584406bf9557a6e7d0 ] It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan_build_s

[PATCH AUTOSEL 4.14 5/8] vxlan: Copy needed_tailroom from lowerdev

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit a5e74021e84bb5eadf760aaf2c583304f02269be ] While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path. Signed-off-by: Sven Eckelmann Link: ht

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-12 Thread Guenter Roeck
On Sun, Nov 29, 2020 at 04:33:35AM +0900, Masahiro Yamada wrote: > Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). > > A lot of warn_unused_result warnings existed in 2006, but until now > they have been fixed thanks to people doing allmodconfig tests. > > Our goal is to always enabl

[PATCH AUTOSEL 4.19 6/9] vxlan: Copy needed_tailroom from lowerdev

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit a5e74021e84bb5eadf760aaf2c583304f02269be ] While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path. Signed-off-by: Sven Eckelmann Link: ht

[PATCH AUTOSEL 4.19 5/9] vxlan: Add needed_headroom for lower device

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit 0a35dc41fea67ac4495ce7584406bf9557a6e7d0 ] It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan_build_s

[PATCH AUTOSEL 5.9 18/23] iwlwifi: pcie: add one missing entry for AX210

2020-12-12 Thread Sasha Levin
From: Luca Coelho [ Upstream commit 5febcdef30902fa870128b9789b873199f13aff1 ] The 0x0024 subsytem device ID was missing from the list, so some AX210 devices were not recognized. Add it. Signed-off-by: Luca Coelho Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/iwlwifi.20201202143

[PATCH AUTOSEL 5.4 11/14] iwlwifi: pcie: add one missing entry for AX210

2020-12-12 Thread Sasha Levin
From: Luca Coelho [ Upstream commit 5febcdef30902fa870128b9789b873199f13aff1 ] The 0x0024 subsytem device ID was missing from the list, so some AX210 devices were not recognized. Add it. Signed-off-by: Luca Coelho Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/iwlwifi.20201202143

[PATCH AUTOSEL 5.4 07/14] vxlan: Copy needed_tailroom from lowerdev

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit a5e74021e84bb5eadf760aaf2c583304f02269be ] While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path. Signed-off-by: Sven Eckelmann Link: ht

[PATCH AUTOSEL 5.4 06/14] vxlan: Add needed_headroom for lower device

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit 0a35dc41fea67ac4495ce7584406bf9557a6e7d0 ] It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan_build_s

[PATCH AUTOSEL 5.9 19/23] iwlwifi: pcie: add some missing entries for AX210

2020-12-12 Thread Sasha Levin
From: Golan Ben Ami [ Upstream commit 9b15596c5006d82b2f82810e8cbf80d8c6e7e7b4 ] Some subsytem device IDs were missing from the list, so some AX210 devices were not recognized. Add them. Signed-off-by: Golan Ben Ami Signed-off-by: Luca Coelho Signed-off-by: Kalle Valo Link: https://lore.ke

[PATCH AUTOSEL 5.9 13/23] vxlan: Add needed_headroom for lower device

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit 0a35dc41fea67ac4495ce7584406bf9557a6e7d0 ] It was observed that sending data via batadv over vxlan (on top of wireguard) reduced the performance massively compared to raw ethernet or batadv on raw ethernet. A check of perf data showed that the vxlan_build_s

[PATCH AUTOSEL 5.9 14/23] vxlan: Copy needed_tailroom from lowerdev

2020-12-12 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit a5e74021e84bb5eadf760aaf2c583304f02269be ] While vxlan doesn't need any extra tailroom, the lowerdev might need it. In that case, copy it over to reduce the chance for additional (re)allocations in the transmit path. Signed-off-by: Sven Eckelmann Link: ht

[RFC] ravb: Add support for optional txc_refclk

2020-12-12 Thread Adam Ford
The SoC expects the txv_refclk is provided, but if it is provided by a programmable clock, there needs to be a way to get and enable this clock to operate. It needs to be optional since it's only necessary for those with programmable clocks. Signed-off-by: Adam Ford diff --git a/drivers/net/eth

Re: [PATCH] net/mlx4: Use true,false for bool variable

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 11:05:18 +0100 Vasyl Gomonovych wrote: > Fix en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable > Fix main.c:4465:5-13: WARNING: Comparison of 0/1 to bool variable Apart from addressing Joe's comment please name the tool which produced those.

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 8:31 AM, Victor Stewart wrote: > RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > cmsgs" thread... > > https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81...@mail.gmail.com/ > > here are the patches we discussed. > > Victor Stewart (3

Re: [PATCH net-next v3 0/4] vsock: Add flags field in the vsock address

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 16:24:13 +0100 Stefano Garzarella wrote: > On Fri, Dec 11, 2020 at 12:32:37PM +0200, Andra Paraschiv wrote: > >vsock enables communication between virtual machines and the host they are > >running on. Nested VMs can be setup to use vsock channels, as the multi > >transport suppo

Re: [PATCH v5 1/2] net: dsa: add optional stats64 support

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 11:53:21 +0100 Oleksij Rempel wrote: > +static void dsa_slave_get_stats64(struct net_device *dev, > + struct rtnl_link_stats64 *s) > +{ > + struct dsa_port *dp = dsa_slave_to_port(dev); > + struct dsa_switch *ds = dp->ds; > + > + if (!ds

Re: [PATCH net-next 13/15] mlxsw: spectrum_router_xm: Introduce basic XM cache flushing

2020-12-12 Thread Ido Schimmel
On Fri, Dec 11, 2020 at 08:24:27PM -0800, Jakub Kicinski wrote: > On Fri, 11 Dec 2020 19:04:11 +0200 Ido Schimmel wrote: > > From: Jiri Pirko > > > > Upon route insertion and removal, it is needed to flush possibly cached > > entries from the XM cache. Extend XM op context to carry information >

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Victor Stewart
On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > > On 12/12/20 8:31 AM, Victor Stewart wrote: > > RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > > cmsgs" thread... > > > > https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81...@mail.gmail.com/

Re: [PATCH v5 2/2] net: dsa: qca: ar9331: export stats64

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 11:53:22 +0100 Oleksij Rempel wrote: > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/dsa/qca/ar9331.c | 256 ++- > 1 file changed, 255 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/d

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 10:25 AM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: >> >> On 12/12/20 8:31 AM, Victor Stewart wrote: >>> RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO >>> cmsgs" thread... >>> >>> https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7n

[PATCH v3 bpf-next 0/2] introduce xdp_init_buff/xdp_prepare_buff

2020-12-12 Thread Lorenzo Bianconi
Introduce xdp_init_buff and xdp_prepare_buff utility routines to initialize xdp_buff data structure and remove duplicated code in all XDP capable drivers. Changes since v2: - precompute xdp->data as hard_start + headroom and save it in a local variable to reuse it for xdp->data_end and xdp->data

[PATCH v3 bpf-next 1/2] net: xdp: introduce xdp_init_buff utility routine

2020-12-12 Thread Lorenzo Bianconi
Introduce xdp_init_buff utility routine to initialize xdp_buff fields const over NAPI iterations (e.g. frame_sz or rxq pointer). Rely on xdp_init_buff in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c| 3 +-- drivers/net/ethernet

[PATCH v3 bpf-next 2/2] net: xdp: introduce xdp_prepare_buff utility routine

2020-12-12 Thread Lorenzo Bianconi
Introduce xdp_prepare_buff utility routine to initialize per-descriptor xdp_buff fields (e.g. xdp_buff pointers). Rely on xdp_prepare_buff() in all XDP capable drivers. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 ++--- drivers/net/ethernet/broadcom

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-12 Thread Sergei Shtylyov
Hello! On 12.12.2020 19:56, Adam Ford wrote: The SoC expects the txv_refclk is provided, but if it is provided by a programmable clock, there needs to be a way to get and enable this clock to operate. It needs to be optional since it's only necessary for those with programmable clocks. Signed

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Victor Stewart
On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: > > On 12/12/20 10:25 AM, Victor Stewart wrote: > > On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > >> > >> On 12/12/20 8:31 AM, Victor Stewart wrote: > >>> RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO > >>> cmsgs" thread

Re: [PATCH v5 2/2] net: dsa: qca: ar9331: export stats64

2020-12-12 Thread Jakub Kicinski
On Sat, 12 Dec 2020 15:48:52 +0200 Vladimir Oltean wrote: > > + stats->rx_packets = u64_stats_read(&s->rx64byte) + > > + u64_stats_read(&s->rx128byte) + u64_stats_read(&s->rx256byte) + > > + u64_stats_read(&s->rx512byte) + u64_stats_read(&s->rx1024byte) + > > + u64_s

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 10:58 AM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: >> >> On 12/12/20 10:25 AM, Victor Stewart wrote: >>> On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: On 12/12/20 8:31 AM, Victor Stewart wrote: > RE our conversation on the "[RFC 0/1]

[PATCH] net: bcmgenet: Fix a resource leak in an error handling path in the probe functin

2020-12-12 Thread Christophe JAILLET
If the 'register_netdev()' call fails, we must undo a previous 'bcmgenet_mii_init()' call. Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") Signed-off-by: Christophe JAILLET --- The missing 'bcmgenet_mii_exit()' call is added here, instead of in the error handling path in order to avoi

Re: [net-next PATCH] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
On Sat, Dec 12, 2020 at 10:34 AM Yuchung Cheng wrote: > > On Fri, Dec 11, 2020 at 5:28 PM Alexander Duyck > wrote: > > > > From: Alexander Duyck > > > > There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG > > message in the case of IPv6 or a fragmentation request in the case of

[PATCH v2 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
Currently any DSA switch that is strict when implementing the mdb operations prints these benign errors after the addresses expire, with at least 2 ports bridged: [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del object (id=3) The reason has to do with this piece of code:

[PATCH v4 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-12 Thread Vladimir Oltean
Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has a very nice ocelot_mact_wait_for_completion at the end. Introduced in commit 639c1b2625af ("net: mscc: ocelot: Register poll timeout should be wall time not attempts"), this function uses readx_poll_timeout which triggers a lo

Re: [PATCH v2 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Andrew Lunn
> +/* DSA can directly translate this to a normal MDB add, but on the CPU port. > + * But because multiple user ports can join the same multicast group and the > + * bridge will emit a notification for each port, we need to add/delete the > + * entry towards the host only once, so we reference coun

Re: [PATCH v10 1/4] dt-bindings: phy: Add sparx5-serdes bindings

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:38AM +0100, Steen Hegelund wrote: > Document the Sparx5 ethernet serdes phy driver bindings. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-by: Rob Herring Reviewed-by: Andrew Lunn Andrew

Re: pull-request: mac80211-next 2020-12-11

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Fri, 11 Dec 2020 15:25:51 +0100 you wrote: > Hi Dave, > > Welcome back! > > I'm a bit late with this, I guess, but I hope you can still > pull it into net-next for 5.11. Nothing really stands out, > we have some

Re: [PATCH v10 2/4] phy: Add ethernet serdes configuration option

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:39AM +0100, Steen Hegelund wrote: > Provide a new ethernet phy configuration structure, that > allow PHYs used for ethernet to be configured with > speed, media type and clock information. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund Reviewed-by:

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-12 Thread Ioana Ciornei
On Sat, Dec 12, 2020 at 04:58:56PM +0100, Jon Nettleton wrote: > On Fri, Dec 11, 2020 at 5:56 PM Ioana Ciornei wrote: > > > > On Fri, Dec 11, 2020 at 04:29:14PM +, Daniel Thompson wrote: > > > On Fri, Dec 11, 2020 at 02:01:28PM +, Ioana Ciornei wrote: > > > > On Thu, Dec 10, 2020 at 08:06:

Re: [PATCH v10 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:40AM +0100, Steen Hegelund wrote: > Add the Microchip Sparx5 ethernet serdes PHY driver for the 6G, 10G and 25G > interfaces available in the Sparx5 SoC. > > Signed-off-by: Bjarni Jonasson > Signed-off-by: Steen Hegelund Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v10 4/4] arm64: dts: sparx5: Add Sparx5 serdes driver node

2020-12-12 Thread Andrew Lunn
On Fri, Dec 11, 2020 at 10:05:41AM +0100, Steen Hegelund wrote: > Add Sparx5 serdes driver node, and enable it generally for all > reference boards. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund Reviewed-by: Andrew Lunn Andrew

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-12 Thread Adam Ford
On Sat, Dec 12, 2020 at 11:55 AM Sergei Shtylyov wrote: > > Hello! > > On 12.12.2020 19:56, Adam Ford wrote: > > > The SoC expects the txv_refclk is provided, but if it is provided > > by a programmable clock, there needs to be a way to get and enable > > this clock to operate. It needs to be opt

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > proc_fs was used, in af_packet, without a surrounding #ifdef, > although there is no hard dependency on proc_fs. > That caused the initialization of the af_packet module to fail > when CONFIG_PROC_FS=n. > > Specifically, proc_create_net() w

Re: [net-next PATCH] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
On Sat, Dec 12, 2020 at 11:07 AM Yuchung Cheng wrote: > > On Sat, Dec 12, 2020 at 11:01 AM Alexander Duyck > wrote: > > > > On Sat, Dec 12, 2020 at 10:34 AM Yuchung Cheng wrote: > > > > > > On Fri, Dec 11, 2020 at 5:28 PM Alexander Duyck > > > wrote: > > > > > > > > From: Alexander Duyck > > >

Incorrect --help / manpage for -color for ip, tc, bridge

2020-12-12 Thread Witold Baryluk
iproute 5.9.0 Apparently ip -c is a shortcut to ip -color but in tc, tc -c doesn't work, one needs to say tc -col or tc -color I understand there is tc -conf, which has tc -c. But: Help says: root@debian:~# tc Usage:tc [ OPTIONS ] OBJECT { COMMAND | help } tc [-force] -batch filename

[net-next PATCH v2] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
From: Alexander Duyck There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG message in the case of IPv6 or a fragmentation request in the case of IPv4. This results in the socket stalling for a second or more as it does not respond to the message by retransmitting the SYN frame.

Re: [net-next v3 00/14] Add mlx5 subfunction support

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 22:12:11 -0800 Saeed Mahameed wrote: > Hi Dave, Jakub, Jason, > > This series form Parav was the theme of this mlx5 release cycle, > we've been waiting anxiously for the auxbus infrastructure to make it into > the kernel, and now as the auxbus is in and all the stars are aligne

Re: pull-request: wireless-drivers-next-2020-12-12

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 05:08:39 + (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with

[net-next PATCH v3] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Alexander Duyck
From: Alexander Duyck There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG message in the case of IPv6 or a fragmentation request in the case of IPv4. This results in the socket stalling for a second or more as it does not respond to the message by retransmitting the SYN frame.

[PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
Currently any DSA switch that is strict when implementing the mdb operations prints these benign errors after the addresses expire, with at least 2 ports bridged: [ 286.013814] mscc_felix :00:00.5 swp3: failed (err=-2) to del object (id=3) The reason has to do with this piece of code:

Re: [PATCH v2 3/3] net: mhi: Add dedicated alloc thread

2020-12-12 Thread Jakub Kicinski
On Thu, 10 Dec 2020 12:15:51 +0100 Loic Poulain wrote: > The buffer allocation for RX path is currently done by a work executed > in the system workqueue. The work to do is quite simple and consists > mostly in allocating and queueing as much as possible buffers to the MHI > RX channel. > > It app

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Yonatan Linik
On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote: > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > > proc_fs was used, in af_packet, without a surrounding #ifdef, > > although there is no hard dependency on proc_fs. > > That caused the initialization of the af_packet module to fai

Re: [PATCH] net: qlcnic: remove casting dma_alloc_coherent

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 08:59:20 + Xu Wang wrote: > Remove casting the values returned by dma_alloc_coherent. > > Signed-off-by: Xu Wang This patch does not apply to net-next, please rebase against: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ if you want it to be appli

Re: [PATCH] xfrm: redact SA secret with lockdown confidentiality

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 09:57:37 +0100 you wrote: > From: Antony Antony > > redact XFRM SA secret in the netlink response to xfrm_get_sa() > or dumpall sa. > Enable lockdown, confidentiality mode, at boot or at run time. > >

Re: pull request (net-next): ipsec-next 2020-12-12

2020-12-12 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Sat, 12 Dec 2020 09:57:36 +0100 you wrote: > Just one patch this time: > > 1) Redact the SA keys with kernel lockdown confidentiality. >If enabled, no secret keys are sent to uuserspace. >From Antony Anto

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Victor Stewart
On Sat, Dec 12, 2020 at 6:02 PM Jens Axboe wrote: > > On 12/12/20 10:58 AM, Victor Stewart wrote: > > On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: > >> > >> On 12/12/20 10:25 AM, Victor Stewart wrote: > >>> On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: > > On 12/12/20 8:31 AM,

Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP)

2020-12-12 Thread Jens Axboe
On 12/12/20 2:42 PM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 6:02 PM Jens Axboe wrote: >> >> On 12/12/20 10:58 AM, Victor Stewart wrote: >>> On Sat, Dec 12, 2020 at 5:40 PM Jens Axboe wrote: On 12/12/20 10:25 AM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 5:07 PM Jens A

Re: [PATCH 1/1] net: Fix use of proc_fs

2020-12-12 Thread Jakub Kicinski
On Sat, 12 Dec 2020 23:39:20 +0200 Yonatan Linik wrote: > On Sat, Dec 12, 2020 at 9:48 PM Jakub Kicinski wrote: > > > > On Fri, 11 Dec 2020 18:37:49 +0200 Yonatan Linik wrote: > > > proc_fs was used, in af_packet, without a surrounding #ifdef, > > > although there is no hard dependency on proc_f

Re: [PATCH] igc: set the default return value to -IGC_ERR_NVM in igc_write_nvm_srwr

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 22:34:56 +0800 Kevin Lo wrote: > This patch sets the default return value to -IGC_ERR_NVM in > igc_write_nvm_srwr. > Without this change it wouldn't lead to a shadow RAM write EEWR timeout. > > Signed-off-by: Kevin Lo This is a fix, please add a Fixes tag. Please CC the mai

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Andrew Lunn
> + /* Complication created by the fact that addition has two phases, but > + * deletion only has one phase, and we need reference counting. > + * The strategy is to do the memory allocation in the prepare phase, > + * but initialize the refcount in the commit phase. > + * >

Re: [PATCH net-next v2] GTP: add support for flow based tunneling API

2020-12-12 Thread Jakub Kicinski
On Fri, 11 Dec 2020 20:40:17 -0800 Pravin B Shelar wrote: > Following patch add support for flow based tunneling API > to send and recv GTP tunnel packet over tunnel metadata API. > This would allow this device integration with OVS or eBPF using > flow based tunneling APIs. > > Signed-off-by: Prav

Re: [PATCH v3 net-next] net: dsa: reference count the host mdb addresses

2020-12-12 Thread Vladimir Oltean
On Sat, Dec 12, 2020 at 11:06:41PM +0100, Andrew Lunn wrote: > > + /* Complication created by the fact that addition has two phases, but > > +* deletion only has one phase, and we need reference counting. > > +* The strategy is to do the memory allocation in the prepare phase, > > +*

Re: [Patch bpf-next 0/3] bpf: introduce timeout map

2020-12-12 Thread Cong Wang
On Fri, Dec 11, 2020 at 11:55 AM Andrii Nakryiko wrote: > > On Fri, Dec 11, 2020 at 2:28 AM Cong Wang wrote: > > > > From: Cong Wang > > > > This patchset introduces a new bpf hash map which has timeout. > > Patch 1 is a preparation, patch 2 is the implementation of timeout > > map, patch 3 cont

Re: [PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-12 Thread Jakub Kicinski
On Tue, 8 Dec 2020 17:19:10 +0800 Cambda Zhu wrote: > For each TCP zero window probe, the icsk_backoff is increased by one and > its max value is tcp_retries2. If tcp_retries2 is greater than 63, the > probe0 timeout shift may exceed its max bits. On x86_64/ARMv8/MIPS, the > shift count would be m

Re: [PATCH net-next v4 2/3] net: implement threaded-able napi poll loop support

2020-12-12 Thread Jakub Kicinski
On Tue, 8 Dec 2020 16:54:43 -0800 Wei Wang wrote: > This patch allows running each napi poll loop inside its own > kernel thread. > The threaded mode could be enabled through napi_set_threaded() > api, and does not require a device up/down. The kthread gets > created on demand when napi_set_thread

Re: [PATCH net-next v4 2/3] net: implement threaded-able napi poll loop support

2020-12-12 Thread Jakub Kicinski
On Sat, 12 Dec 2020 14:50:22 -0800 Jakub Kicinski wrote: > > @@ -6731,6 +6790,7 @@ void napi_disable(struct napi_struct *n) > > msleep(1); > > > > hrtimer_cancel(&n->timer); > > + napi_kthread_stop(n); > > I'm surprised that we stop the thread on napi_disable() but there is n

Re: [PATCH net-next v4 3/3] net: add sysfs attribute to control napi threaded mode

2020-12-12 Thread Jakub Kicinski
On Tue, 8 Dec 2020 16:54:44 -0800 Wei Wang wrote: > +static void dev_disable_threaded_all(struct net_device *dev) > +{ > + struct napi_struct *napi; > + > + list_for_each_entry(napi, &dev->napi_list, dev_list) > + napi_set_threaded(napi, false); > +} This is an implementation

[PATCH net-next 06/10] netfilter: ctnetlink: add timeout and protoinfo to destroy events

2020-12-12 Thread Pablo Neira Ayuso
From: Florian Westphal DESTROY events do not include the remaining timeout. Add the timeout if the entry was removed explicitly. This can happen when a conntrack gets deleted prematurely, e.g. due to a tcp reset, module removal, netdev notifier (nat/masquerade device went down), ctnetlink and so

Re: [PATCH] nfc: s3fwrn5: let core configure the interrupt trigger

2020-12-12 Thread Jakub Kicinski
On Thu, 10 Dec 2020 22:18:24 +0100 Krzysztof Kozlowski wrote: > If interrupt trigger is not set when requesting the interrupt, the core > will take care of reading trigger type from Devicetree. There is no > point to do it in the driver. > > Signed-off-by: Krzysztof Kozlowski Applied, thank you

  1   2   >