RE: [PATCH v1 net-next 05/15] nvme-tcp: Add DDP offload control path

2020-12-10 Thread Shai Malin
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index c0c33320fe65..ef96e4a02bbd 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "nvme.h" #include "fabrics.h" @@ -62,6 +63,7 @@ enum nvme_tc

Re: [Intel-wired-lan] Explaining XDP redirect bulk size design (Was: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set)

2020-12-10 Thread Jesper Dangaard Brouer
On Thu, 10 Dec 2020 15:14:18 +0100 Magnus Karlsson wrote: > On Thu, Dec 10, 2020 at 2:32 PM Jesper Dangaard Brouer > wrote: > > > > On Wed, 9 Dec 2020 08:44:33 -0700 > > David Ahern wrote: > > > > > On 12/9/20 4:52 AM, Jesper Dangaard Brouer wrote: > > > > But I have redesigned the ndo_xdp_

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
Hi Russell, czw., 10 gru 2020 o 16:46 Russell King - ARM Linux admin napisał(a): > > On Thu, Dec 10, 2020 at 03:35:29PM +0100, Marcin Wojtas wrote: > > Hi Greg, > > > > śr., 9 gru 2020 o 11:59 Greg Kroah-Hartman > > napisał(a): > > > What part fixes the issue? I can't see it... > > > > I re-che

Re: [PATCH v4 net-next 0/2] add ppp_generic ioctl(s) to bridge channels

2020-12-10 Thread Guillaume Nault
On Thu, Dec 10, 2020 at 03:50:56PM +, Tom Parkin wrote: > Following on from my previous RFC[1], this series adds two ioctl calls > to the ppp code to implement "channel bridging". > > When two ppp channels are bridged, frames presented to ppp_input() on > one channel are passed to the other ch

Re: [PATCH net] net: sched: Fix dump of MPLS_OPT_LSE_LABEL attribute in cls_flower

2020-12-10 Thread Davide Caratti
On Wed, 2020-12-09 at 16:48 +0100, Guillaume Nault wrote: > TCA_FLOWER_KEY_MPLS_OPT_LSE_LABEL is a u32 attribute (MPLS label is > 20 bits long). > > Fixes the following bug: > >  $ tc filter add dev ethX ingress protocol mpls_uc \ >  flower mpls lse depth 2 label 256 \ >  acti

Re: [PATCH] net/netconsole: Support VLAN for netconsole

2020-12-10 Thread Florian Fainelli
On 12/10/2020 2:07 AM, Libing Zhou wrote: > During kernel startup phase, current netconsole doesn’t support VLAN > since there is no VLAN interface setup already. > > This patch provides VLAN ID and PCP as optional boot/module parameters > to support VLAN environment, thus kernel startup log ca

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Russell King - ARM Linux admin
On Thu, Dec 10, 2020 at 06:43:50PM +0100, Marcin Wojtas wrote: > I must admit that due to other duties I did not follow the mainline > mvpp2 for a couple revisions (and I am not maintainer of it). However > recently I got reached-out directly by different developers - the > trigger was different di

Re: [PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-10 Thread Phil Sutter
Hi Nicolas, On Thu, Dec 10, 2020 at 02:18:45PM +0100, Nicolas Dichtel wrote: > Le 10/12/2020 à 12:48, Eyal Birger a écrit : > > On Thu, Dec 10, 2020 at 1:10 PM Nicolas Dichtel > > wrote: > [snip] > > I also think they should be consistent. But it'd still be confusing to me > > to get an OUTPUT ho

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
On Dec 10, Maciej Fijalkowski wrote: > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > > > structure. Rely on xdp_init_buff in al

Re: [PATCH net-next] ice, xsk: Move Rx alloction out of while-loop

2020-12-10 Thread Björn Töpel
On Thu, 10 Dec 2020 at 17:20, Maciej Fijalkowski wrote: > > On Thu, Dec 10, 2020 at 01:19:15PM +0100, Björn Töpel wrote: > > From: Björn Töpel > > > > Instead of trying to allocate for each packet, move it outside the > > while loop and try to allocate once every NAPI loop. > > To rectify above,

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-10 Thread Ioana Ciornei
[Added also the netdev mailing list, I haven't heard of linux-netdev before but kept it] On Thu, Dec 10, 2020 at 05:31:56PM +, Daniel Thompson wrote: > Hi Ioana Hi Daniel, > > On Mon, Jun 29, 2020 at 06:47:11PM +, Ioana Ciornei wrote: > > Instead of realloc-ing the skb on the Tx path wh

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Alexander Duyck
On Thu, Dec 10, 2020 at 9:05 AM Maciej Fijalkowski wrote: > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > > > structure. Rel

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Geva, Erez
helpful. > >> [auto build test ERROR on b65054597872ce3aefbc6a666385eabdf9e288da] >> >> url: >> https://github.com/0day-ci/linux/commits/Erez-Geva/Add-sending-TX-hardware-timestamp-for-TC-ETF-Qdisc/20201210-000521 > I can not find this commit > >> ba

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Maciej Fijalkowski
On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > Introduce xdp_init_buff utility routine to initialize xdp_buff data > > > structure. Rely on xdp_init_buff in all XDP capable drivers. > > > > Hm, Jesper wa

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Marcin Wojtas
czw., 10 gru 2020 o 18:56 Russell King - ARM Linux admin napisał(a): > > On Thu, Dec 10, 2020 at 06:43:50PM +0100, Marcin Wojtas wrote: > > I must admit that due to other duties I did not follow the mainline > > mvpp2 for a couple revisions (and I am not maintainer of it). However > > recently I g

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > On Dec 10, Maciej Fijalkowski wrote: > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi > > > > wrote: > > > > > Introduce xdp_init_buff utility routine

Re: [PATCH wireless -next] cw1200: txrx: convert comma to semicolon

2020-12-10 Thread Kalle Valo
Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Patch applied to wireless-drivers-next.git, thanks. c42d492c672a cw1200: txrx: convert comma to semicolon -- https://patchwork.kernel.org/project/linux-wireless/patch/202012

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Maciej Fijalkowski
On Thu, Dec 10, 2020 at 06:59:45PM +0100, Lorenzo Bianconi wrote: > On Dec 10, Maciej Fijalkowski wrote: > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi wrote: > > > > > Introduce xdp_init_buff utility routine

Re: [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests.

2020-12-10 Thread Martin KaFai Lau
On Thu, Dec 10, 2020 at 02:15:38PM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Wed, 9 Dec 2020 16:07:07 -0800 > > On Tue, Dec 01, 2020 at 11:44:12PM +0900, Kuniyuki Iwashima wrote: > > > This patch renames reuseport_select_sock() to __reuseport_select_sock() > > > and > >

[PATCH] selftests: Skip BPF seftests by default

2020-12-10 Thread Mark Brown
The BPF selftests have build time dependencies on cutting edge versions of tools in the BPF ecosystem including LLVM which are more involved to satisfy than more typical requirements like installing a package from your distribution. This causes issues for users looking at kselftest in as a whole w

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 08:30 -0700, David Ahern wrote: > On 12/9/20 11:48 PM, Saeed Mahameed wrote: > > On Wed, 2020-12-09 at 20:34 -0700, David Ahern wrote: > > > On 12/9/20 10:15 AM, Saeed Mahameed wrote: > > > > > My personal experience with this one is mlx5/ConnectX4-LX > > > > > with a > > > >

Re: [PATCH v9 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-10 Thread Steen Hegelund
On 10.12.2020 15:16, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > So why are returning link up information? Yes that was a bit of a hijacking of the function. I will remove that. I also removed the dependency on this behaviou

[PATCH net-next] igc: Add new device ID

2020-12-10 Thread Tony Nguyen
From: Sasha Neftin Add new device ID for the next step of the silicon and reflect the I226_K part. Signed-off-by: Sasha Neftin Tested-by: Aaron Brown Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/igc/igc_base.c | 1 + drivers/net/ethernet/intel/igc/igc_hw.h | 1 + drivers/net/e

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Willem de Bruijn
On Wed, Dec 9, 2020 at 3:18 PM Geva, Erez wrote: > > > On 09/12/2020 18:37, Willem de Bruijn wrote: > > On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez > > wrote: > >> > >> > >> On 09/12/2020 15:48, Willem de Bruijn wrote: > >>> On Wed, Dec 9, 2020 at 9:37 AM Erez Geva > >>> wrote: > > Co

Re: [PATCH] selftests: Skip BPF seftests by default

2020-12-10 Thread Alexei Starovoitov
On Thu, Dec 10, 2020 at 06:52:33PM +, Mark Brown wrote: > The BPF selftests have build time dependencies on cutting edge versions > of tools in the BPF ecosystem including LLVM which are more involved > to satisfy than more typical requirements like installing a package from > your distribution

[net-next] tcp: correctly handle increased zerocopy args struct size

2020-12-10 Thread Arjun Roy
From: Arjun Roy A prior patch increased the size of struct tcp_zerocopy_receive but did not update do_tcp_getsockopt() handling to properly account for this. This patch simply reintroduces content erroneously cut from the referenced prior patch that handles the new struct size. Fixes: 18fb76ed5

Re: Explaining XDP redirect bulk size design (Was: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set)

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 14:32 +0100, Jesper Dangaard Brouer wrote: > On Wed, 9 Dec 2020 08:44:33 -0700 > David Ahern wrote: > > > On 12/9/20 4:52 AM, Jesper Dangaard Brouer wrote: > > > But I have redesigned the ndo_xdp_xmit call to take a bulk of > > > packets > > > (up-to 16) so it should not be

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
> On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > > On Dec 10, Maciej Fijalkowski wrote: > > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi wrote: > > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100, Lorenzo Bianconi > > > > > wrote: > > > > > > Introduce xdp_init_buff uti

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-10 Thread Martin KaFai Lau
On Thu, Dec 10, 2020 at 02:58:10PM +0900, Kuniyuki Iwashima wrote: [ ... ] > > > I've implemented one-by-one migration only for the accept queue for now. > > > In addition to the concern about TFO queue, > > You meant this queue: queue->fastopenq.rskq_rst_head? > > Yes. > > > > Can "req" be p

[patch 04/30] genirq: Provide irq_get_effective_affinity()

2020-12-10 Thread Thomas Gleixner
Provide an accessor to the effective interrupt affinity mask. Going to be used to replace open coded fiddling with the irq descriptor. Signed-off-by: Thomas Gleixner --- include/linux/irq.h |7 +++ 1 file changed, 7 insertions(+) --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -9

[patch 00/30] genirq: Treewide hunt for irq descriptor abuse and assorted fixes

2020-12-10 Thread Thomas Gleixner
A recent request to export kstat_irqs() pointed to a copy of the same in the i915 code, which made me look for further usage of irq descriptors in drivers. The usage in drivers ranges from creative to broken in all colours. irqdesc.h clearly says that this is core functionality and the fact C doe

[patch 05/30] genirq: Annotate irq stats data races

2020-12-10 Thread Thomas Gleixner
Both the per cpu stats and the accumulated count are accessed lockless and can be concurrently modified. That's intentional and the stats are a rough estimate anyway. Annotate them with data_race(). Signed-off-by: Thomas Gleixner --- kernel/irq/irqdesc.c |4 ++-- kernel/irq/proc.c|5

[patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-10 Thread Thomas Gleixner
Driver code has no business with the internals of the irq descriptor. Aside of that the count is per interrupt line and therefore takes interrupts from other devices into account which share the interrupt line and are not handled by the graphics driver. Replace it with a pmu private count which o

[patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-10 Thread Thomas Gleixner
All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite the affinity mask with the corresponding cpumask. That does not make sense. The XEN implementation of irqchip::irq_set_affinity() already picks a single target CPU out of the affinity mask and

[patch 09/30] ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()

2020-12-10 Thread Thomas Gleixner
The irq descriptor is already there, no need to look it up again. Signed-off-by: Thomas Gleixner Cc: Marc Zyngier Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/kernel/smp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/kernel/smp.c +++ b/arch

[patch 29/30] xen/events: Implement irq distribution

2020-12-10 Thread Thomas Gleixner
Keep track of the assignments of event channels to CPUs and select the online CPU with the least assigned channels in the affinity mask which is handed to irq_chip::irq_set_affinity() from the core code. Signed-off-by: Thomas Gleixner Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini

[patch 28/30] xen/events: Reduce irq_info::spurious_cnt storage size

2020-12-10 Thread Thomas Gleixner
To prepare for interrupt spreading reduce the storage size of irq_info::spurious_cnt to u8 so the required flag for the spreading logic will not increase the storage size. Protect the usage site against overruns. Signed-off-by: Thomas Gleixner Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano

[patch 24/30] xen/events: Remove unused bind_evtchn_to_irq_lateeoi()

2020-12-10 Thread Thomas Gleixner
Signed-off-by: Thomas Gleixner Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- drivers/xen/events/events_base.c |6 -- 1 file changed, 6 deletions(-) --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -1

[patch 17/30] NTB/msi: Use irq_has_action()

2020-12-10 Thread Thomas Gleixner
Use the proper core function. Signed-off-by: Thomas Gleixner Cc: Jon Mason Cc: Dave Jiang Cc: Allen Hubbe Cc: linux-...@googlegroups.com --- drivers/ntb/msi.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/ntb/msi.c +++ b/drivers/ntb/msi.c @@ -282,15 +282,13 @@ int

[patch 22/30] net/mlx5: Replace irq_to_desc() abuse

2020-12-10 Thread Thomas Gleixner
No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation does not mean that the kernel has no limits. Retr

[patch 20/30] net/mlx4: Replace irq_to_desc() abuse

2020-12-10 Thread Thomas Gleixner
No driver has any business with the internals of an interrupt descriptor. Storing a pointer to it just to use yet another helper at the actual usage site to retrieve the affinity mask is creative at best. Just because C does not allow encapsulation does not mean that the kernel has no limits. Retr

[patch 23/30] net/mlx5: Use effective interrupt affinity

2020-12-10 Thread Thomas Gleixner
Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even must reduce the mask to the effective set, which me

Re: [Intel-gfx] [patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage

2020-12-10 Thread Ville Syrjälä
On Thu, Dec 10, 2020 at 08:25:49PM +0100, Thomas Gleixner wrote: > Nothing uses the result and nothing should ever use it in driver code. > > Signed-off-by: Thomas Gleixner > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: David Airlie > Cc: Daniel Vetter > Cc: Pankaj Bharadiy

[patch 15/30] pinctrl: nomadik: Use irq_has_action()

2020-12-10 Thread Thomas Gleixner
Let the core code do the fiddling with irq_desc. Signed-off-by: Thomas Gleixner Cc: Linus Walleij Cc: linux-arm-ker...@lists.infradead.org Cc: linux-g...@vger.kernel.org --- drivers/pinctrl/nomadik/pinctrl-nomadik.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/pinct

[patch 16/30] mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc

2020-12-10 Thread Thomas Gleixner
First of all drivers have absolutely no business to dig into the internals of an irq descriptor. That's core code and subject to change. All of this information is readily available to /proc/interrupts in a safe and race free way. Remove the inspection code which is a blatant violation of subsyste

[patch 30/30] genirq: Remove export of irq_to_desc()

2020-12-10 Thread Thomas Gleixner
No more (ab)use in modules finally. Remove the export so there won't come new ones. Signed-off-by: Thomas Gleixner --- kernel/irq/irqdesc.c |1 - 1 file changed, 1 deletion(-) --- a/kernel/irq/irqdesc.c +++ b/kernel/irq/irqdesc.c @@ -352,7 +352,6 @@ struct irq_desc *irq_to_desc(unsigned in

[patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Thomas Gleixner
Going through a full irq descriptor lookup instead of just using the proper helper function which provides direct access is suboptimal. In fact it _is_ wrong because the chip callback needs to get the chip data which is relevant for the chip while using the irq descriptor variant returns the irq c

[patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage

2020-12-10 Thread Thomas Gleixner
Nothing uses the result and nothing should ever use it in driver code. Signed-off-by: Thomas Gleixner Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Cc: Pankaj Bharadiya Cc: Chris Wilson Cc: Wambui Karuga Cc: intel-...@lists.freedesktop.org Cc: dri

INFO: task can't die in inet_twsk_purge

2020-12-10 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a9e26cb5 Add linux-next specific files for 20201208 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161a961350 kernel config: https://syzkaller.appspot.com/x/.config?x=e259434a8eaf0206 dashboard

[patch 12/30] s390/irq: Use irq_desc_kstat_cpu() in show_msi_interrupt()

2020-12-10 Thread Thomas Gleixner
The irq descriptor is already there, no need to look it up again. Signed-off-by: Thomas Gleixner Cc: Christian Borntraeger Cc: Heiko Carstens Cc: linux-s...@vger.kernel.org --- arch/s390/kernel/irq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/s390/kernel/irq.c +++ b/a

[patch 10/30] arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()

2020-12-10 Thread Thomas Gleixner
The irq descriptor is already there, no need to look it up again. Signed-off-by: Thomas Gleixner Cc: Mark Rutland Cc: Catalin Marinas Cc: Will Deacon Cc: Marc Zyngier Cc: linux-arm-ker...@lists.infradead.org --- arch/arm64/kernel/smp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[patch 11/30] parisc/irq: Use irq_desc_kstat_cpu() in show_interrupts()

2020-12-10 Thread Thomas Gleixner
The irq descriptor is already there, no need to look it up again. Signed-off-by: Thomas Gleixner Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: afzal mohammed Cc: linux-par...@vger.kernel.org --- arch/parisc/kernel/irq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/pa

[patch 08/30] genirq: Provide kstat_irqdesc_cpu()

2020-12-10 Thread Thomas Gleixner
Most users of kstat_irqs_cpu() have the irq descriptor already. No point in calling into the core code and looking it up once more. Use it in per_cpu_count_show() to start with. Signed-off-by: Thomas Gleixner --- include/linux/irqdesc.h |6 ++ kernel/irq/irqdesc.c|4 ++-- 2 file

Re: [PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core

2020-12-10 Thread Wolfram Sang
On Thu, Dec 10, 2020 at 03:47:50PM +0100, Heiner Kallweit wrote: > Zillions of drivers use the unlikely() hint when checking the result of > dma_mapping_error(). This is an inline function anyway, so we can move > the hint into the function and remove it from drivers. > From time to time discussion

[patch 26/30] xen/events: Use immediate affinity setting

2020-12-10 Thread Thomas Gleixner
There is absolutely no reason to mimic the x86 deferred affinity setting. This mechanism is required to handle the hardware induced issues of IO/APIC and MSI and is not in use when the interrupts are remapped. XEN does not need this and can simply change the affinity from the calling context. The

[patch 25/30] xen/events: Remove disfunct affinity spreading

2020-12-10 Thread Thomas Gleixner
This function can only ever work when the event channels: - are already established - interrupts assigned to them - the affinity has been set by user space already because any newly set up event channel is forced to be bound to CPU0 and the affinity mask of the interrupt is forced to contai

[patch 21/30] net/mlx4: Use effective interrupt affinity

2020-12-10 Thread Thomas Gleixner
Using the interrupt affinity mask for checking locality is not really working well on architectures which support effective affinity masks. The affinity mask is either the system wide default or set by user space, but the architecture can or even must reduce the mask to the effective set, which me

[patch 18/30] PCI: xilinx-nwl: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Thomas Gleixner
Going through a full irq descriptor lookup instead of just using the proper helper function which provides direct access is suboptimal. In fact it _is_ wrong because the chip callback needs to get the chip data which is relevant for the chip while using the irq descriptor variant returns the irq c

[patch 02/30] genirq: Move status flag checks to core

2020-12-10 Thread Thomas Gleixner
These checks are used by modules and prevent the removal of the export of irq_to_desc(). Move the accessor into the core. Signed-off-by: Thomas Gleixner --- include/linux/irqdesc.h | 17 + kernel/irq/manage.c | 17 + 2 files changed, 22 insertions(+), 12 d

[patch 06/30] parisc/irq: Simplify irq count output for /proc/interrupts

2020-12-10 Thread Thomas Gleixner
The SMP variant works perfectly fine on UP as well. Signed-off-by: Thomas Gleixner Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: afzal mohammed Cc: linux-par...@vger.kernel.org --- arch/parisc/kernel/irq.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) --- a/arch/parisc/kerne

[patch 07/30] genirq: Make kstat_irqs() static

2020-12-10 Thread Thomas Gleixner
No more users outside the core code. Signed-off-by: Thomas Gleixner --- include/linux/kernel_stat.h |1 - kernel/irq/irqdesc.c| 19 ++- 2 files changed, 6 insertions(+), 14 deletions(-) --- a/include/linux/kernel_stat.h +++ b/include/linux/kernel_stat.h @@ -67,7 +6

[patch 01/30] genirq: Move irq_has_action() into core code

2020-12-10 Thread Thomas Gleixner
This function uses irq_to_desc() and is going to be used by modules to replace the open coded irq_to_desc() (ab)usage. The final goal is to remove the export of irq_to_desc() so driver cannot fiddle with it anymore. Move it into the core code and fixup the usage sites to include the proper header.

[patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-10 Thread Thomas Gleixner
irq_set_lockdep_class() is used from modules and requires irq_to_desc() to be exported. Move it into the core code which lifts another requirement for the export. Signed-off-by: Thomas Gleixner --- include/linux/irqdesc.h | 10 -- kernel/irq/irqdesc.c| 14 ++ 2 files

Re: [PATCH net-next 2/7] net: hns3: add support for tc mqprio offload

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 20:27 +0800, tanhuazhong wrote: > > On 2020/12/10 12:50, Saeed Mahameed wrote: > > On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: > > > From: Jian Shen > > > > > > Currently, the HNS3 driver only supports offload for tc number > > > and prio_tc. This patch adds supp

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-10 Thread Andrew Lunn
> +1. As soon as the MDIO+ACPI lands, I plan to do the rework. Don't hold you breath. It has gone very quiet about ACPI in net devices. Andrew

Re: [patch 12/30] s390/irq: Use irq_desc_kstat_cpu() in show_msi_interrupt()

2020-12-10 Thread Heiko Carstens
On Thu, Dec 10, 2020 at 08:25:48PM +0100, Thomas Gleixner wrote: > The irq descriptor is already there, no need to look it up again. > > Signed-off-by: Thomas Gleixner > Cc: Christian Borntraeger > Cc: Heiko Carstens > Cc: linux-s...@vger.kernel.org > --- > arch/s390/kernel/irq.c |2 +- >

Re: [patch 17/30] NTB/msi: Use irq_has_action()

2020-12-10 Thread Logan Gunthorpe
On 2020-12-10 12:25 p.m., Thomas Gleixner wrote: > Use the proper core function. > > Signed-off-by: Thomas Gleixner > Cc: Jon Mason > Cc: Dave Jiang > Cc: Allen Hubbe > Cc: linux-...@googlegroups.com Looks good to me. Reviewed-by: Logan Gunthorpe > --- > drivers/ntb/msi.c |4 +--- >

Re: [PATCH] vxlan: avoid double unlikely() notation when using IS_ERR()

2020-12-10 Thread David Miller
From: Antonio Quartulli Date: Thu, 10 Dec 2020 09:55:49 +0100 > The definition of IS_ERR() already applies the unlikely() notation > when checking the error status of the passed pointer. For this > reason there is no need to have the same notation outside of > IS_ERR() itself. > > Clean up code

Re: [PATCH net-next 3/7] net: hns3: add support for forwarding packet to queues of specified TC when flow director rule hit

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 20:24 +0800, tanhuazhong wrote: > > On 2020/12/10 13:40, Saeed Mahameed wrote: > > On Thu, 2020-12-10 at 11:42 +0800, Huazhong Tan wrote: > > > From: Jian Shen > > > > > > For some new device, it supports forwarding packet to queues > > > of specified TC when flow director

Re: pull-request: can-next 2020-12-10

2020-12-10 Thread David Miller
From: Marc Kleine-Budde Date: Thu, 10 Dec 2020 10:55:00 +0100 > Hello Jakub, hello David, > > here's a pull request of 7 patches for net-next/master. > > The first patch is by Oliver Hartkopp for the CAN ISOTP, which adds support > for > functional addressing. > > A patch by Antonio Quartulli

Re: [PATCH net-next] net: stmmac: simplify the return tc_delete_knode()

2020-12-10 Thread David Miller
From: Zheng Yongjun Date: Thu, 10 Dec 2020 21:48:33 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied, thanks.

Re: [PATCH net-next] net/mlx4: simplify the return expression of mlx4_init_srq_table()

2020-12-10 Thread David Miller
From: Zheng Yongjun Date: Thu, 10 Dec 2020 21:50:00 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied.

Re: [PATCH net-next] net: mediatek: simplify the return expression of mtk_gmac_sgmii_path_setup()

2020-12-10 Thread David Miller
From: Zheng Yongjun Date: Thu, 10 Dec 2020 21:50:50 +0800 > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Applied, thanks.

Re: [PATCH rdma-next] RDMA/mlx4: remove bogus dev_base_lock usage

2020-12-10 Thread Jason Gunthorpe
On Tue, Dec 08, 2020 at 09:39:28PM +0200, Vladimir Oltean wrote: > It is not clear what this lock protects. If the authors wanted to ensure > that "dev" does not disappear, that is impossible, given the following > code path: > > mlx4_ib_netdev_event (under RTNL mutex) > -> mlx4_ib_scan_netdevs >

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Saeed Mahameed
On Thu, 2020-12-10 at 20:28 +0100, Lorenzo Bianconi wrote: > > On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > > > On Dec 10, Maciej Fijalkowski wrote: > > > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi > > > > wrote: > > > > > > On Thu, Dec 10, 2020 at 04:50:42PM +0100

Re: [net-next] tcp: correctly handle increased zerocopy args struct size

2020-12-10 Thread David Miller
From: Arjun Roy Date: Thu, 10 Dec 2020 11:16:03 -0800 > From: Arjun Roy > > A prior patch increased the size of struct tcp_zerocopy_receive > but did not update do_tcp_getsockopt() handling to properly account > for this. > > This patch simply reintroduces content erroneously cut from the > re

Re: [PATCH net-next] igc: Add new device ID

2020-12-10 Thread David Miller
From: Tony Nguyen Date: Thu, 10 Dec 2020 11:08:12 -0800 > From: Sasha Neftin > > Add new device ID for the next step of the silicon and > reflect the I226_K part. > > Signed-off-by: Sasha Neftin > Tested-by: Aaron Brown > Signed-off-by: Tony Nguyen > Applied.

Re: [PATCH net-next] net: lapbether: Consider it successful if (dis)connecting when already (dis)connected

2020-12-10 Thread David Miller
From: Xie He Date: Tue, 8 Dec 2020 14:50:44 -0800 > When the upper layer instruct us to connect (or disconnect), but we have > already connected (or disconnected), consider this operation successful > rather than failed. > > This can help the upper layer to correct its record about whether we a

Re: [PATCH bpf-next] net: xdp: introduce xdp_init_buff utility routine

2020-12-10 Thread Lorenzo Bianconi
> On Thu, 2020-12-10 at 20:28 +0100, Lorenzo Bianconi wrote: > > > On Thu, 2020-12-10 at 18:59 +0100, Lorenzo Bianconi wrote: > > > > On Dec 10, Maciej Fijalkowski wrote: > > > > > On Thu, Dec 10, 2020 at 05:32:41PM +0100, Lorenzo Bianconi > > > > > wrote: > > > > > > > On Thu, Dec 10, 2020 at 04:5

Re: [PATCH net-next] net: qualcomm: rmnet: Update rmnet device MTU based on real device

2020-12-10 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Wed, 9 Dec 2020 22:51:46 -0700 > Packets sent by rmnet to the real device have variable MAP header > lengths based on the data format configured. This patch adds checks > to ensure that the real device MTU is sufficient to transmit the MAP > packet comp

Re: [PATCH] Revert "macb: support the two tx descriptors on at91rm9200"

2020-12-10 Thread David Miller
From: Willy Tarreau Date: Wed, 9 Dec 2020 19:47:40 +0100 > This reverts commit 0a4e9ce17ba77847e5a9f87eed3c0ba46e3f82eb. > > The code was developed and tested on an MSC313E SoC, which seems to be > half-way between the AT91RM9200 and the AT91SAM9260 in that it supports > both the 2-descriptors

Re: [PATCH wireless -next] cw1200: txrx: convert comma to semicolon

2020-12-10 Thread Joe Perches
On Thu, 2020-12-10 at 18:50 +, Kalle Valo wrote: > Zheng Yongjun wrote: > > > Replace a comma between expression statements by a semicolon. > > > > Signed-off-by: Zheng Yongjun > > Patch applied to wireless-drivers-next.git, thanks. > > c42d492c672a cw1200: txrx: convert comma to semicolo

Re: [PATCH net-next] rtnetlink: RCU-annotate both dimensions of rtnl_msg_handlers

2020-12-10 Thread David Miller
From: Jakub Kicinski Date: Wed, 9 Dec 2020 18:16:08 -0800 > We use rcu_assign_pointer to assign both the table and the entries, > but the entries are not marked as __rcu. This generates sparse > warnings. > > Signed-off-by: Jakub Kicinski > --- Applied.

[PATCH] nfc: s3fwrn5: let core configure the interrupt trigger

2020-12-10 Thread Krzysztof Kozlowski
If interrupt trigger is not set when requesting the interrupt, the core will take care of reading trigger type from Devicetree. There is no point to do it in the driver. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/s3fwrn5/i2c.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

Re: [PATCH v2 0/1] net: Reduce rcu_barrier() contentions from 'unshare(CLONE_NEWNET)'

2020-12-10 Thread SeongJae Park
On Thu, 10 Dec 2020 15:09:10 +0100 Eric Dumazet wrote: > On Thu, Dec 10, 2020 at 9:09 AM SeongJae Park wrote: > > > > From: SeongJae Park > > > > On a few of our systems, I found frequent 'unshare(CLONE_NEWNET)' calls > > make the number of active slab objects including 'sock_inode_cache' type

[PATCH net-next 7/9] mptcp: parse and act on incoming FASTCLOSE option

2020-12-10 Thread Mat Martineau
From: Florian Westphal parse the MPTCP FASTCLOSE subtype. If provided key matches the local one, schedule the work queue to close (with tcp reset) all subflows. The MPTCP socket moves to closed state immediately. Reviewed-by: Matthieu Baerts Signed-off-by: Florian Westphal Signed-off-by: Mat

Re: [PATCH bpf] xsk: fix race in SKB mode transmit with shared cq

2020-12-10 Thread Alexei Starovoitov
On Thu, Dec 10, 2020 at 7:36 AM Magnus Karlsson wrote: > > From: Magnus Karlsson > > Fix a race when multiple sockets are simultaneously calling sendto() > when the completion ring is shared in the SKB case. This is the case > when you share the same netdev and queue id through the > XDP_SHARED_U

Re: pull-request: bpf 2020-12-10

2020-12-10 Thread David Miller
From: Alexei Starovoitov Date: Thu, 10 Dec 2020 14:25:01 -0800 > Hi David, hi Jakub, > > The following pull-request contains BPF updates for your *net* tree. > > We've added 21 non-merge commits during the last 12 day(s) which contain > a total of 21 files changed, 163 insertions(+), 88 deletio

Re: [patch 18/30] PCI: xilinx-nwl: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant fo

Re: [patch 19/30] PCI: mobiveil: Use irq_data_get_irq_chip_data()

2020-12-10 Thread Rob Herring
On Thu, Dec 10, 2020 at 1:42 PM Thomas Gleixner wrote: > > Going through a full irq descriptor lookup instead of just using the proper > helper function which provides direct access is suboptimal. > > In fact it _is_ wrong because the chip callback needs to get the chip data > which is relevant fo

RE: [PATCH net-next] net: x25: Remove unimplemented X.25-over-LLC code stubs

2020-12-10 Thread David Laight
From: Xie He > Sent: 10 December 2020 10:17 > > On Thu, Dec 10, 2020 at 1:14 AM David Laight wrote: > > > > > To me, LLC1 and LLC2 are to Ethernet what UDP and TCP are to IP > > > networks. I think we can use LLC1 and LLC2 wherever UDP and TCP can be > > > used, as long as we are in the same LAN

[PATCH net-next 9/9] mptcp: let MPTCP create max size skbs

2020-12-10 Thread Mat Martineau
From: Paolo Abeni Currently the xmit path of the MPTCP protocol creates smaller- than-max-size skbs, which is suboptimal for the performances. There are a few things to improve: - when coalescing to an existing skb, must clear the PUSH flag - tcp_build_frag() expect the available space as an arg

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-10 Thread Geva, Erez
On 10/12/2020 20:11, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 at 3:18 PM Geva, Erez wrote: >> >> >> On 09/12/2020 18:37, Willem de Bruijn wrote: >>> On Wed, Dec 9, 2020 at 10:25 AM Geva, Erez >>> wrote: On 09/12/2020 15:48, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 a

[PATCH iproute2-next 08/10] dcb: Add a subtool for the DCB PFC object

2020-12-10 Thread Petr Machata
PFC, for "Priority-based Flow Control", allows configuration of priority lossiness, and related toggles. Add a dcb subtool to allow showing and tweaking of individual PFC configuration options, and querying statistics. For example: # dcb pfc show dev eni1np1 pfc-cap 8 macsec-bypass on del

[PATCH iproute2-next 07/10] dcb: Add -i to enable IEC mode

2020-12-10 Thread Petr Machata
Allow switching "dcb" into the ISO/IEC mode of units by passing -i. Signed-off-by: Petr Machata --- dcb/dcb.c | 10 +++--- dcb/dcb.h | 1 + man/man8/dcb.8 | 5 + 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/dcb/dcb.c b/dcb/dcb.c index 9332a8b2e3d4..4b4a5b93

[PATCH iproute2-next 06/10] dcb: Add -s to enable statistics

2020-12-10 Thread Petr Machata
Allow selective display of statistical counters by passing -s. Signed-off-by: Petr Machata --- dcb/dcb.c | 9 +++-- dcb/dcb.h | 1 + man/man8/dcb.8 | 5 + 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/dcb/dcb.c b/dcb/dcb.c index 7c0beee43686..9332a8b2e3d4 1006

[PATCH iproute2-next 01/10] dcb: Remove unsupported command line arguments from getopt_long()

2020-12-10 Thread Petr Machata
getopt_long() currently includes "c" and "n" in the short option string. These probably slipped in as a cut'n'paste, and are not actually accepted. Remove them. Signed-off-by: Petr Machata --- dcb/dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dcb/dcb.c b/dcb/dcb.c ind

[PATCH iproute2-next 10/10] dcb: Add a subtool for the DCB maxrate object

2020-12-10 Thread Petr Machata
DCBNL maxrate interfaces are an extension to the 802.1q DCB interfaces and allow configuration of rate with which traffic in a given traffic class is sent. Add a dcb subtool to allow showing and tweaking of this per-TC maximum rate. For example: # dcb maxrate show dev eni1np1 tc-maxrate 0

[PATCH iproute2-next 04/10] man: dcb-ets: Remove an unnecessary empty line

2020-12-10 Thread Petr Machata
Signed-off-by: Petr Machata --- man/man8/dcb-ets.8 | 1 - 1 file changed, 1 deletion(-) diff --git a/man/man8/dcb-ets.8 b/man/man8/dcb-ets.8 index 1ef0948fb062..9c64b33e30ff 100644 --- a/man/man8/dcb-ets.8 +++ b/man/man8/dcb-ets.8 @@ -61,7 +61,6 @@ the DCB (Data Center Bridging) subsystem .ti -

[PATCH iproute2-next 03/10] dcb: ets: Change the way show parameters are given in synopsis

2020-12-10 Thread Petr Machata
None, one, or many parameters can be given on the command line, but the current synopsis allows only none or one. Fix it. Signed-off-by: Petr Machata --- dcb/dcb_ets.c | 6 +++--- man/man8/dcb-ets.8 | 13 ++--- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/dcb/dcb

<    1   2   3   >