Re: [PATCH net] vhost_net: fix high cpu load when sendmsg fails

2020-12-09 Thread Michael S. Tsirkin
On Wed, Dec 09, 2020 at 07:48:24PM +0800, wangyunjian wrote: > From: Yunjian Wang > > Currently we break the loop and wake up the vhost_worker when > sendmsg fails. When the worker wakes up again, we'll meet the > same error. This will cause high CPU load. To fix this issue, > we can skip this de

[PATCH net 1/2] net/mlx4_en: Avoid scheduling restart task if it is already running

2020-12-09 Thread Tariq Toukan
From: Moshe Shemesh Add restarting state flag to avoid scheduling another restart task while such task is already running. Change task name from watchdog_task to restart_task to better fit the task role. Fixes: 1e338db56e5a ("mlx4_en: Fix a race at restart task") Signed-off-by: Moshe Shemesh Si

[PATCH net 2/2] net/mlx4_en: Handle TX error CQE

2020-12-09 Thread Tariq Toukan
From: Moshe Shemesh In case error CQE was found while polling TX CQ, the QP is in error state and all posted WQEs will generate error CQEs without any data transmitted. Fix it by reopening the channels, via same method used for TX timeout handling. In addition add some more info on error CQE and

[PATCH net 0/2] mlx4_en fixes

2020-12-09 Thread Tariq Toukan
Hi, This patchset by Moshe contains fixes to the mlx4 Eth driver, addressing issues in restart flow. Patch 1 protects the restart task from being rescheduled while active. Please queue for -stable >= v2.6. Patch 2 reconstructs SQs stuck in error state, and adds prints for improved debuggabili

Re: [PATCH net v1] net: dsa: qca: ar9331: fix sleeping function called from invalid context bug

2020-12-09 Thread Oleksij Rempel
On Fri, Dec 04, 2020 at 04:00:35PM +0100, Marc Kleine-Budde wrote: > On 12/4/20 3:57 PM, Oleksij Rempel wrote: > [...] > > > > +static void ar9331_sw_irq_bus_sync_unlock(struct irq_data *d) > > { > > struct ar9331_sw_priv *priv = irq_data_get_irq_chip_data(d); > > struct regmap *regmap =

RE: [EXT] Re: [PATCH v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-09 Thread Mickey Rachamim
> On Tue, 8 Dec 2020 08:39:17 -0800 Jakub Kicinski wrote: > > On Tue, 8 Dec 2020 09:22:52 + Mickey Rachamim wrote: > > > > > +S: Supported > > > > > +W: http://www.marvell.com > > > > > > > > The website entry is for a project-specific website. If you have a link > > > > to a site wit

RE: [PATCH net] vhost_net: fix high cpu load when sendmsg fails

2020-12-09 Thread wangyunjian
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, December 9, 2020 8:50 PM > To: wangyunjian > Cc: jasow...@redhat.com; virtualizat...@lists.linux-foundation.org; > netdev@vger.kernel.org; Lilijun (Jerry) ; > chenchanghu ; xudingke > Subject: Re:

[PATCH net-next] net: rxrpc: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- net/rxrpc/recvmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/recvmsg.c b/net/rxrpc/recvmsg.c index 2c842851d72e..fef3573fdc8b 100644 --- a/net/rxrpc/recvmsg.c +++ b

[PATCH net-next] net: micrel: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/micrel/ks8851_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/micrel/ks8851_common.c b/drivers/net/ethernet/micrel/ks8851_common.

[PATCH net-next] net: mlx5: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/

[PATCH net-next] hisilicon/hns: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/eth

[PATCH net-next] hisilicon/hns3: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethern

[PATCH net-next] net: ethernet: ti: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/ti/davinci_mdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c index 7

[PATCH net-next] net: usb: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/usb/cdc-phonet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/cdc-phonet.c b/drivers/net/usb/cdc-phonet.c index dba847f28096..02e6bbb17b15 100644 ---

[PATCH net-next] net: thunderbolt: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/thunderbolt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c index 3160443ef3b9..ae83d66195a5 100644 --- a/drivers

[PATCH net-next] net: freescale: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/freescale/fsl_pq_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_md

[PATCH net-next] net: mv88e6xxx: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/dsa/mv88e6xxx/global1_atu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/global1_atu.c b/drivers/net/dsa/mv88e6xxx/global1_atu.c index bac9

[PATCH net-next] net: ipa: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/ipa/ipa_qmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c index 5090f0f923ad..174f093b66b8 100644 --- a/drivers

[PATCH v3] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-09 Thread Mickey Rachamim
Add maintainers info for new Marvell Prestera Ethernet switch driver. Signed-off-by: Mickey Rachamim --- 1. Update +W to link to the project source github page. 2. Remove +L as inherited from the entry of networking drivers. MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a

Re: [PATCH bpf v3 3/7] netdevsim: Add debugfs toggle to reject BPF programs in verifier

2020-12-09 Thread Toke Høiland-Jørgensen
Toke Høiland-Jørgensen writes: > From: Toke Høiland-Jørgensen > > This adds a new debugfs toggle ('bpf_bind_verifier_accept') that can be > used to make netdevsim reject BPF programs from being accepted by the > verifier. If this toggle (which defaults to true) is set to false, > nsim_bpf_verify

[PATCH wireless -next] cw1200: txrx: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/wireless/st/cw1200/txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/st/cw1200/txrx.c b/drivers/net/wireless/st/cw1200/txrx.c index 400dd58591

[PATCH wireless -next] mt76: mt7915: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76

[PATCH wireless -next] mt76: mt7615: convert comma to semicolon

2020-12-09 Thread Zheng Yongjun
Replace a comma between expression statements by a semicolon. Signed-off-by: Zheng Yongjun --- drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76

[PATCH bpf v4 4/7] selftests/bpf/test_offload.py: only check verifier log on verification fails

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Since commit 6f8a57ccf851 ("bpf: Make verifier log more relevant by default"), the verifier discards log messages for successfully-verified programs. This broke test_offload.py which is looking for a verification message from the driver callback. Change test_offload.p

[PATCH bpf v4 3/7] netdevsim: Add debugfs toggle to reject BPF programs in verifier

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This adds a new debugfs toggle ('bpf_bind_verifier_accept') that can be used to make netdevsim reject BPF programs from being accepted by the verifier. If this toggle (which defaults to true) is set to false, nsim_bpf_verify_insn() will return EOPNOTSUPP on the last i

[PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order

2020-12-09 Thread Toke Høiland-Jørgensen
This series restores the test_offload.py selftest to working order. It seems a number of subtle behavioural changes have crept into various subsystems which broke test_offload.py in a number of ways. Most of these are fairly benign changes where small adjustments to the test script seems to be the

[PATCH bpf v4 5/7] selftests/bpf/test_offload.py: fix expected case of extack messages

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Commit 7f0a838254bd ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device") changed the case of some of the extack messages being returned when attaching of XDP programs failed. This broke test_offload.py, so let's fix the test to reflect this. Fixes:

[PATCH bpf v4 6/7] selftests/bpf/test_offload.py: reset ethtool features after failed setting

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen When setting the ethtool feature flag fails (as expected for the test), the kernel now tracks that the feature was requested to be 'off' and refuses to subsequently disable it again. So reset it back to 'on' so a subsequent disable (that's not supposed to fail) can su

[PATCH 0/2] Add LED mode behavior/select properties and handle

2020-12-09 Thread Ivan Mikhaylov
In KSZ9131 PHY it is possible to control LEDs blink behavior via LED mode behavior and select registers. Add DTS properties plus handles of them inside micrel PHY driver. I've some concerns about passing raw register values into LED mode select and behavior. It can be passed via array like in micr

[PATCH 1/2] net: phy: micrel: add LED control on KSZ9131

2020-12-09 Thread Ivan Mikhaylov
Add the possibility to read the LED configuration via DTS properties from KSZ9131 PHY node. Add the new proprties and handle for them: micrel,led-mode-behavior micrel,led-mode-select Signed-off-by: Ivan Mikhaylov --- drivers/net/phy/micrel.c | 69 +++- 1 file

[PATCH 2/2] dt-bindings: net: phy: micrel: add LED mode behavior and select properties

2020-12-09 Thread Ivan Mikhaylov
Add LED mode behavior and LED mode select properties which can be used in KSZ9131 PHY. Signed-off-by: Ivan Mikhaylov --- Documentation/devicetree/bindings/net/micrel.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/net/micrel.txt b/Documentation/d

[PATCH bpf v4 1/7] xdp: remove the xdp_attachment_flags_ok() callback

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Since commit 7f0a838254bd ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device"), the XDP program attachment info is now maintained in the core code. This interacts badly with the xdp_attachment_flags_ok() check that prevents unloading an XDP program w

[PATCH bpf v4 2/7] selftests/bpf/test_offload.py: Remove check for program load flags match

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Since we just removed the xdp_attachment_flags_ok() callback, also remove the check for it in test_offload.py, and replace it with a test for the new ambiguity-avoid check when multiple programs are loaded. Fixes: 7f0a838254bd ("bpf, xdp: Maintain info on attached XD

Re: [PATCH v4 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-09 Thread Oleksij Rempel
Hi George, On Fri, Dec 04, 2020 at 04:04:07PM -0600, George McCollister wrote: > On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote: > > > > Add stats support for the ar9331 switch. > > > > Signed-off-by: Oleksij Rempel > > --- > > drivers/net/dsa/qca/ar9331.c | 247 +++

Re: [PATCH net-next 1/4] ptp: clockmatrix: reset device and check BOOT_STATUS

2020-12-09 Thread Richard Cochran
On Tue, Dec 08, 2020 at 10:41:54AM -0500, min.li...@renesas.com wrote: > From: Min Li > > SM_RESET device only when loading full configuration and check > for BOOT_STATUS. Also remove polling for write trigger done in > _idtcm_settime(). > > Changes since v1: > -Correct warnings from strict chec

[PATCH bpf v4 7/7] selftests/bpf/test_offload.py: filter bpftool internal map when counting maps

2020-12-09 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen A few of the tests in test_offload.py expects to see a certain number of maps created, and checks this by counting the number of maps returned by bpftool. There is already a filter that will remove any maps already there at the beginning of the test, but bpftool now c

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-09 Thread Andrew Lunn
On Tue, Dec 08, 2020 at 10:49:16PM -0500, Sven Van Asbroeck wrote: > On Tue, Dec 8, 2020 at 6:36 PM Florian Fainelli wrote: > > > > dma_sync_single_for_{cpu,device} is what you would need in order to make > > a partial cache line invalidation. You would still need to unmap the > > same address+len

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Tobias Waldekranz
On Wed, Dec 09, 2020 at 12:53, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 09:37:39AM +0100, Tobias Waldekranz wrote: >> I will remove `struct dsa_lag` in v4. > > Ok, thanks. > It would be nice if you could also make .port_lag_leave return an int code. Sure. > And I think that .port_lag_cha

Re: [PATCH net 1/4] net: freescale/fman: Split the main resource region reservation

2020-12-09 Thread Patrick Havelange
area. I'm assuming this is the problem you are trying to address here, besides the stack corruption issue. Yes exactly. I did not add this behaviour (having a main region and subdrivers using subregions), I'm just trying to correct what is already there. For example: this is some content of /pro

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 12:53:26PM +0200, Vladimir Oltean wrote: > On Wed, Dec 09, 2020 at 09:37:39AM +0100, Tobias Waldekranz wrote: > > I will remove `struct dsa_lag` in v4. > > Ok, thanks. > It would be nice if you could also make .port_lag_leave return an int code. I've not looked at the code

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Andrew Lunn
> I disagree. A LAG is one type of netdev that a DSA port can offload. The > other one is the DSA port's own netdev, i.e. what we have had since time > immemorial. > > dsa_port_offloads_netdev(dp, dev)? That is better. But a comment explaining what the function does might be useful. Andrew

[PATCH bpf-next] selftests/bpf: Fix selftest compilation on clang 11

2020-12-09 Thread Jiri Olsa
We can't compile test_core_reloc_module.c selftest with clang 11, compile fails with: CLNG-LLC [test_maps] test_core_reloc_module.o progs/test_core_reloc_module.c:57:21: error: use of unknown builtin \ '__builtin_preserve_type_info' [-Wimplicit-function-declaration] out->read_ctx_sz = bpf

Re: [PATCH v1] ARM: imx: mach-imx6ul: remove 14x14 EVK specific PHY fixup

2020-12-09 Thread Fabio Estevam
On Wed, Dec 9, 2020 at 9:21 AM Oleksij Rempel wrote: > > Remove board specific PHY fixup introduced by commit: > > | 709bc0657fe6f9f5 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup > init") > > This fixup addresses boards with a specific configuration: a KSZ8081RNA > PHY with attached cl

Re: [PATCH] net: ethernet: fec: Clear stale flag in IEVENT register before MII transfers

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 11:29:59AM +0100, Uwe Kleine-König wrote: > For some mii transfers the MII bit in the event register is already set > before a read or write transfer is started. This breaks evaluating the > transfer's result because it is checked too early. > > Before MII transfers were sw

Re: [PATCH net-next] net: mv88e6xxx: convert comma to semicolon

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 09:39:38PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-09 Thread Eyal Birger
Hi Phil, On Tue, Dec 8, 2020 at 8:51 PM Phil Sutter wrote: > > Hi Eyal, > > On Tue, Dec 08, 2020 at 04:47:02PM +0200, Eyal Birger wrote: > > On Mon, Dec 7, 2020 at 4:07 PM Phil Sutter wrote: > > > > > > With an IPsec tunnel without dedicated interface, netfilter sees locally > > > generated pack

Re: [PATCH net-next] net: thunderbolt: convert comma to semicolon

2020-12-09 Thread Mika Westerberg
On Wed, Dec 09, 2020 at 09:38:52PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Acked-by: Mika Westerberg

Re: [PATCH net v2] tun: fix ubuf refcount incorrectly on error path

2020-12-09 Thread Willem de Bruijn
On Wed, Dec 9, 2020 at 8:03 AM wangyunjian wrote: > > From: Yunjian Wang > > After setting callback for ubuf_info of skb, the callback > (vhost_net_zerocopy_callback) will be called to decrease > the refcount when freeing skb. But when an exception occurs With exception, you mean if tun_get_user

Re: [PATCH] net: ethernet: fec: Clear stale flag in IEVENT register before MII transfers

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 11:29:59AM +0100, Uwe Kleine-König wrote: > For some mii transfers the MII bit in the event register is already set > before a read or write transfer is started. This breaks evaluating the > transfer's result because it is checked too early. > > Before MII transfers were sw

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-09 Thread Hans de Goede
Hi, On 12/8/20 5:14 PM, Alexander Duyck wrote: > On Tue, Dec 8, 2020 at 1:30 AM Hans de Goede wrote: >> >> Hi, >> >> On 12/8/20 6:08 AM, Neftin, Sasha wrote: >>> On 12/7/2020 17:41, Limonciello, Mario wrote: > First of all thank you for working on this. > > I must say though that I do

Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Martin Zaharinov
Hi All I have problem with latest kernel release And the problem is base on this late problem : https://www.mail-archive.com/search?l=netdev@vger.kernel.org&q=subject:%22Re%5C%3A+ppp%5C%2Fpppoe%2C+still+panic+4.15.3+in+ppp_push%22&o=newest&f=1 I have same problem in kernel 5.6 > now I use kern

Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-09 Thread kernel test robot
/scm/linux/kernel/git/robh/linux.git for-next config: x86_64-randconfig-s022-20201209 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-179-ga00755aa-dirty # https://github.com/0day-ci/li

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Willem de Bruijn
On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: > > Configure and send TX sending hardware timestamp from > user space application to the socket layer, > to provide to the TC ETC Qdisc, and pass it to > the interface network driver. > > - New flag for the SO_TXTIME socket option. > - New acce

[PATCH 1/3] bus: mhi: core: Add helper API to return number of free TREs

2020-12-09 Thread Loic Poulain
From: Hemant Kumar Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam -

[PATCH 2/3] net: mhi: Get RX queue size from MHI core

2020-12-09 Thread Loic Poulain
The RX queue size can be determined at runtime by retrieveing the number of available transfer descriptors Signed-off-by: Loic Poulain --- drivers/net/mhi_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c index 8e72d94..

[PATCH 3/3] net: mhi: Add dedicated alloc thread

2020-12-09 Thread Loic Poulain
The buffer allocation for RX path is currently done by a work executed in the system workqueue. The work to do is quite simple and consists mostly in allocating and queueing as much as possible buffers to the MHI RX channel. It appears that using a dedicated kthread would be more appropriate to pr

Re: [PATCH net-next] net: rxrpc: convert comma to semicolon

2020-12-09 Thread David Howells
Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Reviewed-by: David Howells

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-09 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 2:38 PM Jakub Kicinski wrote: > > On Sat, 5 Dec 2020 18:43:54 -0500 Jarod Wilson wrote: > > I'm seeing a system get stuck unable to bring a downed interface back up > > when it's got an updelay value set, behavior which ceased when logging > > spew was removed from bond_mii

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-09 Thread Paraschiv, Andra-Irina
On 09/12/2020 12:48, Stefano Garzarella wrote: On Tue, Dec 08, 2020 at 10:42:22AM -0800, Jakub Kicinski wrote: On Tue, 8 Dec 2020 20:23:24 +0200 Paraschiv, Andra-Irina wrote: >> --- a/include/uapi/linux/vm_sockets.h >> +++ b/include/uapi/linux/vm_sockets.h >> @@ -145,7 +145,7 @@ >> >>   stru

Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Geva, Erez
On 09/12/2020 15:48, Willem de Bruijn wrote: > On Wed, Dec 9, 2020 at 9:37 AM Erez Geva wrote: >> >> Configure and send TX sending hardware timestamp from >> user space application to the socket layer, >> to provide to the TC ETC Qdisc, and pass it to >> the interface network driver. >> >>

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Tobias Waldekranz
On Wed, Dec 09, 2020 at 15:27, Andrew Lunn wrote: >> I disagree. A LAG is one type of netdev that a DSA port can offload. The >> other one is the DSA port's own netdev, i.e. what we have had since time >> immemorial. >> >> dsa_port_offloads_netdev(dp, dev)? > > That is better. ...but there is an

Re: [PATCH net] bonding: reduce rtnl lock contention in mii monitor thread

2020-12-09 Thread Jarod Wilson
On Tue, Dec 8, 2020 at 3:35 PM Jay Vosburgh wrote: > > Jarod Wilson wrote: > > >I'm seeing a system get stuck unable to bring a downed interface back up > >when it's got an updelay value set, behavior which ceased when logging > >spew was removed from bond_miimon_inspect(). I'm monitoring logs on

Re: [PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order

2020-12-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf.git (refs/heads/master): On Wed, 09 Dec 2020 14:57:36 +0100 you wrote: > This series restores the test_offload.py selftest to working order. It seems a > number of subtle behavioural changes have crept into various subsystems which > broke test_offload.py

Re: [PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order

2020-12-09 Thread Daniel Borkmann
On 12/9/20 2:57 PM, Toke Høiland-Jørgensen wrote: This series restores the test_offload.py selftest to working order. It seems a number of subtle behavioural changes have crept into various subsystems which broke test_offload.py in a number of ways. Most of these are fairly benign changes where s

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-09 Thread David Ahern
On 12/9/20 4:52 AM, Jesper Dangaard Brouer wrote: >>> still load and either share queues across multiple cores or restirct >>> down to a subset of CPUs. >> >> And that's the missing piece of logic, I suppose. >> >>> Do you need 192 cores for a 10gbps nic, probably not. >> >> Let's hear from Jes

[PATCH 1/3] Add TX sending hardware timestamp.

2020-12-09 Thread Erez Geva
Configure and send TX sending hardware timestamp from user space application to the socket layer, to provide to the TC ETC Qdisc, and pass it to the interface network driver. - New flag for the SO_TXTIME socket option. - New access auxiliary data header to pass the TX sending hardware time

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-09 Thread David Ahern
On 12/9/20 4:52 AM, Jesper Dangaard Brouer wrote: > But I have redesigned the ndo_xdp_xmit call to take a bulk of packets > (up-to 16) so it should not be a problem to solve this by sharing > TX-queue and talking a lock per 16 packets. I still recommend that, > for fallback case, you allocated a

Re: [PATCH 2/3] net: mhi: Get RX queue size from MHI core

2020-12-09 Thread Jeffrey Hugo
On 12/9/2020 8:03 AM, Loic Poulain wrote: The RX queue size can be determined at runtime by retrieveing the retrieving number of available transfer descriptors Signed-off-by: Loic Poulain --- drivers/net/mhi_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

KASAN: use-after-free Write in rtl_fw_do_work (2)

2020-12-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b175d273 USB: legotower: fix logical error in recent commit git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing console output: https://syzkaller.appspot.com/x/log.txt?x=12ee7c8750 kernel confi

[PATCH net] net: sched: Fix dump of MPLS_OPT_LSE_LABEL attribute in cls_flower

2020-12-09 Thread Guillaume Nault
TCA_FLOWER_KEY_MPLS_OPT_LSE_LABEL is a u32 attribute (MPLS label is 20 bits long). Fixes the following bug: $ tc filter add dev ethX ingress protocol mpls_uc \ flower mpls lse depth 2 label 256 \ action drop $ tc filter show dev ethX ingress filter protocol mpls_uc pre

[PATCH 3/3] The TC ETF Qdisc pass the hardware timestamp to the interface driver.

2020-12-09 Thread Erez Geva
The ETF pass the TX sending hardware timestamp to the network interface driver. - Add new flag to the ETF Qdisc setting that mandate the use of the hardware timestamp in a socket's buffer. - The ETF Qdisc pass the TX sending hardware timestamp to the network interface driver. Signed-

[PATCH 0/3] Add sending TX hardware timestamp for TC ETF Qdisc

2020-12-09 Thread Erez Geva
Add support for TX sending hardware timestamp with Traffic control Earliest TxTime First (ETF) Qdisc. Why do we need additional timestamp? Current ETF requires to synchronization the system clock to the PTP Hardware clock (PHC) we want to send through. But there are cases that we can not synchron

[PATCH 2/3] Pass TX sending hardware timestamp to a socket's buffer.

2020-12-09 Thread Erez Geva
Pass TX sending hardware timestamp from the socket layer to a socket's buffer. The TC ETC Qdisc will pass it to the interface network driver. - Add the hardware timestamp to the IP cork, to support the use of IP/UDP with the TX sending hardware timestamp when sending through the TC ETF Qd

Re: [PATCH bpf-next v4 0/5] selftests/bpf: xsk selftests

2020-12-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 7 Dec 2020 21:53:28 + you wrote: > This patch set adds AF_XDP selftests based on veth to selftests/bpf. > > # Topology: > # - > # --- > # _ | Process | _ > #

[PATCH net-next 0/4] HTB offload

2020-12-09 Thread Maxim Mikityanskiy
This series adds support for HTB offload to the HTB qdisc, and adds usage to mlx5 driver. The previous RFCs are available at [1], [2]. The feature is intended to solve the performance bottleneck caused by the single lock of the HTB qdisc, which prevents it from scaling well. The HTB algorithm its

[PATCH net-next 1/4] net: sched: Add multi-queue support to sch_tree_lock

2020-12-09 Thread Maxim Mikityanskiy
The existing qdiscs that set TCQ_F_MQROOT don't use sch_tree_lock. However, hardware-offloaded HTB will start setting this flag while also using sch_tree_lock. The current implementation of sch_tree_lock basically locks on qdisc->dev_queue->qdisc, and it works fine when the tree is attached to som

[PATCH net-next 3/4] sch_htb: Stats for offloaded HTB

2020-12-09 Thread Maxim Mikityanskiy
This commit adds support for statistics of offloaded HTB. Bytes and packets counters for leaf and inner nodes are supported, the values are taken from per-queue qdiscs, and the numbers that the user sees should have the same behavior as the software (non-offloaded) HTB. Signed-off-by: Maxim Mikity

[PATCH net-next 4/4] net/mlx5e: Support HTB offload

2020-12-09 Thread Maxim Mikityanskiy
This commit adds support for HTB offload in the mlx5e driver. Performance: NIC: Mellanox ConnectX-6 Dx CPU: Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (24 cores with HT) 100 Gbit/s line rate, 500 UDP streams @ ~200 Mbit/s each 48 traffic classes, flower used for steering No shaping (rat

[PATCH net-next 2/4] sch_htb: Hierarchical QoS hardware offload

2020-12-09 Thread Maxim Mikityanskiy
HTB doesn't scale well because of contention on a single lock, and it also consumes CPU. This patch adds support for offloading HTB to hardware that supports hierarchical rate limiting. This solution addresses two main problems of scaling HTB: 1. Contention by flow classification. Currently the f

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-09 Thread Vladimir Oltean
On Wed, Dec 09, 2020 at 03:11:41PM +0100, Tobias Waldekranz wrote: > On Wed, Dec 09, 2020 at 12:53, Vladimir Oltean wrote: > > And I think that .port_lag_change passes more arguments than needed to > > the driver. > > You mean the `struct netdev_lag_lower_state_info`? Fine by me, it was > mostly

Re: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote: > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45. > This extends the probing of C45 PHY devices on the MDIO bus. > > Signed-off-by: Wong Vee Khee > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 + > 1 fi

[PATCH net-next] nfp: silence set but not used warning with IPV6=n

2020-12-09 Thread Jakub Kicinski
Test robot reports: drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_rx_resync_req': drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable 'ipv6h' set but not used [-Wunused-but-set-variable] 477 | struct ipv6hdr *ipv6h; | ^~

Re: [EXT] Re: [PATCH v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-09 Thread Andrew Lunn
> You can see that only yesterday (Dec 8th) we had the first official > merge on this repo - this is the reason for the lack of commits. > Marvell Switching group took strategic decision to open some aspects > of the Prestera family devices with the Open Source community and > this is the first ste

Re: [PATCH bpf v4 0/7] selftests/bpf: Restore test_offload.py to working order

2020-12-09 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 12/9/20 2:57 PM, Toke Høiland-Jørgensen wrote: >> This series restores the test_offload.py selftest to working order. It seems >> a >> number of subtle behavioural changes have crept into various subsystems which >> broke test_offload.py in a number of ways. Most of

Re: Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Guillaume Nault
On Wed, Dec 09, 2020 at 04:47:52PM +0200, Martin Zaharinov wrote: > Hi All > > I have problem with latest kernel release > And the problem is base on this late problem : > > > https://www.mail-archive.com/search?l=netdev@vger.kernel.org&q=subject:%22Re%5C%3A+ppp%5C%2Fpppoe%2C+still+panic+4.15.3

Re: [PATCH] net: ethernet: fec: Clear stale flag in IEVENT register before MII transfers

2020-12-09 Thread Uwe Kleine-König
Hi Andrew, On Wed, Dec 09, 2020 at 03:44:13PM +0100, Andrew Lunn wrote: > On Wed, Dec 09, 2020 at 11:29:59AM +0100, Uwe Kleine-König wrote: > Do you have > > ommit 1e6114f51f9d4090390fcec2f5d67d8cc8dc4bfc > Author: Greg Ungerer > Date: Wed Oct 28 15:22:32 2020 +1000 > > net: fec: fix MDIO

Re: [EXT] Re: [PATCH v2] octeontx2-pf: Add RSS multi group support

2020-12-09 Thread Geethasowjanya Akula
Thanks, Jakub. Will address your comments in next version. From: Jakub Kicinski Sent: Wednesday, December 9, 2020 3:04 AM To: Geethasowjanya Akula Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Sunil Kovvuri Goutham; da...@davemloft.net; Subba

Re: [PATCH net-next] nfp: silence set but not used warning with IPV6=n

2020-12-09 Thread Simon Horman
On Wed, Dec 09, 2020 at 08:18:21AM -0800, Jakub Kicinski wrote: > Test robot reports: > > drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function > 'nfp_net_tls_rx_resync_req': > drivers/net/ethernet/netronome/nfp/crypto/tls.c:477:18: warning: variable > 'ipv6h' set but not used [-Wunused-b

Re: Urgent: BUG: PPP ioctl Transport endpoint is not connected

2020-12-09 Thread Martin Zaharinov
Hi Nault > On 9 Dec 2020, at 18:40, Guillaume Nault wrote: > > On Wed, Dec 09, 2020 at 04:47:52PM +0200, Martin Zaharinov wrote: >> Hi All >> >> I have problem with latest kernel release >> And the problem is base on this late problem : >> >> >> https://www.mail-archive.com/search?l=netde

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-09 Thread Kuniyuki Iwashima
From: Kuniyuki Iwashima Date: Wed, 9 Dec 2020 17:05:09 +0900 > From: Martin KaFai Lau > Date: Tue, 8 Dec 2020 19:09:03 -0800 > > On Tue, Dec 08, 2020 at 05:17:48PM +0900, Kuniyuki Iwashima wrote: > > > From: Martin KaFai Lau > > > Date: Mon, 7 Dec 2020 23:34:41 -0800 > > > > On Tue,

[PATCH v3 5/8] dt-bindings: add documentation for sama7g5 ethernet interface

2020-12-09 Thread Claudiu Beznea
Add documentation for SAMA7G5 ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net

Re: [PATCH -next] net/mlx5_core: remove unused including

2020-12-09 Thread Jakub Kicinski
On Wed, 9 Dec 2020 08:21:00 +0200 Leon Romanovsky wrote: > On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote: > > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote: > > > Remove including that don't need it. > > > > > > Signed-off-by: Zou Wei > > > --- > > > drivers/net/ethernet/mel

INFO: task can't die in p9_client_rpc (2)

2020-12-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:0eedceaf Add linux-next specific files for 20201201 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1df750 kernel config: https://syzkaller.appspot.com/x/.config?x=55aec7153b7827ea dashboard

[PATCH v3 8/8] net: macb: add support for sama7g5 emac interface

2020-12-09 Thread Claudiu Beznea
Add support for SAMA7G5 10/100Mbps interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c ind

[PATCH v3 2/8] net: macb: add capability to not set the clock rate

2020-12-09 Thread Claudiu Beznea
SAMA7G5's ethernet IPs TX clock could be provided by its generic clock or by the external clock provided by the PHY. The internal IP logic divides properly this clock depending on the link speed. The patch adds a new capability so that macb_set_tx_clock() to not be called for IPs having this capabi

[PATCH v3 3/8] net: macb: add function to disable all macb clocks

2020-12-09 Thread Claudiu Beznea
Add function to disable all macb clocks. Signed-off-by: Claudiu Beznea Suggested-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 38 ++-- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/driver

[PATCH v3 7/8] net: macb: add support for sama7g5 gem interface

2020-12-09 Thread Claudiu Beznea
Add support for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence

[PATCH v3 4/8] net: macb: unprepare clocks in case of failure

2020-12-09 Thread Claudiu Beznea
Unprepare clocks in case of any failure in fu540_c000_clk_init(). Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git

[PATCHv3 net-next] octeontx2-pf: Add RSS multi group support

2020-12-09 Thread Geetha sowjanya
Hardware supports 8 RSS groups per interface. Currently we are using only group '0'. This patch allows user to create new RSS groups/contexts and use the same as destination for flow steering rules. usage: To steer the traffic to RQ 2,3 ethtool -X eth0 weight 0 0 1 1 context new (It will print th

[PATCH v3 1/8] net: macb: add userio bits as platform configuration

2020-12-09 Thread Claudiu Beznea
This is necessary for SAMA7G5 as it uses different values for PHY interface and also introduces hdfctlen bit. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb.h | 10 ++ drivers/net/ethernet/cadence/macb_main.c | 28 ++

<    1   2   3   4   >