Re: [PATCH 065/141] airo: Fix fall-through warnings for Clang

2020-12-08 Thread Kalle Valo
"Gustavo A. R. Silva" wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-08 Thread Martin KaFai Lau
On Tue, Dec 08, 2020 at 03:27:14PM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Mon, 7 Dec 2020 12:14:38 -0800 > > On Sun, Dec 06, 2020 at 01:03:07AM +0900, Kuniyuki Iwashima wrote: > > > From: Martin KaFai Lau > > > Date: Fri, 4 Dec 2020 17:42:41 -0800 > > > > On Tue,

Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications

2020-12-08 Thread Rasmus Villemoes
On 08/12/2020 04.07, Qiang Zhao wrote: > On 06/12/2020 05:12, Rasmus Villemoes wrote: > >> I think patch 2 is a bug fix as well, but I'd like someone from NXP to >> comment. > > It 's ok for me. I was hoping for something a bit more than that. Can you please go check with the people who made

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-08 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Mon, 7 Dec 2020 23:34:41 -0800 > On Tue, Dec 08, 2020 at 03:31:34PM +0900, Kuniyuki Iwashima wrote: > > From: Martin KaFai Lau > > Date: Mon, 7 Dec 2020 12:33:15 -0800 > > > On Thu, Dec 03, 2020 at 11:14:24PM +0900, Kuniyuki Iwashima wrote: > > > > From: Eri

[PATCHv3 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2020-12-08 Thread Hangbin Liu
This patch add a xdp program on egress to show that we can modify the packet on egress. In this sample we will set the pkt's src mac to egress's mac address. The xdp_prog will be attached when -X option supplied. Signed-off-by: Hangbin Liu --- v3: a) modify the src mac address based on egress mac

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-08 Thread subashab
What about just returning an error on NETDEV_PRECHANGEMTU notification to prevent real device MTU change while virtual rmnet devices are linked? Not sure there is a more proper and thread safe way to manager that otherwise. Can't you copy what vlan devices do? That'd seem like a reasonable and

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-08 Thread Ard Biesheuvel
On Mon, 7 Dec 2020 at 15:15, David Howells wrote: > > Ard Biesheuvel wrote: > > > > I wonder if it would help if the input buffer and output buffer didn't > > > have to correspond exactly in usage - ie. the output buffer could be used > > > at a slower rate than the input to allow for buffering i

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-08 Thread Jesper Dangaard Brouer
On Mon, 7 Dec 2020 18:01:00 -0700 David Ahern wrote: > On 12/7/20 1:52 PM, John Fastabend wrote: > >> > >> I think we need to keep XDP_TX action separate, because I think that > >> there are use-cases where the we want to disable XDP_TX due to end-user > >> policy or hardware limitations. > >

Re: [PATCH net] net: ll_temac: Fix potential NULL dereference in temac_probe()

2020-12-08 Thread Esben Haabendal
Zhang Changzhong writes: > platform_get_resource() may fail and in this case a NULL dereference > will occur. > > Fix it to use devm_platform_ioremap_resource() instead of calling > platform_get_resource() and devm_ioremap(). > > This is detected by Coccinelle semantic patch. > > @@ > expression

[PATCH] net: 8021q: vlan: reduce noise in driver initialization

2020-12-08 Thread Enrico Weigelt, metux IT consult
If drivers work properly, they should be silent. Thus remove the unncessary noise von initialization. Signed-off-by: Enrico Weigelt, metux IT consult --- net/8021q/vlan.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..9f4b1b9a37e4

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-08 Thread Enrico Weigelt, metux IT consult
On 05.12.20 16:53, Greg KH wrote: >> How do we feel about deleting this not really informative message >> altogether in a future patch? > > It too should be removed. If drivers are working properly, they are > quiet. Just sent a separate patch for removing this message. I'll rebase my patch queu

[PATCH net-next] net: dsa: mv88e6xxx: don't set non-existing learn2all bit for 6220/6250

2020-12-08 Thread Rasmus Villemoes
The 6220 and 6250 switches do not have a learn2all bit in global1, ATU control register; bit 3 is reserved. On the switches that do have that bit, it is used to control whether learning frames are sent out the ports that have the message_port bit set. So rather than adding yet another chip method,

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-08 Thread Jesper Dangaard Brouer
On Mon, 07 Dec 2020 12:52:22 -0800 John Fastabend wrote: > > Use-case(1): Cloud-provider want to give customers (running VMs) ability > > to load XDP program for DDoS protection (only), but don't want to allow > > customer to use XDP_TX (that can implement LB or cheat their VM > > isolation polic

Re: [PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-08 Thread Nicolas Dichtel
Le 07/12/2020 à 14:43, Phil Sutter a écrit : > With an IPsec tunnel without dedicated interface, netfilter sees locally > generated packets twice as they exit the physical interface: Once as "the > inner packet" with IPsec context attached and once as the encrypted > (ESP) packet. > > With xfrm_in

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-08 Thread Kuniyuki Iwashima
From: Martin KaFai Lau Date: Tue, 8 Dec 2020 00:13:28 -0800 > On Tue, Dec 08, 2020 at 03:27:14PM +0900, Kuniyuki Iwashima wrote: > > From: Martin KaFai Lau > > Date: Mon, 7 Dec 2020 12:14:38 -0800 > > > On Sun, Dec 06, 2020 at 01:03:07AM +0900, Kuniyuki Iwashima wrote: > > > > From: Mar

Re: [PATCH v3 09/11] dt-bindings: usb: convert mediatek,mtk-xhci.txt to YAML schema

2020-12-08 Thread Chunfeng Yun
On Mon, 2020-12-07 at 15:24 -0600, Rob Herring wrote: > On Wed, Nov 18, 2020 at 04:21:24PM +0800, Chunfeng Yun wrote: > > Convert mediatek,mtk-xhci.txt to YAML schema mediatek,mtk-xhci.yaml > > > > Signed-off-by: Chunfeng Yun > > --- > > v3: > > 1. fix yamllint warning > > 2. remove pinctrl*

Re: [PATCH v3 10/11] dt-bindings: usb: convert mediatek,mtu3.txt to YAML schema

2020-12-08 Thread Chunfeng Yun
On Mon, 2020-12-07 at 15:30 -0600, Rob Herring wrote: > On Wed, Nov 18, 2020 at 04:21:25PM +0800, Chunfeng Yun wrote: > > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > > > Signed-off-by: Chunfeng Yun > > --- > > v3: > > 1. fix yamllint warning > > 2. remove pinctrl* properti

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-08 Thread David Howells
Ard Biesheuvel wrote: Ard Biesheuvel wrote: > > > > I wonder if it would help if the input buffer and output buffer didn't > > > > have to correspond exactly in usage - ie. the output buffer could be > > > > used at a slower rate than the input to allow for buffering inside the > > > > crypto a

[PATCH net-next] net: Limit logical shift left of TCP probe0 timeout

2020-12-08 Thread Cambda Zhu
For each TCP zero window probe, the icsk_backoff is increased by one and its max value is tcp_retries2. If tcp_retries2 is greater than 63, the probe0 timeout shift may exceed its max bits. On x86_64/ARMv8/MIPS, the shift count would be masked to range 0 to 63. And on ARMv7 the result is zero. If t

RE: [EXT] Re: [PATCH v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-08 Thread Mickey Rachamim
Hi Jakub, thanks for the guidelines. > On Sat, 5 Dec 2020 18:43:00 +0200 Mickey Rachamim wrote: > > Add maintainers info for new Marvell Prestera Ethernet switch driver. > > > > Signed-off-by: Mickey Rachamim > > --- > > v2: > > Update the maintainers list according to community recommendation.

[PATCH net-next 00/13] mlxsw: Add support for Q-in-VNI

2020-12-08 Thread Ido Schimmel
From: Ido Schimmel This patch set adds support for Q-in-VNI over Spectrum-{2,3} ASICs. Q-in-VNI is like regular VxLAN encapsulation with the sole difference that overlay packets can contain a VLAN tag. In Linux, this is achieved by adding the VxLAN device to a 802.1ad bridge instead of a 802.1q b

[PATCH net-next 04/13] mlxsw: spectrum_switchdev: Create common function for joining VxLAN to VLAN-aware bridge

2020-12-08 Thread Ido Schimmel
From: Amit Cohen The code in mlxsw_sp_bridge_8021q_vxlan_join() can be used also for 802.1ad bridge. Move the code to function called mlxsw_sp_bridge_vlan_aware_vxlan_join() and call it from mlxsw_sp_bridge_8021q_vxlan_join() to enable code reuse. Signed-off-by: Amit Cohen Reviewed-by: Petr Ma

[PATCH net-next 02/13] mlxsw: reg: Add Switch Port VLAN Stacking Register

2020-12-08 Thread Ido Schimmel
From: Amit Cohen SPVTR register configures the VLAN mode of the port to enable VLAN stacking. It will be used to configure VxLAN to push VLAN to the decapsulated packet. Without this setting, Spectrum-2 overtakes the VLAN tag of decapsulated packet for bridging. Signed-off-by: Amit Cohen Revie

[PATCH net-next 06/13] mlxsw: Save EtherType as part of mlxsw_sp_nve_config

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Add EtherType field to mlxsw_sp_nve_config struct. Set EtherType according to mlxsw_sp_nve_params.ethertype. Pass 'mlxsw_sp_nve_params' instead of 'mlxsw_sp_nve_params->dev' to the function which initializes mlxsw_sp_nve_config struct to know which EtherType to use. This field

[PATCH net-next 03/13] mlxsw: reg: Add support for tunnel port in SPVID register

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Add spvid_tport field which indicates if the port is tunnel port. When spvid_tport is true, local_port field supposed to be tunnel port type. It will be used to configure which Ethertype will be used when VLAN is pushed at ingress for tunnel port. Signed-off-by: Amit Cohen Rev

[PATCH net-next 07/13] mlxsw: spectrum: Publish mlxsw_sp_ethtype_to_sver_type()

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Declare mlxsw_sp_ethtype_to_sver_type() in spectrum.h to enable using it in other files. It will be used in the next patch to map between EtherType and the relevant value configured by SVER register. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Signed-off-by: Ido Schim

[PATCH net-next 05/13] mlxsw: Save EtherType as part of mlxsw_sp_nve_params

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Add EtherType field to mlxsw_sp_nve_params struct. Set it when VxLAN device is added to bridge device. This field is needed to configure which EtherType will be used when VLAN is pushed at ingress of the tunnel port. Use ETH_P_8021Q for tunnel port enslaved to 802.1d and 802.1q

[PATCH net-next 09/13] mlxsw: spectrum_switchdev: Use ops->vxlan_join() when adding VLAN to VxLAN device

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Currently mlxsw_sp_switchdev_vxlan_vlan_add() always calls mlxsw_sp_bridge_8021q_vxlan_join() because VLANs were only ever added to a VLAN-filtering bridge, which is only 802.1q bridge. This set adds support for VxLAN with 802.1ad bridge, so VLAN-filtering bridge is not only 802

[PATCH net-next 01/13] mlxsw: Use one enum for all registers that contain tunnel_port field

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Currently SFN, TNUMT and TNPC registers use separate enums for tunnel_port. Create one enum with a neutral name and use it. Remove the enums that are not currently required. The next patches add two more registers that contain tunnel_port field, the new enum can be used for the

[PATCH net-next 11/13] mlxsw: spectrum_switchdev: Allow joining VxLAN to 802.1ad bridge

2020-12-08 Thread Ido Schimmel
From: Amit Cohen The previous patches added support for VxLAN device enslaved to 802.1ad bridge in Spectrum-2 ASIC and vetoed it in Spectrum-1. Do not veto VxLAN with 802.1ad bridge. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mel

[PATCH net-next 08/13] mlxsw: spectrum_nve_vxlan: Add support for Q-in-VNI for Spectrum-2 ASIC

2020-12-08 Thread Ido Schimmel
From: Amit Cohen On Spectrum-2, the default setting is not to push VLAN to the decapsulated packet. This is controlled by SPVTR.ipvid_mode. Set SPVTR.ipvid_mode to always push VLAN. Without this setting, Spectrum-2 overtakes the VLAN tag of decapsulated packet for bridging. In addition, set SPVI

[PATCH net-next 10/13] mlxsw: Veto Q-in-VNI for Spectrum-1 ASIC

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Implementation of Q-in-VNI is different between ASIC types, this set adds support only for Spectrum-2. Return an error when trying to create VxLAN device and enslave it to 802.1ad bridge in Spectrum-1. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Signed-off-by: Ido Sch

[PATCH net-next 13/13] selftests: mlxsw: Add Q-in-VNI veto tests

2020-12-08 Thread Ido Schimmel
From: Amit Cohen Add tests to ensure that the forbidden and unsupported cases are indeed vetoed by mlxsw driver. Signed-off-by: Amit Cohen Reviewed-by: Petr Machata Signed-off-by: Ido Schimmel --- .../net/mlxsw/spectrum-2/q_in_vni_veto.sh | 77 +++ .../net/mlxsw/spectrum/

[PATCH net-next 12/13] selftests: forwarding: Add Q-in-VNI test

2020-12-08 Thread Ido Schimmel
From: Petr Machata Add test to check Q-in-VNI traffic. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- .../selftests/net/forwarding/q_in_vni.sh | 347 ++ 1 file changed, 347 insertions(+) create mode 100755 tools/testing/selftests/net/forwarding/q_in_vni.sh

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-08 Thread Hans de Goede
Hi, On 12/8/20 6:08 AM, Neftin, Sasha wrote: > On 12/7/2020 17:41, Limonciello, Mario wrote: >>> First of all thank you for working on this. >>> >>> I must say though that I don't like the approach taken here very >>> much. >>> >>> This is not so much a criticism of this series as it is a criticis

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-08 Thread Daniel Borkmann
On 12/8/20 10:00 AM, Jesper Dangaard Brouer wrote: On Mon, 07 Dec 2020 12:52:22 -0800 John Fastabend wrote: Use-case(1): Cloud-provider want to give customers (running VMs) ability to load XDP program for DDoS protection (only), but don't want to allow customer to use XDP_TX (that can implemen

[PATCH 0/1] net: Reduce rcu_barrier() contentions from 'unshare(CLONE_NEWNET)'

2020-12-08 Thread SeongJae Park
From: SeongJae Park On a few of our systems, I found frequent 'unshare(CLONE_NEWNET)' calls make the number of active slab objects including 'sock_inode_cache' type rapidly and continuously increase. As a result, memory pressure occurs. 'cleanup_net()' and 'fqdir_work_fn()' are functions that d

[PATCH 1/1] net/ipv4/inet_fragment: Batch fqdir destroy works

2020-12-08 Thread SeongJae Park
From: SeongJae Park In 'fqdir_exit()', a work for destruction of the 'fqdir' is enqueued. The work function, 'fqdir_work_fn()', calls 'rcu_barrier()'. In case of intensive 'fqdir_exit()' (e.g., frequent 'unshare(CLONE_NEWNET)' systemcalls), this increased contention could result in unacceptably

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-08 Thread Jesper Dangaard Brouer
On Mon, 07 Dec 2020 22:49:55 -0800 Saeed Mahameed wrote: > On Mon, 2020-12-07 at 19:16 -0800, Alexander Duyck wrote: > > On Mon, Dec 7, 2020 at 3:03 PM Saeed Mahameed > > wrote: > > > On Mon, 2020-12-07 at 13:16 -0800, Alexander Duyck wrote: > > > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bia

Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-08 Thread Sven Eckelmann
On Tuesday, 8 December 2020 08:48:56 CET Enrico Weigelt, metux IT consult wrote: > > Is there some explanation besides an opinion? Some kind goal which you want > > to > > achieve with it maybe? > > Just a cleanup. I've been under the impression that this version is just > an relic from oot time

Re: [PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-08 Thread Jisheng Zhang
On Mon, 7 Dec 2020 19:38:49 +0800 Joakim Zhang wrote: > > commit 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before > clk_disable_unprepare()"), > have not clean up check NULL clock parameter completely, this patch did it. > > commit e8377e7a29efb ("net: stmmac: only call pmt() du

Re: [PATCH v5 bpf-next 02/14] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

2020-12-08 Thread Lorenzo Bianconi
> On Mon, 2020-12-07 at 22:37 +0100, Maciej Fijalkowski wrote: > > On Mon, Dec 07, 2020 at 01:15:00PM -0800, Alexander Duyck wrote: > > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > > > wrote: > > > > Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers. > > > > This is a prelimi

Re: [PATCHv3 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2020-12-08 Thread Jesper Dangaard Brouer
On Tue, 8 Dec 2020 16:18:56 +0800 Hangbin Liu wrote: > This patch add a xdp program on egress to show that we can modify > the packet on egress. In this sample we will set the pkt's src > mac to egress's mac address. The xdp_prog will be attached when > -X option supplied. > > Signed-off-by: Ha

RE: [PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-08 Thread Joakim Zhang
> -Original Message- > From: Jisheng Zhang > Sent: 2020年12月8日 18:24 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; k...@kernel.org; > netdev@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH RFC] ethernet: stmmac:

RE: [PATCH v4 2/6] igb: take vlan double header into account

2020-12-08 Thread Penigalapati, Sandeep
On Tue, Dec 01, 2020 at 09:58:52AM +0100, Jesper Dangaard Brouer wrote: > > On Tue, 1 Dec 2020 08:23:23 + > > "Penigalapati, Sandeep" wrote: > > > > > Tested-by: Sandeep Penigalapati > > > > Very happy that you are testing this. > > > > Have you also tested that samples/bpf/ xdp_redirect_cpu

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-08 Thread Lorenzo Bianconi
> On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: > > Introduce xdp_shared_info data structure to contain info about > > "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info > > allowing to keep most of the frags in the same cache-line. > > Introduce some xdp_shared_info he

Re: [PATCH 01/17] wil6210: wmi: Correct misnamed function parameter 'ptr_'

2020-12-08 Thread Lee Jones
On Wed, 02 Dec 2020, Kalle Valo wrote: > Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or > > member 'ptr_' not described in 'wmi_buffer_block' > > drivers/net/wireless/ath/wil6210/wmi.c

Re: [PATCHv3 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2020-12-08 Thread Hangbin Liu
On Tue, Dec 08, 2020 at 11:39:14AM +0100, Jesper Dangaard Brouer wrote: > > + /* If -X supplied, load 2nd xdp prog on egress. > > +* If not, just load dummy prog on egress. > > +*/ > > The dummy prog need to be loaded, regardless of 2nd xdp prog on egress. Thanks for this remind, Now I

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-08 Thread Vladimir Oltean
Hi Tobias, On Wed, Dec 02, 2020 at 10:13:54AM +0100, Tobias Waldekranz wrote: > Monitor the following events and notify the driver when: > > - A DSA port joins/leaves a LAG. > - A LAG, made up of DSA ports, joins/leaves a bridge. > - A DSA port in a LAG is enabled/disabled (enabled meaning > "di

[PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_uap_bss_param_prepare

2020-12-08 Thread Xiaohui Zhang
From: Zhang Xiaohui mwifiex_uap_bss_param_prepare() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code. Fix it by putting the length check before calling memcpy(). Signed

Re: [PATCH v4 2/6] igb: take vlan double header into account

2020-12-08 Thread Jesper Dangaard Brouer
On Tue, 8 Dec 2020 10:52:28 + "Penigalapati, Sandeep" wrote: > On Tue, Dec 01, 2020 at 09:58:52AM +0100, Jesper Dangaard Brouer wrote: > > > On Tue, 1 Dec 2020 08:23:23 + > > > "Penigalapati, Sandeep" wrote: > > > > > > > Tested-by: Sandeep Penigalapati > > > > > > Very happy that y

[PATCH] [v11] wireless: Initial driver submission for pureLiFi STA devices

2020-12-08 Thread Srinivasan Raju
This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC and LiFi-XL USB devices. This driver implementation has been based on the zd1211rw driver. Driver is based on 802.11 softMAC Architecture and uses native 802.11 for configuration and management. The driver is compiled and tested in ARM

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-08 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Mon, 7 Dec 2020 18:01:00 -0700 > David Ahern wrote: > >> On 12/7/20 1:52 PM, John Fastabend wrote: >> >> >> >> I think we need to keep XDP_TX action separate, because I think that >> >> there are use-cases where the we want to disable XDP_TX due to end-user >>

[PATCHv4 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2020-12-08 Thread Hangbin Liu
This patch add a xdp program on egress to show that we can modify the packet on egress. In this sample we will set the pkt's src mac to egress's mac address. The xdp_prog will be attached when -X option supplied. Signed-off-by: Hangbin Liu --- v4: a) Update get_mac_addr socket creation b) Load du

BUG: unable to handle kernel paging request in smc_nl_handle_smcr_dev

2020-12-08 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b1f7b098 Merge branch 's390-qeth-next' git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=164d246b50 kernel config: https://syzkaller.appspot.com/x/.config?x=2ac2dabe250b3a58 dashboard link: https://s

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-08 Thread Marcin Wojtas
Hi Greg, Apologies for delayed response:. pon., 2 lis 2020 o 19:02 Greg Kroah-Hartman napisał(a): > > On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > > Hi Greg and Sasha, > > > > pt., 9 paź 2020 o 05:43 Marcin Wojtas napisał(a): > > > > > > Hi, > > > > > > sob., 20 cze 2020 o

[PATCH net-next] net/sched: cls_u32: simplify the return expression of u32_reoffload_knode()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- net/sched/cls_u32.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 54209a18d7fe..6e1abe805448 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32

[RFC PATCH net-next 00/16] LAG offload for Ocelot DSA switches

2020-12-08 Thread Vladimir Oltean
This patch series comes as a continuation of the discussion started with Tobias Waldekranz in his patch series to offload bonding/team from DSA: https://patchwork.kernel.org/project/netdevbpf/patch/20201202091356.24075-3-tob...@waldekranz.com/ On one hand, it shows the rework that needs to be done

[RFC PATCH net-next 02/16] net: mscc: ocelot: allow offloading of bridge on top of LAG

2020-12-08 Thread Vladimir Oltean
Commit 7afb3e575e5a ("net: mscc: ocelot: don't handle netdev events for other netdevs") was too aggressive, and it made ocelot_netdevice_event react only to network interface events emitted for the ocelot switch ports. In fact, only the PRECHANGEUPPER should have had that check. When we ignore al

[RFC PATCH net-next 01/16] net: mscc: ocelot: offload bridge port flags to device

2020-12-08 Thread Vladimir Oltean
We should not be unconditionally enabling address learning, since doing that is actively detrimential when a port is standalone and not offloading a bridge. Namely, if a port in the switch is standalone and others are offloading the bridge, then we could enter a situation where we learn an address

[RFC PATCH net-next 06/16] net: mscc: ocelot: use ipv6 in the aggregation code

2020-12-08 Thread Vladimir Oltean
IPv6 header information is not currently part of the entropy source for the 4-bit aggregation code used for LAG offload, even though it could be. The hardware reference manual says about these fields: ANA::AGGR_CFG.AC_IP6_TCPUDP_PORT_ENA Use IPv6 TCP/UDP port when calculating aggregation code. Con

[RFC PATCH net-next 05/16] net: mscc: ocelot: don't refuse bonding interfaces we can't offload

2020-12-08 Thread Vladimir Oltean
Since switchdev/DSA exposes network interfaces that fulfill many of the same user space expectations that dedicated NICs do, it makes sense to not deny bonding interfaces with a bonding policy that we cannot offload, but instead allow the bonding driver to select the egress interface in software.

[RFC PATCH net-next 16/16] net: dsa: ocelot: tell DSA that we can offload link aggregation

2020-12-08 Thread Vladimir Oltean
For preallocation purposes, we need to specify the maximum number of individual bonding/team devices that we can offload, which in our case is equal to the number of physical interfaces. Signed-off-by: Vladimir Oltean --- drivers/net/dsa/ocelot/felix.c | 1 + 1 file changed, 1 insertion(+) diff

[RFC PATCH net-next 03/16] net: mscc: ocelot: rename ocelot_netdevice_port_event to ocelot_netdevice_changeupper

2020-12-08 Thread Vladimir Oltean
ocelot_netdevice_port_event treats a single event, NETDEV_CHANGEUPPER. So we can remove the check for the type of event, and rename the function to be more suggestive, since there already is a function with a very similar name of ocelot_netdevice_event. Signed-off-by: Vladimir Oltean --- drivers

[RFC PATCH net-next 07/16] net: mscc: ocelot: set up the bonding mask in a way that avoids a net_device

2020-12-08 Thread Vladimir Oltean
Since this code should be called from pure switchdev as well as from DSA, we must find a way to determine the bonding mask not by looking directly at the net_device lowers of the bonding interface, since those could have different private structures. We keep a pointer to the bonding upper interfac

[RFC PATCH net-next 04/16] net: mscc: ocelot: use a switch-case statement in ocelot_netdevice_event

2020-12-08 Thread Vladimir Oltean
Make ocelot's net device event handler more streamlined by structuring it in a similar way with others. The inspiration here was dsa_slave_netdevice_event. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot_net.c | 68 +- 1 file changed, 45 insertions(+),

[RFC PATCH net-next 15/16] net: dsa: felix: propagate the LAG offload ops towards the ocelot lib

2020-12-08 Thread Vladimir Oltean
The ocelot switch has been supporting LAG offload since its initial commit, however felix could not make use of that, due to lack of a LAG abstraction in DSA. Now that we have that, let's forward DSA's calls towards the ocelot library, who will deal with setting up the bonding. Note that ocelot_po

[RFC PATCH net-next 09/16] net: mscc: ocelot: use "lag" variable name in ocelot_bridge_stp_state_set

2020-12-08 Thread Vladimir Oltean
In anticipation of further simplification, make it more clear what we're iterating over. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/etherne

[PATCH net-next] net: ipv6: rpl_iptunnel: simplify the return expression of rpl_do_srh()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- net/ipv6/rpl_iptunnel.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/ipv6/rpl_iptunnel.c b/net/ipv6/rpl_iptunnel.c index 5fdf3ebb953f..f16cf45a2421 100644 --- a/net/ipv6/rpl_iptunnel.c +++ b/net/ipv

[RFC PATCH net-next 10/16] net: mscc: ocelot: reapply bridge forwarding mask on bonding join/leave

2020-12-08 Thread Vladimir Oltean
Applying the bridge forwarding mask currently is done only on the STP state changes for any port. But it depends on both STP state changes, and bonding interface state changes. Export the bit that recalculates the forwarding mask so that it could be reused, and call it when a port starts and stops

[RFC PATCH net-next 08/16] net: mscc: ocelot: avoid unneeded "lp" variable in LAG join

2020-12-08 Thread Vladimir Oltean
The index of the LAG is equal to the logical port ID that all the physical port members have, which is further equal to the index of the first physical port that is a member of the LAG. The code gets a bit carried away with logic like this: if (a == b) c = a; else

[RFC PATCH net-next 12/16] net: mscc: ocelot: drop the use of the "lags" array

2020-12-08 Thread Vladimir Oltean
We can now simplify the implementation by always using ocelot_get_bond_mask to look up the other ports that are offloading the same bonding interface as us. In ocelot_set_aggr_pgids, the code had a way to uniquely iterate through LAGs. We need to achieve the same behavior by marking each LAG as vi

[RFC PATCH net-next 14/16] net: mscc: ocelot: rebalance LAGs on link up/down events

2020-12-08 Thread Vladimir Oltean
At present there is an issue when ocelot is offloading a bonding interface, but one of the links of the physical ports goes down. Traffic keeps being hashed towards that destination, and of course gets dropped on egress. Monitor the netdev notifier events emitted by the bonding driver for changes

[RFC PATCH net-next 13/16] net: mscc: ocelot: rename aggr_count to num_ports_in_lag

2020-12-08 Thread Vladimir Oltean
It makes it a bit easier to read and understand the code that deals with balancing the 16 aggregation codes among the ports in a certain LAG. Signed-off-by: Vladimir Oltean --- drivers/net/ethernet/mscc/ocelot.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/n

[PATCH net-next] net: core: devlink: simplify the return expression of devlink_nl_cmd_trap_set_doit()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- net/core/devlink.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 8c5ddffd707d..3f0a65ee0474 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -6981

[RFC PATCH net-next 11/16] net: mscc: ocelot: set up logical port IDs centrally

2020-12-08 Thread Vladimir Oltean
The setup of logical port IDs is done in two places: from the inconclusively named ocelot_setup_lag and from ocelot_port_lag_leave, a function that also calls ocelot_setup_lag (which apparently does an incomplete setup of the LAG). To improve this situation, we can rename ocelot_setup_lag into oce

KMSAN: uninit-value in smsc95xx_wait_eeprom (2)

2020-12-08 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=178d246b50 kernel config: https://syzkaller.appspot.co

[PATCH net-next] net: openvswitch: conntrack: simplify the return expression of ovs_ct_limit_get_default_limit()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- net/openvswitch/conntrack.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index 4beb96139d77..96a49aa3a128 100644 --- a/net/openvswitch/conntrack.

RE: [PATCH v4 1/6] igb: XDP xmit back fix error code

2020-12-08 Thread Penigalapati, Sandeep
> From: sven.auha...@voleatech.de > Sent: Wednesday, November 11, 2020 10:35 PM > To: Nguyen, Anthony L ; Fijalkowski, Maciej > ; k...@kernel.org > Cc: da...@davemloft.net; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Penigalapati, Sandeep

RE: [PATCH v4 4/6] igb: skb add metasize for xdp

2020-12-08 Thread Penigalapati, Sandeep
> From: sven.auha...@voleatech.de > Sent: Wednesday, November 11, 2020 10:35 PM > To: Nguyen, Anthony L ; Fijalkowski, Maciej > ; k...@kernel.org > Cc: da...@davemloft.net; intel-wired-...@lists.osuosl.org; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > Penigalapati, Sandeep

Re: [PATCH] net: 8021q: vlan: reduce noise in driver initialization

2020-12-08 Thread kernel test robot
h, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-consult/net-8021q-vlan-reduce-noise-in-driver-initialization/20201208-165821 base: https://git.kernel.org/pub/scm/linux/kern

Re: [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing

2020-12-08 Thread Oliver Hartkopp
On 05.12.20 22:09, Jakub Kicinski wrote: On Sat, 5 Dec 2020 21:56:33 +0100 Marc Kleine-Budde wrote: On 12/5/20 9:33 PM, Jakub Kicinski wrote: What about the (incremental?) change that Thomas Wagner posted? https://lore.kernel.org/r/20201204135557.55599-1-th...@web.de That settles it :) Th

[PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2020-12-08 Thread Xiaohui Zhang
From: Zhang Xiaohui mwifiex_config_scan() calls memcpy() without checking the destination size may trigger a buffer overflower, which a local user could use to cause denial of service or the execution of arbitrary code. Fix it by putting the length check before calling memcpy(). Signed-off-by: Z

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-08 Thread Richard Cochran
On Mon, Dec 07, 2020 at 12:42:33PM -0800, Jakub Kicinski wrote: > The behavior is not entirely dissimilar to the time stamps on > multi-layered devices (e.g. DSA switches). The time stamp can either > be generated when the packet enters the device (current mlx5 behavior) > or when it actually egr

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-08 Thread David Howells
I wonder - would it make sense to reserve two arrays of scatterlist structs and a mutex per CPU sufficient to map up to 1MiB of pages with each array while the krb5 service is in use? That way sunrpc could, say, grab the mutex, map the input and output buffers, do the entire crypto op in one go an

Re: [PATCH v5 bpf-next 02/14] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

2020-12-08 Thread Jesper Dangaard Brouer
On Tue, 8 Dec 2020 11:31:03 +0100 Lorenzo Bianconi wrote: > > On Mon, 2020-12-07 at 22:37 +0100, Maciej Fijalkowski wrote: > > > On Mon, Dec 07, 2020 at 01:15:00PM -0800, Alexander Duyck wrote: > > > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > > > > wrote: > > > > > Initialize multi-

Re: [PATCH net-next 2/4] net: mvpp2: add mvpp2_phylink_to_port() helper

2020-12-08 Thread Sasha Levin
On Tue, Dec 08, 2020 at 01:03:38PM +0100, Marcin Wojtas wrote: Hi Greg, Apologies for delayed response:. pon., 2 lis 2020 o 19:02 Greg Kroah-Hartman napisał(a): On Mon, Nov 02, 2020 at 06:38:54PM +0100, Marcin Wojtas wrote: > Hi Greg and Sasha, > > pt., 9 paź 2020 o 05:43 Marcin Wojtas nap

[PATCH net-next] drivers: net: ionic: simplify the return expression of ionic_set_rxfh()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.

[PATCH net-next] drivers: net: qlcnic: simplify the return expression of qlcnic_sriov_vf_shutdown()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c b/drivers/net/ethernet/qlogic/qlcnic/qlcni

[PATCH net-next] net/mlx4: simplify the return expression of mlx4_init_cq_table()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/mellanox/mlx4/cq.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/cq.c b/drivers/net/ethernet/mellanox/mlx4/cq.c index 3b8576b9c2f9..68bd18ee6ee

Re: [PATCH net-next] net: openvswitch: conntrack: simplify the return expression of ovs_ct_limit_get_default_limit()

2020-12-08 Thread Eelco Chaudron
On 8 Dec 2020, at 13:13, Zheng Yongjun wrote: > Simplify the return expression. > > Signed-off-by: Zheng Yongjun Change looks good to me. Reviewed-by: Eelco Chaudron

[PATCH net-next] net/mlx5: simplify the return expression of mlx5_esw_offloads_pair()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/c

[PATCH net-next] net: atheros: simplify the return expression of atl2_phy_setup_autoneg_adv()

2020-12-08 Thread Zheng Yongjun
Simplify the return expression. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/atheros/atlx/atl2.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c b/drivers/net/ethernet/atheros/atlx/atl2.c index 7b80d924632a..f016f2e12e

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-08 Thread David Howells
David Howells wrote: > I wonder - would it make sense to reserve two arrays of scatterlist structs > and a mutex per CPU sufficient to map up to 1MiB of pages with each array > while the krb5 service is in use? Actually, simply reserving a set per CPU is probably unnecessary. We could, say, set

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-08 Thread Ard Biesheuvel
On Tue, 8 Dec 2020 at 14:25, David Howells wrote: > > I wonder - would it make sense to reserve two arrays of scatterlist structs > and a mutex per CPU sufficient to map up to 1MiB of pages with each array > while the krb5 service is in use? > > That way sunrpc could, say, grab the mutex, map the

[PATCH v2 net-next 0/2] nfc: s3fwrn5: Change I2C interrupt trigger to EDGE_RISING

2020-12-08 Thread Bongsu Jeon
From: Bongsu Jeon For stable Samsung's I2C interrupt handling, I changed the interrupt trigger from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING and removed the hard coded interrupt trigger type in the i2c module for the flexible control. 1/2 is the changed dt binding for the edge rising trigg

[PATCH v2 net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Change I2C interrupt trigger type

2020-12-08 Thread Bongsu Jeon
From: Bongsu Jeon Change interrupt trigger from IRQ_TYPE_LEVEL_HIGH to IRQ_TYPE_EDGE_RISING for stable NFC I2C interrupt handling. Samsung's NFC Firmware sends an i2c frame as below. 1. NFC Firmware sets the GPIO(interrupt pin) high when there is an i2c frame to send. 2. If the CPU's I2C master

[PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove hard coded interrupt trigger type from the i2c module

2020-12-08 Thread Bongsu Jeon
From: Bongsu Jeon For the flexible control of interrupt trigger type, remove the hard coded interrupt trigger type in the i2c module. The trigger type will be loaded from a dts. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/i2c.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-08 Thread David Howells
Ard Biesheuvel wrote: > Apparently, it is permitted for gss_krb5_cts_crypt() to do a > kmalloc(GFP_NOFS) in the context from where gss_krb5_aes_encrypt() is > being invoked, and so I don't see why it wouldn't be possible to > simply kmalloc() a scatterlist[] of the appropriate size, populate it >

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-08 Thread Andrew Lunn
> > Hi Jean > > > > I never said i was too specific to your board. There are other boards > > using different switches like this. This is where the commit message > > is so important. Without understanding Why? it is hard to point you in > > the right direction. > > > > So you setup is: > > > > SoC

  1   2   3   4   >