[PATCH v1 net-next 05/15] nvme-tcp: Add DDP offload control path

2020-12-07 Thread Boris Pismenny
This commit introduces direct data placement offload to NVME TCP. There is a context per queue, which is established after the handshake using the tcp_ddp_sk_add/del NDOs. Additionally, a resynchronization routine is used to assist hardware recovery from TCP OOO, and continue the offload. Resynchr

[PATCH v1 net-next 07/15] nvme-tcp : Recalculate crc in the end of the capsule

2020-12-07 Thread Boris Pismenny
From: Yoray Zack crc offload of the nvme capsule. Check if all the skb bits are on, and if not recalculate the crc in SW and check it. This patch reworks the receive-side crc calculation to always run at the end, so as to keep a single flow for both offload and non-offload. This change simplifie

[PATCH v1 net-next 06/15] nvme-tcp: Add DDP data-path

2020-12-07 Thread Boris Pismenny
Introduce the NVMe-TCP DDP data-path offload. Using this interface, the NIC hardware will scatter TCP payload directly to the BIO pages according to the command_id in the PDU. To maintain the correctness of the network stack, the driver is expected to construct SKBs that point to the BIO pages. Th

[PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-07 Thread Boris Pismenny
This commit introduces direct data placement offload for TCP. This capability is accompanied by new net_device operations that configure hardware contexts. There is a context per socket, and a context per DDP opreation. Additionally, a resynchronization routine is used to assist hardware handle TCP

[PATCH v1 net-next 14/15] net/mlx5e: NVMEoTCP statistics

2020-12-07 Thread Boris Pismenny
From: Ben Ben-ishay NVMEoTCP offload statistics includes both control and data path statistic: counters for ndo, offloaded packets/bytes , dropped packets and resync operation. Signed-off-by: Boris Pismenny Signed-off-by: Ben Ben-Ishay Signed-off-by: Or Gerlitz Signed-off-by: Yoray Zack ---

[PATCH v1 net-next 04/15] net/tls: expose get_netdev_for_sock

2020-12-07 Thread Boris Pismenny
get_netdev_for_sock is a utility that is used to obtain the net_device structure from a connected socket. Later patches will use this for nvme-tcp DDP and DDP CRC offloads. Signed-off-by: Boris Pismenny Reviewed-by: Sagi Grimberg --- include/net/sock.h | 17 + net/tls/tls_dev

[PATCH v1 net-next 08/15] nvme-tcp: Deal with netdevice DOWN events

2020-12-07 Thread Boris Pismenny
From: Or Gerlitz For ddp setup/teardown and resync, the offloading logic uses HW resources at the NIC driver such as SQ and CQ. These resources are destroyed when the netdevice does down and hence we must stop using them before the NIC driver destroys them. Use netdevice notifier for that matte

[PATCH v1 net-next 10/15] net/mlx5: Add 128B CQE for NVMEoTCP offload

2020-12-07 Thread Boris Pismenny
From: Ben Ben-ishay Add the NVMEoTCP offload definition and access functions for 128B cookies. Signed-off-by: Ben Ben-ishay Signed-off-by: Boris Pismenny Signed-off-by: Or Gerlitz Signed-off-by: Yoray Zack --- include/linux/mlx5/device.h | 35 ++- 1 file chan

[PATCH v1 net-next 03/15] net: Introduce crc offload for tcp ddp ulp

2020-12-07 Thread Boris Pismenny
This commit introduces support for CRC offload to direct data placement ULP on the receive side. Both DDP and CRC share a common API to initialize the offload for a TCP socket. But otherwise, both can be executed independently. On the receive side, CRC offload requires a new SKB bit that indicates

[PATCH v1 net-next 15/15] net/mlx5e: NVMEoTCP workaround CRC after resync

2020-12-07 Thread Boris Pismenny
From: Yoray Zack The nvme-tcp crc computed over the first packet after resync may provide the wrong signal when the packet contains multiple PDUs. We workaround that by ignoring the cqe->nvmeotcp_crc signal for the first packet after resync. Signed-off-by: Yoray Zack Signed-off-by: Boris Pismen

[PATCH v1 net-next 11/15] net/mlx5e: TCP flow steering for nvme-tcp

2020-12-07 Thread Boris Pismenny
Both nvme-tcp and tls require tcp flow steering. Compile it for both of them. Additionally, use reference counting to allocate/free TCP flow steering. Signed-off-by: Boris Pismenny Signed-off-by: Ben Ben-Ishay Signed-off-by: Or Gerlitz Signed-off-by: Yoray Zack --- drivers/net/ethernet/mellan

[PATCH v1 net-next 01/15] iov_iter: Skip copy in memcpy_to_page if src==dst

2020-12-07 Thread Boris Pismenny
When using direct data placement the NIC writes some of the payload directly to the destination buffer, and constructs the SKB such that it points to this data. As a result, the skb_copy datagram_iter call will attempt to copy data when it is not necessary. This patch adds a check to avoid this co

[PATCH v1 net-next 13/15] net/mlx5e: NVMEoTCP, data-path for DDP offload

2020-12-07 Thread Boris Pismenny
From: Ben Ben-ishay NVMEoTCP direct data placement constructs an SKB from each CQE, while pointing at NVME buffers. This enables the offload, as the NVMe-TCP layer will skip the copy when src == dst. Signed-off-by: Boris Pismenny Signed-off-by: Ben Ben-Ishay Signed-off-by: Or Gerlitz Signed-

[PATCH v1 net-next 09/15] net/mlx5: Header file changes for nvme-tcp offload

2020-12-07 Thread Boris Pismenny
From: Ben Ben-ishay Add the necessary infrastructure for NVMEoTCP offload: - Add nvmeocp_en + nvmeotcp_crc_en bit to the TIR for identify NVMEoTCP offload flow And tag_buffer_id that will be used by the connected nvmeotcp_queues - Add new CQE field that will be used to pass scattered data inf

Re: [PATCH v5 bpf-next 02/14] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

2020-12-07 Thread Alexander Duyck
On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi wrote: > > Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers. > This is a preliminary patch to enable xdp multi-buffer support. > > Signed-off-by: Lorenzo Bianconi I'm really not a fan of this design. Having to update every driver in

Re: [PATCH v3 03/11] dt-bindings: phy: convert phy-mtk-xsphy.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, 18 Nov 2020 16:21:18 +0800, Chunfeng Yun wrote: > Convert phy-mtk-xsphy.txt to YAML schema mediatek,xsphy.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. remove type for property with standard unit suffix suggested by Rob > 2. remove '|' for descritpion > 3. fix yamllint warni

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-07 Thread Alexander Duyck
On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi wrote: > > Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data structure > in order to specify if this is a linear buffer (mb = 0) or a multi-buffer > frame (mb = 1). In the latter case the shared_info area at the end of the > first buffer i

Re: [PATCH v3 04/11] dt-bindings: phy: convert phy-mtk-tphy.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, 18 Nov 2020 16:21:19 +0800, Chunfeng Yun wrote: > Convert phy-mtk-tphy.txt to YAML schema mediatek,tphy.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. fix dt_binding_check error in example after add mtu3.yaml > Changes suggested by Rob: > 2. fix wrong indentation > 3. remov

Re: [PATCH v3 07/11] dt-bindings: phy: convert MIP DSI PHY binding to YAML schema

2020-12-07 Thread Rob Herring
On Wed, Nov 18, 2020 at 04:21:22PM +0800, Chunfeng Yun wrote: > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > > Cc: Chun-Kuang Hu > Signed-off-by: Chunfeng Yun > --- > v3: new patch > --- > .../display/mediatek/mediatek,dsi.txt | 18 +--- > .../bindings/phy/mediate

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-07 Thread Tobias Waldekranz
On Fri, Dec 04, 2020 at 03:20, Andrew Lunn wrote: >> +static int dsa_tree_setup_lags(struct dsa_switch_tree *dst) >> +{ >> +struct dsa_port *dp; >> +unsigned int num; >> + >> +list_for_each_entry(dp, &dst->ports, list) >> +num = dp->ds->num_lags; >> + >> +list_for_each_

Re: [PATCH v3 09/11] dt-bindings: usb: convert mediatek,mtk-xhci.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, Nov 18, 2020 at 04:21:24PM +0800, Chunfeng Yun wrote: > Convert mediatek,mtk-xhci.txt to YAML schema mediatek,mtk-xhci.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. fix yamllint warning > 2. remove pinctrl* properties supported by default suggested by Rob > 3. drop unused la

Re: [PATCH] Bluetooth: smp: Fix biased random passkey generation

2020-12-07 Thread kernel test robot
Hi Mincheol, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bluetooth-next/master] [also build test WARNING on net-next/master net/master bluetooth/master sparc-next/master v5.10-rc7 next-20201207] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-07 Thread Jakub Kicinski
On Fri, 4 Dec 2020 19:02:32 +0200 Andra Paraschiv wrote: > diff --git a/include/uapi/linux/vm_sockets.h b/include/uapi/linux/vm_sockets.h > index fd0ed7221645d..46735376a57a8 100644 > --- a/include/uapi/linux/vm_sockets.h > +++ b/include/uapi/linux/vm_sockets.h > @@ -145,7 +145,7 @@ > > struct s

Re: [PATCH v3 10/11] dt-bindings: usb: convert mediatek,mtu3.txt to YAML schema

2020-12-07 Thread Rob Herring
On Wed, Nov 18, 2020 at 04:21:25PM +0800, Chunfeng Yun wrote: > Convert mediatek,mtu3.txt to YAML schema mediatek,mtu3.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. fix yamllint warning > 2. remove pinctrl* properties > 3. remove unnecessary '|' > 4. drop unused labels in example

[PATCH v1 net-next 12/15] net/mlx5e: NVMEoTCP DDP offload control path

2020-12-07 Thread Boris Pismenny
From: Ben Ben-ishay This commit introduces direct data placement offload to NVME TCP. There is a context per queue, which is established after the handshake using the tcp_ddp_sk_add/del NDOs. Additionally, a resynchronization routine is used to assist hardware recovery from TCP OOO, and continue

Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-07 Thread Jakub Kicinski
On Sun, 6 Dec 2020 14:27:12 +0100 Aleksander Jan Bajkowski wrote: > This patch allows to use all PHYs on GRX300 and GRX330. The ARX300 has 3 > and the GRX330 has 4 integrated PHYs connected to different ports compared > to VRX200. > > Port configurations: > > xRX200: > GMAC0: RGMII/MII/REVMII/RM

Re: [PATCH v5 bpf-next 02/14] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

2020-12-07 Thread Maciej Fijalkowski
On Mon, Dec 07, 2020 at 01:15:00PM -0800, Alexander Duyck wrote: > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi wrote: > > > > Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers. > > This is a preliminary patch to enable xdp multi-buffer support. > > > > Signed-off-by: Lorenzo Bia

Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-07 Thread Michael Grzeschik
On Mon, Dec 07, 2020 at 08:02:57PM +, tristram...@microchip.com wrote: In order to get this driver used with other switches the functions need to use different offsets and register shifts. This patch changes the direct use of the register defines to register description structures, which can

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-07 Thread Tobias Waldekranz
On Fri, Dec 04, 2020 at 02:56, Vladimir Oltean wrote: > On Fri, Dec 04, 2020 at 12:12:32AM +0100, Tobias Waldekranz wrote: >> You make a lot of good points. I think it might be better to force the >> user to be explicit about their choice though. Imagine something like >> this: >> >> - We add NETI

[PATCH bpf-next v4 0/5] selftests/bpf: xsk selftests

2020-12-07 Thread Weqaar Janjua
This patch set adds AF_XDP selftests based on veth to selftests/bpf. # Topology: # - # --- # _ | Process | _ # / --- \ # /|\ #/ | \ # --- | ---

[PATCH bpf-next v4 2/5] selftests/bpf: xsk selftests - SKB POLL, NOPOLL

2020-12-07 Thread Weqaar Janjua
Adds following tests: 1. AF_XDP SKB mode Generic mode XDP is driver independent, used when the driver does not have support for XDP. Works on any netdevice using sockets and generic XDP path. XDP hook from netif_receive_skb(). a. nopoll - soft-irq processing b. poll - using poll() s

[PATCH bpf-next v4 4/5] selftests/bpf: xsk selftests - Socket Teardown - SKB, DRV

2020-12-07 Thread Weqaar Janjua
Adds following tests: 1. AF_XDP SKB mode c. Socket Teardown Create a Tx and a Rx socket, Tx from one socket, Rx on another. Destroy both sockets, then repeat multiple times. Only nopoll mode is used 2. AF_XDP DRV/Native mode c. Socket Teardown * Only copy mode is suppor

[PATCH bpf-next v4 3/5] selftests/bpf: xsk selftests - DRV POLL, NOPOLL

2020-12-07 Thread Weqaar Janjua
Adds following tests: 2. AF_XDP DRV/Native mode Works on any netdevice with XDP_REDIRECT support, driver dependent. Processes packets before SKB allocation. Provides better performance than SKB. Driver hook available just after DMA of buffer descriptor. a. nopoll b. poll * Only c

[PATCH bpf-next v4 5/5] selftests/bpf: xsk selftests - Bi-directional Sockets - SKB, DRV

2020-12-07 Thread Weqaar Janjua
Adds following tests: 1. AF_XDP SKB mode d. Bi-directional Sockets Configure sockets as bi-directional tx/rx sockets, sets up fill and completion rings on each socket, tx/rx in both directions. Only nopoll mode is used 2. AF_XDP DRV/Native mode d. Bi-directional Sockets

[PATCH bpf-next v4 1/5] selftests/bpf: xsk selftests framework

2020-12-07 Thread Weqaar Janjua
This patch adds AF_XDP selftests framework under selftests/bpf. Topology: - --- --- | xskX | - | xskY | --- | --- | | | --- | -- | vethX |

Re: [PATCH bpf-next v3 1/5] selftests/bpf: xsk selftests framework

2020-12-07 Thread Weqaar Janjua
On Sat, 28 Nov 2020 at 03:13, Yonghong Song wrote: > > > > On 11/27/20 9:54 AM, Weqaar Janjua wrote: > > On Fri, 27 Nov 2020 at 04:19, Yonghong Song wrote: > >> > >> > >> > >> On 11/26/20 1:22 PM, Weqaar Janjua wrote: > >>> On Thu, 26 Nov 2020 at 09:01, Björn Töpel wrote: > > On 2020-1

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-07 Thread Tobias Waldekranz
On Thu, Dec 03, 2020 at 20:18, Florian Fainelli wrote: > On 12/3/2020 5:33 PM, Andrew Lunn wrote: >>> Of course, neither is fully correct. There is always more to improve on >>> the communication side of things. >> >> I wonder if switchdev needs to gain an enumeration API? A way to ask >> the und

[PATCH net-next v3 0/3] Arrow SpeedChips XRS700x DSA Driver

2020-12-07 Thread George McCollister
This series adds a DSA driver for the Arrow SpeedChips XRS 7000 series of HSR/PRP gigabit switch chips. The chips use Flexibilis IP. More information can be found here: https://www.flexibilis.com/products/speedchips-xrs7000/ The switches have up to three RGMII ports and one MII port and are mana

[PATCH net-next v3 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-12-07 Thread George McCollister
Add support for Arrow SpeedChips XRS700x single byte tag trailer. This is modeled on tag_trailer.c which works in a similar way. Signed-off-by: George McCollister Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli --- include/net/dsa.h | 2 ++ net/dsa/Kconfig | 6 + net/dsa

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 12:42 -0800, Jakub Kicinski wrote: > On Mon, 7 Dec 2020 07:19:06 -0800 Richard Cochran wrote: > > On Mon, Dec 07, 2020 at 12:37:45AM -0800, Saeed Mahameed wrote: > > > we are not adding any new mechanism. > > > > Sorry, I didn't catch the beginning of this thread. Are you

[PATCH net-next v3 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches

2020-12-07 Thread George McCollister
Add documentation and an example for Arrow SpeedChips XRS7000 Series single chip Ethernet switches. Signed-off-by: George McCollister Reviewed-by: Florian Fainelli --- .../devicetree/bindings/net/dsa/arrow,xrs700x.yaml | 74 ++ 1 file changed, 74 insertions(+) create mode 1

[PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-12-07 Thread George McCollister
Add a driver with initial support for the Arrow SpeedChips XRS7000 series of gigabit Ethernet switch chips which are typically used in critical networking applications. The switches have up to three RGMII ports and one RMII port. Management to the switches can be performed over i2c or mdio. Suppo

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: >> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h >> index e3da25b51ae4..16d6ee29a6ac 100644 >> --- a/include/linux/ethtool.h >> +++ b/include/linux/ethtool.h >> @@ -263,6 +263,19 @@ struct ethtool_pause_stats { >> u64 rx_pause_frames; >> }; >> >> +/

[PATCH net-next v5] devlink: Add devlink port documentation

2020-12-07 Thread Parav Pandit
Added documentation for devlink port and port function related commands. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Jacob Keller --- Changelog: v4->v5: - described logically ingress and egress point of devlink port - removed networking from devlink port description - re

Re: [PATCH net-next v1 6/9] igc: Add support for tuning frame preemption via ethtool

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Tue, 1 Dec 2020 20:53:22 -0800 Vinicius Costa Gomes wrote: >> The tc subsystem sets which queues are marked as preemptible, it's the >> role of ethtool to control more hardware specific parameters. These >> parameters include: >> >> - enabling the frame preemption h

Re: [PATCH net-next v1 8/9] igc: Add support for exposing frame preemption stats registers

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Tue, 1 Dec 2020 20:53:24 -0800 Vinicius Costa Gomes wrote: >> Expose the Frame Preemption counters, so the number of >> express/preemptible packets can be monitored by userspace. >> >> These registers are cleared when read, so the value shown is the >> number of even

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 12:52 -0800, John Fastabend wrote: > Jesper Dangaard Brouer wrote: > > On Fri, 4 Dec 2020 16:21:08 +0100 > > Daniel Borkmann wrote: > > > > > On 12/4/20 1:46 PM, Maciej Fijalkowski wrote: > > > > On Fri, Dec 04, 2020 at 01:18:31PM +0100, Toke Høiland- > > > > Jørgensen wrote

Re: [PATCH net-next v1 0/9] ethtool: Add support for frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Tue, 1 Dec 2020 20:53:16 -0800 Vinicius Costa Gomes wrote: >> $ tc qdisc replace dev $IFACE parent root handle 100 taprio \ >> num_tc 3 \ >> map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \ >> queues 1@0 1@1 2@2 \ >> base-time $BASE_TIME \ >> sched-

Re: [PATCH bpf-next] bpf: avoid overflows involving hash elem_size

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 7 Dec 2020 10:28:21 -0800 you wrote: > From: Eric Dumazet > > Use of bpf_map_charge_init() was making sure hash tables would not use more > than 4GB of memory. > > Since the implicit check disappeared, we have to b

Re: [PATCH] drivers: broadcom: save return value of pci_find_capability() in u8

2020-12-07 Thread Bjorn Helgaas
On Mon, Dec 07, 2020 at 01:40:33AM +0530, Puranjay Mohan wrote: > Callers of pci_find_capability() should save the return value in u8. > change the type of pcix_cap from int to u8, to match the specification. > > Signed-off-by: Puranjay Mohan > --- > drivers/net/ethernet/broadcom/tg3.h | 2 +- >

Re: [PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 13:16 -0800, Alexander Duyck wrote: > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > wrote: > > Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data > > structure > > in order to specify if this is a linear buffer (mb = 0) or a multi- > > buffer > > frame (mb = 1).

Re: [PATCH net-next v1 0/9] ethtool: Add support for frame preemption

2020-12-07 Thread Vladimir Oltean
On Mon, Dec 07, 2020 at 02:49:35PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > > > On Tue, 1 Dec 2020 20:53:16 -0800 Vinicius Costa Gomes wrote: > >> $ tc qdisc replace dev $IFACE parent root handle 100 taprio \ > >> num_tc 3 \ > >> map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Maciej Fijalkowski
On Mon, Dec 07, 2020 at 12:52:22PM -0800, John Fastabend wrote: > Jesper Dangaard Brouer wrote: > > On Fri, 4 Dec 2020 16:21:08 +0100 > > Daniel Borkmann wrote: > > > > > On 12/4/20 1:46 PM, Maciej Fijalkowski wrote: > > > > On Fri, Dec 04, 2020 at 01:18:31PM +0100, Toke Høiland-Jørgensen wrote:

Re: [PATCH v5 bpf-next 02/14] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 22:37 +0100, Maciej Fijalkowski wrote: > On Mon, Dec 07, 2020 at 01:15:00PM -0800, Alexander Duyck wrote: > > On Mon, Dec 7, 2020 at 8:36 AM Lorenzo Bianconi > > wrote: > > > Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers. > > > This is a preliminary patch t

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> + * expressed in terms of X in '(1 + X)*64 + 4' > > > > Is this way of expressing the min frag size from the standard? > > >

Re: [PATCH net-next v1 6/9] igc: Add support for tuning frame preemption via ethtool

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 14:15:25 -0800 Vinicius Costa Gomes wrote: > > WARNING: 'PREEMPTABLE' may be misspelled - perhaps 'PREEMPTIBLE'? > > In the datasheet the term PREEMPTABLE is used, and when refering to > register values I chose to be consistent with the datasheet. But as the > margin for conf

[PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Abhishek Kumar
In some devices difference in chip-id should be enough to pick the right BDF. Add another support for chip-id based BDF selection. With this new option, ath10k supports 2 fallback options. The board name with chip-id as option looks as follows board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-07 Thread Andrew Lunn
On Mon, Dec 07, 2020 at 10:19:47PM +0100, Tobias Waldekranz wrote: > On Fri, Dec 04, 2020 at 03:20, Andrew Lunn wrote: > >> +static int dsa_tree_setup_lags(struct dsa_switch_tree *dst) > >> +{ > >> + struct dsa_port *dp; > >> + unsigned int num; > >> + > >> + list_for_each_entry(dp, &dst->ports

Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-07 Thread Andrew Lunn
On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > Port counts in microchip dsa drivers can be quite confusing: > on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, > yet on the ksz9477, it includes the cpu port. > > Add comments to docum

Re: macb: should we revert 0a4e9ce17ba7 ("macb: support the two tx descriptors on at91rm9200") ?

2020-12-07 Thread Jakub Kicinski
On Sun, 6 Dec 2020 10:20:41 +0100 Willy Tarreau wrote: > Hi Jakub, > > Two months ago I implemented a small change in the macb driver to > support the two Tx descriptors that AT91RM9200 supports. I implemented > this using the only compatible device I had which is the MSC313E-based > Breadbee boar

Re: macb: should we revert 0a4e9ce17ba7 ("macb: support the two tx descriptors on at91rm9200") ?

2020-12-07 Thread Alexandre Belloni
Hi, On 07/12/2020 15:40:42-0800, Jakub Kicinski wrote: > On Sun, 6 Dec 2020 10:20:41 +0100 Willy Tarreau wrote: > > Hi Jakub, > > > > Two months ago I implemented a small change in the macb driver to > > support the two Tx descriptors that AT91RM9200 supports. I implemented > > this using the onl

RE: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-07 Thread Tristram.Ha
> In order to get this driver used with other switches the functions need > to use different offsets and register shifts. This patch changes the > direct use of the register defines to register description structures, > which can be set depending on the chips register layout. > > Signed-off-by: Mi

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Doug Anderson
Hi, On Mon, Dec 7, 2020 at 3:23 PM Abhishek Kumar wrote: > > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option l

[PATCH 0/1] Bluetooth: Further improvements for suspend tasks

2020-12-07 Thread Abhishek Pandit-Subedi
Hi Marcel, This patch further improves suspend handling by getting rid of the separate function used for always configuring LE scan. Instead, we only configure LE scan if it is necessary and properly set the task bits depending on what actions were taken. The previously sent-up CL was incomplet

[PATCH 1/1] Bluetooth: Remove hci_req_le_suspend_config

2020-12-07 Thread Abhishek Pandit-Subedi
Add a missing SUSPEND_SCAN_ENABLE in passive scan, remove the separate function for configuring le scan during suspend and update the request complete function to clear both enable and disable tasks. Fixes: dce0a4be8054 ("Bluetooth: Set missing suspend task bits") Reviewed-by: Alain Michaud Signe

Re: [PATCH v2] MAINTAINERS: Add entry for Marvell Prestera Ethernet Switch driver

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 18:43:00 +0200 Mickey Rachamim wrote: > Add maintainers info for new Marvell Prestera Ethernet switch driver. > > Signed-off-by: Mickey Rachamim > --- > v2: > Update the maintainers list according to community recommendation. > > MAINTAINERS | 8 > 1 file changed, 8

Re: [PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

2020-12-07 Thread Saeed Mahameed
On Mon, 2020-12-07 at 17:32 +0100, Lorenzo Bianconi wrote: > Introduce xdp_shared_info data structure to contain info about > "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info > allowing to keep most of the frags in the same cache-line. > Introduce some xdp_shared_info helpers alig

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: >> Jakub Kicinski writes: >> >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, >> >> + * expressed in terms of X in '(1 + X)*64 + 4' >> > >> > Is this way of expressing the min frag

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vladimir Oltean
On Mon, Dec 07, 2020 at 04:24:02PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > > > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > >> Jakub Kicinski writes: > >> >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> >> + * expressed in t

Re: [PATCH net-next v1 0/9] ethtool: Add support for frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Vladimir Oltean writes: > On Mon, Dec 07, 2020 at 02:49:35PM -0800, Vinicius Costa Gomes wrote: >> Jakub Kicinski writes: >> >> > On Tue, 1 Dec 2020 20:53:16 -0800 Vinicius Costa Gomes wrote: >> >> $ tc qdisc replace dev $IFACE parent root handle 100 taprio \ >> >> num_tc 3 \ >> >>

Re: [PATCH v1 net-next 01/15] iov_iter: Skip copy in memcpy_to_page if src==dst

2020-12-07 Thread David Ahern
On 12/7/20 2:06 PM, Boris Pismenny wrote: > When using direct data placement the NIC writes some of the payload > directly to the destination buffer, and constructs the SKB such that it > points to this data. As a result, the skb_copy datagram_iter call will > attempt to copy data when it is not ne

Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-12-07 Thread kernel test robot
Hi George, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/George-McCollister/Arrow-SpeedChips-XRS700x-DSA-Driver/20201208-060957 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [PATCH v1 net-next 02/15] net: Introduce direct data placement tcp offload

2020-12-07 Thread David Ahern
On 12/7/20 2:06 PM, Boris Pismenny wrote: > This commit introduces direct data placement offload for TCP. > This capability is accompanied by new net_device operations that > configure > hardware contexts. There is a context per socket, and a context per DDP > opreation. Additionally, a resynchroni

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Jakub Kicinski
On Tue, 8 Dec 2020 00:27:31 + Vladimir Oltean wrote: > On Mon, Dec 07, 2020 at 04:24:02PM -0800, Vinicius Costa Gomes wrote: > > Jakub Kicinski writes: > > > > > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > > >> Jakub Kicinski writes: > > >> >> + * @min_frag_size_mul

Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-12-07 Thread George McCollister
On Mon, Dec 7, 2020 at 6:40 PM kernel test robot wrote: >drivers/net/dsa/xrs700x/xrs700x.c:511:3: error: 'const struct > dsa_switch_ops' has no member named 'get_stats64' This patch depends on "net: dsa: add optional stats64 support" being merged first: https://lore.kernel.org/netdev/2020120

Re: [PATCH net] enetc: Fix reporting of h/w packet counters

2020-12-07 Thread Jakub Kicinski
On Fri, 4 Dec 2020 19:15:05 +0200 Claudiu Manoil wrote: > Noticed some inconsistencies in packet statistics reporting. > This patch adds the missing Tx packet counter registers to > ethtool reporting and fixes the information strings for a > few of them. > > Fixes: 16eb4c85c964 ("enetc: Add ethto

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread David Ahern
On 12/7/20 1:52 PM, John Fastabend wrote: >> >> I think we need to keep XDP_TX action separate, because I think that >> there are use-cases where the we want to disable XDP_TX due to end-user >> policy or hardware limitations. > > How about we discover this at load time though. Meaning if the prog

Re: [PATCH v3 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 02:43:15 +0200 Vladimir Oltean wrote: > Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has > a very nice ocelot_mact_wait_for_completion at the end. Introduced in > commit 639c1b2625af ("net: mscc: ocelot: Register poll timeout should be > wall time not att

Re: [PATCH net-next v3 1/1] ibmvnic: add some debugs

2020-12-07 Thread Jakub Kicinski
On Fri, 4 Dec 2020 18:22:35 -0800 Sukadev Bhattiprolu wrote: > We sometimes run into situations where a soft/hard reset of the adapter > takes a long time or fails to complete. Having additional messages that > include important adapter state info will hopefully help understand what > is happening

Re: [PATCH net-next v5] devlink: Add devlink port documentation

2020-12-07 Thread Randy Dunlap
Hi-- On 12/7/20 2:13 PM, Parav Pandit wrote: > Added documentation for devlink port and port function related commands. > > Signed-off-by: Parav Pandit > Reviewed-by: Jiri Pirko > Reviewed-by: Jacob Keller > --- > Changelog: > v4->v5: > - described logically ingress and egress point of devlin

Re: [PATCH v3] bridge: Fix a deadlock when enabling multicast snooping

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 10:56:45 +0200 Nikolay Aleksandrov wrote: > On 05/12/2020 01:56, Joseph Huang wrote: > > When enabling multicast snooping, bridge module deadlocks on multicast_lock > > if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2 > > network. > > > > The deadlock wa

Re: [PATCH net-next v3 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 18:47:19 -0600 George McCollister wrote: > On Mon, Dec 7, 2020 at 6:40 PM kernel test robot wrote: > >drivers/net/dsa/xrs700x/xrs700x.c:511:3: error: 'const struct > > dsa_switch_ops' has no member named 'get_stats64' > > This patch depends on "net: dsa: add optional sta

Re: [PATCH net v2] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 15:56:33 +0800 Jianguo Wu wrote: > From: Jianguo Wu > > When do cat /proc/net/netstat, the output isn't append with a new line, it > looks like this: > [root@localhost ~]# cat /proc/net/netstat > ... > MPTcpExt: 0 0 0 0 0 0 0 0 0 0 0 0 0[root@localhost ~]# > > This is because

[PATCH net] net: ll_temac: Fix potential NULL dereference in temac_probe()

2020-12-07 Thread Zhang Changzhong
platform_get_resource() may fail and in this case a NULL dereference will occur. Fix it to use devm_platform_ioremap_resource() instead of calling platform_get_resource() and devm_ioremap(). This is detected by Coccinelle semantic patch. @@ expression pdev, res, n, t, e, e1, e2; @@ res = \(plat

Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 15:04:58 + Ioana Ciornei wrote: > On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote: > > Add an 'of_node_put()' call when a tested device node is not available. > > > > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > > Signed-off-

Re: [PATCH v3 07/11] dt-bindings: phy: convert MIP DSI PHY binding to YAML schema

2020-12-07 Thread Chunfeng Yun
On Mon, 2020-12-07 at 15:19 -0600, Rob Herring wrote: > On Wed, Nov 18, 2020 at 04:21:22PM +0800, Chunfeng Yun wrote: > > Convert MIPI DSI PHY binding to YAML schema mediatek,dsi-phy.yaml > > > > Cc: Chun-Kuang Hu > > Signed-off-by: Chunfeng Yun > > --- > > v3: new patch > > --- > > .../display

Re: [PATCH] net: stmmac: dwmac-meson8b: fix mask definition of the m250_sel mux

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 10:31:46 +0100 Jerome Brunet wrote: > > The m250_sel mux clock uses bit 4 in the PRG_ETH0 register. Fix this by > > shifting the PRG_ETH0_CLK_M250_SEL_MASK accordingly as the "mask" in > > struct clk_mux expects the mask relative to the "shift" field in the > > same struct. > >

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-07 Thread Andrew Lunn
On Mon, Dec 07, 2020 at 08:43:32PM +0100, Jean Pihet wrote: > Hi Andrew, > > On Tue, Dec 1, 2020 at 9:45 PM Andrew Lunn wrote: > > > > > Configure the host port of the switch to match the host interface > > > settings. This is useful when the switch is directly connected to the > > > host MAC int

Re: [PATCH net v1 2/2] net: dsa: microchip: improve port count comments

2020-12-07 Thread Jakub Kicinski
On Tue, 8 Dec 2020 00:31:16 +0100 Andrew Lunn wrote: > On Sat, Dec 05, 2020 at 10:28:14AM -0500, Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > > > Port counts in microchip dsa drivers can be quite confusing: > > on the ksz8795, ksz_chip_data->port_cnt excludes the cpu port, > > yet on

Re: [PATCH net-next] bonding: set xfrm feature flags more sanely

2020-12-07 Thread Jakub Kicinski
On Sat, 5 Dec 2020 12:40:03 -0500 Jarod Wilson wrote: > We can remove one of the ifdef blocks here, and instead of setting both > the xfrm hw_features and features flags, then unsetting the the features > flags if not in AB, wait to set the features flags if we're actually in AB > mode. > > Cc: J

Re: vlan_filtering=1 breaks all traffic

2020-12-07 Thread Andrew Lunn
On Mon, Dec 07, 2020 at 08:15:28PM +, Vladimir Oltean wrote: > On Mon, Dec 07, 2020 at 08:43:18PM +0100, Rasmus Villemoes wrote: > > # uname -a > > Linux (none) 5.10.0-rc7-00035-g66d777e1729d #194 Mon Dec 7 16:00:30 CET > > 2020 ppc GNU/Linux > > # devlink dev > > mdio_bus/mdio@e0102120:10 > >

Re: [PATCH net-next] net/mlx4: Remove unused #define MAX_MSIX_P_PORT

2020-12-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 6 Dec 2020 11:12:54 +0200 you wrote: > From: Tariq Toukan > > All usages of the definition MAX_MSIX_P_PORT were removed. > It's not in use anymore. Remove it. > > Signed-off-by: Tariq Toukan > Reviewed-by: Mosh

Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 09:59:16 +0800 Chris Mi wrote: > The offending commit introduces a cleanup callback that is invoked > when the driver module is removed to clean up the tunnel device > flow block. But it returns on the first iteration of the for loop. > The remaining indirect flow blocks will ne

Re: pull request (net): ipsec 2020-12-07

2020-12-07 Thread Jakub Kicinski
On Mon, 7 Dec 2020 10:39:33 +0100 Steffen Klassert wrote: > 1) Sysbot reported fixes for the new 64/32 bit compat layer. >From Dmitry Safonov. > > 2) Fix a memory leak in xfrm_user_policy that was introduced >by adding the 64/32 bit compat layer. From Yu Kuai. Pulled, thank you!

Re: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path

2020-12-07 Thread Jason Wang
On 2020/12/7 下午9:38, wangyunjian wrote: I think the newly added code is easy to miss this problem, so I want to copy ubuf_info until we're sure there's no errors. Thanks, Yunjian But isn't this actually a disabling of zerocopy? Thanks

[PATCH net v2] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Chris Mi
The offending commit introduces a cleanup callback that is invoked when the driver module is removed to clean up the tunnel device flow block. But it returns on the first iteration of the for loop. The remaining indirect flow blocks will never be freed. Fixes: 1fac52da5942 ("net: flow_offload: con

Re: [PATCH net] net: flow_offload: Fix memory leak for indirect flow block

2020-12-07 Thread Chris Mi
On 12/8/2020 10:28 AM, Jakub Kicinski wrote: On Mon, 7 Dec 2020 09:59:16 +0800 Chris Mi wrote: The offending commit introduces a cleanup callback that is invoked when the driver module is removed to clean up the tunnel device flow block. But it returns on the first iteration of the for loop. Th

Re: [PATCH bpf-next v9 00/34] bpf: switch to memcg-based memory accounting

2020-12-07 Thread Andrii Nakryiko
On Fri, Dec 4, 2020 at 4:37 PM Daniel Borkmann wrote: > > On 12/3/20 4:26 AM, Roman Gushchin wrote: > > On Wed, Dec 02, 2020 at 06:54:46PM -0800, Alexei Starovoitov wrote: > >> On Tue, Dec 1, 2020 at 1:59 PM Roman Gushchin wrote: > >>> > >>> 5) Cryptic -EPERM is returned on exceeding the limit. L

Re: [PATCH bpf] tools/bpftool: fix PID fetching with a lot of results

2020-12-07 Thread Andrii Nakryiko
On Sat, Dec 5, 2020 at 11:11 AM Yonghong Song wrote: > > > > On 12/4/20 3:20 PM, Andrii Nakryiko wrote: > > In case of having so many PID results that they don't fit into a singe page > > (4096) bytes, bpftool will erroneously conclude that it got corrupted data > > due > > to 4096 not being a mu

RE: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications

2020-12-07 Thread Qiang Zhao
On 06/12/2020 05:12, Rasmus Villemoes wrote: > -Original Message- > From: Rasmus Villemoes > Sent: 2020年12月6日 5:12 > To: Jakub Kicinski > Cc: Leo Li ; David S. Miller ; > Qiang Zhao ; netdev@vger.kernel.org; > linuxppc-...@lists.ozlabs.org; linux-ker...@vger.kernel.org; > linux-arm-ker

<    1   2   3   4   >