Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

On Mon, Dec 07, 2020 at 12:37:45AM -0800, Saeed Mahameed wrote: > we are not adding any new mechanism. Sorry, I didn't catch the beginning of this thread. Are you proposing adding HWTSTAMP_TX_ON_TIME_CRITICAL_ONLY to net_tstamp.h ? If so, then ... > Our driver feature is and internal enhanceme

Re: [RFC PATCH net-next 05/13] net: bonding: hold the netdev lists lock when retrieving device statistics

On Mon, Dec 07, 2020 at 03:00:40AM +0200, Vladimir Oltean wrote: > There is a very obvious deadlock here which happens when we have > bond-over-bond and the upper calls dev_get_stats from the lower. > > Conceptually, the same can happen even in any number of stacking > combinations between bonding,

RE: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

> First of all thank you for working on this. > > I must say though that I don't like the approach taken here very > much. > > This is not so much a criticism of this series as it is a criticism > of the earlier decision to simply disable s0ix on all devices > with the i219-LM + and active ME. I

RE: bonding driver issue when configured for active/backup and using ARP monitoring

Thanks for confirming what I am seeing.I agree it is not just a notification issue, and that “it would be ideal if the backup interfaces could be kept track of and switched to immediately as you suggest.” Given that this is a defect in the driver and that an active/backup configuration with

Re: [PATCH bpf-next] bpf: return -EOPNOTSUPP when attaching to non-kernel BTF

On Mon, Dec 7, 2020 at 6:07 AM Toke Høiland-Jørgensen wrote: > > Alexei Starovoitov writes: > > > On Fri, Dec 4, 2020 at 7:11 PM Andrii Nakryiko wrote: > >> + return -EOPNOTSUPP; > > > > $ cd kernel/bpf > > $ git grep ENOTSUPP|wc -l > > 46 > > $ git grep EOPNOTSUPP|

Re: [PATCH net-next] net: sfp: add debugfs support

On Wed, Dec 02, 2020 at 09:01:47AM -0800, Jakub Kicinski wrote: > On Wed, 2 Dec 2020 08:59:13 -0800 Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 13:03:18 + Russell King - ARM Linux admin wrote: > > > Jakub, > > > > > > What's your opinion on this patch? It seems to have stalled... > > > > S

Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()

On Fri, Dec 04, 2020 at 04:43:30PM +0800, Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session") > Reported-by: Hulk Robot > Signed-

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

>Since I can not reproduce this problem with another NIC on x86, I >really wonder if this is not an issue with ENA driver on PowerPC >perhaps ? I am able to reproduce it on x86 based EC2 instances using ENA or Xen netfront or Intel ixgbevf driver on the receiver so it's not specifi

[PATCH v2] octeontx2-pf: Add RSS multi group support

Hardware supports 8 RSS groups per interface. Currently we are using only group '0'. This patch allows user to create new RSS groups/contexts and use the same as destination for flow steering rules. usage: To steer the traffic to RQ 2,3 ethtool -X eth0 weight 0 0 1 1 context new (It will print th

Re: [PATCH] bpf: propagate __user annotations properly

On 12/7/20 4:37 AM, Lukas Bulwahn wrote: __htab_map_lookup_and_delete_batch() stores a user pointer in the local variable ubatch and uses that in copy_{from,to}_user(), but ubatch misses a __user annotation. So, sparse warns in the various assignments and uses of ubatch: kernel/bpf/hashta

[PATCH] net: sched: fix spelling mistake in Kconfig "trys" -> "tries"

From: Colin Ian King There is a spelling mistake in the Kconfig help text. Fix it. Signed-off-by: Colin Ian King --- net/nfc/Kconfig | 2 +- net/sched/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/Kconfig b/net/nfc/Kconfig index 9b27599870e3..96b91674

Re: [PATCH] net: ath9k: remove trailing semicolon in macro definition

t...@redhat.com wrote: > The macro use will already have a semicolon. > > Signed-off-by: Tom Rix > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 5a5b820d18c7 ath9k: remove trailing semicolon in macro definition -- https://patchwork.kernel.org/project/linux-w

[PATCH v9 1/4] dt-bindings: phy: Add sparx5-serdes bindings

Document the Sparx5 ethernet serdes phy driver bindings. Signed-off-by: Lars Povlsen Signed-off-by: Steen Hegelund --- .../bindings/phy/microchip,sparx5-serdes.yaml | 100 ++ 1 file changed, 100 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/microchip,s

[PATCH v9 0/4] Adding the Sparx5 Serdes driver

Adding the Sparx5 Serdes driver This series of patches provides the serdes driver for the Microchip Sparx5 ethernet switch. The serdes driver supports the 10G and 25G serdes instances available in the Sparx5. The Sparx5 serdes support several interface modes with several speeds and also allows t

[PATCH v2 8/8] net: macb: add support for sama7g5 emac interface

Add support for SAMA7G5 10/100Mbps interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c ind

[PATCH v9 2/4] phy: Add ethernet serdes configuration option

Provide a new ethernet phy configuration structure, that allow PHYs used for ethernet to be configured with speed, media type and clock information. Signed-off-by: Lars Povlsen Signed-off-by: Steen Hegelund --- include/linux/phy/phy-ethernet-serdes.h | 30 + include/linu

[PATCH v2 6/8] dt-bindings: add documentation for sama7g5 gigabit ethernet interface

Add documentation for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bind

[PATCH v9 4/4] arm64: dts: sparx5: Add Sparx5 serdes driver node

Add Sparx5 serdes driver node, and enable it generally for all reference boards. Signed-off-by: Lars Povlsen Signed-off-by: Steen Hegelund --- arch/arm64/boot/dts/microchip/sparx5.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/

[PATCH v2 3/8] net: macb: add function to disable all macb clocks

Add function to disable all macb clocks. Signed-off-by: Claudiu Beznea Suggested-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 62 1 file changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/driver

[PATCH v2 2/8] net: macb: add capability to not set the clock rate

SAMA7G5's ethernet IPs TX clock could be provided by its generic clock or by the external clock provided by the PHY. The internal IP logic divides properly this clock depending on the link speed. The patch adds a new capability so that macb_set_tx_clock() to not be called for IPs having this capabi

[PATCH v2 0/8] net: macb: add support for sama7g5

Hi, This series adds support for SAMA7G5 Ethernet interfaces: one 10/100Mbps and one 1Gbps interfaces. Along with it I also included a fix to disable clocks for SiFive FU540-C000 on failure path of fu540_c000_clk_init(). Thank you, Claudiu Beznea Changes in v2: - introduced patch "net: macb: ad

[PATCH v2 1/8] net: macb: add userio bits as platform configuration

This is necessary for SAMA7G5 as it uses different values for PHY interface and also introduces hdfctlen bit. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb.h | 10 ++ drivers/net/ethernet/cadence/macb_main.c | 28 ++

[PATCH v2 4/8] net: macb: unprepare clocks in case of failure

Unprepare clocks in case of any failure in fu540_c000_clk_init(). Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git

[PATCH v2 5/8] dt-bindings: add documentation for sama7g5 ethernet interface

Add documentation for SAMA7G5 ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net

[PATCH v2 7/8] net: macb: add support for sama7g5 gem interface

Add support for SAMA7G5 gigabit ethernet interface. Signed-off-by: Claudiu Beznea Reviewed-by: Andrew Lunn --- drivers/net/ethernet/cadence/macb_main.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence

Re: [PATCH v3 net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls

On Fri, Dec 04, 2020 at 04:36:55PM +, Tom Parkin wrote: > +static int ppp_unbridge_channels(struct channel *pch) > +{ > + struct channel *pchb, *pchbb; > + > + write_lock_bh(&pch->upl); > + pchb = rcu_dereference_protected(pch->bridge, > lockdep_is_held(&pch->upl)); > + if (!pc

Re: [PATCH v2 bpf-next 03/13] Revert "locking/spinlocks: Remove the unused spin_lock_bh_nested() API"

On 12/7/20 8:24 AM, Kuniyuki Iwashima wrote: This reverts commit 607904c357c61adf20b8fd18af765e501d61a385 to use spin_lock_bh_nested() in the next commit. Link: https://lore.kernel.org/netdev/9d290a57-49e1-04cd-2487-262b0d7c5...@gmail.com/ Signed-off-by: Kuniyuki Iwashima CC: Waiman Long If

Re: [PATCH] bpf: propagate __user annotations properly

On Mon, Dec 7, 2020 at 5:12 PM Yonghong Song wrote: > > > > On 12/7/20 4:37 AM, Lukas Bulwahn wrote: > > __htab_map_lookup_and_delete_batch() stores a user pointer in the local > > variable ubatch and uses that in copy_{from,to}_user(), but ubatch misses a > > __user annotation. > > > > So, sparse

Re: [PATCH v2] brmcfmac: fix compile when DEBUG is defined

hby wrote: > The steps: > 1. add "#define DEBUG" in > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c line 61. > 2. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux > bcm2835_defconfig > 3. make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=../Out_Linux/ zImage > modules

[PATCH v5 bpf-next 00/14] mvneta: introduce XDP multi-buffer support

This series introduce XDP multi-buffer support. The mvneta driver is the first to support these new "non-linear" xdp_{buff,frame}. Reviewers please focus on how these new types of xdp_{buff,frame} packets traverse the different layers and the layout design. It is on purpose that BPF-helpers are kep

[PATCH v5 bpf-next 01/14] xdp: introduce mb in xdp_buff/xdp_frame

Introduce multi-buffer bit (mb) in xdp_frame/xdp_buffer data structure in order to specify if this is a linear buffer (mb = 0) or a multi-buffer frame (mb = 1). In the latter case the shared_info area at the end of the first buffer is been properly initialized to link together subsequent buffers.

Re: [17/17] rtw88: pci: Add prototypes for .probe, .remove and .shutdown

Lee Jones wrote: > Also strip out other duplicates from driver specific headers. > > Ensure 'main.h' is explicitly included in 'pci.h' since the latter > uses some defines from the former. It avoids issues like: > > from drivers/net/wireless/realtek/rtw88/rtw8822be.c:5: > drivers/net/wireles

[PATCH v5 bpf-next 02/14] xdp: initialize xdp_buff mb bit to 0 in all XDP drivers

Initialize multi-buffer bit (mb) to 0 in all XDP-capable drivers. This is a preliminary patch to enable xdp multi-buffer support. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/amazon/ena/ena_netdev.c| 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 1 + drivers/net/

[PATCH v5 bpf-next 03/14] xdp: add xdp_shared_info data structure

Introduce xdp_shared_info data structure to contain info about "non-linear" xdp frame. xdp_shared_info will alias skb_shared_info allowing to keep most of the frags in the same cache-line. Introduce some xdp_shared_info helpers aligned to skb_frag* ones Signed-off-by: Lorenzo Bianconi --- driver

[PATCH v5 bpf-next 04/14] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer

Update multi-buffer bit (mb) in xdp_buff to notify XDP/eBPF layer and XDP remote drivers if this is a "non-linear" XDP buffer. Access xdp_shared_info only if xdp_buff mb is set. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 24 ++-- 1 file change

[PATCH v5 bpf-next 05/14] xdp: add multi-buff support to xdp_return_{buff/frame}

Take into account if the received xdp_buff/xdp_frame is non-linear recycling/returning the frame memory to the allocator or into xdp_frame_bulk. Introduce xdp_return_num_frags_from_buff to return a given number of fragments from a xdp multi-buff starting from the tail. Signed-off-by: Lorenzo Bianc

[PATCH v5 bpf-next 08/14] bpf: introduce multibuff support to bpf_prog_test_run_xdp()

Introduce the capability to allocate a xdp multi-buff in bpf_prog_test_run_xdp routine. This is a preliminary patch to introduce the selftests for new xdp multi-buff ebpf helpers Signed-off-by: Lorenzo Bianconi --- net/bpf/test_run.c | 52 +++--- 1 file ch

[PATCH v5 bpf-next 06/14] net: mvneta: add multi buffer support to XDP_TX

Introduce the capability to map non-linear xdp buffer running mvneta_xdp_submit_frame() for XDP_TX and XDP_REDIRECT Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 94 --- 1 file changed, 56 insertions(+), 38 deletions(-) diff --git a/drivers/

[PATCH v5 bpf-next 10/14] net: mvneta: enable jumbo frames for XDP

Enable the capability to receive jumbo frames even if the interface is running in XDP mode Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvell/mvneta.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvel

[PATCH v5 bpf-next 09/14] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature

introduce xdp_shared_info pointer in bpf_test_finish signature in order to copy back paged data from a xdp multi-buff frame to userspace buffer Signed-off-by: Lorenzo Bianconi --- net/bpf/test_run.c | 46 +++--- 1 file changed, 39 insertions(+), 7 deletion

[PATCH v5 bpf-next 07/14] bpf: move user_size out of bpf_test_init

Rely on data_size_in in bpf_test_init routine signature. This is a preliminary patch to introduce xdp multi-buff selftest Signed-off-by: Lorenzo Bianconi --- net/bpf/test_run.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/net/bpf/test_run.c b/net/bpf/test_run

[PATCH v5 bpf-next 12/14] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API

From: Eelco Chaudron This change adds support for tail growing and shrinking for XDP multi-buff. Signed-off-by: Eelco Chaudron Signed-off-by: Lorenzo Bianconi --- include/net/xdp.h | 5 net/core/filter.c | 63 +++ 2 files changed, 68 insertion

[PATCH v5 bpf-next 11/14] bpf: cpumap: introduce xdp multi-buff support

Introduce __xdp_build_skb_from_frame and xdp_build_skb_from_frame utility routines to build the skb from xdp_frame. Add xdp multi-buff support to cpumap Signed-off-by: Lorenzo Bianconi --- include/net/xdp.h | 5 kernel/bpf/cpumap.c | 45 +--- net/core/xdp.c |

[PATCH v5 bpf-next 14/14] bpf: update xdp_adjust_tail selftest to include multi-buffer

From: Eelco Chaudron This change adds test cases for the multi-buffer scenarios when shrinking and growing. Signed-off-by: Eelco Chaudron Signed-off-by: Lorenzo Bianconi --- .../bpf/prog_tests/xdp_adjust_tail.c | 105 ++ .../bpf/progs/test_xdp_adjust_tail_grow.c |

Re: [PATCH] mwl8k: switch from 'pci_' to 'dma_' API

Christophe JAILLET wrote: > he wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in 'mwl8k_rxq_

[PATCH v5 bpf-next 13/14] bpf: add new frame_length field to the XDP ctx

From: Eelco Chaudron This patch adds a new field to the XDP context called frame_length, which will hold the full length of the packet, including fragments if existing. eBPF programs can determine if fragments are present using something like: if (ctx->data_end - ctx->data < ctx->frame_length

Re: [PATCH][next] wilc1000: remove redundant assignment to pointer vif

Colin King wrote: > From: Colin Ian King > > The assignment to pointer vif is redundant as the assigned value > is never read, hence it can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Acked-by: Ajay Singh Patch applied to wireless-drivers-next.git,

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

100ms RTT >Which exact version of linux kernel are you using ? On the receiver side I could see the issue with any mainline kernel version >=4.19.86 which is the first kernel version that has patches [1] & [2] included. On the sender I am using kernel 5.4.0-rc6. Links: [1] https://lore.kernel.o

Re: [PATCH][next] rtw88: coex: fix missing unitialization of variable 'interval'

Colin King wrote: > From: Colin Ian King > > Currently the variable 'interval' is not initialized and is only set > to 1 when oex_stat->bt_418_hid_existi is true. Fix this by inintializing > variable interval to 0 (which I'm assuming is the intended default). > > Addresses-Coverity: ("Uninita

Re: [PATCH wireless] adm8211: fix error return code in adm8211_probe()

Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: cc0b88cf5ecf ("[PATCH] Add adm8211 802.11b wireless driver") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Patch applied to w

Re: brcmfmac: remove redundant assignment to pointer 'entry'

Colin King wrote: > From: Colin Ian King > > The pointer 'entry' is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian Kin

Re: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

On Fri, 4 Dec 2020, Andrii Nakryiko wrote: > When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE relocation, > put module BTF FD, containing target type, into upper 32 bits of imm64. > > Because this FD is internal to libbpf, it's very cumbersome to test this in > selftests. Manual

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

Hi Subash, On Fri, 4 Dec 2020 at 22:56, wrote: > > On 2020-12-03 10:40, Loic Poulain wrote: > > A submitted qmap/rmnet packet size can not be larger than the linked > > interface (real_dev) MTU. This patch ensures that the rmnet virtual > > iface MTU is configured according real device capability

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

Bjorn Andersson writes: > On Tue 03 Nov 01:48 CST 2020, Amit Pundir wrote: > >> Hi Rob, Bjorn, Kalle, >> >> On Thu, 29 Oct 2020 at 19:10, Bjorn Andersson >> wrote: >> > >> > On Tue 29 Sep 14:08 CDT 2020, Rob Herring wrote: >> > >> > > On Fri, Sep 25, 2020 at 11:59:41PM +0530, Amit Pundir wrote:

Re: [PATCH net-next 0/6] s390/qeth: updates 2020-12-07

On 07.12.20 16:57, David Miller wrote: > From: Julian Wiedmann > Date: Mon, 7 Dec 2020 14:12:27 +0100 > >> Hi Jakub, >> >> please apply the following patch series for qeth to netdev's net-next tree. >> >> Some sysfs cleanups (with the prep work in ccwgroup acked by Heiko), and >> a few improveme

Re: [PATCH v4 net-next 1/2] net: dsa: add optional stats64 support

On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote: > > Allow DSA drivers to export stats64 > > Signed-off-by: Oleksij Rempel > Reviewed-by: Vladimir Oltean Reviewed-by: George McCollister I've already updated my xrs700x dsa driver for v3 to use this. I'm blocked on sending v3 until this is

Re: [PATCH net-next v4] devlink: Add devlink port documentation

On Mon, 7 Dec 2020 04:46:14 + Parav Pandit wrote: > > From: Jakub Kicinski > > Sent: Sunday, December 6, 2020 1:57 AM > > > > On Thu, 3 Dec 2020 20:02:55 +0200 Parav Pandit wrote: > > > Added documentation for devlink port and port function related commands. > > > > > > Signed-off-by: Parav

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

On Mon, Dec 07, 2020 at 04:34:57PM +, Mohamed Abuelfotoh, Hazem wrote: > 100ms RTT > > >Which exact version of linux kernel are you using ? > On the receiver side I could see the issue with any mainline kernel > version >=4.19.86 which is the first kernel version that has patches > [1] & [2] i

Re: [PATCH net] tcp: fix receive buffer autotuning to trigger for any valid advertised MSS

> I find using icsk->icsk_ack.rcv_mss misleading. > I would either use TCP_MSS_DEFAULT , or maybe simply 0, since we had > no samples yet, there is little point to use a magic value. My point is by definition rcv_space is used in TCP's internal auto-tuning to grow socket buffers bas

[PATCH] Bluetooth: smp: Fix biased random passkey generation

Since u32 range size is not a multiple of 1,000,000, current passkey generation logic is biased. Fixed this by adding a routine that selects passkey again if passkey is 4,200,000,000 or more. Signed-off-by: Mincheol Son --- net/bluetooth/smp.c | 4 +++- 1 file changed, 3 insertions(+), 1 dele

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

>5.4.0-rc6 is a very old and odd kernel to be doing anything with. Are >you sure you don't mean "5.10-rc6" here? I was able to reproduce it on the latest mainline kernel as well so anything newer than 4.19.85 is just broken. Thank you. Hazem On 07/12/2020, 17:45, "Greg KH" wrote: CAUT

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

Hi, > > (no changes since v1) > > I think you need to work on the method you're using to generate your > patches. There are most definitely changes since v1. You described > them in your cover letter (which you don't really need for a singleton > patch) instead of here. I agree, this was not int

Re: [PATCH v9 1/4] dt-bindings: phy: Add sparx5-serdes bindings

On Mon, 07 Dec 2020 13:13:42 +0100, Steen Hegelund wrote: > Document the Sparx5 ethernet serdes phy driver bindings. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > --- > .../bindings/phy/microchip,sparx5-serdes.yaml | 100 ++ > 1 file changed, 100 insertions(+

[PATCH bpf-next] bpf: avoid overflows involving hash elem_size

From: Eric Dumazet Use of bpf_map_charge_init() was making sure hash tables would not use more than 4GB of memory. Since the implicit check disappeared, we have to be more careful about overflows, to support big hash tables. syzbot triggers a panic using : bpf(BPF_MAP_CREATE, {map_type=BPF_MAP

Re: [PATCH net] tcp: fix receive buffer autotuning to trigger for any valid advertised MSS

On Mon, 7 Dec 2020 11:46:25 + Hazem Mohamed Abuelfotoh wrote: > Previously receiver buffer auto-tuning starts after receiving > one advertised window amount of data.After the initial > receiver buffer was raised by > commit a337531b942b ("tcp: up initial rmem to 128KB > and

Re: [PATCH V4 net-next 3/9] net: ena: add explicit casting to variables

On Fri, Dec 4, 2020 at 4:15 AM wrote: > > From: Arthur Kiyanovski > > This patch adds explicit casting to some implicit conversions in the ena > driver. The implicit conversions fail some of our static checkers that > search for accidental conversions in our driver. > Adding this cast won't affec

KASAN: use-after-free Read in ieee80211_ibss_build_presp

Hello, syzbot found the following issue on: HEAD commit:e87297fa Merge tag 'drm-fixes-2020-12-04' of git://anongit.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=144035d350 kernel config: https://syzkaller.appspot.com/x/.config?x=e49433cfed49b7d9 das

Re: [PATCH V4 net-next 6/9] net: ena: use xdp_frame in XDP TX flow

Maciej Fijalkowski writes: On Fri, Dec 04, 2020 at 02:11:12PM +0200, akiy...@amazon.com wrote: From: Arthur Kiyanovski Rename the ena_xdp_xmit_buff() function to ena_xdp_xmit_frame() and pass it an xdp_frame struct instead of xdp_buff. This change lays the ground for XDP redirect impleme

Re: [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay

On Sun, Nov 15, 2020 at 07:52:06PM +0100, Martin Blumenstingl wrote: > Amlogic Meson G12A, G12B and SM1 SoCs have a more advanced RGMII RX > delay register which allows picoseconds precision. Deprecate the old > "amlogic,rx-delay-ns" in favour of a new "amlogic,rgmii-rx-delay-ps" > property. > > F

Re: [PATCH net-next v2 0/4] vsock: Add flags field in the vsock address

On 07/12/2020 12:05, Stefano Garzarella wrote: Hi Andra, On Fri, Dec 04, 2020 at 07:02:31PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. Nested VMs can be setup to use vsock channels, as the multi transport support has

Re: [PATCH V4 net-next 7/9] net: ena: introduce XDP redirect implementation

Jakub Kicinski writes: On Fri, 4 Dec 2020 14:11:13 +0200 akiy...@amazon.com wrote: + case XDP_REDIRECT: + xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog); + xdp_stat = &rx_ring->rx_stats.xdp_redirect; + break; Don't you have to check if xdp_d

Re: [net-next V2 09/15] net/mlx5e: CT: Use the same counter for both directions

On Mon, Dec 07, 2020 at 12:20:54PM +0200, Oz Shlomo wrote: > On 12/1/2020 11:41 PM, Saeed Mahameed wrote: > > On Fri, 2020-11-27 at 11:01 -0300, Marcelo Ricardo Leitner wrote: ... > > > The same is visible on 'ovs-appctl dpctl/dump-conntrack -s' then. > > > Summing both directions in one like this

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

On 07/12/2020 11:59, Stefano Garzarella wrote: On Fri, Dec 04, 2020 at 07:02:32PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. With the multi transport support (guest->host and host->guest), nested VMs can also use vsock

Re: [PATCH V4 net-next 9/9] net: ena: introduce ndo_xdp_xmit() function for XDP_REDIRECT

Maciej Fijalkowski writes: On Fri, Dec 04, 2020 at 02:11:15PM +0200, akiy...@amazon.com wrote: From: Arthur Kiyanovski This patch implements the ndo_xdp_xmit() net_device function which is called when a packet is redirected to this driver using an XDP_REDIRECT directive. The function re

Re: pull-request: wireless-drivers-next-2020-12-03

On Mon, Dec 7, 2020 at 2:42 AM Kalle Valo wrote: > Jakub Kicinski writes: > > On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote: > > There's also a patch which looks like it renames a module parameter. > > Module parameters are considered uAPI. > > Ah, I have been actually wondering that

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

Hi Vladimir, On Tue, Dec 1, 2020 at 8:48 PM Vladimir Oltean wrote: > > Hi Jean, > > On Tue, Dec 01, 2020 at 07:58:01PM +0100, Jean Pihet wrote: > > Hi Andrew, > > > > On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn wrote: > > > > > > On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > > > >

Re: vlan_filtering=1 breaks all traffic

On 06/12/2020 20.45, Vladimir Oltean wrote: > It would be interesting to see what is the ingress drop reason, if that > could be deduced from the drop counters that are incrementing in ethtool -S. I don't see anything obvious from running ethtool -S before/during/after ping. > Since you've alrea

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

Hi Andrew, On Tue, Dec 1, 2020 at 9:45 PM Andrew Lunn wrote: > > > Configure the host port of the switch to match the host interface > > settings. This is useful when the switch is directly connected to the > > host MAC interface. > > Why do you need this when no other board does? Why is your boa

Re: [PATCH net-next v2 2/4] vm_sockets: Add VMADDR_FLAG_TO_HOST vsock flag

On 07/12/2020 11:59, Stefano Garzarella wrote: On Fri, Dec 04, 2020 at 07:02:33PM +0200, Andra Paraschiv wrote: Add VMADDR_FLAG_TO_HOST vsock flag that is used to setup a vsock connection where all the packets are forwarded to the host. Then, using this type of vsock channel, vsock communica

Re: [PATCH net-next v2 4/4] af_vsock: Assign the vsock transport considering the vsock address flags

On 07/12/2020 12:00, Stefano Garzarella wrote: On Fri, Dec 04, 2020 at 07:02:35PM +0200, Andra Paraschiv wrote: The vsock flags field can be set in the connect and (listen) receive paths. When the vsock transport is assigned, the remote CID is used to distinguish between types of connection.

Re: [PATCH][next] seg6: fix unintentional integer overflow on left shift

On Mon, 7 Dec 2020 14:45:03 + Colin King wrote: > From: Colin Ian King > > Shifting the integer value 1 is evaluated using 32-bit arithmetic > and then used in an expression that expects a unsigned long value > leads to a potential integer overflow. Fix this by using the BIT > macro to per

RE: [PATCH net-next v4] devlink: Add devlink port documentation

> From: Jakub Kicinski > Sent: Monday, December 7, 2020 11:10 PM > > On Mon, 7 Dec 2020 04:46:14 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Sunday, December 6, 2020 1:57 AM > > > > > > On Thu, 3 Dec 2020 20:02:55 +0200 Parav Pandit wrote: > > > > Added documentation for

KASAN: vmalloc-out-of-bounds Write in pcpu_freelist_populate

Hello, syzbot found the following issue on: HEAD commit:34da8721 selftests/bpf: Test bpf_sk_storage_get in tcp ite.. git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=10c3b83750 kernel config: https://syzkaller.appspot.com/x/.config?x=3cb098ab0334059f das

Re: [PATCH net-next] tcp: optimise receiver buffer autotuning initialisation for high latency connections

>I want to state again that using 536 bytes as a magic value makes no sense to me. >autotuning might be delayed by one RTT, this does not match numbers >given by Mohamed (flows stuck in low speed) >autotuning is an heuristic, and because it has one RTT latency, it is >crucial to ge

Re: linux-next: build failure after merge of the block tree

On Mon, 2020-12-07 at 14:09 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the block tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > fs/io_uring.c: In function 'io_shutdown': > fs/io_uring.c:3782:9: error: too many arguments to function > 'sock_from_fi

Re: [Patch net v2 1/2] lwt: disable BH too in run_lwt_bpf()

Hello: This series was applied to bpf/bpf.git (refs/heads/master): On Fri, 4 Dec 2020 23:59:45 -0800 you wrote: > From: Dongdong Wang > > The per-cpu bpf_redirect_info is shared among all skb_do_redirect() > and BPF redirect helpers. Callers on RX path are all in BH context, > disabling preemp

Re: pull-request: wireless-drivers-next-2020-12-03

On Mon, 7 Dec 2020 11:35:53 -0800 Brian Norris wrote: > On Mon, Dec 7, 2020 at 2:42 AM Kalle Valo wrote: > > Jakub Kicinski writes: > > > On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote: > > > There's also a patch which looks like it renames a module parameter. > > > Module parameters

Re: [PATCH net-next v4] devlink: Add devlink port documentation

On Mon, 7 Dec 2020 20:00:53 + Parav Pandit wrote: > > > > Each port is a logically separate ingress/egress point of the device. > > > > > > > > ? > > > This may not be true when both physical ports are under bond. > > > > Bonding changes forwarding logic, not what points of egress ASIC has

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

On Sun, Dec 06, 2020 at 01:03:07AM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Fri, 4 Dec 2020 17:42:41 -0800 > > On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: > > [ ... ] > > > diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c > > > i

Re: vlan_filtering=1 breaks all traffic

On Mon, Dec 07, 2020 at 08:43:18PM +0100, Rasmus Villemoes wrote: > # uname -a > Linux (none) 5.10.0-rc7-00035-g66d777e1729d #194 Mon Dec 7 16:00:30 CET > 2020 ppc GNU/Linux > # devlink dev > mdio_bus/mdio@e0102120:10 > # mv88e6xxx_dump --device mdio_bus/mdio@e0102120:10 --vtu > VTU: > Error: devli

RE: [PATCH net-next v4] devlink: Add devlink port documentation

> From: Jakub Kicinski > Sent: Tuesday, December 8, 2020 1:43 AM > > On Mon, 7 Dec 2020 20:00:53 + Parav Pandit wrote: > > > > > Each port is a logically separate ingress/egress point of the device. > > > > > > > > > > ? > > > > This may not be true when both physical ports are under bond.

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

On Mon, 7 Dec 2020 17:45:17 +0100 Loic Poulain wrote: > > This would need similar checks in the NETDEV_PRECHANGEMTU > > netdev notifier. > > What about just returning an error on NETDEV_PRECHANGEMTU notification > to prevent real device MTU change while virtual rmnet devices are > linked? Not su

Re: [PATCH V4 net-next 3/9] net: ena: add explicit casting to variables

Alexander Duyck writes: On Fri, Dec 4, 2020 at 4:15 AM wrote: From: Arthur Kiyanovski This patch adds explicit casting to some implicit conversions in the ena driver. The implicit conversions fail some of our static checkers that search for accidental conversions in our driver. Adding

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

On Sun, 6 Dec 2020 15:36:38 +0200 Eran Ben Elisha wrote: > On 12/5/2020 1:17 AM, Jakub Kicinski wrote: > >> We only forward ptp traffic to the new special queue but we create more > >> than one to avoid internal locking as we will utilize the tx softirq > >> percpu. > > In other words to make the

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

On Thu, Dec 03, 2020 at 11:14:24PM +0900, Kuniyuki Iwashima wrote: > From: Eric Dumazet > Date: Tue, 1 Dec 2020 16:25:51 +0100 > > On 12/1/20 3:44 PM, Kuniyuki Iwashima wrote: > > > This patch lets reuseport_detach_sock() return a pointer of struct sock, > > > which is used only by inet_unhash

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

On Mon, 7 Dec 2020 07:19:06 -0800 Richard Cochran wrote: > On Mon, Dec 07, 2020 at 12:37:45AM -0800, Saeed Mahameed wrote: > > we are not adding any new mechanism. > > Sorry, I didn't catch the beginning of this thread. Are you proposing > adding HWTSTAMP_TX_ON_TIME_CRITICAL_ONLY to net_tstamp.

Re: [PATCH][next] seg6: fix unintentional integer overflow on left shift

On 07/12/2020 19:59, Andrea Mayer wrote: > On Mon, 7 Dec 2020 14:45:03 + > Colin King wrote: > >> From: Colin Ian King >> >> Shifting the integer value 1 is evaluated using 32-bit arithmetic >> and then used in an expression that expects a unsigned long value >> leads to a potential integer

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

Jesper Dangaard Brouer wrote: > On Fri, 4 Dec 2020 16:21:08 +0100 > Daniel Borkmann wrote: > > > On 12/4/20 1:46 PM, Maciej Fijalkowski wrote: > > > On Fri, Dec 04, 2020 at 01:18:31PM +0100, Toke Høiland-Jørgensen wrote: > > >> alar...@gmail.com writes: > > >>> From: Marek Majtyka > > >>> >

Re: [PATCH bpf-next] bpf: avoid overflows involving hash elem_size

On Mon, Dec 07, 2020 at 10:28:21AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > Use of bpf_map_charge_init() was making sure hash tables would not use more > than 4GB of memory. > > Since the implicit check disappeared, we have to be more careful > about overflows, to support big hash tab

[PATCH v1 net-next 00/15] nvme-tcp receive offloads

This series adds support for nvme-tcp receive offloads which do not mandate the offload of the network stack to the device. Instead, these work together with TCP to offload: 1. copy from SKB to the block layer buffers 2. CRC verification for received PDU The series implements these as a generic of

<    1   2   3   4   >