RE: [PATCH V2 0/5] patches for stmmac

2020-12-07 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2020年12月6日 5:40 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx > Subject: Re: [PATCH V2 0/5] patches for stmmac > > On Fri,

RE: [PATCH] net: stmmac: implement .set_intf_mode() callback for imx8dxl

2020-12-07 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2020年12月6日 3:58 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; dl-linux-imx > ; netdev@vger.kernel.org > Subject: Re: [PATCH] net: stmmac: implement .set_intf_mode(

[PATCH bpf-next] xsk: Validate socket state in xsk_recvmsg, prior touching socket members

2020-12-07 Thread Björn Töpel
From: Björn Töpel In AF_XDP the socket state needs to be checked, prior touching the members of the socket. This was not the case for the recvmsg implementation. Fix that by moving the xsk_is_bound() call. Reported-by: kernel test robot Fixes: 45a86681844e ("xsk: Add support for recvmsg()") Sig

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread David Howells
Herbert Xu wrote: > > Herbert recently made some changes for MSG_MORE support in the AF_ALG > > code, which permits a skcipher encryption to be split into several > > invocations of the skcipher layer without the need for this complexity > > on the side of the caller. Maybe there is a way to reus

[PATCH] net: tipc: prevent possible null deref of link

2020-12-07 Thread Cengiz Can
`tipc_node_apply_property` does a null check on a `tipc_link_entry` pointer but also accesses the same pointer out of the null check block. This triggers a warning on Coverity Static Analyzer because we're implying that `e->link` can BE null. Move "Update MTU for node link entry" line into if blo

Re: [PATCH net] udp: fix the proto value passed to ip_protocol_deliver_rcu for the segments

2020-12-07 Thread David Miller
From: Xin Long Date: Mon, 7 Dec 2020 15:55:40 +0800 > Guillaume noticed that: for segments udp_queue_rcv_one_skb() returns the > proto, and it should pass "ret" unmodified to ip_protocol_deliver_rcu(). > Otherwize, with a negtive value passed, it will underflow inet_protos. > > This can be repr

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-07 Thread Saeed Mahameed
On Sun, 2020-12-06 at 09:08 -0800, Richard Cochran wrote: > On Sun, Dec 06, 2020 at 03:37:47PM +0200, Eran Ben Elisha wrote: > > Adding new enum to the ioctl means we have add > > (HWTSTAMP_TX_ON_TIME_CRITICAL_ONLY for example) all the way - > > drivers, > > kernel ptp, user space ptp, ethtool. > >

Re: [PATCH 1/1] ice: fix array overflow on receiving too many fragments for a packet

2020-12-07 Thread kernel test robot
'--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Xiaohui-Zhang/ice-fix-array-overflow-on-receiving-too-many-fragments-for-a-packet/20201207-141033 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queu

Re: [PATCH bpf-next] xsk: Validate socket state in xsk_recvmsg, prior touching socket members

2020-12-07 Thread Magnus Karlsson
On Mon, Dec 7, 2020 at 9:22 AM Björn Töpel wrote: > > From: Björn Töpel > > In AF_XDP the socket state needs to be checked, prior touching the > members of the socket. This was not the case for the recvmsg > implementation. Fix that by moving the xsk_is_bound() call. > > Reported-by: kernel test

[PATCH 1/1] xdp: avoid calling kfree twice

2020-12-07 Thread Zhu Yanjun
From: Zhu Yanjun In the function xdp_umem_pin_pages, if npgs != umem->npgs and npgs >= 0, the function xdp_umem_unpin_pages is called. In this function, kfree is called to handle umem->pgs, and then in the function xdp_umem_pin_pages, kfree is called again to handle umem->pgs. Eventually, umem->p

Re: [PATCH] net: stmmac: dwmac-meson8b: fix mask definition of the m250_sel mux

2020-12-07 Thread Jerome Brunet
On Sat 05 Dec 2020 at 22:32, Martin Blumenstingl wrote: > The m250_sel mux clock uses bit 4 in the PRG_ETH0 register. Fix this by > shifting the PRG_ETH0_CLK_M250_SEL_MASK accordingly as the "mask" in > struct clk_mux expects the mask relative to the "shift" field in the > same struct. > > Whi

Re: [PATCH net] net: openvswitch: fix TTL decrement exception action execution

2020-12-07 Thread Eelco Chaudron
On 5 Dec 2020, at 1:30, Jakub Kicinski wrote: On Fri, 4 Dec 2020 07:16:23 -0500 Eelco Chaudron wrote: Currently, the exception actions are not processed correctly as the wrong dataset is passed. This change fixes this, including the misleading comment. In addition, a check was added to ma

pull request (net): ipsec 2020-12-07

2020-12-07 Thread Steffen Klassert
1) Sysbot reported fixes for the new 64/32 bit compat layer. From Dmitry Safonov. 2) Fix a memory leak in xfrm_user_policy that was introduced by adding the 64/32 bit compat layer. From Yu Kuai. Please pull or let me know if there are problems. Thanks! The following changes since commit 4

[PATCH 3/4] xfrm/compat: Don't allocate memory with __GFP_ZERO

2020-12-07 Thread Steffen Klassert
From: Dmitry Safonov 32-bit to 64-bit messages translator zerofies needed paddings in the translation, the rest is the actual payload. Don't allocate zero pages as they are not needed. Fixes: 5106f4a8acff ("xfrm/compat: Add 32=>64-bit messages translator") Signed-off-by: Dmitry Safonov Signed-o

Re: [PATCH ipsec-next] xfrm: interface: support collect metadata mode

2020-12-07 Thread Steffen Klassert
On Fri, Nov 27, 2020 at 02:32:44PM +0200, Eyal Birger wrote: > Hi Steffen, > > On Fri, Nov 27, 2020 at 11:44 AM Steffen Klassert > wrote: > > > > On Sat, Nov 21, 2020 at 04:28:23PM +0200, Eyal Birger wrote: > > > This commit adds support for 'collect_md' mode on xfrm interfaces. > > > > > > Each

[PATCH 1/4] xfrm/compat: Translate by copying XFRMA_UNSPEC attribute

2020-12-07 Thread Steffen Klassert
From: Dmitry Safonov xfrm_xlate32() translates 64-bit message provided by kernel to be sent for 32-bit listener (acknowledge or monitor). Translator code doesn't expect XFRMA_UNSPEC attribute as it doesn't know its payload. Kernel never attaches such attribute, but a user can. I've searched if a

[PATCH 2/4] xfrm/compat: memset(0) 64-bit padding at right place

2020-12-07 Thread Steffen Klassert
From: Dmitry Safonov 32-bit messages translated by xfrm_compat can have attributes attached. For all, but XFRMA_SA, XFRMA_POLICY the size of payload is the same in 32-bit UABI and 64-bit UABI. For XFRMA_SA (struct xfrm_usersa_info) and XFRMA_POLICY (struct xfrm_userpolicy_info) it's only tail-pad

[PATCH 4/4] net: xfrm: fix memory leak in xfrm_user_policy()

2020-12-07 Thread Steffen Klassert
From: Yu Kuai if xfrm_get_translator() failed, xfrm_user_policy() return without freeing 'data', which is allocated in memdup_sockptr(). Fixes: 96392ee5a13b ("xfrm/compat: Translate 32-bit user_policy from sockptr") Reported-by: Hulk Robot Signed-off-by: Yu Kuai Signed-off-by: Steffen Klassert

Re: [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support

2020-12-07 Thread Marcel Holtmann
Hi Archie, > MSFT needs rssi parameter for monitoring advertisement packet, > therefore we should supply them from mgmt. > > Signed-off-by: Archie Pusaka > Reviewed-by: Miao-chen Chou > Reviewed-by: Yun-Hao Chung I don’t need any Reviewed-by if they are not c

Re: [PATCH net-next v2 1/4] vm_sockets: Include flags field in the vsock address data structure

2020-12-07 Thread Stefano Garzarella
On Fri, Dec 04, 2020 at 07:02:32PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. With the multi transport support (guest->host and host->guest), nested VMs can also use vsock channels for communication. In addition to this, b

Re: [PATCH net-next v2 2/4] vm_sockets: Add VMADDR_FLAG_TO_HOST vsock flag

2020-12-07 Thread Stefano Garzarella
On Fri, Dec 04, 2020 at 07:02:33PM +0200, Andra Paraschiv wrote: Add VMADDR_FLAG_TO_HOST vsock flag that is used to setup a vsock connection where all the packets are forwarded to the host. Then, using this type of vsock channel, vsock communication between sibling VMs can be built on top of it.

Re: [PATCH net-next v2 4/4] af_vsock: Assign the vsock transport considering the vsock address flags

2020-12-07 Thread Stefano Garzarella
On Fri, Dec 04, 2020 at 07:02:35PM +0200, Andra Paraschiv wrote: The vsock flags field can be set in the connect and (listen) receive paths. When the vsock transport is assigned, the remote CID is used to distinguish between types of connection. Use the vsock flags value (in addition to the CID

Re: [PATCH net-next v2 3/4] af_vsock: Set VMADDR_FLAG_TO_HOST flag on the receive path

2020-12-07 Thread Stefano Garzarella
On Fri, Dec 04, 2020 at 07:02:34PM +0200, Andra Paraschiv wrote: The vsock flags can be set during the connect() setup logic, when initializing the vsock address data structure variable. Then the vsock transport is assigned, also considering this flags field. The vsock transport is also assigned

Re: [PATCH net-next v2 0/4] vsock: Add flags field in the vsock address

2020-12-07 Thread Stefano Garzarella
Hi Andra, On Fri, Dec 04, 2020 at 07:02:31PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. Nested VMs can be setup to use vsock channels, as the multi transport support has been available in the mainline since the v5.5 Linux

[PATCH net v2] net: openvswitch: fix TTL decrement exception action execution

2020-12-07 Thread Eelco Chaudron
Currently, the exception actions are not processed correctly as the wrong dataset is passed. This change fixes this, including the misleading comment. In addition, a check was added to make sure we work on an IPv4 packet, and not just assume if it's not IPv6 it's IPv4. This was all tested using O

Re: [net-next V2 09/15] net/mlx5e: CT: Use the same counter for both directions

2020-12-07 Thread Oz Shlomo
Hi Marcelo, On 12/1/2020 11:41 PM, Saeed Mahameed wrote: On Fri, 2020-11-27 at 11:01 -0300, Marcelo Ricardo Leitner wrote: On Wed, Sep 23, 2020 at 03:48:18PM -0700, sa...@kernel.org wrote: From: Oz Shlomo Sorry for reviving this one, but seemed better for the context. A connection is repr

Re: pull-request: wireless-drivers-next-2020-12-03

2020-12-07 Thread Kalle Valo
Jakub Kicinski writes: > On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote: >> wireless-drivers-next patches for v5.11 >> >> First set of patches for v5.11. rtw88 getting improvements to work >> better with Bluetooth and other driver also getting some new features. >> mhi-ath11k-immutabl

[PATCH V3 0/5] patches for stmmac

2020-12-07 Thread Joakim Zhang
A patch set for stmmac, fix some driver issues. ChangeLogs: V1->V2: * add Fixes tag. * add patch 5/5 into this patch set. V2->V3: * rebase to latest net tree where fixes go. Fugang Duan (5): net: stmmac: increase the timeout for dma reset net: stmmac: start phylink in

[PATCH V3 1/5] net: stmmac: increase the timeout for dma reset

2020-12-07 Thread Joakim Zhang
From: Fugang Duan Current timeout value is not enough for gmac5 dma reset on imx8mp platform, increase the timeout range. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH V3 3/5] net: stmmac: free tx skb buffer in stmmac_resume()

2020-12-07 Thread Joakim Zhang
From: Fugang Duan When do suspend/resume test, there have WARN_ON() log dump from stmmac_xmit() funciton, the code logic: entry = tx_q->cur_tx; first_entry = entry; WARN_ON(tx_q->tx_skbuff[first_entry]); In normal case, tx_q->tx_skbuff[txq->cur_tx] should be NULL because

[PATCH V3 2/5] net: stmmac: start phylink instance before stmmac_hw_setup()

2020-12-07 Thread Joakim Zhang
From: Fugang Duan Start phylink instance and resume back the PHY to supply RX clock to MAC before MAC layer initialization by calling .stmmac_hw_setup(), since DMA reset depends on the RX clock, otherwise DMA reset cost maximum timeout value then finally timeout. Fixes: 74371272f97f ("net: stmma

[PATCH V3 5/5] net: stmmac: overwrite the dma_cap.addr64 according to HW design

2020-12-07 Thread Joakim Zhang
From: Fugang Duan The current IP register MAC_HW_Feature1[ADDR64] only defines 32/40/64 bit width, but some SOCs support others like i.MX8MP support 34 bits but it maps to 40 bits width in MAC_HW_Feature1[ADDR64]. So overwrite dma_cap.addr64 according to HW real design. Fixes: 94abdad6974a ("net

[PATCH V3 4/5] net: stmmac: delete the eee_ctrl_timer after napi disabled

2020-12-07 Thread Joakim Zhang
From: Fugang Duan There have chance to re-enable the eee_ctrl_timer and fire the timer in napi callback after delete the timer in .stmmac_release(), which introduces to access eee registers in the timer function after clocks are disabled then causes system hang. Found this issue when do suspend/r

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-07 Thread Eran Ben Elisha
On 12/7/2020 10:37 AM, Saeed Mahameed wrote: On Sun, 2020-12-06 at 09:08 -0800, Richard Cochran wrote: On Sun, Dec 06, 2020 at 03:37:47PM +0200, Eran Ben Elisha wrote: Adding new enum to the ioctl means we have add (HWTSTAMP_TX_ON_TIME_CRITICAL_ONLY for example) all the way - drivers, kernel

[PATCH net-next] nfc: s3fwrn5: Change irqflags

2020-12-07 Thread Bongsu Jeon
From: Bongsu Jeon change irqflags from IRQF_TRIGGER_HIGH to IRQF_TRIGGER_RISING for stable Samsung's nfc interrupt handling. Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/s3fw

[PATCH RFC] ethernet: stmmac: clean up the code for release/suspend/resume function

2020-12-07 Thread Joakim Zhang
commit 1c35cc9cf6a0 ("net: stmmac: remove redundant null check before clk_disable_unprepare()"), have not clean up check NULL clock parameter completely, this patch did it. commit e8377e7a29efb ("net: stmmac: only call pmt() during suspend/resume if HW enables PMT"), after this patch, we use if

[PATCH net] tcp: fix receive buffer autotuning to trigger for any valid advertised MSS

2020-12-07 Thread Hazem Mohamed Abuelfotoh
Previously receiver buffer auto-tuning starts after receiving one advertised window amount of data.After the initial receiver buffer was raised by commit a337531b942b ("tcp: up initial rmem to 128KB and SYN rwin to around 64KB"),the receiver buffer may take too long for TCP

BUG: unable to handle kernel paging request in bpf_lru_populate

2020-12-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:bcd684aa net/nfc/nci: Support NCI 2.x initial sequence git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=12001bd350 kernel config: https://syzkaller.appspot.com/x/.config?x=3cb098ab0334059f dashboard

[PATCH net] tcp: fix receive buffer autotuning to trigger for any valid advertised MSS

2020-12-07 Thread Hazem Mohamed Abuelfotoh
Previously receiver buffer auto-tuning starts after receiving one advertised window amount of data.After the initial receiver buffer was raised by commit a337531b942b ("tcp: up initial rmem to 128KB and SYN rwin to around 64KB"),the receiver buffer may take too long for TCP

Re: [PATCH net-next] nfc: s3fwrn5: Change irqflags

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > change irqflags from IRQF_TRIGGER_HIGH to IRQF_TRIGGER_RISING for stable > Samsung's nfc interrupt handling. 1. Describe in commit title/subject the change. Just a word "change irqflags" is not enough. 2. De

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Jesper Dangaard Brouer
On Fri, 4 Dec 2020 23:19:55 +0100 Daniel Borkmann wrote: > On 12/4/20 6:20 PM, Toke Høiland-Jørgensen wrote: > > Daniel Borkmann writes: > [...] > >> We tried to standardize on a minimum guaranteed amount, but unfortunately > >> not > >> everyone seems to implement it, but I think it would be

Re: [EXT] Re: [PATCH v5 6/9] task_isolation: arch/arm64: enable task isolation functionality

2020-12-07 Thread Mark Rutland
On Fri, Dec 04, 2020 at 12:37:32AM +, Alex Belits wrote: > On Wed, 2020-12-02 at 13:59 +, Mark Rutland wrote: > > On Mon, Nov 23, 2020 at 05:58:06PM +, Alex Belits wrote: > > As a heads-up, the arm64 entry code is changing, as we found that > > our lockdep, RCU, and context-tracking ma

Re: [EXT] Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-12-07 Thread Mark Rutland
On Fri, Dec 04, 2020 at 12:54:29AM +, Alex Belits wrote: > > On Wed, 2020-12-02 at 14:20 +, Mark Rutland wrote: > > External Email > > > > --- > > --- > > On Mon, Nov 23, 2020 at 05:58:22PM +, Alex Belits wrote: > > > Fro

[PATCH -next] net/mlx5_core: remove unused including

2020-12-07 Thread Zou Wei
Remove including that don't need it. Signed-off-by: Zou Wei --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index 989c70c..82ecc161 100644

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread David Howells
Ard Biesheuvel wrote: > > Yeah - the problem with that is that for sunrpc, we might be dealing with > > 1MB > > plus bits of non-contiguous pages, requiring >8K of scatterlist elements > > (admittedly, we can chain them, but we may have to do one or more large > > allocations). > > > > > However

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > On 12/4/20 6:20 PM, Toke Høiland-Jørgensen wrote: >> Daniel Borkmann writes: > [...] >>> We tried to standardize on a minimum guaranteed amount, but unfortunately >>> not >>> everyone seems to implement it, but I think it would be very useful to query >>> this from app

Re: [PATCH v2 bpf 0/5] New netdev feature flags for XDP

2020-12-07 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Fri, 04 Dec 2020 18:26:10 +0100 Toke Høiland-Jørgensen wrote: >> Jakub Kicinski writes: >> >> > On Fri, 4 Dec 2020 11:28:56 +0100 alar...@gmail.com wrote: >> >> * Extend ethtool netlink interface in order to get access to the XDP >> >>bitmap (XDP_PROPERTIES_G

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Fri, 4 Dec 2020 23:19:55 +0100 > Daniel Borkmann wrote: > >> On 12/4/20 6:20 PM, Toke Høiland-Jørgensen wrote: >> > Daniel Borkmann writes: >> [...] >> >> We tried to standardize on a minimum guaranteed amount, but unfortunately >> >> not >> >> everyone se

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-07 Thread Steen Hegelund
On 04.12.2020 15:16, Alexandre Belloni wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On 03/12/2020 22:52:53+0100, Andrew Lunn wrote: > + if (macro->serdestype == SPX5_SDT_6G) { > + value = sdx5_rd(priv, SD6G_LANE_LANE_DF(macro->st

[PATCH] bpf: propagate __user annotations properly

2020-12-07 Thread Lukas Bulwahn
__htab_map_lookup_and_delete_batch() stores a user pointer in the local variable ubatch and uses that in copy_{from,to}_user(), but ubatch misses a __user annotation. So, sparse warns in the various assignments and uses of ubatch: kernel/bpf/hashtab.c:1415:24: warning: incorrect type in initial

Re: [PATCH 1/1] xdp: avoid calling kfree twice

2020-12-07 Thread Björn Töpel
On 2020-12-08 07:50, Zhu Yanjun wrote: From: Zhu Yanjun In the function xdp_umem_pin_pages, if npgs != umem->npgs and npgs >= 0, the function xdp_umem_unpin_pages is called. In this function, kfree is called to handle umem->pgs, and then in the function xdp_umem_pin_pages, kfree is called again

WARNING: ODEBUG bug in slave_kobj_release

2020-12-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:34816d20 Merge tag 'gfs2-v5.10-rc5-fixes' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=153f779d50 kernel config: https://syzkaller.appspot.com/x/.config?x=e49433cfed49b7d9 das

[PATCH net-next] net/af_iucv: use DECLARE_SOCKADDR to cast from sockaddr

2020-12-07 Thread Julian Wiedmann
This gets us compile-time size checking. Signed-off-by: Julian Wiedmann --- net/iucv/af_iucv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index db7d888914fa..882f028992c3 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iu

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-07 Thread Jesper Dangaard Brouer
On Fri, 4 Dec 2020 16:21:08 +0100 Daniel Borkmann wrote: > On 12/4/20 1:46 PM, Maciej Fijalkowski wrote: > > On Fri, Dec 04, 2020 at 01:18:31PM +0100, Toke Høiland-Jørgensen wrote: > >> alar...@gmail.com writes: > >>> From: Marek Majtyka > >>> > >>> Implement support for checking what kind o

[PATCH v5 5/6] net: dsa: microchip: Add Microchip KSZ8863 SPI based driver support

2020-12-07 Thread Michael Grzeschik
Add KSZ88X3 driver support. We add support for the KXZ88X3 three port switches using the SPI Interface. Reviewed-by: Florian Fainelli Signed-off-by: Michael Grzeschik --- v1 -> v2: - this glue was not implemented v2 -> v3: - this glue was part of previous bigger patch v3 -> v4: - this glue was

[PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-07 Thread Michael Grzeschik
In order to get this driver used with other switches the functions need to use different offsets and register shifts. This patch changes the direct use of the register defines to register description structures, which can be set depending on the chips register layout. Signed-off-by: Michael Grzesc

[PATCH v5 1/6] net: dsa: microchip: ksz8795: change drivers prefix to be generic

2020-12-07 Thread Michael Grzeschik
The driver can be used on other chips of this type. To reflect this we rename the drivers prefix from ksz8795 to ksz8. Signed-off-by: Michael Grzeschik --- v1 -> v4: - extracted this change from bigger previous patch v4 -> v5: - removed extra unavailable variables in ksz8_r_vlan_entries --- dri

[PATCH v5 2/6] net: dsa: microchip: ksz8795: move cpu_select_interface to extra function

2020-12-07 Thread Michael Grzeschik
This patch moves the cpu interface selection code to a individual function specific for ksz8795. It will make it simpler to customize the code path for different switches supported by this driver. Signed-off-by: Michael Grzeschik --- v1 -> v5: - extracted this from previous bigger patch --- dri

[PATCH v5 0/6] microchip: add support for ksz88x3 driver family

2020-12-07 Thread Michael Grzeschik
This series adds support for the ksz88x3 driver family to the dsa based ksz drivers. The driver is making use of the already available ksz8795 driver and moves it to an generic driver for the ksz8 based chips which have similar functions but an totaly different register layout. This branch is to b

[PATCH v5 6/6] dt-bindings: net: dsa: document additional Microchip KSZ8863/8873 switch

2020-12-07 Thread Michael Grzeschik
It is a 3-Port 10/100 Ethernet Switch. One CPU-Port and two Switch-Ports. Cc: devicet...@vger.kernel.org Reviewed-by: Andrew Lunn Acked-by: Rob Herring Reviewed-by: Florian Fainelli Signed-off-by: Michael Grzeschik --- v1 -> v3: - nothing changes - already Acked-by Rob Herring v1 ->

[PATCH v5 4/6] net: dsa: microchip: ksz8795: add support for ksz88xx chips

2020-12-07 Thread Michael Grzeschik
We add support for the ksz8863 and ksz8873 chips which are using the same register patterns but other offsets as the ksz8795. Signed-off-by: Michael Grzeschik --- v1 -> v4: - extracted this change from bigger previous patch v4 -> v5: - added clear of reset bit for ksz8863 reset code -

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread Ard Biesheuvel
On Mon, 7 Dec 2020 at 13:02, David Howells wrote: > > Ard Biesheuvel wrote: > > > > Yeah - the problem with that is that for sunrpc, we might be dealing with > > > 1MB > > > plus bits of non-contiguous pages, requiring >8K of scatterlist elements > > > (admittedly, we can chain them, but we may

[PATCH net-next 2/6] s390/ccwgroup: use bus->dev_groups for bus-based sysfs attributes

2020-12-07 Thread Julian Wiedmann
Bus drivers have their own way of describing the sysfs attributes that all devices on a bus should provide. Switch ccwgroup_attr_groups over to use bus->dev_groups, and thus free up dev->groups for usage by the ccwgroup device drivers. While adjusting the attribute naming, use ATTRIBUTE_GROUPS() t

[PATCH net-next 5/6] s390/qeth: remove QETH_QDIO_BUF_HANDLED_DELAYED state

2020-12-07 Thread Julian Wiedmann
Reuse the QETH_QDIO_BUF_EMPTY state to indicate that a TX buffer has been completed with a QAOB notification, and may be cleaned up by qeth_cleanup_handled_pending(). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 -- drivers/s390/net/qeth_core_main.c | 5 ++--- 2 files

[PATCH net-next 3/6] s390/qeth: use dev->groups for common sysfs attributes

2020-12-07 Thread Julian Wiedmann
All qeth devices have a minimum set of sysfs attributes, and non-OSN devices share a group of additional attributes. Depending on whether the device is forced to use a specific discipline, the device_type then specifies further attributes. Shift the common attributes into dev->groups, so that the

[PATCH net-next 4/6] s390/qeth: don't replace a fully completed async TX buffer

2020-12-07 Thread Julian Wiedmann
For TX buffers that require an additional async notification via QAOB, the TX completion code can now manage all the necessary processing if the notification has already occurred (or is occurring concurrently). In such cases we can avoid replacing the metadata that is associated with the buffer's

[PATCH net-next 0/6] s390/qeth: updates 2020-12-07

2020-12-07 Thread Julian Wiedmann
Hi Jakub, please apply the following patch series for qeth to netdev's net-next tree. Some sysfs cleanups (with the prep work in ccwgroup acked by Heiko), and a few improvements to the code that deals with async TX completion notifications for IQD devices. This also brings the missing patch from

[PATCH net-next 6/6] s390/qeth: make qeth_qdio_handle_aob() more robust

2020-12-07 Thread Julian Wiedmann
When qeth_qdio_handle_aob() frees dangling allocations in the notified TX buffer, there are rare tear-down cases where qeth_drain_output_queue() would later call qeth_clear_output_buffer() for the same buffer - and thus end up walking the buffer a second time to check for dangling kmem_cache alloca

[PATCH net-next 1/6] s390/qeth: don't call INIT_LIST_HEAD() on iob's list entry

2020-12-07 Thread Julian Wiedmann
INIT_LIST_HEAD() only needs to be called on actual list heads. While at it clarify the naming of the field. Suggested-by: Vasily Gorbik Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 +- drivers/s390/net/qeth_core_main.c | 9 - 2 files changed, 5 insertions(+),

[PATCH v2 bpf-next 00/13] Socket migration for SO_REUSEPORT.

2020-12-07 Thread Kuniyuki Iwashima
The SO_REUSEPORT option allows sockets to listen on the same port and to accept connections evenly. However, there is a defect in the current implementation[1]. When a SYN packet is received, the connection is tied to a listening socket. Accordingly, when the listener is closed, in-flight requests

[PATCH v2 bpf-next 01/13] tcp: Allow TCP_CLOSE sockets to hold the reuseport group.

2020-12-07 Thread Kuniyuki Iwashima
This patch is a preparation patch to migrate incoming connections in the later commits and adds a field (num_closed_socks) to the struct sock_reuseport to allow TCP_CLOSE sockets to access to the reuseport group. When we close a listening socket, to migrate its connections to another listener in t

Re: [PATCH 3/7] net: macb: unprepare clocks in case of failure

2020-12-07 Thread Claudiu.Beznea
Hi Andrew, On 05.12.2020 16:30, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Dec 04, 2020 at 02:34:17PM +0200, Claudiu Beznea wrote: >> Unprepare clocks in case of any failure in fu540_c000_clk_init(). > > Hi Claud

[PATCH v2 bpf-next 02/13] bpf: Define migration types for SO_REUSEPORT.

2020-12-07 Thread Kuniyuki Iwashima
As noted in the preceding commit, there are two migration types. In addition to that, the kernel will run the same eBPF program to select a listener for SYN packets. This patch defines three types to signal the kernel and the eBPF program if it is receiving a new request or migrating ESTABLISHED/S

[PATCH v2 bpf-next 03/13] Revert "locking/spinlocks: Remove the unused spin_lock_bh_nested() API"

2020-12-07 Thread Kuniyuki Iwashima
This reverts commit 607904c357c61adf20b8fd18af765e501d61a385 to use spin_lock_bh_nested() in the next commit. Link: https://lore.kernel.org/netdev/9d290a57-49e1-04cd-2487-262b0d7c5...@gmail.com/ Signed-off-by: Kuniyuki Iwashima CC: Waiman Long --- include/linux/spinlock.h | 8

[PATCH v2 bpf-next 04/13] tcp: Introduce inet_csk_reqsk_queue_migrate().

2020-12-07 Thread Kuniyuki Iwashima
This patch defines a new function to migrate ESTABLISHED/SYN_RECV sockets. Listening sockets hold incoming connections as a linked list of struct request_sock in the accept queue, and each request has reference to its full socket and listener. In inet_csk_reqsk_queue_migrate(), we only unlink the

[PATCH v2 bpf-next 05/13] tcp: Set the new listener to migrated TFO requests.

2020-12-07 Thread Kuniyuki Iwashima
A TFO request socket is only freed after BOTH 3WHS has completed (or aborted) and the child socket has been accepted (or its listener has been closed). Hence, depending on the order, there can be two kinds of request sockets in the accept queue. 3WHS -> accept : TCP_ESTABLISHED accept -> 3WHS

[PATCH v2 bpf-next 06/13] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-07 Thread Kuniyuki Iwashima
This patch lets reuseport_detach_sock() return a pointer of struct sock, which is used only by inet_unhash(). If it is not NULL, inet_csk_reqsk_queue_migrate() migrates TCP_ESTABLISHED/TCP_SYN_RECV sockets from the closing listener to the selected one. By default, the kernel selects a new listener

[PATCH v2 bpf-next 07/13] tcp: Migrate TCP_NEW_SYN_RECV requests.

2020-12-07 Thread Kuniyuki Iwashima
This patch renames reuseport_select_sock() to __reuseport_select_sock() and adds two wrapper function of it to pass the migration type defined in the previous commit. reuseport_select_sock : BPF_SK_REUSEPORT_MIGRATE_NO reuseport_select_migrated_sock : BPF_SK_REUSEPORT_MIGRATE_REQUEST

[PATCH v2 bpf-next 09/13] libbpf: Set expected_attach_type for BPF_PROG_TYPE_SK_REUSEPORT.

2020-12-07 Thread Kuniyuki Iwashima
This commit introduces a new section (sk_reuseport/migrate) and sets expected_attach_type to two each section in BPF_PROG_TYPE_SK_REUSEPORT program. Signed-off-by: Kuniyuki Iwashima --- tools/lib/bpf/libbpf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/l

[PATCH v2 bpf-next 10/13] bpf: Add migration to sk_reuseport_(kern|md).

2020-12-07 Thread Kuniyuki Iwashima
This patch adds u8 migration field to sk_reuseport_kern and sk_reuseport_md to signal the eBPF program if the kernel calls it for selecting a listener for SYN or migrating sockets in the accept queue or an immature socket during 3WHS. Note that this field is accessible only if the attached type is

[PATCH v2 bpf-next 11/13] bpf: Support BPF_FUNC_get_socket_cookie() for BPF_PROG_TYPE_SK_REUSEPORT.

2020-12-07 Thread Kuniyuki Iwashima
We will call sock_reuseport.prog for socket migration in the next commit, so the eBPF program has to know which listener is closing in order to select the new listener. Currently, we can get a unique ID for each listener in the userspace by calling bpf_map_lookup_elem() for BPF_MAP_TYPE_REUSEPORT_

[PATCH v2 bpf-next 12/13] bpf: Call bpf_run_sk_reuseport() for socket migration.

2020-12-07 Thread Kuniyuki Iwashima
This patch supports socket migration by eBPF. If the attached type is BPF_SK_REUSEPORT_SELECT_OR_MIGRATE, we can select a new listener by BPF_FUNC_sk_select_reuseport(). Also, we can cancel migration by returning SK_DROP. This feature is useful when listeners have different settings at the socket A

[PATCH v2 bpf-next 08/13] bpf: Introduce two attach types for BPF_PROG_TYPE_SK_REUSEPORT.

2020-12-07 Thread Kuniyuki Iwashima
This commit adds new bpf_attach_type for BPF_PROG_TYPE_SK_REUSEPORT to check if the attached eBPF program is capable of migrating sockets. When the eBPF program is attached, the kernel runs it for socket migration only if the expected_attach_type is BPF_SK_REUSEPORT_SELECT_OR_MIGRATE. The kernel w

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-07 Thread Hans de Goede
Hi, On 12/4/20 9:09 PM, Mario Limonciello wrote: > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions > caused by an ea

[PATCH v2 bpf-next 13/13] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE.

2020-12-07 Thread Kuniyuki Iwashima
This patch adds a test for BPF_SK_REUSEPORT_SELECT_OR_MIGRATE. Reviewed-by: Benjamin Herrenschmidt Signed-off-by: Kuniyuki Iwashima --- .../bpf/prog_tests/select_reuseport_migrate.c | 173 ++ .../bpf/progs/test_select_reuseport_migrate.c | 53 ++ 2 files changed, 226 insert

Re: [RFC PATCH 2/3] net: sparx5: Add Sparx5 switchdev driver

2020-12-07 Thread Jiri Pirko
Mon, Nov 30, 2020 at 02:13:35PM CET, steen.hegel...@microchip.com wrote: >On 27.11.2020 18:15, Andrew Lunn wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> This is a very large driver, which is going to make it slow to review. >Hi Andre

RE: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path

2020-12-07 Thread wangyunjian
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, December 7, 2020 11:54 AM > To: wangyunjian ; m...@redhat.com > Cc: virtualizat...@lists.linux-foundation.org; netdev@vger.kernel.org; Lilijun > (Jerry) ; xudingke > Subject: Re: [PATCH net-next] tun: fi

Re: [PATCH net-next] nfc: s3fwrn5: Change irqflags

2020-12-07 Thread Bongsu Jeon
On Mon, Dec 7, 2020 at 8:51 PM Krzysztof Kozlowski wrote: > > On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > change irqflags from IRQF_TRIGGER_HIGH to IRQF_TRIGGER_RISING for stable > > Samsung's nfc interrupt handling. > > 1. Describe in commit title/s

miss you

2020-12-07 Thread Sophia jasper
Greetings I'm Sophia jasper I hope we can start a relationship please reply me

[PATCH v2] xfrm: interface: Don't hide plain packets from netfilter

2020-12-07 Thread Phil Sutter
With an IPsec tunnel without dedicated interface, netfilter sees locally generated packets twice as they exit the physical interface: Once as "the inner packet" with IPsec context attached and once as the encrypted (ESP) packet. With xfrm_interface, the inner packet did not traverse NF_INET_LOCAL_

Re: [PATCH bpf-next] bpf: return -EOPNOTSUPP when attaching to non-kernel BTF

2020-12-07 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Fri, Dec 4, 2020 at 7:11 PM Andrii Nakryiko wrote: >> + return -EOPNOTSUPP; > > $ cd kernel/bpf > $ git grep ENOTSUPP|wc -l > 46 > $ git grep EOPNOTSUPP|wc -l > 11 But also $ cd kernel/include/uapi $ git grep ENOTSUPP | wc -l 0 $ gi

Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-07 Thread kernel test robot
Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20201207] [cannot apply to net/master ipvs/master linus/master v5.10-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH net-next] nfc: s3fwrn5: Change irqflags

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 10:39:01PM +0900, Bongsu Jeon wrote: > On Mon, Dec 7, 2020 at 8:51 PM Krzysztof Kozlowski wrote: > > > > On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wrote: > > > From: Bongsu Jeon > > > > > > change irqflags from IRQF_TRIGGER_HIGH to IRQF_TRIGGER_RISING for stabl

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-07 Thread David Howells
Ard Biesheuvel wrote: > > I wonder if it would help if the input buffer and output buffer didn't > > have to correspond exactly in usage - ie. the output buffer could be used > > at a slower rate than the input to allow for buffering inside the crypto > > algorithm. > > > > I don't follow - how

Re: [PATCH net-next] nfc: s3fwrn5: Change irqflags

2020-12-07 Thread Bongsu Jeon
On Mon, Dec 7, 2020 at 11:13 PM Krzysztof Kozlowski wrote: > > On Mon, Dec 07, 2020 at 10:39:01PM +0900, Bongsu Jeon wrote: > > On Mon, Dec 7, 2020 at 8:51 PM Krzysztof Kozlowski wrote: > > > > > > On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wrote: > > > > From: Bongsu Jeon > > > > > >

[PATCH][next] seg6: fix unintentional integer overflow on left shift

2020-12-07 Thread Colin King
From: Colin Ian King Shifting the integer value 1 is evaluated using 32-bit arithmetic and then used in an expression that expects a unsigned long value leads to a potential integer overflow. Fix this by using the BIT macro to perform the shift to avoid the overflow. Addresses-Coverity: ("Uninit

Re: [PATCH net-next 0/6] s390/qeth: updates 2020-12-07

2020-12-07 Thread David Miller
From: Julian Wiedmann Date: Mon, 7 Dec 2020 14:12:27 +0100 > Hi Jakub, > > please apply the following patch series for qeth to netdev's net-next tree. > > Some sysfs cleanups (with the prep work in ccwgroup acked by Heiko), and > a few improvements to the code that deals with async TX completi

Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

2020-12-07 Thread David Miller
From: Michael Grzeschik Date: Mon, 7 Dec 2020 13:56:24 +0100 > @@ -991,13 +1090,16 @@ static void ksz8_port_setup(struct ksz_device *dev, > int port, bool cpu_port) > static void ksz8_config_cpu_port(struct dsa_switch *ds) > { > struct ksz_device *dev = ds->priv; > + struct ksz8 *ks

Re: [PATCH] dpaa2-mac: Add a missing of_node_put after of_device_is_available

2020-12-07 Thread Ioana Ciornei
On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote: > Add an 'of_node_put()' call when a tested device node is not available. > > Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module") > Signed-off-by: Christophe JAILLET Reviewed-by: Ioana Ciornei Thanks! >

pull request: bluetooth-next 2020-12-07

2020-12-07 Thread Johan Hedberg
Hi Dave, Jakub, Here's the main bluetooth-next pull request for the 5.11 kernel. - Updated Bluetooth entries in MAINTAINERS to include Luiz von Dentz - Added support for Realtek 8822CE and 8852A devices - Added support for MediaTek MT7615E device - Improved workarounds for fake CSR devices -

  1   2   3   4   >