Re: [PATCH bpf-next] bpf, xdp: add bpf_redirect{,_map}() leaf node detection and optimization

2020-12-02 Thread Björn Töpel
On 2020-12-02 05:46, Alexei Starovoitov wrote: [...] Sorry I don't like this check at all. It's too fragile. It will work for one hard coded program. It may work for something more real, but will break with minimal changes to the prog or llvm changes. How are we going to explain that fragility t

Re: [PATCH net-next] net: sched: remove redundant 'rtnl_held' argument

2020-12-02 Thread Vlad Buslov
On Tue 01 Dec 2020 at 21:24, Jakub Kicinski wrote: > On Tue, 1 Dec 2020 20:39:16 +0200 Vlad Buslov wrote: >> On Tue 01 Dec 2020 at 19:03, Jakub Kicinski wrote: >> > On Tue, 1 Dec 2020 09:55:37 +0200 Vlad Buslov wrote: >> >> On Tue 01 Dec 2020 at 04:52, Jakub Kicinski wrote: >> >> > On Fri,

Re: [PATCH net-next v1 1/3] vm_sockets: Include flag field in the vsock address data structure

2020-12-02 Thread Stefano Garzarella
On Tue, Dec 01, 2020 at 08:15:04PM +0200, Paraschiv, Andra-Irina wrote: On 01/12/2020 18:09, Stefano Garzarella wrote: On Tue, Dec 01, 2020 at 05:25:03PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. With the multi transp

Re: [PATCH iproute2-net 0/3] devlink: Add devlink reload action limit and stats

2020-12-02 Thread Moshe Shemesh
On 12/1/2020 1:25 PM, Vasundhara Volam wrote: On Thu, Nov 26, 2020 at 4:46 PM Moshe Shemesh wrote: Introduce new options on devlink reload API to enable the user to select the reload action required and constrains limits on these actions that he may want to ensure. Add reload stats to show t

Re: [PATCH net-next v1 2/3] virtio_transport_common: Set sibling VMs flag on the receive path

2020-12-02 Thread Stefano Garzarella
On Tue, Dec 01, 2020 at 09:01:05PM +0200, Paraschiv, Andra-Irina wrote: On 01/12/2020 18:22, Stefano Garzarella wrote: On Tue, Dec 01, 2020 at 05:25:04PM +0200, Andra Paraschiv wrote: The vsock flag can be set during the connect() setup logic, when initializing the vsock address data structu

[PATCH 0/4] patch for stmmac

2020-12-02 Thread Joakim Zhang
A patch set for stmmac, fix some driver issues. Fugang Duan (4): net: stmmac: dwmac4_lib: increase the timeout for dma reset net: stmmac: start phylink instance before stmmac_hw_setup() net: ethernet: stmmac: free tx skb buffer in stmmac_resume() net: ethernet: stmmac: delete the eee_ctrl_

[PATCH 2/4] net: stmmac: start phylink instance before stmmac_hw_setup()

2020-12-02 Thread Joakim Zhang
From: Fugang Duan Start phylink instance and resume back the PHY to supply RX clock to MAC before MAC layer initialization by calling .stmmac_hw_setup(), since DMA reset depends on the RX clock, otherwise DMA reset cost maximum timeout value then finally timeout. Signed-off-by: Fugang Duan Sign

[PATCH] LF-2678 net: ethernet: stmmac: delete the eee_ctrl_timer after napi disabled

2020-12-02 Thread Joakim Zhang
From: Fugang Duan There have chance to re-enable the eee_ctrl_timer and fire the timer in napi callback after delete the timer in .stmmac_release(), which introduces to access eee registers in the timer function after clocks are disabled then causes system hang. It is safe to delete the timer af

[PATCH 3/4] net: ethernet: stmmac: free tx skb buffer in stmmac_resume()

2020-12-02 Thread Joakim Zhang
From: Fugang Duan When do suspend/resume test, there have WARN_ON() log dump from stmmac_xmit() funciton, the code logic: entry = tx_q->cur_tx; first_entry = entry; WARN_ON(tx_q->tx_skbuff[first_entry]); In normal case, tx_q->tx_skbuff[txq->cur_tx] should be NULL because

[PATCH 1/4] net: stmmac: dwmac4_lib: increase the timeout for dma reset

2020-12-02 Thread Joakim Zhang
From: Fugang Duan Current timeout value is not enough for gmac5 dma reset on imx8mp platform, increase the timeout range. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 4/4] net: ethernet: stmmac: delete the eee_ctrl_timer after napi disabled

2020-12-02 Thread Joakim Zhang
From: Fugang Duan There have chance to re-enable the eee_ctrl_timer and fire the timer in napi callback after delete the timer in .stmmac_release(), which introduces to access eee registers in the timer function after clocks are disabled then causes system hang. Found this issue when do suspend/r

RE: [PATCH] LF-2678 net: ethernet: stmmac: delete the eee_ctrl_timer after napi disabled

2020-12-02 Thread Joakim Zhang
Hi, Please ignore this patch due to wrongly send out. Sorry. Best Regards, Joakim Zhang > -Original Message- > From: Joakim Zhang > Sent: 2020年12月2日 17:00 > To: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com > Cc: da...@davemloft.net; k...@kernel.org; netdev@vg

[PATCH v3 net-next 1/4] net: bonding: Notify ports about their initial state

2020-12-02 Thread Tobias Waldekranz
When creating a static bond (e.g. balance-xor), all ports will always be enabled. This is set, and the corresponding notification is sent out, before the port is linked to the bond upper. In the offloaded case, this ordering is hard to deal with. The lower will first see a notification that it ca

[PATCH v3 net-next 0/4] net: dsa: Link aggregation support

2020-12-02 Thread Tobias Waldekranz
Start of by adding an extra notification when adding a port to a bond, this allows static LAGs to be offloaded using the bonding driver. Then add the generic support required to offload link aggregates to drivers built on top of the DSA subsystem. Finally, implement offloading for the mv88e6xxx d

[PATCH v3 net-next 3/4] net: dsa: mv88e6xxx: Link aggregation support

2020-12-02 Thread Tobias Waldekranz
Support offloading of LAGs to hardware. LAGs may be attached to a bridge in which case VLANs, multicast groups, etc. are also offloaded as usual. Signed-off-by: Tobias Waldekranz --- drivers/net/dsa/mv88e6xxx/chip.c| 234 +++- drivers/net/dsa/mv88e6xxx/chip.h| 4

[PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-02 Thread Tobias Waldekranz
Monitor the following events and notify the driver when: - A DSA port joins/leaves a LAG. - A LAG, made up of DSA ports, joins/leaves a bridge. - A DSA port in a LAG is enabled/disabled (enabled meaning "distributing" in 802.3ad LACP terms). Each LAG interface to which a DSA port is attached is

[PATCH v3 net-next 4/4] net: dsa: tag_dsa: Support reception of packets from LAG devices

2020-12-02 Thread Tobias Waldekranz
Packets ingressing on a LAG that egress on the CPU port, which are not classified as management, will have a FORWARD tag that does not contain the normal source device/port tuple. Instead the trunk bit will be set, and the port field holds the LAG id. Since the exact source port information is not

Re: [External] Re: [PATCH 0/7] Introduce vdpa management tool

2020-12-02 Thread Yongji Xie
On Wed, Dec 2, 2020 at 12:53 PM Parav Pandit wrote: > > > > > From: Yongji Xie > > Sent: Wednesday, December 2, 2020 9:00 AM > > > > On Tue, Dec 1, 2020 at 11:59 PM Parav Pandit wrote: > > > > > > > > > > > > > From: Yongji Xie > > > > Sent: Tuesday, December 1, 2020 7:49 PM > > > > > > > > On

Re: [External] Re: [PATCH 0/7] Introduce vdpa management tool

2020-12-02 Thread Yongji Xie
On Wed, Dec 2, 2020 at 1:51 PM Jason Wang wrote: > > > On 2020/12/2 下午12:53, Parav Pandit wrote: > > > >> From: Yongji Xie > >> Sent: Wednesday, December 2, 2020 9:00 AM > >> > >> On Tue, Dec 1, 2020 at 11:59 PM Parav Pandit wrote: > >>> > >>> > From: Yongji Xie > Sent: Tuesday, Decem

Re: [PATCH net v2] net/x25: prevent a couple of overflows

2020-12-02 Thread Martin Schiller
On 2020-12-01 16:15, Dan Carpenter wrote: The .x25_addr[] address comes from the user and is not necessarily NUL terminated. This leads to a couple problems. The first problem is that the strlen() in x25_bind() can read beyond the end of the buffer. The second problem is more subtle and could

[PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset()

2020-12-02 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/chelsio/cxgb3/sge.c | 1 + 1 file change

[PATCH net] net: pasemi: fix error return code in pasemi_mac_open()

2020-12-02 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 72b05b9940f0 ("pasemi_mac: RX/TX ring management cleanup") Fixes: 8d636d8bc5ff ("pasemi_mac: jumbo frame support") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong ---

[PATCH net] vxlan: fix error return code in __vxlan_dev_create()

2020-12-02 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 0ce1822c2a08 ("vxlan: add adjacent link to limit depth level") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/vxlan.c | 4 +++- 1 file changed, 3 in

Re: [PATCH bpf] libbpf: sanitise map names before pinning

2020-12-02 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Mon, Nov 30, 2020 at 8:17 AM Toke Høiland-Jørgensen > wrote: >> >> When we added sanitising of map names before loading programs to libbpf, we >> still allowed periods in the name. While the kernel will accept these for >> the map names themselves, they are not allo

Re: KMSAN: uninit-value in validate_beacon_head

2020-12-02 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=153d460750 kernel config: https://syzkall

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-02 Thread Vladimir Oltean
On Wed, Dec 02, 2020 at 10:13:54AM +0100, Tobias Waldekranz wrote: > Monitor the following events and notify the driver when: > > - A DSA port joins/leaves a LAG. > - A LAG, made up of DSA ports, joins/leaves a bridge. > - A DSA port in a LAG is enabled/disabled (enabled meaning > "distributing"

Re: [PATCH net] inet_ecn: Fix endianness of checksum update when setting ECT(1)

2020-12-02 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Mon, 30 Nov 2020 19:37:05 +0100 Toke Høiland-Jørgensen wrote: >> When adding support for propagating ECT(1) marking in IP headers it seems I >> suffered from endianness-confusion in the checksum update calculation: In >> fact the ECN field is in the *lower* bits of the

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-12-02 Thread Jiri Pirko
Wed, Dec 02, 2020 at 01:32:46AM CET, edwin.p...@broadcom.com wrote: >On Tue, Dec 1, 2020 at 3:22 AM Jiri Pirko wrote: > >> >Consider a physical QSFP connector comprising 4 lanes. Today, if the >> >speed is forced, we would achieve 100G speeds using all 4 lanes with >> >NRZ encoding. If we configur

[PATCH v6 bpf-next 0/2] libbpf: add support for privileged/unprivileged control separation

2020-12-02 Thread mariusz . dudek
From: Mariusz Dudek This patch series adds support for separation of eBPF program load and xsk socket creation. In for example a Kubernetes environment you can have an AF_XDP CNI or daemonset that is responsible for launching pods that execute an application using AF_XDP sockets. It is desirabl

[PATCH v6 bpf-next 2/2] samples/bpf: sample application for eBPF load and socket creation split

2020-12-02 Thread mariusz . dudek
From: Mariusz Dudek Introduce a sample program to demonstrate the control and data plane split. For the control plane part a new program called xdpsock_ctrl_proc is introduced. For the data plane part, some code was added to xdpsock_user.c to act as the data plane entity. Application xdpsock_ctr

[PATCH v6 bpf-next 1/2] libbpf: separate XDP program load with xsk socket creation

2020-12-02 Thread mariusz . dudek
From: Mariusz Dudek Add support for separation of eBPF program load and xsk socket creation. This is needed for use-case when you want to privide as little privileges as possible to the data plane application that will handle xsk socket creation and incoming traffic. With this patch the data en

Re: [PATCH v2 net-next 0/2] add ppp_generic ioctl(s) to bridge channels

2020-12-02 Thread James Chapman
On 01/12/2020 11:52, Tom Parkin wrote: > Following on from my previous RFC[1], this series adds two ioctl calls > to the ppp code to implement "channel bridging". > > When two ppp channels are bridged, frames presented to ppp_input() on > one channel are passed to the other channel's ->start_xmit f

Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-02 Thread Lukasz Stelmach
It was <2020-11-25 śro 13:26>, when Jakub Kicinski wrote: > On Tue, 24 Nov 2020 13:03:30 +0100 Łukasz Stelmach wrote: >> +static int >> +ax88796c_start_xmit(struct sk_buff *skb, struct net_device *ndev) >> +{ >> +struct ax88796c_device *ax_local = to_ax88796c_device(ndev); >> + >> +skb_queu

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-02 Thread Tobias Waldekranz
On Wed, Dec 02, 2020 at 12:07, Vladimir Oltean wrote: > On Wed, Dec 02, 2020 at 10:13:54AM +0100, Tobias Waldekranz wrote: >> + >> +/* Link aggregates */ >> +struct { >> +struct dsa_lag *pool; >> +unsigned long *busy; >> +unsigned int num; > > Can we get

RE: [External] Re: [PATCH 0/7] Introduce vdpa management tool

2020-12-02 Thread Parav Pandit
> From: Yongji Xie > Sent: Wednesday, December 2, 2020 2:52 PM > > On Wed, Dec 2, 2020 at 12:53 PM Parav Pandit wrote: > > > > > > > > > From: Yongji Xie > > > Sent: Wednesday, December 2, 2020 9:00 AM > > > > > > On Tue, Dec 1, 2020 at 11:59 PM Parav Pandit wrote: > > > > > > > > > > > > >

[PATCH bpf v2] libbpf: sanitise map names before pinning

2020-12-02 Thread Toke Høiland-Jørgensen
When we added sanitising of map names before loading programs to libbpf, we still allowed periods in the name. While the kernel will accept these for the map names themselves, they are not allowed in file names when pinning maps. This means that bpf_object__pin_maps() will fail if called on an obje

Re: [PATCH net-next v3] macvlan: Support for high multicast packet rate

2020-12-02 Thread Thomas Karlsson
On 2020-12-01 20:11, Jakub Kicinski wrote: > On Mon, 30 Nov 2020 15:00:43 +0100 Thomas Karlsson wrote: >> Background: >> Broadcast and multicast packages are enqueued for later processing. >> This queue was previously hardcoded to 1000. >> >> This proved insufficient for handling very high packet r

Re: [PATCH net] cxgb3: fix error return code in t3_sge_alloc_qset()

2020-12-02 Thread Raju Rangoju
On Wednesday, December 12/02/20, 2020 at 17:56:05 +0800, Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b1fb1f280d09 ("cxgb3 - Fix dma mapping error path") > Reported-by: Hulk Robot > Signed

[PATCH v5 net-next 0/4] nfc: s3fwrn5: Support a UART interface

2020-12-02 Thread Bongsu Jeon
From: Bongsu Jeon S3FWRN82 is the Samsung's NFC chip that supports the UART communication. Before adding the UART driver module, I did refactoring the s3fwrn5_i2c module to reuse the common blocks. 1/4 is the dt bindings for the RN82 UART interface. 2/4..3/4 are refactoring the s3fwrn5_i2c modu

[PATCH v5 net-next 1/4] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-12-02 Thread Bongsu Jeon
From: Bongsu Jeon Since S3FWRN82 NFC Chip, The UART interface can be used. S3FWRN82 supports I2C and UART interface. Signed-off-by: Bongsu Jeon --- .../bindings/net/nfc/samsung,s3fwrn5.yaml | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/Doc

[PATCH v5 net-next 2/4] nfc: s3fwrn5: reduce the EN_WAIT_TIME

2020-12-02 Thread Bongsu Jeon
From: Bongsu Jeon The delay of 20ms is enough to enable and wake up the Samsung's nfc chip. Acked-by: Krzysztof Kozlowski Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nfc/s3fwrn5/i2c.c b/drivers/nfc/

[PATCH v5 net-next 3/4] nfc: s3fwrn5: extract the common phy blocks

2020-12-02 Thread Bongsu Jeon
From: Bongsu Jeon Extract the common phy blocks to reuse it. The UART module will use the common blocks. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/Makefile | 2 +- drivers/nfc/s3fwrn5/i2c.c| 117 +-- d

[PATCH v5 net-next 4/4] nfc: s3fwrn5: Support a UART interface

2020-12-02 Thread Bongsu Jeon
From: Bongsu Jeon Since S3FWRN82 NFC Chip, The UART interface can be used. S3FWRN82 uses NCI protocol and supports I2C and UART interface. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Bongsu Jeon --- drivers/nfc/s3fwrn5/Kconfig | 12 +++ drivers/nfc/s3fwrn5/Makefile | 2 + driv

[GIT PULL] vdpa: last minute bugfixes

2020-12-02 Thread Michael S. Tsirkin
A couple of patches of the obviously correct variety. The following changes since commit ad89653f79f1882d55d9df76c9b2b94f008c4e27: vhost-vdpa: fix page pinning leakage in error path (rework) (2020-11-25 04:29:07 -0500) are available in the Git repository at: https://git.kernel.org/pub/scm/

Linux IPV6 TCP egress path device passed for LOCAL_OUT hook is incorrect

2020-12-02 Thread Preethi Ramachandra
Hi David Ahren, In TCP egress path for ipv6 the device passed to NF_INET_LOCAL_OUT hook should be skb_dst(skb)->dev instead of dst->dev. https://elixir.bootlin.com/linux/latest/source/net/ipv6/ip6_output.c#L202 struct dst_entry *dst = skb_dst(skb); >>> This may return slave device. In this code

[PATCH v2 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Oleksij Rempel
Add stats support for the ar9331 switch. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/qca/ar9331.c | 242 ++- 1 file changed, 241 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index e24a99031b80..1a8027

[PATCH v2 1/2] net: dsa: add optional stats64 support

2020-12-02 Thread Oleksij Rempel
Allow DSA drivers to export stats64 Signed-off-by: Oleksij Rempel --- include/net/dsa.h | 3 +++ net/dsa/slave.c | 14 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index 4e60d2610f20..457b89143875 100644 --- a/include/net/

[PATCH v2 0/2] net: dsa: add stats64 support

2020-12-02 Thread Oleksij Rempel
changes v2: - use stats64 instead of get_ethtool_stats - add worked to poll for the stats Oleksij Rempel (2): net: dsa: add optional stats64 support net: dsa: qca: ar9331: export stats64 drivers/net/dsa/qca/ar9331.c | 242 ++- include/net/dsa.h|

Re: KMSAN: uninit-value in __skb_checksum_complete (5)

2020-12-02 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=13bd460750 kernel config: https://syzkall

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-12-02 Thread Michael Ellerman
Uwe Kleine-König writes: > Hello Michael, > > On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: >> On Thu, 26 Nov 2020 17:59:50 +0100, >> Uwe Kleine-König wrote: >> > >> > The driver core ignores the return value of struct device_driver::remove >> > because there is only little that c

Re: [PATCH v2 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Marc Kleine-Budde
On 12/2/20 1:07 PM, Oleksij Rempel wrote: > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/dsa/qca/ar9331.c | 242 ++- > 1 file changed, 241 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca/ar9331.c

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

2020-12-02 Thread Takashi Iwai
On Wed, 02 Dec 2020 13:14:06 +0100, Michael Ellerman wrote: > > Uwe Kleine-König writes: > > Hello Michael, > > > > On Sat, Nov 28, 2020 at 09:48:30AM +0100, Takashi Iwai wrote: > >> On Thu, 26 Nov 2020 17:59:50 +0100, > >> Uwe Kleine-König wrote: > >> > > >> > The driver core ignores the return

[PATCH 1/1] bareudp: constify device_type declaration

2020-12-02 Thread Jonas Bonn
device_type may be declared as const. Signed-off-by: Jonas Bonn --- drivers/net/bareudp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 28257bccec41..85ebd2b7e446 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareud

[PATCH 3/5] gtp: really check namespaces before xmit

2020-12-02 Thread Jonas Bonn
Blindly assuming that packet transmission crosses namespaces results in skb marks being lost in the single namespace case. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 096aaf1c86

[PATCH 4/5] gtp: drop unnecessary call to skb_dst_drop

2020-12-02 Thread Jonas Bonn
The call to skb_dst_drop() is already done as part of udp_tunnel_xmit(). Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index e053f86f43f3..c19465458187 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gt

[PATCH 5/5] gtp: set device type

2020-12-02 Thread Jonas Bonn
Set the devtype to 'gtp' when setting up the link. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index c19465458187..6de38e06588d 100644 --- a/drivers/net/gtp.c +++ b/drivers/net/gtp.c @@ -610,6 +610

[PATCH 1/5] gtp: set initial MTU

2020-12-02 Thread Jonas Bonn
The GTP link is brought up with a default MTU of zero. This can lead to some rather unexpected behaviour for users who are more accustomed to interfaces coming online with reasonable defaults. This patch sets an initial MTU for the GTP link of 1500 less worst-case tunnel overhead. Signed-off-by:

[PATCH 2/5] gtp: include role in link info

2020-12-02 Thread Jonas Bonn
Querying link info for the GTP interface doesn't reveal in which "role" the device is set to operate. Include this information in the info query result. Signed-off-by: Jonas Bonn --- drivers/net/gtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/dr

Re: [PATCH v2 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Oleksij Rempel
On Wed, Dec 02, 2020 at 01:15:58PM +0100, Marc Kleine-Budde wrote: > On 12/2/20 1:07 PM, Oleksij Rempel wrote: > > Add stats support for the ar9331 switch. > > > > Signed-off-by: Oleksij Rempel > > --- > > drivers/net/dsa/qca/ar9331.c | 242 ++- > > 1 file changed

[PATCH] net: 8021q: use netdev_info() instead of pr_info()

2020-12-02 Thread Enrico Weigelt, metux IT consult
Use netdev_info() instead of pr_info() for more consistent log output. Signed-off-by: Enrico Weigelt --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..d3a6f4ffdaef 100644 --- a/net/8021q/vlan.c +++

Re: [PATCH v2 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Marc Kleine-Budde
On 12/2/20 1:43 PM, Oleksij Rempel wrote: >>> +struct ar9331_sw_priv; >>> +struct ar9331_sw_port { >>> + int idx; >>> + struct ar9331_sw_priv *priv; >>> + struct delayed_work mib_read; >>> + struct ar9331_sw_stats stats; >>> + struct mutex lock; /* stats access */ >> >> What

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-02 Thread Miguel Ojeda
On Sat, Nov 28, 2020 at 8:34 PM Masahiro Yamada wrote: > > Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). > > A lot of warn_unused_result warnings existed in 2006, but until now > they have been fixed thanks to people doing allmodconfig tests. > > Our goal is to always enable __must_

[PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/8021q/vlan.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e

[PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/batman-adv/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index 70fee9b42e25..

[PATCH 5/7] net: bridge: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/bridge/br.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bridge/br.c b/net/bridge/br.c index 401eeb9142eb..2502fdcbb8b2 10064

[PATCH 3/7] net: ipv4: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt --- net/ipv4/tcp_cubic.c| 1 - net/ipv4/tcp_illinois.c | 1 - net/ipv4/tcp_nv.c | 1 - 3 files changed, 3 deletions(-) diff --git a/net/ipv4/tcp_cubic

[PATCH 6/7] net: vmw_vsock: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/vmw_vsock/af_vsock.c | 1 - net/vmw_vsock/hyperv_transport.c | 1 - net/vmw_vsock/vmci_transport.c | 1 - 3 files changed, 3

[PATCH 7/7] net: tipc: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/tipc/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/core.c b/net/tipc/core.c index c2ff42900b53..8c0c45347c53 10064

[PATCH 4/7] net: bluetooth: remove unneeded MODULE_VERSION() usage

2020-12-02 Thread Enrico Weigelt, metux IT consult
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult --- net/bluetooth/6lowpan.c | 3 --- net/bluetooth/af_bluetooth.c | 1 - net/bluetooth/bnep/core.c| 1 - net/bluetooth/cmtp/core.c

Re: [PATCH v2 1/2] net: dsa: add optional stats64 support

2020-12-02 Thread Vladimir Oltean
On Wed, Dec 02, 2020 at 01:07:11PM +0100, Oleksij Rempel wrote: > Allow DSA drivers to export stats64 > > Signed-off-by: Oleksij Rempel > --- Reviewed-by: Vladimir Oltean

Re: [PATCH net-next] net: sfp: add debugfs support

2020-12-02 Thread Russell King - ARM Linux admin
Jakub, What's your opinion on this patch? It seems to have stalled... Regards, Russell On Tue, Nov 24, 2020 at 12:46:40PM +0200, Ido Schimmel wrote: > On Tue, Nov 24, 2020 at 09:49:16AM +, Russell King - ARM Linux admin > wrote: > > On Tue, Nov 24, 2020 at 10:41:51AM +0200, Ido Schimmel wro

Re: [PATCH v2 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Vladimir Oltean
On Wed, Dec 02, 2020 at 01:07:12PM +0100, Oleksij Rempel wrote: > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- > /* Warning: switch reset will reset last AR9331_SW_MDIO_PHY_MODE_PAGE request > @@ -422,6 +527,7 @@ static void ar9331_sw_phylink_mac_link_down(str

Re: [PATCH 1/2][v3] e1000e: Leverage direct_complete to speed up s2ram

2020-12-02 Thread Kai-Heng Feng
Hi Yu, > On Dec 1, 2020, at 09:21, Chen Yu wrote: > > The NIC is put in runtime suspend status when there is no cable connected. > As a result, it is safe to keep non-wakeup NIC in runtime suspended during > s2ram because the system does not rely on the NIC plug event nor WoL to wake > up the sy

[net-next v4 3/8] seg6: add support for optional attributes in SRv6 behaviors

2020-12-02 Thread Andrea Mayer
Before this patch, each SRv6 behavior specifies a set of required attributes that must be provided by the userspace application when such behavior is going to be instantiated. If at least one of the required attributes is not provided, the creation of the behavior fails. The SRv6 behavior framewor

[net-next v4 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-12-02 Thread Andrea Mayer
This patchset provides support for the SRv6 End.DT4 and End.DT6 (VRF mode) behaviors. The SRv6 End.DT4 behavior is used to implement multi-tenant IPv4 L3 VPNs. It decapsulates the received packets and performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implement

[net-next v4 1/8] vrf: add mac header for tunneled packets when sniffer is attached

2020-12-02 Thread Andrea Mayer
Before this patch, a sniffer attached to a VRF used as the receiving interface of L3 tunneled packets detects them as malformed packets and it complains about that (i.e.: tcpdump shows bogus packets). The reason is that a tunneled L3 packet does not carry any L2 information and when the VRF is set

[net-next v4 6/8] seg6: add VRF support for SRv6 End.DT6 behavior

2020-12-02 Thread Andrea Mayer
SRv6 End.DT6 is defined in the SRv6 Network Programming [1]. The Linux kernel already offers an implementation of the SRv6 End.DT6 behavior which permits IPv6 L3 VPNs over SRv6 networks. This implementation is not particularly suitable in contexts where we need to deploy IPv6 L3 VPNs among differe

[net-next v4 4/8] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-12-02 Thread Andrea Mayer
We introduce two callbacks used for customizing the creation/destruction of a SRv6 behavior. Such callbacks are defined in the new struct seg6_local_lwtunnel_ops and hereafter we provide a brief description of them: - build_state(...): used for calling the custom constructor of the behavior du

[net-next v4 8/8] selftests: add selftest for the SRv6 End.DT6 (VRF) behavior

2020-12-02 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT6 (VRF) behavior used, in this example, for implementing IPv6 L3 VPN use cases. Signed-off-by: Andrea Mayer Signed-off-by: Paolo Lungaroni --- .../selftests/net/srv6_end_dt6_l3vpn_test.sh | 502 ++ 1 file changed, 502

[net-next v4 7/8] selftests: add selftest for the SRv6 End.DT4 behavior

2020-12-02 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT4 behavior used, in this example, for implementing IPv4 L3 VPN use cases. Signed-off-by: Andrea Mayer Reviewed-by: David Ahern --- .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 494 ++ 1 file changed, 494 insertions(+

[net-next v4 2/8] seg6: improve management of behavior attributes

2020-12-02 Thread Andrea Mayer
Depending on the attribute (i.e.: SEG6_LOCAL_SRH, SEG6_LOCAL_TABLE, etc), the parse() callback performs some validity checks on the provided input and updates the tunnel state (slwt) with the result of the parsing operation. However, an attribute may also need to reserve some additional resources (

[net-next v4 5/8] seg6: add support for the SRv6 End.DT4 behavior

2020-12-02 Thread Andrea Mayer
SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. The SRv6 End.DT4 is used to implement IPv4 L3VPN use-cases in multi-tenants environments. It decapsulates the received packets and it performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation

Re: [PATCH net-next] net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround

2020-12-02 Thread Russell King - ARM Linux admin
On Wed, Nov 25, 2020 at 02:00:20PM +, Russell King - ARM Linux admin wrote: > On Tue, Nov 24, 2020 at 08:18:56AM +0800, kernel test robot wrote: > > All warnings (new ones prefixed by >>): > > > >drivers/net/phy/sfp.c: In function 'sfp_i2c_read': > > >> drivers/net/phy/sfp.c:339:9: warning

RE: [PATCH] dpaa_eth: copy timestamp fields to new skb in A-050385 workaround

2020-12-02 Thread Camelia Alexandra Groza
> -Original Message- > From: Yangbo Lu > Sent: Tuesday, December 1, 2020 09:53 > To: netdev@vger.kernel.org > Cc: Y.b. Lu ; Madalin Bucur > ; David S . Miller > Subject: [PATCH] dpaa_eth: copy timestamp fields to new skb in A-050385 > workaround > > The timestamp fields should be copied

Re: [External] Re: [PATCH 0/7] Introduce vdpa management tool

2020-12-02 Thread Yongji Xie
On Wed, Dec 2, 2020 at 7:13 PM Parav Pandit wrote: > > > > > From: Yongji Xie > > Sent: Wednesday, December 2, 2020 2:52 PM > > > > On Wed, Dec 2, 2020 at 12:53 PM Parav Pandit wrote: > > > > > > > > > > > > > From: Yongji Xie > > > > Sent: Wednesday, December 2, 2020 9:00 AM > > > > > > > > On

Re: [PATCH net-next v2] mptcp: be careful on MPTCP-level ack.

2020-12-02 Thread Eric Dumazet
On 11/24/20 10:51 PM, Paolo Abeni wrote: > We can enter the main mptcp_recvmsg() loop even when > no subflows are connected. As note by Eric, that would > result in a divide by zero oops on ack generation. > > Address the issue by checking the subflow status before > sending the ack. > > Addit

Re: [PATCH net-next 2/2] net: ipa: add support for inline checksum offload

2020-12-02 Thread Alex Elder
On 12/1/20 8:13 PM, Jakub Kicinski wrote: >> To function, the rmnet driver must also add support for this new >> "inline" checksum offload. The changes implementing this will be >> submitted soon. > We don't usually merge half of a feature. Why not wait until all > support is in place? > > Do I u

[iproute2-next v2] seg6: add support for vrftable attribute in SRv6 End.DT4/DT6 behaviors

2020-12-02 Thread Paolo Lungaroni
We introduce the "vrftable" attribute for supporting the SRv6 End.DT4 and End.DT6 behaviors in iproute2. The "vrftable" attribute indicates the routing table associated with the VRF device used by SRv6 End.DT4/DT6 for routing IPv4/IPv6 packets. The SRv6 End.DT4/DT6 is used to implement IPv4/IPv6 L

Re: [PATCH net-next v1 0/3] vsock: Add flag field in the vsock address

2020-12-02 Thread Stefano Garzarella
Hi Andra, On Tue, Dec 01, 2020 at 05:25:02PM +0200, Andra Paraschiv wrote: vsock enables communication between virtual machines and the host they are running on. Nested VMs can be setup to use vsock channels, as the multi transport support has been available in the mainline since the v5.5 Linux

Re: [PATCH v2 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Oleksij Rempel
On Wed, Dec 02, 2020 at 03:04:38PM +0200, Vladimir Oltean wrote: > On Wed, Dec 02, 2020 at 01:07:12PM +0100, Oleksij Rempel wrote: > > Add stats support for the ar9331 switch. > > > > Signed-off-by: Oleksij Rempel > > --- > > /* Warning: switch reset will reset last AR9331_SW_MDIO_PHY_MODE_PAGE

[PATCH net-next v3] devlink: Add devlink port documentation

2020-12-02 Thread Parav Pandit
Added documentation for devlink port and port function related commands. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko Reviewed-by: Jacob Keller --- Changelog: v2->v3: - rephased many lines - first paragraph now describe devlink port - instead of saying PCI device/function, using PCI f

Re: [PATCH v5 6/9] task_isolation: arch/arm64: enable task isolation functionality

2020-12-02 Thread Mark Rutland
Hi Alex, On Mon, Nov 23, 2020 at 05:58:06PM +, Alex Belits wrote: > In do_notify_resume(), call task_isolation_before_pending_work_check() > first, to report isolation breaking, then after handling all pending > work, call task_isolation_start() for TIF_TASK_ISOLATION tasks. > > Add _TIF_TASK

Re: [EXT] Re: [PATCH v5 0/9] "Task_isolation" mode

2020-12-02 Thread Mark Rutland
On Tue, Nov 24, 2020 at 05:40:49PM +, Alex Belits wrote: > > On Tue, 2020-11-24 at 08:36 -0800, Tom Rix wrote: > > External Email > > > > --- > > --- > > > > On 11/23/20 9:42 AM, Alex Belits wrote: > > > This is an update of tas

[PATCH v3 net-next 0/2] net: dsa: add stats64 support

2020-12-02 Thread Oleksij Rempel
changes v3: - fix wrong multiplication - cancel port workers on remove changes v2: - use stats64 instead of get_ethtool_stats - add worked to poll for the stats Oleksij Rempel (2): net: dsa: add optional stats64 support net: dsa: qca: ar9331: export stats64 drivers/net/dsa/qca/ar9331.c | 24

[PATCH v3 net-next 1/2] net: dsa: add optional stats64 support

2020-12-02 Thread Oleksij Rempel
Allow DSA drivers to export stats64 Signed-off-by: Oleksij Rempel Reviewed-by: Vladimir Oltean --- include/net/dsa.h | 3 +++ net/dsa/slave.c | 14 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/include/net/dsa.h b/include/net/dsa.h index 4e60d2610f20..457b8914

[PATCH v3 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-02 Thread Oleksij Rempel
Add stats support for the ar9331 switch. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/qca/ar9331.c | 248 ++- 1 file changed, 247 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c index e24a99031b80..48c819

[PATCH v2 net-next] net: ipa: fix build-time bug in ipa_hardware_config_qsb()

2020-12-02 Thread Alex Elder
Jon Hunter reported observing a build bug in the IPA driver: https://lore.kernel.org/netdev/5b5d9d40-94d5-5dad-b861-fd9bef826...@nvidia.com The problem is that the QMB0 max read value set for IPA v4.5 (16) is too large to fit in the 4-bit field. The actual value we want is 0, which requests tha

Re: [PATCH v5 5/9] task_isolation: Add driver-specific hooks

2020-12-02 Thread Mark Rutland
On Mon, Nov 23, 2020 at 05:57:42PM +, Alex Belits wrote: > Some drivers don't call functions that call > task_isolation_kernel_enter() in interrupt handlers. Call it > directly. I don't think putting this in drivers is the right approach. IIUC we only need to track user<->kernel transitions, a

Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-12-02 Thread Mark Rutland
On Mon, Nov 23, 2020 at 05:58:22PM +, Alex Belits wrote: > From: Yuri Norov > > For nohz_full CPUs the desirable behavior is to receive interrupts > generated by tick_nohz_full_kick_cpu(). But for hard isolation it's > obviously not desirable because it breaks isolation. > > This patch adds

[PATCH net-next] selftests: forwarding: Add MPLS L2VPN test

2020-12-02 Thread Guillaume Nault
Connect hosts H1 and H2 using two intermediate encapsulation routers (LER1 and LER2). These routers encapsulate traffic from the hosts, including the original Ethernet header, into MPLS. Use ping to test reachability between H1 and H2. Signed-off-by: Guillaume Nault --- .../testing/selftests/ne

  1   2   3   4   >