Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Miguel Ojeda
On Mon, Nov 23, 2020 at 4:58 PM James Bottomley wrote: > > Well, I used git. It says that as of today in Linus' tree we have 889 > patches related to fall throughs and the first series went in in > october 2017 ... ignoring a couple of outliers back to February. I can see ~10k insertions over ~1

Re: [PATCH net-next v3 1/5] net: implement threaded-able napi poll loop support

2020-11-23 Thread Jakub Kicinski
On Sat, 21 Nov 2020 18:23:33 -0800 Wei Wang wrote: > On Sat, Nov 21, 2020 at 4:31 PM Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 11:10:05 -0800 Wei Wang wrote: > > > +int napi_set_threaded(struct napi_struct *n, bool threaded) > > > +{ > > > + ASSERT_RTNL(); > > > + > > > + if (n->dev-

Re: netconsole deadlock with virtnet

2020-11-23 Thread Steven Rostedt
On Mon, 23 Nov 2020 10:52:52 -0800 Jakub Kicinski wrote: > On Mon, 23 Nov 2020 09:31:28 -0500 Steven Rostedt wrote: > > On Mon, 23 Nov 2020 13:08:55 +0200 > > Leon Romanovsky wrote: > > > > > > > [ 10.028024] Chain exists of: > > > [ 10.028025] console_owner --> target_list_lock -->

[PATCH V3 net 3/3] net: ena: fix packet's addresses for rx_offset feature

2020-11-23 Thread Shay Agroskin
This patch fixes two lines in which the rx_offset received by the device wasn't taken into account: - prefetch function: In our driver the copied data would reside in rx_info->page + rx_headroom + rx_offset so the prefetch function is changed accordingly. - setting page_o

[PATCH V3 net 2/3] net: ena: set initial DMA width to avoid intel iommu issue

2020-11-23 Thread Shay Agroskin
The ENA driver uses the readless mechanism, which uses DMA, to find out what the DMA mask is supposed to be. If DMA is used without setting the dma_mask first, it causes the Intel IOMMU driver to think that ENA is a 32-bit device and therefore disables IOMMU passthrough permanently. This patch se

[PATCH V3 net 1/3] net: ena: handle bad request id in ena_netdev

2020-11-23 Thread Shay Agroskin
After request id is checked in validate_rx_req_id() its value is still used in the line rx_ring->free_ids[next_to_clean] = rx_ring->ena_bufs[i].req_id; even if it was found to be out-of-bound for the array free_ids. The patch moves the request id to

[PATCH V3 net 0/3] Fixes for ENA driver

2020-11-23 Thread Shay Agroskin
Hi all, This series fixes some issues in the ENA driver: - fix wrong data offset on machines that support rx offset - work-around Intel iommu issue - fix out of bound access when request id is wrong Changes from previous version: v1->v2: switched to using dma_set_mask_and_coherent() function

[PATCH net-next v1 1/2] lan743x: clean up software_isr function

2020-11-23 Thread Sven Van Asbroeck
From: Sven Van Asbroeck For no apparent reason, this function reads the INT_STS register, and checks if the software interrupt bit is set. These things have already been carried out by this function's only caller. Clean up by removing the redundant code. Tested-by: Sven Van Asbroeck # lan7430

[PATCH net-next v1 2/2] lan743x: replace polling loop by wait_event_timeout()

2020-11-23 Thread Sven Van Asbroeck
From: Sven Van Asbroeck The driver's ISR sends a 'software interrupt' event to the probe() thread using the following method: - probe(): write 0 to flag, enable s/w interrupt - probe(): poll on flag, relax using usleep_range() - ISR: write 1 to flag Replace with wake_up() / wait_event_timeou

Re: netconsole deadlock with virtnet

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 14:09:34 -0500 Steven Rostedt wrote: > On Mon, 23 Nov 2020 10:52:52 -0800 > Jakub Kicinski wrote: > > > On Mon, 23 Nov 2020 09:31:28 -0500 Steven Rostedt wrote: > > > On Mon, 23 Nov 2020 13:08:55 +0200 > > > Leon Romanovsky wrote: > > > > > > > > > > [ 10.028024] C

[PATCH net v2 0/3] ibmvnic: null pointer dereference

2020-11-23 Thread Lijun Pan
Fix two NULL pointer dereference crash issues. Improve module removal procedure. In v2, we split v1 into 3 sets according to patch dependencies so that individual author can rework on them during the coming holiday. 1-11 as a set since they are dependent and most of them are Dany's. 12-14 as a set

[PATCH net v2 2/3] ibmvnic: fix NULL pointer dereference in ibmvic_reset_crq

2020-11-23 Thread Lijun Pan
crq->msgs could be NULL if the previous reset did not complete after freeing crq->msgs. Check for NULL before dereferencing them. Snippet of call trace: ... ibmvnic 3003 env3 (unregistering): Releasing sub-CRQ ibmvnic 3003 env3 (unregistering): Releasing CRQ BUG: Kernel NULL pointer derefe

[PATCH net v2 1/3] ibmvnic: fix NULL pointer dereference in reset_sub_crq_queues

2020-11-23 Thread Lijun Pan
adapter->tx_scrq and adapter->rx_scrq could be NULL if the previous reset did not complete after freeing sub crqs. Check for NULL before dereferencing them. Snippet of call trace: ibmvnic 3006 env6: Releasing sub-CRQ ibmvnic 3006 env6: Releasing CRQ ... ibmvnic 3006 env6: Got Control I

Re: [EXT] Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-23 Thread Maciej Fijalkowski
On Fri, Nov 20, 2020 at 11:18:34AM +0300, Igor Russkikh wrote: > > > On 20/11/2020 1:49 am, Maciej Fijalkowski wrote: > > External Email > > > > -- > > On Thu, Nov 19, 2020 at 10:34:48PM +, Ramsay, Lincoln wrote: > >> When p

[PATCH net v2 3/3] ibmvnic: enhance resetting status check during module exit

2020-11-23 Thread Lijun Pan
Based on the discussion with Sukadev Bhattiprolu and Dany Madden, we believe that checking adapter->resetting bit is preferred since RESETTING state flag is not as strict as resetting bit. RESETTING state flag is removed since it is verbose now. Fixes: 7d7195a026ba ("ibmvnic: Do not process device

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 03:17:54 -0800 Xie He wrote: > On Mon, Nov 23, 2020 at 2:38 AM Martin Schiller wrote: > > Well, one could argue that we would have to repair these drivers, but I > > don't think that will get us anywhere. > > Yeah... One problem I see with the Linux project is the lack of >

Re: [PATCH net] net: openvswitch: fix TTL decrement action netlink message format

2020-11-23 Thread Matteo Croce
On Fri, Nov 20, 2020 at 10:12 PM Jakub Kicinski wrote: > > On Thu, 19 Nov 2020 04:04:04 -0500 Eelco Chaudron wrote: > > Currently, the openvswitch module is not accepting the correctly formated > > netlink message for the TTL decrement action. For both setting and getting > > the dec_ttl action, t

Re: [PATCH net 00/15] ibmvnic: assorted bug fixes

2020-11-23 Thread ljp
On 2020-11-20 16:40, Lijun Pan wrote: Assorted fixes and improvements for ibmvnic bugs. Dany Madden (9): ibmvnic: handle inconsistent login with reset ibmvnic: process HMC disable command ibmvnic: stop free_all_rwi on failed reset ibmvnic: remove free_all_rwi function ibmvnic: avoid me

Re: [PATCH net 02/15] ibmvnic: process HMC disable command

2020-11-23 Thread Jakub Kicinski
On Sun, 22 Nov 2020 07:12:38 -0800 drt wrote: > On 2020-11-21 15:36, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 16:40:36 -0600 Lijun Pan wrote: > >> From: Dany Madden > >> > >> Currently ibmvnic does not support the disable vnic command from the > >> Hardware Management Console. This patch e

Re: [PATCH net 15/15] ibmvnic: add some debugs

2020-11-23 Thread Sukadev Bhattiprolu
Jakub Kicinski [k...@kernel.org] wrote: > On Fri, 20 Nov 2020 16:40:49 -0600 Lijun Pan wrote: > > From: Sukadev Bhattiprolu > > > > We sometimes run into situations where a soft/hard reset of the adapter > > takes a long time or fails to complete. Having additional messages that > > include impor

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Jason Gunthorpe
On Fri, Nov 20, 2020 at 12:21:39PM -0600, Gustavo A. R. Silva wrote: > IB/hfi1: Fix fall-through warnings for Clang > IB/mlx4: Fix fall-through warnings for Clang > IB/qedr: Fix fall-through warnings for Clang > RDMA/mlx5: Fix fall-through warnings for Clang I picked these four to the rdm

[PATCH net-next 01/17] keys: Provide the original description to the key preparser

2020-11-23 Thread David Howells
Provide the proposed description (add key) or the original description (update/instantiate key) when preparsing a key so that the key type can validate it against the data. This is important for rxrpc server keys as we need to check that they have the right amount of key material present - and it'

[PATCH net 00/17] rxrpc: Prelude to gssapi support

2020-11-23 Thread David Howells
ls/linux-fs.git rxrpc-next-20201123 and can also be found on the following branch: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-next David --- David Howells (17): keys: Provide the original description to the key preparser rxrpc: Remove the rxk5

[PATCH net-next 02/17] rxrpc: Remove the rxk5 security class as it's now defunct

2020-11-23 Thread David Howells
Remove the rxrpc rxk5 security class as it's now defunct and nothing uses it anymore. Signed-off-by: David Howells --- include/keys/rxrpc-type.h | 55 - net/rxrpc/key.c | 468 - 2 files changed, 523 deletions(-) diff --git a/include/

[PATCH net-next 04/17] rxrpc: Support keys with multiple authentication tokens

2020-11-23 Thread David Howells
rxrpc-type keys can have multiple tokens attached for different security classes. Currently, rxrpc always picks the first one, whether or not the security class it indicates is supported. Add preliminary support for choosing which security class will be used (this will need to be directed from a

[PATCH net-next 05/17] rxrpc: Don't retain the server key in the connection

2020-11-23 Thread David Howells
Don't retain a pointer to the server key in the connection, but rather get it on demand when the server has to deal with a response packet. This is necessary to implement RxGK (GSSAPI-mediated transport class), where we can't know which key we'll need until we've challenged the client and got back

[PATCH net-next 03/17] rxrpc: List the held token types in the key description in /proc/keys

2020-11-23 Thread David Howells
When viewing an rxrpc-type key through /proc/keys, display a list of held token types. Signed-off-by: David Howells --- net/rxrpc/key.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index fb4d2a2fca02..197b4

[PATCH net-next 08/17] rxrpc: Don't leak the service-side session key to userspace

2020-11-23 Thread David Howells
Don't let someone reading a service-side rxrpc-type key get access to the session key that was exchanged with the client. The server application will, at some point, need to be able to read the information in the ticket, but this probably shouldn't include the key material. Signed-off-by: David H

[PATCH net-next 10/17] rxrpc: Make the parsing of xdr payloads more coherent

2020-11-23 Thread David Howells
Make the parsing of xdr-encoded payloads, as passed to add_key, more coherent. Shuttling back and forth between various variables was a bit hard to follow. Signed-off-by: David Howells --- net/rxrpc/key.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --g

[PATCH net-next 06/17] rxrpc: Split the server key type (rxrpc_s) into its own file

2020-11-23 Thread David Howells
Split the server private key type (rxrpc_s) out into its own file rather than mingling it with the authentication/client key type (rxrpc) since they don't really bear any relation. Signed-off-by: David Howells --- net/rxrpc/Makefile |1 net/rxrpc/ar-internal.h |9 ++- net/rxrpc/ke

[PATCH net-next 11/17] rxrpc: Ignore unknown tokens in key payload unless no known tokens

2020-11-23 Thread David Howells
When parsing a payload for an rxrpc-type key, ignore any tokens that are not of a known type and don't give an error for them - unless there are no tokens of a known type. Signed-off-by: David Howells --- net/rxrpc/key.c | 31 +-- 1 file changed, 21 insertions(+),

[PATCH net-next 07/17] rxrpc: Hand server key parsing off to the security class

2020-11-23 Thread David Howells
Hand responsibility for parsing a server key off to the security class. We can determine which class from the description. This is necessary as rxgk server keys have different lookup requirements and different content requirements (dependent on crypto type) to those of rxkad server keys. Signed-

[PATCH net-next 09/17] rxrpc: Allow security classes to give more info on server keys

2020-11-23 Thread David Howells
Allow a security class to give more information on an rxrpc_s-type key when it is viewed in /proc/keys. This will allow the upcoming RxGK security class to show the enctype name here. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |3 +++ net/rxrpc/server_key.c |4 2 fi

[PATCH net-next 12/17] rxrpc: Fix example key name in a comment

2020-11-23 Thread David Howells
Fix an example of an rxrpc key name in a comment. Signed-off-by: David Howells --- net/rxrpc/key.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c index 7e6d19263ce3..9631aa8543b5 100644 --- a/net/rxrpc/key.c +++ b/net/rxrpc/key.c @@ -5,7

[PATCH net-next 13/17] rxrpc: Merge prime_packet_security into init_connection_security

2020-11-23 Thread David Howells
Merge the ->prime_packet_security() into the ->init_connection_security() hook as they're always called together. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |2 -- net/rxrpc/conn_client.c |6 -- net/rxrpc/conn_event.c |4 net/rxrpc/insecure.c|6 --

[PATCH net-next 14/17] rxrpc: Don't reserve security header in Tx DATA skbuff

2020-11-23 Thread David Howells
Insert the security header into the skbuff representing a DATA packet to be transmitted rather than using skb_reserve() when the packet is allocated. This makes it easier to apply crypto that spans the security header and the data, particularly in the upcoming RxGK class where we have a common encr

[PATCH net-next 15/17] rxrpc: Organise connection security to use a union

2020-11-23 Thread David Howells
Organise the security information in the rxrpc_connection struct to use a union to allow for different data for different security classes. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h | 11 --- net/rxrpc/rxkad.c | 40 2 fil

[PATCH net-next 17/17] rxrpc: Ask the security class how much space to allow in a packet

2020-11-23 Thread David Howells
Ask the security class how much header and trailer space to allow for when allocating a packet, given how much data is remaining. This will allow the rxgk security class to stick both a trailer in as well as a header as appropriate in the future. Signed-off-by: David Howells --- net/rxrpc/ar-i

[PATCH net-next 16/17] rxrpc: rxkad: Don't use pskb_pull() to advance through the response packet

2020-11-23 Thread David Howells
In the rxkad security class, don't use pskb_pull() to advance through the contents of the response packet. There's no point, especially as the next and last access to the skbuff still has to allow for the wire header in the offset (which we didn't advance over). Better to just add the displacemen

Re: [PATCH net-next v2 1/2] lockdep: Introduce in_softirq lockdep assert

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 15:27:25 +0100 Peter Zijlstra wrote: > On Sat, Nov 21, 2020 at 11:06:15AM +0800, Yunsheng Lin wrote: > > The current semantic for napi_consume_skb() is that caller need > > to provide non-zero budget when calling from NAPI context, and > > breaking this semantic will cause hard

Re: [PATCH v2] net: mvpp2: divide fifo for dts-active ports only

2020-11-23 Thread Russell King - ARM Linux admin
On Mon, Nov 23, 2020 at 07:54:33PM +0200, stef...@marvell.com wrote: > From: Stefan Chulski > > Tx/Rx FIFO is a HW resource limited by total size, but shared > by all ports of same CP110 and impacting port-performance. > Do not divide the FIFO for ports which are not enabled in DTS, > so active p

[PATCH v2 net] ptp: clockmatrix: bug fix for idtcm_strverscmp

2020-11-23 Thread min.li.xe
From: Min Li Feed kstrtou8 with NULL terminated string. Changes since v1: -Use strscpy instead of strncpy for safety. Signed-off-by: Min Li --- drivers/ptp/ptp_clockmatrix.c | 60 ++- tools/bpf/example | 12 + tools/bpf/novlan

Re: [PATCH net-next 15/17] rxrpc: Organise connection security to use a union

2020-11-23 Thread Joe Perches
On Mon, 2020-11-23 at 20:11 +, David Howells wrote: > Organise the security information in the rxrpc_connection struct to use a > union to allow for different data for different security classes. Is there a known future purpose to this? > diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-in

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread James Bottomley
On Mon, 2020-11-23 at 19:56 +0100, Miguel Ojeda wrote: > On Mon, Nov 23, 2020 at 4:58 PM James Bottomley > wrote: > > Well, I used git. It says that as of today in Linus' tree we have > > 889 patches related to fall throughs and the first series went in > > in october 2017 ... ignoring a couple o

Re: [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-23 Thread George McCollister
On Fri, Nov 20, 2020 at 5:24 PM Andrew Lunn wrote: > > Hi George > > > > > +static void xrs700x_port_stp_state_set(struct dsa_switch *ds, int port, > > > > +u8 state) > > > > +{ > > > > + struct xrs700x *priv = ds->priv; > > > > + unsigned int val; > > >

Re: [PATCH net-next 15/17] rxrpc: Organise connection security to use a union

2020-11-23 Thread David Howells
Joe Perches wrote: > It seems no other follow-on patch in the series uses this nameless union. There will be a follow on series. Either this: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rxgk or this: https://git.kernel.org/pub/scm/lin

Re: [PATCH mlx5-next 09/16] net/mlx5: Expose IP-in-IP TX and RX capability bits

2020-11-23 Thread Saeed Mahameed
On Sun, 2020-11-22 at 17:17 +0200, Aya Levin wrote: > > On 11/22/2020 1:58 AM, Jakub Kicinski wrote: > > On Fri, 20 Nov 2020 15:03:32 -0800 Saeed Mahameed wrote: > > > From: Aya Levin > > > > > > Expose FW indication that it supports stateless offloads for IP > > > over IP > > > tunneled packets

Re: [PATCH] net: mlx5e: fix fs_tcp.c build when IPV6 is not enabled

2020-11-23 Thread Saeed Mahameed
On Mon, 2020-11-23 at 12:08 +0200, Tariq Toukan wrote: > > On 11/22/2020 11:12 PM, Randy Dunlap wrote: > > Fix build when CONFIG_IPV6 is not enabled by making a function > > be built conditionally. > > > > Fixes these build errors and warnings: > > > > ../drivers/net/ethernet/mellanox/mlx5/core/

Re: [PATCH iproute2-next 0/7] Convert a number of use-cases to parse_on_off(), print_on_off()

2020-11-23 Thread Nikolay Aleksandrov
On 17/11/2020 02:56, David Ahern wrote: > On 11/14/20 3:53 PM, Petr Machata wrote: >> Two helpers, parse_on_off() and print_on_off(), have been recently added to >> lib/utils.c. Convert a number of instances of the same effective behavior >> to calls to these helpers. >> >> Petr Machata (7): >> b

Re: [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-23 Thread George McCollister
On Sun, Nov 22, 2020 at 5:39 PM Vladimir Oltean wrote: > > Hi George, > > On Fri, Nov 20, 2020 at 12:16:26PM -0600, George McCollister wrote: > > Add a driver with initial support for the Arrow SpeedChips XRS7000 > > series of gigabit Ethernet switch chips which are typically used in > > critical

Re: [PATCH net-next] net: sched: alias action flags with TCA_ACT_ prefix

2020-11-23 Thread Jakub Kicinski
On Sat, 21 Nov 2020 18:09:02 +0200 Vlad Buslov wrote: > Currently both filter and action flags use same "TCA_" prefix which makes > them hard to distinguish to code and confusing for users. Create aliases > for existing action flags constants with "TCA_ACT_" prefix. > > Signed-off-by: Vlad Buslov

Re: [PATCH net-next v2] compat: always include linux/compat.h from net/compat.h

2020-11-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 21 Nov 2020 13:48:44 -0800 you wrote: > We're about to do reshuffling in networking headers and > eliminate some implicit includes. This results in: > > In file included from ../net/ipv4/netfilter/arp_tables.c:26:

[PATCH net v5] aquantia: Remove the build_skb path

2020-11-23 Thread Ramsay, Lincoln
From: Lincoln Ramsay When performing IPv6 forwarding, there is an expectation that SKBs will have some headroom. When forwarding a packet from the aquantia driver, this does not always happen, triggering a kernel warning. aq_ring.c has this code (edited slightly for brevity): if (buff->is_eop &

Re: [PATCH net 02/15] ibmvnic: process HMC disable command

2020-11-23 Thread drt
On 2020-11-23 11:43, Jakub Kicinski wrote: On Sun, 22 Nov 2020 07:12:38 -0800 drt wrote: On 2020-11-21 15:36, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 16:40:36 -0600 Lijun Pan wrote: >> From: Dany Madden >> >> Currently ibmvnic does not support the disable vnic command from the >> Hardware M

Re: [PATCH v5 1/9] task_isolation: vmstat: add quiet_vmstat_sync function

2020-11-23 Thread Thomas Gleixner
Alex, On Mon, Nov 23 2020 at 17:56, Alex Belits wrote: why are you insisting on adding 'task_isolation: ' as prefix to every single patch? That's wrong as I explained before. The prefix denotes the affected subsystem and 'task_isolation' is _NOT_ a subsystem. It's the project name you are using

Re: [PATCH v5 2/9] task_isolation: vmstat: add vmstat_idle function

2020-11-23 Thread Thomas Gleixner
On Mon, Nov 23 2020 at 17:56, Alex Belits wrote: > This function checks to see if a vmstat worker is not running, > and the vmstat diffs don't require an update. The function is > called from the task-isolation code to see if we need to > actually do some work to quiet vmstat. A changelog has to

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-23 Thread Saeed Mahameed
On Fri, 2020-11-20 at 11:04 -0800, Samudrala, Sridhar wrote: > > On 11/20/2020 9:58 AM, Alexander Duyck wrote: > > On Thu, Nov 19, 2020 at 5:29 PM Jakub Kicinski > > wrote: > > > On Wed, 18 Nov 2020 21:35:29 -0700 David Ahern wrote: > > > > On 11/18/20 7:14 PM, Jakub Kicinski wrote: > > > > > On

[PATCH net-next] net: sfp: VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 workaround

2020-11-23 Thread Russell King
Add a workaround for the VSOL V2801F / CarlitoxxPro CPGOS03-0490 v2.0 GPON module which the manufacturer states needs single byte I2C reads to the EEPROM. Reported-by: Thomas Schreiber Tested-by: Thomas Schreiber Signed-off-by: Russell King --- drivers/net/phy/sfp.c | 45 ++

Re: [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-23 Thread Andrew Lunn
> > If it cannot send/receive BPDUs, it might get into an oscillating > > state. They see each other via BPDUs, decide there is a loop, and > > block a port. The BPDUs stop, they think the loop has been broken and > > so unblock. They see each other via BPUS, decide there is a loop,... > > Yeah, t

Re: [PATCH v5 3/9] task_isolation: userspace hard isolation from kernel

2020-11-23 Thread Thomas Gleixner
Alex, On Mon, Nov 23 2020 at 17:56, Alex Belits wrote: > .../admin-guide/kernel-parameters.txt | 6 + > drivers/base/cpu.c| 23 + > include/linux/hrtimer.h | 4 + > include/linux/isolation.h | 326 > inclu

Re: [PATCH net-next 2/3] mlxsw: spectrum_ptp: use PTP wide message type definitions

2020-11-23 Thread Jakub Kicinski
On Sun, 22 Nov 2020 22:01:54 +0200 Ido Schimmel wrote: > > > I don't know what are Jakub's preferences, but had this happened on our > > > internal patchwork instance, I would just ask the author to submit > > > another version with all the patches. > > Please let me know how I shall proceed...

Re: [PATCH net-next v3 0/3] net: ptp: introduce common defines for PTP message types

2020-11-23 Thread Jakub Kicinski
On Fri, 20 Nov 2020 09:41:03 +0100 Christian Eggers wrote: > This series introduces commen defines for PTP event messages. Driver > internal defines are removed and some uses of magic numbers are replaced > by the new defines. Applied, thanks!

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 16:25:53 +0200 Nikolay Aleksandrov wrote: > >>> @@ -156,4 +157,10 @@ struct br_mrp_in_link_hdr { > >>> __be16 interval; > >>> }; > >>> > >>> +struct br_mrp_in_link_status_hdr { > >>> + __u8 sa[ETH_ALEN]; > >>> + __be16 port_role; > >>> + __be16 id; > >>> +}; >

[PATCH net-next] net: sfp: add debugfs support

2020-11-23 Thread Russell King
Add debugfs support to SFP so that the internal state of the SFP state machines and hardware signal state can be viewed from userspace, rather than having to compile a debug kernel to view state state transitions in the kernel log. The 'state' output looks like: Module state: empty Module probe a

Re: [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-23 Thread Andrew Lunn
> > > https://www.flexibilis.com/downloads/xrs/SpeedChip_XRS7000_3000_User_Manual.pdf Section 6.1.4 The forwarding decision is presented in Figure 19. Note that also frames coming into a disabled port are received to the buffer memory, but because their forwarding decision is not to forward them

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Xie He
On Mon, Nov 23, 2020 at 11:36 AM Jakub Kicinski wrote: > > > > From this point of view it will be the best to handle the NETDEV_UP in > > > the lapb event handler and establish the link analog to the > > > NETDEV_CHANGE event if the carrier is UP. > > > > Thanks! This way we can make sure LAPB wo

Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-11-23 Thread Frederic Weisbecker
Hi Alex, On Mon, Nov 23, 2020 at 05:58:22PM +, Alex Belits wrote: > From: Yuri Norov > > For nohz_full CPUs the desirable behavior is to receive interrupts > generated by tick_nohz_full_kick_cpu(). But for hard isolation it's > obviously not desirable because it breaks isolation. > > This p

Re: [PATCH net-next 3/3] dt-bindings: net: dsa: add bindings for xrs700x switches

2020-11-23 Thread Florian Fainelli
On 11/20/2020 10:16 AM, George McCollister wrote: > Add documentation and an example for Arrow SpeedChips XRS7000 Series > single chip Ethernet switches. > > Signed-off-by: George McCollister Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next v3 2/7] dpaa_eth: add basic XDP support

2020-11-23 Thread Maciej Fijalkowski
On Fri, Nov 20, 2020 at 06:50:28PM +, Camelia Alexandra Groza wrote: > > -Original Message- > > From: Maciej Fijalkowski > > Sent: Friday, November 20, 2020 02:19 > > To: Camelia Alexandra Groza > > Cc: k...@kernel.org; bro...@redhat.com; sa...@kernel.org; > > da...@davemloft.net; Mad

Re: [PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)

2020-11-23 Thread Martin Blumenstingl
Hello Ioana, On Mon, Nov 23, 2020 at 4:38 PM Ioana Ciornei wrote: [...] > Ioana Ciornei (15): > net: phy: intel-xway: implement generic .handle_interrupt() callback > net: phy: intel-xway: remove the use of .ack_interrupt() > net: phy: icplus: implement generic .handle_interrupt() callback

Re: [PATCH net-next 1/3] dsa: add support for Arrow XRS700x tag trailer

2020-11-23 Thread Florian Fainelli
On 11/20/2020 10:16 AM, George McCollister wrote: > Add support for Arrow SpeedChips XRS700x single byte tag trailer. This > is modeled on tag_trailer.c which works in a similar way. > > Signed-off-by: George McCollister One question below: [snip] > + if (pskb_trim_rcsum(skb, skb->len -

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-23 Thread Alexander Duyck
On Mon, Nov 23, 2020 at 1:14 AM Xin Long wrote: > > On Sat, Nov 21, 2020 at 12:10 AM Alexander Duyck > wrote: > > > > On Fri, Nov 20, 2020 at 2:23 AM Xin Long wrote: > > > > > > On Fri, Nov 20, 2020 at 1:24 AM Alexander Duyck > > > wrote: > > > > > > > > On Wed, Nov 18, 2020 at 9:53 PM Xin Long

Re: [PATCH net-next 2/3] net: dsa: add Arrow SpeedChips XRS700x driver

2020-11-23 Thread George McCollister
On Mon, Nov 23, 2020 at 4:09 PM Andrew Lunn wrote: > > > > > https://www.flexibilis.com/downloads/xrs/SpeedChip_XRS7000_3000_User_Manual.pdf > > Section 6.1.4 > > The forwarding decision is presented in Figure 19. Note that also > frames coming into a disabled port are received to the buffer memor

Re: [PATCH net-next v3 4/7] dpaa_eth: add XDP_TX support

2020-11-23 Thread Maciej Fijalkowski
On Fri, Nov 20, 2020 at 06:54:42PM +, Camelia Alexandra Groza wrote: > > -Original Message- > > From: Maciej Fijalkowski > > Sent: Friday, November 20, 2020 01:51 > > To: Camelia Alexandra Groza > > Cc: k...@kernel.org; bro...@redhat.com; sa...@kernel.org; > > da...@davemloft.net; Mad

Re: [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus

2020-11-23 Thread Frederic Weisbecker
On Mon, Nov 23, 2020 at 05:58:42PM +, Alex Belits wrote: > From: Yuri Norov > > Make sure that kick_all_cpus_sync() does not call CPUs that are running > isolated tasks. > > Signed-off-by: Yuri Norov > [abel...@marvell.com: use safe task_isolation_cpumask() implementation] > Signed-off-by:

Re: Hardcoded multicast queue length in macvlan.c driver causes poor multicast receive performance

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 14:22:31 + Thomas Karlsson wrote: > Hello, > > There is a special queue handling in macvlan.c for broadcast and > multicast packages that was arbitrarily set to 1000 in commit > 07d92d5cc977a7fe1e683e1d4a6f723f7f2778cb . While this is probably > sufficient for most uses cas

Re: [PATCH v5 4/9] task_isolation: Add task isolation hooks to arch-independent code

2020-11-23 Thread Thomas Gleixner
Alex, On Mon, Nov 23 2020 at 17:57, Alex Belits wrote: > Kernel entry and exit functions for task isolation are added to context > tracking and common entry points. Common handling of pending work on exit > to userspace now processes isolation breaking, cleanup and start. Again: You fail to expla

Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-11-23 Thread Alex Belits
On Mon, 2020-11-23 at 23:13 +0100, Frederic Weisbecker wrote: > External Email > > --- > --- > Hi Alex, > > On Mon, Nov 23, 2020 at 05:58:22PM +, Alex Belits wrote: > > From: Yuri Norov > > > > For nohz_full CPUs the desirable

Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-11-23 Thread Thomas Gleixner
On Mon, Nov 23 2020 at 17:58, Alex Belits wrote: > From: Yuri Norov > > For nohz_full CPUs the desirable behavior is to receive interrupts > generated by tick_nohz_full_kick_cpu(). But for hard isolation it's > obviously not desirable because it breaks isolation. > > This patch adds check for it.

Re: [PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 23:13:11 +0100 Martin Blumenstingl wrote: > > Ioana Ciornei (15): > > net: phy: intel-xway: implement generic .handle_interrupt() callback > > net: phy: intel-xway: remove the use of .ack_interrupt() > > net: phy: icplus: implement generic .handle_interrupt() callback > >

Re: [PATCH net-next v2 1/2] ethtool: Add CMIS 4.0 module type to UAPI

2020-11-23 Thread Jesse Brandeburg
Moshe Shemesh wrote: > From: Vladyslav Tarasiuk > > CMIS 4.0 document describes a universal EEPROM memory layout, which is > used for some modules such as DSFP, OSFP and QSFP-DD modules. In order > to distinguish them in userspace from existing standards, add > corresponding values. > > CMIS 4.

Re: [EXT] Re: [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus

2020-11-23 Thread Alex Belits
On Mon, 2020-11-23 at 23:29 +0100, Frederic Weisbecker wrote: > External Email > > --- > --- > On Mon, Nov 23, 2020 at 05:58:42PM +, Alex Belits wrote: > > From: Yuri Norov > > > > Make sure that kick_all_cpus_sync() does not c

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 23:31:48 +0100 Horatiu Vultur wrote: > > The existing structs are only present in net-next as well, so if you > > don't mind Horatiu it'd be good to follow up and remove the unused ones > > and move the ones (if any) which are only used by the kernel but not by > > the user spac

Re: [PATCH net-next v2] net: don't include ethtool.h from netdevice.h

2020-11-23 Thread Jesse Brandeburg
Jakub Kicinski wrote: > linux/netdevice.h is included in very many places, touching any > of its dependecies causes large incremental builds. > > Drop the linux/ethtool.h include, linux/netdevice.h just needs > a forward declaration of struct ethtool_ops. > > Fix all the places which made use of

Re: [PATCH net-next resend 1/2] enetc: Fix endianness issues for enetc_ethtool

2020-11-23 Thread Jesse Brandeburg
Claudiu Manoil wrote: > These particular fields are specified in the H/W reference > manual as having network byte order format, so enforce big > endian annotation for them and clear the related sparse > warnings in the process. > > Signed-off-by: Claudiu Manoil Thanks for fixing these warnings

Re: [PATCH 015/141] netfilter: Fix fall-through warnings for Clang

2020-11-23 Thread Gustavo A. R. Silva
On Fri, Nov 20, 2020 at 11:47:37PM +0100, Florian Westphal wrote: > Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > > warnings by explicitly adding multiple break statements instead of just > > letting the code fall through to the next case.

Re: [EXT] [PATCH 018/141] qed: Fix fall-through warnings for Clang

2020-11-23 Thread Gustavo A. R. Silva
On Fri, Nov 20, 2020 at 09:50:06PM +0300, Igor Russkikh wrote: > > > On 20/11/2020 9:26 pm, Gustavo A. R. Silva wrote: > > External Email > > > > -- > > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > >

Re: [PATCH 044/141] net/mlx4: Fix fall-through warnings for Clang

2020-11-23 Thread Gustavo A. R. Silva
On Sun, Nov 22, 2020 at 10:36:01AM +0200, Tariq Toukan wrote: > > > On 11/20/2020 8:31 PM, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > > by explicitly adding a break statement instead of just letting the code > > fall through to the ne

Re: [PATCH V4 net-next 0/4] net: hns3: updates for -next

2020-11-23 Thread Jesse Brandeburg
Huazhong Tan wrote: > There are several updates relating to the interrupt coalesce for > the HNS3 ethernet driver. > > #1 adds support for QL(quantity limiting, interrupt coalesce >based on the frame quantity). > #2 queries the maximum value of GL from the firmware instead of >a fixed val

Re: [PATCH net-next] net: DSCP in IPv4 routing v2

2020-11-23 Thread Guillaume Nault
On Sat, Nov 21, 2020 at 06:24:46PM +1000, Russell Strong wrote: > From 2f27f92d5a6f4dd69ac4af32cdb51ba8d2083606 Mon Sep 17 00:00:00 2001 > From: Russell Strong > Date: Sat, 21 Nov 2020 18:12:43 +1000 > Subject: [PATCH] DSCP in IPv4 routing v2 > > This patch allows the use of DSCP values in routin

Re: [PATCH net-next 00/15] net: phy: add support for shared interrupts (part 3)

2020-11-23 Thread Ioana Ciornei
On Mon, Nov 23, 2020 at 02:37:13PM -0800, Jakub Kicinski wrote: > On Mon, 23 Nov 2020 23:13:11 +0100 Martin Blumenstingl wrote: > > > Ioana Ciornei (15): > > > net: phy: intel-xway: implement generic .handle_interrupt() callback > > > net: phy: intel-xway: remove the use of .ack_interrupt() > >

Re: [EXT] Re: [PATCH v5 9/9] task_isolation: kick_all_cpus_sync: don't kick isolated cpus

2020-11-23 Thread Frederic Weisbecker
On Mon, Nov 23, 2020 at 10:39:34PM +, Alex Belits wrote: > > On Mon, 2020-11-23 at 23:29 +0100, Frederic Weisbecker wrote: > > External Email > > > > --- > > --- > > On Mon, Nov 23, 2020 at 05:58:42PM +, Alex Belits wrote: >

Re: [net-next v3 05/15] ice: create flow profile

2020-11-23 Thread Jesse Brandeburg
Alexander Duyck wrote: > > > I'm not sure this logic is correct. Can the flow director rules > > > handle > > > a field that is removed? Last I knew it couldn't. If that is the case > > > you should be using ACL for any case in which a full mask is not > > > provided. So in your tests below you co

Re: pull-request: wireless-drivers-2020-11-23

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 16:10:37 + (UTC) Kalle Valo wrote: > wireless-drivers fixes for v5.10 > > First set of fixes for v5.10. One fix for iwlwifi kernel panic, others > less notable. > > rtw88 > > * fix a bogus test found by clang > > iwlwifi > > * fix long memory reads causing soft lockup w

Re: [PATCH] lsm,selinux: pass flowi_common instead of flowi to the LSM hooks

2020-11-23 Thread Paul Moore
On Thu, Nov 19, 2020 at 10:02 PM James Morris wrote: > On Thu, 19 Nov 2020, Paul Moore wrote: > > As pointed out by Herbert in a recent related patch, the LSM hooks do > > not have the necessary address family information to use the flowi > > struct safely. As none of the LSMs currently use any o

Re: [PATCH bpf-next v3 00/10] Introduce preferred busy-polling

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 14:31:14 +0100 Björn Töpel wrote: > Eric/Jakub, any more thoughts/input? Tomatoes? :-P Looking now, sorry for the delay. Somehow patches without net in their tag feel like they can wait..

[PATCH net v2 1/9] ibmvnic: handle inconsistent login with reset

2020-11-23 Thread Dany Madden
Inconsistent login with the vnicserver is causing the device to be removed. This does not give the device a chance to recover from error state. This patch schedules a FATAL reset instead to bring the adapter up. Fixes: 032c5e82847a2 ("Driver for IBM System i/p VNIC protocol") Signed-off-by: Dany

[PATCH net v2 4/9] ibmvnic: restore adapter state on failed reset

2020-11-23 Thread Dany Madden
In a failed reset, driver could end up in VNIC_PROBED or VNIC_CLOSED state and cannot recover in subsequent resets, leaving it offline. This patch restores the adapter state to reset_state, the original state when reset was called. Fixes: b27507bb59ed5 ("net/ibmvnic: unlock rtnl_lock in reset so

[PATCH net v2 0/9] ibmvnic: assorted bug fixes

2020-11-23 Thread Dany Madden
Assorted fixes for ibmvnic originated from "[PATCH net 00/15] ibmvnic: assorted bug fixes" sent by Lijun Pan. V2 Changes as suggested by Jakub Kicinski: - Added "Fixes" to each patch - Remove "ibmvnic: process HMC disable command" from the series. Submitting it separately to net-next. - Squash

[PATCH net v2 8/9] ibmvnic: no reset timeout for 5 seconds after reset

2020-11-23 Thread Dany Madden
Reset timeout is going off right after adapter reset. This patch ensures that timeout is scheduled if it has been 5 seconds since the last reset. 5 seconds is the default watchdog timeout. Fixes: ed651a10875f1 ("ibmvnic: Updated reset handling") Signed-off-by: Dany Madden --- drivers/net/ethern

<    1   2   3   4   >