Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface

2020-11-23 Thread k...@kernel.org
On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote: > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon > --- > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 28 +-- > 1 file changed, 26

Re: [PATCH net-next v2] compat: always include linux/compat.h from net/compat.h

2020-11-23 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH net-next] net: page_pool: Add page_pool_put_page_bulk() to page_pool.rst

2020-11-23 Thread Ilias Apalodimas
On Fri, Nov 20, 2020 at 11:19:34PM +0100, Lorenzo Bianconi wrote: > Introduce page_pool_put_page_bulk() entry into the API section of > page_pool.rst > > Signed-off-by: Lorenzo Bianconi > --- > Documentation/networking/page_pool.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git

Re: [PATCH net] bonding: fix feature flag setting at init time

2020-11-23 Thread Ivan Vecera
On Sun, 22 Nov 2020 22:17:16 -0500 Jarod Wilson wrote: > Have run into a case where bond_option_mode_set() gets called before > hw_features has been filled in, and very bad things happen when > netdev_change_features() then gets called, because the empty hw_features > wipes out almost all feature

Re: [PATCH net-next 2/2] net: nfc: s3fwrn5: Support a UART interface

2020-11-23 Thread k...@kernel.org
On Mon, Nov 23, 2020 at 04:56:58PM +0900, Bongsu Jeon wrote: > Since S3FWRN82 NFC Chip, The UART interface can be used. > S3FWRN82 uses NCI protocol and supports I2C and UART interface. > > Signed-off-by: Bongsu Jeon Please start sending emails properly, e.g. with git send-email, so all your pat

Re: [PATCH bpf] xsk: fix incorrect netdev reference count

2020-11-23 Thread Magnus Karlsson
On Fri, Nov 20, 2020 at 4:17 PM wrote: > > From: Marek Majtyka > > Fix incorrect netdev reference count in xsk_bind operation. Incorrect > reference count of the device appears when a user calls bind with the > XDP_ZEROCOPY flag on an interface which does not support zero-copy. > In such a case,

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Xie He
On Sun, Nov 22, 2020 at 10:55 PM Martin Schiller wrote: > > No, they aren't independent. The carrier can only be up if the device / > interface is UP. And as far as I can see a NETDEV_CHANGE event will also > only be generated on interfaces that are UP. > > So you can be sure, that if there is a N

Re: [PATCH net-next] net: page_pool: Add page_pool_put_page_bulk() to page_pool.rst

2020-11-23 Thread Lorenzo Bianconi
> On Fri, Nov 20, 2020 at 11:19:34PM +0100, Lorenzo Bianconi wrote: > > Introduce page_pool_put_page_bulk() entry into the API section of > > page_pool.rst > > > > Signed-off-by: Lorenzo Bianconi > > --- > > Documentation/networking/page_pool.rst | 8 > > 1 file changed, 8 insertions(+)

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Martin Schiller
On 2020-11-23 09:31, Xie He wrote: On Sun, Nov 22, 2020 at 10:55 PM Martin Schiller wrote: No, they aren't independent. The carrier can only be up if the device / interface is UP. And as far as I can see a NETDEV_CHANGE event will also only be generated on interfaces that are UP. So you ca

[PATCH v4] dt-bindings: misc: convert fsl,qoriq-mc from txt to YAML

2020-11-23 Thread Laurentiu Tudor
From: Ionut-robert Aron Convert fsl,qoriq-mc to YAML in order to automate the verification process of dts files. In addition, update MAINTAINERS accordingly and, while at it, add some missing files. Signed-off-by: Ionut-robert Aron [laurentiu.tu...@nxp.com: update MINTAINERS, updates & fixes in

Re: [PATCH net-next 3/3] net: phy: mscc: use new PTP_MSGTYPE_* defines

2020-11-23 Thread Antoine Tenart
Hello Christian, Quoting Christian Eggers (2020-11-22 09:26:36) > Use recently introduced PTP_MSGTYPE_SYNC and PTP_MSGTYPE_DELAY_REQ > defines instead of a driver internal enumeration. > > Signed-off-by: Christian Eggers Reviewed-by: Antoine Tenart Thanks! Antoine > Cc: Quentin Schulz > Cc:

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-23 Thread Xin Long
On Sat, Nov 21, 2020 at 12:10 AM Alexander Duyck wrote: > > On Fri, Nov 20, 2020 at 2:23 AM Xin Long wrote: > > > > On Fri, Nov 20, 2020 at 1:24 AM Alexander Duyck > > wrote: > > > > > > On Wed, Nov 18, 2020 at 9:53 PM Xin Long wrote: > > > > > > > > On Thu, Nov 19, 2020 at 4:35 AM Alexander Du

[PATCH net-next v2 0/2] Add support for DSFP transceiver type

2020-11-23 Thread Moshe Shemesh
Add support for new cable module type DSFP (Dual Small Form-Factor Pluggable transceiver). DSFP EEPROM memory layout is compatible with CMIS 4.0 spec. Add CMIS 4.0 module type to UAPI and implement DSFP EEPROM dump in mlx5. Change log: v1 -> v2 - Added comments on accessing only the mandatory part

[PATCH net-next v2 2/2] net/mlx5e: Add DSFP EEPROM dump support to ethtool

2020-11-23 Thread Moshe Shemesh
From: Vladyslav Tarasiuk DSFP is a new cable module type, which EEPROM uses memory layout described in CMIS 4.0 document. Use corresponding standard value for userspace ethtool to distinguish DSFP's layout from older standards. Add DSFP module ID in accordance to SFF-8024. DSFP module memory ca

[PATCH net-next v2 1/2] ethtool: Add CMIS 4.0 module type to UAPI

2020-11-23 Thread Moshe Shemesh
From: Vladyslav Tarasiuk CMIS 4.0 document describes a universal EEPROM memory layout, which is used for some modules such as DSFP, OSFP and QSFP-DD modules. In order to distinguish them in userspace from existing standards, add corresponding values. CMIS 4.0 EERPOM memory includes mandatory and

RE: [PATCH v15 0/9] Enable ptp_kvm for arm/arm64

2020-11-23 Thread Jianyong Wu
Hi, Ping ... Any comments? > -Original Message- > From: Jianyong Wu > Sent: Wednesday, November 11, 2020 2:22 PM > To: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org; > t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com; > m...@kernel.org; richardc

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Xie He
On Mon, Nov 23, 2020 at 1:00 AM Martin Schiller wrote: > > AFAIK the carrier can't be up before the device is up. Therefore, there > will be a NETDEV_CHANGE event after the NETDEV_UP event. > > This is what I can see in my tests (with the HDLC interface). > > Is the behaviour different for e.g. la

Re: [PATCH] dpaa2-eth: Fix compile error due to missing devlink support

2020-11-23 Thread Ioana Ciornei
Hi Ezequiel, Thanks a lot for the fix, I overlooked this when adding devlink support. On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote: > The dpaa2 driver depends on devlink, so it should select > NET_DEVLINK in order to fix compile errors, such as: > > drivers/net/ethernet/frees

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-11-23 Thread Jiri Pirko
Thu, Nov 19, 2020 at 09:38:34PM CET, edwin.p...@broadcom.com wrote: >On Sat, Oct 10, 2020 at 3:54 PM Ido Schimmel wrote: > >> Add 'ETHTOOL_A_LINKMODES_LANES' attribute and expand 'struct >> ethtool_link_settings' with lanes field in order to implement a new >> lanes-selector that will enable the u

Re: [PATCH] libbpf: add support for canceling cached_cons advance

2020-11-23 Thread Magnus Karlsson
On Sun, Nov 22, 2020 at 2:21 PM Li RongQing wrote: > > It is possible to fail receiving packets after calling > xsk_ring_cons__peek, at this condition, cached_cons has > been advanced, should be cancelled. Thanks RongQing, I have needed this myself in various situations, so I think we should add

RE: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-11-23 Thread Danielle Ratson
> -Original Message- > From: Michal Kubecek > Sent: Thursday, October 22, 2020 7:28 PM > To: Danielle Ratson > Cc: Jiri Pirko ; Andrew Lunn ; Jakub > Kicinski ; Ido Schimmel > ; netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko > ; f.faine...@gmail.com; mlxsw > ; Ido Schimmel ;

BUG: receive list entry not found for dev vcan0, id 001, mask C00007FF

2020-11-23 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b9ad3e9f bonding: wait for sysfs kobject destruction befor.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=1195c5cd50 kernel config: https://syzkaller.appspot.com/x/.config?x=330f3436df12fd44 dashboar

inconsistent lock state in io_file_data_ref_zero

2020-11-23 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:27bba9c5 Merge tag 'scsi-fixes' of git://git.kernel.org/pu.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11041f1e50 kernel config: https://syzkaller.appspot.com/x/.config?x=330f3436df12fd44 das

general protection fault in ieee80211_subif_start_xmit

2020-11-23 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a349e4c6 Merge tag 'xfs-5.10-fixes-7' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1427b22550 kernel config: https://syzkaller.appspot.com/x/.config?x=330f3436df12fd44 das

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Xie He
On Mon, Nov 23, 2020 at 1:36 AM Xie He wrote: > > Some drivers don't support carrier status and will never change it. > Their carrier status will always be UP. There will not be a > NETDEV_CHANGE event. > > lapbether doesn't change carrier status. I also have my own virtual > HDLC WAN driver (for

Re: [PATCH] net: mlx5e: fix fs_tcp.c build when IPV6 is not enabled

2020-11-23 Thread Tariq Toukan
On 11/22/2020 11:12 PM, Randy Dunlap wrote: Fix build when CONFIG_IPV6 is not enabled by making a function be built conditionally. Fixes these build errors and warnings: ../drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c: In function 'accel_fs_tcp_set_ipv6_flow': ../include/net/so

Re: [PATCH 1/1] xdp: compact the function xsk_map_inc

2020-11-23 Thread Magnus Karlsson
On Sun, Nov 22, 2020 at 10:07 AM Zhu Yanjun wrote: > > From: Zhu Yanjun > > The function xsk_map_inc always returns zero. As such, changing the > return type to void and removing the test code. > > Signed-off-by: Zhu Yanjun > Signed-off-by: Zhu Yanjun > --- > net/xdp/xsk.c|1 - > net/x

[PATCH net-next v2] net/nfc/nci: Support NCI 2.x initial sequence

2020-11-23 Thread Bongsu Jeon
implement the NCI 2.x initial sequence to support NCI 2.x NFCC. Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed. If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work. In NCI 1.0, Initial sequence and payloads are as below: (DH) (NFCC) | -- COR

Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-23 Thread Jiri Pirko
Mon, Nov 23, 2020 at 03:49:06AM CET, gcher...@marvell.com wrote: > > >> -Original Message- >> From: Jiri Pirko >> Sent: Saturday, November 21, 2020 7:44 PM >> To: George Cherian >> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; >> k...@kernel.org; da...@davemloft.net; Sunil Kov

Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-23 Thread George Cherian
Hi Jiri, > -Original Message- > From: Jiri Pirko > Sent: Monday, November 23, 2020 3:52 PM > To: George Cherian > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > k...@kernel.org; da...@davemloft.net; Sunil Kovvuri Goutham > ; Linu Cherian ; > Geethasowjanya Akula ; masahi...@

[PATCH v2] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-11-23 Thread Amit Pundir
Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error message in ath10k_qmi_host_cap_send_sync(), but we can still bring up WiFi services successfully on AOSP if we ignore it. We suspect either the host cap is not implemented or there m

Re: Is test_offload.py supposed to work?

2020-11-23 Thread Toke Høiland-Jørgensen
Jakub Kicinski writes: > On Fri, 20 Nov 2020 16:46:51 +0100 Toke Høiland-Jørgensen wrote: >> Hi Jakub and Jiri >> >> I am investigating an error with XDP offload mode, and figured I'd run >> 'test_offload.py' from selftests. However, I'm unable to get it to run >> successfully; am I missing some

Re: Is test_offload.py supposed to work?

2020-11-23 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Fri, Nov 20, 2020 at 7:49 AM Toke Høiland-Jørgensen > wrote: >> >> Hi Jakub and Jiri >> >> I am investigating an error with XDP offload mode, and figured I'd run >> 'test_offload.py' from selftests. However, I'm unable to get it to run >> successfully; am I missing

Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip

2020-11-23 Thread Jiaxun Yang
Hi Lizhi, You didn't send the patch to any mail list, is this intentional? 在 2020/11/23 18:03, lizhi01 写道: Add gmac driver to support LS7A bridge chip. Signed-off-by: lizhi01 --- arch/mips/configs/loongson3_defconfig | 4 +- drivers/net/ethernet/stmicro/stmmac/Kconfig

[PATCH][next] net: hns3: fix spelling mistake "memroy" -> "memory"

2020-11-23 Thread Colin King
From: Colin Ian King There are spelling mistakes in two dev_err messages. Fix them. Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletion

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Martin Schiller
On 2020-11-23 11:08, Xie He wrote: On Mon, Nov 23, 2020 at 1:36 AM Xie He wrote: Some drivers don't support carrier status and will never change it. Their carrier status will always be UP. There will not be a NETDEV_CHANGE event. Well, one could argue that we would have to repair these drive

Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp.

2020-11-23 Thread Marc Zyngier
On 2020-11-11 06:22, Jianyong Wu wrote: ptp_kvm will get this service through SMCC call. The service offers wall time and cycle count of host to guest. The caller must specify whether they want the host cycle count or the difference between host cycle count and cntvoff. Signed-off-by: Jianyong W

Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

2020-11-23 Thread Marc Zyngier
On 2020-11-11 06:22, Jianyong Wu wrote: Currently, there is no mechanism to keep time sync between guest and host in arm/arm64 virtualization environment. Time in guest will drift compared with host after boot up as they may both use third party time sources to correct their time respectively.

Re: [PATCH v15 8/9] doc: add ptp_kvm introduction for arm64 support

2020-11-23 Thread Marc Zyngier
On 2020-11-11 06:22, Jianyong Wu wrote: PTP_KVM implementation depends on hypercall using SMCCC. So we introduce a new SMCCC service ID. This doc explains how does the ID define and how does PTP_KVM works on arm/arm64. Signed-off-by: Jianyong Wu --- Documentation/virt/kvm/api.rst | 9

RE: [PATCH] libbpf: add support for canceling cached_cons advance

2020-11-23 Thread Li,Rongqing
> -Original Message- > From: Magnus Karlsson [mailto:magnus.karls...@gmail.com] > Sent: Monday, November 23, 2020 5:40 PM > To: Li,Rongqing > Cc: Network Development ; bpf > > Subject: Re: [PATCH] libbpf: add support for canceling cached_cons advance > > On Sun, Nov 22, 2020 at 2:21 PM

Re: netconsole deadlock with virtnet

2020-11-23 Thread Leon Romanovsky
On Wed, Nov 18, 2020 at 09:12:57AM -0500, Steven Rostedt wrote: > > [ Adding netdev as perhaps someone there knows ] > > On Wed, 18 Nov 2020 12:09:59 +0800 > Jason Wang wrote: > > > > This CPU0 lock(_xmit_ETHER#2) -> hard IRQ -> lock(console_owner) is > > > basically > > > soft IRQ -> lock(_xmit

[arm64] kernel BUG at kernel/seccomp.c:1309!

2020-11-23 Thread Naresh Kamboju
While booting arm64 kernel the following kernel BUG noticed on several arm64 devices running linux next 20201123 tag kernel. $ git log --oneline next-20201120..next-20201123 -- kernel/seccomp.c 5c5c5fa055ea Merge remote-tracking branch 'seccomp/for-next/seccomp' bce6a8cba7bf Merge bra

Re: [PATCH net-next v4 2/5] net/lapb: support netdev events

2020-11-23 Thread Xie He
On Mon, Nov 23, 2020 at 2:38 AM Martin Schiller wrote: > > Well, one could argue that we would have to repair these drivers, but I > don't think that will get us anywhere. Yeah... One problem I see with the Linux project is the lack of docs/specs. Often we don't know what is right and what is wro

Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-23 Thread Jiri Pirko
Mon, Nov 23, 2020 at 11:28:28AM CET, gcher...@marvell.com wrote: >Hi Jiri, > >> -Original Message- >> From: Jiri Pirko >> Sent: Monday, November 23, 2020 3:52 PM >> To: George Cherian >> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; >> k...@kernel.org; da...@davemloft.net; Sun

Re: [PATCH 0/3] Bluetooth: Power down controller when suspending

2020-11-23 Thread Marcel Holtmann
Hi Abhishek, > This patch series adds support for a quirk that will power down the > Bluetooth controller when suspending and power it back up when resuming. > > On Marvell SDIO Bluetooth controllers (SD8897 and SD8997), we are seeing > a large number of suspend failures with the following log me

Re: [PATCH] Bluetooth: sco: Fix crash when using BT_SNDMTU/BT_RCVMTU option

2020-11-23 Thread Marcel Holtmann
Hi Wei, > This commit add the invalid check for connected socket, without it will > causes the following crash due to sco_pi(sk)->conn being NULL: > > KASAN: null-ptr-deref in range [0x0050-0x0057] > CPU: 3 PID: 4284 Comm: test_sco Not tainted 5.10.0-rc3+ #1 > Hardware nam

Re: [PATCH net-next 10/10] mptcp: refine MPTCP-level ack scheduling

2020-11-23 Thread Eric Dumazet
On 11/19/20 8:46 PM, Mat Martineau wrote: > From: Paolo Abeni > > Send timely MPTCP-level ack is somewhat difficult when > the insertion into the msk receive level is performed > by the worker. > > It needs TCP-level dup-ack to notify the MPTCP-level > ack_seq increase, as both the TCP-level

Re: [PATCH net] Bluetooth: Fix potential null pointer dereference in create_le_conn_complete

2020-11-23 Thread Marcel Holtmann
Hi Wang, > The pointer 'conn' may be null. Before being used by > hci_connect_le_scan_cleanup(), The pointer 'conn' must be > checked whether it is null. > > Fixes: 28a667c9c279 ("Bluetooth: advertisement handling in new connect > procedure") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai

BUG: receive list entry not found for dev vxcan1, id 002, mask C00007FF

2020-11-23 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c2e7554e Merge tag 'gfs2-v5.10-rc4-fixes' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=117f03ba50 kernel config: https://syzkaller.appspot.com/x/.config?x=75292221eb79ace2 das

Re: [PATCH 1/2] bluetooth: hci_event: consolidate error paths in hci_phy_link_complete_evt()

2020-11-23 Thread Marcel Holtmann
Hi Sergey, >>> hci_phy_link_complete_evt() has several duplicate error paths -- consolidate >>> them, using the *goto* statements. >>> >>> Signed-off-by: Sergey Shtylyov >>> >>> --- >>> net/bluetooth/hci_event.c | 16 ++-- >>> 1 file changed, 6 insertions(+), 10 deletions(-) >> pat

Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp.

2020-11-23 Thread Marc Zyngier
On 2020-11-23 10:44, Marc Zyngier wrote: On 2020-11-11 06:22, Jianyong Wu wrote: ptp_kvm will get this service through SMCC call. The service offers wall time and cycle count of host to guest. The caller must specify whether they want the host cycle count or the difference between host cycle cou

Re: [PATCHv2 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Zhu Yanjun
On Mon, Nov 23, 2020 at 8:05 PM wrote: > > From: Zhu Yanjun > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > always returns zero. As such, replacing this function with bpf_map_inc > and removing the test code. > > Signed-off-by: Zhu Yanjun > --- > net/xdp/xsk.c| 1 -

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Nikolay Aleksandrov
On 23/11/2020 13:14, Horatiu Vultur wrote: > Extend MRP to support LC mode(link check) for the interconnect port. > This applies only to the interconnect ring. > > Opposite to RC mode(ring check) the LC mode is using CFM frames to > detect when the link goes up or down and based on that the usersp

Re: [PATCHv2 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Magnus Karlsson
On Mon, Nov 23, 2020 at 1:11 PM Zhu Yanjun wrote: > > On Mon, Nov 23, 2020 at 8:05 PM wrote: > > > > From: Zhu Yanjun > > > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > > always returns zero. As such, replacing this function with bpf_map_inc > > and removing the test code.

Re: [PATCH bpf-next v2 0/5] selftests/bpf: xsk selftests

2020-11-23 Thread Björn Töpel
On 2020-11-21 01:31, Yonghong Song wrote: On 11/20/20 5:00 AM, Weqaar Janjua wrote: This patch set adds AF_XDP selftests based on veth to selftests/bpf. # Topology: # - # --- #   _ | Process | _ #  /  ---  \ # /  

Re: [PATCH bpf] xsk: fix incorrect netdev reference count

2020-11-23 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Fri, 20 Nov 2020 16:14:43 +0100 you wrote: > From: Marek Majtyka > > Fix incorrect netdev reference count in xsk_bind operation. Incorrect > reference count of the device appears when a user calls bind with the > XDP_ZEROCOPY

Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Gustavo A. R. Silva
On Sun, Nov 22, 2020 at 11:53:55AM -0800, James Bottomley wrote: > On Sun, 2020-11-22 at 11:22 -0800, Joe Perches wrote: > > On Sun, 2020-11-22 at 11:12 -0800, James Bottomley wrote: > > > On Sun, 2020-11-22 at 10:25 -0800, Joe Perches wrote: > > > > On Sun, 2020-11-22 at 10:21 -0800, James Bottoml

[PATCH bpf] net, xsk: Avoid taking multiple skbuff references

2020-11-23 Thread Björn Töpel
From: Björn Töpel Commit 642e450b6b59 ("xsk: Do not discard packet when NETDEV_TX_BUSY") addressed the problem that packets were discarded from the Tx AF_XDP ring, when the driver returned NETDEV_TX_BUSY. Part of the fix was bumping the skbuff reference count, so that the buffer would not be free

[PATCHv6 iproute2-next 0/5] iproute2: add libbpf support

2020-11-23 Thread Hangbin Liu
This series converts iproute2 to use libbpf for loading and attaching BPF programs when it is available. This means that iproute2 will correctly process BTF information and support the new-style BTF-defined maps, while keeping compatibility with the old internal map definition syntax. This is achi

[PATCHv6 iproute2-next 1/5] iproute2: add check_libbpf() and get_libbpf_version()

2020-11-23 Thread Hangbin Liu
This patch aim to add basic checking functions for later iproute2 libbpf support. First we add check_libbpf() in configure to see if we have bpf library support. By default the system libbpf will be used, but static linking against a custom libbpf version can be achieved by passing libbpf DESTDIR

[PATCHv6 iproute2-next 2/5] lib: make ipvrf able to use libbpf and fix function name conflicts

2020-11-23 Thread Hangbin Liu
There are directly calls in libbpf for bpf program load/attach. So we could just use two wrapper functions for ipvrf and convert them with libbpf support. Function bpf_prog_load() is removed as it's conflict with libbpf function name. bpf.c is moved to bpf_legacy.c for later main libbpf support i

[PATCHv6 iproute2-next 3/5] lib: add libbpf support

2020-11-23 Thread Hangbin Liu
This patch converts iproute2 to use libbpf for loading and attaching BPF programs when it is available, which is started by Toke's implementation[1]. With libbpf iproute2 could correctly process BTF information and support the new-style BTF-defined maps, while keeping compatibility with the old int

[PATCHv6 iproute2-next 5/5] examples/bpf: add bpf examples with BTF defined maps

2020-11-23 Thread Hangbin Liu
Users should try use the new BTF defined maps instead of struct bpf_elf_map defined maps. The tail call examples are not added yet as libbpf doesn't currently support declaratively populating tail call maps. Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Hangbin Liu --- examples/bpf/README

[PATCHv6 iproute2-next 4/5] examples/bpf: move struct bpf_elf_map defined maps to legacy folder

2020-11-23 Thread Hangbin Liu
Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Hangbin Liu --- examples/bpf/README| 14 +- examples/bpf/{ => legacy}/bpf_cyclic.c | 2 +- examples/bpf/{ => legacy}/bpf_graft.c | 2 +- examples/bpf/{ => legacy}/bpf_map_in_map.c | 2 +- examples/

Re: [PATCH ipsec-next v5] xfrm: redact SA secret with lockdown confidentiality

2020-11-23 Thread Steffen Klassert
On Tue, Nov 17, 2020 at 05:47:23PM +0100, Antony Antony wrote: > redact XFRM SA secret in the netlink response to xfrm_get_sa() > or dumpall sa. > Enable lockdown, confidentiality mode, at boot or at run time. > > e.g. when enabled: > cat /sys/kernel/security/lockdown > none integrity [confidentia

Re: ESN, seqhi and out-of-order calls to advance()

2020-11-23 Thread Steffen Klassert
Hi, I've Cced netdev, maybe other people have an opinion on this too. On Thu, Nov 19, 2020 at 01:39:29PM -0800, Nic Dade wrote: > I've been investigating a problem which happens when I use IPsec > (strongswan in userspace), ESN, the default anti-replay window (32 > seqnums), on a multi-core CPU.

Re: [PATCH bpf-next v2 0/5] selftests/bpf: xsk selftests

2020-11-23 Thread Björn Töpel
On 2020-11-23 13:20, Björn Töpel wrote: On 2020-11-21 01:31, Yonghong Song wrote: On 11/20/20 5:00 AM, Weqaar Janjua wrote: This patch set adds AF_XDP selftests based on veth to selftests/bpf. # Topology: # - # --- #   _ | Process | _ #

Re: [PATCH net-next V7] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-23 Thread Hideaki Yoshifuji
Hi, 2020年11月20日(金) 18:28 Dmytro Shytyi : > > Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly > generated hostID or stable privacy + privacy extensions). > The main problem is that SLAAC RA or PD allocates a /64 by the Wireless > carrier 4G, 5G to a mobile hotspot, however

Re: [PATCH bpf-next v7 00/34] bpf: switch to memcg-based memory accounting

2020-11-23 Thread Daniel Borkmann
On 11/19/20 6:37 PM, Roman Gushchin wrote: Currently bpf is using the memlock rlimit for the memory accounting. This approach has its downsides and over time has created a significant amount of problems: 1) The limit is per-user, but because most bpf operations are performed as root, the lim

Re: [PATCH bpf-next v3 00/10] Introduce preferred busy-polling

2020-11-23 Thread Björn Töpel
On Thu, 19 Nov 2020 at 09:30, Björn Töpel wrote: > > This series introduces three new features: > > 1. A new "heavy traffic" busy-polling variant that works in concert >with the existing napi_defer_hard_irqs and gro_flush_timeout knobs. > > 2. A new socket option that let a user change the bus

Re: [PATCHv2 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Zhu Yanjun
On Mon, Nov 23, 2020 at 8:19 PM Magnus Karlsson wrote: > > On Mon, Nov 23, 2020 at 1:11 PM Zhu Yanjun wrote: > > > > On Mon, Nov 23, 2020 at 8:05 PM wrote: > > > > > > From: Zhu Yanjun > > > > > > The function xsk_map_inc is a simple wrapper of bpf_map_inc and > > > always returns zero. As such

Re: [net v3] net/tls: missing received data after fast remote close

2020-11-23 Thread Vadim Fedorenko
On 20.11.2020 18:26, Jakub Kicinski wrote: On Thu, 19 Nov 2020 18:59:48 +0300 Vadim Fedorenko wrote: In case when tcp socket received FIN after some data and the parser haven't started before reading data caller will receive an empty buffer. This behavior differs from plain TCP socket and leads

[PATCH net-next V2] MAINTAINERS: Update page pool entry

2020-11-23 Thread Jesper Dangaard Brouer
Add some file F: matches that is related to page_pool. Acked-by: Ilias Apalodimas Signed-off-by: Jesper Dangaard Brouer --- MAINTAINERS |2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f827f504251b..a607ff2156dd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [arm64] kernel BUG at kernel/seccomp.c:1309!

2020-11-23 Thread Arnd Bergmann
On Mon, Nov 23, 2020 at 12:15 PM Naresh Kamboju wrote: > > While booting arm64 kernel the following kernel BUG noticed on several arm64 > devices running linux next 20201123 tag kernel. > > > $ git log --oneline next-20201120..next-20201123 -- kernel/seccomp.c > 5c5c5fa055ea

Re: [PATCHv2 1/1] xdp: remove the function xsk_map_inc

2020-11-23 Thread Magnus Karlsson
On Mon, Nov 23, 2020 at 2:37 PM Zhu Yanjun wrote: > > On Mon, Nov 23, 2020 at 8:19 PM Magnus Karlsson > wrote: > > > > On Mon, Nov 23, 2020 at 1:11 PM Zhu Yanjun wrote: > > > > > > On Mon, Nov 23, 2020 at 8:05 PM wrote: > > > > > > > > From: Zhu Yanjun > > > > > > > > The function xsk_map_inc

[RFC 00/18] net: iosm: PCIe Driver for Intel M.2 Modem

2020-11-23 Thread M Chetan Kumar
The IOSM (IPC over Shared Memory) driver is a PCIe host driver implemented for linux or chrome platform for data exchange over PCIe interface between Host platform & Intel M.2 Modem. The driver exposes interface conforming to the MBIM protocol [1]. Any front end application ( eg: Modem Manager) cou

[RFC 01/18] net: iosm: entry point

2020-11-23 Thread M Chetan Kumar
1) Register IOSM driver with kernel to manage Intel WWAN PCIe device(PCI_VENDOR_ID_INTEL, INTEL_CP_DEVICE_7560_ID). 2) Exposes the EP PCIe device capability to Host PCIe core. 3) Initializes PCIe EP configuration and defines PCIe driver probe, remove and power management OPS. 4) Allocate and

[RFC 02/18] net: iosm: irq handling

2020-11-23 Thread M Chetan Kumar
1) Request interrupt vector, frees allocated resource. 2) Registers IRQ handler. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_irq.c | 95 drivers/net/wwan/iosm/iosm_ipc_irq.h | 35 + 2 files changed, 130 insertions(+) create m

[RFC 03/18] net: iosm: mmio scratchpad

2020-11-23 Thread M Chetan Kumar
1) Initializes the Scratchpad region for Host-Device communication. 2) Exposes device capabilities like chip info and device execution stages. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_mmio.c | 222 ++ drivers/net/wwan/iosm/iosm_ipc_mmio.

[RFC 04/18] net: iosm: shared memory IPC interface

2020-11-23 Thread M Chetan Kumar
1) Initializes shared memory for host-device communication. 2) Allocate resources required for control & data operations. 3) Transfers the Device IRQ to IPC execution thread. 4) Defines the timer cbs for async events. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_imem.c | 1466

[RFC 06/18] net: iosm: channel configuration

2020-11-23 Thread M Chetan Kumar
Defines pipes & channel configurations like channel type, pipe mappings, No. of transfer descriptors and transfer buffer size etc. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.c | 87 +++ drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.h | 57

[RFC 07/18] net: iosm: char device for FW flash & coredump

2020-11-23 Thread M Chetan Kumar
Implements a char device for flashing Modem FW image while Device is in boot rom phase and for collecting traces on modem crash. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_sio.c | 188 +++ drivers/net/wwan/iosm/iosm_ipc_sio.h | 72 ++

[RFC 09/18] net: iosm: bottom half

2020-11-23 Thread M Chetan Kumar
1) Bottom half(tasklet) for IRQ and task processing. 2) Tasks are processed asynchronous and synchronously. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_task_queue.c | 258 drivers/net/wwan/iosm/iosm_ipc_task_queue.h | 46 + 2 files changed,

[RFC 08/18] net: iosm: MBIM control device

2020-11-23 Thread M Chetan Kumar
Implements a char device for MBIM protocol communication & provides a simple IOCTL for max transfer buffer size configuration. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_mbim.c | 205 ++ drivers/net/wwan/iosm/iosm_ipc_mbim.h | 24 2 fil

[RFC 13/18] net: iosm: shared memory protocol

2020-11-23 Thread M Chetan Kumar
1) Defines messaging protocol for handling Transfer Descriptor in both UL/DL direction. 2) Ring buffer management. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_protocol.c | 287 ++ drivers/net/wwan/iosm/iosm_ipc_protocol.h | 219

[RFC 11/18] net: iosm: encode or decode datagram

2020-11-23 Thread M Chetan Kumar
1) Encode UL packet into datagram. 2) Decode DL datagram and route it to network layer. 3) Supports credit based flow control. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 902 + drivers/net/wwan/iosm/iosm_ipc_mux_codec.h | 194 ++

[RFC 12/18] net: iosm: power management

2020-11-23 Thread M Chetan Kumar
Implements state machine to handle host & device sleep. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_pm.c | 334 drivers/net/wwan/iosm/iosm_ipc_pm.h | 216 +++ 2 files changed, 550 insertions(+) create mode 100644 driv

[RFC 05/18] net: iosm: shared memory I/O operations

2020-11-23 Thread M Chetan Kumar
1) Binds logical channel between host-device for communication. 2) Implements device specific(Char/Net) IO operations. 3) Inject primary BootLoader FW image to modem. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_imem_ops.c | 779 ++ drivers/net/wwa

[RFC 15/18] net: iosm: uevent support

2020-11-23 Thread M Chetan Kumar
Report modem status via uevent. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_uevent.c | 47 + drivers/net/wwan/iosm/iosm_ipc_uevent.h | 41 2 files changed, 88 insertions(+) create mode 100644 drivers/net/wwan/iosm

[RFC 14/18] net: iosm: protocol operations

2020-11-23 Thread M Chetan Kumar
1) Update UL/DL transfer descriptors in message ring. 2) Define message set for pipe/sleep protocol. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_protocol_ops.c | 563 ++ drivers/net/wwan/iosm/iosm_ipc_protocol_ops.h | 358 2 files cha

[RFC 17/18] net: iosm: readme file

2020-11-23 Thread M Chetan Kumar
Documents IOSM Driver interface usage. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/README | 126 +++ 1 file changed, 126 insertions(+) create mode 100644 drivers/net/wwan/iosm/README diff --git a/drivers/net/wwan/iosm/README b/drivers/net/wwa

[RFC 10/18] net: iosm: multiplex IP sessions

2020-11-23 Thread M Chetan Kumar
Establish IP session between host-device & session management. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_mux.c | 455 +++ drivers/net/wwan/iosm/iosm_ipc_mux.h | 344 ++ 2 files changed, 799 insertions(+) create mode

[RFC 18/18] net: iosm: infrastructure

2020-11-23 Thread M Chetan Kumar
1) Kconfig & Makefile changes for IOSM Driver compilation. 2) Modified driver/net Kconfig & Makefile for driver inclusion. 3) Modified MAINTAINER file for IOSM Driver addition. Signed-off-by: M Chetan Kumar --- MAINTAINERS| 7 +++ drivers/net/Kconfig| 1 + d

[RFC 16/18] net: iosm: net driver

2020-11-23 Thread M Chetan Kumar
1) Create net device for data/IP communication. 2) Bind VLAN ID to mux IP session. 3) Implement net device operations. Signed-off-by: M Chetan Kumar --- drivers/net/wwan/iosm/iosm_ipc_wwan.c | 674 ++ drivers/net/wwan/iosm/iosm_ipc_wwan.h | 72 2 files chang

Re: [PATCH bpf] net, xsk: Avoid taking multiple skbuff references

2020-11-23 Thread Daniel Borkmann
On 11/23/20 2:12 PM, Björn Töpel wrote: From: Björn Töpel Commit 642e450b6b59 ("xsk: Do not discard packet when NETDEV_TX_BUSY") addressed the problem that packets were discarded from the Tx AF_XDP ring, when the driver returned NETDEV_TX_BUSY. Part of the fix was bumping the skbuff reference c

Re: [PATCH 0/3] xsk: fix for xsk_poll writeable

2020-11-23 Thread Magnus Karlsson
On Wed, Nov 18, 2020 at 9:25 AM Xuan Zhuo wrote: > > I tried to combine cq available and tx writeable, but I found it very > difficult. > Sometimes we pay attention to the status of "available" for both, but > sometimes, > we may only pay attention to one, such as tx writeable, because we can us

Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-23 Thread Miguel Ojeda
On Sun, Nov 22, 2020 at 11:54 PM Finn Thain wrote: > > We should also take into account optimisim about future improvements in > tooling. Not sure what you mean here. There is no reliable way to guess what the intention was with a missing fallthrough, even if you parsed whitespace and indentation

Re: [PATCH bpf] net, xsk: Avoid taking multiple skbuff references

2020-11-23 Thread Björn Töpel
On 2020-11-23 14:53, Daniel Borkmann wrote: [...] Hm, but this way free_on_busy, even though constant, cannot be optimized away? Can't you just move the dev_xmit_complete() check out into dev_direct_xmit() instead? That way you can just drop the bool, and the below dev_direct_xmit() should p

Re: [PATCH 1/3] xsk: replace datagram_poll by sock_poll_wait

2020-11-23 Thread Magnus Karlsson
On Wed, Nov 18, 2020 at 9:26 AM Xuan Zhuo wrote: > > datagram_poll will judge the current socket status (EPOLLIN, EPOLLOUT) > based on the traditional socket information (eg: sk_wmem_alloc), but > this does not apply to xsk. So this patch uses sock_poll_wait instead of > datagram_poll, and the mas

[PATCH net] netdevice.h: Fix unintentional disable of ALL_FOR_ALL features on upper device

2020-11-23 Thread Tariq Toukan
Calling netdev_increment_features() on upper/master device from netdev_add_tso_features() implies unintentional clearance of ALL_FOR_ALL features supported by all slaves. Fix it by passing ALL_FOR_ALL in addition to ALL_TSO. Fixes: b0ce3508b25e ("bonding: allow TSO being set on bonding master") S

  1   2   3   4   >