Re: [EXT] Re: [PATCH v3] aquantia: Remove the build_skb path

2020-11-20 Thread Igor Russkikh
On 20/11/2020 1:49 am, Maciej Fijalkowski wrote: > External Email > > -- > On Thu, Nov 19, 2020 at 10:34:48PM +, Ramsay, Lincoln wrote: >> When performing IPv6 forwarding, there is an expectation that SKBs >> will have some

[PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-20 Thread Wang Hai
kmemleak report a memory leak as follows: BUG: memory leak unreferenced object 0x8880759ea000 (size 256): comm "syz-executor.3", pid 6484, jiffies 4297476946 (age 48.546s) hex dump (first 32 bytes): 00 00 00 00 01 00 00 00 08 a0 9e 75 80 88 ff ff ...u 08 a0 9e 75 80 88 ff ff 00 00

Re: [PATCH bpf-next V6 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx

2020-11-20 Thread Jesper Dangaard Brouer
On Wed, 18 Nov 2020 16:29:35 +0100 Jesper Dangaard Brouer wrote: > BPF end-user on Cilium slack-channel (Carlo Carraro) wants to use > bpf_fib_lookup for doing MTU-check, but *prior* to extending packet size, > by adjusting fib_params 'tot_len' with the packet length plus the > expected encap siz

Re: [PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-20 Thread wanghai (M)
在 2020/11/20 2:22, Julian Anastasov 写道: Hello, On Thu, 19 Nov 2020, Wang Hai wrote: kmemleak report a memory leak as follows: BUG: memory leak unreferenced object 0x8880759ea000 (size 256): comm "syz-executor.3", pid 6484, jiffies 4297476946 (age 48.546s) hex dump (first 32 byte

[PATCH net-next v3 0/3] net: ptp: introduce common defines for PTP message types

2020-11-20 Thread Christian Eggers
This series introduces commen defines for PTP event messages. Driver internal defines are removed and some uses of magic numbers are replaced by the new defines. Changes v2 --> v3 -- - extend commit description for ptp_ines (Jacob Keller) Changes v1 --> v2 -- - use

[PATCH net-next v3 1/3] net: ptp: introduce common defines for PTP message types

2020-11-20 Thread Christian Eggers
Using PTP wide defines will obsolete different driver internal defines and uses of magic numbers. Signed-off-by: Christian Eggers Cc: Kurt Kanzenbach --- include/linux/ptp_classify.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/linux/ptp_classify.h b/include

[PATCH net-next v3 2/3] dpaa2-eth: use new PTP_MSGTYPE_* define(s)

2020-11-20 Thread Christian Eggers
Remove usage of magic numbers. Signed-off-by: Christian Eggers Cc: Ioana Ciornei Cc: Ioana Radulescu Cc: Yangbo Lu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/d

[PATCH net-next v3 3/3] ptp: ptp_ines: use new PTP_MSGTYPE_* define(s)

2020-11-20 Thread Christian Eggers
Remove driver internal defines for this. Masking msgtype with 0xf is already done within ptp_get_msgtype(). Signed-off-by: Christian Eggers Cc: Richard Cochran Cc: Kurt Kanzenbach --- drivers/ptp/ptp_ines.c | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git

Re: [PATCH net-next] MAINTAINERS: Update XDP and AF_XDP entries

2020-11-20 Thread Jesper Dangaard Brouer
On Thu, 19 Nov 2020 14:16:20 -0800 Joe Perches wrote: > On Thu, 2020-11-19 at 21:50 +0100, Jesper Dangaard Brouer wrote: > > On Thu, 19 Nov 2020 10:02:10 -0800 > > Jakub Kicinski wrote: > > > > > On Thu, 19 Nov 2020 18:26:40 +0100 Jesper Dangaard Brouer wrote: > > > > Getting too many false

[PATCH net-next V3] MAINTAINERS: Update XDP and AF_XDP entries

2020-11-20 Thread Jesper Dangaard Brouer
Getting too many false positive matches with current use of the content regex K: and file regex N: patterns. This patch drops file match N: and makes K: more restricted. Some more normal F: file wildcards are added. Notice that AF_XDP forgot to some F: files that is also updated in this patch. S

Kernel warning "TX on unused queue" for iwlwifi on 7260 with kernel 5.10-rc2

2020-11-20 Thread Gonsolo
Output of lspci -nn: 02:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1] (rev 73) > Guy, can you help with this one? I believe there is a bugzilla issue > for this already... I'd like to know this too. -- g

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-20 Thread Tobias Waldekranz
On Fri, Nov 20, 2020 at 01:00, Andrew Lunn wrote: >> E.g. at Westermo we make switches with M12/M12X connectors [1] that >> sometimes have a 1G PHY behind a 2-pair M12 connector (for complicated >> legacy reasons). In such cases we have to remove 1000-HD/FD from the >> advertised link modes. Being

[PATCH net 4/4] s390/qeth: fix tear down of async TX buffers

2020-11-20 Thread Julian Wiedmann
When qeth_iqd_tx_complete() detects that a TX buffer requires additional async completion via QAOB, it might fail to replace the queue entry's metadata (and ends up triggering recovery). Assume now that the device gets torn down, overruling the recovery. If the QAOB notification then arrives befor

[PATCH net 2/4] s390/qeth: make af_iucv TX notification call more robust

2020-11-20 Thread Julian Wiedmann
Calling into socket code is ugly already, at least check whether we are dealing with the expected sk_family. Only looking at skb->protocol is bound to cause troubles (consider eg. af_packet). Fixes: b333293058aa ("qeth: add support for af_iucv HiperSockets transport") Signed-off-by: Julian Wiedman

[PATCH net 1/4] s390/qeth: Remove pnso workaround

2020-11-20 Thread Julian Wiedmann
From: Alexandra Winter Remove workaround that supported early hardware implementations of PNSO OC3. Rely on the 'enarf' feature bit instead. Fixes: fa115adff2c1 ("s390/qeth: Detect PNSO OC3 capability") Signed-off-by: Alexandra Winter Reviewed-by: Julian Wiedmann [jwi: use logical instead of b

[PATCH net 3/4] s390/qeth: fix af_iucv notification race

2020-11-20 Thread Julian Wiedmann
The two expected notification sequences are 1. TX_NOTIFY_PENDING with a subsequent TX_NOTIFY_DELAYED_*, when our TX completion code first observed the pending TX and the QAOB then completes at a later time; or 2. TX_NOTIFY_OK, when qeth_qdio_handle_aob() picked up the QAOB completion befor

[PATCH net 0/4] s390/qeth: fixes 2020-11-20

2020-11-20 Thread Julian Wiedmann
Hi Jakub, please apply the following patch series to netdev's net tree. This brings several fixes for qeth's af_iucv-specific code paths. Also one fix by Alexandra for the recently added BR_LEARNING_SYNC support. We want to trust the feature indication bit, so that HW can mask it out if there's

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-20 Thread Tobias Waldekranz
On Fri, Nov 20, 2020 at 00:40, Russell King - ARM Linux admin wrote: > I think you're advocating calling the fiber interface "SGMII", which > would be totally wrong. > > SGMII is a Cisco modification of 802.3 1000base-X to allow 10M and 100M > speeds to be used over a single serdes lane in each d

Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

2020-11-20 Thread Sergei Shtylyov
Hello! On 19.11.2020 20:24, Yves-Alexis Perez wrote: Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic or DNS resolution using the DNS

[PATCH net-next 2/5] net: hns3: add support for mapping device memory

2020-11-20 Thread Huazhong Tan
For device who has device memory accessed through the PCI BAR4, IO descriptor push of NIC and direct WQE(Work Queue Element) of RoCE will use this device memory, so add support for mapping this device memory, and add this info to the RoCE client whose new feature needs. Signed-off-by: Huazhong Tan

[PATCH net-next 5/5] net: hns3: adds debugfs to dump more info of shaping parameters

2020-11-20 Thread Huazhong Tan
From: Yonglong Liu Adds debugfs to dump new shaping parameters: rate and flag. Signed-off-by: Yonglong Liu Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH net-next 3/5] net: hns3: add support for pf querying new interrupt resources

2020-11-20 Thread Huazhong Tan
From: Yufeng Mo For HNAE3_DEVICE_VERSION_V3, a maximum of 1281 interrupt resources are supported. To utilize these new resources, extend the corresponding field or variable to 16bit type, and remove the restriction of NIC client that only use a maximum of 65 interrupt vectors. In addition, the I/

[PATCH net-next 0/5] net: hns3: misc updates for -next

2020-11-20 Thread Huazhong Tan
This series includes some misc updates for the HNS3 ethernet driver. #1 adds support for 1280 queues #2 adds mapping for BAR45 which is needed by RoCE client. #3 extend the interrupt resources. #4 add support to query firmware's calculated shaping parameters. Huazhong Tan (1): net: hns3: add su

[PATCH net-next 4/5] net: hns3: add support to utilize the firmware calculated shaping parameters

2020-11-20 Thread Huazhong Tan
From: Yonglong Liu Since the calculation of the driver is fixed, if the number of queue or clock changed, the calculated result may be inaccurate. So for compatible and maintainable, add a new flag to tell the firmware to calculate the shaping parameters with the specified rate. Signed-off-by:

[PATCH net-next 1/5] net: hns3: add support for 1280 queues

2020-11-20 Thread Huazhong Tan
From: Yonglong Liu For DEVICE_VERSION_V1/2, there are total 1024 queues and queue sets. For DEVICE_VERSION_V3, it increases to 1280, and can be assigned to one pf, so remove the limitation of 1024. To keep compatible with DEVICE_VERSION_V1/2 and old driver version, the queue number is split into

[PATCH net-next V7] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-20 Thread Dmytro Shytyi
Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly generated hostID or stable privacy + privacy extensions). The main problem is that SLAAC RA or PD allocates a /64 by the Wireless carrier 4G, 5G to a mobile hotspot, however segmentation of the /64 via SLAAC is required so tha

[PATCH] veth: fix memleak in veth_newlink()

2020-11-20 Thread Yang Yingliang
I got a memleak report when doing fault-inject test: unreferenced object 0x88810ace9000 (size 1024): comm "ip", pid 4622, jiffies 4295457037 (age 43.378s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-20 Thread Maxime Chevallier
Hi Tobias, On Fri, 20 Nov 2020 01:11:12 +0100 Tobias Waldekranz wrote: >On Thu, Nov 19, 2020 at 23:16, Russell King - ARM Linux admin > wrote: >> On Thu, Nov 19, 2020 at 11:43:39PM +0100, Tobias Waldekranz wrote: >>> On Thu, Nov 19, 2020 at 16:24, Maxime Chevallier >>> wrote: >>> > I don'

[PATCH net-next] MAINTAINERS: Update page pool entry

2020-11-20 Thread Jesper Dangaard Brouer
Add some file F: matches that is related to page_pool. Signed-off-by: Jesper Dangaard Brouer --- MAINTAINERS |2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f827f504251b..efcdc68a03b1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13179,6 +13179,8 @@ L:

RE: [EXT] Re: [RFC, net-next] net: qos: introduce a redundancy flow action

2020-11-20 Thread Xiaoliang Yang
On 2020-11-18 3:01 Joergen Andreasen wrote: > > Hi Xiaoliang, > > I like your idea about using filter actions for FRER configuration. > > I think this is a good starting point but I think that this approach will > only allow us to configure end systems and not relay systems in > bridges/switches

[PATCH] octeontx2-af: Add support for RSS hashing based on Transport protocol field

2020-11-20 Thread George Cherian
Add support to choose RSS flow key algorithm with IPv4 transport protocol field included in hashing input data. This will be enabled by default. There-by enabling 3/5 tuple hash Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: George Cherian --- drivers/net/ethernet/marvell/octeontx2/af/mbox

Re: [EXT] Re: [RFC, net-next] net: qos: introduce a redundancy flow action

2020-11-20 Thread Vladimir Oltean
On Fri, Nov 20, 2020 at 09:39:12AM +, Xiaoliang Yang wrote: > On 2020-11-18 3:01 Joergen Andreasen wrote: > > I like your idea about using filter actions for FRER configuration. > > > > I think this is a good starting point but I think that this approach > > will only allow us to configure end

[PATCH v2] brcmfmac: expose firmware config files through modinfo

2020-11-20 Thread matthias . bgg
From: Matthias Brugger Apart from a firmware binary the chip needs a config file used by the FW. Add the config files to modinfo so that they can be read by userspace. Signed-off-by: Matthias Brugger --- Changes in v2: In comparison to first version [0] we use wildcards to enumerate the firmw

Re: [PATCH v2] brcmfmac: expose firmware config files through modinfo

2020-11-20 Thread Dmitry Osipenko
20.11.2020 12:52, matthias@kernel.org пишет: > From: Matthias Brugger > > Apart from a firmware binary the chip needs a config file used by the > FW. Add the config files to modinfo so that they can be read by > userspace. > > Signed-off-by: Matthias Brugger > > --- > > Changes in v2: > I

[PATCH net] net/af_iucv: set correct sk_protocol for child sockets

2020-11-20 Thread Julian Wiedmann
Child sockets erroneously inherit their parent's sk_type (ie. SOCK_*), instead of the PF_IUCV protocol that the parent was created with in iucv_sock_create(). We're currently not using sk->sk_protocol ourselves, so this shouldn't have much impact (except eg. getting the output in skb_dump() right)

Re: [PATCH net-next V3] MAINTAINERS: Update XDP and AF_XDP entries

2020-11-20 Thread Björn Töpel
On 2020-11-20 09:53, Jesper Dangaard Brouer wrote: Getting too many false positive matches with current use of the content regex K: and file regex N: patterns. This patch drops file match N: and makes K: more restricted. Some more normal F: file wildcards are added. Notice that AF_XDP forgot to

Re: [PATCH net-next] ip_gre: remove CRC flag from dev features in gre_gso_segment

2020-11-20 Thread Xin Long
On Fri, Nov 20, 2020 at 1:24 AM Alexander Duyck wrote: > > On Wed, Nov 18, 2020 at 9:53 PM Xin Long wrote: > > > > On Thu, Nov 19, 2020 at 4:35 AM Alexander Duyck > > wrote: > > > > > > On Mon, Nov 16, 2020 at 1:17 AM Xin Long wrote: > > > > > > > > This patch is to let it always do CRC checksu

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-20 Thread Russell King - ARM Linux admin
On Fri, Nov 20, 2020 at 10:36:01AM +0100, Maxime Chevallier wrote: > So maybe we could be a bit more generic, with something along these lines : > > ethernet-phy@0 { > ... > > mdi { > port@0 { > media = "10baseT", "100baseT", "1000baseT"; >

[PATCH net] vsock/virtio: discard packets only when socket is really closed

2020-11-20 Thread Stefano Garzarella
Starting from commit 8692cefc433f ("virtio_vsock: Fix race condition in virtio_transport_recv_pkt"), we discard packets in virtio_transport_recv_pkt() if the socket has been released. When the socket is connected, we schedule a delayed work to wait the RST packet from the other peer, also if SHUTD

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-20 Thread Tobias Waldekranz
On Fri, Nov 20, 2020 at 10:25, Russell King - ARM Linux admin wrote: > On Fri, Nov 20, 2020 at 10:36:01AM +0100, Maxime Chevallier wrote: >> So maybe we could be a bit more generic, with something along these lines : >> >> ethernet-phy@0 { >> ... >> >> mdi { >> p

Re: [PATCH v2] brcmfmac: expose firmware config files through modinfo

2020-11-20 Thread Matthias Brugger
On 20/11/2020 11:05, Dmitry Osipenko wrote: 20.11.2020 12:52, matthias@kernel.org пишет: From: Matthias Brugger Apart from a firmware binary the chip needs a config file used by the FW. Add the config files to modinfo so that they can be read by userspace. Signed-off-by: Matthias Brugg

[PATCH v8] tcp: fix race condition when creating child sockets from syncookies

2020-11-20 Thread Ricardo Dias
When the TCP stack is in SYN flood mode, the server child socket is created from the SYN cookie received in a TCP packet with the ACK flag set. The child socket is created when the server receives the first TCP packet with a valid SYN cookie from the client. Usually, this packet corresponds to the

[PATCH net-next] net: bridge: switch to net core statistics counters handling

2020-11-20 Thread Heiner Kallweit
Use netdev->tstats instead of a member of net_bridge for storing a pointer to the per-cpu counters. This allows us to use core functionality for statistics handling. Signed-off-by: Heiner Kallweit --- net/bridge/br_device.c | 31 +-- net/bridge/br_input.c | 6 +---

[PATCH net-next 0/4] dt-bindings: net: dsa: microchip: convert KSZ bindings to yaml

2020-11-20 Thread Christian Eggers
These patches are orginally from the series "net: dsa: microchip: PTP support for KSZ956x" As the the device tree conversion to yaml is not really related to the PTP patches and the original series is going to take more time than I expected, I would like to split this. Changes (original series -

[PATCH net-next 1/4] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-11-20 Thread Christian Eggers
Convert the bindings document for Microchip KSZ Series Ethernet switches from txt to yaml. Removed spi-cpha and spi-cpol flags is this should be handled by the device driver. Signed-off-by: Christian Eggers --- .../devicetree/bindings/net/dsa/ksz.txt | 125 --- .../bindings/net

[PATCH net-next 2/4] net: dsa: microchip: support for "ethernet-ports" node

2020-11-20 Thread Christian Eggers
The dsa.yaml device tree binding allows "ethernet-ports" (preferred) and "ports". Signed-off-by: Christian Eggers Reviewed-by: Vladimir Oltean --- drivers/net/dsa/microchip/ksz_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c

[PATCH net-next 3/4] net: dsa: microchip: ksz9477: setup SPI mode

2020-11-20 Thread Christian Eggers
This should be done in the device driver instead of the device tree. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_spi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz9477_spi.c b/drivers/net/dsa/microchip/ksz9477_spi.c index 1142

[PATCH net-next 4/4] net: dsa: microchip: ksz8795: setup SPI mode

2020-11-20 Thread Christian Eggers
This should be done in the device driver instead of the device tree. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz8795_spi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/dsa/microchip/ksz8795_spi.c b/drivers/net/dsa/microchip/ksz8795_spi.c index 8b00

[PATCH net] MAINTAINERS: Change Solarflare maintainers

2020-11-20 Thread Martin Habets
Email from solarflare.com will stop working. Update the maintainers. A replacement for linux-net-driv...@solarflare.com is not working yet, for now remove it. Signed-off-by: Martin Habets Signed-off-by: Edward Cree --- MAINTAINERS |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) d

[PATCH bpf] xsk: fix umem cleanup bug at socket destruct

2020-11-20 Thread Magnus Karlsson
From: Magnus Karlsson Fix a bug that is triggered when a partially setup socket is destroyed. For a fully setup socket, a socket that has been bound to a device, the cleanup of the umem is performed at the end of the buffer pool's cleanup work queue item. This has to be performed in a work queue,

Re: [PATCH V5 5/5] can: flexcan: add CAN wakeup function for i.MX8QM

2020-11-20 Thread Marc Kleine-Budde
On 11/6/20 11:56 AM, Joakim Zhang wrote: > The System Controller Firmware (SCFW) is a low-level system function > which runs on a dedicated Cortex-M core to provide power, clock, and > resource management. It exists on some i.MX8 processors. e.g. i.MX8QM > (QM, QP), and i.MX8QX (QXP, DX). SCU drive

[PATCH net-next,v5 1/9] netfilter: flowtable: add hash offset field to tuple

2020-11-20 Thread Pablo Neira Ayuso
Add a placeholder field to calculate hash tuple offset. Similar to 2c407aca6497 ("netfilter: conntrack: avoid gcc-10 zero-length-bounds warning"). Signed-off-by: Pablo Neira Ayuso --- v5: no changes include/net/netfilter/nf_flow_table.h | 4 net/netfilter/nf_flow_table_core.c| 6 +++---

[PATCH net-next,v5 7/9] netfilter: flowtable: use dev_fill_forward_path() to obtain egress device

2020-11-20 Thread Pablo Neira Ayuso
The egress device in the tuple is obtained from route. Use dev_fill_forward_path() instead to provide the real egress device for this flow whenever this is available. The new FLOW_OFFLOAD_XMIT_DIRECT type uses dev_queue_xmit() to transmit ethernet frames. Cache the source and destination hardware

[PATCH net-next,v5 3/9] net: resolve forwarding path from virtual netdevice and HW destination address

2020-11-20 Thread Pablo Neira Ayuso
This patch adds dev_fill_forward_path() which resolves the path to reach the real netdevice from the IP forwarding side. This function takes as input the netdevice and the destination hardware address and it walks down the devices calling .ndo_fill_forward_path() for each device until the real devi

[PATCH net-next,v5 8/9] netfilter: flowtable: add vlan support

2020-11-20 Thread Pablo Neira Ayuso
Add the vlan id and protocol to the flow tuple to uniquely identify flows from the receive path. For the transmit path, dev_hard_header() on the vlan device push the headers. This patch includes support for two VLAN headers (QinQ) from the ingress path. Signed-off-by: Pablo Neira Ayuso --- v5: no

[PATCH net-next,v5 6/9] netfilter: flowtable: use dev_fill_forward_path() to obtain ingress device

2020-11-20 Thread Pablo Neira Ayuso
Obtain the ingress device in the tuple from the route in the reply direction. Use dev_fill_forward_path() instead to get the real ingress device for this flow. Fall back to use the ingress device that the IP forwarding route provides if: - dev_fill_forward_path() finds no real ingress device. - t

[PATCH net-next,v5 5/9] bridge: resolve forwarding path for bridge devices

2020-11-20 Thread Pablo Neira Ayuso
Add .ndo_fill_forward_path for bridge devices. Signed-off-by: Pablo Neira Ayuso --- v5: no changes. include/linux/netdevice.h | 1 + net/bridge/br_device.c| 27 +++ 2 files changed, 28 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h

[PATCH net-next,v5 0/9] netfilter: flowtable bridge and vlan enhancements

2020-11-20 Thread Pablo Neira Ayuso
Hi, The following patchset augments the Netfilter flowtable fastpath to support for network topologies that combine IP forwarding, bridge and VLAN devices. This v5 includes updates for: - Patch #2: fix incorrect xmit type in IPv6 path, per Florian Westphal. - Patch #3: fix possible off by one in

[PATCH net-next,v5 2/9] netfilter: flowtable: add xmit path types

2020-11-20 Thread Pablo Neira Ayuso
Add the xmit_type field that defines the two supported xmit paths in the flowtable data plane, which are the neighbour and the xfrm xmit paths. This patch prepares for new flowtable xmit path types to come. Signed-off-by: Pablo Neira Ayuso --- v5: fix incorrect xmit type in IPv6 datapath, per Flo

[PATCH net-next,v5 9/9] selftests: netfilter: flowtable bridge and VLAN support

2020-11-20 Thread Pablo Neira Ayuso
This patch adds two new tests to cover bridge and VLAN support: - Add a bridge device to the Router1 (nsr1) container and attach the veth0 device to the bridge. Set the IP address to the bridge device to exercise the bridge forwarding path. - Add VLAN encapsulation between to the bridge devic

[PATCH net-next,v5 4/9] net: 8021q: resolve forwarding path for vlan devices

2020-11-20 Thread Pablo Neira Ayuso
Add .ndo_fill_forward_path for vlan devices. For instance, assuming the following topology: IP forwarding / \ eth0.100 eth0 | eth0 . . . ethX ab:cd:

Re: [PATCH bpf-next 2/2] bpf: sanitize BTF data pointer after module is loaded

2020-11-20 Thread Jessica Yu
+++ Andrii Nakryiko [19/11/20 10:26 -0800]: Given .BTF section is not allocatable, it will get trimmed after module is loaded. BPF system handles that properly by creating an independent copy of data. But prevent any accidental misused by resetting the pointer to BTF data. Suggested-by: Jessica

Re: [PATCH v1 net-next] net: dsa: qca: ar9331: add ethtool stats support

2020-11-20 Thread Oleksij Rempel
On Mon, Nov 16, 2020 at 04:28:44PM -0800, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 02:10:05 +0200 Vladimir Oltean wrote: > > On Mon, Nov 16, 2020 at 04:02:13PM -0800, Jakub Kicinski wrote: > > > For a while now we have been pushing back on stats which have a proper > > > interface to be added to

[PATCH bpf-next v2 5/5] selftests/bpf: xsk selftests - Bi-directional Sockets - SKB, DRV

2020-11-20 Thread Weqaar Janjua
Adds following tests: 1. AF_XDP SKB mode d. Bi-directional Sockets Configure sockets as bi-directional tx/rx sockets, sets up fill and completion rings on each socket, tx/rx in both directions. Only nopoll mode is used 2. AF_XDP DRV/Native mode d. Bi-directional Sockets

[PATCH bpf-next v2 0/5] selftests/bpf: xsk selftests

2020-11-20 Thread Weqaar Janjua
This patch set adds AF_XDP selftests based on veth to selftests/bpf. # Topology: # - # --- # _ | Process | _ # / --- \ # /|\ #/ | \ # --- | ---

[PATCH bpf-next v2 4/5] selftests/bpf: xsk selftests - Socket Teardown - SKB, DRV

2020-11-20 Thread Weqaar Janjua
Adds following tests: 1. AF_XDP SKB mode c. Socket Teardown Create a Tx and a Rx socket, Tx from one socket, Rx on another. Destroy both sockets, then repeat multiple times. Only nopoll mode is used 2. AF_XDP DRV/Native mode c. Socket Teardown * Only copy mode is suppor

[PATCH bpf-next v2 2/5] selftests/bpf: xsk selftests - SKB POLL, NOPOLL

2020-11-20 Thread Weqaar Janjua
Adds following tests: 1. AF_XDP SKB mode Generic mode XDP is driver independent, used when the driver does not have support for XDP. Works on any netdevice using sockets and generic XDP path. XDP hook from netif_receive_skb(). a. nopoll - soft-irq processing b. poll - using poll() s

[PATCH bpf-next v2 1/5] selftests/bpf: xsk selftests framework

2020-11-20 Thread Weqaar Janjua
This patch adds AF_XDP selftests framework under selftests/bpf. Prerequisites setup by script test_xsk_prerequisites.sh: Set up veth interfaces as per the topology shown ^^: * setup two veth interfaces and one namespace ** veth in root namespace ** veth in af_xdp namespace ** names

[PATCH bpf-next v2 3/5] selftests/bpf: xsk selftests - DRV POLL, NOPOLL

2020-11-20 Thread Weqaar Janjua
Adds following tests: 2. AF_XDP DRV/Native mode Works on any netdevice with XDP_REDIRECT support, driver dependent. Processes packets before SKB allocation. Provides better performance than SKB. Driver hook available just after DMA of buffer descriptor. a. nopoll b. poll * Only c

Re: [PATCH bpf-next V6 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx

2020-11-20 Thread Carlo Carraro
Hi I report here the issue with the previous patch. The code is now checking against params->tot_len but then it is still using is_skb_forwardable. Consider this case where I shrink the packet: skb->len == 1520 dev->mtu == 1500 params->tot_len == 1480 So the incoming pkt has len 1520, and the out

Re: [PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-20 Thread Andrew Lunn
On Thu, Nov 19, 2020 at 06:43:38PM -0800, Florian Fainelli wrote: > > > On 11/19/2020 4:30 PM, Andrew Lunn wrote: > >> +static struct dsa_lag *dsa_lag_get(struct dsa_switch_tree *dst, > >> + struct net_device *dev) > >> +{ > >> + unsigned long busy = 0; > >> + struct

pull-request: can-next 2020-11-20

2020-11-20 Thread Marc Kleine-Budde
19 22:05:44 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-5.11-20201120 for you to fetch changes up to 275f6010b6994ad286a859062c03be050e8073ad: can: mcp251xfd: remove useless code in mcp251xfd_ch

[net-next 07/25] can: update documentation for DLC usage in Classical CAN

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp The extension of struct can_frame with the len8_dlc element and the can_dlc naming issue required an update of the documentation. Additionally introduce the term 'Classical CAN' which has been established by CAN in Automation to separate the original CAN2.0 A/B from CAN FD.

[net-next 02/25] can: add optional DLC element to Classical CAN frame structure

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp ISO 11898-1 Chapter 8.4.2.3 defines a 4 bit data length code (DLC) table which maps the DLC to the payload length of the CAN frame in bytes: DLC -> payload length 0 .. 8 -> 0 .. 8 9 .. 15 -> 8 Although the DLC values 8 .. 15 in Classical CAN always r

[net-next 13/25] dt-bindings: can: fsl,flexcan: fix fsl,clk-source property

2020-11-20 Thread Marc Kleine-Budde
From: Joakim Zhang Correct fsl,clk-source example since flexcan driver uses "of_property_read_u8" to get this property. Fixes: 9d733992772d ("dt-bindings: can: flexcan: add PE clock source property to device tree") Signed-off-by: Joakim Zhang Link: https://lore.kernel.org/r/20201106105627.3106

[net-next 24/25] can: kvaser_usb: Add new Kvaser hydra devices

2020-11-20 Thread Marc Kleine-Budde
From: Jimmy Assarsson Add new Kvaser hydra devices. Signed-off-by: Jimmy Assarsson Link: https://lore.kernel.org/r/20201115163027.16851-6-jimmyassars...@gmail.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/Kconfig | 3 +++ drivers/net/can/usb/kvaser_usb/kvas

[net-next 23/25] can: kvaser_usb: kvaser_usb_hydra: Add support for new device variant

2020-11-20 Thread Marc Kleine-Budde
From: Christer Beskow Add support for a new variant of devices using the hydra platform, based on NXP i.MX RT (flexcan). Signed-off-by: Christer Beskow Signed-off-by: Jimmy Assarsson Link: https://lore.kernel.org/r/20201115163027.16851-5-jimmyassars...@gmail.com Signed-off-by: Marc Kleine-Budd

[net-next 18/25] can: flexcan: flexcan_rx_offload_setup(): factor out mailbox and rx-offload setup into separate function

2020-11-20 Thread Marc Kleine-Budde
In an upcoming patch the order of operations in flexcan_open() are changed. Introduce convenience function to make that patch simpler. Link: https://lore.kernel.org/r/20201119100917.3013281-4-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 74 +

[net-next 01/25] can: j1939: add tables for the CAN identifier and its fields

2020-11-20 Thread Marc Kleine-Budde
From: Yegor Yefremov Use table markup to show the structure of the CAN identifier, PGN, PDU1, and PDU2 formats. Also add introductory sentence. Signed-off-by: Yegor Yefremov Link: https://lore.kernel.org/r/20201104155730.25196-1-yegorsli...@googlemail.com [mkl: removed trailing whitespace] Sig

[net-next 14/25] dt-bindings: firmware: add IMX_SC_R_CAN(x) macro for CAN

2020-11-20 Thread Marc Kleine-Budde
From: Joakim Zhang Add IMX_SC_R_CAN(x) macro for CAN. Suggested-by: Marc Kleine-Budde Acked-by: Shawn Guo Signed-off-by: Joakim Zhang Link: https://lore.kernel.org/r/20201106105627.31061-5-qiangqing.zh...@nxp.com Signed-off-by: Marc Kleine-Budde --- include/dt-bindings/firmware/imx/rsrc.h |

[net-next 16/25] can: flexcan: factor out enabling and disabling of interrupts into separate function

2020-11-20 Thread Marc Kleine-Budde
The upcoming patches are going to move the enabling and disabling of the interrupts. Introduce convenience functions to make these patches simpler. Link: https://lore.kernel.org/r/20201119100917.3013281-2-...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.c | 41

[net-next 19/25] can: flexcan: flexcan_open(): completely initialize controller before requesting IRQ

2020-11-20 Thread Marc Kleine-Budde
This patch changes the order in which the flexcan controller is brought up during flexcan_open(). It makes sure that the chip is completely initialized before the IRQs are requested and finally enabled. Link: https://lore.kernel.org/r/20201119100917.3013281-5-...@pengutronix.de Signed-off-by: Marc

[net-next 11/25] can: gw: support modification of Classical CAN DLCs

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp Add support for data length code modifications for Classical CAN. The netlink configuration interface always allowed to pass any value that fits into a byte, therefore only the modification process had to be extended to handle the raw DLC represenation of Classical CAN fram

[net-next 15/25] can: flexcan: rename macro FLEXCAN_QUIRK_SETUP_STOP_MODE -> FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR

2020-11-20 Thread Marc Kleine-Budde
From: Joakim Zhang This patch intends to rename FLEXCAN_QUIRK_SETUP_STOP_MODE quirk to FLEXCAN_QUIRK_SETUP_STOP_MODE_GRP for non-scu SoCs, coming patch will add quirk for scu SoCs. For non-scu SoCs, setup stop mode with GPR register. For scu SoCs, setup stop mode with SCU firmware. Signed-off-b

[net-next 12/25] dt-bindings: can: fsl,flexcan: add uint32 reference to clock-frequency property

2020-11-20 Thread Marc Kleine-Budde
This patch adds the missing reference to the clock-frequency property. The driver uses a of_property_read_u32() to read the property to mark it as uint32. Fixes: e5ab9aa7e49b ("dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml") Link: https://lore.kernel.org/r/20201119073357.285892

[net-next 21/25] can: kvaser_usb: Add USB_{LEAF,HYDRA}_PRODUCT_ID_END defines

2020-11-20 Thread Marc Kleine-Budde
From: Jimmy Assarsson Add USB_{LEAF,HYDRA}_PRODUCT_ID_END defines, representing the last USB PID entry in respectively family. This removes the need to update the kvaser_is_{leaf,hydra}() functions whenever new devices are added. Signed-off-by: Jimmy Assarsson Link: https://lore.kernel.org/r/20

[net-next 22/25] can: kvaser_usb: Add new Kvaser Leaf v2 devices

2020-11-20 Thread Marc Kleine-Budde
From: Jimmy Assarsson Add new Kvaser Leaf v2 devices. Signed-off-by: Jimmy Assarsson Link: https://lore.kernel.org/r/20201115163027.16851-4-jimmyassars...@gmail.com Signed-off-by: Marc Kleine-Budde --- drivers/net/can/usb/Kconfig | 2 ++ drivers/net/can/usb/kvaser_usb/kva

[net-next 20/25] can: flexcan: flexcan_close(): change order if commands to properly shut down the controller

2020-11-20 Thread Marc Kleine-Budde
There haven been reports, that the flexcan_close() soradically hangs during simultanious ifdown, sending of CAN messages and probably open CAN bus: | (__schedule) from [<808bbd34>] (schedule+0x90/0xb8) | (schedule) from [<808bf274>] (schedule_timeout+0x1f8/0x24c) | (schedule_timeout) from [<8016be

[net-next 17/25] can: flexcan: move enabling/disabling of interrupts from flexcan_chip_{start,stop}() to callers

2020-11-20 Thread Marc Kleine-Budde
The function flexcan_chip_start() first configures the CAN controller and then enables the interrupt, flexcan_chip_stop() does the opposite. In an upcoming patch the order of operations in flexcan_open() and flexcan_close() are changed. This requires flexcan_chip_start()/flexcan_chip_stop_disable_

[net-next 09/25] can: drivers: add len8_dlc support for various CAN adapters

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp Support the Classical CAN raw DLC functionality to send and receive DLC values from 9 .. 15 on various Classical CAN capable CAN network drivers: - sja1000 - gs_usb - pcan_usb - pcan_usb_fd - usb_8dev Signed-off-by: Oliver Hartkopp Tested-by: Oliver Hartkopp Link: https:

[net-next 10/25] can: drivers: add len8_dlc support for esd_usb2 CAN adapter

2020-11-20 Thread Marc Kleine-Budde
From: Stefan Mätje Support the Classical CAN raw DLC functionality to send and receive DLC values from 9 .. 15 for the Classical CAN capable CAN network driver esd_usb that supports the esd CAN-USB/2 and CAN-USB/Micro devices: - esd_usb2 Signed-off-by: Stefan Mätje Tested-by: Stefan Mätje Lin

[net-next 06/25] can: rename CAN FD related can_len2dlc and can_dlc2len helpers

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp The helper functions can_len2dlc and can_dlc2len are only relevant for CAN FD data length code (DLC) conversion. To fit the introduced can_cc_dlc2len for Classical CAN we rename: can_dlc2len -> can_fd_dlc2len to get the payload length from the DLC can_len2dlc -> can_fd_len

[net-next 05/25] can: replace can_dlc as variable/element for payload length

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp The naming of can_dlc as element of struct can_frame and also as variable name is misleading as it claims to be a 'data length CODE' but in reality it always was a plain data length. With the indroduction of a new 'len' element in struct can_frame we can now remove can_dlc

[net-next 03/25] can: rename get_can_dlc() macro with can_cc_dlc2len()

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp The get_can_dlc() macro is used to ensure the payload length information of the Classical CAN frame to be max 8 bytes (the CAN_MAX_DLEN). Rename the macro and use the correct constant in preparation of the len/dlc cleanup for Classical CAN frames. Signed-off-by: Oliver Har

[net-next 08/25] can: drivers: introduce helpers to access Classical CAN DLC values

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp This patch adds the following helper to functions to access Classical CAN DLC values. can_get_cc_dlc(): get the data length code for Classical CAN raw DLC access can_frame_set_cc_len(): set len and len8_dlc value for Classical CAN raw DLC access Signed-off-by: Oliver Hart

[net-next 04/25] can: remove obsolete get_canfd_dlc() macro

2020-11-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp The macro was always used together with can_dlc2len() which sanitizes the given dlc value on its own. Signed-off-by: Oliver Hartkopp Link: https://lore.kernel.org/r/20201110101852.1973-4-socket...@hartkopp.net Signed-off-by: Marc Kleine-Budde --- drivers/net/can/flexcan.

Re: [PATCH net-next v3 0/3] net: ptp: introduce common defines for PTP message types

2020-11-20 Thread Richard Cochran
On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote: > This series introduces commen defines for PTP event messages. Driver > internal defines are removed and some uses of magic numbers are replaced > by the new defines. Nice cleanup! Reviewed-by: Richard Cochran Thanks, Richard

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-20 Thread Andrew Lunn
On Fri, Nov 20, 2020 at 08:23:22AM +0100, Michal Kubecek wrote: > On Fri, Nov 20, 2020 at 10:59:59AM +0800, tanhuazhong wrote: > > On 2020/11/20 6:02, Michal Kubecek wrote: > > > > > > We could use a similar approach as struct ethtool_link_ksettings, e.g. > > > > > > struct kernel_ethtool_coale

[PATCH net] devlink: Fix reload stats structure

2020-11-20 Thread Moshe Shemesh
Fix reload stats structure exposed to the user. Change stats structure hierarchy to have the reload action as a parent of the stat entry and then stat entry includes value per limit. This will also help to avoid string concatenation on iproute2 output. Reload stats structure before this fix: "stat

[PATCH 25/25] can: mcp251xfd: remove useless code in mcp251xfd_chip_softreset

2020-11-20 Thread Marc Kleine-Budde
From: Kaixu Xia It would directly return if the variable err equals to 0 or other errors. Only when the err equals to -ETIMEDOUT it can reach the 'if (err)' statement, so the 'if (err)' and last 'return -ETIMEDOUT' statements are useless. Romove them. Reported-by: Tosk Robot Signed-off-by: Kaix

  1   2   3   4   5   >