[PATCH v9 0/4] Add support for mv88e6393x family of Marvell

2020-11-19 Thread Pavana Sharma
Thanks for the review. Here's updated patchset. All possible checkpatch 'checks' are attended. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int net: dsa: mv88e6xxx

[PATCH v9 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-11-19 Thread Pavana Sharma
Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-

Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled

2020-11-19 Thread Nicolas Dichtel
Le 18/11/2020 à 18:39, Mahesh Bandewar (महेश बंडेवार) a écrit : > On Wed, Nov 18, 2020 at 8:58 AM Nicolas Dichtel > wrote: >> >> Le 18/11/2020 à 02:12, David Ahern a écrit : >> [snip] >>> If there is no harm in just creating lo in the up state, why not just do >>> it vs relying on a sysctl? It onl

[PATCH v9 2/4] net: phy: Add 5GBASER interface mode

2020-11-19 Thread Pavana Sharma
Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index eb3cb1a98b45..71e280059ec5 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7 @@

[PATCH v9 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

2020-11-19 Thread Pavana Sharma
Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 ++-- drivers/net

[PATCH v9 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread Pavana Sharma
The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Co-developed-by: Ashkan

Re: [PATCH net-next v3 0/6] net/x25: netdev event handling

2020-11-19 Thread Xie He
On Wed, Nov 18, 2020 at 11:02 PM Martin Schiller wrote: > > On 2020-11-18 15:47, Xie He wrote: > > > > But... Won't it be better to handle L2 connections in L2 code? > > > > For example, if we are running X.25 over XOT, we can decide in the XOT > > layer whether and when we reconnect in case the T

Re: [MPTCP] WARNING: net/mptcp/protocol.c:719 mptcp_reset_timer+0x40/0x50

2020-11-19 Thread Matthieu Baerts
Hi Naresh, On 19/11/2020 08:04, Naresh Kamboju wrote: While running kselftest net/mptcp: mptcp_join.sh on x86_64 device running linux next 20201118 tag the following warning was noticed. Thank you for testing MPTCP and having reported this bug! It looks like it is similar to what syzbot repor

Re: violating function pointer signature

2020-11-19 Thread Peter Zijlstra
On Wed, Nov 18, 2020 at 01:48:37PM -0600, Segher Boessenkool wrote: > If you have at most four or so args, what you wnat to do will work on > all systems the kernel currently supports, as far as I can tell. It > is not valid C, and none of the compilers have an extension for this > either. But i

RE: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Parav Pandit
> From: Saeed Mahameed > Sent: Thursday, November 19, 2020 11:42 AM > > From how this discussion is going, i think you are right, we need to clarify > what we are doing in a more high level simplified and generic documentation > to give some initial context, Parav, let's add the missing documen

[PATCH bpf-next v3 00/10] Introduce preferred busy-polling

2020-11-19 Thread Björn Töpel
This series introduces three new features: 1. A new "heavy traffic" busy-polling variant that works in concert with the existing napi_defer_hard_irqs and gro_flush_timeout knobs. 2. A new socket option that let a user change the busy-polling NAPI budget. 3. Allow busy-polling to be perform

[PATCH bpf-next v3 02/10] net: add SO_BUSY_POLL_BUDGET socket option

2020-11-19 Thread Björn Töpel
From: Björn Töpel This option lets a user set a per socket NAPI budget for busy-polling. If the options is not set, it will use the default of 8. Signed-off-by: Björn Töpel --- arch/alpha/include/uapi/asm/socket.h | 1 + arch/mips/include/uapi/asm/socket.h | 1 + arch/parisc/include/uapi/

[PATCH bpf-next v3 01/10] net: introduce preferred busy-polling

2020-11-19 Thread Björn Töpel
From: Björn Töpel The existing busy-polling mode, enabled by the SO_BUSY_POLL socket option or system-wide using the /proc/sys/net/core/busy_read knob, is an opportunistic. That means that if the NAPI context is not scheduled, it will poll it. If, after busy-polling, the budget is exceeded the bu

[PATCH bpf-next v3 03/10] xsk: add support for recvmsg()

2020-11-19 Thread Björn Töpel
From: Björn Töpel Add support for non-blocking recvmsg() to XDP sockets. Previously, only sendmsg() was supported by XDP socket. Now, for symmetry and the upcoming busy-polling support, recvmsg() is added. Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 22 +- 1 file changed

[PATCH bpf-next v3 04/10] xsk: check need wakeup flag in sendmsg()

2020-11-19 Thread Björn Töpel
From: Björn Töpel Add a check for need wake up in sendmsg(), so that if a user calls sendmsg() when no wakeup is needed, do not trigger a wakeup. To simplify the need wakeup check in the syscall, unconditionally enable the need wakeup flag for Tx. This has a side-effect for poll(); If poll() is

[PATCH bpf-next v3 05/10] xsk: add busy-poll support for {recv,send}msg()

2020-11-19 Thread Björn Töpel
From: Björn Töpel Wire-up XDP socket busy-poll support for recvmsg() and sendmsg(). If the XDP socket prefers busy-polling, make sure that no wakeup/IPI is performed. Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 24 1 file changed, 24 insertions(+) diff --git a/net/

[PATCH bpf-next v3 08/10] samples/bpf: use recvfrom() in xdpsock/l2fwd

2020-11-19 Thread Björn Töpel
From: Björn Töpel Start using recvfrom() the l2fwd scenario, instead of poll() which is more expensive and need additional knobs for busy-polling. Signed-off-by: Björn Töpel --- samples/bpf/xdpsock_user.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff -

[PATCH bpf-next v3 06/10] xsk: propagate napi_id to XDP socket Rx path

2020-11-19 Thread Björn Töpel
From: Björn Töpel Add napi_id to the xdp_rxq_info structure, and make sure the XDP socket pick up the napi_id in the Rx path. The napi_id is used to find the corresponding NAPI structure for socket busy polling. Acked-by: Ilias Apalodimas Acked-by: Tariq Toukan Signed-off-by: Björn Töpel ---

[PATCH bpf-next v3 10/10] samples/bpf: add option to set the busy-poll budget

2020-11-19 Thread Björn Töpel
From: Björn Töpel Support for the SO_BUSY_POLL_BUDGET setsockopt, via the batching option ('b'). Signed-off-by: Björn Töpel --- samples/bpf/xdpsock_user.c | 5 + 1 file changed, 5 insertions(+) diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index cb1eaee8a32b..deba62

[PATCH bpf-next v3 09/10] samples/bpf: add busy-poll support to xdpsock

2020-11-19 Thread Björn Töpel
From: Björn Töpel Add a new option to xdpsock, 'B', for busy-polling. This option will also set the batching size, 'b' option, to the busy-poll budget. Signed-off-by: Björn Töpel --- samples/bpf/xdpsock_user.c | 40 +++--- 1 file changed, 33 insertions(+), 7 del

[PATCH bpf-next v3 07/10] samples/bpf: use recvfrom() in xdpsock/rxdrop

2020-11-19 Thread Björn Töpel
From: Björn Töpel Start using recvfrom() the rxdrop scenario. Signed-off-by: Björn Töpel --- samples/bpf/xdpsock_user.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c index 2567f0db5aca..f90111b95b2e 100644 --

Re: violating function pointer signature

2020-11-19 Thread Peter Zijlstra
On Wed, Nov 18, 2020 at 01:11:27PM -0600, Segher Boessenkool wrote: > Calling this via a different declared function type is undefined > behaviour, but that is independent of how the function is *defined*. > Your program can make ducks appear from your nose even if that function > is never called,

Re: [PATCH 06/11] net: dsa: microchip: ksz8795: use phy_port_cnt where possible

2020-11-19 Thread Michael Grzeschik
On Thu, Nov 19, 2020 at 01:29:15AM +0100, Andrew Lunn wrote: case BR_STATE_DISABLED: data |= PORT_LEARN_DISABLE; - if (port < SWITCH_PORT_NUM) + if (port < dev->phy_port_cnt) member = 0; break; So this,

Re: [RFC net-next 1/2] ethtool: add support for controling the type of adaptive coalescing

2020-11-19 Thread tanhuazhong
On 2020/11/19 12:15, Andrew Lunn wrote: diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 9ca87bc..afd8de2 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -433,6 +433,7 @@ struct ethtool_modinfo { *a TX interrupt, when the pac

Re: [PATCH bpf-next] libbpf: Add libbpf_version() function to get library version at runtime

2020-11-19 Thread Jiri Benc
On Wed, 18 Nov 2020 09:43:25 -0800, Alexei Starovoitov wrote: > Just like the kernel doesn't add features for out-of-tree modules > libbpf doesn't add features for projects where libbpf is optional. A more fitting comparison would be the kernel refusing to add a new uAPI call because some applicat

[PATCH net] net: openvswitch: fix TTL decrement action netlink message format

2020-11-19 Thread Eelco Chaudron
Currently, the openvswitch module is not accepting the correctly formated netlink message for the TTL decrement action. For both setting and getting the dec_ttl action, the actions should be nested in the OVS_DEC_TTL_ATTR_ACTION attribute as mentioned in the openvswitch.h uapi. Fixes: 744676e77720

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-11-19 Thread Yunsheng Lin
On 2020/11/19 0:26, Jakub Kicinski wrote: > On Wed, 18 Nov 2020 16:57:57 +0100 Peter Zijlstra wrote: >> On Wed, Nov 18, 2020 at 07:43:48AM -0800, Jakub Kicinski wrote: >> >>> TBH the last sentence I wrote isn't clear even to me at this point ;D >>> >>> Maybe using just the macros from preempt.h - l

Re: [PATCH net-next 0/9] s390/qeth: updates 2020-11-17

2020-11-19 Thread Julian Wiedmann
On 19.11.20 03:35, Jakub Kicinski wrote: > On Tue, 17 Nov 2020 17:15:11 +0100 Julian Wiedmann wrote: >> please apply the following patch series for qeth to netdev's net-next tree. >> >> This brings some cleanups, and a bunch of improvements for our >> .get_link_ksettings() code. > > Applied, thank

Re: [PATCH net-next v2 1/9] ibmvnic: Introduce indirect subordinate Command Response Queue buffer

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: This patch introduces the infrastructure to send batched subordinate Command Response Queue descriptors, which are used by the ibmvnic driver to send TX frame and RX buffer descriptors. Signed-off-by: Thomas Falcon Acked-by: Lijun Pan

Re: [PATCH net-next v2 5/9] ibmvnic: Remove send_subcrq function

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: It is not longer used, so remove it. Signed-off-by: Thomas Falcon Acked-by: Lijun Pan

Re: [PATCH net-next v2 9/9] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case half of the total number of buffers, or if the polling loop exits before the pack

Re: [PATCH] Documentation: networking: Fix Column span alignment warnings in l2tp.rst

2020-11-19 Thread Tom Parkin
On Wed, Nov 18, 2020 at 16:44:11 +0530, siddhant gupta wrote: > On Wed, 18 Nov 2020 at 15:53, Tom Parkin wrote: > > > > On Tue, Nov 17, 2020 at 15:22:07 +0530, Siddhant Gupta wrote: > > > Fix Column span alignment problem warnings in the file > > > > > > > Thanks for the patch, Siddhant. > > > >

Re: [PATCH net-next v2 8/9] ibmvnic: Use netdev_alloc_skb instead of alloc_skb to replenish RX buffers

2020-11-19 Thread ljp
On 2020-11-18 19:12, Thomas Falcon wrote: From: "Dwip N. Banerjee" Take advantage of the additional optimizations in netdev_alloc_skb when allocating socket buffers to be used for packet reception. Signed-off-by: Dwip N. Banerjee Acked-by: Lijun Pan

Re: [PATCH] libbpf: Fix VERSIONED_SYM_COUNT number parsing

2020-11-19 Thread Jiri Olsa
On Wed, Nov 18, 2020 at 05:57:25PM -0800, Andrii Nakryiko wrote: > On Wed, Nov 18, 2020 at 1:15 PM Jiri Olsa wrote: > > > > We remove "other info" from "readelf -s --wide" output when > > parsing GLOBAL_SYM_COUNT variable, which was added in [1]. > > But we don't do that for VERSIONED_SYM_COUNT an

[PATCH net] netfilter: ipset: prevent uninit-value in hash_ip6_add

2020-11-19 Thread Eric Dumazet
From: Eric Dumazet syzbot found that we are not validating user input properly before copying 16 bytes [1]. Using NLA_BINARY in ipaddr_policy[] for IPv6 address is not correct, since it ensures at most 16 bytes were provided. We should instead make sure user provided exactly 16 bytes. In old k

[PATCH net v2] ipv6: Remove dependency of ipv6_frag_thdr_truncated on ipv6 module

2020-11-19 Thread Georg Kohmann
IPV6=m NF_DEFRAG_IPV6=y ld: net/ipv6/netfilter/nf_conntrack_reasm.o: in function `nf_ct_frag6_gather': net/ipv6/netfilter/nf_conntrack_reasm.c:462: undefined reference to `ipv6_frag_thdr_truncated' Netfilter is depending on ipv6 symbol ipv6_frag_thdr_truncated. This dependency is forcing IPV6=y.

Re: [PATCH net] netfilter: ipset: prevent uninit-value in hash_ip6_add

2020-11-19 Thread Florian Westphal
Eric Dumazet wrote: > From: Eric Dumazet > > syzbot found that we are not validating user input properly > before copying 16 bytes [1]. > Using NLA_BINARY in ipaddr_policy[] for IPv6 address is not correct, > since it ensures at most 16 bytes were provided. Thanks Eric. Looks like this is the o

[PATCH net-next resend 0/2] enetc: Clean endianness warnings up

2020-11-19 Thread Claudiu Manoil
Cleanup patches to address the outstanding endianness issues in the driver reported by sparse. Claudiu Manoil (2): enetc: Fix endianness issues for enetc_ethtool enetc: Fix endianness issues for enetc_qos .../net/ethernet/freescale/enetc/enetc_hw.h | 8 +- .../net/ethernet/freescale/enetc

[PATCH net-next resend 2/2] enetc: Fix endianness issues for enetc_qos

2020-11-19 Thread Claudiu Manoil
Currently the control buffer descriptor (cbd) fields have endianness restrictions while the commands passed into the control buffers don't (with one exception). This patch fixes offending code, by adding endianness accessors for cbd fields and removing the unnecessary ones in case of data buffer fi

[PATCH net-next resend 1/2] enetc: Fix endianness issues for enetc_ethtool

2020-11-19 Thread Claudiu Manoil
These particular fields are specified in the H/W reference manual as having network byte order format, so enforce big endian annotation for them and clear the related sparse warnings in the process. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc_hw.h | 8 1

RE: [PATCH net-next 0/2] enetc: Clean endianness warnings up

2020-11-19 Thread Claudiu Manoil
>-Original Message- >From: Jakub Kicinski [...] >Subject: Re: [PATCH net-next 0/2] enetc: Clean endianness warnings up > >On Wed, 18 Nov 2020 09:52:58 -0800 Jakub Kicinski wrote: >> On Tue, 17 Nov 2020 20:20:02 +0200 Claudiu Manoil wrote: >> > Cleanup patches to address the outstanding end

Re: [PATCH net-next resend 1/2] enetc: Fix endianness issues for enetc_ethtool

2020-11-19 Thread Denis Kirjanov
On 11/19/20, Claudiu Manoil wrote: > These particular fields are specified in the H/W reference > manual as having network byte order format, so enforce big > endian annotation for them and clear the related sparse > warnings in the process. > > Signed-off-by: Claudiu Manoil > --- > drivers/net/

[PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-19 Thread Wang Hai
kmemleak report a memory leak as follows: BUG: memory leak unreferenced object 0x8880759ea000 (size 256): comm "syz-executor.3", pid 6484, jiffies 4297476946 (age 48.546s) hex dump (first 32 bytes): 00 00 00 00 01 00 00 00 08 a0 9e 75 80 88 ff ff ...u 08 a0 9e 75 80 88 ff ff 00 00

Re: [RFC PATCH 0/4] net: dsa: link aggregation support

2020-11-19 Thread Vladimir Oltean
On Tue, Oct 27, 2020 at 11:51:13AM +0100, Tobias Waldekranz wrote: > This series starts by adding the generic support required to offload > link aggregates to drivers built on top of the DSA subsystem. It then > implements offloading for the mv88e6xxx driver, i.e. Marvell's > LinkStreet family. > >

[PATCH net-next v2] net: dsa: avoid potential use-after-free error

2020-11-19 Thread Christian Eggers
If dsa_switch_ops::port_txtstamp() returns false, clone will be freed immediately. Shouldn't store a pointer to freed memory. Signed-off-by: Christian Eggers Fixes: 146d442c2357 ("net: dsa: Keep a pointer to the skb clone for TX timestamping") --- Changes since v1: - Fixed "Fixes:" tag (and conf

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-11-19 Thread Peter Zijlstra
On Thu, Nov 19, 2020 at 05:19:44PM +0800, Yunsheng Lin wrote: > On 2020/11/19 0:26, Jakub Kicinski wrote: > > On Wed, 18 Nov 2020 16:57:57 +0100 Peter Zijlstra wrote: > >> On Wed, Nov 18, 2020 at 07:43:48AM -0800, Jakub Kicinski wrote: > >> > >>> TBH the last sentence I wrote isn't clear even to me

Re: [PATCH 5.9 000/255] 5.9.9-rc1 review

2020-11-19 Thread Greg Kroah-Hartman
On Wed, Nov 18, 2020 at 11:03:55AM +0530, Naresh Kamboju wrote: > On Tue, 17 Nov 2020 at 19:02, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 5.9.9 release. > > There are 255 patches in this series, all will be posted as a response > > to this one. If an

Re: [RFC PATCH 0/4] net: dsa: link aggregation support

2020-11-19 Thread Tobias Waldekranz
On Thu Nov 19, 2020 at 1:51 PM CET, Vladimir Oltean wrote: > I have tested these patches on ocelot/felix and all is OK there, I would > appreciate if you could resend as non-RFC. In the case of my hardware, For sure, I am working on it as we speak. I was mostly waiting for the dsa-tag-unification

Re: [PATCH net-next] net: add in_softirq() debug checking in napi_consume_skb()

2020-11-19 Thread Yunsheng Lin
On 2020/11/19 19:41, Peter Zijlstra wrote: > On Thu, Nov 19, 2020 at 05:19:44PM +0800, Yunsheng Lin wrote: >> On 2020/11/19 0:26, Jakub Kicinski wrote: >>> On Wed, 18 Nov 2020 16:57:57 +0100 Peter Zijlstra wrote: On Wed, Nov 18, 2020 at 07:43:48AM -0800, Jakub Kicinski wrote: > TBH th

Re: [PATCH] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Heiner Kallweit
Am 18.11.2020 um 15:24 schrieb Grygorii Strashko: > The mdio_bus may have dependencies from GPIO controller and so got > deferred. Now it will print error message every time -EPROBE_DEFER is > returned from: > __mdiobus_register() > |-devm_gpiod_get_optional() > without actually identifying error

[PATCH net-next 0/8] mlxsw: Add support for nexthop objects

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel This patch set adds support for nexthop objects in mlxsw. Nexthop objects are treated as another front-end for programming nexthops, in addition to the existing IPv4 and IPv6 front-ends. Patch #1 registers a listener to the nexthop notification chain and parses the nexthop inf

[PATCH net-next 1/8] mlxsw: spectrum_router: Add support for nexthop objects

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel Register a listener to the nexthop notification chain and parse notified nexthop objects into the existing mlxsw nexthop data structures. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_router.c | 453 ++ .../ethe

[PATCH net-next 2/8] mlxsw: spectrum_router: Enable resolution of nexthop groups from nexthop objects

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel If the FIB info (i.e, 'struct fib_info', 'struct fib6_info') uses a nexthop object, then use the object's identifier to resolve the nexthop group. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_router.c | 31 +++

[PATCH net-next 8/8] selftests: forwarding: Add multipath tunneling nexthop test

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel Add a nexthop objects version of gre_multipath.sh. Unlike the original test, it also tests IPv6 overlay which is not possible with the legacy nexthop implementation. See commit 9a2ad3623868 ("selftests: forwarding: gre_multipath: Drop IPv6 tests") for more info. Signed-off-by:

[PATCH net-next 6/8] selftests: forwarding: Test IPv4 routes with IPv6 link-local nexthops

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel In addition to IPv4 multipath tests with IPv4 nexthops, also test IPv4 multipath with nexthops that use IPv6 link-local addresses. Signed-off-by: Ido Schimmel --- .../selftests/net/forwarding/router_mpath_nh.sh | 11 +++ 1 file changed, 11 insertions(+) diff -

[PATCH net-next 3/8] mlxsw: spectrum_router: Allow programming routes with nexthop objects

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel Now that the driver supports nexthop objects, the check is no longer necessary. Remove it. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/n

[PATCH net-next 4/8] selftests: mlxsw: Add nexthop objects configuration tests

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel Test that unsupported nexthop objects are rejected and that offload indication is correctly set on: nexthop objects, nexthop group objects and routes associated these objects. Signed-off-by: Ido Schimmel --- .../selftests/drivers/net/mlxsw/rtnetlink.sh | 189 +++

[PATCH net-next 5/8] selftests: forwarding: Do not configure nexthop objects twice

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel routing_nh_obj() is used to configure the nexthop objects employed by the test, but it is called twice resulting in "RTNETLINK answers: File exists" messages. Remove the first call, so that the function is only called after setup_wait(), when all the interfaces are up and read

[PATCH net-next 7/8] selftests: forwarding: Add device-only nexthop test

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel In a similar fashion to router_multipath.sh and its nexthop objects version router_mpath_nh.sh, create a nexthop objects version of router.sh. It reuses the same topology, but uses device-only nexthop objects instead of legacy ones. Signed-off-by: Ido Schimmel --- .../selft

Re: [PATCH net] netfilter: ipset: prevent uninit-value in hash_ip6_add

2020-11-19 Thread Jozsef Kadlecsik
Hi Eric, On Thu, 19 Nov 2020, Eric Dumazet wrote: > From: Eric Dumazet > > syzbot found that we are not validating user input properly > before copying 16 bytes [1]. > > Using NLA_BINARY in ipaddr_policy[] for IPv6 address is not correct, > since it ensures at most 16 bytes were provided. > >

RE: [PATCH net-next resend 1/2] enetc: Fix endianness issues for enetc_ethtool

2020-11-19 Thread Claudiu Manoil
>-Original Message- >From: Denis Kirjanov >Sent: Thursday, November 19, 2020 12:37 PM >To: Claudiu Manoil >Cc: netdev@vger.kernel.org; Jakub Kicinski ; David S . >Miller >Subject: Re: [PATCH net-next resend 1/2] enetc: Fix endianness issues for >enetc_ethtool > >On 11/19/20, Claudiu Ma

[PATCH net] bnxt_en: fix error return code in bnxt_init_board()

2020-11-19 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + 1 file c

Re: [PATCH net] netfilter: ipset: prevent uninit-value in hash_ip6_add

2020-11-19 Thread Pablo Neira Ayuso
On Thu, Nov 19, 2020 at 01:59:32AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > syzbot found that we are not validating user input properly > before copying 16 bytes [1]. > > Using NLA_BINARY in ipaddr_policy[] for IPv6 address is not correct, > since it ensures at most 16 bytes were prov

Re: [PATCH net v2] ipv6: Remove dependency of ipv6_frag_thdr_truncated on ipv6 module

2020-11-19 Thread Pablo Neira Ayuso
On Thu, Nov 19, 2020 at 10:58:33AM +0100, Georg Kohmann wrote: > IPV6=m > NF_DEFRAG_IPV6=y > > ld: net/ipv6/netfilter/nf_conntrack_reasm.o: in function > `nf_ct_frag6_gather': > net/ipv6/netfilter/nf_conntrack_reasm.c:462: undefined reference to > `ipv6_frag_thdr_truncated' > > Netfilter is depen

[PATCH net-next V6] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-19 Thread Dmytro Shytyi
Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly generated hostID or stable privacy + privacy extensions). The main problem is that SLAAC RA or PD allocates a /64 by the Wireless carrier 4G, 5G to a mobile hotspot, however segmentation of the /64 via SLAAC is required so tha

Re: [PATCH] mdio_bus: suppress err message for reset gpio EPROBE_DEFER

2020-11-19 Thread Grygorii Strashko
On 19/11/2020 14:30, Heiner Kallweit wrote: Am 18.11.2020 um 15:24 schrieb Grygorii Strashko: The mdio_bus may have dependencies from GPIO controller and so got deferred. Now it will print error message every time -EPROBE_DEFER is returned from: __mdiobus_register() |-devm_gpiod_get_optiona

Re: [PATCH net-next v3 01/12] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-11-19 Thread Rob Herring
On Wed, 18 Nov 2020 21:30:02 +0100, Christian Eggers wrote: > Convert the bindings document for Microchip KSZ Series Ethernet switches > from txt to yaml. > > Signed-off-by: Christian Eggers > --- > .../devicetree/bindings/net/dsa/ksz.txt | 125 -- > .../bindings/net/dsa/microc

Re: [PATCH net-next v3 01/12] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-11-19 Thread Rob Herring
On Wed, Nov 18, 2020 at 09:30:02PM +0100, Christian Eggers wrote: > Convert the bindings document for Microchip KSZ Series Ethernet switches > from txt to yaml. > > Signed-off-by: Christian Eggers > --- > .../devicetree/bindings/net/dsa/ksz.txt | 125 -- > .../bindings/net/dsa/

RE: [PATCH net-next v2 2/7] dpaa_eth: add basic XDP support

2020-11-19 Thread Camelia Alexandra Groza
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, November 19, 2020 02:22 > To: Camelia Alexandra Groza > Cc: bro...@redhat.com; sa...@kernel.org; da...@davemloft.net; > Madalin Bucur (OSS) ; Ioana Ciornei > ; netdev@vger.kernel.org > Subject: Re: [PATCH net-next v2 2/7] dpaa_

[PATCH iproute2-next 0/2] ip: Nexthop flags extensions

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel Patch #1 prints the recently added 'RTNH_F_TRAP' flag. Patch #2 makes sure that nexthop flags are always printed for nexthop objects. Even when the nexthop does not have a device, such as a blackhole nexthop or a group. Example output with netdevsim: # ip nexthop id 1 via 19

[PATCH iproute2-next 2/2] nexthop: Always print nexthop flags

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel Currently, the nexthop flags are only printed when the nexthop has a nexthop device. The offload / trap indication is therefore not printed for nexthop groups. Instead, always print the nexthop flags, regardless if the nexthop has a nexthop device or not. Signed-off-by: Ido S

[PATCH iproute2-next 1/2] ip route: Print "trap" nexthop indication

2020-11-19 Thread Ido Schimmel
From: Ido Schimmel The kernel can now signal that a nexthop is trapping packets instead of forwarding them. Print the flag to help users understand the offload state of each nexthop. Signed-off-by: Ido Schimmel --- ip/iproute.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/iproute.c

Re: [PATCH 06/11] net: dsa: microchip: ksz8795: use phy_port_cnt where possible

2020-11-19 Thread Andrew Lunn
On Thu, Nov 19, 2020 at 09:40:05AM +0100, Michael Grzeschik wrote: > On Thu, Nov 19, 2020 at 01:29:15AM +0100, Andrew Lunn wrote: > > > case BR_STATE_DISABLED: > > > data |= PORT_LEARN_DISABLE; > > > - if (port < SWITCH_PORT_NUM) > > > + if (port < dev->phy_port_cnt) > >

Re: [PATCH net-next 00/13] Add mlx5 subfunction support

2020-11-19 Thread Jason Gunthorpe
On Wed, Nov 18, 2020 at 10:22:51PM -0800, Saeed Mahameed wrote: > > I think the biggest missing piece in my understanding is what's the > > technical difference between an SF and a VDPA device. > > Same difference as between a VF and netdev. > SF == VF, so a full HW function. > VDPA/RDMA/netdev/SC

Re: [PATCH net] vsock: forward all packets to the host when no H2G is registered

2020-11-19 Thread Stefan Hajnoczi
On Thu, Nov 12, 2020 at 02:38:37PM +0100, Stefano Garzarella wrote: > Before commit c0cfa2d8a788 ("vsock: add multi-transports support"), > if a G2H transport was loaded (e.g. virtio transport), every packets > was forwarded to the host, regardless of the destination CID. > The H2G transports imple

Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

2020-11-19 Thread Naresh Kamboju
col.c | 9 + > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > Reviewed-by: Mat Martineau Reported-by: Naresh Kamboju Tested-by: Naresh Kamboju The reported kernel warning was fixed after applying this fix on top of Linux next tag 20201119. - Naresh

net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Maxime Chevallier
Hello everyone, I'm reaching out to discuss an issue I'm currently having, while working on a Marvell 88E1543 PHY. This PHY is very similar to the 88E1545 we already support upstream, but with an added "dual-port mode" feature that I'm currently using in a project, and that might be interesting t

Re: [PATCH net] vsock: forward all packets to the host when no H2G is registered

2020-11-19 Thread Alexander Graf
On 19.11.20 15:03, Stefan Hajnoczi wrote: On Thu, Nov 12, 2020 at 02:38:37PM +0100, Stefano Garzarella wrote: Before commit c0cfa2d8a788 ("vsock: add multi-transports support"), if a G2H transport was loaded (e.g. virtio transport), every packets was forwarded to the host, regardless of the des

Re: [PATCH net] vsock: forward all packets to the host when no H2G is registered

2020-11-19 Thread Stefano Garzarella
On Thu, Nov 19, 2020 at 03:25:42PM +0100, Alexander Graf wrote: On 19.11.20 15:03, Stefan Hajnoczi wrote: On Thu, Nov 12, 2020 at 02:38:37PM +0100, Stefano Garzarella wrote: Before commit c0cfa2d8a788 ("vsock: add multi-transports support"), if a G2H transport was loaded (e.g. virtio transport

[PATCH net-next 0/4] net: dsa: Link aggregation support

2020-11-19 Thread Tobias Waldekranz
Start of by adding an extra notification when adding a port to a bond, this allows static LAGs to be offloaded using the bonding driver. Then add the generic support required to offload link aggregates to drivers built on top of the DSA subsystem. Finally, implement offloading for the mv88e6xxx d

[PATCH net-next 1/4] net: bonding: Notify ports about their initial state

2020-11-19 Thread Tobias Waldekranz
When creating a static bond (e.g. balance-xor), all ports will always be enabled. This is set, and the corresponding notification is sent out, before the port is linked to the bond upper. In the offloaded case, this ordering is hard to deal with. The lower will first see a notification that it ca

[PATCH net-next 3/4] net: dsa: mv88e6xxx: Link aggregation support

2020-11-19 Thread Tobias Waldekranz
Support offloading of LAGs to hardware. LAGs may be attached to a bridge in which case VLANs, multicast groups, etc. are also offloaded as usual. Signed-off-by: Tobias Waldekranz --- drivers/net/dsa/mv88e6xxx/chip.c| 226 +++- drivers/net/dsa/mv88e6xxx/chip.h| 4

[PATCH net-next 2/4] net: dsa: Link aggregation support

2020-11-19 Thread Tobias Waldekranz
Monitor the following events and notify the driver when: - A DSA port joins/leaves a LAG. - A LAG, made up of DSA ports, joins/leaves a bridge. - A DSA port in a LAG is enabled/disabled (enabled meaning "distributing" in 802.3ad LACP terms). Each LAG interface to which a DSA port is attached is

[PATCH net-next 4/4] net: dsa: tag_dsa: Support reception of packets from LAG devices

2020-11-19 Thread Tobias Waldekranz
Packets ingressing on a LAG that egress on the CPU port, which are not classified as management, will have a FORWARD tag that does not contain the normal source device/port tuple. Instead the trunk bit will be set, and the port field holds the LAG id. Since the exact source port information is not

Re: violating function pointer signature

2020-11-19 Thread Segher Boessenkool
On Thu, Nov 19, 2020 at 09:36:48AM +0100, Peter Zijlstra wrote: > On Wed, Nov 18, 2020 at 01:11:27PM -0600, Segher Boessenkool wrote: > > Calling this via a different declared function type is undefined > > behaviour, but that is independent of how the function is *defined*. > > Your program can ma

[PATCH net] dpaa2-eth: select XGMAC_MDIO for MDIO bus support

2020-11-19 Thread Ioana Ciornei
From: Ioana Ciornei Explicitly enable the FSL_XGMAC_MDIO Kconfig option in order to have MDIO access to internal and external PHYs. Fixes: 719479230893 ("dpaa2-eth: add MAC/PHY support through phylink") Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 + 1 file

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Russell King - ARM Linux admin
On Thu, Nov 19, 2020 at 03:22:46PM +0100, Maxime Chevallier wrote: > Hello everyone, > > I'm reaching out to discuss an issue I'm currently having, while working > on a Marvell 88E1543 PHY. > > This PHY is very similar to the 88E1545 we already support upstream, but > with an added "dual-port mod

Re: violating function pointer signature

2020-11-19 Thread Steven Rostedt
On Thu, 19 Nov 2020 08:37:35 -0600 Segher Boessenkool wrote: > > Note that we have a fairly extensive tradition of defining away UB with > > language extentions, -fno-strict-overflow, -fno-strict-aliasing, > > These are options to make a large swath of not correct C programs > compile (and oft

[PATCH bpf-next v2 0/7] bpf: remove bpf_load loader completely

2020-11-19 Thread Daniel T. Lee
Numerous refactoring that rewrites BPF programs written with bpf_load to use the libbpf loader was finally completed, resulting in BPF programs using bpf_load within the kernel being completely no longer present. This patchset refactors remaining bpf programs with libbpf and completely removes bpf

[PATCH bpf-next v2 1/7] samples: bpf: refactor hbm program with libbpf

2020-11-19 Thread Daniel T. Lee
This commit refactors the existing cgroup programs with libbpf bpf loader. Since bpf_program__attach doesn't support cgroup program attachment, this explicitly attaches cgroup bpf program with bpf_program__attach_cgroup(bpf_prog, cg1). Also, to change attach_type of bpf program, this uses libbpf's

[PATCH bpf-next v2 2/7] samples: bpf: refactor test_cgrp2_sock2 program with libbpf

2020-11-19 Thread Daniel T. Lee
This commit refactors the existing cgroup program with libbpf bpf loader. The original test_cgrp2_sock2 has keeped the bpf program attached to the cgroup hierarchy even after the exit of user program. To implement the same functionality with libbpf, this commit uses the BPF_LINK_PINNING to pin the

[PATCH bpf-next v2 3/7] samples: bpf: refactor task_fd_query program with libbpf

2020-11-19 Thread Daniel T. Lee
This commit refactors the existing kprobe program with libbpf bpf loader. To attach bpf program, this uses generic bpf_program__attach() approach rather than using bpf_load's load_bpf_file(). To attach bpf to perf_event, instead of using previous ioctl method, this commit uses bpf_program__attach_

[PATCH bpf-next v2 4/7] samples: bpf: refactor ibumad program with libbpf

2020-11-19 Thread Daniel T. Lee
This commit refactors the existing ibumad program with libbpf bpf loader. Attach/detach of Tracepoint bpf programs has been managed with the generic bpf_program__attach() and bpf_link__destroy() from the libbpf. Also, instead of using the previous BPF MAP definition, this commit refactors ibumad M

[PATCH bpf-next v2 6/7] samples: bpf: fix lwt_len_hist reusing previous BPF map

2020-11-19 Thread Daniel T. Lee
Currently, lwt_len_hist's map lwt_len_hist_map is uses pinning, and the map isn't cleared on test end. This leds to reuse of that map for each test, which prevents the results of the test from being accurate. This commit fixes the problem by removing of pinned map from bpffs. Also, this commit add

[PATCH bpf-next v2 7/7] samples: bpf: remove bpf_load loader completely

2020-11-19 Thread Daniel T. Lee
Numerous refactoring that rewrites BPF programs written with bpf_load to use the libbpf loader was finally completed, resulting in BPF programs using bpf_load within the kernel being completely no longer present. This commit removes bpf_load, an outdated bpf loader that is difficult to keep up wit

[PATCH bpf-next v2 5/7] samples: bpf: refactor test_overhead program with libbpf

2020-11-19 Thread Daniel T. Lee
This commit refactors the existing program with libbpf bpf loader. Since the kprobe, tracepoint and raw_tracepoint bpf program can be attached with single bpf_program__attach() interface, so the corresponding function of libbpf is used here. Rather than specifying the number of cpus inside the cod

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Andrew Lunn
Hi Maxime > The way this works is that the PHY is internally configured by chaining > 2 internal PHYs back to back. One PHY deals with the Host interface and > is configured as an SGMII to QSGMII converter (the QSGMII is only used > from within the PHY), and the other PHY acts as the Media-side PH

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Russell King - ARM Linux admin
On Thu, Nov 19, 2020 at 02:55:00PM +, Russell King - ARM Linux admin wrote: > On Thu, Nov 19, 2020 at 03:22:46PM +0100, Maxime Chevallier wrote: > > Hello everyone, > > > > I'm reaching out to discuss an issue I'm currently having, while working > > on a Marvell 88E1543 PHY. > > > > This PHY

Re: net: phy: Dealing with 88e1543 dual-port mode

2020-11-19 Thread Maxime Chevallier
Hello Russell, On Thu, 19 Nov 2020 14:55:00 + Russell King - ARM Linux admin wrote: >On Thu, Nov 19, 2020 at 03:22:46PM +0100, Maxime Chevallier wrote: >> Hello everyone, >> >> I'm reaching out to discuss an issue I'm currently having, while working >> on a Marvell 88E1543 PHY. >> >> This

Re: [PATCH v9 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-19 Thread kernel test robot
Hi Pavana, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master v5.10-rc4 next-20201119] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly

  1   2   3   4   >