> On Fri, Nov 13, 2020 at 08:44:40AM -0800, Jakub Kicinski wrote:
> >
> > SGTM, actually everything starting from patch 4 is in drivers/crypto,
> > so we can merge the first 3 into net-next and the rest via crypto?
>
> Yes of course.
>
Thanks I will resubmit patches 4-12 on crypto-2.6 in the next
max_payload is unused.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/core.c| 3 +--
drivers/nfc/s3fwrn5/i2c.c | 4 +---
drivers/nfc/s3fwrn5/s3fwrn5.h | 3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/core.c
stucture should be replaced by structure.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c
index ec930ee2c847..4cde6d
ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Bongsu Jeon
---
drivers/nfc/s3fwrn5/s3fwrn5.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/nfc/s3fwrn5/s3fwrn5.h b/drivers/nfc/s3fwrn5/s3fwrn5.h
index 9d
2020-11-17 16:42 GMT+09:00, k...@kernel.org :
> On Tue, Nov 17, 2020 at 10:16:11AM +0900, Bongsu Jeon wrote:
>> max_payload is unused.
>
> Why did you resend the patch ignoring my review? I already provided you
> with a tag, so you should include it.
>
> https://www.kernel.org/doc/html/latest/proce
On Mon, Nov 16, 2020 at 11:29 PM CET, John Fastabend wrote:
> If the skb_verdict_prog redirects an skb knowingly to itself, fix your
> BPF program this is not optimal and an abuse of the API please use
> SK_PASS. That said there may be cases, such as socket load balancing,
> where picking the socke
This series contain some fixes for selftests/bpf when building/running
on a RISC-V host. Details can be found in each individual commit.
Cheers,
Björn
Björn Töpel (3):
selftests/bpf: Fix broken riscv build
selftests/bpf: Avoid running unprivileged tests with alignment
requirements
self
The selftests/bpf Makefile includes system include directories from
the host, when building BPF programs. On RISC-V glibc requires that
__riscv_xlen is defined. This is not the case for "clang -target bpf",
which messes up __WORDSIZE (errno.h -> ... -> wordsize.h) and breaks
the build.
By explicit
Some architectures have strict alignment requirements. In that case,
the BPF verifier detects if a program has unaligned accesses and
rejects them. A user can pass BPF_F_ANY_ALIGNMENT to a program to
override this check. That, however, will only work when a privileged
user loads a program. A unpriv
A lot of tests require unaligned memory access to work. Mark the tests
as such, so that they can be avoided on unsupported architectures such
as RISC-V.
Signed-off-by: Björn Töpel
---
.../selftests/bpf/verifier/ctx_sk_lookup.c| 7 +++
.../bpf/verifier/direct_value_access.c| 3 ++
.
Nack.
This API is meant to take simple integers, so that programmers can use
atomic64_t with it and have safe nonces. I'm also interested in
preserving the API's ability to safely encrypt more than 4 gigs of
data at once. Passing a buffer also encourages people to use
randomized nonces, which isn'
On Tue, 17 Nov 2020 at 03:45, Antonio Quartulli wrote:
>
> From: Antonio Quartulli
>
> The current interface limits the nonce 64bit, however, new users
> may want to specify a 96bit nonce, as dictated by the
> AEAD_CHACHA20_POLY1305 construction in RFC7539 Section 2.8.
>
> This patch changes the
On Tue, Nov 17, 2020 at 9:32 AM Ard Biesheuvel wrote:
> If you are going back to the drawing board with in-kernel acceleration
> for OpenVPN
As far as I can tell, they're mostly after compatibility with their
existing userspace stuff. Otherwise, if they were going back to the
drawing board, they
On Tue, 17 Nov 2020 at 09:14, Bongsu Jeon wrote:
>
> 2020-11-17 16:42 GMT+09:00, k...@kernel.org :
> > On Tue, Nov 17, 2020 at 10:16:11AM +0900, Bongsu Jeon wrote:
> >> max_payload is unused.
> >
> > Why did you resend the patch ignoring my review? I already provided you
> > with a tag, so you sho
Hello,
Thank you for the feedback!
On Mon, 2020-11-16 at 23:27 +0100, Luc Van Oostenryck wrote:
> > @@ -1606,10 +1607,12 @@ bool lock_sock_fast(struct sock *sk);
> > */
> > static inline void unlock_sock_fast(struct sock *sk, bool slow)
> > {
> > - if (slow)
> > + if (slow) {
> >
On Tue, Nov 17, 2020 at 8:37 AM Magnus Karlsson
wrote:
Thank you for your quick answers and comments.
>
> On Mon, Nov 16, 2020 at 2:25 PM Toke Høiland-Jørgensen
> wrote:
> >
> > alar...@gmail.com writes:
> >
> > > From: Marek Majtyka
> > >
> > > Implement support for checking if a netdev has
Am 17.11.2020 um 08:43 schrieb Chris Snook:
> The full text of the preceding comment explains the need:
>
> /*
> * The atl1c chip can DMA to 64-bit addresses, but it uses a single
> * shared register for the high 32 bits, so only a single, aligned,
> * 4 GB physical address range can be used at a
This patch adds an IPv6 routes encapsulation attribute
to the result of netlink RTM_GETROUTE requests
(i.e. ip route get 2001:db8::).
Signed-off-by: Oliver Herms
---
net/ipv6/route.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 82cbb46a2a4f..d
On Tue, Nov 17, 2020 at 1:01 AM Heiner Kallweit wrote:
>
> Am 17.11.2020 um 08:43 schrieb Chris Snook:
> > The full text of the preceding comment explains the need:
> >
> > /*
> > * The atl1c chip can DMA to 64-bit addresses, but it uses a single
> > * shared register for the high 32 bits, so only
From: Kaixu Xia
It would directly return if the variable err equals to 0 or other errors.
Only when the err equals to -ETIMEDOUT it can reach the 'if (err)'
statement, so the 'if (err)' and last 'return -ETIMEDOUT' statements are
useless. Romove them.
Reported-by: Tosk Robot
Signed-off-by: Kaix
Convert netsec driver to xdp_return_frame_bulk APIs.
Rely on xdp_return_frame_rx_napi for XDP_TX in order to try to recycle
the page in the "in-irq" page_pool cache.
Co-developed-by: Jesper Dangaard Brouer
Signed-off-by: Jesper Dangaard Brouer
Signed-off-by: Lorenzo Bianconi
---
This patch is j
As mentioned before, we have to select a new listener for TCP_NEW_SYN_RECV
requests at receiving the final ACK or sending a SYN+ACK. Therefore, this
patch changes the code to call reuseport_select_sock() even if the
listening socket is TCP_CLOSE. If we can pick out a listening socket from
the reuse
This patch lets reuseport_detach_sock() return a pointer of struct sock,
which is used only by inet_unhash(). If it is not NULL,
inet_csk_reqsk_queue_migrate() migrates TCP_ESTABLISHED/TCP_SYN_RECV
sockets from the closing listener to the selected one.
Listening sockets hold incoming connections a
A TFO request socket is only freed after BOTH 3WHS has completed (or
aborted) and the child socket has been accepted (or its listener closed).
Hence, depending on the order, there can be two kinds of request sockets in
the accept queue.
3WHS -> accept : TCP_ESTABLISHED
accept -> 3WHS : TCP_SYN
Hello,
On 17/11/2020 09:30, Jason A. Donenfeld wrote:
> Nack.
>
> This API is meant to take simple integers, so that programmers can use
> atomic64_t with it and have safe nonces. I'm also interested in
> preserving the API's ability to safely encrypt more than 4 gigs of
> data at once. Passing a
This patch makes it possible to select a new listener for socket migration
by eBPF.
The noteworthy point is that we select a listening socket in
reuseport_detach_sock() and reuseport_select_sock(), but we do not have
struct skb in the unhash path.
Since we cannot pass skb to the eBPF program, we
This patch is a preparation patch to migrate incoming connections in the
later commits and adds two fields (migrate_req and num_closed_socks) to the
struct sock_reuseport to keep TCP_CLOSE sockets in the reuseport group.
If migrate_req is 1, and then we close a listening socket, we can migrate
its
This patch adds a test for net.ipv4.tcp_migrate_req with eBPF.
Reviewed-by: Benjamin Herrenschmidt
Signed-off-by: Kuniyuki Iwashima
---
.../bpf/prog_tests/migrate_reuseport.c| 175 ++
.../bpf/progs/test_migrate_reuseport_kern.c | 53 ++
2 files changed, 228 insert
The SO_REUSEPORT option allows sockets to listen on the same port and to
accept connections evenly. However, there is a defect in the current
implementation. When a SYN packet is received, the connection is tied to a
listening socket. Accordingly, when the listener is closed, in-flight
requests dur
This commit adds a new sysctl option: net.ipv4.tcp_migrate_req. If this
option is enabled, and then we call listen() for SO_REUSEPORT enabled
sockets and close one, we will be able to migrate its child sockets to
another listener.
Reviewed-by: Benjamin Herrenschmidt
Signed-off-by: Kuniyuki Iwashi
We will call sock_reuseport.prog for socket migration in the next commit,
so the eBPF program has to know which listener is closing in order to
select the new listener.
Currently, we can get a unique ID for each listener in the userspace by
calling bpf_map_lookup_elem() for BPF_MAP_TYPE_REUSEPORT_
Hi,
On 17/11/2020 09:31, Ard Biesheuvel wrote:
> If you are going back to the drawing board with in-kernel acceleration
> for OpenVPN, I strongly suggest to:
> a) either stick to one implementation, and use the library interface,
> or use dynamic dispatch using the crypto API AEAD abstraction, wh
Fix Column span alignment problem warnings in the file
Signed-off-by: Siddhant Gupta
---
Documentation/networking/l2tp.rst | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/Documentation/networking/l2tp.rst
b/Documentation/networking/l2tp.rst
index
On 2020-11-16 21:16, Xie He wrote:
Do you mean we will now automatically establish LAPB connections
without upper layers instructing us to do so?
Yes, as soon as the physical link is established, the L2 and also the
L3 layer (restart handshake) is established.
In this context I also noticed th
On 11/17/20 8:29 AM, Ricardo Dias wrote:
> When the TCP stack is in SYN flood mode, the server child socket is
> created from the SYN cookie received in a TCP packet with the ACK flag
> set.
>
...
>
> @@ -1374,6 +1381,13 @@ static struct sock *tcp_v6_syn_recv_sock(const struct
> sock *sk,
On Tue, 17 Nov 2020 at 10:47, Antonio Quartulli wrote:
>
> Hi,
>
>
> On 17/11/2020 09:31, Ard Biesheuvel wrote:
> > If you are going back to the drawing board with in-kernel acceleration
> > for OpenVPN, I strongly suggest to:
> > a) either stick to one implementation, and use the library interfac
On 2020-11-16 17:12, Xuan Zhuo wrote:
On Mon, 16 Nov 2020 15:31:20 +0100, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?=
wrote:
On 2020-11-16 09:10, Xuan Zhuo wrote:
When we write all cq items to tx, we have to wait for a new event based
on poll to indicate that it is writable. But the current writab
On Tue, Nov 17, 2020 at 05:29:12PM +0800, xiakaixu1...@gmail.com wrote:
> From: Kaixu Xia
>
> It would directly return if the variable err equals to 0 or other errors.
> Only when the err equals to -ETIMEDOUT it can reach the 'if (err)'
> statement, so the 'if (err)' and last 'return -ETIMEDOUT'
Hi,
On 17/11/2020 10:52, Ard Biesheuvel wrote:
> On Tue, 17 Nov 2020 at 10:47, Antonio Quartulli wrote:
>>
>> Hi,
>>
>>
>> On 17/11/2020 09:31, Ard Biesheuvel wrote:
>>> If you are going back to the drawing board with in-kernel acceleration
>>> for OpenVPN, I strongly suggest to:
>>> a) either st
>-Original Message-
>From: Andrew Lunn
>Sent: Tuesday, November 17, 2020 4:45 AM
>To: Claudiu Manoil
>Cc: netdev@vger.kernel.org; Jakub Kicinski ; David S .
>Miller ; Alexandru Marginean
>; Vladimir Oltean
>
>Subject: Re: [PATCH net] enetc: Workaround for MDIO register access issue
>
>> +
On Mon, Nov 09, 2020 at 11:03:59AM +0100, Andrea Parri (Microsoft) wrote:
> Currently, VMbus drivers use pointers into guest memory as request IDs
> for interactions with Hyper-V. To be more robust in the face of errors
> or malicious behavior from a compromised Hyper-V, avoid exposing
> guest memo
On Thursday, 12 November 2020, 16:28:44 CET, Christian Eggers wrote:
> Hi Vladimir,
>
> On Tuesday, 10 November 2020, 20:32:45 CET, Vladimir Oltean wrote:
> > But something is still wrong if you need to special-case the negative
> > correctionField, it looks like the arithmetic is not done on the
On Mon, Nov 16, 2020 at 04:45:03PM -0800, Jakub Kicinski wrote:
> On Sat, 14 Nov 2020 00:16:55 +0100 Antonio Cardace wrote:
> > Add scripts to test ring and coalesce settings
> > of netdevsim.
> >
> > Signed-off-by: Antonio Cardace
>
> > @@ -0,0 +1,68 @@
> > +#!/bin/bash
> > +# SPDX-License-Iden
On Tue, Nov 17, 2020 at 1:53 AM Martin Schiller wrote:
>
> On 2020-11-16 21:16, Xie He wrote:
> > Do you mean we will now automatically establish LAPB connections
> > without upper layers instructing us to do so?
>
> Yes, as soon as the physical link is established, the L2 and also the
> L3 layer
On Mon, Nov 16, 2020 at 6:00 AM Martin Schiller wrote:
>
> This makes it possible to handle carrier lost and detection.
> In case of carrier lost, we shutdown layer 3 and flush all sessions.
>
> @@ -275,6 +275,19 @@ static int x25_device_event(struct notifier_block *this,
> unsigned long event,
>
On 17/11/2020 02:37, Alexei Starovoitov wrote:
> If a company built a bpf-based product and wants to distibute such
> product as a package it needs a way to specify this dependency in pkg config.
> 'tc -V' is not something that can be put in a spec.
> The main iproute2 version can be used as a depe
On Tue, Nov 10, 2020 at 08:58:17AM +0800, Yunsheng Lin wrote:
> On 2020/11/9 20:46, Greg KH wrote:
> > On Tue, Nov 03, 2020 at 11:25:38AM +0800, Yunsheng Lin wrote:
> >> commit 2fb541c862c9 ("net: sch_generic: aviod concurrent reset and enqueue
> >> op for lockless qdisc")
> >>
> >> When the above
From: Shravya Kumbham
Add ret variable, condition to check the return value and error
path for the of_address_to_resource() function. It also adds error
handling for mdio setup and decrement refcount of phy node.
Addresses-Coverity: Event check_return value.
Signed-off-by: Shravya Kumbham
Signe
On Sun, Nov 15, 2020 at 12:59:59 +0100, Guillaume Nault wrote:
> On Tue, Nov 10, 2020 at 11:54:07AM +, Tom Parkin wrote:
> > On Mon, Nov 09, 2020 at 23:51:53 +0100, Guillaume Nault wrote:
> > > BTW, shouldn't we have an "UNBRIDGE" command to remove the bridge
> > > between two channels?
> >
On Sun, Nov 15, 2020 at 17:28:38 +0100, Guillaume Nault wrote:
> On Tue, Nov 10, 2020 at 12:04:29PM +, Tom Parkin wrote:
> > On Tue, Nov 10, 2020 at 00:24:01 +0100, Guillaume Nault wrote:
> > > On Fri, Nov 06, 2020 at 06:16:46PM +, Tom Parkin wrote:
> > > > +
On 2020-11-17 12:41, Xie He wrote:
On Mon, Nov 16, 2020 at 6:00 AM Martin Schiller wrote:
This makes it possible to handle carrier lost and detection.
In case of carrier lost, we shutdown layer 3 and flush all sessions.
@@ -275,6 +275,19 @@ static int x25_device_event(struct notifier_block
*
How about this patch? If it is appropriate, I will send a real one.
mm/slub: fix slab double-free when release callback of sysfs trigger
Signed-off-by: Yanfei Xu
diff --git a/mm/slub.c b/mm/slub.c
index 4148235ba554..d10c4fbf8c84 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -5653,7 +5653,
On Tue, Nov 17, 2020 at 5:39 PM Krzysztof Kozlowski wrote:
>
> On Tue, 17 Nov 2020 at 09:14, Bongsu Jeon wrote:
> >
> > 2020-11-17 16:42 GMT+09:00, k...@kernel.org :
> > > On Tue, Nov 17, 2020 at 10:16:11AM +0900, Bongsu Jeon wrote:
> > >> max_payload is unused.
> > >
> > > Why did you resend the
On Tue, Nov 10, 2020 at 08:47:40 -0800, Jakub Kicinski wrote:
> On Tue, 10 Nov 2020 10:28:34 +0100 Guillaume Nault wrote:
> > On Mon, Nov 09, 2020 at 03:52:37PM -0800, Jakub Kicinski wrote:
> > > On Fri, 6 Nov 2020 18:16:45 + Tom Parkin wrote:
> > > > This small RFC series implements a sugg
From: Ian Rogers
[ Upstream commit 1e6f5dcc1b9ec9068f5d38331cec38b35498edf5 ]
The bpf_caps array is shorter without CAP_BPF, avoid out of bounds reads
if this isn't defined. Working around this avoids -Wno-array-bounds with
clang.
Signed-off-by: Ian Rogers
Signed-off-by: Daniel Borkmann
Revie
On 2020-11-17 12:32, Xie He wrote:
On Tue, Nov 17, 2020 at 1:53 AM Martin Schiller wrote:
On 2020-11-16 21:16, Xie He wrote:
> Do you mean we will now automatically establish LAPB connections
> without upper layers instructing us to do so?
Yes, as soon as the physical link is established, the
> > Do you have the Marvell PHY driver either built-in or available as a
> > module? I suspect the problem is you don't. You will need the Marvell
> > PHY driver to correctly drive the PHY, you can't rely on the fallback
> > driver for SFPs.
> Correct. I was using the generic driver and that does
On Tue, Nov 17, 2020 at 07:30:00AM +0200, Leon Romanovsky wrote:
> On Fri, Nov 13, 2020 at 08:18:50AM -0800, Dave Ertman wrote:
> > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver.
> > It enables drivers to create an auxiliary_device and bind an
> > auxiliary_driver to it.
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly using the fallthrough pseudo-keyword as a
replacement for a number of "fall through" markings.
Notice that Clang doesn't recognize "fall through" comments as
implicit fall-through.
Link: https://github.
On Tue, Nov 17, 2020 at 01:48:08PM +, Mark Brown wrote:
> On Tue, Nov 17, 2020 at 07:30:00AM +0200, Leon Romanovsky wrote:
> > On Fri, Nov 13, 2020 at 08:18:50AM -0800, Dave Ertman wrote:
>
> > > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver.
> > > It enables drivers
On 11/17/20, Radhey Shyam Pandey wrote:
> From: Shravya Kumbham
>
> Add ret variable, condition to check the return value and error
> path for the of_address_to_resource() function. It also adds error
> handling for mdio setup and decrement refcount of phy node.
>
> Addresses-Coverity: Event chec
Marc
On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
From: Wu Bo
m_can_handle_state_change() is called with the new_state as an argument.
In the switch statements for CAN_STATE_ERROR_ACTIVE, the comment and the
following code indicate that a CAN_STATE_ERROR_WARNING is handled.
This patch fixe
Marc
On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
Change the order in tcan4x5x_can_remove() to be the exact inverse of
tcan4x5x_can_probe(). First m_can_class_unregister(), then power down the
device.
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy
Lin
On 11/17/20 3:00 PM, Dan Murphy wrote:
> Reviewed-by: Dan Murphy
Thanks. The patches are already mainline.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone:
Marc
On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
This patch adds the missing error checking when initializing the regmap
interface fails.
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Cc: Dan Murphy
Link: http://lore.kernel.org/r/20201019154233.1262589-7-...@pengu
On Tue, Nov 17, 2020 at 12:26:38PM +, Tom Parkin wrote:
> On Sun, Nov 15, 2020 at 17:28:38 +0100, Guillaume Nault wrote:
> > On Tue, Nov 10, 2020 at 12:04:29PM +, Tom Parkin wrote:
> > > On Tue, Nov 10, 2020 at 00:24:01 +0100, Guillaume Nault wrote:
> > > However, my primary motivation fo
On Tue, Nov 17, 2020 at 12:54:22PM +, Tom Parkin wrote:
> On Tue, Nov 10, 2020 at 08:47:40 -0800, Jakub Kicinski wrote:
> > On Tue, 10 Nov 2020 10:28:34 +0100 Guillaume Nault wrote:
> > > I think the question is more about long term maintainance. Do we want
> > > to keep PPP related module sel
On Mon, 16 Nov 2020 at 23:46, Hemant Kumar wrote:
>
> Loopback test opens the MHI device file node and writes
> a data buffer to it. MHI UCI kernel space driver copies
> the data and sends it to MHI uplink (Tx) LOOPBACK channel.
> MHI device loops back the same data to MHI downlink (Rx)
> LOOPBACK
This commit refactors the existing cgroup program with libbpf bpf
loader. The original test_cgrp2_sock2 has keeped the bpf program
attached to the cgroup hierarchy even after the exit of user program.
To implement the same functionality with libbpf, this commit uses the
BPF_LINK_PINNING to pin the
This commit removes the unused trace_helper and bpf_load from
samples/bpf target objects from Makefile.
Signed-off-by: Daniel T. Lee
---
samples/bpf/Makefile | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
index 16d9d68e1
This commit refactors the existing cgroup programs with libbpf
bpf loader. Since bpf_program__attach doesn't support cgroup program
attachment, this explicitly attaches cgroup bpf program with
bpf_program__attach_cgroup(bpf_prog, cg1).
Also, to change attach_type of bpf program, this uses libbpf's
This commit refactors the existing ibumad program with libbpf bpf
loader. Attach/detach of Tracepoint bpf programs has been managed
with the generic bpf_program__attach() and bpf_link__destroy() from
the libbpf.
Also, instead of using the previous BPF MAP definition, this commit
refactors ibumad M
This commit refactors the existing program with libbpf bpf loader.
Since the kprobe, tracepoint and raw_tracepoint bpf program can be
attached with single bpf_program__attach() interface, so the
corresponding function of libbpf is used here.
Rather than specifying the number of cpus inside the cod
Numerous refactoring that rewrites BPF programs written with bpf_load
to use the libbpf loader was finally completed, resulting in BPF
programs using bpf_load within the kernel being completely no longer
present.
This commit removes bpf_load, an outdated bpf loader that is difficult
to keep up wit
Numerous refactoring that rewrites BPF programs written with bpf_load
to use the libbpf loader was finally completed, resulting in BPF
programs using bpf_load within the kernel being completely no longer
present.
This patchset refactors remaining bpf programs with libbpf and
completely removes bpf
This commit refactors the existing kprobe program with libbpf bpf
loader. To attach bpf program, this uses generic bpf_program__attach()
approach rather than using bpf_load's load_bpf_file().
To attach bpf to perf_event, instead of using previous ioctl method,
this commit uses bpf_program__attach_
Under the samples/bpf directory, similar tracing helpers are
fragmented around. To keep consistent of tracing programs, this commit
moves the helper and define locations to increase the reuse of each
helper function.
Signed-off-by: Daniel T. Lee
---
samples/bpf/Makefile|
Currently, lwt_len_hist's map lwt_len_hist_map is uses pinning, and the
map isn't cleared on test end. This leds to reuse of that map for
each test, which prevents the results of the test from being accurate.
This commit fixes the problem by removing of pinned map from bpffs.
Also, this commit add
On 11/17/2020 5:45 AM, Andrew Lunn wrote:
>>> Do you have the Marvell PHY driver either built-in or available as a
>>> module? I suspect the problem is you don't. You will need the Marvell
>>> PHY driver to correctly drive the PHY, you can't rely on the fallback
>>> driver for SFPs.
>> Correct.
Russell King - ARM Linux admin writes:
> On Wed, Nov 11, 2020 at 09:52:18AM +0100, Bjarni Jonasson wrote:
>>
>> Russell King - ARM Linux admin writes:
>>
>> > On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote:
>> >>
>> >> Russell King - ARM Linux admin writes:
>> >>
>> >> > On Tue,
Output of ethtool-ring.sh and ethtool-coalesce.sh selftests:
# ./ethtool-ring.sh
PASSED all 4 checks
# ./ethtool-coalesce.sh
PASSED all 22 checks
Antonio Cardace (6):
ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define
netdevsim: move ethtool pause params in separate struct
netdevsim: support e
As pointed out by Michal Kubecek, getting the name
with the previous approach was racy, it's better
and easier to get the name of the device with this
patch's approach.
Essentialy the function doesn't need to exist
anymore as it's a simple 'ls' command.
Signed-off-by: Antonio Cardace
---
.../dr
Add scripts to test ring and coalesce settings
of netdevsim.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-coalesce.sh | 132 ++
.../drivers/net/netdevsim/ethtool-ring.sh | 85 +++
2 files changed, 217 insertions(+)
create mode 100755
tools/t
This bitmask represents all existing coalesce parameters.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
include/linux/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index 6408b446051f..e3da25b51ae4 100644
--- a/in
Factor out some useful functions so that they can be reused
by other ethtool-netdevsim scripts.
Signed-off-by: Antonio Cardace
---
.../drivers/net/netdevsim/ethtool-common.sh | 69 +++
.../drivers/net/netdevsim/ethtool-pause.sh| 63 +
2 files changed, 71 ins
Add ethtool ring and coalesce settings support for testing.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
v3 -> v4:
- move supported_coalesce_params struct field as first field
- extracted pauseparam refactoring in a different patch
---
drivers/net/netdevsim/ethtool.c | 68
This will help the refactoring in the next commit
when coalesce and ring settings are added.
Signed-off-by: Antonio Cardace
Reviewed-by: Michal Kubecek
---
drivers/net/netdevsim/ethtool.c | 14 +++---
drivers/net/netdevsim/netdevsim.h | 6 +-
2 files changed, 12 insertions(+), 8
On Tue, Nov 17, 2020 at 08:53:34AM +0100, Peter Zijlstra wrote:
> On Mon, Nov 16, 2020 at 01:02:09PM -0800, Martin KaFai Lau wrote:
> > On Mon, Nov 16, 2020 at 07:37:52PM +0100, Florian Lehner wrote:
> > > bpf handlers for perf events other than tracepoints, kprobes or uprobes
> > > are attached to
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly using the fallthrough pseudo-keyword as a
replacement for a number of "fall through" markings.
Notice that Clang doesn't recognize "fall through" comments as
implicit fall-through.
Link: https://github.
On Tue, Nov 17, 2020 at 03:57:24PM +0200, Leon Romanovsky wrote:
> On Tue, Nov 17, 2020 at 01:48:08PM +, Mark Brown wrote:
> > On Tue, Nov 17, 2020 at 07:30:00AM +0200, Leon Romanovsky wrote:
> > > On Fri, Nov 13, 2020 at 08:18:50AM -0800, Dave Ertman wrote:
> >
> > > > Add support for the Auxi
From: Min Li
SM_RESET device only when loading full configuration and check
for BOOT_STATUS. Also remove polling for write trigger done in
_idtcm_settime().
Signed-off-by: Min Li
---
drivers/ptp/idt8a340_reg.h| 1 +
drivers/ptp/ptp_clockmatrix.c | 152
From: Min Li
Feed kstrtou8 with NULL terminated string.
Changes since v1:
-Only strcpy 15 characters to leave 1 space for '\0'
Signed-off-by: Min Li
---
drivers/ptp/ptp_clockmatrix.c | 52 +++
1 file changed, 38 insertions(+), 14 deletions(-)
diff --gi
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/net/wireless/ma
On Tue, 17 Nov 2020 14:56:44 +
"Daniel T. Lee" wrote:
> Numerous refactoring that rewrites BPF programs written with bpf_load
> to use the libbpf loader was finally completed, resulting in BPF
> programs using bpf_load within the kernel being completely no longer
> present.
>
> This commit r
On Tue, 17 Nov 2020 01:50:03 + Hayes Wang wrote:
> Jakub Kicinski
> > Sent: Tuesday, November 17, 2020 1:03 AM
> [...]
> > > Yes, this fixes this issue, although I would prefer a separate Kconfig
> > > entry for r8153_ecm with proper dependencies instead of this ifdefs in
> > > Makefile.
>
Hard-code the minimal link info at initialization time, after we
obtained the link_type. qeth_get_link_ksettings() can still override
this with more accurate data from QUERY CARD INFO later on.
Don't set arbitrary defaults for unknown OSA link types, they
certainly won't match any future type.
Si
Move all the HW reply data parsing into qeth_query_card_info_cb(), and
use common ethtool enums for transporting the information back to the
caller.
Also only look at the .port_speed field when we couldn't determine the
speed from the .card_type field, and introduce some 'default' cases for
SPEED_
Improve the initial link info with data obtained from QUERY OAT.
Doing so _only_ at initialization time avoids
1. dealing with multi-part replies, and
2. sifting through all the data that may get returned at runtime.
This allows us to determine the correct port type for the 1000BT variant
of recen
By the time that our .get_link_ksettings() code issues a QUERY CARD INFO
cmd to get link-related information, we already set up a good amount of
static link data.
Return this data when the cmd fails, same as when the cmd is not
supported.
Signed-off-by: Julian Wiedmann
---
drivers/s390/net/qeth
On Tue, 2020-11-17 at 10:09 -0600, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
Thanks Gustavo.
I think this is better sty
1 - 100 of 353 matches
Mail list logo
