Re: [PATCH] net: ethernet: ti: cpsw: fix cpts irq after suspend

2020-11-13 Thread Tony Lindgren
* Grygorii Strashko [201112 11:15]: > Depending on the SoC/platform the CPSW can completely lose context after a > suspend/resume cycle, including CPSW wrapper (WR) which will cause reset of > WR_C0_MISC_EN register, so CPTS IRQ will became disabled. > > Fix it by moving CPTS IRQ enabling in cpsw

Re: [PATCH net-next 00/18] net: phy: add support for shared interrupts (part 2)

2020-11-13 Thread Ioana Ciornei
On Thu, Nov 12, 2020 at 06:19:10PM -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 17:54:55 +0200 Ioana Ciornei wrote: > > From: Ioana Ciornei > > > > This patch set aims to actually add support for shared interrupts in > > phylib and not only for multi-PHY devices. While we are at it, > > str

答复: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size

2020-11-13 Thread 殷张成
Hi Kristian, For openwrt device, the ' Performance bottleneck ' usually is NAT, not usbnet. As I remember: MT7621 have dual core, and support Hardware acceleration of 'NAT'. It seems r8152 is a pure Ethernet card, does it can use the ' Hardware acceleration ' A

Re: [PATCH v2 bpf-next 1/2] libbpf: separate XDP program load with xsk socket creation

2020-11-13 Thread Magnus Karlsson
On Thu, Nov 12, 2020 at 8:12 PM Andrii Nakryiko wrote: > > On Thu, Nov 12, 2020 at 12:58 AM wrote: > > > > From: Mariusz Dudek > > > > Add support for separation of eBPF program load and xsk socket > > creation. > > > > This is needed for use-case when you want to privide as little > > privilege

RE: [PATCH] brcmfmac: fix error return code in brcmf_cfg80211_connect()

2020-11-13 Thread Chi-Hsien.Lin
> Fix to return a negative error code from the error handling case instead of > 0, as done elsewhere in th> > > Fixes: 3b1e0a7bdfee ("brcmfmac: add support for SAE authentication offload") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Reviewed-by: Chi-hsien Lin > --- > drivers/n

Re: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size

2020-11-13 Thread Kristian Evensen
Hi Carl, Thanks a lot for your reply. On Fri, Nov 13, 2020 at 9:37 AM Carl Yin(殷张成) wrote: > For openwrt device, the ' Performance bottleneck ' usually is NAT, > not usbnet. > As I remember: MT7621 have dual core, and support Hardware > acceleration of 'NAT'. Yes, you are righ

[PATCH v2] IPv4: RTM_GETROUTE: Add RTA_ENCAP to result

2020-11-13 Thread Oliver Herms
This patch adds an IPv4 routes encapsulation attribute to the result of netlink RTM_GETROUTE requests (e.g. ip route get 192.0.2.1). Signed-off-by: Oliver Herms --- net/ipv4/route.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 1d7076b78e63..0fb

[PATCH v2 1/3] net: mac80211: use core API for updating TX/RX stats

2020-11-13 Thread Lev Stipakov
Commits d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") 451b05f413d3f ("net: netdevice.h: sw_netstats_rx_add helper) have added API to update net device per-cpu TX/RX stats. Use core API instead of ieee80211_tx/rx_stats(). Signed-off-by: Lev Stipakov --- v2: also replace ieee80211

Re: [PATCH net-next] net: DSCP in IPv4 routing

2020-11-13 Thread Guillaume Nault
On Thu, Nov 12, 2020 at 07:36:56PM -0800, Stephen Hemminger wrote: > On Fri, 13 Nov 2020 12:06:37 +1000 > Russell Strong wrote: > > > diff --git a/include/uapi/linux/in_route.h > > b/include/uapi/linux/in_route.h index 0cc2c23b47f8..db5d236b9c50 100644 > > --- a/include/uapi/linux/in_route.h > >

[PATCH v2 2/3] net: openvswitch: use core API to update/provide stats

2020-11-13 Thread Lev Stipakov
Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added function "dev_sw_netstats_tx_add()" to update net device per-cpu TX stats. Use this function instead of own code. While on it, remove internal_get_stats() and replace it with dev_get_tstats64(). Signed-off-by: Lev Stipakov

[PATCH v2 3/3] net: xfrm: use core API for updating/providing stats

2020-11-13 Thread Lev Stipakov
Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added function "dev_sw_netstats_tx_add()" to update net device per-cpu TX stats. Use this function instead of own code. While on it, remove xfrmi_get_stats64() and replace it with dev_get_tstats64(). Signed-off-by: Lev Stipakov

[PATCH net] sctp: change to hold/put transport for proto_unreach_timer

2020-11-13 Thread Xin Long
A call trace was found in Hangbin's Codenomicon testing with debug kernel: [ 2615.981988] ODEBUG: free active (active state 0) object type: timer_list hint: sctp_generate_proto_unreach_event+0x0/0x3a0 [sctp] [ 2615.995050] WARNING: CPU: 17 PID: 0 at lib/debugobjects.c:328 debug_print_object+

Re: [net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-13 Thread kernel test robot
Hi Andrea, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipvs/master] [also build test ERROR on linus/master sparc-next/master v5.10-rc3 next-20201112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy

2020-11-13 Thread Antoine Tenart
Quoting Steen Hegelund (2020-11-13 10:11:16) > Selecting VSC8575 as a MACSec PHY was not correct > > The relevant datasheet can be found here: > - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575 > > History: > v1 -> v2: >- Corrected the sha in the "Fixes:" tag > > Fixes: 1bbe0ecc2a1

[PATCH net] net: bridge: add missing counters to ndo_get_stats64 callback

2020-11-13 Thread Heiner Kallweit
In br_forward.c and br_input.c fields dev->stats.tx_dropped and dev->stats.multicast are populated, but they are ignored in ndo_get_stats64. Fixes: 28172739f0a2 ("net: fix 64 bit counters on 32 bit arches") Signed-off-by: Heiner Kallweit --- Patch will not apply cleanly on kernel versions that do

pull-request: mac80211 2020-11-13

2020-11-13 Thread Johannes Berg
Hi Jakub, We have a few fixes, most importantly probably the fix for the sleeping-in-atomic syzbot reported half a dozen (or so) times. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 52755b66ddcef2e897778fac5656df18817b59ab: cosa: Ad

Re: [PATCH v4 2/3] Modify return value of nla_strlcpy to match that of strscpy.

2020-11-13 Thread Francis Laniel
Le vendredi 30 octobre 2020, 20:25:38 CET Kees Cook a écrit : > On Fri, Oct 30, 2020 at 04:36:46PM +0100, laniel_fran...@privacyrequired.com wrote: > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > > index 2a76a2f5ed88..f9b053b30a7b 100644 > > --- a/net/sched/sch_api.c > > +++ b/net/sch

pull-request: mac80211-next 2020-11-13

2020-11-13 Thread Johannes Berg
Hi Jakub, And here's another set of patches, this one for -next. Nothing much stands out, perhaps apart from the WDS removal, but that was old and pretty much dead code when we turned it off, so it won't be missed. Please pull and let me know if there's any problem. Thanks, johannes The follo

Re: [PATCH net-next 0/3] sfc: further EF100 encap TSO features

2020-11-13 Thread Martin Habets
On Thu, Nov 12, 2020 at 03:18:01PM +, Edward Cree wrote: > This series adds support for GRE and GRE_CSUM TSO on EF100 NICs, as > well as improving the handling of UDP tunnel TSO. > > Edward Cree (3): > sfc: extend bitfield macros to 19 fields > sfc: correctly support non-partial GSO_UDP_T

Re: [PATCH net-next 0/3] macb: support the 2-deep Tx queue on at91

2020-11-13 Thread Alexandre Belloni
On 14/10/2020 05:06:30+0200, Willy Tarreau wrote: > On Tue, Oct 13, 2020 at 05:03:58PM -0700, Jakub Kicinski wrote: > > On Sun, 11 Oct 2020 11:09:41 +0200 Willy Tarreau wrote: > > > while running some tests on my Breadbee board, I noticed poor network > > > Tx performance. I had a look at the drive

Re: [PATCH v4 bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-13 Thread Jessica Yu
+++ Andrii Nakryiko [11/11/20 12:11 -0800]: On Wed, Nov 11, 2020 at 2:13 AM Jessica Yu wrote: +++ Andrii Nakryiko [09/11/20 17:19 -0800]: [snipped] >diff --git a/kernel/module.c b/kernel/module.c >index a4fa44a652a7..f2996b02ab2e 100644 >--- a/kernel/module.c >+++ b/kernel/module.c >@@ -380,6

csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Björn Töpel
I was running the selftest/bpf on riscv, and had a closer look at one of the failing cases: #14/p valid read map access into a read-only array 2 FAIL retval 65507 != -29 (run 1/1) The test does a csum_partial() call via a BPF helper. riscv uses the generic implementation. arm64 uses the generic

Re: [PATCH net-next v2 01/13] tcp: factor out tcp_build_frag()

2020-11-13 Thread Paolo Abeni
On Thu, 2020-11-12 at 15:12 -0800, Jakub Kicinski wrote: > On Thu, 12 Nov 2020 15:08:31 -0800 Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 18:45:21 +0100 Paolo Abeni wrote: > > > + skb = sk_stream_alloc_skb(sk, 0, sk->sk_allocation, > > > + tcp_rtx_and_write_queues_

Re: [PATCH v2 1/3] net: mac80211: use core API for updating TX/RX stats

2020-11-13 Thread Heiner Kallweit
Am 13.11.2020 um 09:58 schrieb Lev Stipakov: > Commits > > d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") > 451b05f413d3f ("net: netdevice.h: sw_netstats_rx_add helper) > > have added API to update net device per-cpu TX/RX stats. > > Use core API instead of ieee80211_tx/rx_stats().

Re: [PATCH v2 3/3] net: xfrm: use core API for updating/providing stats

2020-11-13 Thread Heiner Kallweit
Am 13.11.2020 um 10:07 schrieb Lev Stipakov: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function instead of own code. > > While on it, remove xfrmi_get_stats64() and replace

Re: [PATCH v2 2/3] net: openvswitch: use core API to update/provide stats

2020-11-13 Thread Heiner Kallweit
Am 13.11.2020 um 10:02 schrieb Lev Stipakov: > Commit d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") has added > function "dev_sw_netstats_tx_add()" to update net device per-cpu TX > stats. > > Use this function instead of own code. > > While on it, remove internal_get_stats() and replac

Re: [PATCH netdev 1/2] virtio: add module option to turn off guest offloads

2020-11-13 Thread Jesper Dangaard Brouer
On Fri, 13 Nov 2020 09:05:19 +0800 Jason Wang wrote: > On 2020/11/12 下午4:11, Xuan Zhuo wrote: > > * VIRTIO_NET_F_GUEST_CSUM > > * VIRTIO_NET_F_GUEST_TSO4 > > * VIRTIO_NET_F_GUEST_TSO6 > > * VIRTIO_NET_F_GUEST_ECN > > * VIRTIO_NET_F_GUEST_UFO > > * VIRTIO_NET_F_MTU > > > > If these features are ne

Re: [PATCH v2 1/3] net: mac80211: use core API for updating TX/RX stats

2020-11-13 Thread Johannes Berg
On Fri, 2020-11-13 at 10:58 +0200, Lev Stipakov wrote: > Commits > > d3fd65484c781 ("net: core: add dev_sw_netstats_tx_add") > 451b05f413d3f ("net: netdevice.h: sw_netstats_rx_add helper) > > have added API to update net device per-cpu TX/RX stats. > > Use core API instead of ieee80211_tx/rx

[PATCH v5 2/3] Modify return value of nla_strlcpy to match that of strscpy.

2020-11-13 Thread laniel_francis
From: Francis Laniel nla_strlcpy now returns -E2BIG if src was truncated when written to dst. It also returns this error value if dstsize is 0 or higher than INT_MAX. For example, if src is "foo\0" and dst is 3 bytes long, the result will be: 1. "foG" after memcpy (G means garbage). 2. "fo\0" af

[PATCH v5 1/3] Fix unefficient call to memset before memcpu in nla_strlcpy.

2020-11-13 Thread laniel_francis
From: Francis Laniel Before this commit, nla_strlcpy first memseted dst to 0 then wrote src into it. This is inefficient because bytes whom number is less than src length are written twice. This patch solves this issue by first writing src into dst then fill dst with 0's. Note that, in the case

[PATCH v5 3/3] treewide: rename nla_strlcpy to nla_strscpy.

2020-11-13 Thread laniel_francis
From: Francis Laniel Calls to nla_strlcpy are now replaced by calls to nla_strscpy which is the new name of this function. Signed-off-by: Francis Laniel Reviewed-by: Kees Cook --- drivers/infiniband/core/nldev.c| 10 +- drivers/net/can/vxcan.c| 4 ++--

[PATCH v2 net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-13 Thread Wang Hai
If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: use goto instead of direct return

[PATCH v5 0/3] Fix inefficiences and rename nla_strlcpy

2020-11-13 Thread laniel_francis
From: Francis Laniel Hi. I hope you are all fine and the same for your relatives. This patch set answers to first three issues listed in: https://github.com/KSPP/linux/issues/110 To sum up, the patch contributions are the following: 1. the first patch fixes an inefficiency where some bytes in

[PATCH net] net: marvell: prestera: fix error return code in prestera_pci_probe()

2020-11-13 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 4c2703dfd7fa ("net: marvell: prestera: Add PCI interface support") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/marvell/prestera/prestera_pci.c |

[PATCH v6 net-nex 0/5] xdp: introduce bulking for page_pool tx return path

2020-11-13 Thread Lorenzo Bianconi
XDP bulk APIs introduce a defer/flush mechanism to return pages belonging to the same xdp_mem_allocator object (identified via the mem.id field) in bulk to optimize I-cache and D-cache since xdp_return_frame is usually run inside the driver NAPI tx completion loop. Convert mvneta, mvpp2 and mlx5 dr

[PATCH v6 net-nex 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-13 Thread Lorenzo Bianconi
Introduce the capability to batch page_pool ptr_ring refill since it is usually run inside the driver NAPI tx completion loop. Suggested-by: Jesper Dangaard Brouer Co-developed-by: Jesper Dangaard Brouer Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi --- include/net/pag

[PATCH v6 net-nex 3/5] net: mvneta: add xdp tx return bulking support

2020-11-13 Thread Lorenzo Bianconi
Convert mvneta driver to xdp_return_frame_bulk APIs. XDP_REDIRECT (upstream codepath): 275Kpps XDP_REDIRECT (upstream codepath + bulking APIs): 284Kpps Co-developed-by: Jesper Dangaard Brouer Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/marvel

[PATCH v6 net-nex 1/5] net: xdp: introduce bulking for xdp tx return path

2020-11-13 Thread Lorenzo Bianconi
XDP bulk APIs introduce a defer/flush mechanism to return pages belonging to the same xdp_mem_allocator object (identified via the mem.id field) in bulk to optimize I-cache and D-cache since xdp_return_frame is usually run inside the driver NAPI tx completion loop. The bulk queue size is set to 16

[PATCH v4 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-13 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v3->v4: delete 'err = 0' v2->v3: add 'err = 0' before successful return v1->v2: use c

Re: [PATCH net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-13 Thread wanghai (M)
在 2020/11/13 1:51, Jakub Kicinski 写道: On Wed, 11 Nov 2020 21:58:53 +0800 Wang Hai wrote: If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). +++ b/net/core/devlink.c @@ -1447,8 +1447,10 @@ static int devlink_nl_sb_port_pool_fill(struc

[PATCH v6 net-nex 5/5] net: mlx5: add xdp tx return bulking support

2020-11-13 Thread Lorenzo Bianconi
Convert mlx5 driver to xdp_return_frame_bulk APIs. XDP_REDIRECT (upstream codepath): 8.9Mpps XDP_REDIRECT (upstream codepath + bulking APIs): 10.2Mpps Tested-by: Jesper Dangaard Brouer Co-developed-by: Jesper Dangaard Brouer Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi

[PATCH v6 net-nex 4/5] net: mvpp2: add xdp tx return bulking support

2020-11-13 Thread Lorenzo Bianconi
Convert mvpp2 driver to xdp_return_frame_bulk APIs. XDP_REDIRECT (upstream codepath): 1.79Mpps XDP_REDIRECT (upstream codepath + bulking APIs): 1.93Mpps Tested-by: Matteo Croce Co-developed-by: Jesper Dangaard Brouer Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Lorenzo Bianconi --- d

Re: [PATCH net-next 1/1] netdevsim: support ethtool ring and coalesce settings

2020-11-13 Thread Michal Kubecek
On Thu, Nov 12, 2020 at 04:12:29PM +0100, Antonio Cardace wrote: > Add ethtool ring and coalesce settings support for testing. > > Signed-off-by: Antonio Cardace > --- > drivers/net/netdevsim/ethtool.c | 65 +++ > drivers/net/netdevsim/netdevsim.h | 9 - > 2 fi

[PATCH net] Bluetooth: Fix potential null pointer dereference in create_le_conn_complete

2020-11-13 Thread Wang Hai
The pointer 'conn' may be null. Before being used by hci_connect_le_scan_cleanup(), The pointer 'conn' must be checked whether it is null. Fixes: 28a667c9c279 ("Bluetooth: advertisement handling in new connect procedure") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/bluetooth/hci_co

Re: [PATCH v9 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

2020-11-13 Thread Wei Liu
On Mon, Nov 09, 2020 at 11:04:02AM +0100, Andrea Parri (Microsoft) wrote: > From: Andres Beltran > > Currently, pointers to guest memory are passed to Hyper-V as > transaction IDs in netvsc. In the face of errors or malicious > behavior in Hyper-V, netvsc should not expose or trust the transactio

[PATCH net-next] inet: unexport udp{4|6}_lib_lookup_skb()

2020-11-13 Thread Eric Dumazet
From: Eric Dumazet These functions do not need to be exported. Signed-off-by: Eric Dumazet --- net/ipv4/udp.c | 1 - net/ipv6/udp.c | 1 - 2 files changed, 2 deletions(-) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index c732f5acf720d14285bc851d965851a572643051..a3f105227ccca132a8479e3ee358

Re: csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Eric Dumazet
On 11/13/20 11:36 AM, Björn Töpel wrote: > I was running the selftest/bpf on riscv, and had a closer look at one > of the failing cases: > > #14/p valid read map access into a read-only array 2 FAIL retval > 65507 != -29 (run 1/1) > > The test does a csum_partial() call via a BPF helper. ris

Re: Fwd: net: fec: rx descriptor ring out of order

2020-11-13 Thread Kegl Rohit
On Fri, Nov 13, 2020 at 8:33 AM Kegl Rohit wrote: > > > What are the addresses of the ring entries? > > I bet there is something wrong with the cache coherency and/or > > flushing. > > > > So the MAC hardware has done the write but (somewhere) it > > isn't visible to the cpu for ages. > > CMA memo

Re: csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Jean-Philippe Brucker
Hi, On Fri, Nov 13, 2020 at 11:36:08AM +0100, Björn Töpel wrote: > I was running the selftest/bpf on riscv, and had a closer look at one > of the failing cases: > > #14/p valid read map access into a read-only array 2 FAIL retval > 65507 != -29 (run 1/1) > > The test does a csum_partial() call

Re: [PATCH v2 1/3] net: mac80211: use core API for updating TX/RX stats

2020-11-13 Thread Lev Stipakov
Hi, > This looks like a 1/3 but I only ever saw this, not the others. The rest are similar changes for openvswitch and xfrm subsystems, so I've sent those to the list of maintainers I got from scripts/get_maintainer.pl. -- -Lev

Re: [PATCH] tipc: fix -Wstringop-truncation warnings

2020-11-13 Thread Ying Xue
On 11/12/20 5:34 PM, Kang Wenlin wrote: > From: Wenlin Kang > > Replace strncpy() with strscpy(), fixes the following warning: > > In function 'bearer_name_validate', > inlined from 'tipc_enable_bearer' at net/tipc/bearer.c:246:7: > net/tipc/bearer.c:141:2: warning: 'strncpy' specified bound

Re: [PATCH net] sctp: change to hold/put transport for proto_unreach_timer

2020-11-13 Thread Marcelo Ricardo Leitner
Hi, On Fri, Nov 13, 2020 at 05:18:24PM +0800, Xin Long wrote: ... > diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c > index 813d307..0a51150 100644 > --- a/net/sctp/sm_sideeffect.c > +++ b/net/sctp/sm_sideeffect.c > @@ -419,7 +419,7 @@ void sctp_generate_proto_unreach_event(struct

Re: [PATCH net-next V4] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-13 Thread Hideaki Yoshifuji
Hi, 2020年11月13日(金) 10:57 Dmytro Shytyi : > > Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO (randomly > generated hostID or stable privacy + privacy extensions). > The main problem is that SLAAC RA or PD allocates a /64 by the Wireless > carrier 4G, 5G to a mobile hotspot, however

[PATCH RFC] bpf, x64: allow not-converged images when BPF_JIT_ALWAYS_ON is set

2020-11-13 Thread Gary Lin
The x64 bpf jit expects the bpf images converge within the given passes. However there is a corner case: l0: ldh [4] l1: jeq #0x537d, l2, l40 l2: ld [0] l3: jeq #0xfa163e0d, l4, l40 l4: ldh [12] l5: ldx #0xe l6: jeq #0x86dd, l41, l7 l7: jeq #0x800, l

Re: csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Al Viro
On Fri, Nov 13, 2020 at 11:36:08AM +0100, Björn Töpel wrote: > I was running the selftest/bpf on riscv, and had a closer look at one > of the failing cases: > > #14/p valid read map access into a read-only array 2 FAIL retval > 65507 != -29 (run 1/1) > > The test does a csum_partial() call via

Re: [PATCH net] net: phy: mscc: remove non-MACSec compatible phy

2020-11-13 Thread Steen Hegelund
On 12.11.2020 14:28, Jakub Kicinski wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Thu, 12 Nov 2020 10:04:29 +0100 Steen Hegelund wrote: Selecting VSC8575 as a MACSec PHY was not correct The relevant datasheet can be found here: - VSC857

Re: [PATCH net] net: marvell: prestera: fix error return code in prestera_pci_probe()

2020-11-13 Thread Vadym Kochan
Hi Wang, Wang Hai writes: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 4c2703dfd7fa ("net: marvell: prestera: Add PCI interface support") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > --- > drivers/

[PATCH net v2] net: phy: mscc: remove non-MACSec compatible phy

2020-11-13 Thread Steen Hegelund
Selecting VSC8575 as a MACSec PHY was not correct The relevant datasheet can be found here: - VSC8575: https://www.microchip.com/wwwproducts/en/VSC8575 History: v1 -> v2: - Corrected the sha in the "Fixes:" tag Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization") Signed-off-by: Ste

Re: csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Björn Töpel
On Fri, 13 Nov 2020 at 12:34, Eric Dumazet wrote: > > > > On 11/13/20 11:36 AM, Björn Töpel wrote: > > I was running the selftest/bpf on riscv, and had a closer look at one > > of the failing cases: > > > > #14/p valid read map access into a read-only array 2 FAIL retval > > 65507 != -29 (run 1/

Re: csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Björn Töpel
On Fri, 13 Nov 2020 at 13:25, Jean-Philippe Brucker wrote: > > Hi, > > On Fri, Nov 13, 2020 at 11:36:08AM +0100, Björn Töpel wrote: > > I was running the selftest/bpf on riscv, and had a closer look at one > > of the failing cases: > > > > #14/p valid read map access into a read-only array 2 FAI

RE: [PATCH net-next 2/7] dpaa_eth: add basic XDP support

2020-11-13 Thread Camelia Alexandra Groza
> -Original Message- > From: Saeed Mahameed > Sent: Thursday, November 12, 2020 22:41 > To: Camelia Alexandra Groza ; k...@kernel.org; > bro...@redhat.com; da...@davemloft.net > Cc: Madalin Bucur (OSS) ; Ioana Ciornei > ; netdev@vger.kernel.org > Subject: Re: [PATCH net-next 2/7] dpaa_eth:

RE: [PATCH net-next 2/7] dpaa_eth: add basic XDP support

2020-11-13 Thread Camelia Alexandra Groza
> -Original Message- > From: Saeed Mahameed > Sent: Thursday, November 12, 2020 22:43 > To: Camelia Alexandra Groza ; k...@kernel.org; > bro...@redhat.com; da...@davemloft.net > Cc: Madalin Bucur (OSS) ; Ioana Ciornei > ; netdev@vger.kernel.org > Subject: Re: [PATCH net-next 2/7] dpaa_eth:

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Arnd Bergmann
On Thu, Nov 5, 2020 at 6:28 PM Jernej Škrabec wrote: > Dne četrtek, 29. oktober 2020 ob 15:46:44 CET je Ilias Apalodimas napisal(a): > > On Thu, Oct 29, 2020 at 03:39:34PM +0100, Andrew Lunn wrote: > > > > What about reverting the realtek PHY commit from stable? > > > > As Ard said it doesn't real

[PATCH] ipv6: remove unused function ipv6_skb_idev()

2020-11-13 Thread Lukas Bulwahn
Commit bdb7cc643fc9 ("ipv6: Count interface receive statistics on the ingress netdev") removed all callees for ipv6_skb_idev(). Hence, since then, ipv6_skb_idev() is unused and make CC=clang W=1 warns: net/ipv6/exthdrs.c:909:33: warning: unused function 'ipv6_skb_idev' [-Wunused-function] S

RE: [PATCH net-next 4/7] dpaa_eth: add XDP_TX support

2020-11-13 Thread Camelia Alexandra Groza
> -Original Message- > From: Saeed Mahameed > Sent: Thursday, November 12, 2020 22:56 > To: Camelia Alexandra Groza ; k...@kernel.org; > bro...@redhat.com; da...@davemloft.net > Cc: Madalin Bucur (OSS) ; Ioana Ciornei > ; netdev@vger.kernel.org > Subject: Re: [PATCH net-next 4/7] dpaa_eth:

Re: csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Al Viro
On Fri, Nov 13, 2020 at 02:22:16PM +0100, Björn Töpel wrote: > Folding Al's input to this reply. > > I think the bpf_csum_diff() is supposed to be used in combination with > another helper(s) (e.g. bpf_l4_csum_replace) so I'd guess the returned > __wsum should be seen as an opaque value, not some

Re: [PATCH net-next 1/1] netdevsim: support ethtool ring and coalesce settings

2020-11-13 Thread Antonio Cardace
On Fri, Nov 13, 2020 at 12:45:22PM +0100, Michal Kubecek wrote: > On Thu, Nov 12, 2020 at 04:12:29PM +0100, Antonio Cardace wrote: > > Add ethtool ring and coalesce settings support for testing. > > > > Signed-off-by: Antonio Cardace > > --- > > drivers/net/netdevsim/ethtool.c | 65 +++

Re: csum_partial() on different archs (selftest/bpf)

2020-11-13 Thread Daniel Borkmann
On 11/13/20 3:15 PM, Al Viro wrote: On Fri, Nov 13, 2020 at 02:22:16PM +0100, Björn Töpel wrote: Folding Al's input to this reply. I think the bpf_csum_diff() is supposed to be used in combination with another helper(s) (e.g. bpf_l4_csum_replace) so I'd guess the returned __wsum should be seen

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Andrew Lunn
> > Sadly, there is one board - Pine64 Plus - where HW settings are wrong and it > > actually needs SW override. Until this Realtek PHY driver fix was merged, it > > was unclear what magic value provided by Realtek to board manufacturer does. > > > > Reference: > > https://lore.kernel.org/netdev/20

Re: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size

2020-11-13 Thread Kristian Evensen
Hi, On Fri, Nov 13, 2020 at 9:50 AM Kristian Evensen wrote: > Yes, you are right in that NAT can have a large effect on performance, > especially when you start being CPU-limited. However,when using perf > to profile the kernel during my tests, no function related to > netfilter/conntrack appeare

[PATCH net-next 2/2] tcp: avoid indirect call to tcp_stream_memory_free()

2020-11-13 Thread Eric Dumazet
From: Eric Dumazet Signed-off-by: Eric Dumazet --- include/net/sock.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index a5c6ae78df77d08e4b65e634e93040446486bdc2..1d29aeae74fdbbae3410def33ebc66758e034205 100644 --- a/inclu

[PATCH net-next 1/2] tcp: uninline tcp_stream_memory_free()

2020-11-13 Thread Eric Dumazet
From: Eric Dumazet Both IPv4 and IPv6 needs it via a function pointer. Following patch will avoid the indirect call. Signed-off-by: Eric Dumazet --- include/net/tcp.h | 13 + net/ipv4/tcp_ipv4.c | 14 ++ 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a

[PATCH net-next 0/2] tcp: avoid indirect call in __sk_stream_memory_free()

2020-11-13 Thread Eric Dumazet
From: Eric Dumazet Small improvement for CONFIG_RETPOLINE=y, when dealing with TCP sockets. Eric Dumazet (2): tcp: uninline tcp_stream_memory_free() tcp: avoid indirect call to tcp_stream_memory_free() include/net/sock.h | 8 ++-- include/net/tcp.h | 13 + net/ipv4/tcp_

Re: [PATCH net-next v4 09/15] net/smc: Introduce SMCR get linkgroup command

2020-11-13 Thread Karsten Graul
On 11/11/2020 23:34, Jakub Kicinski wrote: > On Mon, 9 Nov 2020 16:18:08 +0100 Karsten Graul wrote: >> @@ -295,6 +377,14 @@ static int smc_diag_dump(struct sk_buff *skb, struct >> netlink_callback *cb) >> >> static int smc_diag_dump_ext(struct sk_buff *skb, struct netlink_callback >> *cb) >>

[PATCH net-next v2 3/4] selftests: extract common functions in ethtool-common.sh

2020-11-13 Thread Antonio Cardace
Factor out some useful functions so that they can be reused by other ethtool-netdevsim scripts. Signed-off-by: Antonio Cardace --- .../drivers/net/netdevsim/ethtool-common.sh | 69 +++ .../drivers/net/netdevsim/ethtool-pause.sh| 63 + 2 files changed, 71 ins

[PATCH net-next v2 2/4] netdevsim: support ethtool ring and coalesce settings

2020-11-13 Thread Antonio Cardace
Add ethtool ring and coalesce settings support for testing. Signed-off-by: Antonio Cardace --- drivers/net/netdevsim/ethtool.c | 78 ++- drivers/net/netdevsim/netdevsim.h | 9 +++- 2 files changed, 75 insertions(+), 12 deletions(-) diff --git a/drivers/net/netdevs

[PATCH net-next v2 1/4] ethtool: add ETHTOOL_COALESCE_ALL_PARAMS define

2020-11-13 Thread Antonio Cardace
This bitmask represents all existing coalesce parameters. Signed-off-by: Antonio Cardace --- include/linux/ethtool.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index 6408b446051f..e3da25b51ae4 100644 --- a/include/linux/ethtool.h +++ b/i

[PATCH net-next v2 4/4] selftests: add ring and coalesce selftests

2020-11-13 Thread Antonio Cardace
Add scripts to test ring and coalesce settings of netdevsim. Signed-off-by: Antonio Cardace --- .../drivers/net/netdevsim/ethtool-coalesce.sh | 68 +++ .../drivers/net/netdevsim/ethtool-ring.sh | 53 +++ 2 files changed, 121 insertions(+) create mode 100755 tool

Re: [PATCH net-next v2 RESEND] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-13 Thread Marek Szyprowski
Hi Hayes, On 04.11.2020 03:19, Hayes Wang wrote: > Support ECM mode based on cdc_ether with relative mii functions, > when CONFIG_USB_RTL8152 is not set, or the device is not supported > by r8152 driver. > > Both r8152 and r8153_ecm would check the return value of > rtl8152_get_version() in porbe(

Re: [PATCH v4 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-13 Thread Daniel Borkmann
On 11/13/20 12:51 PM, Wang Hai wrote: progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai Applied & improved commit msg a bit, thanks!

Re: Re: realtek PHY commit bbc4d71d63549 causes regression

2020-11-13 Thread Arnd Bergmann
On Fri, Nov 13, 2020 at 3:45 PM Andrew Lunn wrote: > > > > Sadly, there is one board - Pine64 Plus - where HW settings are wrong and > > > it > > > actually needs SW override. Until this Realtek PHY driver fix was merged, > > > it > > > was unclear what magic value provided by Realtek to board m

Re: [PATCH net-next,v3 5/9] bridge: resolve forwarding path for bridge devices

2020-11-13 Thread Nikolay Aleksandrov
On 12/11/2020 02:53, Nikolay Aleksandrov wrote: > On 11/11/2020 21:37, Pablo Neira Ayuso wrote: >> Add .ndo_fill_forward_path for bridge devices. >> >> Signed-off-by: Pablo Neira Ayuso >> --- >> include/linux/netdevice.h | 1 + >> net/bridge/br_device.c| 24 >> 2 fil

Re: [PATCH v3 01/10] Add auxiliary bus support

2020-11-13 Thread Greg KH
On Thu, Oct 22, 2020 at 05:33:29PM -0700, Dave Ertman wrote: > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. > It enables drivers to create an auxiliary_device and bind an > auxiliary_driver to it. > > The bus supports probe/remove shutdown and suspend/resume callbacks.

Re: [net] 0b726f6b31: BUG:unable_to_handle_page_fault_for_address

2020-11-13 Thread Willem de Bruijn
On Fri, Nov 13, 2020 at 7:00 AM kernel test robot wrote: > > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 0b726f6b318a07644b6c2388e6e44406740f4754 ("[PATCH v3 net] net: udp: > fix Fast/frag0 UDP GRO") > url: > https://github.com/0day-ci/linux/commits/Alexa

Re: [PATCH v6] lib: optimize cpumask_local_spread()

2020-11-13 Thread Dave Hansen
On 11/12/20 6:06 PM, Shaokun Zhang wrote: >>> On Huawei Kunpeng 920 server, there are 4 NUMA node(0 - 3) in the 2-cpu >>> system(0 - 1). The topology of this server is followed: >> >> This is with a feature enabled that Intel calls sub-NUMA-clustering >> (SNC), right? Explaining *that* feature wou

Re: [PATCH v2] datapath: Add a new action dec_ttl

2020-11-13 Thread Ilya Maximets
Cc: netdev On 11/13/20 3:28 PM, Eelco Chaudron wrote: > > > On 13 Nov 2020, at 13:06, Ilya Maximets wrote: > >> On 11/13/20 11:04 AM, Eelco Chaudron wrote: >>> Add support for the dec_ttl action. Instead of programming the datapath with >>> a flow that matches the packet TTL and an IP set, use

[PATCH net-next 00/15] mlxsw: Preparations for nexthop objects support - part 1/2

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel This patch set contains small and non-functional changes aimed at making it easier to support nexthop objects in mlxsw. Follow up patches can be found here [1]. Patches #1-#4 add a type field to the nexthop group struct instead of the existing protocol field. This will be used

[PATCH net-next 04/15] mlxsw: spectrum_router: Associate neighbour table with nexthop instead of group

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel As explained in the previous patch, nexthop objects can have both IPv4 and IPv6 nexthops in the same group. Therefore, move the neighbour table to be a property of the nexthop instead of the nexthop group. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- .../ethernet

[PATCH net-next 03/15] mlxsw: spectrum_router: Use nexthop group type in hash table key

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel Both IPv4 and IPv6 nexthop groups are hashed in the same table. The protocol field is used to indicate how the hash should be computed for each group. When nexthop group objects are supported, the hash will be computed for them based on the nexthop identifier. To differentiat

[PATCH net-next 10/15] mlxsw: spectrum_router: Pass nexthop netdev to mlxsw_sp_nexthop6_type_init()

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel Instead of passing the route and resolving the nexthop netdev from it, pass the nexthop netdev directly. This will later allow us to consolidate code paths between IPv4 and IPv6 code. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx

[PATCH net-next 13/15] mlxsw: spectrum_router: Consolidate mlxsw_sp_nexthop{4, 6}_type_init()

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel The two functions are now identical, so consolidate them to mlxsw_sp_nexthop_type_init(). Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_router.c | 78 +-- 1 file changed, 21 insertions(+), 57 deletions(-) diff

[PATCH net-next 08/15] mlxsw: spectrum_router: Split nexthop group configuration to a different struct

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel Currently, the individual nexthops member in the group and attributes of the group (e.g., its type) are stored in the same struct (i.e., 'struct mlxsw_sp_nexthop_group'). This is fine since the individual nexthops cannot change during the lifetime of the group. With nexthop ob

[PATCH net-next 05/15] mlxsw: spectrum_router: Store FIB info in route

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel When needed, IPv4 routes fetch the FIB info (i.e., 'struct fib_info') from their associated nexthop group. This will not work when the nexthop group represents a nexthop object (i.e., 'struct nexthop'), as it will only have access to the nexthop's identifier. Instead, store th

[PATCH net-next 12/15] mlxsw: spectrum_router: Remove unused argument from mlxsw_sp_nexthop6_type_init()

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel Remove it as it is unused. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/ne

[PATCH net-next 01/15] mlxsw: spectrum_router: Compare key with correct object type

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel When comparing a key with a nexthop group in rhastable's obj_cmpfn() callback, make sure that the key and nexthop group are of the same type (i.e., IPv4 / IPv6). The bug is not currently visible because IPv6 nexthop groups do not populate the FIB info pointer and IPv4 nexthop

[PATCH net-next 11/15] mlxsw: spectrum_router: Pass nexthop netdev to mlxsw_sp_nexthop4_type_init()

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel Instead of passing the nexthop and resolving the nexthop netdev from it, pass the nexthop netdev directly. This will later allow us to consolidate code paths between IPv4 and IPv6 code. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/m

[PATCH net-next 09/15] mlxsw: spectrum_ipip: Remove overlay protocol from can_offload() callback

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel The overlay protocol (i.e., IPv4/IPv6) that is being encapsulated has no impact on whether a certain IP tunnel can be offloaded or not. Only the underlay protocol matters. Therefore, remove the unused overlay protocol parameter from the callback. This will later allow us to c

[PATCH net-next 02/15] mlxsw: spectrum_router: Add nexthop group type field

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel Currently, the type (i.e., IPv4/IPv6) of the nexthop group is derived from the neighbour table associated with the group. This is problematic when nexthop objects are taken into account, as a nexthop group object can contain both IPv4 and IPv6 nexthops. Instead, add a new fie

[PATCH net-next 14/15] mlxsw: spectrum_router: Consolidate mlxsw_sp_nexthop{4, 6}_type_fini()

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel The two functions are identical, so consolidate them to mlxsw_sp_nexthop_type_fini(). Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- .../ethernet/mellanox/mlxsw/spectrum_router.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git

[PATCH net-next 15/15] mlxsw: spectrum_router: Remove outdated comment

2020-11-13 Thread Ido Schimmel
From: Ido Schimmel Since commit 21151f64a458 ("mlxsw: Add new FIB entry type for reject routes") this comment is no longer correct. Remove it. Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 6 -- 1 file changed, 6 deletions(

  1   2   3   4   >