RE: [PATCH bpf-next v2 4/5] xsk: introduce batched Tx descriptor interfaces

2020-11-11 Thread John Fastabend
Magnus Karlsson wrote: > From: Magnus Karlsson > > Introduce batched descriptor interfaces in the xsk core code for the > Tx path to be used in the driver to write a code path with higher > performance. This interface will be used by the i40e driver in the > next patch. Though other drivers would

Re: [PATCH v2 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-11 Thread John Fastabend
wanghai (M) wrote: > > 在 2020/11/10 12:33, John Fastabend 写道: > > Wang Hai wrote: > >> progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, > >> it should be closed. > >> > >> Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP > >> on interface") > >> Si

Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

2020-11-11 Thread kernel test robot
. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jianyong-Wu/Enable-ptp_kvm-for-arm-arm64/2020-142600 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds

Re: [PATCH] mwifiex: pcie: skip cancel_work_sync() on reset failure path

2020-11-11 Thread Tsuchiya Yuto
On Tue, 2020-11-10 at 18:51 +, Kalle Valo wrote: > Tsuchiya Yuto wrote: > > > If a reset is performed, but even the reset fails for some reasons (e.g., > > on Surface devices, the fw reset requires another quirks), > > cancel_work_sync() hangs in mwifiex_cleanup_pcie(). > > > > # firmwar

Re: [PATCH] mwifiex: pcie: skip cancel_work_sync() on reset failure path

2020-11-11 Thread Kalle Valo
Tsuchiya Yuto writes: > On Tue, 2020-11-10 at 18:51 +, Kalle Valo wrote: >> Tsuchiya Yuto wrote: >> >> > If a reset is performed, but even the reset fails for some reasons (e.g., >> > on Surface devices, the fw reset requires another quirks), >> > cancel_work_sync() hangs in mwifiex_cleanup

[PATCH v9 net-next 0/3] net/sched: fix over mtu packet of defrag in

2020-11-11 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in act_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH v9 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb

2020-11-11 Thread wenxu
From: wenxu The mru in the qdisc_skb_cb should be init as 0. Only defrag packets in the act_ct will set the value. Fixes: 038ebb1a713d ("net/sched: act_ct: fix miss set mru for ovs after defrag in act_ct") Signed-off-by: wenxu --- v9: no change net/core/dev.c | 2 ++ 1 file changed, 2 insert

[PATCH v9 net-next 3/3] net/sched: act_frag: add implict packet fragment support.

2020-11-11 Thread wenxu
From: wenxu Currently kernel tc subsystem can do conntrack in cat_ct. But when several fragment packets go through the act_ct, function tcf_ct_handle_fragments will defrag the packets to a big one. But the last action will redirect mirred to a device which maybe lead the reassembly big packet ove

[PATCH v9 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit

2020-11-11 Thread wenxu
From: wenxu This one is prepare for the next patch. Signed-off-by: wenxu --- v9: no change include/net/sch_generic.h | 5 - net/sched/act_mirred.c| 21 +++-- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_g

[PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Wang Qing
We always have to update the value of ret, otherwise the error value may be the previous one. And ptp_clock_register() never return NULL when PTP_1588_CLOCK enable. Signed-off-by: Wang Qing --- drivers/net/ethernet/ti/am65-cpts.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

RE: [PATCH v5 net-nex 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-11 Thread John Fastabend
Lorenzo Bianconi wrote: > Introduce the capability to batch page_pool ptr_ring refill since it is > usually run inside the driver NAPI tx completion loop. > > Suggested-by: Jesper Dangaard Brouer > Co-developed-by: Jesper Dangaard Brouer > Signed-off-by: Jesper Dangaard Brouer > Signed-off-by:

Re: [PATCH v3] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id

2020-11-11 Thread John Fastabend
Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 9:03 PM wrote: > > > > From: Kaixu Xia > > > > The unsigned variable datasec_id is assigned a return value from the call > > to check_pseudo_btf_id(), which may return negative error code. > > > > Fixes coccicheck warning: > > > > ./kernel/bpf/veri

Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp()

2020-11-11 Thread Miroslav Lichvar
On Tue, Nov 10, 2020 at 11:06:07AM -0800, Vinicius Costa Gomes wrote: > Miroslav Lichvar writes: > > I suspect the estimate would be valid only when the NIC is connected > > directly to the PTM root (PCI root complex). Is it possible to get the > > timestamps or delay from PTM-capable switches on

Re: [Intel-wired-lan] [PATCH net v3 3/6] igb: XDP extack message on error

2020-11-11 Thread Sven Auhagen
On Wed, Nov 11, 2020 at 08:11:46AM +0100, Paul Menzel wrote: > Dear Sven, > > > Am 19.10.20 um 10:05 schrieb sven.auha...@voleatech.de: > > From: Sven Auhagen > > > > Add an extack error message when the RX buffer size is too small > > for the frame size. > > > > Suggested-by: Maciej Fijalkows

Re: [PATCH v2] Bluetooth: Enforce key size of 16 bytes on FIPS level

2020-11-11 Thread Marcel Holtmann
Hi Archie, > According to the spec Ver 5.2, Vol 3, Part C, Sec 5.2.2.8: > Device in security mode 4 level 4 shall enforce: > 128-bit equivalent strength for link and encryption keys required > using FIPS approved algorithms (E0 not allowed, SAFER+ not allowed, > and P-192 not allowed; encryption k

[PATCH v8] can-dev: add len8_dlc support for various CAN adapters

2020-11-11 Thread Oliver Hartkopp
Support the Classical CAN raw DLC functionality to send and receive DLC values from 9 .. 15 on various Classical CAN capable CAN network drivers: - sja1000 - gs_usb - pcan_usb - pcan_usb_fd - usb_8dev Signed-off-by: Oliver Hartkopp Tested-by: Oliver Hartkopp Link: https://lore.kernel.org/r/2020

[PATCH net] net: x25: Fix kernel crashes due to x25_disconnect releasing x25_neigh

2020-11-11 Thread Xie He
The x25_disconnect function in x25_subr.c would decrease the refcount of "x25->neighbour" (struct x25_neigh) and reset this pointer to NULL. However: 1) When we receive a connection, the x25_rx_call_request function in af_x25.c does not increase the refcount when it assigns the pointer. When we d

Re: [PATCH v3] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id

2020-11-11 Thread Daniel Borkmann
On 11/11/20 6:03 AM, xiakaixu1...@gmail.com wrote: From: Kaixu Xia The unsigned variable datasec_id is assigned a return value from the call to check_pseudo_btf_id(), which may return negative error code. Fixes coccicheck warning: ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expressio

Re: [Intel-wired-lan] [PATCH net v3 3/6] igb: XDP extack message on error

2020-11-11 Thread Sven Auhagen
On Wed, Nov 11, 2020 at 08:11:46AM +0100, Paul Menzel wrote: > Dear Sven, > > > Am 19.10.20 um 10:05 schrieb sven.auha...@voleatech.de: > > From: Sven Auhagen > > > > Add an extack error message when the RX buffer size is too small > > for the frame size. > > > > Suggested-by: Maciej Fijalkows

Re: [PATCH v4 bpf-next 4/5] bpf: load and verify kernel module BTFs

2020-11-11 Thread Jessica Yu
+++ Andrii Nakryiko [09/11/20 17:19 -0800]: [snipped] diff --git a/kernel/module.c b/kernel/module.c index a4fa44a652a7..f2996b02ab2e 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -380,6 +380,35 @@ static void *section_objs(const struct load_info *info, return (void *)info->sechdr

Re: [PATCH v8] can-dev: add len8_dlc support for various CAN adapters

2020-11-11 Thread Oliver Hartkopp
Hi Marc, On 11.11.20 10:59, Oliver Hartkopp wrote: Support the Classical CAN raw DLC functionality to send and receive DLC values from 9 .. 15 on various Classical CAN capable CAN network drivers: - sja1000 I got a PCAN-ExpressCard34 to work on my old 2008 Sony Vaio again to test the SJA1000

Re: [RFC PATCH net-next 3/3] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-11-11 Thread Alexandra Winter
On 08.11.20 18:23, Vladimir Oltean wrote: > On Sun, Nov 08, 2020 at 10:09:25PM +0800, DENG Qingfang wrote: >> Can it be turned off for switches that support SA learning from CPU? > > Is there a good reason I would add another property per switch and not > just do it unconditionally? > I have a

Re: [Intel-wired-lan] [PATCH net v3 3/6] igb: XDP extack message on error

2020-11-11 Thread Jesper Dangaard Brouer
On Wed, 11 Nov 2020 10:39:09 +0100 Sven Auhagen wrote: > On Wed, Nov 11, 2020 at 08:11:46AM +0100, Paul Menzel wrote: > > Dear Sven, > > > > > > Am 19.10.20 um 10:05 schrieb sven.auha...@voleatech.de: > > > From: Sven Auhagen > > > > > > Add an extack error message when the RX buffer size i

I sent you a mail earlier but not sure if you received it, kindly check your email and get back to me for I have very urgent information to pass to you.

2020-11-11 Thread Kevin Roberts

Re: [Intel-wired-lan] [PATCH net v3 3/6] igb: XDP extack message on error

2020-11-11 Thread Paul Menzel
Dear Sven, Am 11.11.20 um 11:10 schrieb Sven Auhagen: On Wed, Nov 11, 2020 at 08:11:46AM +0100, Paul Menzel wrote: Am 19.10.20 um 10:05 schrieb sven.auha...@voleatech.de: From: Sven Auhagen Add an extack error message when the RX buffer size is too small for the frame size. Suggested-by:

Re: [RFC PATCH net-next 3/3] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-11-11 Thread Vladimir Oltean
Hi Alexandra, On Wed, Nov 11, 2020 at 11:13:03AM +0100, Alexandra Winter wrote: > On 08.11.20 18:23, Vladimir Oltean wrote: > > On Sun, Nov 08, 2020 at 10:09:25PM +0800, DENG Qingfang wrote: > >> Can it be turned off for switches that support SA learning from CPU? > > > > Is there a good reason I

Re: [PATCH] bpf: relax return code check for subprograms

2020-11-11 Thread Dmitrii Banshchikov
On Tue, Nov 10, 2020 at 08:47:13PM -0800, Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 1:03 PM Dmitrii Banshchikov > wrote: > > > > Currently verifier enforces return code checks for subprograms in the > > same manner as it does for program entry points. This prevents returning > > arbitrary

Re: [PATCH v5 net-nex 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-11 Thread Lorenzo Bianconi
> Lorenzo Bianconi wrote: > > Introduce the capability to batch page_pool ptr_ring refill since it is > > usually run inside the driver NAPI tx completion loop. > > > > Suggested-by: Jesper Dangaard Brouer > > Co-developed-by: Jesper Dangaard Brouer > > Signed-off-by: Jesper Dangaard Brouer > >

Re: [PATCH] vhost_vdpa: switch to vmemdup_user()

2020-11-11 Thread Stefano Garzarella
On Wed, Nov 11, 2020 at 09:14:48AM +0800, Tian Tao wrote: Replace opencoded alloc and copy with vmemdup_user() Signed-off-by: Tian Tao --- drivers/vhost/vdpa.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Stefano Garzarella diff --git a/drivers/vhost/vdpa.c

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-11 Thread Toke Høiland-Jørgensen
Alexei Starovoitov writes: > On Mon, Nov 09, 2020 at 09:09:44PM -0700, David Ahern wrote: >> On 11/8/20 6:45 PM, Alexei Starovoitov wrote: >> > >> > I don't understand why on one side you're pointing out existing quirkiness >> > with >> > bpf usability while at the same time arguing to make it

Re: [PATCH 1/2] bluetooth: hci_event: consolidate error paths in hci_phy_link_complete_evt()

2020-11-11 Thread Marcel Holtmann
Hi Sergey, > hci_phy_link_complete_evt() has several duplicate error paths -- consolidate > them, using the *goto* statements. > > Signed-off-by: Sergey Shtylyov > > --- > net/bluetooth/hci_event.c | 16 ++-- > 1 file changed, 6 insertions(+), 10 deletions(-) patch has been applie

Re: [PATCH v9 1/6] Bluetooth: Replace BT_DBG with bt_dev_dbg in HCI request

2020-11-11 Thread Marcel Holtmann
Hi Howard, > This replaces the BT_DBG function to bt_dev_dbg as it is cleaner to show > the controller index in the debug message. > > Signed-off-by: Howard Chung > --- > > Changes in v9: > - Fix compile warning on patch 6/6 > > Changes in v8: > - Simplified logic in __hci_update_interleaved_s

Re: [PATCH 1/1] RDMA/rxe: Fetch skb packets from ethernet layer

2020-11-11 Thread Zhu Yanjun
On Tue, Nov 10, 2020 at 9:58 AM Zhu Yanjun wrote: > > On Tue, Nov 10, 2020 at 2:25 AM Jakub Kicinski wrote: > > > > On Sun, 8 Nov 2020 13:27:32 +0800 Zhu Yanjun wrote: > > > On Sun, Nov 8, 2020 at 1:24 PM Zhu Yanjun wrote: > > > > On Thu, 5 Nov 2020 19:12:01 +0800 Zhu Yanjun wrote: > > > > > > >

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-11 Thread Jakub Sitnicki
On Wed, Nov 11, 2020 at 05:48 AM CET, Andrii Nakryiko wrote: > On Tue, Nov 10, 2020 at 9:12 AM Santucci Pierpaolo > wrote: >> >> From second fragment on, IPV6FR program must stop the dissection of IPV6 >> fragmented packet. This is the same approach used for IPV4 fragmentation. >> > > Jakub, can y

Re: [PATCH v9 2/6] Bluetooth: Interleave with allowlist scan

2020-11-11 Thread Marcel Holtmann
Hi Howard, > This patch implements the interleaving between allowlist scan and > no-filter scan. It'll be used to save power when at least one monitor is > registered and at least one pending connection or one device to be > scanned for. > > The durations of the allowlist scan and the no-filter s

Re: [PATCH v9 5/6] Bluetooth: Refactor read default sys config for various types

2020-11-11 Thread Marcel Holtmann
Hi Howard, > Refactor read default system configuration function so that it's capable > of returning different types than u16 > > Signed-off-by: Howard Chung > --- > > (no changes since v8) > > Changes in v8: > - Update the commit title and message > > net/bluetooth/mgmt_config.c | 140 ++

Re: [PATCHv6 bpf] bpf: Move iterator functions into special init section

2020-11-11 Thread Daniel Borkmann
On 11/10/20 4:40 PM, Jiri Olsa wrote: With upcoming changes to pahole, that change the way how and which kernel functions are stored in BTF data, we need a way to recognize iterator functions. Iterator functions need to be in BTF data, but have no real body and are currently placed in .init.text

Re: [PATCH v4 net] net: udp: fix Fast/frag0 UDP GRO

2020-11-11 Thread Alexander Lobakin
From: Willem de Bruijn Date: Tue, 10 Nov 2020 13:49:56 -0500 > On Mon, Nov 9, 2020 at 7:29 PM Alexander Lobakin wrote: >> >> From: Alexander Lobakin >> Date: Tue, 10 Nov 2020 00:17:18 + >> >>> While testing UDP GSO fraglists forwarding through driver that uses >>> Fast GRO (via napi_gro_fra

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-11 Thread Edward Cree
On 11/11/2020 00:53, Alexei Starovoitov wrote: > On Tue, Nov 10, 2020 at 12:47:28PM +, Edward Cree wrote: >> But I think it illustrates why having to >>  interoperate with systems outside their control and mix-and-match >>  versioning of various components provides external discipline that >>  

Re: [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect

2020-11-11 Thread Xie He
> This fixes a regression for blocking connects introduced by commit > 4becb7ee5b3d ("net/x25: Fix x25_neigh refcnt leak when x25 disconnect"). > The x25->neighbour is already set to "NULL" by x25_disconnect() now, > while a blocking connect is waiting in > x25_wait_for_connection_establishment().

RE: [PATCH net-next] enetc: Workaround for MDIO register access issue

2020-11-11 Thread Claudiu Manoil
>-Original Message- >From: Andrew Lunn >Sent: Wednesday, November 11, 2020 1:05 AM >To: Claudiu Manoil >Cc: netdev@vger.kernel.org; Jakub Kicinski ; David S . >Miller ; Alexandru Marginean >; Vladimir Oltean > >Subject: Re: [PATCH net-next] enetc: Workaround for MDIO register access >i

Re: [PATCH net] net: x25: Fix kernel crashes due to x25_disconnect releasing x25_neigh

2020-11-11 Thread Martin Schiller
On 2020-11-11 11:04, Xie He wrote: The x25_disconnect function in x25_subr.c would decrease the refcount of "x25->neighbour" (struct x25_neigh) and reset this pointer to NULL. However: 1) When we receive a connection, the x25_rx_call_request function in af_x25.c does not increase the refcount

RE: [PATCH net-next] enetc: Workaround for MDIO register access issue

2020-11-11 Thread Claudiu Manoil
>-Original Message- >From: Florian Fainelli >Sent: Wednesday, November 11, 2020 1:25 AM >To: Claudiu Manoil ; netdev@vger.kernel.org >Cc: Jakub Kicinski ; David S . Miller >; Alexandru Marginean >; Vladimir Oltean > >Subject: Re: [PATCH net-next] enetc: Workaround for MDIO register access

[PATCH net v4] ipv6/netfilter: Discard first fragment not including all headers

2020-11-11 Thread Georg Kohmann
Packets are processed even though the first fragment don't include all headers through the upper layer header. This breaks TAHI IPv6 Core Conformance Test v6LC.1.3.6. Referring to RFC8200 SECTION 4.5: "If the first fragment does not include all headers through an Upper-Layer header, then that frag

Re: [PATCHv6 bpf] bpf: Move iterator functions into special init section

2020-11-11 Thread Jiri Olsa
On Wed, Nov 11, 2020 at 12:26:29PM +0100, Daniel Borkmann wrote: > On 11/10/20 4:40 PM, Jiri Olsa wrote: > > With upcoming changes to pahole, that change the way how and > > which kernel functions are stored in BTF data, we need a way > > to recognize iterator functions. > > > > Iterator functions

Re: [PATCH bpf-next v2 5/5] i40e: use batched xsk Tx interfaces to increase performance

2020-11-11 Thread Magnus Karlsson
On Wed, Nov 11, 2020 at 2:38 AM kernel test robot wrote: > > Hi Magnus, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: > https://github.com/0day-ci/linux/commits/Magnus-Karlsson/xsk-i40e-Tx-performance-improvements/20201110-190310

Re: [RESEND PATCH v2] net/x25: Fix null-ptr-deref in x25_connect

2020-11-11 Thread Xie He
> @@ -825,7 +825,7 @@ static int x25_connect(struct socket *sock, struct > sockaddr *uaddr, > sock->state = SS_CONNECTED; > rc = 0; > out_put_neigh: > - if (rc) { > + if (rc && x25->neighbour) { > read_lock_bh(&x25_list_lock); > x25_neigh_put(x25->

Re: [PATCH net-next 2/5] qmi_wwan: switch to core handling of rx/tx byte/packet counters

2020-11-11 Thread Bjørn Mork
Heiner Kallweit writes: > Use netdev->tstats instead of a member of qmimux_priv for storing > a pointer to the per-cpu counters. This allows us to use core > functionality for statistics handling. > > Signed-off-by: Heiner Kallweit Acked-by: Bjørn Mork

Re: [PATCH net-next 5/5] net: usb: switch to dev_get_tstats64 and remove usbnet_get_stats64 alias

2020-11-11 Thread Bjørn Mork
Heiner Kallweit writes: > Replace usbnet_get_stats64() with new identical core function > dev_get_tstats64() in all users and remove usbnet_get_stats64(). > > Signed-off-by: Heiner Kallweit > --- > drivers/net/usb/aqc111.c | 2 +- > drivers/net/usb/asix_devices.c| 6 +++--- > drive

Re: [PATCH net] net: x25: Fix kernel crashes due to x25_disconnect releasing x25_neigh

2020-11-11 Thread Xie He
On Wed, Nov 11, 2020 at 3:41 AM Martin Schiller wrote: > > > 1) When we receive a connection, the x25_rx_call_request function in > > af_x25.c does not increase the refcount when it assigns the pointer. > > When we disconnect, x25_disconnect is called and the struct's refcount > > is decreased wit

Re: [PATCH net V2] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled

2020-11-11 Thread Tariq Toukan
On 11/11/2020 1:44 AM, Jakub Kicinski wrote: On Sun, 8 Nov 2020 16:43:09 +0200 Tariq Toukan wrote: @@ -528,3 +528,7 @@ Drivers should ignore the changes to TLS the device feature flags. These flags will be acted upon accordingly by the core ``ktls`` code. TLS device feature flags only c

Re: [PATCH 05/10] ARM: dts: BCM5301X: Provide defaults ports container node

2020-11-11 Thread Rafał Miłecki
On 11.11.2020 02:48, Florian Fainelli wrote: On 11/10/2020 2:13 PM, Florian Fainelli wrote: On 11/10/20 2:12 PM, Vladimir Oltean wrote: On Mon, Nov 09, 2020 at 07:31:08PM -0800, Florian Fainelli wrote: Provide an empty 'ports' container node with the correct #address-cells and #size-cells prop

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Richard Cochran
On Wed, Nov 11, 2020 at 05:24:41PM +0800, Wang Qing wrote: > We always have to update the value of ret, otherwise the error value > may be the previous one. And ptp_clock_register() never return NULL > when PTP_1588_CLOCK enable. NAK. Your code must handle the possibility that ptp_clock_registe

Re: [PATCHv6 bpf] bpf: Move iterator functions into special init section

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 12:26:29PM +0100, Daniel Borkmann escreveu: > On 11/10/20 4:40 PM, Jiri Olsa wrote: > > With upcoming changes to pahole, that change the way how and > > which kernel functions are stored in BTF data, we need a way > > to recognize iterator functions. > > > > Iterator functi

Re: [PATCHv6 bpf] bpf: Move iterator functions into special init section

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 09:37:38AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Nov 11, 2020 at 12:26:29PM +0100, Daniel Borkmann escreveu: > > On 11/10/20 4:40 PM, Jiri Olsa wrote: > > > With upcoming changes to pahole, that change the way how and > > > which kernel functions are stored in

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-11 Thread Bjarni Jonasson
Russell King - ARM Linux admin writes: > On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote: >> >> Russell King - ARM Linux admin writes: >> >> > On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni Jonasson wrote: >> >> There is an issue with the current phylink driver and CuSFPs which

[PATCH net] net/tls: Fix wrong record sn in async mode of device resync

2020-11-11 Thread Tariq Toukan
In async_resync mode, we log the TCP seq of records until the async request is completed. Later, in case one of the logged seqs matches the resync request, we return it, together with its record serial number. Before this fix, we mistakenly returned the serial number of the current record instead

Re: [PATCH v8] can-dev: add len8_dlc support for various CAN adapters

2020-11-11 Thread Stefan Mätje
Hi Oliver, I would like to jump on the rolling train for the Classical CAN driver in - esd_usb2 that supports the esd CAN-USB/2 and CAN-USB/Micro devices and add the CAN_CTRLMODE_CC_LEN8_DLC capability. At least I could do some tests with both devices. Am I right with the assumption that your p

Re: [PATCH v5 net-nex 2/5] net: page_pool: add bulk support for ptr_ring

2020-11-11 Thread Jesper Dangaard Brouer
On Wed, 11 Nov 2020 11:43:31 +0100 Lorenzo Bianconi wrote: > > Lorenzo Bianconi wrote: > > > Introduce the capability to batch page_pool ptr_ring refill since it is > > > usually run inside the driver NAPI tx completion loop. > > > > > > Suggested-by: Jesper Dangaard Brouer > > > Co-developed

Re: [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-11 Thread Grygorii Strashko
On 07/11/2020 17:08, Richard Cochran wrote: On Fri, Nov 06, 2020 at 03:56:45PM +0800, Wang Qing wrote: We always have to update the value of ret, otherwise the error value may be the previous one. Signed-off-by: Wang Qing Acked-by: Richard Cochran Following Richard's comments: Revi

RE: [PATCH net-next] enetc: Workaround for MDIO register access issue

2020-11-11 Thread Claudiu Manoil
>-Original Message- >From: Jakub Kicinski [...] > >Please check for new sparse warnings. I see... __iomem missing. Thanks.

pull-request: can 2020-11-11

2020-11-11 Thread Marc Kleine-Budde
Hello, after v5.10-rc1 the flexcan bindings were converted to yaml. This causes several unneeded regressions on i.MX53 based boards and/or SoC specifying the fsl,stop-mode property in their flexcan node. This series fixes these problems by first updating the affected i.MX SoC dtsi files and then

[net v2 4/4] dt-bindings: can: fsl,flexcan.yaml: fix fsl,stop-mode

2020-11-11 Thread Marc Kleine-Budde
The fsl,stop-mode property is a phandle-array and should consist of one phandle and two 32 bit integers, e.g.: fsl,stop-mode = <&gpr 0x34 28>; This patch fixes the following errors, which shows up during a dtbs_check: arch/arm/boot/dts/imx6dl-apf6dev.dt.yaml: can@209: fsl,stop-mode: [[1,

[net v2 1/4] ARM: dts: imx: fix can fsl,stop-mode

2020-11-11 Thread Marc Kleine-Budde
Since commit: d9b081e3fc4b can: flexcan: remove ack_grp and ack_bit handling from driver the 4th and 5th value of the property "fsl,stop-mode" aren't used anymore. With the conversion of the flexcan binding to yaml this raises the following error during dtbs_check: arch/arm/boot/dts/imx6dl-a

[net v2 2/4] ARM: dts: imx: Change flexcan node name to "can"

2020-11-11 Thread Marc Kleine-Budde
Change i.MX SoCs nand node name from "flexcan" to "can" to be compliant with yaml schema, it requires the nodename to be "can". This fixes the following error found by dtbs_check: arch/arm/boot/dts/imx6dl-apf6dev.dt.yaml: flexcan@209: $nodename:0: 'flexcan@209' does not match '^can(@.*)?$

[net v2 3/4] dt-bindings: can: fsl,flexcan.yaml: fix compatible for i.MX35 and i.MX53

2020-11-11 Thread Marc Kleine-Budde
As both the i.MX35 and i.MX53 flexcan IP cores are compatible to the i.MX25, they are listed as: compatible = "fsl,imx35-flexcan", "fsl,imx25-flexcan"; and: compatible = "fsl,imx53-flexcan", "fsl,imx25-flexcan"; in the SoC device trees. This patch fixes the following errors, which show

Re: [PATCH 04/10] ARM: dts: BCM5301X: Add a default compatible for switch node

2020-11-11 Thread Rafał Miłecki
On 10.11.2020 04:31, Florian Fainelli wrote: Provide a default compatible string which is based on the 53010 SRAB compatible, this allows us to have sane defaults and silences the following warnings: arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: ethernet-switch@18007000: compatible: 'oneOf' c

[PATCH v2 net-next 1/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-11 Thread Tobias Waldekranz
Ethertype DSA encodes exactly the same information in the DSA tag as the non-ethertype variety. So refactor out the common parts and reuse them for both protocols. This is ensures tag parsing and generation is always consistent across all mv88e6xxx chips. While we are at it, explicitly deal with

[PATCH v2 net-next 2/2] net: dsa: tag_dsa: Use a consistent comment style

2020-11-11 Thread Tobias Waldekranz
Use a consistent style of one-line/multi-line comments throughout the file. Signed-off-by: Tobias Waldekranz --- net/dsa/tag_dsa.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/net/dsa/tag_dsa.c b/net/dsa/tag_dsa.c index b44b75a4c809..4d5d605f0

Re: [PATCH v15 3/9] ptp: Reorganize ptp_kvm module to make it arch-independent.

2020-11-11 Thread kernel test robot
Hi Jianyong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc3 next-2020] [cannot apply to tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note

[PATCH v2 net-next 0/2] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-11 Thread Tobias Waldekranz
The first commit does the heavy lifting of actually fusing tag_dsa.c and tag_edsa.c. Second commit just follows up with some clean up of existing comments. v1 -> v2: - Fixed some grammar and whitespace errors. - Removed unnecessary default value in Kconfig. - Removed unnecessary #ifdef. -

[no subject]

2020-11-11 Thread Системный администратор
ВНИМАНИЕ; Ваш почтовый ящик превысил лимит хранилища, который составляет 5 ГБ, определенный администратором, который в настоящее время работает с 10,9 ГБ, вы не сможете отправлять или получать новую почту, пока не подтвердите свой почтовый ящик снова. Для повторной проверки вашего почтового ящи

Re: [PATCH v3 2/2] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml

2020-11-11 Thread Marc Kleine-Budde
On 11/10/20 4:43 PM, Rob Herring wrote: > On Thu, Oct 22, 2020 at 2:52 AM Oleksij Rempel > wrote: >> >> In order to automate the verification of DT nodes convert >> fsl-flexcan.txt to fsl,flexcan.yaml >> >> Signed-off-by: Oleksij Rempel >> Link: >> https://lore.kernel.org/r/20201016073315.16232

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Grygorii Strashko
hi Jakub, On 11/11/2020 14:32, Richard Cochran wrote: On Wed, Nov 11, 2020 at 05:24:41PM +0800, Wang Qing wrote: We always have to update the value of ret, otherwise the error value may be the previous one. And ptp_clock_register() never return NULL when PTP_1588_CLOCK enable. NAK. Your

Re: [PATCH] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers

2020-11-11 Thread Tobias Waldekranz
On Tue Nov 10, 2020 at 8:41 PM CET, Florian Fainelli wrote: > > > On 11/10/2020 1:13 AM, Tobias Waldekranz wrote: > > Ethertype DSA encodes exactly the same information in the DSA tag as > > the non-ethertype variety. So refactor out the common parts and reuse > > them for both protocols. > > > >

Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

2020-11-11 Thread kernel test robot
Hi Jianyong, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.10-rc3 next-2020] [cannot apply to tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[PATCH v3 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-11 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v2->v3: add 'err = 0' before successful return v1->v2: use cleanup tag instead of rep

Re: [PATCH v8] can-dev: add len8_dlc support for various CAN adapters

2020-11-11 Thread Marc Kleine-Budde
On 11/11/20 10:59 AM, Oliver Hartkopp wrote: > Support the Classical CAN raw DLC functionality to send and receive DLC > values from 9 .. 15 on various Classical CAN capable CAN network drivers: > > - sja1000 > - gs_usb > - pcan_usb > - pcan_usb_fd > - usb_8dev > > Signed-off-by: Oliver Hartkopp

[PATCH net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-11 Thread Wang Hai
If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/core/devlink.c | 4 +++- 1 file change

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Richard Cochran
On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: > > Following Richard's comments v1 of the patch has to be applied [1]. > I've also added my Reviewed-by there. > > [1] https://lore.kernel.org/patchwork/patch/1334067/ +1 Jakub, can you please take the original v1 of this patch

[net] net: phy: mscc: adjust the phy support for PTP and MACsec

2020-11-11 Thread Steen Hegelund
The MSCC PHYs selected for PTP and MACSec was not correct - PTP - Add VSC8572 and VSC8574 - MACsec - Removed VSC8575 The relevant datasheets can be found here: - VSC8572: https://www.microchip.com/wwwproducts/en/VSC8572 - VSC8574: https://www.microchip.com/wwwproducts/en/VSC8574 -

Re: [net] net: phy: mscc: adjust the phy support for PTP and MACsec

2020-11-11 Thread Antoine Tenart
Hi Steen! Either this is a fix and it would need a Fixes: tag in addition to the Signed-off-by: one (you can have a look at the git history to see what is the format); or the patch is not a fix and then it should have [net-next] in its subject instead of [net]. Please have a look at the relevant

Re: linux-next: build warning after merge of the bpf-next tree

2020-11-11 Thread Qian Cai
On Wed, 2020-11-11 at 12:01 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the bpf-next tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > kernel/bpf/btf.c:4481:20: warning: 'btf_parse_module' defined but not used [- > Wunused-function] > 4481 | sta

Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector

2020-11-11 Thread Santucci Pierpaolo
Hi Jakub, thanks for your reply. Let me explain the problem with an example. Please consider the PCAP file: https://github.com/named-data/ndn-tools/blob/master/tests/dissect-wireshark/ipv6-udp-fragmented.pcap Let's assume that the dissector is invoked without the flag: BPF_FLOW_DISSECTOR_F_STOP_

Re: [RFC PATCH net-next 3/3] net: dsa: listen for SWITCHDEV_{FDB,DEL}_ADD_TO_DEVICE on foreign bridge neighbors

2020-11-11 Thread Alexandra Winter
On 11.11.20 11:36, Vladimir Oltean wrote: > Hi Alexandra, > > On Wed, Nov 11, 2020 at 11:13:03AM +0100, Alexandra Winter wrote: >> On 08.11.20 18:23, Vladimir Oltean wrote: >>> On Sun, Nov 08, 2020 at 10:09:25PM +0800, DENG Qingfang wrote: Can it be turned off for switches that support SA

KASAN: use-after-free Read in ath9k_hif_usb_reg_in_cb

2020-11-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:407ab579 Merge tag 'for-linus' of git://git.kernel.org/pub.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=143b796650 kernel config: https://syzkaller.appspot.com/x/.config?x=f9aa2432c01bcb1f das

Fwd: net: fec: rx descriptor ring out of order

2020-11-11 Thread Kegl Rohit
Hello! We are using a imx6q platform. The fec interface is used to receive a continuous stream of custom / raw ethernet packets. The packet size is fixed ~132 bytes and they get sent every 250µs. While testing I observed spontaneous packet delays from time to time. After digging down deeper I thi

Re: [PATCH v15 3/9] ptp: Reorganize ptp_kvm module to make it arch-independent.

2020-11-11 Thread kernel test robot
Hi Jianyong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc3 next-2020] [cannot apply to tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH v3 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-11 Thread Michal Rostecki
On 11/11/20 2:54 PM, Wang Hai wrote: progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v2->v3: add 'err = 0' before successful return

Re: Hardware time stamping support for AF_XDP applications

2020-11-11 Thread Jesper Dangaard Brouer
On Tue, 10 Nov 2020 23:53:41 + "Patel, Vedang" wrote: > Hi Saeed, > > > On Nov 10, 2020, at 3:32 PM, Saeed Mahameed wrote: > > > > On Tue, 2020-11-10 at 22:44 +, Patel, Vedang wrote: > >> [Sorry if you got the email twice. Resending because it was rejected > >> by netdev for contain

Re: [PATCH v4 net] net: udp: fix Fast/frag0 UDP GRO

2020-11-11 Thread Willem de Bruijn
On Wed, Nov 11, 2020 at 6:29 AM Alexander Lobakin wrote: > > From: Willem de Bruijn > Date: Tue, 10 Nov 2020 13:49:56 -0500 > > > On Mon, Nov 9, 2020 at 7:29 PM Alexander Lobakin wrote: > >> > >> From: Alexander Lobakin > >> Date: Tue, 10 Nov 2020 00:17:18 + > >> > >>> While testing UDP GSO

BUG: unable to handle kernel paging request in bpf_trace_run4

2020-11-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c6bde958 bpf: Lift hashtab key_size limit git tree: bpf-next console output: https://syzkaller.appspot.com/x/log.txt?x=159f611a50 kernel config: https://syzkaller.appspot.com/x/.config?x=58a4ca757d776bfe dashboard link: https:

[PATCH net-next] selftests: set conf.all.rp_filter=0 in bareudp.sh

2020-11-11 Thread Guillaume Nault
When working on the rp_filter problem, I didn't realise that disabling it on the network devices didn't cover all cases: rp_filter could also be enabled globally in the namespace, in which case it would drop packets, even if the net device has rp_filter=0. Fixes: 1ccd58331f6f ("selftests: disable

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-11 Thread Daniel Borkmann
On 11/11/20 12:02 PM, Toke Høiland-Jørgensen wrote: Alexei Starovoitov writes: On Mon, Nov 09, 2020 at 09:09:44PM -0700, David Ahern wrote: On 11/8/20 6:45 PM, Alexei Starovoitov wrote: I don't understand why on one side you're pointing out existing quirkiness with bpf usability while at the

Re: Fwd: net: fec: rx descriptor ring out of order

2020-11-11 Thread Eric Dumazet
On 11/11/20 3:27 PM, Kegl Rohit wrote: > Hello! > > We are using a imx6q platform. > The fec interface is used to receive a continuous stream of custom / > raw ethernet packets. The packet size is fixed ~132 bytes and they get > sent every 250µs. > > While testing I observed spontaneous packet

RE: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are coherent

2020-11-11 Thread Madalin Bucur
> -Original Message- > From: linux-arm-kernel On > Behalf Of Shawn Guo > To: Madalin Bucur (OSS) > Subject: Re: [PATCH] arm64: dts: fsl: DPAA FMan DMA operations are > coherent > > On Mon, Oct 05, 2020 at 03:46:39PM +0300, Madalin Bucur wrote: > > Although the DPAA 1 FMan operations are

Re: [PATCH net] net: lan78xx: Disable hardware vlan filtering in promiscuous mode

2020-11-11 Thread Jakub Kicinski
On Tue, 10 Nov 2020 16:39:58 +0100 Markus Blöchl wrote: > The rx-vlan-filter feature flag prevents unexpected tagged frames on > the wire from reaching the kernel in promiscuous mode. > Disable this offloading feature in the lan7800 controller whenever > IFF_PROMISC is set and make sure that the ha

Re: [PATCH net] net: lan78xx: Disable hardware vlan filtering in promiscuous mode

2020-11-11 Thread Florian Fainelli
On 11/11/2020 7:43 AM, Jakub Kicinski wrote: > On Tue, 10 Nov 2020 16:39:58 +0100 Markus Blöchl wrote: >> The rx-vlan-filter feature flag prevents unexpected tagged frames on >> the wire from reaching the kernel in promiscuous mode. >> Disable this offloading feature in the lan7800 controller wh

Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR

2020-11-11 Thread Jakub Kicinski
On Wed, 11 Nov 2020 05:55:58 -0800 Richard Cochran wrote: > On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: > > > > Following Richard's comments v1 of the patch has to be applied [1]. > > I've also added my Reviewed-by there. > > > > [1] https://lore.kernel.org/patchwork/patch/

Re: [PATCH net v2] net: phy: spi_ks8995: Do not overwrite SPI mode flags

2020-11-11 Thread Sven Van Asbroeck
A spi core fix has been accepted which makes this patch unnecessary. https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?id=766c6b63aa044e84b045803b40b14754d69a2a1d On Tue, Nov 10, 2020 at 9:20 AM Sven Van Asbroeck wrote: > > > This driver makes sure the underlying SPI bus is

  1   2   3   >