> Note that as a side-effect, the devicetree phy mode now no longer
> has a default, and always needs to be specified explicitly (via
> 'phy-connection-type').
That sounds like it could break systems. Why do you do this?
Andrew
From: Min Li
Refactor idt82p33_xfer and use i2c_master_send for write operation.
Because some I2C controllers are only working with single-burst write
transaction.
Signed-off-by: Min Li
---
drivers/ptp/ptp_idt82p33.c | 52 +-
drivers/ptp/ptp_idt82p33
From: Min Li
Use div_s64 so that the neg_adj is not needed.
Signed-off-by: Min Li
---
drivers/ptp/ptp_idt82p33.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c
index b1528a0..e970379d 100644
--- a/drivers/pt
From: Min Li
Add idt82p33_adjphase() to support PHC write phase mode.
Signed-off-by: Min Li
---
drivers/ptp/ptp_idt82p33.c | 226 -
drivers/ptp/ptp_idt82p33.h | 2 +
2 files changed, 164 insertions(+), 64 deletions(-)
diff --git a/drivers/ptp/ptp_
Allen Pais writes:
>>
>> This series converts the remaining drivers to use new
>> tasklet_setup() API.
>>
>> The patches are based on wireless-drivers-next (c2568c8c9e63)
>
> Is this series queue? I haven't seen any email. This is the last
> series as part of the tasklet conversion effort.
They
Hi Andrew, many thanks for looking at this patch !
On Wed, Nov 4, 2020 at 11:27 AM Andrew Lunn wrote:
>
> > Note that as a side-effect, the devicetree phy mode now no longer
> > has a default, and always needs to be specified explicitly (via
> > 'phy-connection-type').
>
> That sounds like it cou
On 11/4/20 4:51 AM, Eric Dumazet wrote:
>
>
> On 11/4/20 1:36 PM, Matthew Wilcox wrote:
>> On Wed, Nov 04, 2020 at 09:50:30AM +0100, Eric Dumazet wrote:
>>> On 11/4/20 2:16 AM, Rama Nichanamatlu wrote:
> Thanks for providing the numbers. Do you think that dropping (up to)
> 7 packets
On Wed, Nov 04, 2020 at 11:01:47AM -0500, min.li...@renesas.com wrote:
> From: Min Li
>
> Add idt82p33_adjphase() to support PHC write phase mode.
>
> Signed-off-by: Min Li
Acked-by: Richard Cochran
On Wed, Nov 04, 2020 at 11:01:48AM -0500, min.li...@renesas.com wrote:
> From: Min Li
>
> Refactor idt82p33_xfer and use i2c_master_send for write operation.
> Because some I2C controllers are only working with single-burst write
> transaction.
>
> Signed-off-by: Min Li
Acked-by: Richard Cochr
>-Original Message-
>From: Eric Dumazet
>Sent: Tuesday, November 3, 2020 8:16 PM
>To: Vladimir Oltean ; Claudiu Manoil
>
>Cc: Jakub Kicinski ; netdev@vger.kernel.org; David S .
>Miller ; james.jur...@ametek.com
>Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
>
On Thu, Oct 15, 2020 at 06:09:14AM +, Song Liu wrote:
>
>
> > On Oct 13, 2020, at 2:56 PM, Andrii Nakryiko
> > wrote:
>
> [...]
>
> >
> > I'd go with Kconfig + bpf_core_enum_value(), as it's shorter and
> > nicer. This compiles and works with my Kconfig, but I haven't checked
> > with CO
On Wed, Nov 04, 2020 at 11:01:49AM -0500, min.li...@renesas.com wrote:
> From: Min Li
>
> Use div_s64 so that the neg_adj is not needed.
Back in the day, I coded the neg_adj because there was some issue with
signed 64 bit division that I can't recall now. Either div_s64 didn't
exist or it was b
On 04/11/20 2:16 AM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 23:32:20 +0530 Rohit Maheshwari wrote:
Creating SKB per tls record and freeing the original one causes
panic. There will be race if connection reset is requested. By
freeing original skb, refcnt will be decremented and that means,
On Wed, Nov 04, 2020 at 11:39:47AM -0500, Sven Van Asbroeck wrote:
> Hi Andrew, many thanks for looking at this patch !
>
> On Wed, Nov 4, 2020 at 11:27 AM Andrew Lunn wrote:
> >
> > > Note that as a side-effect, the devicetree phy mode now no longer
> > > has a default, and always needs to be sp
From: Ioana Ciornei
The dpaa2-ethsw supports only one Rx queue that is shared by all switch
ports. This means that information about which port was the ingress port
for a specific frame needs to be passed in metadata. In our case, the
Flow Context (FLC) field from the frame descriptor holds this
From: Ioana Ciornei
Setup interrupts on the control interface queues. We do not force an
exact affinity between the interrupts received from a specific queue and
a cpu.
Also, the DPSW object version is incremented since the
dpsw_ctrl_if_set_queue() API is introduced in the v8.4 object
(first see
From: Ioana Ciornei
Introduce a new structure to hold all necessary info related to an RX
queue for the control interface and populate the FQ IDs.
We only have one Rx queue and one Tx confirmation queue on the control
interface, both shared by all the switch ports.
Signed-off-by: Ioana Ciornei
From: Ioana Ciornei
The DPAA2 Switch is not capable to handle traffic in a VLAN unaware
fashion, thus the previous handling of both the accepted upper devices
and the SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING flag was wrong.
Fix this by checking if the bridge that we are joining is indeed VLAN
awa
From: Ioana Ciornei
Enable the CTRL_IF of the switch object, now that all the pieces are in
place (buffer and queue management, interrupts, NAPI instances etc).
Signed-off-by: Ioana Ciornei
---
drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 2 ++
drivers/staging/fsl-dpaa2/ethsw/dpsw.c | 37
From: Ioana Ciornei
Allocate and setup a buffer pool, needed on the Rx path of the control
interface. Also, define the Rx buffer size seen by the WRIOP from the
PAGE_SIZE buffers seeded.
Signed-off-by: Ioana Ciornei
---
drivers/staging/fsl-dpaa2/ethsw/dpsw-cmd.h | 12 +++
drivers/staging/fsl-d
From: Ioana Ciornei
Implement the .ndo_start_xmit() callback for the switch port interfaces.
For each of the switch ports, gather the corresponding queue
destination ID (QDID) necessary for Tx enqueueing.
We'll reserve 64 bytes for software annotations, where we keep a skb
backpointer used on th
From: Ioana Ciornei
On the Rx path, when a pull-dequeue operation is performed on a
software portal, available frame descriptors are put in a ring - a DMA
memory storage - for further usage. Create the needed rings for both
frame queues used on the control interface.
Signed-off-by: Ioana Ciornei
From: Ioana Ciornei
This patch set adds support for Rx/Tx capabilities on DPAA2 switch port
interfaces as well as fixing up so major blunders in how we take care of
the switching domains. The netdev community considers this as a basic
features, thus it's sent against the staging tree before anyth
From: Ioana Ciornei
Until now, the DPAA2 switch was not capable to properly setup it's
switching domains depending on the existence, or lack thereof, of a
upper bridge device. This meant that all switch ports of a DPSW object
were switching by default even though they were not under the same
brid
Hi,
On Wed, Sep 9, 2020 at 11:14 AM Daniele Palmas wrote:
>
> Add default rx_urb_size to support QMAP download data aggregation
> without needing additional setup steps in userspace.
>
> The value chosen is the current highest one seen in available modems.
>
> The patch has the side-effect of fix
On Wed, Nov 4, 2020 at 11:55 AM Andrew Lunn wrote:
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/net/ethernet/microchip/lan743x_main.c?h=v5.9.3&id=6f197fb63850b26ef8f70f1bfe5900e377910a5a
>
> If you look at that patch, you see:
>
> - ret = phy_connect_
On 04/11/20 2:21 AM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 23:32:22 +0530 Rohit Maheshwari wrote:
There could be a case where ACK for tls exchanges prior to start
marker is missed out, and by the time tls is offloaded. This pkt
should not be discarded and handled carefully. It could be
pla
upport for high speed interface")?
Tell us if you saw it on other platforms or if you couldn't reproduce it.
[..]
Linux version 5.10.0-rc2-next-20201104 (root@linux-ci-43h78-cjbps)
(arm-linux-gnueabihf-gcc (GNU Toolchain for the A-profile Architecture
8.3-2019.03 (arm-rel-8.36)) 8.3.0, G
On Tue, 2020-11-03 at 08:52 -0800, Jakub Kicinski wrote:
> On Tue, 03 Nov 2020 16:22:07 +0100 Paolo Abeni wrote:
> > The relevant use case is an host running containers (with the related
> > orchestration tools) in a RT environment. Virtual devices (veths, ovs
> > ports, etc.) are created by the or
On 04.11.20 17:02, Jakub Kicinski wrote:
On Wed, 4 Nov 2020 15:59:25 +0100 Oliver Hartkopp wrote:
On 04.11.20 09:16, Eric Dumazet wrote:
So skb_orphan(skb) in CAN before calling netif_rx() is better IMO.
Unfortunately you missed the answer from Vincent, why skb_orphan() does
not work he
On 2020-11-04 05:38, Andrew Lunn wrote:
On Wed, Nov 04, 2020 at 09:06:07AM +, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
from drivers/net/ethernet/ibm/ibmvnic.c:35:
inlined from ‘handle_vpd_rsp’ at
drivers/net/ethernet/ibm/ibmvnic.c:4124:3:
drivers/net/ethernet/ib
On 2020-11-04 01:06, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
from drivers/net/ethernet/ibm/ibmvnic.c:35:
inlined from ‘handle_vpd_rsp’ at
drivers/net/ethernet/ibm/ibmvnic.c:4124:3:
drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter
or member 'hdr_
On Sun, Nov 01, 2020 at 02:51:00PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> In preparation of removing the .ack_interrupt() callback, we must replace
> its occurrences (aka phy_clear_interrupt), from the 2 places where it is
> called from (phy_enable_interrupts and phy_disable_interr
On Sun, Nov 01, 2020 at 02:50:59PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> In an attempt to actually support shared IRQs in phylib, we now move the
> responsibility of triggering the phylib state machine or just returning
> IRQ_NONE, based on the IRQ status register, to the PHY driv
On Wed, Nov 04, 2020 at 06:36:08PM +0100, Paolo Abeni wrote:
> On Tue, 2020-11-03 at 08:52 -0800, Jakub Kicinski wrote:
> > On Tue, 03 Nov 2020 16:22:07 +0100 Paolo Abeni wrote:
> > > The relevant use case is an host running containers (with the related
> > > orchestration tools) in a RT environmen
On Wed, Nov 4, 2020 at 4:00 PM Mika Westerberg
wrote:
>
> +#define DMA_TEST_DATA_PATTERN 0x0123456789abcdefLL
Have you considered making it configurable? For mem test, for example, there is
a reason to try different patterns. Not sure if it's relevant here.
On Wed, Nov 4, 2020 at 4:00 PM Mika Westerberg
wrote:
>
> Hi all,
>
> This series adds a new Thunderbolt service driver that can be used on
> manufacturing floor to test that each Thunderbolt/USB4 port is functional.
> It can be done either using a special loopback dongle that has RX and TX
> lane
On Wed, 4 Nov 2020 10:00:08 +0100 Steffen Klassert wrote:
> 1) Fix packet receiving of standard IP tunnels when the xfrm_interface
>module is installed. From Xin Long.
>
> 2) Fix a race condition between spi allocating and hash list
>resizing. From zhuoliang zhang.
Pulled, thank you!
On Tue, Nov 03, 2020 at 12:29:07PM +0800, Hangbin Liu wrote:
> In comment 173ca26e9b51 ("samples/bpf: add comprehensive ipip, ipip6,
> ip6ip6 test") we added ip6ip6 test for bpf tunnel testing. But in commit
> 933a741e3b82 ("selftests/bpf: bpf tunnel test.") when we moved it to
> the current folder
On Tue, 3 Nov 2020 23:06:09 +0100 Marc Kleine-Budde wrote:
> Hello Jakub, hello David,
>
> here's a pull request for net/master consisting of 27 patches for net/master.
Pulled, thanks!
On Wed, 04 Nov 2020 16:51:45 +0100, Jerome Pouiller wrote:
> From: Jérôme Pouiller
>
> Signed-off-by: Jérôme Pouiller
> ---
> .../bindings/net/wireless/silabs,wfx.yaml | 131 ++
> 1 file changed, 131 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/ne
On Wed, 4 Nov 2020 14:12:47 +0100 Daniel Borkmann wrote:
> If we would have done lib/bpf.c as a dynamic library back then, we wouldn't be
> where we are today since users might be able to start consuming BPF
> functionality
> just now, don't you agree? This was an explicit design choice back then
On 03.11.20 19:42, Willem de Bruijn wrote:
> Thanks. Yes, this is long overdue.
>
> The hard_header_len issue was also recently discussed in the context
> of GRE in commit fdafed459998 ("ip_gre: set dev->hard_header_len and
> dev->needed_headroom properly").
>
> Question is whether we should rese
On Wed, 04 Nov 2020 18:36:08 +0100 Paolo Abeni wrote:
> On Tue, 2020-11-03 at 08:52 -0800, Jakub Kicinski wrote:
> > On Tue, 03 Nov 2020 16:22:07 +0100 Paolo Abeni wrote:
> > > The relevant use case is an host running containers (with the related
> > > orchestration tools) in a RT environment. Vi
On Wed, Nov 4, 2020 at 12:27 AM Magnus Karlsson
wrote:
>
> On Tue, Nov 3, 2020 at 8:05 PM Andrii Nakryiko
> wrote:
> >
> > On Tue, Nov 3, 2020 at 1:42 AM Magnus Karlsson
> > wrote:
> > >
> > > From: Magnus Karlsson
> > >
> > > Fix a possible use after free in xsk_socket__delete that will happen
On Wed, Nov 4, 2020 at 3:31 PM Heiner Kallweit wrote:
>
> Replace ip_tunnel_get_stats64() with the new identical core fucntion
> dev_get_tstats64().
>
> Signed-off-by: Heiner Kallweit
> ---
> drivers/net/wireguard/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
On Wed, Nov 4, 2020 at 2:30 PM Oliver Herms
wrote:
>
> On 03.11.20 19:42, Willem de Bruijn wrote:
> > Thanks. Yes, this is long overdue.
> >
> > The hard_header_len issue was also recently discussed in the context
> > of GRE in commit fdafed459998 ("ip_gre: set dev->hard_header_len and
> > dev->ne
Check for corner case of port_init failure before using
the port_info pointer.
Fixes: 4d03e00a2140 ("ionic: Add initial ethtool support")
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/eth
On Wed, 4 Nov 2020 22:23:14 +0530 rohit maheshwari wrote:
> On 04/11/20 2:16 AM, Jakub Kicinski wrote:
> > On Fri, 30 Oct 2020 23:32:20 +0530 Rohit Maheshwari wrote:
> >> Creating SKB per tls record and freeing the original one causes
> >> panic. There will be race if connection reset is requeste
On Wed, 4 Nov 2020 22:48:22 +0530 rohit maheshwari wrote:
> On 04/11/20 2:21 AM, Jakub Kicinski wrote:
> > On Fri, 30 Oct 2020 23:32:22 +0530 Rohit Maheshwari wrote:
> >> There could be a case where ACK for tls exchanges prior to start
> >> marker is missed out, and by the time tls is offloaded.
On Wed, Nov 04, 2020 at 11:10:51AM -0800, Nick Desaulniers wrote:
> bpftrace parses the kernel headers and uses Clang under the hood. Remove
> the version check when __BPF_TRACING__ is defined (as bpftrace does) so
> that this tool can continue to parse kernel headers, even with older
> clang sourc
On Wed, Nov 4, 2020 at 11:17 AM Jakub Kicinski wrote:
>
> On Wed, 4 Nov 2020 14:12:47 +0100 Daniel Borkmann wrote:
> > If we would have done lib/bpf.c as a dynamic library back then, we wouldn't
> > be
> > where we are today since users might be able to start consuming BPF
> > functionality
> >
On Wed, Nov 4, 2020 at 3:26 AM David Verbeiren
wrote:
>
> Zero-fill element values for all other cpus than current, just as
> when not using prealloc. This is the only way the bpf program can
> ensure known initial values for all cpus ('onallcpus' cannot be
> set when coming from the bpf program).
On Wed, Nov 4, 2020 at 8:46 AM Jiri Olsa wrote:
>
> On Thu, Oct 15, 2020 at 06:09:14AM +, Song Liu wrote:
> >
> >
> > > On Oct 13, 2020, at 2:56 PM, Andrii Nakryiko
> > > wrote:
> >
> > [...]
> >
> > >
> > > I'd go with Kconfig + bpf_core_enum_value(), as it's shorter and
> > > nicer. This c
On Wed, 4 Nov 2020 14:14:24 +0200 Vladimir Oltean wrote:
> To my eyes this is easier to digest.
+1
On Wed, Nov 4, 2020 at 1:47 AM wrote:
>
> From: Mariusz Dudek
>
> Add support for separation of eBPF program load and xsk socket
> creation.
>
> This is needed for use-case when you want to privide as little
> privileges as possible to the data plane application th
On Wed, 4 Nov 2020 03:58:34 +0200 Vladimir Oltean wrote:
> The only problem?
> Throughput is actually a few Mbps worse, and this is 100% reproducible,
> doesn't appear to be measurement error.
Is there any performance scaling enabled? IOW CPU freq can vary?
On 04/11/2020 03:11, Alexei Starovoitov wrote:
> The user will do 'tc -V'. Does version mean anything from bpf loading pov?
> It's not. The user will do "ldd `which tc`" and then what?
Is it beyond the wit of man for 'tc -V' to output somethingabout
libbpf version?
Other libraries seem to solve th
On Wed, 4 Nov 2020 12:21:41 +0200 Tariq Toukan wrote:
> With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be
> logically done when HW_CSUM offload is off.
Right. Do you expect drivers to nack clearing NETIF_F_HW_TLS_TX when
there are active connections, then? I don't think NFP does
On Wed, Nov 04, 2020 at 06:57:17PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> Implement the .ndo_start_xmit() callback for the switch port interfaces.
> For each of the switch ports, gather the corresponding queue
> destination ID (QDID) necessary for Tx enqueueing.
>
> We'll reserve
On Wed, 4 Nov 2020 06:53:11 -0500 menglong8.d...@gmail.com wrote:
> From: Menglong Dong
>
> The initialization for err with 0 seems useless, as it is soon updated
> with -ENOMEM. So, we can init err with -ENOMEM.
>
> Signed-off-by: Menglong Dong
> ---
> drivers/net/macvlan.c | 3 +--
> 1 file
On Wed, 4 Nov 2020 16:40:27 +0100 Andrea Parri (Microsoft) wrote:
> From: Andres Beltran
>
> Currently, pointers to guest memory are passed to Hyper-V as
> transaction IDs in netvsc. In the face of errors or malicious
> behavior in Hyper-V, netvsc should not expose or trust the transaction
> IDs
On Wed, 4 Nov 2020 13:43:48 -0800 Jakub Kicinski wrote:
> On Wed, 4 Nov 2020 16:40:27 +0100 Andrea Parri (Microsoft) wrote:
> > From: Andres Beltran
> >
> > Currently, pointers to guest memory are passed to Hyper-V as
> > transaction IDs in netvsc. In the face of errors or malicious
> > behavior
Andrew,
On Wed, Nov 4, 2020 at 11:55 AM Andrew Lunn wrote:
> If you look at that patch, you see:
>
> - ret = phy_connect_direct(netdev, phydev,
> -lan743x_phy_link_status_change,
> -PHY_INTERFACE_MODE_GMII);
> - if (ret)
On Wed, 4 Nov 2020 11:01:47 -0500 min.li...@renesas.com wrote:
> From: Min Li
>
> Add idt82p33_adjphase() to support PHC write phase mode.
>
> Signed-off-by: Min Li
This appears to break the build. Each patch must build, otherwise we're
risking breaking builds when people bisect bugs with git
On 2020-11-03 15:09, Jakub Kicinski wrote:
On Sat, 31 Oct 2020 04:46:45 -0500 Lijun Pan wrote:
Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so
linkwatch_event can run") introduced do_change_param_reset function to
solve the rtnl lock issue. Majority of the code in
do_change_para
On Wed, 4 Nov 2020 11:08:47 -0500 Sven Van Asbroeck wrote:
> Tested-by: Sven Van Asbroeck # lan7430
> Signed-off-by: Sven Van Asbroeck
Not a big deal but if you have to change the patch could you make sure
your email address is spelled the same in the From line and other tags?
On Wed, Nov 04, 2020 at 12:50:25PM -0800, Andrii Nakryiko wrote:
> On Wed, Nov 4, 2020 at 8:46 AM Jiri Olsa wrote:
> >
> > On Thu, Oct 15, 2020 at 06:09:14AM +, Song Liu wrote:
> > >
> > >
> > > > On Oct 13, 2020, at 2:56 PM, Andrii Nakryiko
> > > > wrote:
> > >
> > > [...]
> > >
> > > >
> >
On Wed, 4 Nov 2020 16:56:32 +0800 we...@ucloud.cn wrote:
> From: wenxu
>
> Currently kernel tc subsystem can do conntrack in cat_ct. But when several
> fragment packets go through the act_ct, function tcf_ct_handle_fragments
> will defrag the packets to a big one. But the last action will redire
On Tue, 3 Nov 2020 11:18:22 -0800 Saeed Mahameed wrote:
> From: Maor Dickman
>
> Modify header actions are allocated during parse tc actions and only
> freed during the flow creation, however, on error flow the allocated
> memory is wrongly unfreed.
>
> Fix this by calling dealloc_mod_hdr_action
On Tue, 3 Nov 2020 11:47:35 -0800 Saeed Mahameed wrote:
> From: Vladyslav Tarasiuk
>
> Stop room is a space that may be taken by WQEs in the SQ during a packet
> transmit. It is used to check if next packet has enough room in the SQ.
> Stop room guarantees this packet can be served and if not, th
On Wed, Nov 04, 2020 at 06:57:19PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> Until now, the DPAA2 switch was not capable to properly setup it's
> switching domains depending on the existence, or lack thereof, of a
> upper bridge device. This meant that all switch ports of a DPSW objec
On Fri, Oct 30, 2020 at 08:56:55PM +0100, Andrew Lunn wrote:
> On Fri, Oct 30, 2020 at 12:29:48PM -0500, Dan Murphy wrote:
> > Per the 802.3cg spec the 10base T1L can operate at 2 different
> > differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
> > drive that output is dependent
On Wed, Nov 4, 2020 at 1:16 PM Edward Cree wrote:
>
> On 04/11/2020 03:11, Alexei Starovoitov wrote:
> > The user will do 'tc -V'. Does version mean anything from bpf loading pov?
> > It's not. The user will do "ldd `which tc`" and then what?
> Is it beyond the wit of man for 'tc -V' to output som
On Wed, 04 Nov 2020 13:56:09 -0800 drt wrote:
> On 2020-11-03 15:09, Jakub Kicinski wrote:
> > On Sat, 31 Oct 2020 04:46:45 -0500 Lijun Pan wrote:
> >> Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so
> >> linkwatch_event can run") introduced do_change_param_reset function to
> >>
Andrii Nakryiko writes:
> Some of the most important APIs of libbpf are, arguably,
> bpf_object__open() and bpf_object__load(). They accept a BPF ELF file,
> do some preprocessing and in the end load BPF instructions into the
> kernel for verification. But while API doesn't change across libbpf
>
We should be using the multicast sync routines for the
multicast filters.
Fixes: 1800eee16676 ("net: ionic: Replace in_interrupt() usage.")
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --gi
Change the order of operations in the link_up handling to be
sure that the queues are up and ready before we announce that
the link is up.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --
These updates are a bit of code cleaning and a minor
bit of performance tweaking.
Shannon Nelson (6):
ionic: start queues before announcing link up
ionic: check for link after netdev registration
ionic: add lif quiesce
ionic: batch rx buffer refilling
ionic: use mc sync for multicast fil
Request a link check as soon as the netdev is registered rather
than waiting for the watchdog to go off in order to get the
interface operational a little more quickly.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 ++
1 file changed, 2 insertions(+)
diff
We don't need to refill the rx descriptors on every napi
if only a few were handled. Waiting until we can batch up
a few together will save us a few Rx cycles.
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensando/ionic/ionic_dev.h| 4 +++-
.../net/ethernet/pensando/ionic/ionic_txrx.
With a few more uses of true and false in function calls, we
need to give them some useful names so we can tell from the
calling point what we're doing.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 16
drivers/net/ethernet/pensando/ionic/io
After the queues are stopped, expressly quiesce the lif.
This assures that even if the queues were in an odd state,
the firmware will close up everything cleanly.
Signed-off-by: Shannon Nelson
---
.../net/ethernet/pensando/ionic/ionic_lif.c | 24 +++
1 file changed, 24 insertio
Hi Jakub,
On Wed, Nov 4, 2020 at 4:58 PM Jakub Kicinski wrote:
>
> Not a big deal but if you have to change the patch could you make sure
> your email address is spelled the same in the From line and other tags?
Absolutely, thanks for letting me know about those case differences.
Alexei Starovoitov writes:
> On Wed, Nov 4, 2020 at 1:16 PM Edward Cree wrote:
>>
>> On 04/11/2020 03:11, Alexei Starovoitov wrote:
>> > The user will do 'tc -V'. Does version mean anything from bpf loading pov?
>> > It's not. The user will do "ldd `which tc`" and then what?
>> Is it beyond the
On Tue, 3 Nov 2020 11:18:25 -0800 Saeed Mahameed wrote:
> From: Maxim Mikityanskiy
>
> On resync, the driver calls inet_lookup_established
> (__inet6_lookup_established) that increases sk_refcnt of the socket. To
> decrease it, the driver set skb->destructor to sock_edemux. However, it
> didn't w
On Tue, 3 Nov 2020 11:18:27 -0800 Saeed Mahameed wrote:
> From: Jianbo Liu
>
> Miss path handling of tc multi chain filters (i.e. filters that are
> defined on chain > 0) requires the hardware to communicate to the
> driver the last chain that was processed. This is possible only when
> the hardw
On 04/11/2020 22:10, Alexei Starovoitov wrote:
> On Wed, Nov 4, 2020 at 1:16 PM Edward Cree wrote:
>> On 04/11/2020 03:11, Alexei Starovoitov wrote:
>>> The user will do 'tc -V'. Does version mean anything from bpf loading pov?
>>> It's not. The user will do "ldd `which tc`" and then what?
>> Is i
On Wed, Nov 04, 2020 at 03:09:02PM +0100, Magnus Karlsson wrote:
> From: Magnus Karlsson
>
> Use the new batched xsk interfaces for the Tx path in the i40e driver
> to improve performance. On my machine, this yields a throughput
> increase of 4% for the l2fwd sample app in xdpsock. If we instead
From: Min Li
Use div_s64 so that the neg_adj is not needed.
Signed-off-by: Min Li
---
drivers/ptp/ptp_idt82p33.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c
index b1528a0..e970379d 100644
--- a/drivers/pt
From: Min Li
Refactor idt82p33_xfer and use i2c_master_send for write operation.
Because some I2C controllers are only working with single-burst write
transaction.
Changes since v1:
- Fix broken build.
Signed-off-by: Min Li
---
drivers/ptp/ptp_idt82p33.c | 52 +
From: Min Li
Add idt82p33_adjphase() to support PHC write phase mode.
Changes since v1:
-Fix broken build
Signed-off-by: Min Li
---
drivers/ptp/ptp_idt82p33.c | 224 -
drivers/ptp/ptp_idt82p33.h | 2 +
2 files changed, 163 insertions(+), 63 deleti
On Tue, Nov 3, 2020 at 7:45 AM Jason Gunthorpe wrote:
[..]
> > +MODULE_DEVICE_TABLE(auxiliary, mlx5v_id_table);
> > +
> > +static struct auxiliary_driver mlx5v_driver = {
> > + .name = "vnet",
> > + .probe = mlx5v_probe,
> > + .remove = mlx5v_remove,
> > + .id_table = mlx5v_id_tabl
On Wed, 4 Nov 2020 15:08:57 +0100 Magnus Karlsson wrote:
> From: Magnus Karlsson
>
> Introduce lazy Tx completions when a queue is used for AF_XDP
> zero-copy. In the current design, each time we get into the NAPI poll
> loop we try to complete as many Tx packets as possible from the
> NIC. This
On Wed, 4 Nov 2020 15:33:20 -0800 Jakub Kicinski wrote:
> I feel like this needs a big fat warning somewhere.
>
> It's perfectly fine to never complete TCP packets,
s/TCP/normal XDP/, sorry
> but AF_XDP could be used to implement protocols in user space. What
> if someone wants to implement some
On Wednesday, November 4, 2020 4:38:33 AM MSK Jakub Kicinski wrote:
> On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote:
> > This is the 3rd revision of the patch fix for potential null pointer
> > dereference with lan743x card.
> >
> > The simpliest way to reproduce: boot with bare lan743x an
Change the security_secctx_to_secid interface to use a lsmblob
structure in place of the single u32 secid in support of
module stacking. Change its callers to do the same.
The security module hook is unchanged, still passing back a secid.
The infrastructure passes the correct entry from the lsmblo
Change security_secid_to_secctx() to take a lsmblob as input
instead of a u32 secid. It will then call the LSM hooks
using the lsmblob element allocated for that module. The
callers have been updated as well. This allows for the
possibility that more than one module may be called upon
to translate
On Wed, 4 Nov 2020 18:13:44 -0500 min.li...@renesas.com wrote:
> From: Min Li
>
> Add idt82p33_adjphase() to support PHC write phase mode.
>
> Changes since v1:
> -Fix broken build
One more trivial thing detected by checkpatch:
ERROR: trailing whitespace
#41: FILE: drivers/ptp/ptp_idt82p33.c:1
On Mon, Nov 2, 2020 at 9:41 PM Song Liu wrote:
>
>
>
> > On Nov 2, 2020, at 9:02 PM, Andrii Nakryiko
> > wrote:
> >
> > On Mon, Nov 2, 2020 at 3:24 PM Song Liu wrote:
> >>
> >>
> >>
> >>> On Oct 28, 2020, at 5:58 PM, Andrii Nakryiko wrote:
> >>>
> >>
> >> [...]
> >>
> >>>
> >>> BTF deduplicati
201 - 300 of 394 matches
Mail list logo
