Re: [PATCH 10/12] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours

On Wed, Nov 04, 2020 at 09:06:08AM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function > parameter or member 'irq' not described in 'gelic_card_interrupt' > drivers/net/ethernet/toshiba/ps3_gelic_net

Re: [PATCH 11/12] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters

On Wed, Nov 04, 2020 at 09:06:09AM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/toshiba/spider_net.c:263: warning: Function parameter > or member 'hwdescr' not described in 'spider_net_get_descr_status' > drivers/net/ethernet/toshiba/spider

RE: net: macb: linux-next: null pointer dereference in phylink_major_config()

as possible. >Could it be related to newly included patch >e4e143e26ce8 ("net: macb: add support for high speed interface")? > >Tell us if you saw it on other platforms or if you couldn't reproduce it. > >[..] >Linux version 5.10.0-rc2-next-20201104 (root@linux

[PATCH 04/10] thunderbolt: Add link_speed and link_width to XDomain

From: Isaac Hazan Link speed and link width are needed for checking expected values in case of using a loopback service. Signed-off-by: Isaac Hazan Signed-off-by: Mika Westerberg --- .../ABI/testing/sysfs-bus-thunderbolt | 28 drivers/thunderbolt/switch.c |

[PATCH 05/10] thunderbolt: Add functions for enabling and disabling lane bonding on XDomain

From: Isaac Hazan These can be used by service drivers to enable and disable lane bonding as needed. Signed-off-by: Isaac Hazan Signed-off-by: Mika Westerberg --- drivers/thunderbolt/switch.c | 24 +++-- drivers/thunderbolt/tb.h | 3 ++ drivers/thunderbolt/xdomain.c | 66 ++

[PATCH 02/10] thunderbolt: Find XDomain by route instead of UUID

We are going to represent loops back to the host also as XDomains and they all have the same (host) UUID, so finding them needs to use route string instead. This also requires that we check if the XDomain device is added to the bus before its properties can be updated. Otherwise the remote UUID mig

[PATCH 08/10] thunderbolt: Add support for end-to-end flow control

USB4 spec defines end-to-end (E2E) flow control that can be used between hosts to prevent overflow of a RX ring. We previously had this partially implemented but that code was removed with commit 53f13319d131 ("thunderbolt: Get rid of E2E workaround") with the idea that we add it back properly if t

[PATCH 10/10] MAINTAINERS: Add Isaac as maintainer of Thunderbolt DMA traffic test driver

From: Isaac Hazan I will be maintaining the Thunderbolt DMA traffic test driver. Signed-off-by: Isaac Hazan Signed-off-by: Mika Westerberg --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b516bb34a8d5..fcd84749defd 100644 --- a/MAINTAIN

[PATCH 00/10] thunderbolt: Add DMA traffic test driver

Hi all, This series adds a new Thunderbolt service driver that can be used on manufacturing floor to test that each Thunderbolt/USB4 port is functional. It can be done either using a special loopback dongle that has RX and TX lanes crossed, or by connecting a cable back to the host (for those who

[PATCH 03/10] thunderbolt: Create XDomain devices for loops back to the host

It is perfectly possible to have loops back from the routers to the host, or even from one host port to another. Instead of ignoring these, we create XDomain devices for each. This allows creating services such as DMA traffic test that is used in manufacturing for example. Signed-off-by: Mika West

[PATCH 01/10] thunderbolt: Do not clear USB4 router protocol adapter IFC and ISE bits

These fields are marked as vendor defined in the USB4 spec and should not be modified by the software, so only clear them when we are dealing with pre-USB4 hardware. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/path.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-)

[PATCH 09/10] thunderbolt: Add DMA traffic test driver

From: Isaac Hazan This driver allows sending DMA traffic over XDomain connection. Specifically over a loopback connection using either a Thunderbolt/USB4 cable that is connected back to the host router port, or a special loopback dongle that has RX and TX lines crossed. This can be useful at manu

[PATCH 06/10] thunderbolt: Create debugfs directory automatically for services

This allows service drivers to use it as parent directory if they need to add their own debugfs entries. Signed-off-by: Mika Westerberg --- drivers/thunderbolt/debugfs.c | 24 drivers/thunderbolt/tb.h | 4 drivers/thunderbolt/xdomain.c | 3 +++ include/linux/

[PATCH 07/10] thunderbolt: Make it possible to allocate one directional DMA tunnel

With DMA tunnels it is possible that the service using it does not require bi-directional paths so make RX and TX optional (but of course one of them needs to be set). Signed-off-by: Mika Westerberg --- drivers/thunderbolt/tunnel.c | 50 ++-- 1 file changed, 31 in

[PATCH bpf-next 1/6] i40e: introduce lazy Tx completions for AF_XDP zero-copy

From: Magnus Karlsson Introduce lazy Tx completions when a queue is used for AF_XDP zero-copy. In the current design, each time we get into the NAPI poll loop we try to complete as many Tx packets as possible from the NIC. This is performed by reading the head pointer register in the NIC that tel

[PATCH bpf-next 4/6] xsk: introduce padding between more ring pointers

From: Magnus Karlsson Introduce one cache line worth of padding between the consumer pointer and the flags field as well as between the flags field and the start of the descriptors in all the lockless rings. This so that the x86 HW adjacency prefetcher will not prefetch the adjacent pointer/field

[PATCH bpf-next 2/6] samples/bpf: increment Tx stats at sending

From: Magnus Karlsson Increment the statistics over how many Tx packets have been sent at the time of sending instead of at the time of completion. This as a completion event means that the buffer has been sent AND returned to user space. The packet always gets sent shortly after sendto() is call

[PATCH bpf-next 3/6] i40e: remove unnecessary sw_ring access from xsk Tx

From: Magnus Karlsson Remove the unnecessary access to the software ring for the AF_XDP zero-copy driver. This was used to record the length of the packet so that the driver Tx completion code could sum this up to produce the total bytes sent. This is now performed during the transmission of the

[PATCH bpf-next 5/6] xsk: introduce batched Tx descriptor interfaces

From: Magnus Karlsson Introduce batched descriptor interfaces in the xsk core code for the Tx path to be used in the driver to write a code path with higher performance. This interface will be used by the i40e driver in the next patch. Though other drivers would likely benefit from this new inter

[PATCH bpf-next 0/6] xsk: i40e: Tx performance improvements

Subject: xsk: i40e: Tx performance improvements This patch set improves the performance of mainly the Tx processing of AF_XDP sockets. Though, patch 4 also improves the Rx path. All in all, this patch set improves the throughput of the l2fwd xdpsock application by around 14%. If we just take a loo

[PATCH bpf-next 6/6] i40e: use batched xsk Tx interfaces to increase performance

From: Magnus Karlsson Use the new batched xsk interfaces for the Tx path in the i40e driver to improve performance. On my machine, this yields a throughput increase of 4% for the l2fwd sample app in xdpsock. If we instead just look at the Tx part, this patch set increases throughput with above 20

[PATCH net-next 3/8] netfilter: nft_reject: add reject verdict support for netdev

From: "Jose M. Guisado Gomez" Adds support for reject from ingress hook in netdev family. Both stacks ipv4 and ipv6. With reject packets supporting ICMP and TCP RST. This ability is required in devices that need to REJECT legitimate clients which traffic is forwarded from the ingress hook. Joi

[PATCH net-next 2/8] netfilter: nft_reject: unify reject init and dump into nft_reject

From: "Jose M. Guisado Gomez" Bridge family is using the same static init and dump function as inet. This patch removes duplicate code unifying these functions body into nft_reject.c so they can be reused in the rest of families supporting reject verdict. Signed-off-by: Jose M. Guisado Gomez S

[PATCH net-next 6/8] netfilter: ipset: Expose the initval hash parameter to userspace

From: Jozsef Kadlecsik It makes possible to reproduce exactly the same set after a save/restore. Signed-off-by: Jozsef Kadlecsik Signed-off-by: Pablo Neira Ayuso --- include/uapi/linux/netfilter/ipset/ip_set.h | 2 +- net/netfilter/ipset/ip_set_hash_gen.h| 13 + net/netf

[PATCH net-next 0/8] Netfilter updates for net-next

Hi, The following patchset contains Netfilter updates for net-next: 1) Move existing bridge packet reject infra to nf_reject_{ipv4,ipv6}.c from Jose M. Guisado. 2) Consolidate nft_reject_inet initialization and dump, also from Jose. 3) Add the netdev reject action, from Jose. 4) Allow to co

[PATCH net-next 8/8] netfilter: nft_reject_inet: allow to use reject from inet ingress

Enhance validation to support for reject from inet ingress chains. Note that, reject from inet ingress and netdev ingress differ. Reject packets from inet ingress are sent through ip_local_out() since inet reject emulates the IP layer receive path. So the reject packet follows to classic IP outpu

[PATCH net-next 5/8] netfilter: ipset: Add bucketsize parameter to all hash types

From: Jozsef Kadlecsik The parameter defines the upper limit in any hash bucket at adding new entries from userspace - if the limit would be exceeded, ipset doubles the hash size and rehashes. It means the set may consume more memory but gives faster evaluation at matching in the set. Signed-off

[PATCH net-next 4/8] netfilter: ipset: Support the -exist flag with the destroy command

From: Jozsef Kadlecsik The -exist flag was supported with the create, add and delete commands. In order to gracefully handle the destroy command with nonexistent sets, the -exist flag is added to destroy too. Signed-off-by: Jozsef Kadlecsik Signed-off-by: Pablo Neira Ayuso --- net/netfilter/i

[PATCH net-next 7/8] netfilter: nftables: Add __printf() attribute

From: Andrew Lunn nft_request_module calls vsnprintf() using parameters passed to it. Make the function with __printf() attribute so the compiler can check the format and arguments. Signed-off-by: Andrew Lunn Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 3 ++- 1 file c

[PATCH net-next 1/8] netfilter: nf_reject: add reject skbuff creation helpers

From: "Jose M. Guisado Gomez" Adds reject skbuff creation helper functions to ipv4/6 nf_reject infrastructure. Use these functions for reject verdict in bridge family. Can be reused by all different families that support reject and will not inject the reject packet through ip local out. Signed-

Re: [PATCH] net: bridge: disable multicast while delete bridge

Dear Nik, On Wed, Nov 4, 2020 at 12:26 AM Nikolay Aleksandrov wrote: > > On Mon, 2020-11-02 at 22:38 +0800, Menglong Dong wrote: > > From: Menglong Dong > > > > This commit seems make no sense, as bridge is destroyed when > > br_multicast_dev_del is called. > > > > In commit b1b9d366028f > > ("b

RE: net: macb: linux-next: null pointer dereference in phylink_major_config()

Hi Russell, It seems apart from changes in driver, we also need check for NULL pcs_config below or make pcs_config as mandatory method for registering pcs_ops. 456 if (pl->pcs_ops) { 457 err = pl->pcs_ops->pcs_config(pl->pcs, pl->cur_link_an_mode, 458

Re: [PATCH net] ipv6/netfilter: Discard first fragment not including all headers

On 04.11.2020 14:41, Pablo Neira Ayuso wrote: > Hi, > > On Wed, Nov 04, 2020 at 02:01:28PM +0100, Georg Kohmann wrote: >> Packets are processed even though the first fragment don't include all >> headers through the upper layer header. This breaks TAHI IPv6 Core >> Conformance Test v6LC.1.3.6. >> >

Re: [PATCH 06/10] thunderbolt: Create debugfs directory automatically for services

On Wed, Nov 04, 2020 at 05:00:26PM +0300, Mika Westerberg wrote: > This allows service drivers to use it as parent directory if they need > to add their own debugfs entries. > > Signed-off-by: Mika Westerberg > --- > drivers/thunderbolt/debugfs.c | 24 > drivers/thunderb

[PATCH net-next v2 00/10] net: add and use dev_get_tstats64

It's a frequent pattern to use netdev->stats for the less frequently accessed counters and per-cpu counters for the frequently accessed counters (rx/tx bytes/packets). Add a default ndo_get_stats64() implementation for this use case. Subsequently switch more drivers to use this pattern. v2: - add

Re: [PATCH] net: stmmac: Don't log error message in case of -EPROBE_DEFER.

On 2020-11-04 14:15, Markus Bauer wrote: Remove error messages that might confuse users when error is just -517 / -EPROBE_DEFER. [...] imx-dwmac 30bf.ethernet: Cannot register the MDIO bus imx-dwmac 30bf.ethernet: stmmac_dvr_probe: MDIO bus (id: 0) registration failed [...] FYI we ha

Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header

On Wed, 04 Nov 2020, Andrew Lunn wrote: > On Wed, Nov 04, 2020 at 09:06:04AM +, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter > > or member 'ndev' not described in 'am65_cpsw_timer_set'

[PATCH net-next v2 04/10] ip6_tunnel: switch to dev_get_tstats64

Switch ip6_tunnel to the standard statistics pattern: - use dev->stats for the less frequently accessed counters - use dev->tstats for the frequently accessed counters An additional benefit is that we now have 64bit statistics also on 32bit systems. Signed-off-by: Heiner Kallweit --- net/ipv6/i

[PATCH net-next v2 09/10] ipv4/ipv6: switch to dev_get_tstats64

Replace ip_tunnel_get_stats64() with the new identical core fucntion dev_get_tstats64(). Signed-off-by: Heiner Kallweit --- net/ipv4/ip_gre.c | 6 +++--- net/ipv4/ipip.c| 2 +- net/ipv6/ip6_gre.c | 6 +++--- net/ipv6/sit.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff -

[PATCH net-next v2 06/10] gtp: switch to dev_get_tstats64

Replace ip_tunnel_get_stats64() with the new identical core fucntion dev_get_tstats64(). Signed-off-by: Heiner Kallweit --- drivers/net/gtp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index dc668ed28..4c04e271f 100644 --- a/drivers/

[PATCH net-next v2 03/10] tun: switch to net core provided statistics counters

Switch tun to the standard statistics pattern: - use netdev->stats for the less frequently accessed counters - use netdev->tstats for the frequently accessed per-cpu counters Signed-off-by: Heiner Kallweit --- drivers/net/tun.c | 127 +++--- 1 file changed

[PATCH net-next v2 02/10] net: dsa: use net core stats64 handling

Use netdev->tstats instead of a member of dsa_slave_priv for storing a pointer to the per-cpu counters. This allows us to use core functionality for statistics handling. Reviewed-by: Florian Fainelli Tested-by: Vladimir Oltean Signed-off-by: Heiner Kallweit --- net/dsa/dsa.c | 7 +--

[PATCH net-next v2 05/10] net: switch to dev_get_tstats64

Replace ip_tunnel_get_stats64() with the new identical core fucntion dev_get_tstats64(). Signed-off-by: Heiner Kallweit --- drivers/net/bareudp.c | 2 +- drivers/net/geneve.c | 2 +- drivers/net/vxlan.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bareu

[PATCH net-next v2 01/10] net: core: add dev_get_tstats64 as a ndo_get_stats64 implementation

It's a frequent pattern to use netdev->stats for the less frequently accessed counters and per-cpu counters for the frequently accessed counters (rx/tx bytes/packets). Add a default ndo_get_stats64() implementation for this use case. Reviewed-by: Florian Fainelli Signed-off-by: Heiner Kallweit -

[PATCH net-next v2 07/10] wireguard: switch to dev_get_tstats64

Replace ip_tunnel_get_stats64() with the new identical core fucntion dev_get_tstats64(). Signed-off-by: Heiner Kallweit --- drivers/net/wireguard/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireguard/device.c b/drivers/net/wireguard/device.c index c9f

Re: [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused

On Wed, 04 Nov 2020, Andrew Lunn wrote: > On Wed, Nov 04, 2020 at 09:06:00AM +, Lee Jones wrote: > > 'status' is used to interact with a hardware register. It might not > > be safe to remove it entirely. Mark it as __maybe_unused instead. > > Hi Lee > > https://www.mail-archive.com/netdev@

[PATCH net-next v2 10/10] net: remove ip_tunnel_get_stats64

After having migrated all users remove ip_tunnel_get_stats64(). Signed-off-by: Heiner Kallweit --- include/net/ip_tunnels.h | 2 -- net/ipv4/ip_tunnel_core.c | 9 - 2 files changed, 11 deletions(-) diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h index 02ccd3254..1b7905

[PATCH net-next v2 08/10] vti: switch to dev_get_tstats64

Replace ip_tunnel_get_stats64() with the new identical core fucntion dev_get_tstats64(). Signed-off-by: Heiner Kallweit --- net/ipv4/ip_vti.c | 2 +- net/ipv6/ip6_vti.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c index b957cbee2..

Re: [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused

On Wed, 04 Nov 2020, Lee Jones wrote: > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > On Wed, Nov 04, 2020 at 09:06:00AM +, Lee Jones wrote: > > > 'status' is used to interact with a hardware register. It might not > > > be safe to remove it entirely. Mark it as __maybe_unused instead. > >

Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header

On Wed, Nov 04, 2020 at 02:28:35PM +, Lee Jones wrote: > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > On Wed, Nov 04, 2020 at 09:06:04AM +, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function

[PATCH] net: stmmac: Don't log error message in case of -EPROBE_DEFER.

Remove error messages that might confuse users when error is just -517 / -EPROBE_DEFER. [...] imx-dwmac 30bf.ethernet: Cannot register the MDIO bus imx-dwmac 30bf.ethernet: stmmac_dvr_probe: MDIO bus (id: 0) regist

Re: [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused

On Wed, Nov 04, 2020 at 02:31:40PM +, Lee Jones wrote: > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > On Wed, Nov 04, 2020 at 09:06:00AM +, Lee Jones wrote: > > > 'status' is used to interact with a hardware register. It might not > > > be safe to remove it entirely. Mark it as __maybe_

Re: [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused

> Our of interest, are you planning on working on any other areas? Hi Lee. No, not really. I'm a networking guy, so will look mostly at drivers/net and the core net code. Andrew

Re: [PATCH v3 net-next 2/5] net: page_pool: add bulk support for ptr_ring

> > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > > index ef98372facf6..236c5ed3aa66 100644 > > --- a/net/core/page_pool.c > > +++ b/net/core/page_pool.c > [...] > > @@ -408,6 +410,39 @@ void page_pool_put_page(struct page_pool *pool, struct > > page *page, > > } > > EXPORT_SYMBOL(p

Re: [PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused

On Wed, 04 Nov 2020, Andrew Lunn wrote: > On Wed, Nov 04, 2020 at 02:31:40PM +, Lee Jones wrote: > > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > > > On Wed, Nov 04, 2020 at 09:06:00AM +, Lee Jones wrote: > > > > 'status' is used to interact with a hardware register. It might not > > >

Re: [net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

Hello Eric, On 04.11.20 09:16, Eric Dumazet wrote: On Wed, Nov 4, 2020 at 2:21 AM Jakub Kicinski wrote: On Tue, 3 Nov 2020 23:06:14 +0100 Marc Kleine-Budde wrote: From: Vincent Mailhol If a driver calls can_get_echo_skb() during a hardware IRQ (which is often, but not always, the case), t

Re: [PATCH 06/10] thunderbolt: Create debugfs directory automatically for services

On Wed, Nov 04, 2020 at 03:20:38PM +0100, Greg KH wrote: > > +/** > > + * tb_service_debugfs_remove() - Remove service debugfs directory > > + * @svc: Thunderbolt service pointer > > + * > > + * Removes the previously created debugfs directory for @svc. > > + */ > > +void tb_service_debugfs_remove(

Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header

On Wed, 04 Nov 2020, Andrew Lunn wrote: > On Wed, Nov 04, 2020 at 02:28:35PM +, Lee Jones wrote: > > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > > > On Wed, Nov 04, 2020 at 09:06:04AM +, Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > > > > > drivers/

Re: [PATCH 1/2] rsi: Move card interrupt handling to RX thread

On 03.11.20 19:09, Marek Vasut wrote: The interrupt handling of the RS911x is particularly heavy. For each RX packet, the card does three SDIO transactions, one to read interrupt status register, one to RX buffer length, one to read the RX packet(s). This translates to ~330 uS per one cycle of in

Re: [PATCH 1/2] rsi: Move card interrupt handling to RX thread

On 11/4/20 4:21 PM, Martin Kepplinger wrote: On 03.11.20 19:09, Marek Vasut wrote: The interrupt handling of the RS911x is particularly heavy. For each RX packet, the card does three SDIO transactions, one to read interrupt status register, one to RX buffer length, one to read the RX packet(s).

[PATCH v8 0/3] Drivers: hv: vmbus: vmbus_requestor data structure for VMBus hardening

Hi all, This is a resubmission of: https://lkml.kernel.org/r/20200907161920.71460-1-parri.and...@gmail.com based on 5.10-rc2. Andrea Cc: James E.J. Bottomley Cc: Martin K. Petersen Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-s...@vger.kernel.org Cc: netdev@vger.kernel.org Andre

[PATCH v8 3/3] hv_netvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening

From: Andres Beltran Currently, pointers to guest memory are passed to Hyper-V as transaction IDs in netvsc. In the face of errors or malicious behavior in Hyper-V, netvsc should not expose or trust the transaction IDs returned by Hyper-V to be valid guest memory addresses. Instead, use small int

[PATCH net-next v2 5/7] drivers: net: smc911x: Fix passing wrong number of parameters to DBG() macro

Now that the compiler always sees the parameters passed to the DBG() macro, it gives an error message about wrong parameters. The comment says it all: /* ndev is not valid yet, so avoid passing it in. */ DBG(SMC_DEBUG_FUNC, "--> %s\n", __func__); You cannot not just pass a parame

[PATCH net-next v2 4/7] drivers: net: smc911x: Fix set but unused status because of DBG macro

drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_timeout’: drivers/net/ethernet/smsc/smc911x.c:1251:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 1251 | int status, mask; The status is read in order to print it via the DBG macro. However, due to the way DBG

[PATCH net-next v2 3/7] drivers: net: smc911x: Work around set but unused status

drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_phy_interrupt’: drivers/net/ethernet/smsc/smc911x.c:976:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 976 | int status; A comment indicates the status needs to be read from the PHY, otherwise bad things happ

[PATCH net-next v2 7/7] drivers: net: smsc: Add COMPILE_TEST support

Improve the build testing of these SMSC drivers by enabling them when COMPILE_TEST is selected. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/smsc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/sms

[PATCH net-next v2 0/7] smsc W=1 warning fixes

Fixup various W=1 warnings, and then add COMPILE_TEST support, which explains why these where missed on the previous pass. One of these patches added as a new checkpatch warning, by copy/pasting an existing macro and slightly modifying it. The code already has lots of checkpatch warnings, so one m

[PATCH net-next v2 6/7] drivers: net: smc911x: Fix cast from pointer to integer of different size

drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_hardware_send_pkt’: drivers/net/ethernet/smsc/smc911x.c:471:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 471 | cmdA = (((u32)skb->data & 0x3) << 16) | When built on 64bit targets, the skb->data poi

[PATCH net-next v2 2/7] drivers: net: smc91x: Fix missing kerneldoc reported by W=1

drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio' drivers/net/ethernet/smsc/smc91x.c:2199:

[PATCH net-next v2 1/7] drivers: net: smc91x: Fix set but unused W=1 warning

drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set but not used [-Wunused-but-set-variable] 706 | unsigned int saved_packet, packet_no, tx_status, pkt_len; Add a new macro for getting fields out of the header, which only gets the status, not the length which in this cas

[PATCH v3 00/24] wfx: get out from the staging area

From: Jérôme Pouiller I think the wfx driver is now mature enough to be accepted in the drivers/net/wireless directory. As requested by Kalle[1], I send one file per patch. At the end, all the patches (or at least the patches 3 to 24) will be squashed (therefore, I didn't bother to write real co

[PATCH v3 08/24] wfx: add bus_sdio.c

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bus_sdio.c | 258 + 1 file changed, 258 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c diff --git a/drivers/net/wireless/silabs/wfx/bus_sdio.c b/drivers/n

[PATCH v3 02/24] dt-bindings: introduce silabs,wfx.yaml

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- .../bindings/net/wireless/silabs,wfx.yaml | 131 ++ 1 file changed, 131 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml diff --git a/Documentation/devicetree/bindings/

[PATCH v3 17/24] wfx: add queue.c/queue.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/queue.c | 304 drivers/net/wireless/silabs/wfx/queue.h | 45 2 files changed, 349 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/queue.c create mode 100644

[PATCH v3 13/24] wfx: add hif_tx*.c/hif_tx*.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hif_tx.c | 523 +++ drivers/net/wireless/silabs/wfx/hif_tx.h | 60 +++ drivers/net/wireless/silabs/wfx/hif_tx_mib.c | 324 drivers/net/wireless/silabs/wfx/hif_tx_mib.h

[PATCH v3 16/24] wfx: add data_rx.c/data_rx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/data_rx.c | 93 +++ drivers/net/wireless/silabs/wfx/data_rx.h | 18 + 2 files changed, 111 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/data_rx.c create mode 10

[PATCH v3 10/24] wfx: add fwio.c/fwio.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/fwio.c | 405 + drivers/net/wireless/silabs/wfx/fwio.h | 15 + 2 files changed, 420 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/fwio.c create mode 100644 driv

[PATCH v3 12/24] wfx: add hif_api_*.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hif_api_cmd.h | 553 ++ .../net/wireless/silabs/wfx/hif_api_general.h | 267 + drivers/net/wireless/silabs/wfx/hif_api_mib.h | 343 +++ 3 files changed, 1163 insertions(+) c

[PATCH v3 09/24] wfx: add hwio.c/hwio.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hwio.c | 352 + drivers/net/wireless/silabs/wfx/hwio.h | 75 ++ 2 files changed, 427 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/hwio.c create mode 100644

[PATCH v3 18/24] wfx: add data_tx.c/data_tx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/data_tx.c | 585 ++ drivers/net/wireless/silabs/wfx/data_tx.h | 67 +++ 2 files changed, 652 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/data_tx.c create mode 100

[PATCH v3 24/24] wfx: get out from the staging area

From: Jérôme Pouiller The wfx driver is now mature enough to leave the staging area. Signed-off-by: Jérôme Pouiller --- MAINTAINERS | 3 ++- drivers/net/wireless/Kconfig | 1 + drivers/net/wireless/Makefile| 1 + drivers/net/wireless/silabs/Kconfig

[PATCH v3 15/24] wfx: add hif_rx.c/hif_rx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hif_rx.c | 415 +++ drivers/net/wireless/silabs/wfx/hif_rx.h | 18 + 2 files changed, 433 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/hif_rx.c create mode 100644

[PATCH v3 20/24] wfx: add scan.c/scan.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/scan.c | 132 + drivers/net/wireless/silabs/wfx/scan.h | 22 + 2 files changed, 154 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/scan.c create mode 100644

[PATCH v3 22/24] wfx: add traces.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/traces.h | 501 +++ 1 file changed, 501 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/traces.h diff --git a/drivers/net/wireless/silabs/wfx/traces.h b/drivers/net/w

[PATCH v3 19/24] wfx: add sta.c/sta.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/sta.c | 807 ++ drivers/net/wireless/silabs/wfx/sta.h | 73 +++ 2 files changed, 880 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/sta.c create mode 100644 driv

[PATCH v3 21/24] wfx: add debug.c/debug.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/debug.c | 359 drivers/net/wireless/silabs/wfx/debug.h | 19 ++ 2 files changed, 378 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/debug.c create mode 100644 d

[PATCH v3 11/24] wfx: add bh.c/bh.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bh.c | 333 +++ drivers/net/wireless/silabs/wfx/bh.h | 33 +++ 2 files changed, 366 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bh.c create mode 100644 driver

[PATCH v3 14/24] wfx: add key.c/key.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/key.c | 241 ++ drivers/net/wireless/silabs/wfx/key.h | 20 +++ 2 files changed, 261 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/key.c create mode 100644 driv

[PATCH v3 03/24] wfx: add Makefile/Kconfig

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/Kconfig | 8 drivers/net/wireless/silabs/wfx/Makefile | 25 2 files changed, 33 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig create mode 100

[PATCH v3 07/24] wfx: add bus_spi.c

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bus_spi.c | 271 ++ 1 file changed, 271 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bus_spi.c diff --git a/drivers/net/wireless/silabs/wfx/bus_spi.c b/drivers/net

[PATCH v3 04/24] wfx: add wfx.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/wfx.h | 166 ++ 1 file changed, 166 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/wfx.h diff --git a/drivers/net/wireless/silabs/wfx/wfx.h b/drivers/net/wireles

[PATCH v3 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

From: Jérôme Pouiller Add Silabs SDIO ID to sdio_ids.h. Note that the values used by Silabs are uncommon. A driver cannot fully rely on the SDIO PnP. It should also check if the device is declared in the DT. Signed-off-by: Jérôme Pouiller --- include/linux/mmc/sdio_ids.h | 5 + 1 file cha

[PATCH v3 06/24] wfx: add bus.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/bus.h | 38 +++ 1 file changed, 38 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/bus.h diff --git a/drivers/net/wireless/silabs/wfx/bus.h b/drivers/net/wireless

[PATCH v3 05/24] wfx: add main.c/main.h

From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/main.c | 489 + drivers/net/wireless/silabs/wfx/main.h | 44 +++ 2 files changed, 533 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/main.c create mode 100644 dr

[PATCH] can: j1939: add tables for the CAN identifier and its fields

From: Yegor Yefremov Use table markup to show the structure of the CAN identifier, PGN, PDU1, and PDU2 formats. Also add introductory sentence. Signed-off-by: Yegor Yefremov --- Documentation/networking/j1939.rst | 46 +++--- 1 file changed, 42 insertions(+), 4 deletion

Re: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property

On 11/4/2020 4:11 AM, Badel, Laurent wrote: > > > > - > Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de > la Longeraie 7, 1110, Morges, Switzerland > > - > > -Original Message- >> From: Rob Herrin

Re: [net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

On Wed, 4 Nov 2020 15:59:25 +0100 Oliver Hartkopp wrote: > Hello Eric, > > On 04.11.20 09:16, Eric Dumazet wrote: > > On Wed, Nov 4, 2020 at 2:21 AM Jakub Kicinski wrote: > >> > >> On Tue, 3 Nov 2020 23:06:14 +0100 Marc Kleine-Budde wrote: > >>> From: Vincent Mailhol > >>> > >>> If a driver

Re: [PATCH] can: j1939: add tables for the CAN identifier and its fields

On 11/4/20 4:57 PM, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Use table markup to show the structure of the CAN identifier, PGN, PDU1, > and PDU2 formats. Also add introductory sentence. > > Signed-off-by: Yegor Yefremov > --- > Documentation/networking/j1939.rst | 46 ++

[PATCH v1] lan743x: correctly handle chips with internal PHY

Commit 6f197fb63850 ("lan743x: Added fixed link and RGMII support") assumes that chips with an internal PHY will not have a devicetree entry. This is incorrect: even for these chips, a devicetree entry can be useful e.g. to pass the mac address from bootloader to chip: &pcie { stat

Re: [PATCH v6] lib: optimize cpumask_local_spread()

On 11/3/20 5:39 AM, Shaokun Zhang wrote: > Currently, Intel DDIO affects only local sockets, so its performance > improvement is due to the relative difference in performance between the > local socket I/O and remote socket I/O.To ensure that Intel DDIO’s > benefits are available to applications wh

<    1   2   3   4   >