[net 08/27] can: j1939: rename jacd tool

2020-11-03 Thread Marc Kleine-Budde
From: Yegor Yefremov Due to naming conflicts, jacd was renamed to j1939acd in: https://github.com/linux-can/can-utils/pull/199 Signed-off-by: Yegor Yefremov Link: https://lore.kernel.org/r/20201020081134.3597-1-yegorsli...@googlemail.com Link: https://github.com/linux-can/can-utils/pull/19

[net 01/27] dt-bindings: can: add can-controller.yaml

2020-11-03 Thread Marc Kleine-Budde
From: Oleksij Rempel For now we have only node name as common rule for all CAN controllers Signed-off-by: Oleksij Rempel Reviewed-by: Rob Herring Link: https://lore.kernel.org/r/20201022075218.11880-2-o.rem...@pengutronix.de Signed-off-by: Marc Kleine-Budde --- .../bindings/net/can/can-contr

pull-request: can 2020-11-03

2020-11-03 Thread Marc Kleine-Budde
:19:59 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-5.10-20201103 for you to fetch changes up to ab07ff1c92fa60f29438e655a1b4abab860ed0b6: can: flexcan: flexcan_remove(): dis

[net 03/27] can: proc: can_remove_proc(): silence remove_proc_entry warning

2020-11-03 Thread Marc Kleine-Budde
From: Zhang Changzhong If can_init_proc() fail to create /proc/net/can directory, can_remove_proc() will trigger a warning: WARNING: CPU: 6 PID: 7133 at fs/proc/generic.c:672 remove_proc_entry+0x17b0 Kernel panic - not syncing: panic_on_warn set ... Fix to return early from can_remove_proc() if

Re: [PATCH net-next] net/mlx5e: Remove duplicated include

2020-11-03 Thread Saeed Mahameed
On Sat, 2020-10-31 at 10:50 +0800, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing > --- > drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c > b/drivers/net/etherne

Re: [PATCH 0/2] prevent potential access of uninitialized members in can_rcv() and canfd_rcv()

2020-11-03 Thread Marc Kleine-Budde
On 11/3/20 10:39 PM, Anant Thazhemadam wrote: > In both can_rcv(), and canfd_rcv(), when skb->len = 0, cfd->len > (which is uninitialized) is accessed by pr_warn_once(). > > Performing the validation check for cfd->len separately, after the > validation check for skb->len is done, resolves this

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread David Ahern
On 11/3/20 10:47 AM, Alexei Starovoitov wrote: > since David is deaf to technical arguments, It is not that I am "deaf to technical arguments"; you do not like my response. The scope of bpf in iproute2 is tiny - a few tc modules (and VRF but it does not need libbpf) which is a small subset of the

Re: [net-next,v1,1/5] vrf: add mac header for tunneled packets when sniffer is attached

2020-11-03 Thread David Ahern
On 11/3/20 5:52 AM, Andrea Mayer wrote: > Before this patch, a sniffer attached to a VRF used as the receiving > interface of L3 tunneled packets detects them as malformed packets and > it complains about that (i.e.: tcpdump shows bogus packets). > > The reason is that a tunneled L3 packet does no

Re: [PATCH 1/4] gve: Add support for raw addressing device option

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote: > From: Catherine Sullivan > > Add support to describe device for parsing device options. As > the first device option, add raw addressing. > > "Raw Addressing" mode (as opposed to the current "qpl" mode) is an > operational mode which a

Re: [net-next,v1,5/5] selftests: add selftest for the SRv6 End.DT4 behavior

2020-11-03 Thread David Ahern
On 11/3/20 5:52 AM, Andrea Mayer wrote: > this selftest is designed for evaluating the new SRv6 End.DT4 behavior > used, in this example, for implementing IPv4 L3 VPN use cases. > > Signed-off-by: Andrea Mayer > --- > .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 494 ++ > 1 fi

Re: [PATCH net-next v2 00/19] net: phy: add support for shared interrupts (part 1)

2020-11-03 Thread Michael Walle
Am 2020-11-01 13:50, schrieb Ioana Ciornei: From: Ioana Ciornei This patch set aims to actually add support for shared interrupts in phylib and not only for multi-PHY devices. While we are at it, streamline the interrupt handling in phylib. For the Broadcom BCM54140: Tested-by: Michael Walle

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread Alexei Starovoitov
On Tue, Nov 03, 2020 at 03:32:55PM -0700, David Ahern wrote: > On 11/3/20 10:47 AM, Alexei Starovoitov wrote: > > since David is deaf to technical arguments, > It is not that I am "deaf to technical arguments"; you do not like my > response. > > The scope of bpf in iproute2 is tiny - a few tc modu

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2020-11-03 Thread Kenny Ho
On Tue, Nov 3, 2020 at 4:04 PM Alexei Starovoitov wrote: > > On Tue, Nov 03, 2020 at 02:19:22PM -0500, Kenny Ho wrote: > > On Tue, Nov 3, 2020 at 12:43 AM Alexei Starovoitov > > wrote: > > > On Mon, Nov 2, 2020 at 9:39 PM Kenny Ho wrote: > > Sounds like either bpf_lsm needs to be made aware of c

Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into do_reset

2020-11-03 Thread Jakub Kicinski
On Sat, 31 Oct 2020 04:46:45 -0500 Lijun Pan wrote: > Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so > linkwatch_event can run") introduced do_change_param_reset function to > solve the rtnl lock issue. Majority of the code in do_change_param_reset > duplicates do_reset. Also, we c

Re: [PATCH 2/4] gve: Add support for raw addressing to the rx path

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote: > From: Catherine Sullivan > > Add support to use raw dma addresses in the rx path. Due to this new > support we can alloc a new buffer instead of making a copy. > > RX buffers are handed to the networking stack and are > re-allocated as

Re: [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-11-03 Thread Jakub Kicinski
On Sat, 31 Oct 2020 11:10:38 -0700 Xie He wrote: > The main purpose of this series is the last patch. The previous 4 patches > are just code clean-ups so that the last patch will not make the code too > messy. The patches must be applied in sequence. > > The receiving code of this driver doesn't s

Re: [PATCH net-next] vxlan: Use a per-namespace nexthop listener instead of a global one

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 18:45:10 -0700 David Ahern wrote: > On 11/1/20 4:39 AM, Ido Schimmel wrote: > > From: Ido Schimmel > > > > The nexthop notification chain is a per-namespace chain and not a global > > one like the netdev notification chain. > > > > Therefore, a single (global) listener cannot

Re: [PATCH net-next 2/3] drivers: net: xilinx_emaclite: Fix -Wpointer-to-int-cast warnings with W=1

2020-11-03 Thread Andrew Lunn
> > > /* BUFFER_ALIGN(adr) calculates the number of bytes to the next > > > alignment. */ -#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32)adr)) % > > > ALIGNMENT) > > > +#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((long)adr)) % ALIGNMENT) > > > > I can't see any reason to change unsigned type to sign

Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2020-11-03 Thread Alexei Starovoitov
On Tue, Nov 03, 2020 at 05:57:47PM -0500, Kenny Ho wrote: > On Tue, Nov 3, 2020 at 4:04 PM Alexei Starovoitov > wrote: > > > > On Tue, Nov 03, 2020 at 02:19:22PM -0500, Kenny Ho wrote: > > > On Tue, Nov 3, 2020 at 12:43 AM Alexei Starovoitov > > > wrote: > > > > On Mon, Nov 2, 2020 at 9:39 PM Ken

Re: [RFC PATCH ethtool] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-11-03 Thread Michal Kubecek
On Tue, Nov 03, 2020 at 04:24:30PM +0200, Ido Schimmel wrote: > > I have the changes you requested here: > https://github.com/idosch/ethtool/commit/b34d15839f2662808c566c04eda726113e20ee59 > > Do you want to integrate it with your nl_parse() rework or should I? I pushed the combined series to

Re: [PATCH 3/4] gve: Rx Buffer Recycling

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote: > This patch lets the driver reuse buffers that have been freed by the > networking stack. > > In the raw addressing case, this allows the driver avoid allocating > new > buffers. > In the qpl case, the driver can avoid copies. > > Signed

[PATCH net] openvswitch: Fix upcall OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS

2020-11-03 Thread Yi-Hung Wei
TUNNEL_GENEVE_OPT is set on tun_flags in struct sw_flow_key when a packet is coming from a geneve tunnel no matter the size of geneve option is zero or not. On the other hand, TUNNEL_VXLAN_OPT or TUNNEL_ERSPAN_OPT is set when the VXLAN or ERSPAN option is available. Currently, ovs kernel module on

Re: [bpf-next PATCH v3 0/5] selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework

2020-11-03 Thread Martin KaFai Lau
On Tue, Nov 03, 2020 at 01:34:40PM -0800, Alexander Duyck wrote: > Move the test functionality from test_tcpbpf_user into the test_progs > framework so that it will be run any time the test_progs framework is run. > This will help to prevent future test escapes as the individual tests, such > as t

Re: [PATCH 4/4] gve: Add support for raw addressing in the tx path

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 09:46 -0800, David Awogbemila wrote: > From: Catherine Sullivan > > During TX, skbs' data addresses are dma_map'ed and passed to the NIC. > This means that the device can perform DMA directly from these > addresses > and the driver does not have to copy the buffer content in

linux-next: manual merge of the net-next tree with the net tree

2020-11-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/ibm/ibmvnic.c between commit: 1d8504937478 ("powerpc/vnic: Extend "failover pending" window") from the net tree and commit: 16b5f5ce351f ("ibmvnic: merge do_change_param_reset into do_reset")

Re: [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:44:43 + Lee Jones wrote: > When AIX_EVENT is not defined, the 'if' body will be empty, which > makes GCC complain. Place bracketing around the invocation to protect > it. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/fddi/skfp/ecm.c: In function

Re: [PATCH net-next v2 04/15] net/smc: Add link counters for IB device ports

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote: > From: Guvenc Gulce > > Add link counters to the structure of the smc ib device, one counter > per > ib port. Increase/decrease the counters as needed in the > corresponding > routines. > > Signed-off-by: Guvenc Gulce > Signed-off-by: Kar

Re: [PATCH net v2] net: openvswitch: silence suspicious RCU usage warning

2020-11-03 Thread Jakub Kicinski
On Tue, 3 Nov 2020 09:25:49 +0100 Eelco Chaudron wrote: > Silence suspicious RCU usage warning in ovs_flow_tbl_masks_cache_resize() > by replacing rcu_dereference() with rcu_dereference_ovsl(). > > In addition, when creating a new datapath, make sure it's configured under > the ovs_lock. > > Fix

Re: [PATCH net-next v2 05/15] net/smc: Add diagnostic information to smc ib-device

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote: > From: Guvenc Gulce > > During smc ib-device creation, add network device name to smc > ib-device structure. Register for netdevice name changes and > update ib-device accordingly. This is needed for diagnostic purposes. > > Signed-off-by:

Re: [PATCH net-next v2 06/15] net/smc: Add diagnostic information to link structure

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote: > From: Guvenc Gulce > > During link creation add network and ib-device name to > link structure. This is needed for diagnostic purposes. > > When diagnostic information is gathered, we need to traverse > device, linkgroup and link structur

Re: [PATCH 1/1] mm: avoid re-using pfmemalloc page in page_frag_alloc()

2020-11-03 Thread Rama Nichanamatlu
Thanks for providing the numbers. Do you think that dropping (up to) 7 packets is acceptable? net.ipv4.tcp_syn_retries = 6 tcp clients wouldn't even get that far leading to connect establish issues. -rama On Tue, Nov 03, 2020 at 09:15:41PM +, Matthew Wilcox wrote: On Tue, Nov 03, 2020 at

Re: [net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-11-03 Thread Jakub Kicinski
On Tue, 3 Nov 2020 23:06:14 +0100 Marc Kleine-Budde wrote: > From: Vincent Mailhol > > If a driver calls can_get_echo_skb() during a hardware IRQ (which is often, > but > not always, the case), the 'WARN_ON(in_irq)' in > net/core/skbuff.c#skb_release_head_state() might be triggered, under netwo

Re: [PATCH net-next v2 11/15] net/smc: Add SMC-D Linkgroup diagnostic support

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote: > From: Guvenc Gulce > > Deliver SMCD Linkgroup information via netlink based > diagnostic interface. > > Signed-off-by: Guvenc Gulce > Signed-off-by: Karsten Graul > --- > include/uapi/linux/smc_diag.h | 7 +++ > net/smc/smc_diag.c

Re: [PATCH v2 net-next 0/2] net: allow virtual netdevs to forward UDP L4 and fraglist GSO skbs

2020-11-03 Thread Jakub Kicinski
On Sun, 01 Nov 2020 13:16:32 + Alexander Lobakin wrote: > NETIF_F_GSO_UDP_L4 and NETIF_F_GSO_FRAGLIST allow drivers to offload > GSO UDP L4. This works well on simple setups, but when any logical > netdev (e.g. VLAN) is present, kernel stack always performs software > resegmentation which actua

Re: [PATCH net-next 0/2] mlxsw: spectrum: Prepare for XM implementation - LPM trees

2020-11-03 Thread Jakub Kicinski
On Sun, 1 Nov 2020 15:42:13 +0200 Ido Schimmel wrote: > From: Ido Schimmel > > Jiri says: > > This is a preparation patchset for follow-up support of boards with > extended mezzanine (XM), which are going to allow extended (scale-wise) > router offload. > > XM requires a separate set of PRM re

Re: [PATCH net-next v2 12/15] net/smc: Add support for obtaining SMCD device list

2020-11-03 Thread Saeed Mahameed
On Tue, 2020-11-03 at 11:25 +0100, Karsten Graul wrote: > From: Guvenc Gulce > > Deliver SMCD device information via netlink based > diagnostic interface. > > Signed-off-by: Guvenc Gulce > Signed-off-by: Karsten Graul > --- > include/uapi/linux/smc.h | 2 + > include/uapi/linux/smc_diag

Re: [PATCH net-next] r8169: align number of tx descriptors with vendor driver

2020-11-03 Thread Jakub Kicinski
On Sun, 1 Nov 2020 23:23:52 +0100 Heiner Kallweit wrote: > Lowest number of tx descriptors used in the vendor drivers is 256 in > r8169. r8101/r8168/r8125 use 1024 what seems to be the hw limit. Stay > on the safe side and go with 256, same as number of rx descriptors. > > Signed-off-by: Heiner Ka

Re: [PATCH net-next] r8169: set IRQF_NO_THREAD if MSI(X) is enabled

2020-11-03 Thread Jakub Kicinski
On Sun, 1 Nov 2020 23:30:44 +0100 Heiner Kallweit wrote: > We had to remove flag IRQF_NO_THREAD because it conflicts with shared > interrupts in case legacy interrupts are used. Following up on the > linked discussion set IRQF_NO_THREAD if MSI or MSI-X is used, because > both guarantee that interru

Re: [PATCH v3] lan743x: fix for potential NULL pointer dereference with bare card

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 01:35:55 +0300 Sergej Bauer wrote: > This is the 3rd revision of the patch fix for potential null pointer > dereference > with lan743x card. > > The simpliest way to reproduce: boot with bare lan743x and issue "ethtool > ethN" > commant where ethN is the interface with lan743

RE: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Hayes Wang
Jakub Kicinski > Sent: Wednesday, November 4, 2020 12:16 AM [...] > > So no, please do not create such a common file, it is not needed or a > > good idea. > > I wouldn't go that far, PCI subsystem just doesn't want everyone to add > IDs to the shared file unless there is a reason. > > *Do n

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread David Ahern
On 11/3/20 3:55 PM, Alexei Starovoitov wrote: > The bpf support in "tc" command instead of being obviously old and obsolete > will be sort-of working with unpredictable delay between released kernel > and released iproute2 version. The iproute2 release that suppose to match > kernel > release will

Re: [PATCH v2 net-next 0/3] fsl/qbman: in_interrupt() cleanup.

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 00:22:54 +0100 Sebastian Andrzej Siewior wrote: > This is the in_interrupt() clean for FSL DPAA framework and the two > users. > > The `napi' parameter has been renamed to `sched_napi', the other parts > are same as in the previous post [0]. > > [0] https://lkml.kernel.org/r/

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Jakub Kicinski
On Wed, 4 Nov 2020 01:39:52 + Hayes Wang wrote: > Jakub Kicinski > > Sent: Wednesday, November 4, 2020 12:16 AM > [...] > > > So no, please do not create such a common file, it is not needed or a > > > good idea. > > > > I wouldn't go that far, PCI subsystem just doesn't want everyone to

Re: [PATCH net-next v2] net: phy: realtek: Add support for RTL8221B-CG series

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 09:52:07 +0800 Willy Liu wrote: > Realtek single-port 2.5Gbps Ethernet PHYs are list as below: > RTL8226-CG: the 1st generation 2.5Gbps single port PHY > RTL8226B-CG/RTL8221B-CG: the 2nd generation 2.5Gbps single port PHY > RTL8221B-VB-CG: the 3rd generation 2.5Gbps single port P

Re: [PATCH] forcedeth: fix excluded_middle.cocci warnings

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 09:38:30 +0100 (CET) Julia Lawall wrote: > From: kernel test robot > > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Fixes: b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script") > CC: Denis E

Re: [PATCH] net: dev_ioctl: remove redundant initialization of variable err

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 12:16:15 + Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value")

Re: [PATCH] octeontx2-pf: Fix sizeof() mismatch

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 13:46:01 + Colin King wrote: > From: Colin Ian King > > An incorrect sizeof() is being used, sizeof(u64 *) is not correct, > it should be sizeof(*sq->sqb_ptrs). > > Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues") > Addresses-Coverity: ("Sizeof not porta

Re: [PATCH net-next] chelsio/chtls: Utilizing multiple rxq/txq to process requests

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 21:58:33 +0530 Vinay Kumar Yadav wrote: > patch adds a logic to utilize multiple queues to process requests. > The queue selection logic uses a round-robin distribution technique > using a counter. > > Signed-off-by: Ayush Sawal > Signed-off-by: Vinay Kumar Yadav Applied tha

Re: [PATCH net-next] net: ipa: restrict special reset to IPA v3.5.1

2020-11-03 Thread Jakub Kicinski
On Mon, 2 Nov 2020 11:34:35 -0600 Alex Elder wrote: > With IPA v3.5.1, if IPA aggregation is active at the time an > underlying GSI channel reset is performed, some special handling > is required. > > There is logic in ipa_endpoint_reset() that arranges for that > special handling, but it's done

RE: [PATCH net-next 1/5] r8152: use generic USB macros to define product table

2020-11-03 Thread Hayes Wang
Marek Behún > Sent: Wednesday, November 4, 2020 3:22 AM > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index b1770489aca5..85dda591c838 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -6862,20 +6862,12 @@ static void rtl8152_disconnect(struct > usb_i

DSA and ptp_classify_raw: saving some CPU cycles causes worse throughput?

2020-11-03 Thread Vladimir Oltean
Hi, I was testing a simple patch: diff --git a/net/dsa/slave.c b/net/dsa/slave.c index c6806eef906f..e0cda3a65f28 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -511,6 +511,9 @@ static void dsa_skb_tx_timestamp(struct dsa_slave_priv *p, struct sk_buff *clone; unsigned int t

Re: [bpf-next PATCH v3 0/5] selftests/bpf: Migrate test_tcpbpf_user to be a part of test_progs framework

2020-11-03 Thread Alexei Starovoitov
On Tue, Nov 3, 2020 at 4:20 PM Martin KaFai Lau wrote: > > On Tue, Nov 03, 2020 at 01:34:40PM -0800, Alexander Duyck wrote: > > Move the test functionality from test_tcpbpf_user into the test_progs > > framework so that it will be run any time the test_progs framework is run. > > This will help to

Re: [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype

2020-11-03 Thread Xie He
On Tue, Nov 3, 2020 at 3:22 PM Jakub Kicinski wrote: > > Applied, but going forward please limit any refactoring and extensions > to the HDLC code. I thought you are actually using it. If that's not > the case let's leave the code be, it's likely going to be removed in > a few years time. OK. I u

Re: [bpf-next PATCH v3 1/5] selftests/bpf: Move test_tcppbf_user into test_progs

2020-11-03 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 03 Nov 2020 13:34:48 -0800 you wrote: > From: Alexander Duyck > > Recently a bug was missed due to the fact that test_tcpbpf_user is not a > part of test_progs. In order to prevent similar issues in the future move

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread Hangbin Liu
On Tue, Nov 03, 2020 at 02:55:54PM -0800, Alexei Starovoitov wrote: > > The scope of bpf in iproute2 is tiny - a few tc modules (and VRF but it > > does not need libbpf) which is a small subset of the functionality and > > commands within the package. > > When Hangbin sent this patch set I got exc

[PATCH net-next v2 RESEND] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Hayes Wang
Support ECM mode based on cdc_ether with relative mii functions, when CONFIG_USB_RTL8152 is not set, or the device is not supported by r8152 driver. Both r8152 and r8153_ecm would check the return value of rtl8152_get_version() in porbe(). If rtl8152_get_version() return none zero value, the r8152

Re: [PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-03 Thread Andrew Lunn
> +config SPI_AX88796C_COMPRESSION > + bool "SPI transfer compression" > + default n > + depends on SPI_AX88796C > + help > + Say Y here to enable SPI transfer compression. It saves up > + to 24 dummy cycles during each transfer which may noticably > + speed up sho

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread Alexei Starovoitov
On Tue, Nov 03, 2020 at 06:40:44PM -0700, David Ahern wrote: > On 11/3/20 3:55 PM, Alexei Starovoitov wrote: > > The bpf support in "tc" command instead of being obviously old and obsolete > > will be sort-of working with unpredictable delay between released kernel > > and released iproute2 version

Re: DSA and ptp_classify_raw: saving some CPU cycles causes worse throughput?

2020-11-03 Thread Andrew Lunn
> My untrained eye tells me that in the 'after patch' case (the worse > one), there are less branch misses, and less cache misses. So by all > perf metrics, the throughput should be better, but it isn't. What gives? Maybe the frame has been pushed out of the L1 cache. The classify code is pulling

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread Alexei Starovoitov
On Wed, Nov 04, 2020 at 10:17:30AM +0800, Hangbin Liu wrote: > On Tue, Nov 03, 2020 at 02:55:54PM -0800, Alexei Starovoitov wrote: > > > The scope of bpf in iproute2 is tiny - a few tc modules (and VRF but it > > > does not need libbpf) which is a small subset of the functionality and > > > command

Re: [net 05/27] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-11-03 Thread Vincent MAILHOL
On Wed. 4 Nov 2020 10:21, Jakub Kicinski wrote: > On Tue, 3 Nov 2020 23:06:14 +0100 Marc Kleine-Budde wrote: >> From: Vincent Mailhol >> >> If a driver calls can_get_echo_skb() during a hardware IRQ (which is often, >> but >> not always, the case), the 'WARN_ON(in_irq)' in >> net/core/skbuff.c#s

[PATCH] cxgb4: Fix the -Wmisleading-indentation warning

2020-11-03 Thread xiakaixu1987
From: Kaixu Xia Fix the gcc warning: drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c:2673:9: warning: this 'for' clause does not guard... [-Wmisleading-indentation] 2673 | for (i = 0; i < n; ++i) \ Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/net/ethernet/chelsio

Re: [PATCH net-next 3/5] r8152: add MCU typed read/write functions

2020-11-03 Thread Marek Behún
On Tue, 3 Nov 2020 23:47:12 +0200 Vladimir Oltean wrote: > On Tue, Nov 03, 2020 at 08:22:24PM +0100, Marek Behún wrote: > > Add pla_ and usb_ prefixed versions of ocp_read_* and ocp_write_* > > functions. This saves us from always writing MCU_TYPE_PLA/MCU_TYPE_USB > > as parameter. > > > > Signe

Re: [PATCH net-next 1/5] r8152: use generic USB macros to define product table

2020-11-03 Thread Marek Behún
On Wed, 4 Nov 2020 01:57:10 + Hayes Wang wrote: > Marek Behún > > Sent: Wednesday, November 4, 2020 3:22 AM > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > > index b1770489aca5..85dda591c838 100644 > > --- a/drivers/net/usb/r8152.c > > +++ b/drivers/net/usb/r8152.c > > @

[PATCH net-next] sctp: bring inet(6)_skb_parm back to sctp_input_cb

2020-11-03 Thread Xin Long
inet(6)_skb_parm was removed from sctp_input_cb by Commit a1dd2cf2f1ae ("sctp: allow changing transport encap_port by peer packets"), as it thought sctp_input_cb->header is not used any more in SCTP. syzbot reported a crash: [ ] BUG: KASAN: use-after-free in decode_session6+0xe7c/0x1580 [ ]

RE: [PATCH net-next 1/5] r8152: use generic USB macros to define product table

2020-11-03 Thread Hayes Wang
Marek Behún > Sent: Wednesday, November 4, 2020 2:03 PM [...] > BTW Hayes, is it possible for me gaining access to Realtek > documentation for these chips under NDA? For example via my employer, > CZ.NIC? I can't find any such information on Realtek website. I have to ask my boss. Maybe I reply

Re: [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined

2020-11-03 Thread Lee Jones
On Tue, 03 Nov 2020, Jakub Kicinski wrote: > On Mon, 2 Nov 2020 11:44:43 + Lee Jones wrote: > > When AIX_EVENT is not defined, the 'if' body will be empty, which > > makes GCC complain. Place bracketing around the invocation to protect > > it. > > > > Fixes the following W=1 kernel build wa

Re: [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined

2020-11-03 Thread Lee Jones
On Wed, 04 Nov 2020, Lee Jones wrote: > On Tue, 03 Nov 2020, Jakub Kicinski wrote: > > > On Mon, 2 Nov 2020 11:44:43 + Lee Jones wrote: > > > When AIX_EVENT is not defined, the 'if' body will be empty, which > > > makes GCC complain. Place bracketing around the invocation to protect > > > i

<    1   2   3   4