On 11/2/20 10:25 PM, Yunsheng Lin wrote:
> commit 2fb541c862c9 ("net: sch_generic: aviod concurrent reset and
enqueue op for lockless qdisc")
>
> When the above upstream commit is backported to stable kernel,
> one assignment is missing, which causes two problems reported
> by Joakim and Vishwan
Zero-fill element values for all other cpus than current, just as
when not using prealloc. This is the only way the bpf program can
ensure known initial values for all cpus ('onallcpus' cannot be
set when coming from the bpf program).
The scenario is: bpf program inserts some elements in a per-cpu
On Tue, 3 Nov 2020 13:02:26 +0530 Allen Pais wrote:
> >
> >> @@ -815,7 +815,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct
> >> usb_interface *intf, u8 data_
> >>
> >>hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> >>ctx->tx_timer.function = &cdc_ncm_tx_ti
On Mon, Nov 2, 2020 at 5:33 PM Martin KaFai Lau wrote:
>
> On Mon, Nov 02, 2020 at 04:49:42PM -0800, Alexander Duyck wrote:
> > On Mon, Nov 2, 2020 at 4:38 PM Martin KaFai Lau wrote:
> > >
> > > On Sat, Oct 31, 2020 at 11:52:18AM -0700, Alexander Duyck wrote:
> > > > From: Alexander Duyck
> > >
On 11/3/20 2:36 PM, Ondrej Ille wrote:
> Hello Marc,
>
> thank you for review, I appreciate it. We will process all your notes, and get
> rid of uin32_t and bitfields then.
>
> As Pavel pointed out, there are user space tests using this stuff, so it is
> not just search and replace work. We will
On Thu, Oct 29, 2020 at 10:10:56AM +0200, Claudiu Manoil wrote:
> When PTP timestamping is enabled on Tx, the controller
> inserts the Tx timestamp at the beginning of the frame
> buffer, between SFD and the L2 frame header. This means
> that the skb provided by the stack is required to have
> eno
On Tue, 3 Nov 2020 10:32:41 +0100 Greg Kroah-Hartman wrote:
> On Mon, Nov 02, 2020 at 11:47:18AM -0800, Jakub Kicinski wrote:
> > On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote:
> > > Jakub Kicinski
> > > > Can you describe the use case in more detail?
> > > >
> > > > AFAICT r8152 defines
Hello.
On 02.11.20 12:45, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/net/ieee802154/ca8210.c:724: warning: Function parameter or member
'cas_ctl' not described in 'ca8210_rx_done'
drivers/net/ieee802154/ca8210.c:724: warning: Excess function parameter
'cas_c
Hello.
On 02.11.20 12:45, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/net/ieee802154/ca8210.c:326: warning: Function parameter or member
'readq' not described in 'ca8210_test'
drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member
'spi_tra
On Tue, Nov 03, 2020 at 07:01:05PM +0530, Radhey Shyam Pandey wrote:
> From: Shravya Kumbham
>
> Add ret variable, conditions to check the return value and it's error
> path for of_address_to_resource() and phy_read() functions.
>
> Addresses-Coverity: Event check_return value.
Hi Radhey
This
On Tue, 3 Nov 2020 10:19:55 +
David Laight wrote:
> From: Jakub Kicinski
> > Sent: 03 November 2020 00:01
> >
> > On Sat, 31 Oct 2020 18:40:28 +0100 Andrew Lunn wrote:
> > > In function ‘strncpy’,
> > > inlined from ‘sky2_name’ at
> > > drivers/net/ethernet/marvell/sky2.c:4903:3,
> >
On Mon, 2020-11-02 at 22:38 +0800, Menglong Dong wrote:
> From: Menglong Dong
>
> This commit seems make no sense, as bridge is destroyed when
> br_multicast_dev_del is called.
>
> In commit b1b9d366028f
> ("bridge: move bridge multicast cleanup to ndo_uninit"), Xin Long
> fixed the use-after-fr
On Tue, 3 Nov 2020 08:25:01 -0800
Stephen Hemminger wrote:
> On Tue, 3 Nov 2020 10:19:55 +
> David Laight wrote:
>
> > From: Jakub Kicinski
> > > Sent: 03 November 2020 00:01
> > >
> > > On Sat, 31 Oct 2020 18:40:28 +0100 Andrew Lunn wrote:
> > > > In function ‘strncpy’,
> > > >
On Tue, 3 Nov 2020 18:13:19 +0200 Vladimir Oltean wrote:
> [14538.046926] PC is at skb_release_data+0x6c/0x14c
> [14538.051518] LR is at consume_skb+0x38/0xd8
> [14538.055588] pc : []lr : []psr: 200f0013
> [14538.061817] sp : c28f1da8 ip : fp : c265aa40
> [14538.067010] r10:
Hi,
> > + if (ctx->idx_svc == ctx->start_svc && ctx->last_svc != svc)
> > + return 0;
> > +
> > + if (ctx->idx_svc > ctx->start_svc) {
> > + if (ip_vs_genl_dump_service(skb, svc, cb) < 0) {
> > + ctx->idx_svc--;
> > + return -
On 03.11.20 18:13, Vladimir Oltean wrote:
> On Thu, Oct 29, 2020 at 10:10:56AM +0200, Claudiu Manoil wrote:
>> When PTP timestamping is enabled on Tx, the controller
>> inserts the Tx timestamp at the beginning of the frame
>> buffer, between SFD and the L2 frame header. This means
>> that the skb
> -Original Message-
> From: Camelia Groza
> Sent: Monday, November 2, 2020 20:35
> To: willemdebruijn.ker...@gmail.com; Madalin Bucur (OSS)
> ; da...@davemloft.net; k...@kernel.org
> Cc: netdev@vger.kernel.org; Camelia Alexandra Groza
>
> Subject: [PATCH net v3 0/2] dpaa_eth: buffer layo
On Sun, Nov 01, 2020 at 02:50:55PM +0200, Ioana Ciornei wrote:
> From: Ioana Ciornei
>
> This patch set aims to actually add support for shared interrupts in
> phylib and not only for multi-PHY devices. While we are at it,
> streamline the interrupt handling in phylib.
Hi Ioana
I did some quick
On Tue, 03 Nov 2020 16:22:07 +0100 Paolo Abeni wrote:
> On Mon, 2020-11-02 at 14:54 -0800, Jakub Kicinski wrote:
> > On Fri, 30 Oct 2020 12:16:00 +0100 Paolo Abeni wrote:
> > > Real-time setups try hard to ensure proper isolation between time
> > > critical applications and e.g. network processin
Andrew
On 10/30/20 2:56 PM, Andrew Lunn wrote:
On Fri, Oct 30, 2020 at 12:29:48PM -0500, Dan Murphy wrote:
Per the 802.3cg spec the 10base T1L can operate at 2 different
differential voltages 1v p2p and 2.4v p2p. The abiility of the PHY to
drive that output is dependent on the PHY's on board po
On Tue, 3 Nov 2020 10:51:00 + Vladimir Oltean wrote:
> On Mon, Nov 02, 2020 at 12:34:11PM -0800, Florian Fainelli wrote:
> > On 11/1/2020 11:16 AM, Vladimir Oltean wrote:
> > > Now that we have a central TX reallocation procedure that accounts for
> > > the tagger's needed headroom in a gener
On Tue, 3 Nov 2020 15:46:27 +0100 Heiner Kallweit wrote:
> On 02.11.2020 23:36, Saeed Mahameed wrote:
> > On Sun, 2020-11-01 at 13:33 +0100, Heiner Kallweit wrote:
> >> It's a frequent pattern to use netdev->stats for the less frequently
> >> accessed counters and per-cpu counters for the frequen
Andrew
On 10/30/20 3:15 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+ int mst_slave_cfg;
+ int ret = 0;
+
+ if (phy_interface_is_rgmii(phydev)) {
+ if (dp83td510
> Do you have any issue with the property being in the ethernet-phy.yaml?
It seems generic enough. Increasing the voltage increases the power
requirements, and maybe not all boards are capable of that.
Andrew
>-Original Message-
>From: Julian Wiedmann
>Sent: Tuesday, November 3, 2020 6:37 PM
>To: Vladimir Oltean ; Claudiu Manoil
>
>Cc: netdev@vger.kernel.org; David S . Miller ; Jakub
>Kicinski ; james.jur...@ametek.com
>Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
Hello
On 10/30/20 6:03 PM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that supports 10M single pair cable.
The device supports both 2.4-V p2p and 1-V p2p output voltage as defined
by IEEE 8
On Tue, 3 Nov 2020 17:08:43 + Claudiu Manoil wrote:
> >> Still crashes for me:
> >>
> >
> >Given the various skb modifications in its xmit path, I wonder why
> >gianfar doesn't clear IFF_TX_SKB_SHARING.
>
> Hi Vladimir,
> Can you try the above suggestion on your setup?
While it is somethi
> On Nov 2, 2020, at 10:31 PM, Andrii Nakryiko
> wrote:
>
> On Mon, Nov 2, 2020 at 9:59 PM Song Liu wrote:
>>
>>
>>
>>> On Nov 2, 2020, at 9:25 PM, Andrii Nakryiko
>>> wrote:
>>>
>>> On Mon, Nov 2, 2020 at 6:49 PM Song Liu wrote:
> On Oct 28, 2020, at 5:58 PM, An
This patch adds a new network driver implementing MHI transport for
network packets. Packets can be in any format, though QMAP (rmnet)
is the usual protocol (flow control + PDN mux).
It support two MHI devices, IP_HW0 which is, the path to the IPA
(IP accelerator) on qcom modem, And IP_SW0 which i
This function can be used by client driver to determine whether it's
possible to queue new elements in a channel ring.
Signed-off-by: Loic Poulain
Reviewed-by: Manivannan Sadhasivam
---
v1->v5: not part of the series
v6: Add this commit, used for stopping TX queue
v7: no change
v8: remove st
>-Original Message-
>From: Jakub Kicinski
>Sent: Tuesday, November 3, 2020 6:31 PM
>To: Vladimir Oltean
>Cc: Claudiu Manoil ; netdev@vger.kernel.org;
>David S . Miller ; james.jur...@ametek.com
>Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
>skb_cow_head for P
On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote:
> Andrew
>
> On 10/30/20 3:15 PM, Andrew Lunn wrote:
> > > +static int dp83td510_config_init(struct phy_device *phydev)
> > > +{
> > > + struct dp83td510_private *dp83td510 = phydev->priv;
> > > + int mst_slave_cfg;
> > > + int ret = 0;
>
On Tue, Nov 03, 2020 at 06:36:30PM +0200, Julian Wiedmann wrote:
> Given the various skb modifications in its xmit path, I wonder why
> gianfar doesn't clear IFF_TX_SKB_SHARING.
Thanks for the hint Julian :) I'll try to see if it makes any
difference.
Just a wild guess, but maybe because the gian
On 11/2/20 10:48 PM, Hangbin Liu wrote:
>
> The iproute2_* functions need access static struct bpf_elf_ctx __ctx;
> We need move the struct bpf_elf_ctx to another header file if add the
> iproute2_* functions to compat file. Do you still want this?
>
ok, leave it in legacy for now.
On Tue, Nov 03, 2020 at 11:09:44AM -0600, Dan Murphy wrote:
> Hello
>
> On 10/30/20 6:03 PM, Jakub Kicinski wrote:
> > On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
> > > The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
> > > that supports 10M single pair cable.
> >
From: Nikolay Aleksandrov
Factor out mcast_packet_test into lib.sh so it can be later extended and
reused by MLDv2 tests.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_igmp.sh | 32 ---
tools/testing/selftests/net/forwarding/lib.sh | 32 ++
Andrew
On 11/3/20 11:21 AM, Andrew Lunn wrote:
On Tue, Nov 03, 2020 at 11:09:44AM -0600, Dan Murphy wrote:
Hello
On 10/30/20 6:03 PM, Jakub Kicinski wrote:
On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote:
The DP83TD510E is an ultra-low power Ethernet physical layer transceiver
that suppo
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) IS_EX (A) EXCLUDE (A-Y, Y*A) (A-X-Y)=MALI
Delete (X-A)
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) TO_EX (A) EXCLUDE (A-Y,Y*A)(A-X-Y) =
Filter Timer
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) ALLOW (B) INCLUDE (A+B)(B)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 29 +++
From: Nikolay Aleksandrov
Add the initial setup for MLDv2 tests with the first test of a simple
is_include report. For MLDv2 we need to setup the bridge properly and we
also send the full precooked packets instead of relying on mausezahn to
fill in some parts. For verification we use the generic
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) IS_IN (A) EXCLUDE (X+A, Y-A) (A)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 30 +++
From: Nikolay Aleksandrov
In order to test an IPv6 multicast packet we need to pass different tc
and mausezahn protocols only, so add a simple check for the destination
address which decides if we should generate an IPv4 or IPv6 mcast
packet.
Signed-off-by: Nikolay Aleksandrov
---
tools/testin
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) BLOCK (A) EXCLUDE (X+(A-Y),Y) (A-X-Y) =
Filter Timer
From: Nikolay Aleksandrov
Hi,
This is the second selftests patch-set for the new multicast functionality
which adds tests for the bridge's MLDv2 support. The tests use full
precooked packets which are sent via mausezahn and the resulting state
after each test is checked for proper X,Y sets, (*,G)
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) IS_IN (B) INCLUDE (A+B) (B)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 29 +++
On Tue, Nov 03, 2020 at 09:12:26AM -0800, Jakub Kicinski wrote:
> While it is something to be fixed - is anything other than pktgen
> making use of IFF_TX_SKB_SHARING? Are you running pktgen, Vladimir?
Nope, just iperf3 TCP and PTP. The problem is actually with PTP, I've
been testing gianfar with
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
EXCLUDE (X,Y) ALLOW (A) EXCLUDE (X+A,Y-A)(A)=MALI
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 30 +++
From: Nikolay Aleksandrov
When we have *,G ports in exclude mode and a new S,G,port is added
the kernel has to automatically create an S,G entry for each exclude
port to get proper forwarding.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 31 +++
From: Nikolay Aleksandrov
Factor out S,G entry state checking functions for existence, forwarding,
blocking and timer to lib.sh so they can be later used by MLDv2 tests.
Add brmcast_ suffix to their name to make the relation to the bridge
explicit.
Signed-off-by: Nikolay Aleksandrov
---
.../se
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) TO_EX (B) EXCLUDE (A*B,B-A)(B-A)=0
Delete (A-B)
From: Nikolay Aleksandrov
Test that when a group in exclude mode expires it changes mode to
include and the blocked entries are deleted.
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 48 ++-
1 file changed, 47 insertions(+), 1 deletion(-
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) BLOCK (B) INCLUDE (A) Send Q(MA,A*B)
Signed-off-by: Nikolay Aleksandrov
---
.../selftests/net/forwarding/bridge_mld.sh| 37 +
From: Nikolay Aleksandrov
The test checks for the following case:
Router State Report Received New Router State Actions
INCLUDE (A) IS_EX (B) EXCLUDE (A*B, B-A) (B-A)=0
Delete (A-B)
On Tue, Nov 03, 2020 at 07:18:49PM +0200, Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 06:36:30PM +0200, Julian Wiedmann wrote:
> > Given the various skb modifications in its xmit path, I wonder why
> > gianfar doesn't clear IFF_TX_SKB_SHARING.
>
> Thanks for the hint Julian :) I'll try to see
On Tue, Nov 03, 2020 at 05:18:25PM +, Claudiu Manoil wrote:
> It's either the dev_kfree_skb_any from the dma mapping error path or the one
> from skb_cow_head()'s error path. A confirmation would help indeed.
It says "consume", not "kfree", which in my mind would make it point
towards the onl
On 11/3/2020 2:51 AM, Vladimir Oltean wrote:
> On Mon, Nov 02, 2020 at 12:34:11PM -0800, Florian Fainelli wrote:
>> On 11/1/2020 11:16 AM, Vladimir Oltean wrote:
>>> Now that we have a central TX reallocation procedure that accounts for
>>> the tagger's needed headroom in a generic way, we can r
On 11/2/20 10:54 PM, Hangbin Liu wrote:
> On Mon, Nov 02, 2020 at 08:37:37AM -0700, David Ahern wrote:
>> On 10/29/20 9:11 AM, Hangbin Liu wrote:
>>> This patch adds a check to see if we support libbpf. By default the
>>> system libbpf will be used, but static linking against a custom libbpf
>>> ve
On 11/3/20 1:46 AM, Daniel Borkmann wrote:
> I thought last time this discussion came up there was consensus that the
> submodule could be an explicit opt in for the configure script at least?
I do not recall Stephen agreeing to that, and I certainly did not.
Andrew
On 11/3/20 11:18 AM, Andrew Lunn wrote:
On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote:
Andrew
On 10/30/20 3:15 PM, Andrew Lunn wrote:
+static int dp83td510_config_init(struct phy_device *phydev)
+{
+ struct dp83td510_private *dp83td510 = phydev->priv;
+ int mst
On Tue, 3 Nov 2020 19:30:07 +0200 Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 05:18:25PM +, Claudiu Manoil wrote:
> > It's either the dev_kfree_skb_any from the dma mapping error path or the one
> > from skb_cow_head()'s error path. A confirmation would help indeed.
>
> It says "consum
On Tue, Nov 03, 2020 at 07:24:41PM +0200, Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 09:12:26AM -0800, Jakub Kicinski wrote:
> > While it is something to be fixed - is anything other than pktgen
> > making use of IFF_TX_SKB_SHARING? Are you running pktgen, Vladimir?
>
> Nope, just iperf3 TCP
> > > > drivers/net/phy/dp83td510.c:70:11: warning: symbol
> > > > 'dp83td510_feature_array' was not declared. Should it be static?
> > > I did not see this warning. Did you use W=1?
> > I _think_ that one is W=1. All the PHY drivers are W=1 clean, and i
> > want to keep it that way. And i hope to
On Tue, 3 Nov 2020 09:36:55 -0800 Jakub Kicinski wrote:
> On Tue, 3 Nov 2020 19:30:07 +0200 Vladimir Oltean wrote:
> > On Tue, Nov 03, 2020 at 05:18:25PM +, Claudiu Manoil wrote:
> > > It's either the dev_kfree_skb_any from the dma mapping error path or the
> > > one
> > > from skb_cow_head(
>-Original Message-
>From: Vladimir Oltean
>Sent: Tuesday, November 3, 2020 7:30 PM
>To: Claudiu Manoil
>Cc: Jakub Kicinski ; netdev@vger.kernel.org; David S .
>Miller ; james.jur...@ametek.com
>Subject: Re: [PATCH net v2 1/2] gianfar: Replace skb_realloc_headroom with
>skb_cow_head for P
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Tuesday, November 3, 2020 7:21 PM
> To: George Cherian
> Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller
> ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> Geethasowjanya Akula ;
Hello,
syzbot found the following issue on:
HEAD commit:04a55c94 Merge tag 'mac80211-for-net-2020-10-30' of git://..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=12079c3a50
kernel config: https://syzkaller.appspot.com/x/.config?x=803dd96a0e492ac1
dashboar
On 11/3/20 1:42 AM, Jiri Benc wrote:
> And I'm convinced this is the way to go for libraries, too: put an
> emphasis on API stability. Make it easy to get consumed and updated
> under the hood. Everybody wins this way.
exactly. Libraries should export well thought out, easy to use, stable
APIs. Ma
On Tue, Nov 3, 2020 at 9:36 AM David Ahern wrote:
>
> On 11/3/20 1:46 AM, Daniel Borkmann wrote:
> > I thought last time this discussion came up there was consensus that the
> > submodule could be an explicit opt in for the configure script at least?
>
> I do not recall Stephen agreeing to that, a
On Tue, Nov 3, 2020 at 12:42 AM Jiri Benc wrote:
> sight, this sounds easier for the developers. Why bother with dynamic
> linking at all? Everything can be linked statically.
That's exactly what some companies do.
Linking everything statically provides stronger security.
On Tue, Nov 03, 2020 at 05:41:36PM +, Claudiu Manoil wrote:
> This is the patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=d145c9031325fed963a887851d9fa42516efd52b
>
> are you sure you have it applied?
Actually? No, I didn't have it applied... I had thought t
On Tue, Nov 03, 2020 at 09:36:55AM -0800, Jakub Kicinski wrote:
> IIRC we did this because too many drivers used dev_kfree_skb
> incorrectly and made the dropwatch output very noisy.
Nice, so that's why the drop monitor never complains with my misplaced
dev_kfree_skb_any calls...
Network problems with RTL8125B have been reported [0] and with help
from Realtek it turned out that this chip version has a hw problem
with short packets (similar to RTL8168evl). Having said that activate
the same workaround as for RTL8168evl.
Realtek suggested to activate the workaround for RTL812
On Mon, Nov 02, 2020 at 10:27:20PM -0800, Andrii Nakryiko wrote:
> On Mon, Nov 2, 2020 at 9:10 PM Alexei Starovoitov
> wrote:
> >
> > On Wed, Oct 28, 2020 at 05:58:59PM -0700, Andrii Nakryiko wrote:
> > > @@ -2942,6 +2948,13 @@ struct btf_dedup {
> > > __u32 *hypot_list;
> > > size_t h
On Tue, Nov 3, 2020 at 12:43 PM George Cherian wrote:
>
> Hi Willem,
>
>
> > -Original Message-
> > From: Willem de Bruijn
> > Sent: Tuesday, November 3, 2020 7:21 PM
> > To: George Cherian
> > Cc: Network Development ; linux-kernel > ker...@vger.kernel.org>; Jakub Kicinski ; David Mill
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Tuesday, November 3, 2020 7:21 PM
> To: George Cherian
> Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller
> ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> Geethasowjanya Akula ;
Hi Willem,
> -Original Message-
> From: Willem de Bruijn
> Sent: Tuesday, November 3, 2020 11:26 PM
> To: George Cherian
> Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller
> ; Sunil Kovvuri Goutham
> ; Linu Cherian ;
> Geethasowjanya Akula ;
On Tue, Nov 03, 2020 at 09:32:38AM -0800, Florian Fainelli wrote:
> the length verification is done after the Broadcom tag is stripped off
> the ingress packet.
Aha, that makes sense. So to the DSA master it has the proper length,
but to the switch it doesn't. Interesting problem. It must mean tha
The interrupt handling of the RS911x is particularly heavy. For each RX
packet, the card does three SDIO transactions, one to read interrupt
status register, one to RX buffer length, one to read the RX packet(s).
This translates to ~330 uS per one cycle of interrupt handler. In case
there is more i
The inner do { ... } while loop is completely useless, all it does
is iterate over a switch-case statement, one bit at a time. This
can easily be replaced by simple if (status & bit) { ... } tests
for each bit. No functional change.
Signed-off-by: Marek Vasut
Cc: Angus Ainslie
Cc: David S. Mille
On Tue, Nov 03, 2020 at 07:42:46AM -0800, Alexander Duyck wrote:
> On Mon, Nov 2, 2020 at 5:26 PM Martin KaFai Lau wrote:
> >
> > On Sat, Oct 31, 2020 at 11:52:37AM -0700, Alexander Duyck wrote:
> > [ ... ]
> >
> > > +struct tcpbpf_globals global = { 0 };
> > > int _version SEC("version") = 1;
>
On Tue, Nov 03, 2020 at 09:04:11AM -0800, Jakub Kicinski wrote:
> In a recent discussion I was wondering if it makes sense to add the
> padding len to struct net_device, with similar best-effort semantics
> to needed_*room. It'd be a u8, so little worry about struct size.
What would that mean in p
On Tue, Nov 03, 2020 at 07:49:06PM +0200, Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 05:41:36PM +, Claudiu Manoil wrote:
> > This is the patch:
> > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=d145c9031325fed963a887851d9fa42516efd52b
> >
> > are you sure you
On 11/3/20 6:49 PM, Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 05:41:36PM +, Claudiu Manoil wrote:
>> This is the patch:
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=d145c9031325fed963a887851d9fa42516efd52b
>>
>> are you sure you have it applied?
>
> Ac
On Tue, Nov 3, 2020 at 7:49 AM David Verbeiren
wrote:
>
> Zero-fill element values for all other cpus than current, just as
> when not using prealloc. This is the only way the bpf program can
> ensure known initial values for all cpus ('onallcpus' cannot be
> set when coming from the bpf program).
On Tue, 3 Nov 2020 09:47:00 -0800
Alexei Starovoitov wrote:
> On Tue, Nov 3, 2020 at 9:36 AM David Ahern wrote:
> >
> > On 11/3/20 1:46 AM, Daniel Borkmann wrote:
> > > I thought last time this discussion came up there was consensus that the
> > > submodule could be an explicit opt in for the
On Mon, Nov 2, 2020 at 3:41 AM David Verbeiren
wrote:
>
> On Thu, Oct 29, 2020 at 11:37 PM Andrii Nakryiko
> wrote:
> >
> > On Thu, Oct 29, 2020 at 11:36 AM Song Liu wrote:
> > >
> > > On Thu, Oct 29, 2020 at 4:19 AM David Verbeiren
> > > wrote:
> > > >
> > > > Tests that when per-cpu hash map
On Sat, Oct 31, 2020 at 11:52 AM Alexander Duyck
wrote:
>
> From: Alexander Duyck
>
> Recently a bug was missed due to the fact that test_tcpbpf_user is not a
> part of test_progs. In order to prevent similar issues in the future move
> the test functionality into test_progs. By doing this we can
On Tue, 3 Nov 2020 18:15:29 + Vladimir Oltean wrote:
> On Tue, Nov 03, 2020 at 09:04:11AM -0800, Jakub Kicinski wrote:
> > In a recent discussion I was wondering if it makes sense to add the
> > padding len to struct net_device, with similar best-effort semantics
> > to needed_*room. It'd be a
On Sat, Oct 31, 2020 at 11:52 AM Alexander Duyck
wrote:
>
> From: Alexander Duyck
>
> There is already logic in test_progs.h for asserting that a value is
> expected to be another value. So instead of reinventing it we should just
> make use of ASSERT_EQ in tcpbpf_user.c. This will allow for bett
On Tue, 3 Nov 2020 08:35:09 +0100 Paul Menzel wrote:
> According to *Developer's Certificate of Origin 1.1* [3], it’s my
> understanding, that it is *not* required. The items (a), (b), and (c)
> are connected by an *or*.
>
> > (b) The contribution is based upon previous work that, to the
On Sat, Oct 31, 2020 at 11:52 AM Alexander Duyck
wrote:
>
> From: Alexander Duyck
>
> Use global variables instead of global_map and sockopt_results_map to track
> test data. Doing this greatly simplifies the code as there is not need to
> take the extra steps of updating the maps or looking up e
On 11/2/20 11:19 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20201102:
>
on x86_64:
when CONFIG_BRIDGE=m:
ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in function
`prestera_bridge_port_event':
prestera_switchdev.c:(.text+0x2ebd): undefined reference to `br_vlan_
On Tue, 3 Nov 2020 16:37:26 + Camelia Alexandra Groza wrote:
> > Subject: [PATCH net v3 0/2] dpaa_eth: buffer layout fixes
> >
> > The patches are related to the software workaround for the A050385
> > erratum.
> > The first patch ensures optimal buffer usage for non-erratum scenarios. The
> >
On Tue, Nov 3, 2020 at 5:41 AM Oliver Herms
wrote:
>
> Due to the legacy usage of hard_header_len for SIT tunnels while
> already using infrastructure from net/ipv4/ip_tunnel.c the
> calculation of the path MTU in tnl_update_pmtu is incorrect.
> This leads to unnecessary creation of MTU exceptions
On Tue, Nov 3, 2020 at 1:41 AM Magnus Karlsson
wrote:
>
> From: Magnus Karlsson
>
> Fix a possible null pointer dereference in xsk_socket__delete that
> will occur if a null pointer is fed into the function.
>
> Fixes: 2f6324a3937f ("libbpf: Support shared umems between queues and
> devices")
>
On Tue, 3 Nov 2020 10:55:19 +0800 Pujin Shi wrote:
> For older versions of gcc, the array = {0}; will cause warnings:
Please include the version of gcc which generates this warning here.
> drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':
> drivers/net/ethernet/mscc/ocelot_vc
Describe the two MPTCP sysctls, what the values mean, and the default
settings.
Acked-by: Geliang Tang
Signed-off-by: Mat Martineau
---
Documentation/networking/index.rst| 1 +
Documentation/networking/mptcp-sysctl.rst | 26 +++
MAINTAINERS
From: Paolo Abeni
When the TCP stack splits a packet on the write queue, the tail
half currently lose the associated skb extensions, and will not
carry the DSM on the wire.
The above does not cause functional problems and is allowed by
the RFC, but interact badly with GRO and RX coalescing, as p
On Tue, Nov 3, 2020 at 1:42 AM Magnus Karlsson
wrote:
>
> From: Magnus Karlsson
>
> Fix a possible use after free in xsk_socket__delete that will happen
> if xsk_put_ctx() frees the ctx. To fix, save the umem reference taken
> from the context and just use that instead.
>
> Fixes: 2f6324a3937f ("
101 - 200 of 368 matches
Mail list logo
