Re: [net-next V3 6/8] net: sched: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/sched/sch_atm.c | 8 ---

[PATCH net v2] net: openvswitch: silence suspicious RCU usage warning

2020-11-03 Thread Eelco Chaudron
Silence suspicious RCU usage warning in ovs_flow_tbl_masks_cache_resize() by replacing rcu_dereference() with rcu_dereference_ovsl(). In addition, when creating a new datapath, make sure it's configured under the ovs_lock. Fixes: 9bf24f594c6a ("net: openvswitch: make masks cache size configurable

Re: [PATCH net] net: openvswitch: silence suspicious RCU usage warning

2020-11-03 Thread Eelco Chaudron
On 2 Nov 2020, at 20:51, Jakub Kicinski wrote: > On Mon, 02 Nov 2020 09:52:19 +0100 Eelco Chaudron wrote: >> On 30 Oct 2020, at 22:28, Jakub Kicinski wrote: @@ -1695,6 +1695,9 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct genl_info *info) if (err) go

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread Jiri Benc
On Mon, 2 Nov 2020 22:58:06 -0800, Andrii Nakryiko wrote: > But I don't think I got a real answer as to what's the exact reason > against the submodule. Like what "inappropriate" even means in this > case? Jesper's security argument so far was the only objective > criteria, as far as I can tell. I

Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-03 Thread Lee Jones
On Mon, 02 Nov 2020, Brian Norris wrote: > On Mon, Nov 2, 2020 at 3:25 AM Lee Jones wrote: > > --- a/drivers/net/wireless/realtek/rtw88/pci.h > > +++ b/drivers/net/wireless/realtek/rtw88/pci.h > > @@ -212,6 +212,10 @@ struct rtw_pci { > > void __iomem *mmap; > > }; > > > > +int rtw_pci_p

Re: [PATCHv3 iproute2-next 0/5] iproute2: add libbpf support

2020-11-03 Thread Daniel Borkmann
On 11/3/20 7:58 AM, Andrii Nakryiko wrote: On Mon, Nov 2, 2020 at 7:47 AM David Ahern wrote: On 10/29/20 9:11 AM, Hangbin Liu wrote: This series converts iproute2 to use libbpf for loading and attaching BPF programs when it is available. This means that iproute2 will correctly process BTF info

[PATCH v8 0/4] Add support for mv88e6393x family of Marvell

2020-11-03 Thread Pavana Sharma
Updated patchset with following changes. - Add kerneldoc for 5GBASER phy interface - Remove lane param initialization wherever is it not needed. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane pa

[PATCH v8 1/4] dt-bindings: net: Add 5GBASER phy interface mode

2020-11-03 Thread Pavana Sharma
Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-

[PATCH v8 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

2020-11-03 Thread Pavana Sharma
Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or error (-ENODEV). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 +-- drivers/net/dsa/mv88e6xxx/ch

[PATCH v8 2/4] net: phy: Add 5GBASER interface mode

2020-11-03 Thread Pavana Sharma
Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index eb3cb1a98b45..71e280059ec5 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7 @@

Re: [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format

2020-11-03 Thread Lee Jones
On Mon, 02 Nov 2020, Larry Finger wrote: > On 11/2/20 5:23 AM, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:455: warning: > > Function parameter or member 'txdesc' not described in > > '_rtl_tx_desc_checksum

[PATCH v8 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-11-03 Thread Pavana Sharma
The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Co-developed-by: Ashkan

Re: [PATCH] vhost/vsock: add IOTLB API support

2020-11-03 Thread Jason Wang
On 2020/11/3 上午1:11, Stefano Garzarella wrote: On Fri, Oct 30, 2020 at 07:44:43PM +0800, Jason Wang wrote: On 2020/10/30 下午6:54, Stefano Garzarella wrote: On Fri, Oct 30, 2020 at 06:02:18PM +0800, Jason Wang wrote: On 2020/10/30 上午1:43, Stefano Garzarella wrote: This patch enables the IOT

Re: [PATCH v9 2/2] net: Add mhi-net driver

2020-11-03 Thread Loic Poulain
Hi Jakub, On Mon, 2 Nov 2020 at 23:40, Jakub Kicinski wrote: > > On Fri, 30 Oct 2020 11:48:15 +0100 Loic Poulain wrote: > > This patch adds a new network driver implementing MHI transport for > > network packets. Packets can be in any format, though QMAP (rmnet) > > is the usual protocol (flow co

[net-next v4 0/8]net: convert tasklets to use new tasklet_setup API

2020-11-03 Thread Allen Pais
From: Allen Pais Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the net/* drivers to use the new tasklet_setup() API The following series is based on net-next (9faebeb2d) v3: introduce qdisc_from_priv, su

[net-next v4 1/8] net: dccp: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/dccp/timer.

[net-next v4 8/8] net: xfrm: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/xfrm/xfrm_i

[net-next v4 6/8] net: sched: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- include/net/pkt

[net-next v4 7/8] net: smc: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/smc/smc_cdc

[net-next v4 2/8] net: ipv4: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/ipv4/tcp_ou

[net-next v4 4/8] net: mac802154: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Acked-by: Stefan Schmidt Signed-off-by: Romain Perier Signed-off-by: Allen

[net-next v4 5/8] net: rds: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/rds/ib_cm.c

[net-next v4 3/8] net: mac80211: convert tasklets to use new tasklet_setup() API

2020-11-03 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Reviewed-by: Johannes Berg Signed-off-by: Romain Perier Signed-off-by: Alle

Re: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Greg Kroah-Hartman
On Mon, Nov 02, 2020 at 11:47:18AM -0800, Jakub Kicinski wrote: > On Mon, 2 Nov 2020 07:20:15 + Hayes Wang wrote: > > Jakub Kicinski > > > Can you describe the use case in more detail? > > > > > > AFAICT r8152 defines a match for the exact same device. > > > Does it not mean that which driver

[PATCH bpf 2/2] libbpf: fix possible use after free in xsk_socket__delete

2020-11-03 Thread Magnus Karlsson
From: Magnus Karlsson Fix a possible use after free in xsk_socket__delete that will happen if xsk_put_ctx() frees the ctx. To fix, save the umem reference taken from the context and just use that instead. Fixes: 2f6324a3937f ("libbpf: Support shared umems between queues and devices") Signed-off-

[PATCH bpf 1/2] libbpf: fix null dereference in xsk_socket__delete

2020-11-03 Thread Magnus Karlsson
From: Magnus Karlsson Fix a possible null pointer dereference in xsk_socket__delete that will occur if a null pointer is fed into the function. Fixes: 2f6324a3937f ("libbpf: Support shared umems between queues and devices") Reported-by: Andrii Nakryiko Signed-off-by: Magnus Karlsson --- tools

[PATCH bpf 0/2] libbpf: fix two bugs in xsk_socket__delete

2020-11-03 Thread Magnus Karlsson
This small series fixes two bugs in xsk_socket__delete. Details can be found in the individual commit messages, but a brief summary follows: Patch 1: fix null pointer dereference in xsk_socket__delete Patch 2: fix possible use after free in xsk_socket__delete This patch has been applied against c

[PATCH net-next v3 2/2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Hayes Wang
Support ECM mode based on cdc_ether with relative mii functions, when CONFIG_USB_RTL8152 is not set, or the device is not supported by r8152 driver. Both r8152 and r8153_ecm would check the return value of rtl8152_get_version() in porbe(). If rtl8152_get_version() return none zero value, the r8152

[PATCH net-next v3 1/2] include/linux/usb: new header file for the vendor ID of USB devices

2020-11-03 Thread Hayes Wang
Add a new header file usb_vendor_id.h to consolidate the definitions of the vendor ID of USB devices which may be used by cdc_ether and r8152 driver. Signed-off-by: Hayes Wang --- drivers/net/usb/cdc_ether.c | 139 +- drivers/net/usb/r8152.c | 48

[PATCH net-next v3 0/2] drivers/net/usb: support ECM mode for RTL8153

2020-11-03 Thread Hayes Wang
v3: Move original patch to #2. And add a new patch #1 to consolidate vendor ID of USB devices. v2: Add include/linux/usb/r8152.h to avoid the warning about no previous prototype for rtl8152_get_version. Hayes Wang (2): include/linux/usb: new header file for the vendor ID of USB devices net/us

RE: [PATCH net-next v2] net/usb/r8153_ecm: support ECM mode for RTL8153

2020-11-03 Thread Hayes Wang
Greg Kroah-Hartman > Sent: Tuesday, November 3, 2020 5:33 PM [...] > There is a reason, it's a nightmare to maintain and handle merges for, > just don't do it. > > Read the comments at the top of the pci_ids.h file if you are curious > why we don't even do this for PCI device ids anymore for the

Re: [PATCH net-next v3 1/2] include/linux/usb: new header file for the vendor ID of USB devices

2020-11-03 Thread Greg KH
On Tue, Nov 03, 2020 at 05:46:37PM +0800, Hayes Wang wrote: > diff --git a/include/linux/usb/usb_vendor_id.h > b/include/linux/usb/usb_vendor_id.h > new file mode 100644 > index ..23b6e6849515 > --- /dev/null > +++ b/include/linux/usb/usb_vendor_id.h > @@ -0,0 +1,51 @@ > +/* SPDX-Licen

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-11-03 Thread Pavel Pisa
Hello Marc, thanks for response On Saturday 31 of October 2020 12:35:11 Marc Kleine-Budde wrote: > On 10/30/20 11:19 PM, Pavel Pisa wrote: > > This driver adds support for the CTU CAN FD open-source IP core. > > Please fix the following checkpatch warnings/errors: Yes I recheck with actual check

Re: [PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-03 Thread Bartosz Golaszewski
On Tue, Nov 3, 2020 at 5:14 AM Joe Perches wrote: > > On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Andy brought to my attention the fact that users allocating an array of > > equally sized elements should check if the size multiplication does

RE: [PATCH net-next 6/7] drivers: net: smc911x: Fix cast from pointer to integer of different size

2020-11-03 Thread David Laight
From: Jakub Kicinski > Sent: 02 November 2020 23:48 > > On Sat, 31 Oct 2020 01:49:57 +0100 Andrew Lunn wrote: > > drivers/net/ethernet/smsc/smc911x.c: In function > > ‘smc911x_hardware_send_pkt’: > > drivers/net/ethernet/smsc/smc911x.c:471:11: warning: cast from pointer to > > integer of differe

RE: [PATCH net-next] drivers: net: sky2: Fix -Wstringop-truncation with W=1

2020-11-03 Thread David Laight
From: Jakub Kicinski > Sent: 03 November 2020 00:01 > > On Sat, 31 Oct 2020 18:40:28 +0100 Andrew Lunn wrote: > > In function ‘strncpy’, > > inlined from ‘sky2_name’ at drivers/net/ethernet/marvell/sky2.c:4903:3, > > inlined from ‘sky2_probe’ at drivers/net/ethernet/marvell/sky2.c:5049:2:

[PATCH net-next v2 00/15] net/smc: extend diagnostic netlink interface

2020-11-03 Thread Karsten Graul
Please apply the following patch series for smc to netdev's net-next tree. This patch series refactors the current netlink API in smc_diag module which is used for diagnostic purposes and extends the netlink API in a backward compatible way so that the extended API can provide information about SM

[PATCH net-next v2 10/15] net/smc: Introduce SMCR get link command

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Introduce get link command which loops through all available links of all available link groups. It uses the SMC-R linkgroup list as entry point, not the socket list, which makes linkgroup diagnosis possible, in case linkgroup does not contain active connections anymore. Signe

[PATCH net-next v2 05/15] net/smc: Add diagnostic information to smc ib-device

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce During smc ib-device creation, add network device name to smc ib-device structure. Register for netdevice name changes and update ib-device accordingly. This is needed for diagnostic purposes. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_ib.c |

[PATCH net-next v2 04/15] net/smc: Add link counters for IB device ports

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Add link counters to the structure of the smc ib device, one counter per ib port. Increase/decrease the counters as needed in the corresponding routines. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_core.c | 3 +++ net/smc/smc_ib.h | 1 + 2 fil

[PATCH net-next v2 12/15] net/smc: Add support for obtaining SMCD device list

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Deliver SMCD device information via netlink based diagnostic interface. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc.h | 2 + include/uapi/linux/smc_diag.h | 20 + net/smc/smc_core.h| 27 + net/smc

[PATCH net-next v2 06/15] net/smc: Add diagnostic information to link structure

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce During link creation add network and ib-device name to link structure. This is needed for diagnostic purposes. When diagnostic information is gathered, we need to traverse device, linkgroup and link structures, to be able to do that we need to hold a spinlock for the linkgroup

[PATCH net-next v2 14/15] net/smc: Refactor smc ism v2 capability handling

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Encapsulate the smc ism v2 capability boolean value in a function for better information hiding. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/af_smc.c | 12 ++-- net/smc/smc_ism.c | 9 - net/smc/smc_ism.h | 5 ++--- 3 files changed

[PATCH net-next v2 07/15] net/smc: Refactor the netlink reply processing routine

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Refactor the netlink reply processing routine so that it provides sub functions for specific parts of the processing. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_diag.c | 218 +++-- 1 file changed, 133 ins

[PATCH net-next v2 02/15] net/smc: Use active link of the connection

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Use active link of the connection directly and not via linkgroup array structure when obtaining link data of the connection. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_diag.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) dif

[PATCH net-next v2 03/15] net/smc: Add connection counters for links

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Add connection counters to the structure of the link. Increase/decrease the counters as needed in the corresponding routines. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- net/smc/smc_core.c | 16 ++-- net/smc/smc_core.h | 1 + 2 files changed, 1

[PATCH net-next v2 09/15] net/smc: Introduce SMCR get linkgroup command

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Introduce get linkgroup command which loops through all available SMCR linkgroups. It uses the SMC-R linkgroup list as entry point, not the socket list, which makes linkgroup diagnosis possible, in case linkgroup does not contain active connections anymore. Signed-off-by: Guve

[PATCH net-next v2 13/15] net/smc: Add support for obtaining SMCR device list

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Deliver SMCR device information via netlink based diagnostic interface. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc_diag.h | 6 ++ net/smc/smc_diag.c| 133 ++ net/smc/smc_ib.c

[PATCH net-next v2 01/15] net/smc: use helper smc_conn_abort() in listen processing

2020-11-03 Thread Karsten Graul
The helper smc_connect_abort() can be used by the listen processing functions, too. And rename this helper to smc_conn_abort() to make the purpose clearer. No functional change. Signed-off-by: Karsten Graul --- net/smc/af_smc.c | 17 + 1 file changed, 5 insertions(+), 12 deletion

[PATCH net-next v2 08/15] net/smc: Add ability to work with extended SMC netlink API

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce smc_diag module should be able to work with legacy and extended netlink api. This is done by using the sequence field of the netlink message header. Sequence field is optional and was filled with a constant value MAGIC_SEQ in the current implementation. New constant values MAGI

[PATCH net-next v2 11/15] net/smc: Add SMC-D Linkgroup diagnostic support

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Deliver SMCD Linkgroup information via netlink based diagnostic interface. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc_diag.h | 7 +++ net/smc/smc_diag.c| 108 ++ net/smc/smc_ism.c

[PATCH net-next v2 15/15] net/smc: Add support for obtaining system information

2020-11-03 Thread Karsten Graul
From: Guvenc Gulce Add new netlink command to obtain system information of the smc module. Signed-off-by: Guvenc Gulce Signed-off-by: Karsten Graul --- include/uapi/linux/smc.h | 1 + include/uapi/linux/smc_diag.h | 18 ++ net/smc/smc_clc.c | 6 net/smc/smc_clc

[PATCH] IPv6: Set SIT tunnel hard_header_len to zero

2020-11-03 Thread Oliver Herms
Due to the legacy usage of hard_header_len for SIT tunnels while already using infrastructure from net/ipv4/ip_tunnel.c the calculation of the path MTU in tnl_update_pmtu is incorrect. This leads to unnecessary creation of MTU exceptions for any flow going over a SIT tunnel. As SIT tunnels do not

[PATCH net] net/tls: Fix kernel panic when socket is in TLS ULP

2020-11-03 Thread Vinay Kumar Yadav
user can initialize tls ulp using setsockopt call on socket before listen() in case of tls-toe (TLS_HW_RECORD) and same setsockopt call on connected socket in case of kernel tls (TLS_SW). In presence of tls-toe devices, TLS ulp is initialized, tls context is allocated per listen socket and socket i

Re: [PATCH v3 net-next 09/12] net: dsa: tag_brcm: let DSA core deal with TX reallocation

2020-11-03 Thread Vladimir Oltean
On Mon, Nov 02, 2020 at 12:34:11PM -0800, Florian Fainelli wrote: > On 11/1/2020 11:16 AM, Vladimir Oltean wrote: > > Now that we have a central TX reallocation procedure that accounts for > > the tagger's needed headroom in a generic way, we can remove the > > skb_cow_head call. > > > > Cc: Floria

Re: [PATCH v2 0/8] slab: provide and use krealloc_array()

2020-11-03 Thread Andy Shevchenko
On Tue, Nov 3, 2020 at 12:13 PM Bartosz Golaszewski wrote: > On Tue, Nov 3, 2020 at 5:14 AM Joe Perches wrote: > > On Mon, 2020-11-02 at 16:20 +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > Yeah so I had this concern for devm_krealloc() and even sent a patch > that extended

Re: [PATCH] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-03 Thread yukuai (C)
On 2020/11/03 9:30, Jakub Kicinski wrote: On Sat, 31 Oct 2020 18:54:18 +0800 Yu Kuai wrote: if of_find_device_by_node() succeed, fman_port_probe() doesn't have a corresponding put_device(). Thus add jump target to fix the exception handling for this function implementation. Fixes: 0572054617f

[PATCH V2] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-03 Thread Yu Kuai
if of_find_device_by_node() succeed, fman_port_probe() doesn't have a corresponding put_device(). Thus add jump target to fix the exception handling for this function implementation. Fixes: 0572054617f3 ("fsl/fman: fix dereference null return value") Signed-off-by: Yu Kuai --- .../net/ethernet/f

RE: [PATCH v2 net-next 0/3] fsl/qbman: in_interrupt() cleanup.

2020-11-03 Thread Madalin Bucur
> -Original Message- > From: Sebastian Andrzej Siewior > Sent: 02 November 2020 01:23 > To: netdev@vger.kernel.org > Cc: Horia Geanta ; Aymen Sghaier > ; Herbert Xu ; David S. > Miller ; Madalin Bucur ; Jakub > Kicinski ; Leo Li ; Thomas Gleixner > ; Sebastian Andrzej Siewior > Subject: [

[PATCH net-next 0/2] net: axienet: Dynamically enable MDIO interface

2020-11-03 Thread Radhey Shyam Pandey
This patchset dynamically enable MDIO interface. The background for this change is coming from Cadence GEM controller(macb) in which MDC is active only during MDIO read or write operations while the PHY registers are read or written. It is implemented as an IP feature. For axiethernet as dynam

[PATCH net-next 1/2] net: xilinx: axiethernet: Introduce helper functions for MDC enable/disable

2020-11-03 Thread Radhey Shyam Pandey
Introduce helper functions to enable/disable MDIO interface clock. This change serves a preparatory patch for the coming feature to dynamically control the management bus clock. Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 ++ drivers/net/ethernet

[PATCH net-next 2/2] net: xilinx: axiethernet: Enable dynamic MDIO MDC

2020-11-03 Thread Radhey Shyam Pandey
From: Clayton Rayment MDIO spec does not require an MDC at all times, only when MDIO transactions are occurring. This patch allows the xilinx_axienet driver to disable the MDC when not in use, and re-enable it when needed. It also simplifies the driver by removing MDC disable and enable in device

Re: [PATCH v7 0/6] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

2020-11-03 Thread Marc Kleine-Budde
On 11/3/20 11:00 AM, Pavel Pisa wrote: > On Saturday 31 of October 2020 12:35:11 Marc Kleine-Budde wrote: >> On 10/30/20 11:19 PM, Pavel Pisa wrote: >>> This driver adds support for the CTU CAN FD open-source IP core. >> >> Please fix the following checkpatch warnings/errors: > > Yes I recheck wit

[PATCH -next] dpaa_eth: use false and true for bool variables

2020-11-03 Thread Zou Wei
Fix coccicheck warnings: ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++-- 1 file changed, 2 inserti

Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Herbert Xu
On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > This fixes a regression where valid selectors are incorrectly skipped > when xfrm_state_find is called with a non-matching address family (e.g. > when using IPv6-in-IPv4 ESP in transport mode). > > The state's address family is mat

Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Herbert Xu
On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > This fixes a regression where valid selectors are incorrectly skipped > when xfrm_state_find is called with a non-matching address family (e.g. > when using IPv6-in-IPv4 ESP in transport mode). Why are we even allowing v6-over-v4 i

RE: [PATCH -next] dpaa_eth: use false and true for bool variables

2020-11-03 Thread Madalin Bucur
> -Original Message- > From: Zou Wei > Sent: 03 November 2020 14:05 > To: Madalin Bucur ; da...@davemloft.net; > k...@kernel.org > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Zou Wei > > Subject: [PATCH -next] dpaa_eth: use false and true for bool variables > > Fix cocciche

RE: [PATCH net v3 0/2] dpaa_eth: buffer layout fixes

2020-11-03 Thread Madalin Bucur (OSS)
> -Original Message- > From: Camelia Groza > Sent: 02 November 2020 20:35 > To: willemdebruijn.ker...@gmail.com; Madalin Bucur (OSS) > ; da...@davemloft.net; k...@kernel.org > Cc: netdev@vger.kernel.org; Camelia Alexandra Groza > Subject: [PATCH net v3 0/2] dpaa_eth: buffer layout fixes >

Re: [PATCH bpf-next 0/5] selftests/xsk: xsk selftests

2020-11-03 Thread Weqaar Janjua
On Mon, 2 Nov 2020 at 23:08, Daniel Borkmann wrote: > > On 10/30/20 1:13 PM, Weqaar Janjua wrote: > > This patch set adds AF_XDP selftests based on veth to selftests/xsk/. > > > > # Topology: > > # - > > # --- > > # _ | Process | _ > > # /

RE: [PATCH v2 net-next 0/3] fsl/qbman: in_interrupt() cleanup.

2020-11-03 Thread Camelia Alexandra Groza
> -Original Message- > From: Sebastian Andrzej Siewior > Sent: Monday, November 2, 2020 01:23 > To: netdev@vger.kernel.org > Cc: Horia Geanta ; Aymen Sghaier > ; Herbert Xu ; > David S. Miller ; Madalin Bucur > ; Jakub Kicinski ; Leo Li > ; Thomas Gleixner ; Sebastian > Andrzej Siewior >

Re: lan78xx: /sys/class/net/eth0/carrier stuck at 1

2020-11-03 Thread Juerg Haefliger
On Fri, 23 Oct 2020 15:05:19 +0200 Andrew Lunn wrote: > On Fri, Oct 23, 2020 at 08:29:59AM +0200, Juerg Haefliger wrote: > > On Wed, 21 Oct 2020 21:35:48 +0200 > > Andrew Lunn wrote: > > > > > On Wed, Oct 21, 2020 at 05:00:53PM +0200, Juerg Haefliger wrote: > > > > Hi, > > > > > > > > If t

[net-next,v1,0/5] seg6: add support for SRv6 End.DT4 behavior

2020-11-03 Thread Andrea Mayer
This patchset provides support for the SRv6 End.DT4 behavior. The SRv6 End.DT4 is used to implement multi-tenant IPv4 L3 VPN. It decapsulates the received packets and performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation leverages a VRF device. The

[net-next,v1,1/5] vrf: add mac header for tunneled packets when sniffer is attached

2020-11-03 Thread Andrea Mayer
Before this patch, a sniffer attached to a VRF used as the receiving interface of L3 tunneled packets detects them as malformed packets and it complains about that (i.e.: tcpdump shows bogus packets). The reason is that a tunneled L3 packet does not carry any L2 information and when the VRF is set

[net-next,v1,2/5] seg6: improve management of behavior attributes

2020-11-03 Thread Andrea Mayer
Depending on the attribute (i.e.: SEG6_LOCAL_SRH, SEG6_LOCAL_TABLE, etc), the parse() callback performs some validity checks on the provided input and updates the tunnel state (slwt) with the result of the parsing operation. However, an attribute may also need to reserve some additional resources (

[net-next,v1,5/5] selftests: add selftest for the SRv6 End.DT4 behavior

2020-11-03 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT4 behavior used, in this example, for implementing IPv4 L3 VPN use cases. Signed-off-by: Andrea Mayer --- .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 494 ++ 1 file changed, 494 insertions(+) create mode 100755 tool

[net-next,v1,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-03 Thread Andrea Mayer
SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. The SRv6 End.DT4 is used to implement IPv4 L3VPN use-cases in multi-tenants environments. It decapsulates the received packets and it performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation

[net-next,v1,3/5] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-11-03 Thread Andrea Mayer
We introduce two callbacks used for customizing the creation/destruction of a SRv6 behavior. Such callbacks are defined in the new struct seg6_local_lwtunnel_ops and hereafter we provide a brief description of them: - build_state(...): used for calling the custom constructor of the behavior du

Re: [PATCH] cfg80211: make wifi driver probe

2020-11-03 Thread Kalle Valo
Kelvin Cheung writes: > We are preparing the Wi-Fi driver for Unisoc WCN chips. Please ignore > this draft version. There will be a formal version soon. Ok, I'll drop this. But please don't use HTML in mails, more info in the wiki page below. I recommend reading it all very carefully. -- https

Re: KASAN: use-after-free Read in decode_session6

2020-11-03 Thread Xin Long
On Sun, Nov 1, 2020 at 1:40 PM syzbot wrote: > > syzbot has bisected this issue to: > > commit bcd623d8e9fa5f82bbd8cd464dc418d24139157b > Author: Xin Long > Date: Thu Oct 29 07:05:05 2020 + > > sctp: call sk_setup_caps in sctp_packet_transmit instead > > bisection log: https://syzkalle

[PATCH net-next] net: emaclite: Add error handling for of_address_ and phy read functions

2020-11-03 Thread Radhey Shyam Pandey
From: Shravya Kumbham Add ret variable, conditions to check the return value and it's error path for of_address_to_resource() and phy_read() functions. Addresses-Coverity: Event check_return value. Signed-off-by: Shravya Kumbham Signed-off-by: Radhey Shyam Pandey --- drivers/net/ethernet/xili

[PATCH v6] lib: optimize cpumask_local_spread()

2020-11-03 Thread Shaokun Zhang
From: Yuqi Jin In multi-processor and NUMA system, I/O driver will find cpu cores that which shall be bound IRQ. When cpu cores in the local numa have been used, it is better to find the node closest to the local numa node for performance, instead of choosing any online cpu immediately. Current

Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-03 Thread Willem de Bruijn
> > > static int rvu_devlink_info_get(struct devlink *devlink, struct > > devlink_info_req *req, > > > struct netlink_ext_ack *extack) { @@ > > > -53,7 +483,8 @@ int rvu_register_dl(struct rvu *rvu) > > > rvu_dl->dl = dl; > > > rvu_dl->rvu = rvu; >

Re: KASAN: use-after-free Read in decode_session6

2020-11-03 Thread Xin Long
On Tue, Nov 3, 2020 at 9:14 PM Xin Long wrote: > > On Sun, Nov 1, 2020 at 1:40 PM syzbot > wrote: > > > > syzbot has bisected this issue to: > > > > commit bcd623d8e9fa5f82bbd8cd464dc418d24139157b > > Author: Xin Long > > Date: Thu Oct 29 07:05:05 2020 + > > > > sctp: call sk_setup_cap

[PATCH net-next] enetc: Remove Tx checksumming offload code

2020-11-03 Thread Claudiu Manoil
Tx checksumming has been defeatured and completely removed from the h/w reference manual. Made a little cleanup for the TSE case as this is complementary code. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/freescale/enetc/enetc.c | 51 ++- drivers/net/ethernet/freescale

Re: [RFC PATCH ethtool] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-11-03 Thread Ido Schimmel
On Mon, Nov 02, 2020 at 11:58:03PM +0100, Michal Kubecek wrote: > On Mon, Nov 02, 2020 at 08:40:36PM +0200, Ido Schimmel wrote: > > +static int linkmodes_reply_adver_all_cb(const struct nlmsghdr *nlhdr, > > ^ advert? > > > + void

Re: [PATCH net-next 0/5] net: add and use dev_get_tstats64

2020-11-03 Thread Heiner Kallweit
On 02.11.2020 23:36, Saeed Mahameed wrote: > On Sun, 2020-11-01 at 13:33 +0100, Heiner Kallweit wrote: >> It's a frequent pattern to use netdev->stats for the less frequently >> accessed counters and per-cpu counters for the frequently accessed >> counters (rx/tx bytes/packets). Add a default ndo_g

Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Anthony DeRossi
On Tue, Nov 3, 2020 at 4:05 AM Herbert Xu wrote: > > On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > > This fixes a regression where valid selectors are incorrectly skipped > > when xfrm_state_find is called with a non-matching address family (e.g. > > when using IPv6-in-IPv4 ES

[PATCH v5 5/5] ARM: defconfig: Enable ax88796c driver

2020-11-03 Thread Łukasz Stelmach
Enable ax88796c driver for the ethernet chip on Exynos3250-based ARTIK5 boards. Signed-off-by: Łukasz Stelmach --- arch/arm/configs/exynos_defconfig | 2 ++ arch/arm/configs/multi_v7_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/

[PATCH v5 0/5] AX88796C SPI Ethernet Adapter

2020-11-03 Thread Łukasz Stelmach
This is a driver for AX88796C Ethernet Adapter connected in SPI mode as found on ARTIK5 evaluation board. The driver has been ported from a v3.10.9 vendor kernel for ARTIK5 board. Changes in v5: - coding style (local variable declarations) - added spi0 node in the DT binding example and remove

[PATCH v5 1/5] dt-bindings: vendor-prefixes: Add asix prefix

2020-11-03 Thread Łukasz Stelmach
Add the prefix for ASIX Electronics Corporation. Signed-off-by: Łukasz Stelmach Reviewed-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefi

[PATCH v5 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-11-03 Thread Łukasz Stelmach
Add node for ax88796c ethernet chip. Signed-off-by: Łukasz Stelmach --- arch/arm/boot/dts/exynos3250-artik5-eval.dts | 29 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts index 20446a

Re: [PATCH ipsec] xfrm: Pass template address family to xfrm_state_look_at

2020-11-03 Thread Anthony DeRossi
On Tue, Nov 3, 2020 at 4:08 AM Herbert Xu wrote: > > On Mon, Nov 02, 2020 at 06:32:19PM -0800, Anthony DeRossi wrote: > > This fixes a regression where valid selectors are incorrectly skipped > > when xfrm_state_find is called with a non-matching address family (e.g. > > when using IPv6-in-IPv4 ES

[PATCH v5 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-11-03 Thread Łukasz Stelmach
Add bindings for AX88796C SPI Ethernet Adapter. Signed-off-by: Łukasz Stelmach --- .../bindings/net/asix,ax88796c.yaml | 73 +++ 1 file changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml diff --git a/Documentation/dev

[PATCH v5 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-11-03 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in

Re: [PATCH net-next v2 0/3] net: introduce rps_default_mask

2020-11-03 Thread Paolo Abeni
On Mon, 2020-11-02 at 14:54 -0800, Jakub Kicinski wrote: > On Fri, 30 Oct 2020 12:16:00 +0100 Paolo Abeni wrote: > > Real-time setups try hard to ensure proper isolation between time > > critical applications and e.g. network processing performed by the > > network stack in softirq and RPS is used

Re: [PATCH 30/33] docs: ABI: cleanup several ABI documents

2020-11-03 Thread Bjorn Andersson
On Wed 28 Oct 09:23 CDT 2020, Mauro Carvalho Chehab wrote: [..] > .../ABI/testing/sysfs-class-remoteproc| 14 +- for this: Acked-by: Bjorn Andersson Thanks, Bjorn

Re: lan78xx: /sys/class/net/eth0/carrier stuck at 1

2020-11-03 Thread Andrew Lunn
On Tue, Nov 03, 2020 at 01:47:12PM +0100, Juerg Haefliger wrote: > On Fri, 23 Oct 2020 15:05:19 +0200 > Andrew Lunn wrote: > > > On Fri, Oct 23, 2020 at 08:29:59AM +0200, Juerg Haefliger wrote: > > > On Wed, 21 Oct 2020 21:35:48 +0200 > > > Andrew Lunn wrote: > > > > > > > On Wed, Oct 21, 202

Re: [bpf-next PATCH v2 5/5] selftest/bpf: Use global variables instead of maps for test_tcpbpf_kern

2020-11-03 Thread Alexander Duyck
On Mon, Nov 2, 2020 at 5:26 PM Martin KaFai Lau wrote: > > On Sat, Oct 31, 2020 at 11:52:37AM -0700, Alexander Duyck wrote: > [ ... ] > > > +struct tcpbpf_globals global = { 0 }; > > int _version SEC("version") = 1; > > > > SEC("sockops") > > @@ -105,29 +72,15 @@ int bpf_testcb(struct bpf_sock_o

Re: [bpf-next PATCH v2 4/5] selftests/bpf: Migrate tcpbpf_user.c to use BPF skeleton

2020-11-03 Thread Alexander Duyck
On Mon, Nov 2, 2020 at 4:55 PM Martin KaFai Lau wrote: > > On Sat, Oct 31, 2020 at 11:52:31AM -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > > > Update tcpbpf_user.c to make use of the BPF skeleton. Doing this we can > > simplify test_tcpbpf_user and reduce the overhead involved in s

Re: [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-11-03 Thread Jason Gunthorpe
On Sun, Nov 01, 2020 at 10:15:37PM +0200, Leon Romanovsky wrote: > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c > b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 6c218b47b9f1..5316e51e72d4 100644 > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -1,18 +1,27 @@ > // SPDX-License-Identifier: GPL-2.0 OR

  1   2   3   4   >