Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-21 Thread Michal Kubecek
On Tue, Oct 20, 2020 at 07:39:13AM +, Danielle Ratson wrote: > > -Original Message- > > From: Michal Kubecek > > Sent: Monday, October 19, 2020 4:25 PM > > > > As I said, I meant the extension suggested in my mail as independent of what > > this series is about. For lanes count select

Re: [PATCH] net: xfrm: fix a race condition during allocing spi

2020-10-21 Thread Herbert Xu
On Tue, Oct 20, 2020 at 04:18:00PM +0800, Zhuoliang Zhang wrote: > From: zhuoliang zhang > > we found that the following race condition exists in > xfrm_alloc_userspi flow: > > user threadstate_hash_work thread >

RE: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-21 Thread Danielle Ratson
> -Original Message- > From: Michal Kubecek > Sent: Wednesday, October 21, 2020 10:08 AM > To: Danielle Ratson > Cc: Jiri Pirko ; Andrew Lunn ; Jakub > Kicinski ; Ido Schimmel ; > netdev@vger.kernel.org; da...@davemloft.net; Jiri Pirko > ; f.faine...@gmail.com; mlxsw ; Ido > Schimmel ;

Re: [PATCH v2] rt2x00: save survey for every channel visited

2020-10-21 Thread Stanislaw Gruszka
On Tue, Oct 20, 2020 at 07:43:12PM +, Марков Михаил Александрович wrote: > rt2800 only gives you survey for current channel. > > Survey-based ACS algorithms are failing to perform their job when working > with rt2800. > > Make rt2800 save survey for every channel visited and be able to give a

Re: [PATCH net] net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action()

2020-10-21 Thread Guillaume Nault
On Tue, Oct 20, 2020 at 05:37:22PM -0700, Cong Wang wrote: > On Tue, Oct 20, 2020 at 8:34 AM Guillaume Nault wrote: > > > > We need to jump to the "err_out_locked" label when > > tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits > > with ->tcfa_lock still held. > > > > Fixes: d

[PATCH v2] tg3: Avoid NULL pointer dereference in netif_device_attach()

2020-10-21 Thread Defang Bo
Similar to commit<1b0ff89852d7>("tg3: Avoid NULL pointer dereference in tg3_io_error_detected()") This patch avoids NULL pointer dereference add a check for netdev being NULL on tg3_resume(). Signed-off-by: Defang Bo --- drivers/net/ethernet/broadcom/tg3.c | 2 +- 1 file changed, 1 insertion(+

[PATCH v3] tg3: Avoid NULL pointer dereference in netif_device_attach()

2020-10-21 Thread Defang Bo
Similar to commit<1b0ff89852d7>("tg3: Avoid NULL pointer dereference in tg3_io_error_detected()") This patch avoids NULL pointer dereference add a check for netdev being NULL on tg3_resume(). Signed-off-by: Defang Bo --- drivers/net/ethernet/broadcom/tg3.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-21 Thread Ahmed Abdelsalam
Hi Reji, We are going to send the patch to the mailer in the next days. As for the link local addresses, we can add a check for that and kernel returns error in case of link local and OIF not provided. We will add you and Jakub to the recipients when we send the patch. Best, Ahmed On Tue

RE: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-21 Thread David Laight
From: Benjamin Herrenschmidt > Sent: 21 October 2020 01:00 > > On Wed, 2020-10-21 at 08:36 +1030, Joel Stanley wrote: > > We must ensure the tx descriptor updates are visible before updating > > the tx pointer. > > > > This resolves the tx hangs observed on the 2600 when running iperf: > > To cla

Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump

2020-10-21 Thread Vlad Buslov
On Tue 20 Oct 2020 at 15:29, Jamal Hadi Salim wrote: > On 2020-10-19 11:18 a.m., Vlad Buslov wrote: >> >> On Mon 19 Oct 2020 at 16:48, Jamal Hadi Salim wrote: >>> On 2020-10-18 8:16 a.m., Vlad Buslov wrote: > > [..] > >>> That could be a good thing, no? you get to see the action name with the >

Re: [PATCH net-next 1/6] ethtool: Extend link modes settings uAPI with lanes

2020-10-21 Thread Michal Kubecek
On Wed, Oct 21, 2020 at 07:20:22AM +, Danielle Ratson wrote: > > -Original Message- > > From: Michal Kubecek > > Sent: Wednesday, October 21, 2020 10:08 AM > > > > On Tue, Oct 20, 2020 at 07:39:13AM +, Danielle Ratson wrote: > > > > -Original Message- > > > > From: Michal

Re: [RFC PATCH net-next 1/9] dt-bindings: net: dsa: convert ksz bindings document to yaml

2020-10-21 Thread Christian Eggers
On Wednesday, 21 October 2020, 08:52:01 CEST, Kurt Kanzenbach wrote: > On Mon Oct 19 2020, Christian Eggers wrote: > > Convert the bindings document for Microchip KSZ Series Ethernet switches > > from txt to yaml. > > A few comments/questions below. > > > diff --git a/Documentation/devicetree/bin

Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks

2020-10-21 Thread Michael Tuexen
> On 21. Oct 2020, at 06:16, Xin Long wrote: > > On Wed, Oct 21, 2020 at 5:23 AM Marcelo Ricardo Leitner > wrote: >> >> On Tue, Oct 20, 2020 at 11:15:26PM +0200, Michael Tuexen wrote: On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner wrote: On Tue, Oct 20, 2020 at 05:12:

Re: [RFC PATCH] net: bridge: multicast: add support for L2 entries

2020-10-21 Thread Nikolay Aleksandrov
On Sat, 2020-10-17 at 21:41 +0300, Vladimir Oltean wrote: > From: Nikolay Aleksandrov > > Extend the bridge multicast control and data path to configure routes > for L2 (non-IP) multicast groups. > > The uapi struct br_mdb_entry union u is extended with another variant, > interpretation, mac_add

Re: [RFC PATCH] net: bridge: multicast: add support for L2 entries

2020-10-21 Thread Nikolay Aleksandrov
On Wed, 2020-10-21 at 09:17 +, Nikolay Aleksandrov wrote: > On Sat, 2020-10-17 at 21:41 +0300, Vladimir Oltean wrote: > > From: Nikolay Aleksandrov > > > > Extend the bridge multicast control and data path to configure routes > > for L2 (non-IP) multicast groups. > > > > The uapi struct br_m

Re: [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

2020-10-21 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 01:12:49PM -0600, Robert Hancock wrote: > The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper > operation in 1000BaseX mode. It should be safe to ensure this bit is > disabled in phylink_mii_c22_pcs_config in all cases. > > Signed-off-by: Robert Hancock

[PATCH net] ip_tunnel: fix over-mtu packet send fail without TUNNEL_DONT_FRAGMENT flags

2020-10-21 Thread wenxu
From: wenxu The TUNNEL_DONT_FRAGMENT flags specific the tunnel outer ip can do fragment or not in the md mode. Without the TUNNEL_DONT_FRAGMENT should always do fragment. So it should not care the frag_off in inner ip. Fixes: cfc7381b3002 ("ip_tunnel: add collect_md mode to IPIP tunnel") Signed-

Re: [PATCH v3] net: phy: marvell: add special handling of Finisar modules with 88E1111

2020-10-21 Thread Russell King - ARM Linux admin
On Tue, Oct 20, 2020 at 06:18:21PM -0600, Robert Hancock wrote: > The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E PHY > with a modified PHY ID. Add support for this ID using the 88E > methods. > > By default these modules do not have 1000BaseX auto-negotiation enabled, > w

Re: [PATCH net v2] mpls: load mpls_gso after mpls_iptunnel

2020-10-21 Thread Guillaume Nault
On Tue, Oct 20, 2020 at 02:43:33PM +0300, Alexander Ovechkin wrote: > mpls_iptunnel is used only for mpls encapsuation, and if encaplusated > packet is larger than MTU we need mpls_gso for segmentation. > > Signed-off-by: Alexander Ovechkin > Acked-by: Dmitry Yakunin > --- > net/mpls/mpls_iptun

Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-21 Thread Geert Uytterhoeven
Hi Jakub, On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote: > On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: > > On 20/10/2020 09:38, Geert Uytterhoeven wrote: > > > MPTCP_IPV6 selects IPV6, thus enabling an optional feature the user may > > > not want to enable. Fix this by makin

Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-21 Thread Matthieu Baerts
Hi Geert, On 21/10/2020 11:43, Geert Uytterhoeven wrote: Hi Jakub, On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote: On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: On 20/10/2020 09:38, Geert Uytterhoeven wrote: MPTCP_IPV6 selects IPV6, thus enabling an optional feature the us

Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-21 Thread Geert Uytterhoeven
Hi Matthieu, On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts wrote: > On 21/10/2020 11:43, Geert Uytterhoeven wrote: > > On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote: > >> On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: > >>> On 20/10/2020 09:38, Geert Uytterhoeven wrote: > >>

[PATCH] net treewide: Use skb_is_gso

2020-10-21 Thread Yi Li
This patch introduces the use of the inline func skb_is_gso in place of tests for skb_shinfo(skb)->gso_size. - if (skb_shinfo(skb)->gso_size) + if (skb_is_gso(skb)) - if (unlikely(skb_shinfo(skb)->gso_size)) + if (unlikely(skb_is_gso(skb))) - if (!skb_shinfo(skb)->gso_size) + if (!skb_is_gso(skb

[PATCH net-next RFC] net: dlci: Deprecate the DLCI driver (aka the Frame Relay layer)

2020-10-21 Thread Xie He
I wish to deprecate the Frame Relay layer (dlci.c) in the kernel because we already have a newer and better "HDLC Frame Relay" layer (hdlc_fr.c). Reasons why hdlc_fr.c is better than dlci.c include: 1. dlci.c is dated 1997, while hdlc_fr.c is dated 1999 - 2006, so the later is newer than the form

[PATCH net] mptcp: depends on IPV6 but not as a module

2020-10-21 Thread Matthieu Baerts
Like TCP, MPTCP cannot be compiled as a module. Obviously, MPTCP IPv6' support also depends on CONFIG_IPV6. But not all functions from IPv6 code are exported. To simplify the code and reduce modifications outside MPTCP, it was decided from the beginning to support MPTCP with IPv6 only if CONFIG_IP

Re: [PATCH] mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it

2020-10-21 Thread Matthieu Baerts
Hi Geert, On 21/10/2020 11:52, Geert Uytterhoeven wrote: Hi Matthieu, On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts wrote: On 21/10/2020 11:43, Geert Uytterhoeven wrote: On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote: On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote: On 2

Re: [PATCH] can: vxcan: Fix memleak in vxcan_newlink

2020-10-21 Thread Oliver Hartkopp
On 21.10.20 07:21, Dinghao Liu wrote: When rtnl_configure_link() fails, peer needs to be freed just like when register_netdevice() fails. Signed-off-by: Dinghao Liu Acked-by: Oliver Hartkopp Btw. as the vxcan.c driver bases on veth.c the same issue can be found there! At this point: h

Re: [PATCH bpf-next V3 3/6] bpf: add BPF-helper for MTU checking

2020-10-21 Thread Jesper Dangaard Brouer
On Fri, 9 Oct 2020 16:29:46 -0700 Maciej Żenczykowski wrote: > On Thu, Oct 8, 2020 at 7:09 AM Jesper Dangaard Brouer > wrote: > > > > This BPF-helper bpf_mtu_check() works for both XDP and TC-BPF programs. > > bpf_check_mtu() seems a better name. Okay, we can rename it. I will go through th

[PATCH v3] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Michael S. Tsirkin
This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. When control vq is not negotiated, that commit causes a crash: [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! [ 72.230266] invalid opcode: [#1] PREEMPT SMP [ 72.231172] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5

Re: [PATCH] net: ftgmac100: Fix missing TX-poll issue

2020-10-21 Thread Arnd Bergmann
(replying to my own mail from a different address to deal with the regular one being blacklisted somewhere, sorry for any duplicates) On Wed, Oct 21, 2020 at 9:16 AM Arnd Bergmann wrote: > > On Wed, Oct 21, 2020 at 12:10 AM Benjamin Herrenschmidt > wrote: > > On Tue, 2020-10-20 at 21:49 +0200, A

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-21 Thread Arnd Bergmann
On Wed, Oct 21, 2020 at 12:39 PM Joel Stanley wrote: > > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c > b/drivers/net/ethernet/faraday/ftgmac100.c > index 331d4bdd4a67..15cdfeb135b0 100644 > --- a/drivers/net/ethernet/faraday/ftgmac100.c > +++ b/drivers/net/ethernet/faraday/ftgmac100.c

Re: [PATCH net-next 3/3] macb: support the two tx descriptors on at91rm9200

2020-10-21 Thread Claudiu.Beznea
Hi Willy, On 14.10.2020 19:27, Willy Tarreau wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi Claudiu, > > first, thanks for your feedback! > > On Wed, Oct 14, 2020 at 04:08:00PM +, claudiu.bez...@microchip.com wrote: >>> @@ -3994

Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-21 Thread Henrik Bjoernlund
Thank you for the review. Comments below. The 10/19/2020 09:21, Jakub Kicinski wrote:> > On Mon, 19 Oct 2020 08:51:04 + Henrik Bjoernlund wrote: > > Thank you for the review. Comments below. > > > > The 10/15/2020 10:34, Jakub Kicinski wrote: > > > > > > On Thu, 15 Oct 2020 11:54:15 + Hen

Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO

2020-10-21 Thread Andrew Lunn
> + if (fep->quirks & FEC_QUIRK_CLEAR_SETUP_MII) { > + /* Clear MMFR to avoid to generate MII event by writing MSCR. > + * MII event generation condition: > + * - writing MSCR: > + * - mmfr[31:0]_not_zero & mscr[7:0]_is_zero & > +

[PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Alexandru Ardelean
The ADIN1300/ADIN1200 support cable diagnostics using TDR. The cable fault detection is automatically run on all four pairs looking at all combinations of pair faults by first putting the PHY in standby (clear the LINK_EN bit, PHY_CTRL_3 register, Address 0x0017) and then enabling the diagnostic c

[PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
The LINKING_EN bit is always cleared during reset. Initially it was set during the downshift setup, because it's in the same register as the downshift retry count (PHY_CTRL1). This change moves the handling of LINKING_EN from the downshift handler to the autonegotiation handler. Also, during auton

Re: russell's net-queue question

2020-10-21 Thread Marek Behún
On Tue, 20 Oct 2020 16:45:15 +0100 Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 05:15:39PM +0200, Marek Behún wrote: > > Russell, > > > > I think the following commits in your net-queue should be still made better: > > > > 7f79709b7a15 ("net: phy: pass supported PHY interface

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Andrew Lunn
On Wed, Oct 21, 2020 at 04:51:39PM +0300, Alexandru Ardelean wrote: > The LINKING_EN bit is always cleared during reset. Initially it was set > during the downshift setup, because it's in the same register as the > downshift retry count (PHY_CTRL1). Hi Alexandru For those of us how have not read

Re: [PATCHv2 net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-21 Thread Willem de Bruijn
On Wed, Oct 21, 2020 at 12:20 AM Hangbin Liu wrote: > > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then that fragment should be discarded and > an ICMP Parameter Problem, Code 3, message sho

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 4:58 PM Andrew Lunn wrote: > > On Wed, Oct 21, 2020 at 04:51:39PM +0300, Alexandru Ardelean wrote: > > The LINKING_EN bit is always cleared during reset. Initially it was set > > during the downshift setup, because it's in the same register as the > > downshift retry count

Re: [PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Andrew Lunn
> Signed-off-by: Alexandru Ardelean Hi Alexandru Overall, this looks good. > +static int adin_cable_test_report_trans(int result) > +{ > + int mask; > + > + if (result & ADIN1300_CDIAG_RSLT_GOOD) > + return ETHTOOL_A_CABLE_RESULT_CODE_OK; > + if (result & ADIN1300_CDIAG_

Re: arm64 build broken on linux next 20201021 - include/uapi/asm-generic/unistd.h:862:26: error: array index in initializer exceeds array bounds

2020-10-21 Thread Naresh Kamboju
On Wed, 21 Oct 2020 at 12:06, Marek Szyprowski wrote: > > Hi Naresh, > > On 21.10.2020 07:05, Naresh Kamboju wrote: > > arm64 build broken while building linux next 20201021 tag. > > > > include/uapi/asm-generic/unistd.h:862:26: error: array index in > &

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Andrew Lunn
> The frame-generator is an interesting feature of the PHY, that's not > useful for the current phylib; the PHY can send packages [like a > signal generator], and then these can be looped back, or sent over the > wire. Many PHYs that that. I posted some patches to the list a few years ago adding b

Re: [PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:09 PM Andrew Lunn wrote: > > > Signed-off-by: Alexandru Ardelean > removed my typo-ed email > Hi Alexandru > > Overall, this looks good. > > > +static int adin_cable_test_report_trans(int result) > > +{ > > + int mask; > > + > > + if (result & ADIN1300_CDIAG_RS

Re: [PATCH v3] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Willem de Bruijn
On Wed, Oct 21, 2020 at 8:00 AM Michael S. Tsirkin wrote: > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > When control vq is not negotiated, that commit causes a crash: > > [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! > [ 72.230266] invalid opcode: [#1]

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:13 PM Andrew Lunn wrote: > > > The frame-generator is an interesting feature of the PHY, that's not > > useful for the current phylib; the PHY can send packages [like a > > signal generator], and then these can be looped back, or sent over the > > wire. > removed my typo

Re: [PATCH v3] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Michael S. Tsirkin
On Wed, Oct 21, 2020 at 10:18:20AM -0400, Willem de Bruijn wrote: > On Wed, Oct 21, 2020 at 8:00 AM Michael S. Tsirkin wrote: > > > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > > > When control vq is not negotiated, that commit causes a crash: > > > > [ 72.229171] kernel B

Re: [PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Andrew Lunn
> Actually, I'd also be interested [for this PHY], to report a > "significance impedance" detection, which is similar to the > short-detection that is already done. You can add that as just another element of the enum. > At first, this report would sound like it could be interesting; but > feel f

[PATCH v4] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Michael S. Tsirkin
This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. When control vq is not negotiated, that commit causes a crash: [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! [ 72.230266] invalid opcode: [#1] PREEMPT SMP [ 72.231172] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5

Re: [PATCH v4] Revert "virtio-net: ethtool configurable RXCSUM"

2020-10-21 Thread Willem de Bruijn
On Wed, Oct 21, 2020 at 10:30 AM Michael S. Tsirkin wrote: > > This reverts commit 3618ad2a7c0e78e4258386394d5d5f92a3dbccf8. > > When control vq is not negotiated, that commit causes a crash: > > [ 72.229171] kernel BUG at drivers/net/virtio_net.c:1667! > [ 72.230266] invalid opcode: [#1]

Re: [PATCH 2/2] net: phy: adin: implement cable-test support

2020-10-21 Thread Alexandru Ardelean
On Wed, Oct 21, 2020 at 5:28 PM Andrew Lunn wrote: > > > Actually, I'd also be interested [for this PHY], to report a > > "significance impedance" detection, which is similar to the > > short-detection that is already done. > > You can add that as just another element of the enum. > > > At first,

lan78xx: /sys/class/net/eth0/carrier stuck at 1

2020-10-21 Thread Juerg Haefliger
Hi, If the lan78xx driver is compiled into the kernel and the network cable is plugged in at boot, /sys/class/net/eth0/carrier is stuck at 1 and doesn't toggle if the cable is unplugged and replugged. If the network cable is *not* plugged in at boot, all seems to work fine. I.e., post-boot cable

Re: [PATCH net] mptcp: depends on IPV6 but not as a module

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 12:51:53 +0200 Matthieu Baerts wrote: > Like TCP, MPTCP cannot be compiled as a module. Obviously, MPTCP IPv6' > support also depends on CONFIG_IPV6. But not all functions from IPv6 > code are exported. > > To simplify the code and reduce modifications outside MPTCP, it was > d

[PATCH net] selftests: mptcp: depends on built-in IPv6

2020-10-21 Thread Matthieu Baerts
Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no longer ensure CONFIG_IPV6=y. If it is not enabled, CONFIG_MPTCP_IPV6 will stay disabled and selftests will fail. We also need CONFIG_IPV6 to be built-in. For more

Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-21 Thread Greg KH
On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > From: David Laight > > This lets the compiler inline it into import_iovec() generating > much better code. > > Signed-off-by: David Laight > Signed-off-by: Christoph Hellwig > --- > fs/read_write.c | 179

Re: [PATCH 1/2] net: phy: adin: clear the diag clock and set LINKING_EN during autoneg

2020-10-21 Thread Andrew Lunn
> i'll think about the frame-generator; Here were the two main problems i can remember with my first version: How do you discover what is can actually do? You probably need to collect up all the open PHY datasheets and get an idea what the different vendors provide, what is common, what could be

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-10-21 Thread Richard Guy Briggs
On 2020-10-02 15:52, Richard Guy Briggs wrote: > On 2020-08-21 15:15, Paul Moore wrote: > > On Wed, Jul 29, 2020 at 3:41 PM Richard Guy Briggs wrote: > > > On 2020-07-05 11:10, Paul Moore wrote: > > > > On Sat, Jun 27, 2020 at 9:22 AM Richard Guy Briggs > > > > wrote: > > > > ... > > > > > > >

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-10-21 Thread Steve Grubb
On Wednesday, October 21, 2020 12:39:26 PM EDT Richard Guy Briggs wrote: > > I think I have a way to generate a signal to multiple targets in one > > syscall... The added challenge is to also give those targets different > > audit container identifiers. > > Here is an exmple I was able to generat

Re: [PATCH v3] tg3: Avoid NULL pointer dereference in netif_device_attach()

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 15:38:09 +0800 Defang Bo wrote: > Similar to commit<1b0ff89852d7>("tg3: Avoid NULL pointer dereference in > tg3_io_error_detected()") > This patch avoids NULL pointer dereference add a check for netdev being NULL > on tg3_resume(). > > Signed-off-by: Defang Bo Are you actua

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-21 Thread Chuck Lever
> On Oct 20, 2020, at 3:16 AM, Martijn de Gouw > wrote: > > Hi, > > On 20-10-2020 00:04, J. Bruce Fields wrote: >> On Mon, Oct 19, 2020 at 03:46:39PM +, Martijn de Gouw wrote: >>> Hi >>> >>> On 19-10-2020 17:23, J. Bruce Fields wrote: On Mon, Oct 19, 2020 at 01:42:27PM +0200, Marti

Re: [PATCH] net: phylink: disable BMCR_ISOLATE in phylink_mii_c22_pcs_config

2020-10-21 Thread Jakub Kicinski
On Wed, 21 Oct 2020 10:27:36 +0100 Russell King - ARM Linux admin wrote: > On Tue, Oct 20, 2020 at 01:12:49PM -0600, Robert Hancock wrote: > > The Xilinx PCS/PMA PHY requires that BMCR_ISOLATE be disabled for proper > > operation in 1000BaseX mode. It should be safe to ensure this bit is > > disabl

pressure for better clocks

2020-10-21 Thread rjmcmahon
Hi All, Iperf 2.0.14 provides end/end latency measurements but requires sync'ed clocks. The lack of attention to network latency is a major deficit to the networking industry and impairs user experience. I find one of the many problems with the tech industry is that cheap mass market stuff p

Re: [PATCH ghak90 V9 05/13] audit: log container info of syscalls

2020-10-21 Thread Richard Guy Briggs
On 2020-10-21 12:49, Steve Grubb wrote: > On Wednesday, October 21, 2020 12:39:26 PM EDT Richard Guy Briggs wrote: > > > I think I have a way to generate a signal to multiple targets in one > > > syscall... The added challenge is to also give those targets different > > > audit container identifie

Re: [PATCH net] gianfar: Account for Tx PTP timestamp in the skb headroom

2020-10-21 Thread Jakub Kicinski
On Tue, 20 Oct 2020 20:36:05 +0300 Claudiu Manoil wrote: > When PTP timestamping is enabled on Tx, the controller > inserts the Tx timestamp at the beginning of the frame > buffer, between SFD and the L2 frame header. This means > that the skb provided by the stack is required to have > enough head

[PATCH v3] net: macb: add support for high speed interface

2020-10-21 Thread Parshuram Thombare
This patch adds support for 10GBASE-R interface to the linux driver for Cadence's ethernet controller. This controller has separate MAC's and PCS'es for low and high speed paths. High speed PCS supports 100M, 1G, 2.5G, 5G and 10G through rate adaptation implementation. However, since it doesn't sup

[PATCH bpf-next 3/3] selftests/bpf: Add asm tests for pkt vs pkt_end comparison.

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov Add few assembly tests for packet comparison. Signed-off-by: Alexei Starovoitov --- .../testing/selftests/bpf/verifier/ctx_skb.c | 42 +++ 1 file changed, 42 insertions(+) diff --git a/tools/testing/selftests/bpf/verifier/ctx_skb.c b/tools/testing/se

[PATCH bpf-next 2/3] selftests/bpf: Add skb_pkt_end test

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov Add a test that currently makes LLVM generate assembly code: $ llvm-objdump -S skb_pkt_end.o : ; if (skb_shorter(skb, ETH_IPV4_TCP_SIZE)) 0: 61 12 50 00 00 00 00 00 r2 = *(u32 *)(r1 + 80) 1: 61 14 4c 00 00 00 00 00 r4 = *(

[PATCH bpf-next 0/3] bpf: Pointers beyond packet end.

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov In some cases LLVM uses the knowledge that branch is taken to optimze the code which causes the verifier to reject valid programs. Teach the verifier to recognize that r1 = skb->data; r1 += 10; r2 = skb->data_end; if (r1 > r2) { here r1 points beyond packet_end and subs

[PATCH bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-10-21 Thread Alexei Starovoitov
From: Alexei Starovoitov This patch adds the verifier support to recognize inlined branch conditions. The LLVM knows that the branch evaluates to the same value, but the verifier couldn't track it. Hence causing valid programs to be rejected. The potential LLVM workaround: https://reviews.llvm.or

Re: [PATCH iproute2-next 15/15] dcb: Add a subtool for the DCB ETS object

2020-10-21 Thread Stephen Hemminger
On Tue, 20 Oct 2020 22:43:37 +0200 Petr Machata wrote: > Jakub Kicinski writes: > > > On Tue, 20 Oct 2020 02:58:23 +0200 Petr Machata wrote: > >> +static void dcb_ets_print_cbs(FILE *fp, const struct ieee_ets *ets) > >> +{ > >> + print_string(PRINT_ANY, "cbs", "cbs %s ", ets->cbs ? "on" : "o

Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions

2020-10-21 Thread Stephen Hemminger
On Mon, 19 Oct 2020 17:23:01 +0200 Guillaume Nault wrote: > + } else if (matches(*argv, "pop_eth") == 0) { Using matches allows for shorter command lines but can be make for bad user experience if strings overlap. For example 'p' here will match the pop_eth and not the push_eth. Is

Re: [Bug 209767] New: Bonding 802.3ad layer2+3 transmits on both slaves within single connection

2020-10-21 Thread Jakub Kicinski
CC some bonding folks On Tue, 20 Oct 2020 07:54:29 -0700 Stephen Hemminger wrote: > Begin forwarded message: > > Date: Tue, 20 Oct 2020 10:42:34 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 209767] New: Bonding 802.3ad layer2+3 transmits on bo

Re: [PATCH v2 iproute2-next 1/2] m_vlan: add pop_eth and push_eth actions

2020-10-21 Thread David Ahern
On 10/21/20 12:32 PM, Stephen Hemminger wrote: > On Mon, 19 Oct 2020 17:23:01 +0200 > Guillaume Nault wrote: > >> +} else if (matches(*argv, "pop_eth") == 0) { > > Using matches allows for shorter command lines but can be make > for bad user experience if strings overlap. > > For ex

[RFC,net-next, 0/4] seg6: add support for SRv6 End.DT4 behavior

2020-10-21 Thread Andrea Mayer
This patchset adds support for the SRv6 End.DT4 behavior. The SRv6 End.DT4 is used to implement multi-tenant IPv4 L3VPN. It decapsulates the received packets and performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation leverages a VRF device. SRv6 End.

[RFC,net-next, 2/4] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-10-21 Thread Andrea Mayer
We introduce two callbacks used for customizing the creation/destruction of a SRv6 behavior. Such callbacks are defined in the new struct seg6_local_lwtunnel_ops and hereafter we provide a brief description of them: - build_state(...): used for calling the custom constructor of the behavior du

Re: [PATCH v3] net: macb: add support for high speed interface

2020-10-21 Thread Russell King - ARM Linux admin
On Wed, Oct 21, 2020 at 07:44:05PM +0200, Parshuram Thombare wrote: > This patch adds support for 10GBASE-R interface to the linux driver for > Cadence's ethernet controller. > This controller has separate MAC's and PCS'es for low and high speed paths. > High speed PCS supports 100M, 1G, 2.5G, 5G a

[RFC,net-next, 1/4] vrf: push mac header for tunneled packets when sniffer is attached

2020-10-21 Thread Andrea Mayer
Before this patch, a sniffer attached to a VRF used as the receiving interface of L3 tunneled packets detects them as malformed packets and it complains about that (i.e.: tcpdump shows bogus packets). The reason is that a tunneled L3 packet does not carry any L2 information and when the VRF is set

[RFC,net-next, 3/4] seg6: add support for the SRv6 End.DT4 behavior

2020-10-21 Thread Andrea Mayer
SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. The SRv6 End.DT4 is used to implement IPv4 L3VPN use-cases in multi-tenants environments. It decapsulates the received packets and it performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation

[RFC,net-next, 4/4] selftests: add selftest for the SRv6 End.DT4 behavior

2020-10-21 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT4 behavior used, in this example, for implementing IPv4 L3 VPN use cases. Signed-off-by: Andrea Mayer --- .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 490 ++ 1 file changed, 490 insertions(+) create mode 100755 tool

Re: lan78xx: /sys/class/net/eth0/carrier stuck at 1

2020-10-21 Thread Andrew Lunn
On Wed, Oct 21, 2020 at 05:00:53PM +0200, Juerg Haefliger wrote: > Hi, > > If the lan78xx driver is compiled into the kernel and the network cable is > plugged in at boot, /sys/class/net/eth0/carrier is stuck at 1 and doesn't > toggle if the cable is unplugged and replugged. > > If the network ca

[RFC PATCH net-next 3/3] sock: Use dev_and_queue structure for TX queue mapping in sock

2020-10-21 Thread Harshitha Ramamurthy
From: Tom Herbert Replace sk_tx_queue_mapping with sk_tx_dev_and_queue_mapping and change associated functions to set, get, and clear mapping. This patch ensures that the queue picked for transmit is correct by setting the queue and ifindex and then retriveing the queue number only if the ifindex

[RFC PATCH net-next 1/3] sock: Definition and general functions for dev_and_queue structure

2020-10-21 Thread Harshitha Ramamurthy
From: Tom Herbert Add struct dev_and_queue which holds and ifindex and queue pair. Add generic functions to get the queue for the ifindex held as well as functions to set, clear the pair in a structure. Signed-off-by: Tom Herbert Signed-off-by: Harshitha Ramamurthy --- include/net/sock.h | 52

[RFC PATCH net-next 0/3] sock: Fix sock queue mapping to include device

2020-10-21 Thread Harshitha Ramamurthy
In XPS, the transmit queue selected for a packet is saved in the associated sock for the packet and is then used to avoid recalculating the queue on subsequent sends. The problem is that the corresponding device is not also recorded so that when the queue mapping is referenced it may correspond to

[RFC PATCH net-next 2/3] sock: Use dev_and_queue structure for RX queue mapping in sock

2020-10-21 Thread Harshitha Ramamurthy
From: Tom Herbert Replace sk_rx_queue_mapping with sk_rx_dev_and_queue_mapping and change associated function to set, get, and clear mapping. This patch ensures that the queue picked for transmit is correct by setting the queue and ifindex and then retrieving the queue number only if the ifindex

Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create

2020-10-21 Thread Saeed Mirzamohammadi
Attached the syzkaller C repro. Tested-by: Saeed Mirzamohammadi repro.c Description: Binary data > On Oct 20, 2020, at 9:45 AM, Saeed Mirzamohammadi > wrote: > > Thanks! Yes, that looks good to me. > > Saeed > >> On Oct 20, 2020, at 4:50 AM, Pablo Neira Ayuso wrote: >> >> On Mon, Oct 19

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-21 Thread Thomas Gleixner
On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote: > On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote: >> However, IMHO we would still need a logic to prevent the devices from >> creating excess vectors. > > Managed interrupts are preventing exactly that by pinning the interrupts > and queu

[PATCH bpf] bpf, libbpf: guard bpf inline asm from bpf_tail_call_static

2020-10-21 Thread Daniel Borkmann
Yaniv reported a compilation error after pulling latest libbpf: [...] ../libbpf/src/root/usr/include/bpf/bpf_helpers.h:99:10: error: unknown register name 'r0' in asm : "r0", "r1", "r2", "r3", "r4", "r5"); [...] The issue got triggered given Yaniv was compiling tracin

Re: [PATCH bpf] bpf, libbpf: guard bpf inline asm from bpf_tail_call_static

2020-10-21 Thread Yonghong Song
On 10/21/20 1:32 PM, Daniel Borkmann wrote: Yaniv reported a compilation error after pulling latest libbpf: [...] ../libbpf/src/root/usr/include/bpf/bpf_helpers.h:99:10: error: unknown register name 'r0' in asm : "r0", "r1", "r2", "r3", "r4", "r5"); [...] Th

Re: [PATCH v1 net-next 2/5] net: mscc: ocelot: set vcap IS2 chain to goto PSFP chain

2020-10-21 Thread joergen.andrea...@microchip.com
The 10/20/2020 23:27, Vladimir Oltean wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Oct 20, 2020 at 03:23:18PM +0800, Xiaoliang Yang wrote: > > VSC9959 supports Per-Stream Filtering and Policing(PSFP), which is > > processing aft

RE: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c"

2020-10-21 Thread David Laight
From: Greg KH > Sent: 21 October 2020 17:13 > > On Fri, Sep 25, 2020 at 06:51:39AM +0200, Christoph Hellwig wrote: > > From: David Laight > > > > This lets the compiler inline it into import_iovec() generating > > much better code. > > > > Signed-off-by: David Laight > > Signed-off-by: Christoph

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-21 Thread Nitesh Narayan Lal
On 10/21/20 4:25 PM, Thomas Gleixner wrote: > On Tue, Oct 20 2020 at 20:07, Thomas Gleixner wrote: >> On Tue, Oct 20 2020 at 12:18, Nitesh Narayan Lal wrote: >>> However, IMHO we would still need a logic to prevent the devices from >>> creating excess vectors. >> Managed interrupts are preventing

[PATCH v3 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board

2020-10-21 Thread Łukasz Stelmach
Add node for ax88796c ethernet chip. Signed-off-by: Łukasz Stelmach --- arch/arm/boot/dts/exynos3250-artik5-eval.dts | 29 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts index 20446a

[PATCH v3 5/5] ARM: defconfig: Enable ax88796c driver

2020-10-21 Thread Łukasz Stelmach
Enable ax88796c driver for the ethernet chip on Exynos3250-based ARTIK5 boards. Signed-off-by: Łukasz Stelmach --- arch/arm/configs/exynos_defconfig | 2 ++ arch/arm/configs/multi_v7_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/

[PATCH v3 1/5] dt-bindings: vendor-prefixes: Add asix prefix

2020-10-21 Thread Łukasz Stelmach
Add the prefix for ASIX Electronics Corporation Signed-off-by: Łukasz Stelmach --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefi

[PATCH v3 0/5] AX88796C SPI Ethernet Adapter

2020-10-21 Thread Łukasz Stelmach
This is a driver for AX88796C Ethernet Adapter connected in SPI mode as found on ARTIK5 evaluation board. The driver has been ported from a v3.10.9 vendor kernel for ARTIK5 board. Changes in v3: - modify vendor-prefixes.yaml in a separate patch - fix several problems in the dt binding - re

[PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-21 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in

[PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-21 Thread Łukasz Stelmach
Add bindings for AX88796C SPI Ethernet Adapter. Signed-off-by: Łukasz Stelmach --- .../bindings/net/asix,ax88796c.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml diff --git a/Documentation/dev

Re: [PATCH bpf v3 1/2] bpf_redirect_neigh: Support supplying the nexthop as a helper parameter

2020-10-21 Thread David Ahern
On 10/20/20 3:25 PM, Toke Høiland-Jørgensen wrote: > From: Toke Høiland-Jørgensen > > Based on the discussion in [0], update the bpf_redirect_neigh() helper to > accept an optional parameter specifying the nexthop information. This makes > it possible to combine bpf_fib_lookup() and bpf_redirect_

Re: [PATCH bpf-next 1/3] bpf: Support for pointers beyond pkt_end.

2020-10-21 Thread kernel test robot
master config: i386-randconfig-r026-20201021 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/1aa4c81ae1dbbc3b6de7416f0384cde6cc8739b1 git remote add linux-review https://github.com/0day-ci/linux

Re: [PATCH bpf] bpf, libbpf: guard bpf inline asm from bpf_tail_call_static

2020-10-21 Thread Yaniv Agman
‫בתאריך יום ד׳, 21 באוק׳ 2020 ב-23:33 מאת ‪Daniel Borkmann‬‏ <‪dan...@iogearbox.net‬‏>:‬ > > Yaniv reported a compilation error after pulling latest libbpf: > > [...] > ../libbpf/src/root/usr/include/bpf/bpf_helpers.h:99:10: error: > unknown register name 'r0' in asm > :

  1   2   >