Re: [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group

2020-10-12 Thread Eli Cohen
On Fri, Oct 09, 2020 at 11:56:45AM +0800, Jason Wang wrote: > > On 2020/10/1 下午9:29, Eli Cohen wrote: > > On Thu, Sep 24, 2020 at 11:21:11AM +0800, Jason Wang wrote: > > > This patch introduces a new bus operation to allow the vDPA bus driver > > > to associate an ASID to a virtqueue group. > > >

Re: [PATCH 1/5] rxrpc: use semicolons rather than commas to separate statements

2020-10-12 Thread David Howells
Julia Lawall wrote: > - call->completion = compl, > + call->completion = compl; Looks good. Do you want me to pick up the patch or send it yourself? If the latter: Acked-by: David Howells

Re: possible deadlock in dev_uc_sync

2020-10-12 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:3dd0130f Merge branch 'akpm' (patches from Andrew) git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16b3612050 kernel config: https://syzkaller.appspot.com/x/.config?x=c06bcf3cc963d91c

Re: [PATCH 1/5] rxrpc: use semicolons rather than commas to separate statements

2020-10-12 Thread Julia Lawall
On Mon, 12 Oct 2020, David Howells wrote: > Julia Lawall wrote: > > > - call->completion = compl, > > + call->completion = compl; > > Looks good. Do you want me to pick up the patch or send it yourself? Please pick it up. Thanks. julia > > If the latter: > > Acked-by:

Re: [PATCH net-next 06/12] qtnfmac: use new function dev_fetch_sw_netstats

2020-10-12 Thread Kalle Valo
Heiner Kallweit writes: > Simplify the code by using new function dev_fetch_sw_netstats(). > > Signed-off-by: Heiner Kallweit I assume this goes via net-next so: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-12 Thread Johannes Berg
On Wed, 2020-10-07 at 10:17 +, Aleksandr Nogikh wrote: > > @@ -904,6 +905,10 @@ struct sk_buff { > __u16 network_header; > __u16 mac_header; > > +#ifdef CONFIG_KCOV > + u64 kcov_handle; > +#endif [...] > @@ -233,6 +233

[PATCH v5,net-next,01/13] octeontx2-pf: move lmt flush to include/linux/soc

2020-10-12 Thread Srujana Challa
On OcteonTX2 platform CPT instruction enqueue and NIX packet send are only possible via LMTST operations which uses LDEOR instruction. This patch moves lmt flush function from OcteonTX2 nic driver to include/linux/soc since it will be used by OcteonTX2 CPT and NIC driver for LMTST. Change-Id: I148

[PATCH v5,net-next,02/13] octeontx2-af: add mailbox interface for CPT

2020-10-12 Thread Srujana Challa
On OcteonTX2 SoC, the admin function (AF) is the only one with all priviliges to configure HW and alloc resources, PFs and it's VFs have to request AF via mailbox for all their needs. This patch adds a mailbox interface for CPT PFs and VFs to allocate resources for cryptography and inline-IPsec. In

[PATCH v5,net-next,04/13] drivers: crypto: add Marvell OcteonTX2 CPT PF driver

2020-10-12 Thread Srujana Challa
Adds skeleton for the Marvell OcteonTX2 CPT physical function driver which includes probe, PCI specific initialization and hardware register defines. RVU defines are present in AF driver (drivers/net/ethernet/marvell/octeontx2/af), header files from AF driver are included here to avoid duplication.

[PATCH v5,net-next,00/13] Add Support for Marvell OcteonTX2 Cryptographic

2020-10-12 Thread Srujana Challa
This series introduces crypto(CPT) drivers(PF & VF) for Marvell OcteonTX2 CN96XX Soc. OcteonTX2 SOC's resource virtualization unit (RVU) supports multiple physical and virtual functions. Each of the PF/VF's functionality is determined by what kind of resources are attached to it. When the CPT bloc

[PATCH v5,net-next,06/13] crypto: octeontx2: enable SR-IOV and mailbox communication with VF

2020-10-12 Thread Srujana Challa
Adds 'sriov_configure' to enable/disable virtual functions (VFs). Also Initializes VF<=>PF mailbox IRQs, register handlers for processing these mailbox messages. Admin function (AF) handles resource allocation and configuration for PFs and their VFs. PFs request the AF directly, via mailboxes. Unl

[PATCH v5,net-next,03/13] octeontx2-af: add debugfs entries for CPT block

2020-10-12 Thread Srujana Challa
Add entries to debugfs at /sys/kernel/debug/octeontx2/cpt. cpt_pc: dump cpt performance HW registers. Usage: cat /sys/kernel/debug/octeontx2/cpt/cpt_pc cpt_engines_sts: show cpt engines current state (busy/free status) Usage: echo "AE/SE/IE/all" > /sys/kernel/debug/octeontx2/cpt/cpt_engines_sts

[PATCH v5,net-next,05/13] crypto: octeontx2: add mailbox communication with AF

2020-10-12 Thread Srujana Challa
In the resource virtualization unit (RVU) each of the PF and AF (admin function) share a 64KB of reserved memory region for communication. This patch initializes PF <=> AF mailbox IRQs, registers handlers for processing these communication messages. Change-Id: I9826d1703a1a19c347c9e3f3cd6a395c5a64

[PATCH v5,net-next,11/13] crypto: octeontx2: add virtual function driver support

2020-10-12 Thread Srujana Challa
Add support for the Marvell OcteonTX2 CPT virtual function driver. This patch includes probe, PCI specific initialization and interrupt handling. Change-Id: Ib0c81fcc7c0d43144463c37e7ea0e954bafe4b62 Signed-off-by: Srujana Challa --- drivers/crypto/marvell/octeontx2/Makefile | 4 +- .../mar

[PATCH v5,net-next,07/13] crypto: octeontx2: load microcode and create engine groups

2020-10-12 Thread Srujana Challa
CPT includes microcoded GigaCypher symmetric engines(SEs), IPsec symmetric engines(IEs), and asymmetric engines (AEs). Each engine receives CPT instructions from the engine groups it has subscribed to. This patch loads microcode, configures three engine groups(one for SEs, one for IEs and one for A

[PATCH v5,net-next,12/13] crypto: octeontx2: add support to process the crypto request

2020-10-12 Thread Srujana Challa
Attach LFs to CPT VF to process the crypto requests and register LF interrupts. Change-Id: Idd9b8ff9a435d9dfc2591f17a84d2f96206dd994 Signed-off-by: Srujana Challa --- drivers/crypto/marvell/octeontx2/Makefile | 2 +- .../marvell/octeontx2/otx2_cpt_reqmgr.h | 145 + drivers/crypto

[PATCH v5,net-next,09/13] crypto: octeontx2: add support to get engine capabilities

2020-10-12 Thread Srujana Challa
Adds support to get engine capabilities and adds a new mailbox to share the engine capabilities to CPT VFIO drivers. Change-Id: Ic43320c02ca4595b5b82f1da9c7d3a070f046f55 Signed-off-by: Srujana Challa --- .../marvell/octeontx2/otx2_cpt_common.h | 36 .../marvell/octeontx2/otx2_cpt_req

[PATCH v5,net-next,10/13] crypto: octeontx2: add mailbox for inline-IPsec RX LF cfg

2020-10-12 Thread Srujana Challa
Add new mailbox message to configure a LF for RX inline-IPsec. This message is added to serve Marvell CPT VFIO driver, since a VF can not send mailbox messages to admin function(AF) directly. Change-Id: I66c984eb3a865a28d59952e7210319c669ef9e6c Signed-off-by: Srujana Challa --- .../marvell/octeo

[PATCH v5,net-next,08/13] crypto: octeontx2: add LF framework

2020-10-12 Thread Srujana Challa
CPT RVU Local Functions(LFs) needs to be attached to the PF/VF to submit the instructions to CPT. This patch adds the interface to initialize and attach the LFs. It also adds interface to register the LF's interrupts. Change-Id: I6a674bab7f905de63fed0a9b611ac4d69baa164f Signed-off-by: Srujana Chal

Re: [PATCH RFC PKS/PMEM 48/58] drivers/md: Utilize new kmap_thread()

2020-10-12 Thread Coly Li
On 2020/10/12 13:28, Ira Weiny wrote: > On Sat, Oct 10, 2020 at 10:20:34AM +0800, Coly Li wrote: >> On 2020/10/10 03:50, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> These kmap() calls are localized to a single thread. To avoid the over >>> head of global PKRS updates use the new kmap_t

[PATCH v5,net-next,13/13] crypto: octeontx2: register with linux crypto framework

2020-10-12 Thread Srujana Challa
CPT offload module utilises the linux crypto framework to offload crypto processing. This patch registers supported algorithms by calling registration functions provided by the kernel crypto API. The module currently supports: - AES block cipher in CBC,ECB,XTS and CFB mode. - 3DES block cipher in

Re: [PATCH net-next v2 1/2] can-isotp: implement cleanups / improvements from review

2020-10-12 Thread Oliver Hartkopp
On 11.10.20 17:44, Jakub Kicinski wrote: On Sun, 11 Oct 2020 11:24:07 +0200 Oliver Hartkopp wrote: diff --git a/net/can/isotp.c b/net/can/isotp.c index e6ff032b5426..22187669c5c9 100644 --- a/net/can/isotp.c +++ b/net/can/isotp.c @@ -79,6 +79,8 @@ MODULE_LICENSE("Dual BSD/GPL"); MODULE_AUTH

[PATCH net-next v3 2/2] can: remove obsolete version strings

2020-10-12 Thread Oliver Hartkopp
As pointed out by Jakub Kicinski here: http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com this patch removes the obsolete version information of the different CAN protocols and the AF_CAN core module. Signed-off-by: Oliver Hartkopp --- include/linux/ca

[PATCH net-next v3 1/2] can-isotp: implement cleanups / improvements from review

2020-10-12 Thread Oliver Hartkopp
As pointed out by Jakub Kicinski here: http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com this patch addresses the remarked issues: - remove empty line in comment - remove default=y for CAN_ISOTP in Kconfig - make use of pr_notice_once() - use GFP_ATOMIC

Re: [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group

2020-10-12 Thread Jason Wang
On 2020/10/12 下午2:59, Eli Cohen wrote: On Fri, Oct 09, 2020 at 11:56:45AM +0800, Jason Wang wrote: On 2020/10/1 下午9:29, Eli Cohen wrote: On Thu, Sep 24, 2020 at 11:21:11AM +0800, Jason Wang wrote: This patch introduces a new bus operation to allow the vDPA bus driver to associate an ASID to

Re: [PATCH net] net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid

2020-10-12 Thread Dominique Martinet
Anant Thazhemadam wrote on Mon, Oct 12, 2020: > In p9_fd_create_unix, checking is performed to see if the addr (passed > as an argument) is NULL or not. > However, no check is performed to see if addr is a valid address, i.e., > it doesn't entirely consist of only 0's. > The initialization of sun_s

[PATCH net-next v2 00/12] net: add and use function dev_fetch_sw_netstats for fetching pcpu_sw_netstats

2020-10-12 Thread Heiner Kallweit
In several places the same code is used to populate rtnl_link_stats64 fields with data from pcpu_sw_netstats. Therefore factor out this code to a new function dev_fetch_sw_netstats(). v2: - constify argument netstats - don't ignore netstats being NULL or an ERRPTR - switch to EXPORT_SYMBOL_GPL He

RE: [PATCH v5,net-next,00/13] Add Support for Marvell OcteonTX2 Cryptographic

2020-10-12 Thread Srujana Challa
I am sorry, please ignore this version of series, it was sent by mistake without removing Gerrit Change IDs. Thanks, Srujana > This series introduces crypto(CPT) drivers(PF & VF) for Marvell OcteonTX2 > CN96XX Soc. > > OcteonTX2 SOC's resource virtualization unit (RVU) supports multiple > physi

Re: [PATCH net 0/2] mptcp: some fallback fixes

2020-10-12 Thread Paolo Abeni
On Sat, 2020-10-10 at 11:13 -0700, Jakub Kicinski wrote: > On Fri, 9 Oct 2020 18:59:59 +0200 Paolo Abeni wrote: > > pktdrill pointed-out we currently don't handle properly some > > fallback scenario for MP_JOIN subflows > > > > The first patch addresses such issue. > > > > Patch 2/2 fixes a rela

Re: [PATCH net-next v2 1/2] Makefile.extrawarn: Add symbol for W=1 warnings for today

2020-10-12 Thread Arnd Bergmann
On Mon, Oct 12, 2020 at 3:00 AM Masahiro Yamada wrote: > > BTW, if possible, please educate me about the difference > between -Wmissing-declarations and -Wmissing-prototypes. > ... > Do we need to specify both in W=1 ? > If yes, what is the difference between them? I think they do the same thing

Re: [PATCH net-next v3 1/2] can-isotp: implement cleanups / improvements from review

2020-10-12 Thread Marc Kleine-Budde
On 10/12/20 9:43 AM, Oliver Hartkopp wrote: > As pointed out by Jakub Kicinski here: > http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com > this patch addresses the remarked issues: > > - remove empty line in comment > - remove default=y for CAN_ISOTP in

Re: [PATCH net-next v3 1/2] can-isotp: implement cleanups / improvements from review

2020-10-12 Thread Oliver Hartkopp
On 12.10.20 10:05, Marc Kleine-Budde wrote: On 10/12/20 9:43 AM, Oliver Hartkopp wrote: As pointed out by Jakub Kicinski here: http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com this patch addresses the remarked issues: - remove empty line in comme

[PATCH v6,net-next,01/13] octeontx2-pf: move lmt flush to include/linux/soc

2020-10-12 Thread Srujana Challa
On OcteonTX2 platform CPT instruction enqueue and NIX packet send are only possible via LMTST operations which uses LDEOR instruction. This patch moves lmt flush function from OcteonTX2 nic driver to include/linux/soc since it will be used by OcteonTX2 CPT and NIC driver for LMTST. Signed-off-by:

[PATCH v6,net-next,00/13] Add Support for Marvell OcteonTX2 Cryptographic

2020-10-12 Thread Srujana Challa
This series introduces crypto(CPT) drivers(PF & VF) for Marvell OcteonTX2 CN96XX Soc. OcteonTX2 SOC's resource virtualization unit (RVU) supports multiple physical and virtual functions. Each of the PF/VF's functionality is determined by what kind of resources are attached to it. When the CPT bloc

Re: [PATCH net-next v2 1/2] Makefile.extrawarn: Add symbol for W=1 warnings for today

2020-10-12 Thread Arnd Bergmann
On Sun, Oct 11, 2020 at 3:04 PM Masahiro Yamada wrote: > On Tue, Oct 6, 2020 at 6:08 AM Andrew Lunn wrote: > > > I am not a big fan of KBUILD_CFLAGS_W1_ > since it is ugly. > > I'd like to start with adding individual flags > like drivers/gpu/drm/i915/Makefile, and see > how difficult it would be

[PATCH v6,net-next,05/13] crypto: octeontx2: add mailbox communication with AF

2020-10-12 Thread Srujana Challa
In the resource virtualization unit (RVU) each of the PF and AF (admin function) share a 64KB of reserved memory region for communication. This patch initializes PF <=> AF mailbox IRQs, registers handlers for processing these communication messages. Signed-off-by: Srujana Challa --- drivers/cryp

[PATCH v6,net-next,03/13] octeontx2-af: add debugfs entries for CPT block

2020-10-12 Thread Srujana Challa
Add entries to debugfs at /sys/kernel/debug/octeontx2/cpt. cpt_pc: dump cpt performance HW registers. Usage: cat /sys/kernel/debug/octeontx2/cpt/cpt_pc cpt_engines_sts: show cpt engines current state (busy/free status) Usage: echo "AE/SE/IE/all" > /sys/kernel/debug/octeontx2/cpt/cpt_engines_sts

[PATCH v6,net-next,02/13] octeontx2-af: add mailbox interface for CPT

2020-10-12 Thread Srujana Challa
On OcteonTX2 SoC, the admin function (AF) is the only one with all priviliges to configure HW and alloc resources, PFs and it's VFs have to request AF via mailbox for all their needs. This patch adds a mailbox interface for CPT PFs and VFs to allocate resources for cryptography and inline-IPsec. In

[PATCH v6,net-next,06/13] crypto: octeontx2: enable SR-IOV and mailbox communication with VF

2020-10-12 Thread Srujana Challa
Adds 'sriov_configure' to enable/disable virtual functions (VFs). Also Initializes VF<=>PF mailbox IRQs, register handlers for processing these mailbox messages. Admin function (AF) handles resource allocation and configuration for PFs and their VFs. PFs request the AF directly, via mailboxes. Unl

[PATCH v6,net-next,04/13] drivers: crypto: add Marvell OcteonTX2 CPT PF driver

2020-10-12 Thread Srujana Challa
Adds skeleton for the Marvell OcteonTX2 CPT physical function driver which includes probe, PCI specific initialization and hardware register defines. RVU defines are present in AF driver (drivers/net/ethernet/marvell/octeontx2/af), header files from AF driver are included here to avoid duplication.

[PATCH v6,net-next,11/13] crypto: octeontx2: add virtual function driver support

2020-10-12 Thread Srujana Challa
Add support for the Marvell OcteonTX2 CPT virtual function driver. This patch includes probe, PCI specific initialization and interrupt handling. Signed-off-by: Srujana Challa --- drivers/crypto/marvell/octeontx2/Makefile | 4 +- .../marvell/octeontx2/otx2_cpt_common.h | 1 + .../m

[PATCH v6,net-next,08/13] crypto: octeontx2: add LF framework

2020-10-12 Thread Srujana Challa
CPT RVU Local Functions(LFs) needs to be attached to the PF/VF to submit the instructions to CPT. This patch adds the interface to initialize and attach the LFs. It also adds interface to register the LF's interrupts. Signed-off-by: Srujana Challa --- drivers/crypto/marvell/octeontx2/Makefile

[PATCH v6,net-next,07/13] crypto: octeontx2: load microcode and create engine groups

2020-10-12 Thread Srujana Challa
CPT includes microcoded GigaCypher symmetric engines(SEs), IPsec symmetric engines(IEs), and asymmetric engines (AEs). Each engine receives CPT instructions from the engine groups it has subscribed to. This patch loads microcode, configures three engine groups(one for SEs, one for IEs and one for A

[PATCH v6,net-next,10/13] crypto: octeontx2: add mailbox for inline-IPsec RX LF cfg

2020-10-12 Thread Srujana Challa
Add new mailbox message to configure a LF for RX inline-IPsec. This message is added to serve Marvell CPT VFIO driver, since a VF can not send mailbox messages to admin function(AF) directly. Signed-off-by: Srujana Challa --- .../marvell/octeontx2/otx2_cpt_common.h | 12 +++ drivers/crypto

[PATCH v6,net-next,09/13] crypto: octeontx2: add support to get engine capabilities

2020-10-12 Thread Srujana Challa
Adds support to get engine capabilities and adds a new mailbox to share the engine capabilities to CPT VFIO drivers. Signed-off-by: Srujana Challa --- .../marvell/octeontx2/otx2_cpt_common.h | 36 .../marvell/octeontx2/otx2_cpt_reqmgr.h | 51 ++ drivers/crypto/marvell/octe

[PATCH v6,net-next,13/13] crypto: octeontx2: register with linux crypto framework

2020-10-12 Thread Srujana Challa
CPT offload module utilises the linux crypto framework to offload crypto processing. This patch registers supported algorithms by calling registration functions provided by the kernel crypto API. The module currently supports: - AES block cipher in CBC,ECB,XTS and CFB mode. - 3DES block cipher in

[PATCH v6,net-next,12/13] crypto: octeontx2: add support to process the crypto request

2020-10-12 Thread Srujana Challa
Attach LFs to CPT VF to process the crypto requests and register LF interrupts. Signed-off-by: Srujana Challa --- drivers/crypto/marvell/octeontx2/Makefile | 2 +- .../marvell/octeontx2/otx2_cpt_reqmgr.h | 145 + drivers/crypto/marvell/octeontx2/otx2_cptlf.h | 7 + .../marvell/

Re: [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group

2020-10-12 Thread Eli Cohen
On Mon, Oct 12, 2020 at 03:45:10PM +0800, Jason Wang wrote: > > > > > So in theory we can have several asid's (for different virtqueues), each > > one should be followed by a specific set_map call. If this is so, how do > > I know if I met all the conditions run my driver? Maybe we need another >

[PATCH net-next v2 01/12] net: add function dev_fetch_sw_netstats for fetching pcpu_sw_netstats

2020-10-12 Thread Heiner Kallweit
In several places the same code is used to populate rtnl_link_stats64 fields with data from pcpu_sw_netstats. Therefore factor out this code to a new function dev_fetch_sw_netstats(). v2: - constify argument netstats - don't ignore netstats being NULL or an ERRPTR - switch to EXPORT_SYMBOL_GPL Si

[PATCH net-next v2 06/12] qtnfmac: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit Acked-by: Kalle Valo --- drivers/net/wireless/quantenna/qtnfmac/core.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/c

[PATCH net-next v2 07/12] net: bridge: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- net/bridge/br_device.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 9a2fb4aa1..6f742fee8 100644 -

[PATCH net-next v2 12/12] xfrm: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- net/xfrm/xfrm_interface.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c index 5b120936d..aa4cdcf6

[PATCH net-next v2 05/12] net: usbnet: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- drivers/net/usb/usbnet.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 963d260d1..6062dc278

[PATCH net-next v2 02/12] IB/hfi1: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- drivers/infiniband/hw/hfi1/ipoib_main.c | 34 + 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/ipoib_main.c b/drivers/infiniband/

[PATCH net-next v2 03/12] net: macsec: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- drivers/net/macsec.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index 2b0c8f01d..11ca5fa90 100644 --- a/

[PATCH net-next v2 04/12] net: usb: qmi_wwan: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit Acked-by: Bjørn Mork --- drivers/net/usb/qmi_wwan.c | 24 +--- 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.

[PATCH net-next v2 10/12] mac80211: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- net/mac80211/iface.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 240862a74..1be775979 100644 --- a

[PATCH net-next v2 09/12] iptunnel: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- net/ipv4/ip_tunnel_core.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index b2ea1a8c5..25f1caf

[PATCH net-next v2 08/12] net: dsa: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit Tested-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- net/dsa/slave.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/net/dsa/slave.c b/net/dsa/slave

[PATCH net-next v2 11/12] net: openvswitch: use new function dev_fetch_sw_netstats

2020-10-12 Thread Heiner Kallweit
Simplify the code by using new function dev_fetch_sw_netstats(). Signed-off-by: Heiner Kallweit --- net/openvswitch/vport-internal_dev.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal

Re: PHY reset question

2020-10-12 Thread Marek Vasut
On 10/12/20 7:48 AM, Oleksij Rempel wrote: > Hi all, > > thank you for the feedback! > > On Fri, Oct 09, 2020 at 04:25:49PM +0200, Bruno Thomsen wrote: >> Hi Fabio and Oleksij >> >> Den ons. 7. okt. 2020 kl. 11.50 skrev Fabio Estevam : >>> >>> Hi Oleksij, >>> >>> On Tue, Oct 6, 2020 at 5:05 AM Ol

pull-request: can-next 2020-10-12

2020-10-12 Thread Marc Kleine-Budde
ux-can-next-for-5.10-20201012 for you to fetch changes up to f726f3d37163f714034aa5fd1f92a1a73df4297f: can: remove obsolete version strings (2020-10-12 10:06:39 +0200) linux-can-ne

[net-next 2/2] can: remove obsolete version strings

2020-10-12 Thread Marc Kleine-Budde
From: Oliver Hartkopp As pointed out by Jakub Kicinski here: http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com this patch removes the obsolete version information of the different CAN protocols and the AF_CAN core module. Signed-off-by: Oliver Hartkop

[net-next 1/2] can: isotp: implement cleanups / improvements from review

2020-10-12 Thread Marc Kleine-Budde
From: Oliver Hartkopp As pointed out by Jakub Kicinski here: http://lore.kernel.org/r/20201009175751.5c540...@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com this patch addresses the remarked issues: - remove empty line in comment - remove default=y for CAN_ISOTP in Kconfig - make use of pr_notice

Re: [PATCH net-next v3 1/2] can-isotp: implement cleanups / improvements from review

2020-10-12 Thread Marc Kleine-Budde
merge window will open > *very* soon. > > I'm not sure if there would be another pull from linux-can-next until > then, therefore I would suggest that Jakub takes the patches himself. I don't mind. FWIW, here's the pull request: http://lore.kernel.or

Re: [PATCH net-next v3 1/2] can-isotp: implement cleanups / improvements from review

2020-10-12 Thread Oliver Hartkopp
kes the patches himself. I don't mind. FWIW, here's the pull request: http://lore.kernel.org/r/20201012082727.2338859-1-...@pengutronix.de git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-5.10-20201012 Marc :-D Well thanks! I

Re: [PATCH bpf-next] xsk: introduce padding between ring pointers

2020-10-12 Thread Magnus Karlsson
On Fri, Oct 9, 2020 at 5:03 PM Daniel Borkmann wrote: > > On 10/8/20 4:12 PM, Magnus Karlsson wrote: > > From: Magnus Karlsson > > > > Introduce one cache line worth of padding between the producer and > > consumer pointers in all the lockless rings. This so that the HW > > adjacency prefetcher w

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Muchun Song
On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: > > On Mon, Oct 12, 2020 at 6:22 AM Muchun Song wrote: > > > > On Mon, Oct 12, 2020 at 2:39 AM Cong Wang wrote: > > > > > > On Sat, Oct 10, 2020 at 3:39 AM Muchun Song > > > wrote: > > > > > > > > The amount of memory allocated to sockets buf

[net v4] net: dsa: microchip: fix race condition

2020-10-12 Thread Christian Eggers
Between queuing the delayed work and finishing the setup of the dsa ports, the process may sleep in request_module() (via phy_device_create()) and the queued work may be executed prior to the switch net devices being registered. In ksz_mib_read_work(), a NULL dereference will happen within netof_ca

Re: [bpf-next PATCH v3 2/6] bpf, sockmap: On receive programs try to fast track SK_PASS ingress

2020-10-12 Thread Jakub Sitnicki
Hey John, Exiting to see this work :-) On Fri, Oct 09, 2020 at 08:36 PM CEST, John Fastabend wrote: > When we receive an skb and the ingress skb verdict program returns > SK_PASS we currently set the ingress flag and put it on the workqueue > so it can be turned into a sk_msg and put on the sk_ms

[PATCH net-next v2 6/9] bnxt_en: Log unknown link speed appropriately.

2020-10-12 Thread Michael Chan
If the VF virtual link is set to always enabled, the speed may be unknown when the physical link is down. The driver currently logs the link speed as 4294967295 Mbps which is SPEED_UNKNOWN. Modify the link up log message as "speed unknown" which makes more sense. Reviewed-by: Vasundhara Volam R

[PATCH net-next v2 9/9] bnxt_en: Add stored FW version info to devlink info_get cb.

2020-10-12 Thread Michael Chan
From: Vasundhara Volam This patch adds FW versions stored in the flash to devlink info_get callback. Return the correct fw.psid running version using the newly added bp->nvm_cfg_ver. v2: Ensure stored pkg_name string is NULL terminated when copied to devlink. Return directly from the last call

[PATCH net-next v2 2/9] bnxt_en: Enable online self tests for multi-host/NPAR mode.

2020-10-12 Thread Michael Chan
From: Vasundhara Volam Online self tests are not disruptive and can be run in NPAR mode and in multi-host NIC as well. Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 1 file changed, 4 ins

[PATCH net-next v2 1/9] bnxt_en: Return -EROFS to user space, if NVM writes are not permitted.

2020-10-12 Thread Michael Chan
From: Vasundhara Volam If NVRAM resources are locked, NVM writes are not permitted. In such scenarios, firmware returns HWRM_ERR_CODE_RESOURCE_LOCKED error to firmware commands. Reviewed-by: Edwin Peer Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broad

[PATCH net-next v2 8/9] bnxt_en: Refactor bnxt_dl_info_get().

2020-10-12 Thread Michael Chan
From: Vasundhara Volam Add a new function bnxt_dl_info_put() to simplify the code, as there are more stored firmware version fields to be added in the next patch. Also, rename fw_ver variable name to ncsi_ver for better naming while copying to devlink info_get cb. v2: Ensure active_pkg_name str

[PATCH net-next v2 0/9] bnxt_en: Updates for net-next.

2020-10-12 Thread Michael Chan
This series contains these main changes: 1. Change of default message level to enable more logging. 2. Some cleanups related to processing async events from firmware. 3. Allow online ethtool selftest on multi-function PFs. 4. Return stored firmware version information to devlink. v2: Patch 3: Cha

[PATCH net-next v2 5/9] bnxt_en: Log event_data1 and event_data2 when handling RESET_NOTIFY event.

2020-10-12 Thread Michael Chan
Log these values that contain useful firmware state information. Reviewed-by: Edwin Peer Reviewed-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/d

[PATCH net-next v2 7/9] bnxt_en: Add bnxt_hwrm_nvm_get_dev_info() to query NVM info.

2020-10-12 Thread Michael Chan
From: Vasundhara Volam Add a new bnxt_hwrm_nvm_get_dev_info() to query firmware version information via NVM_GET_DEV_INFO firmware command. Use it to get the running version of the NVM configuration information. This new function will also be used in subsequent patches to get the stored firmware

[PATCH net-next v2 4/9] bnxt_en: Simplify bnxt_async_event_process().

2020-10-12 Thread Michael Chan
event_data1 and event_data2 are used when processing most events. Store these in local variables at the beginning of the function to simplify many of the case statements. Reviewed-by: Edwin Peer Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 +++- 1 file

[PATCH net-next v2 3/9] bnxt_en: Set driver default message level.

2020-10-12 Thread Michael Chan
Currently, bp->msg_enable has default value of 0. It is more useful to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by default. v2: Change the fall back bnxt_reset_task() inside bnxt_rx_ring_reset() to silent mode. With older fw, we would take the fall back path and it would be

Re: [PATCH net-next v4 01/10] net: bridge: extend the process of special frames

2020-10-12 Thread Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > This patch extends the processing of frames in the bridge. Currently MRP > frames needs special processing and the current implementation doesn't > allow a nice way to process different frame types. Therefore try to > improve this by add

Re: [PATCH net] net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid

2020-10-12 Thread Anant Thazhemadam
On 12-10-2020 13:29, Dominique Martinet wrote: > Anant Thazhemadam wrote on Mon, Oct 12, 2020: >> In p9_fd_create_unix, checking is performed to see if the addr (passed >> as an argument) is NULL or not. >> However, no check is performed to see if addr is a valid address, i.e., >> it doesn't enti

[PATCH bpf] bpf: sockmap: add locking annotations to iterator

2020-10-12 Thread Lorenz Bauer
The sparse checker currently outputs the following warnings: include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_hash_seq_start' - wrong count at exit include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_map_seq_start' - wrong count at exit A

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Eric Dumazet
On 10/12/20 10:39 AM, Muchun Song wrote: > On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: >> >> On Mon, Oct 12, 2020 at 6:22 AM Muchun Song wrote: >>> >>> On Mon, Oct 12, 2020 at 2:39 AM Cong Wang wrote: On Sat, Oct 10, 2020 at 3:39 AM Muchun Song wrote: > > The

Re: [PATCH] net: Add mhi-net driver

2020-10-12 Thread Loic Poulain
Hi Jakub, and thanks for your review. On Sun, 11 Oct 2020 at 20:59, Jakub Kicinski wrote: > > On Fri, 9 Oct 2020 22:33:31 +0200 Loic Poulain wrote: > > This patch adds a new network driver implementing MHI transport for > > network packets. Packets can be in any format, though QMAP (rmnet) > > i

[PATCH net v2 1/2] socket: fix option SO_TIMESTAMPING_NEW

2020-10-12 Thread Christian Eggers
The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around, so SOCK_TSTAMP_NEW will first be set and than reset again. Additionally move it out of the test for SOF_TIMESTAMPING_RX_SOFTWARE as this seems unrelated. This problem happens on 32 bit platforms were the libc has already switc

Re: [PATCH bpf-next] xsk: introduce padding between ring pointers

2020-10-12 Thread Magnus Karlsson
On Mon, Oct 12, 2020 at 10:37 AM Magnus Karlsson wrote: > > On Fri, Oct 9, 2020 at 5:03 PM Daniel Borkmann wrote: > > > > On 10/8/20 4:12 PM, Magnus Karlsson wrote: > > > From: Magnus Karlsson > > > > > > Introduce one cache line worth of padding between the producer and > > > consumer pointers

[PATCH net v2 2/2] socket: don't clear SOCK_TSTAMP_NEW when SO_TIMESTAMPNS is disabled

2020-10-12 Thread Christian Eggers
SOCK_TSTAMP_NEW (timespec64 instead of timespec) is also used for hardware time stamps (configured via SO_TIMESTAMPING_NEW). User space (ptp4l) first configures hardware time stamping via SO_TIMESTAMPING_NEW which sets SOCK_TSTAMP_NEW. In the next step, ptp4l disables SO_TIMESTAMPNS(_NEW) (softwar

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-10-12 Thread Harald Welte
Hi Paul, On Sun, Oct 11, 2020 at 10:09:11PM -0400, Paul Moore wrote: > Harald, Pablo - I know you both suggested taking a slow iterative > approach to merging functionality, perhaps you could also help those > of us on the SELinux side better understand some of the common GTP use > cases? There r

Re: [PATCH bpf-next v6 2/6] bpf: add redirect_peer helper

2020-10-12 Thread Jesper Dangaard Brouer
On Sun, 11 Oct 2020 20:50:12 -0600 David Ahern wrote: > On 10/11/20 10:16 AM, Daniel Borkmann wrote: > >> > >> This is awesome results and great work Daniel! :-) > > +1 > > >> > >> I wonder if we can also support this from XDP, which can also native > >> redirect into veth.  Originally I thou

[PATCH SRv6 End.X] Signed-off-by: Reji Thomas

2020-10-12 Thread Reji Thomas
seg6: Fix End.X nexthop to use oif. Currently End.X action doesn't consider the outgoing interface while looking up the nexthop.This breaks packet path functionality while using link local address as the End.X nexthop.The patch fixes this for link local addresses. Signed-off-by: Reji Thomas -

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-12 Thread Muchun Song
On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: > > > > On 10/12/20 10:39 AM, Muchun Song wrote: > > On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: > >> > >> On Mon, Oct 12, 2020 at 6:22 AM Muchun Song > >> wrote: > >>> > >>> On Mon, Oct 12, 2020 at 2:39 AM Cong Wang > >>> wrote: > >

Re: [PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-12 Thread Aleksandr Nogikh
On Mon, 12 Oct 2020 at 10:12, Johannes Berg wrote: [...] > > @@ -233,6 +233,7 @@ struct sk_buff *__alloc_skb(unsigned int size, gfp_t > > gfp_mask, > > skb->end = skb->tail + size; > > skb->mac_header = (typeof(skb->mac_header))~0U; > > skb->transport_header = (typeof(skb->trans

Re: [PATCH net] net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid

2020-10-12 Thread Dominique Martinet
Anant Thazhemadam wrote on Mon, Oct 12, 2020: > You mentioned how a fully zeroed address isn't exactly faulty. By extension, > wouldn't that > mean that an address that simply begins with a 0 isn't faulty as well? That is correct. If you have a look at the unix(7) man page that describes AF_UNIX,

Re: [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot

2020-10-12 Thread Ondrej Zary
On Monday 12 October 2020, Jakub Kicinski wrote: > On Sat, 10 Oct 2020 16:00:46 +0200 Ondrej Zary wrote: > > When the router is rebooted without a power cycle, the USB device > > remains connected but its configuration is reset. This results in > > a non-working ethernet connection with messages li

[PATCH 00/23] wfx: get out from the staging area

2020-10-12 Thread Jerome Pouiller
From: Jérôme Pouiller I think the wfx driver is now mature enough to be accepted in the drivers/net/wireless directory. As requested by Kalle[1], I send one file per patch. At the end, all the patches will be squashed (therefore, I didn't bother to write real commit messages). Here is a diagram

[PATCH 02/23] wfx: add Makefile/Kconfig

2020-10-12 Thread Jerome Pouiller
From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/Kconfig | 8 drivers/net/wireless/silabs/wfx/Makefile | 25 2 files changed, 33 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/Kconfig create mode 100

[PATCH 04/23] wfx: add main.c/main.h

2020-10-12 Thread Jerome Pouiller
From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/main.c | 489 + drivers/net/wireless/silabs/wfx/main.h | 44 +++ 2 files changed, 533 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/main.c create mode 100644 dr

[PATCH 01/23] dt-bindings: introduce silabs,wfx.yaml

2020-10-12 Thread Jerome Pouiller
From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- .../bindings/net/wireless/silabs,wfx.yaml | 125 ++ 1 file changed, 125 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml diff --git a/Documentation/devicetree/bindings/

[PATCH 08/23] wfx: add hwio.c/hwio.h

2020-10-12 Thread Jerome Pouiller
From: Jérôme Pouiller Signed-off-by: Jérôme Pouiller --- drivers/net/wireless/silabs/wfx/hwio.c | 352 + drivers/net/wireless/silabs/wfx/hwio.h | 75 ++ 2 files changed, 427 insertions(+) create mode 100644 drivers/net/wireless/silabs/wfx/hwio.c create mode 100644

  1   2   3   4   >