Hi Coiby,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
url:
https://github.com/0day-ci/linux/commits/Coiby-Xu/staging-qlge-Re-writing-the-debugging-features/20201008-22
base: https://git.kernel.org/pub/scm/linux/kernel/git
On Thu, Oct 8, 2020 at 1:45 AM Xin Long wrote:
>
> On Thu, Oct 8, 2020 at 12:12 PM Cong Wang wrote:
> >
> > skb_unshare() drops a reference count on the old skb unconditionally,
> > so in the failure case, we end up freeing the skb twice here.
> > And because the skb is allocated in fclone and cl
On Thu, 2020-10-08 at 10:09 -0700, Jakub Kicinski wrote:
> On Thu, 8 Oct 2020 10:18:09 + Nikolay Aleksandrov wrote:
> > On Wed, 2020-10-07 at 14:49 +, Nikolay Aleksandrov wrote:
> > > On Wed, 2020-10-07 at 12:07 +, Henrik Bjoernlund wrote:
> > > > This commit is correcting NETLINK br_
On Thu, Oct 8, 2020 at 3:34 AM Luka Perkov wrote:
>
> Hello Andrii,
>
> On Wed, Oct 7, 2020 at 8:01 PM Andrii Nakryiko
> wrote:
> >
> > On Wed, Oct 7, 2020 at 10:56 AM Luka Perkov wrote:
> > >
> > > Hello Andrii,
> > >
> > > On Fri, Oct 2, 2020 at 3:09 AM Andrii Nakryiko wrote:
> > > > Patch se
On 10/8/20 1:25 PM, Jakub Kicinski wrote:
On Thu, 8 Oct 2020 14:31:56 +0700 Hoang Huu Le wrote:
diff --git a/net/tipc/name_distr.c b/net/tipc/name_distr.c
index 2f9c148f17e2..fe4edce459ad 100644
--- a/net/tipc/name_distr.c
+++ b/net/tipc/name_distr.c
@@ -327,8 +327,13 @@ static struct sk_buf
In case of bad entries in /proc/mounts just skip cgroup cache initialization.
Cgroups in output will be shown as "unreachable:cgroup_id".
Fixes: d5e6ee0dac64 ("ss: introduce cgroup2 cache and helper functions")
Signed-off-by: Dmitry Yakunin
Reported-by: Donald Sharp
---
lib/cg_map.c | 5 ++---
> -Original Message-
> From: Parav Pandit
> Sent: Thursday, October 8, 2020 10:35 AM
> To: Ertman, David M ; Pierre-Louis Bossart
> ; Leon Romanovsky
>
> Cc: alsa-de...@alsa-project.org; pa...@mellanox.com; ti...@suse.de;
> netdev@vger.kernel.org; ranjani.sridha...@linux.intel.com;
> fred
I've tested this patch and it works for me.
donald
On 10/8/20, 2:00 PM, "Dmitry Yakunin" wrote:
External email: Use caution opening links or attachments
In case of bad entries in /proc/mounts just skip cgroup cache
initialization.
Cgroups in output will be shown as "unreachable:
Florian
Thanks for the review
On 10/8/20 12:11 PM, Florian Fainelli wrote:
On 10/8/2020 9:23 AM, Dan Murphy wrote:
The DP83TD510 is a 10M single twisted pair Ethernet PHY
Signed-off-by: Dan Murphy
---
.../devicetree/bindings/net/ti,dp83td510.yaml | 70 +++
1 file changed
> -Original Message-
> From: Dan Williams
> Sent: Wednesday, October 7, 2020 11:32 PM
> To: Leon Romanovsky
> Cc: Ertman, David M ; Parav Pandit
> ; Pierre-Louis Bossart louis.boss...@linux.intel.com>; alsa-de...@alsa-project.org;
> pa...@mellanox.com; ti...@suse.de; netdev@vger.kernel.o
Hi Xin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
From: Jonathan Lemon
netcons will call napi_poll with a budget of 0, indicating
a non-napi caller (and also called with irqs disabled). Call
free_old_xmit_skbs() with the is_napi parameter set correctly.
Found by this splat:
WARNING: CPU: 2 PID: 1368 at net/core/skbuff.c:650
skb_release_head_
On 08.10.2020 19:15, Eric Dumazet wrote:
> On Thu, Oct 8, 2020 at 6:37 PM Heiner Kallweit wrote:
>>
>> On 02.10.2020 13:48, Eric Dumazet wrote:
>>> On Fri, Oct 2, 2020 at 1:09 PM Heiner Kallweit wrote:
On 02.10.2020 10:46, Eric Dumazet wrote:
> On Fri, Oct 2, 2020 at 10:32 AM Eric D
From: Jonathan Lemon
netcons calls napi_poll with a budget of 0 to transmit packets.
Handle this by:
- skipping RX processing
- do not try to recycle TX packets to the RX cache
Signed-off-by: Jonathan Lemon
---
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 3 +++
drivers/net/ethernet/mellanox
On Thu, 8 Oct 2020 11:34:36 -0700 Jonathan Lemon wrote:
> From: Jonathan Lemon
>
> netcons will call napi_poll with a budget of 0, indicating
> a non-napi caller (and also called with irqs disabled). Call
> free_old_xmit_skbs() with the is_napi parameter set correctly.
This is a fix, can we get
On Thu, Oct 8, 2020 at 1:34 PM Cong Wang wrote:
>
> On Thu, Oct 8, 2020 at 4:49 AM Willem de Bruijn
> wrote:
> >
> > On Wed, Oct 7, 2020 at 9:22 PM Cong Wang wrote:
> > >
> > > GRE tunnel has its own header_ops, ipgre_header_ops, and sets it
> > > conditionally. When it is set, it assumes the ou
The ibmveth driver is a virtual Ethernet driver used on IBM pSeries systems.
Gso packets can be sent between LPARS (virtual hosts) without segmentation,
by flagging gso packets using one of two methods depending on the firmware
version. Some gso packet may not be correctly identified by the receive
On 10/8/20 8:50 PM, Eric Dumazet wrote:
>
>
> OK, it would be nice to know what is the input interface
>
> if4 -> look at "ip link | grep 4:"
>
> Then identifying the driver that built such a strange packet (32000
> bytes allocated in skb->head)
>
> ethtool -i ifname
>
According to https://
Ingress large send packets are identified by either:
The IBMVETH_RXQ_LRG_PKT flag in the receive buffer
or with a -1 placed in the ip header checksum.
The method used depends on firmware version.
Signed-off-by: David Wilder
Reviewed-by: Thomas Falcon
Reviewed-by: Cristobal Forno
Reviewed-by: Pr
ibmveth_rx_csum_helper() must be called after ibmveth_rx_mss_helper()
as ibmveth_rx_csum_helper() may alter ip and tcp checksum values.
Signed-off-by: David Wilder
Reviewed-by: Thomas Falcon
Reviewed-by: Cristobal Forno
Reviewed-by: Pradeep Satyanarayana
---
drivers/net/ethernet/ibm/ibmveth.c
On Thu, Oct 8, 2020 at 12:04 PM Willem de Bruijn
wrote:
>
> On Thu, Oct 8, 2020 at 1:34 PM Cong Wang wrote:
> >
> > The uninit data is allocated by packet_alloc_skb(), if dev->hard_header_len
> > is 0 and 'len' is anything between [0, tunnel->hlen + sizeof(struct iphdr)),
> > dev_validate_header(
On Thu, Oct 8, 2020 at 3:04 PM Willem de Bruijn
wrote:
>
> On Thu, Oct 8, 2020 at 1:34 PM Cong Wang wrote:
> >
> > On Thu, Oct 8, 2020 at 4:49 AM Willem de Bruijn
> > wrote:
> > >
> > > On Wed, Oct 7, 2020 at 9:22 PM Cong Wang wrote:
> > > >
> > > > GRE tunnel has its own header_ops, ipgre_head
On Thu, Oct 8, 2020 at 3:17 PM Xie He wrote:
>
> On Thu, Oct 8, 2020 at 12:04 PM Willem de Bruijn
> wrote:
> >
> > On Thu, Oct 8, 2020 at 1:34 PM Cong Wang wrote:
> > >
> > > The uninit data is allocated by packet_alloc_skb(), if
> > > dev->hard_header_len
> > > is 0 and 'len' is anything betwe
On Thu, Oct 08, 2020 at 12:01:02PM -0700, Jakub Kicinski wrote:
> On Thu, 8 Oct 2020 11:34:36 -0700 Jonathan Lemon wrote:
> > From: Jonathan Lemon
> >
> > netcons will call napi_poll with a budget of 0, indicating
> > a non-napi caller (and also called with irqs disabled). Call
> > free_old_xmit
On Thu, Oct 8, 2020 at 12:18 PM Willem de Bruijn
wrote:
>
> On Thu, Oct 8, 2020 at 3:04 PM Willem de Bruijn
> wrote:
> >
> > On Thu, Oct 8, 2020 at 1:34 PM Cong Wang wrote:
> > >
> > > On Thu, Oct 8, 2020 at 4:49 AM Willem de Bruijn
> > > wrote:
> > > >
> > > > On Wed, Oct 7, 2020 at 9:22 PM Co
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 7 Oct 2020 17:48:03 +0200 you wrote:
> With multiple DNAT rules it's possible that after destination
> translation the resulting tuples collide.
>
> For example, two openvswitch flows:
> nw_dst=10.0.0.10,tp_dst=10, act
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 7 Oct 2020 09:24:01 +0530 you wrote:
> In nl80211_parse_key(), key.idx is first initialized as -1.
> If this value of key.idx remains unmodified and gets returned, and
> nl80211_key_allowed() also returns 0, then rdev_d
Hello:
This pull request was applied to netdev/net.git (refs/heads/master):
On Thu, 8 Oct 2020 12:39:34 +0200 you wrote:
> Hi Dave,
>
> Not sure you were still planning to send anything to Linus,
> but even if not this single fix seemed appropriate for net.
> Seems to be a long-standing issue.
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 7 Oct 2020 13:34:51 +0200 you wrote:
> Some firmware files trigger a PHY soft reset and don't wait for it to
> be finished. PHY register writes directly after applying the firmware
> may fail or provide unexpected result
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 7 Oct 2020 01:42:46 -0700 you wrote:
> From: Eric Dumazet
>
> De-referencing skb after call to gro_cells_receive() is not allowed.
> We need to fetch skb->len earlier.
>
> Fixes: 5491e7c6b1a9 ("macsec: enable GRO and
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 7 Oct 2020 12:07:00 + you wrote:
> This commit is correcting NETLINK br_fill_ifinfo() to be able to
> handle 'filter_mask' with multiple flags asserted.
>
> Fixes: 36a8e8e265420 ("bridge: Extend br_fill_ifinfo to re
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 8 Oct 2020 01:38:31 -0700 you wrote:
> From: Eric Dumazet
>
> After freeing ep->auth_hmacs we have to clear the pointer
> or risk use-after-free as reported by syzbot:
>
> BUG: KASAN: use-after-free in sctp_auth_dest
On Thu, Oct 08, 2020 at 06:13:11PM +0200, Stefano Garzarella wrote:
> If riov and wiov are both defined and they point to different
> objects, only riov is initialized. If the wiov is not initialized
> by the caller, the function fails returning -EINVAL and printing
> "Readable desc 0x... after wri
On Thu, Oct 8, 2020 at 10:34 AM Jakub Kicinski wrote:
>
> On Wed, 7 Oct 2020 23:18:21 -0700 Cong Wang wrote:
> > This fixes an uninit-value warning:
> > BUG: KMSAN: uninit-value in can_receive+0x26b/0x630 net/can/af_can.c:650
> >
> > Reported-and-tested-by:
> > syzbot+3f3837e61a48d32b4...@syzkal
On Thu, Oct 8, 2020 at 12:20 PM Willem de Bruijn
wrote:
>
> On Thu, Oct 8, 2020 at 3:17 PM Xie He wrote:
> >
> > However, there's something I don't understand in the GRE code. The
> > ipgre_header function only creates an IP header (20 bytes) + a GRE
> > base header (4 bytes), but pushes and retu
From: Rao Shoaib
For AF_UNIX stream socket send SIGURG to the peer if
the msg has MSG_OOB flag set.
Signed-off-by: Rao Shoaib
---
net/unix/af_unix.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 92784e5..4f01d74 100644
--
From: Rao Shoaib
The use of AF_UNIX sockets is on the rise. We have a case where thousands
of processes connect locally to a database and issue queries that are
serviced by a pool of threads. Communication is done over AF_UNIX
sockets. Currently, there is no way for the submitter to signal the
se
On Wed, Oct 7, 2020 at 9:22 PM Cong Wang wrote:
>
> GRE tunnel has its own header_ops, ipgre_header_ops, and sets it
> conditionally. When it is set, it assumes the outer IP header is
> already created before ipgre_xmit().
>
> This is not true when we send packets through a raw packet socket,
> wh
Hi Linus!
Here is one more pull request with fixes from the networking tree,
selected with the filtering knobs for priority / risk / impact set
for -rc8 time.
- add missing input validation in nl80211_del_key(), preventing
out-of-bounds access
- last minute fix / improvement of a MRP netli
On Thu, Oct 08, 2020 at 04:00:51PM -0400, Michael S. Tsirkin wrote:
> On Thu, Oct 08, 2020 at 06:13:11PM +0200, Stefano Garzarella wrote:
> > If riov and wiov are both defined and they point to different
> > objects, only riov is initialized. If the wiov is not initialized
> > by the caller, the fu
On Thu, Oct 08, 2020 at 10:24:36PM +0200, Stefano Garzarella wrote:
> On Thu, Oct 08, 2020 at 04:00:51PM -0400, Michael S. Tsirkin wrote:
> > On Thu, Oct 08, 2020 at 06:13:11PM +0200, Stefano Garzarella wrote:
> > > If riov and wiov are both defined and they point to different
> > > objects, only r
The following changes since commit a127c5bbb6a8eee851cbdec254424c480b8edd75:
vhost-vdpa: fix backend feature ioctls (2020-09-24 05:54:36 -0400)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
for you to fetch changes up to
On Thu, Oct 8, 2020 at 4:11 PM Xie He wrote:
>
> On Thu, Oct 8, 2020 at 12:20 PM Willem de Bruijn
> wrote:
> >
> > On Thu, Oct 8, 2020 at 3:17 PM Xie He wrote:
> > >
> > > However, there's something I don't understand in the GRE code. The
> > > ipgre_header function only creates an IP header (20
On Thu, Oct 08, 2020 at 04:28:40PM -0400, Michael S. Tsirkin wrote:
> On Thu, Oct 08, 2020 at 10:24:36PM +0200, Stefano Garzarella wrote:
> > On Thu, Oct 08, 2020 at 04:00:51PM -0400, Michael S. Tsirkin wrote:
> > > On Thu, Oct 08, 2020 at 06:13:11PM +0200, Stefano Garzarella wrote:
> > > > If riov
If riov and wiov are both defined and they point to different
objects, only riov is initialized. If the wiov is not initialized
by the caller, the function fails returning -EINVAL and printing
"Readable desc 0x... after writable" error message.
This issue happens when descriptors have both readabl
On 08.10.2020 21:07, Eric Dumazet wrote:
>
>
> On 10/8/20 8:50 PM, Eric Dumazet wrote:
>>
>>
>> OK, it would be nice to know what is the input interface
>>
>> if4 -> look at "ip link | grep 4:"
>>
>> Then identifying the driver that built such a strange packet (32000
>> bytes allocated in skb->he
David Ahern writes:
> On 10/8/20 7:53 AM, Toke Høiland-Jørgensen wrote:
>> The bpf_fib_lookup() helper performs a neighbour lookup for the destination
>> IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with the expectation
>> that the BPF program will pass the packet up the stack in this case
Daniel Borkmann writes:
> On 10/8/20 4:53 PM, Toke Høiland-Jørgensen wrote:
>> The bpf_fib_lookup() helper performs a neighbour lookup for the destination
>> IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with the expectation
>> that the BPF program will pass the packet up the stack in this
On 10/8/20 10:59 PM, Toke Høiland-Jørgensen wrote:
Daniel Borkmann writes:
On 10/8/20 4:53 PM, Toke Høiland-Jørgensen wrote:
The bpf_fib_lookup() helper performs a neighbour lookup for the destination
IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with the expectation
that the BPF program
The MTU setting for this DSA switch is global so we need
to keep track of the MTU set for each port, then as soon
as any MTU changes, roof the MTU to the biggest common
denominator and poke that into the switch MTU setting.
To achieve this we need a per-chip-variant state container
for the RTL8366
Daniel Borkmann writes:
n> On 10/8/20 10:59 PM, Toke Høiland-Jørgensen wrote:
>> Daniel Borkmann writes:
>>> On 10/8/20 4:53 PM, Toke Høiland-Jørgensen wrote:
The bpf_fib_lookup() helper performs a neighbour lookup for the destination
IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails,
On Thu, 8 Oct 2020 16:51:54 +0200 Daniel Borkmann wrote:
> Hi David,
>
> The following pull-request contains BPF updates for your *net* tree.
>
> We've added 2 non-merge commits during the last 8 day(s) which contain
> a total of 2 files changed, 10 insertions(+), 4 deletions(-).
>
> The main c
On 10/8/2020 2:03 PM, Linus Walleij wrote:
The MTU setting for this DSA switch is global so we need
to keep track of the MTU set for each port, then as soon
as any MTU changes, roof the MTU to the biggest common
denominator and poke that into the switch MTU setting.
To achieve this we need a
Hi Xin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Xin-Long/sctp-Implement-RFC6951-UDP-Encapsulation-of-SCTP/20201008-175211
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net
On Thu, 08 Oct 2020 19:10:57 +0200 Bjørn Mork wrote:
> Jakub Kicinski writes:
>
> > I'm guessing that I'm supposed to take this patch into the networking
> > tree, correct?
>
> Correct.
>
> > Is this net or net-next candidate? Bjørn?
>
> Sorry, should have made that explicit. This is for n
Extend the test_tc_redirect test and add a small test that exercises the new
redirect_peer() helper for the IPv4 and IPv6 case.
Signed-off-by: Daniel Borkmann
---
.../selftests/bpf/progs/test_tc_peer.c| 45 +++
.../testing/selftests/bpf/test_tc_redirect.sh | 25 +++---
Rename into test_tc_redirect.sh and move setup and test code into separate
functions so they can be reused for newly added tests in here. Also remove
the crude hack to override ifindex inside the object file via xxd and sed
and just use a simple map instead. Map given iproute2 does not support BTF
Follow-up to address David's feedback that we should better describe internals
of the bpf_redirect_neigh() helper.
Suggested-by: David Ahern
Signed-off-by: Daniel Borkmann
---
include/uapi/linux/bpf.h | 10 +++---
tools/include/uapi/linux/bpf.h | 10 +++---
2 files changed, 14 ins
This series addresses most of the feedback [0] that was to be followed
up from the last series, that is, UAPI helper comment improvements and
getting rid of the ifindex obj file hacks in the selftest by using a
BPF map instead. The __sk_buff data/data_end pointer work, I'm planning
to do in a later
Add an efficient ingress to ingress netns switch that can be used out of tc BPF
programs in order to redirect traffic from host ns ingress into a container
veth device ingress without having to go via CPU backlog queue [0]. For local
containers this can also be utilized and path via CPU backlog que
Extend the "diff_size" subtest to also include a non-inlined array map variant
where dynamic inner #elems are possible.
Signed-off-by: Daniel Borkmann
---
.../selftests/bpf/prog_tests/btf_map_in_map.c | 39 -
.../selftests/bpf/progs/test_btf_map_in_map.c | 43 +++
Recent work in f4d05259213f ("bpf: Add map_meta_equal map ops") and 134fede4eecf
("bpf: Relax max_entries check for most of the inner map types") added support
for dynamic inner max elements for most map-in-map types. Exceptions were maps
like array or prog array where the map_gen_lookup() callback
On Thu, Oct 8, 2020 at 1:32 PM Willem de Bruijn
wrote:
>
> On Thu, Oct 8, 2020 at 4:11 PM Xie He wrote:
> >
> > OK. I understand that t->tun_hlen is the GRE header length. What is
> > t->encap_hlen?
>
> I've looked at that closely either.
>
> Appears to be to account for additional FOU/GUE encap:
The pull request you sent on Thu, 8 Oct 2020 16:30:51 -0400:
> https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3fdd47c3b40ac48e6e6e5904cf24d12e6e073a96
Thank you!
--
Deet-doot-dot, I am a bo
The pull request you sent on Thu, 8 Oct 2020 13:23:29 -0700:
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/6288c1d8024eebb7a1ccdbab80f6e857ac94eeb0
Thank you!
--
Deet-doot-dot, I am a
/mkl/linux-can.git
tags/linux-can-fixes-for-5.9-20201008
for you to fetch changes up to 13ba4c434422837d7c8c163f9c8d854e67bf3c99:
net: j1939: j1939_session_fresh_new(): fix missing initialization of skbcnt
(2020-10-08 23:28:09 +0200)
--
From: Cong Wang
This fixes an uninit-value warning:
BUG: KMSAN: uninit-value in can_receive+0x26b/0x630 net/can/af_can.c:650
Reported-and-tested-by: syzbot+3f3837e61a48d32b4...@syzkaller.appspotmail.com
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Cc: Robin van der Gracht
Cc:
On 10/1/20 11:49 AM, Frederic Weisbecker wrote:
> On Mon, Sep 28, 2020 at 02:35:25PM -0400, Nitesh Narayan Lal wrote:
>> Nitesh Narayan Lal (4):
>> sched/isolation: API to get number of housekeeping CPUs
>> sched/isolation: Extend nohz_full to isolate managed IRQs
>> i40e: Limit msix vectors
This patch add the initialization of skbcnt, similar to:
e009f95b1543 can: j1935: j1939_tp_tx_dat_new(): fix missing initialization
of skbcnt
Let's play save and initialize this skbcnt as well.
Suggested-by: Jakub Kicinski
Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Sign
From: Lucas Stach
0704c5743694 can: m_can_platform: remove unnecessary m_can_class_resume()
call
removed the m_can_class_resume() call in the runtime resume path to get
rid of a infinite recursion, so the runtime resume now only handles the device
clocks.
Unfortunately it did not remove th
On Thu, Oct 8, 2020 at 5:36 PM Xie He wrote:
>
> On Thu, Oct 8, 2020 at 1:32 PM Willem de Bruijn
> wrote:
> >
> > On Thu, Oct 8, 2020 at 4:11 PM Xie He wrote:
> > >
> > > OK. I understand that t->tun_hlen is the GRE header length. What is
> > > t->encap_hlen?
> >
> > I've looked at that closely
to net, in case there is a last
> minute PR to Linus for 5.9?
Yes, of you can pull Cong Wang's patch and my patch, that fixes the other
missing init of skbcnt.
That tag includes my previous oneline-patch-pull-request from 20201006, that
fixes the c_can driver on basically all stm32mp1 ba
+ * tcp_ddp.h
+ * Author: Boris Pismenny
+ * Copyright (C) 2020 Mellanox Technologies.
+ */
+#ifndef _TCP_DDP_H
+#define _TCP_DDP_H
+
+#include
Why is blkdev.h needed?
+#include
+#include
+#include
+
+/* limits returned by the offload driver, zero means don't care */
+struct tc
This commit itroduces support for CRC offload to direct data placement
introduces
ULP on the receive side. Both DDP and CRC share a common API to
initialize the offload for a TCP socket. But otherwise, both can
be executed independently.
From the API it not clear that the offl
On Thu, Oct 8, 2020 at 2:48 PM Willem de Bruijn
wrote:
>
> > I see the ipgre_xmit function would pull the header our header_ops
> > creates, and then call __gre_xmit. __gre_xmit will call
> > gre_build_header to complete the GRE header. gre_build_header expects
> > to find the base GRE header afte
Reviewed-by: Sagi Grimberg
In order to enable -Wimplicit-fallthrough for Clang[1], replace the
existing /* fall through */ comments with the new pseudo-keyword
macro fallthrough[2].
[1] https://git.kernel.org/linus/e2079e93f562c7f7a030eb7642017ee5eabaaa10
[2]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?hig
On 10/8/20 1:57 PM, Toke Høiland-Jørgensen wrote:
> David Ahern writes:
>
>> On 10/8/20 7:53 AM, Toke Høiland-Jørgensen wrote:
>>> The bpf_fib_lookup() helper performs a neighbour lookup for the destination
>>> IP and returns BPF_FIB_LKUP_NO_NEIGH if this fails, with the expectation
>>> that the
On 10/8/20 2:31 PM, Daniel Borkmann wrote:
> Follow-up to address David's feedback that we should better describe internals
> of the bpf_redirect_neigh() helper.
>
> Suggested-by: David Ahern
> Signed-off-by: Daniel Borkmann
> ---
> include/uapi/linux/bpf.h | 10 +++---
> tools/includ
In order to enable -Wimplicit-fallthrough for Clang[1], replace the
existing /* fall-through */ comments with the new pseudo-keyword
macro fallthrough[2].
[1] https://git.kernel.org/linus/e2079e93f562c7f7a030eb7642017ee5eabaaa10
[2]
https://www.kernel.org/doc/html/v5.7/process/deprecated.html?hig
> -Original Message-
> From: Leon Romanovsky
> Sent: Tuesday, October 6, 2020 10:23 AM
> To: Ertman, David M
> Cc: alsa-de...@alsa-project.org; ti...@suse.de; broo...@kernel.org; linux-
> r...@vger.kernel.org; j...@nvidia.com; dledf...@redhat.com;
> netdev@vger.kernel.org; da...@davemloft
On 9/30/20 9:20 AM, Boris Pismenny wrote:
This commit introduces direct data placement offload to NVME
TCP. There is a context per queue, which is established after the
handshake
using the tcp_ddp_sk_add/del NDOs.
Additionally, a resynchronization routine is used to assist
hardware recovery f
>
> That tag includes my previous oneline-patch-pull-request from 20201006, that
> fixes the c_can driver on basically all stm32mp1 based boards. Would be good
> to
> see that in 5.9, as well.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git
> tags/linux-
bool nvme_tcp_resync_request(struct sock *sk, u32 seq, u32 flags);
+void nvme_tcp_ddp_teardown_done(void *ddp_ctx);
const struct tcp_ddp_ulp_ops nvme_tcp_ddp_ulp_ops __read_mostly = {
+
.resync_request = nvme_tcp_resync_request,
+ .ddp_teardown_done = nvme_tcp_ddp
On Thu, Oct 8, 2020 at 3:04 PM Ertman, David M wrote:
>
> > -Original Message-
> > From: Leon Romanovsky
> > Sent: Tuesday, October 6, 2020 10:23 AM
> > To: Ertman, David M
> > Cc: alsa-de...@alsa-project.org; ti...@suse.de; broo...@kernel.org; linux-
> > r...@vger.kernel.org; j...@nvidi
crc offload of the nvme capsule. Check if all the skb bits
are on, and if not recalculate the crc in SW and check it.
Can you clarify in the patch description that this is only
for pdu data digest and not header digest?
This patch reworks the receive-side crc calculation to always
run at t
On 9/30/20 9:20 AM, Boris Pismenny wrote:
From: Or Gerlitz
For ddp setup/teardown and resync, the offloading logic
uses HW resources at the NIC driver such as SQ and CQ.
These resources are destroyed when the netdevice does down
and hence we must stop using them before the NIC driver
destro
static
int nvme_tcp_offload_socket(struct nvme_tcp_queue *queue,
struct nvme_tcp_config *config)
@@ -630,6 +720,7 @@ static void nvme_tcp_error_recovery(struct
nvme_ctrl *ctrl)
static int nvme_tcp_process_nvme_cqe(struct nvme_tcp_queue *queue,
struct nvme_com
You probably want Al to have a look at this..
On Wed, 7 Oct 2020 12:53:50 +0200 Johannes Berg wrote:
> From: Johannes Berg
>
> The ETHTOOL_A_STRSET_COUNTS_ONLY flag attribute was previously
> not allowed to be used, but now due to the policy size reduction
> we would access the tb[] array out of bounds since we tried to
> check for the attr
On Thu, Oct 8, 2020 at 2:54 PM Xie He wrote:
>
> OK. If the t->encap_hlen header needs to be placed before the GRE
> header, then I think the ipgre_header function should leave some space
> before the GRE header to place the t->encap_hlen header, rather than
> leaving space after the GRE header.
On Wed, Oct 7, 2020 at 12:32 PM Francesco Ruggeri wrote:
>
> If the first packet conntrack sees after a re-register is an outgoing
> keepalive packet with no data (SEG.SEQ = SND.NXT-1), td_end is set to
> SND.NXT-1.
> When the peer correctly acknowledges SND.NXT, tcp_in_window fails
> check III (U
On Thu, Oct 08, 2020 at 05:27:49PM +0100, John Keeping wrote:
> With threadirqs, stmmac_interrupt() is called on a thread with hardirqs
> enabled so we cannot call __napi_schedule_irqoff(). Under lockdep it
> leads to:
>
> [ cut here ]
> WARNING: CPU: 0 PID: 28
On Tue, 6 Oct 2020 11:41:54 +0530 Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
> @@ -815,7
On Tue, 6 Oct 2020 11:23:32 +0530 Allen Pais wrote:
> From: Allen Pais
>
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-o
On 9/30/20 9:20 AM, Boris Pismenny wrote:
This series adds support for nvme-tcp receive offloads
which do not mandate the offload of the network stack to the device.
Instead, these work together with TCP to offload:
1. copy from SKB to the block layer buffers
2. CRC verification for received P
On Thu, Oct 08, 2020 at 04:31:42PM +0300, Dan Carpenter wrote:
On Thu, Oct 08, 2020 at 07:58:03PM +0800, Coiby Xu wrote:
Initialize devlink health dump framework for the dlge driver so the
coredump could be done via devlink.
Signed-off-by: Coiby Xu
---
drivers/staging/qlge/Kconfig| 1
On Thu, Oct 08, 2020 at 04:39:40PM +0300, Dan Carpenter wrote:
On Thu, Oct 08, 2020 at 07:58:04PM +0800, Coiby Xu wrote:
-static int
-qlge_reporter_coredump(struct devlink_health_reporter *reporter,
- struct devlink_fmsg *fmsg, void *priv_ctx,
- struct
On Wed, 7 Oct 2020 09:51:11 -0700 Eric Dumazet wrote:
> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
> index
> 6c762457122fd0091cb0f2bf41bda73babc4ac12..d8fd8676fc724110630904909f64d7789f3a4b47
> 100644
> --- a/include/net/sch_generic.h
> +++ b/include/net/sch_generic.h
> @
On Tue, 6 Oct 2020 08:27:34 +0200 Paolo Abeni wrote:
> If recvmsg() and the workqueue race to dequeue the data
> pending on some subflow, the current mapping for such
> subflow covers several skbs and some of them have not
> reached yet the received, either the worker or recvmsg()
> can find a sub
301 - 400 of 451 matches
Mail list logo
