Re: [PATCH can-next] can: add ISO 15765-2:2016 transport protocol

2020-10-07 Thread Oliver Hartkopp
On 06.10.20 22:27, Marc Kleine-Budde wrote: On 9/28/20 10:04 PM, Oliver Hartkopp wrote: CAN Transport Protocols offer support for segmented Point-to-Point communication between CAN nodes via two defined CAN Identifiers. As CAN frames can only transport a small amount of data bytes (max. 8 byt

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-07 Thread Johannes Berg
On Wed, 2020-10-07 at 09:27 +0300, Leon Romanovsky wrote: > > This series and my guess that it comes from ff419afa4310 ("ethtool: trim > policy tables") > generates the following KASAN out-of-bound error. Interesting. I guess that is req_info->counts_only = tb[ETHTOOL_A_STRSET_COUNTS_ON

Re: [PATCH bpf-next V1 2/6] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-07 Thread kernel test robot
Hi Jesper, url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-New-approach-for-BPF-MTU-handling-and-enforcement/20201007-000903 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: s390-randconfig-m031-20201002 (attached as .config

Re: [PATCH bpf-next V1 2/6] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-07 Thread Jesper Dangaard Brouer
On Tue, 6 Oct 2020 18:34:50 -0700 Maciej Żenczykowski wrote: > On Tue, Oct 6, 2020 at 9:03 AM Jesper Dangaard Brouer > wrote: > > > > The BPF-helpers for FIB lookup (bpf_xdp_fib_lookup and bpf_skb_fib_lookup) > > can perform MTU check and return BPF_FIB_LKUP_RET_FRAG_NEEDED. The BPF-prog > > d

Re: [PATCH bpf-next V1 3/6] bpf: add BPF-helper for reading MTU from net_device via ifindex

2020-10-07 Thread Jesper Dangaard Brouer
On Tue, 6 Oct 2020 18:24:28 -0700 Maciej Żenczykowski wrote: > On Tue, Oct 6, 2020 at 6:19 PM Jakub Kicinski wrote: > > > > On Tue, 6 Oct 2020 18:33:02 +0200 Jesper Dangaard Brouer wrote: > > > > +static const struct bpf_func_proto bpf_xdp_mtu_lookup_proto = { > > > > + .func = bpf

Re: PHY reset question

2020-10-07 Thread Marco Felsch
Hi Marek, On 20-10-06 14:11, Florian Fainelli wrote: > On 10/6/2020 1:24 PM, Marek Vasut wrote: ... > > If this happens on MX6 with FEC, can you please try these two patches? > > > > https://patchwork.ozlabs.org/project/netdev/patch/20201006135253.97395-1-ma...@denx.de/ > > > > https://patchwo

Re: net: Initialize return value in gro_cells_receive

2020-10-07 Thread Eric Dumazet
On 10/6/20 8:53 PM, Gregory Rose wrote: > The 'res' return value is uninitalized and may be returned with > some random value.  Initialize to NET_RX_DROP as the default > return value. > > Signed-off-by: Greg Rose > > diff --git a/net/core/gro_cells.c b/net/core/gro_cells.c > index e095fb871d

Re: PHY reset question

2020-10-07 Thread Marek Vasut
On 10/7/20 10:14 AM, Marco Felsch wrote: > Hi Marek, Hi, [...] > On 20-10-06 14:11, Florian Fainelli wrote: >> On 10/6/2020 1:24 PM, Marek Vasut wrote: > > ... > >>> If this happens on MX6 with FEC, can you please try these two patches? >>> >>> https://patchwork.ozlabs.org/project/netdev/patch

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 09:30:51AM +0200, Johannes Berg wrote: > On Wed, 2020-10-07 at 09:27 +0300, Leon Romanovsky wrote: > > > > This series and my guess that it comes from ff419afa4310 ("ethtool: trim > > policy tables") > > generates the following KASAN out-of-bound error. > > Interesting. I g

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-07 Thread Johannes Berg
On Wed, 2020-10-07 at 11:24 +0300, Leon Romanovsky wrote: > On Wed, Oct 07, 2020 at 09:30:51AM +0200, Johannes Berg wrote: > > On Wed, 2020-10-07 at 09:27 +0300, Leon Romanovsky wrote: > > > This series and my guess that it comes from ff419afa4310 ("ethtool: trim > > > policy tables") > > > genera

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 10:29:01AM +0200, Johannes Berg wrote: > On Wed, 2020-10-07 at 11:24 +0300, Leon Romanovsky wrote: > > On Wed, Oct 07, 2020 at 09:30:51AM +0200, Johannes Berg wrote: > > > On Wed, 2020-10-07 at 09:27 +0300, Leon Romanovsky wrote: > > > > This series and my guess that it come

[PATCH net] macsec: avoid use-after-free in macsec_handle_frame()

2020-10-07 Thread Eric Dumazet
From: Eric Dumazet De-referencing skb after call to gro_cells_receive() is not allowed. We need to fetch skb->len earlier. Fixes: 5491e7c6b1a9 ("macsec: enable GRO and RPS on macsec devices") Signed-off-by: Eric Dumazet Cc: Paolo Abeni --- drivers/net/macsec.c | 4 +++- 1 file changed, 3 inse

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-07 Thread Michal Kubecek
On Wed, Oct 07, 2020 at 11:24:37AM +0300, Leon Romanovsky wrote: > Yes, it fixed KASAN, but it we got new failure after that. > > 11:07:51 player_id: 1 shell.py:62 [LinuxEthtoolAgent] DEBUG : running > command(/opt/mellanox/ethtool/sbin/ethtool --set-channels eth2 combined 3) > with pid: 13409 >

[net v3] net: dsa: microchip: fix race condition

2020-10-07 Thread Christian Eggers
Between queuing the delayed work and finishing the setup of the dsa ports, the process may sleep in request_module() (via phy_device_create()) and the queued work may be executed prior to the switch net devices being registered. In ksz_mib_read_work(), a NULL dereference will happen within netof_ca

Re: PHY reset question

2020-10-07 Thread Marco Felsch
On 20-10-07 10:23, Marek Vasut wrote: > On 10/7/20 10:14 AM, Marco Felsch wrote: > > Hi Marek, > > Hi, > > [...] > > > On 20-10-06 14:11, Florian Fainelli wrote: > >> On 10/6/2020 1:24 PM, Marek Vasut wrote: > > > > ... > > > >>> If this happens on MX6 with FEC, can you please try these two pa

WARNING in ieee80211_free_ack_frame

2020-10-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=121fa53f90 kernel config: https://syzkaller.appspot.com/x/.config?x=c06bcf3cc963d91c das

general protection fault in ieee80211_key_free

2020-10-07 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=10e6e93f90 kernel config: https://syzkaller.appspot.com/x/.config?x=de7f697da23057c7 das

Re: [PATCH] net/mlx5e: Fix freeing of unassigned pointer

2020-10-07 Thread Alex Dewar
On Tue, Oct 06, 2020 at 04:22:12PM -0700, Saeed Mahameed wrote: > On Sat, 2020-10-03 at 12:10 +0100, Alex Dewar wrote: > > Commit ff7ea04ad579 ("net/mlx5e: Fix potential null pointer > > dereference") > > added some missing null checks but the error handling in > > mlx5e_alloc_flow() was left broke

Re: PHY reset question

2020-10-07 Thread Marek Vasut
On 10/7/20 11:06 AM, Marco Felsch wrote: > On 20-10-07 10:23, Marek Vasut wrote: >> On 10/7/20 10:14 AM, Marco Felsch wrote: >>> Hi Marek, >> >> Hi, >> >> [...] >> >>> On 20-10-06 14:11, Florian Fainelli wrote: On 10/6/2020 1:24 PM, Marek Vasut wrote: >>> >>> ... >>> > If this happens on M

[PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C driver

2020-10-07 Thread Christian Eggers
Add support for the KSZ9563 3-Port Gigabit Ethernet Switch to the ksz9477 driver. The KSZ9563 supports both SPI (already in) and I2C. The ksz9563 is already in the device tree binding documentation. Signed-off-by: Christian Eggers --- drivers/net/dsa/microchip/ksz9477_i2c.c | 1 + 1 file changed

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-07 Thread Eric Dumazet
On 10/7/20 5:55 AM, Hangbin Liu wrote: > kfree_skb(skb); > @@ -282,6 +285,21 @@ static struct sk_buff *ip6_rcv_core(struct sk_buff *skb, > struct net_device *dev, > } > } > > + /* RFC 8200, Section 4.5 Fragment Header: > + * If the first fragment do

Re: [net-next PATCH v2] net: dsa: rtl8366rb: Roof MTU for switch

2020-10-07 Thread Linus Walleij
On Wed, Oct 7, 2020 at 12:19 AM kernel test robot wrote: > I love your patch! Yet something to improve: > > [auto build test ERROR on net-next/master] Ooops fixing syntax without checking semantics, will respin. Yours, Linus Walleij

Re: [RESEND net-next 1/8] net: dccp: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
net/dccp/timer.c:223: warning: Function parameter or member 't' not described in 'dccp_write_xmitlet' net/dccp/timer.c:223: warning: Excess function parameter 'data' description in 'dccp_write_xmitlet' My bad. Will fix it. Thanks.

[PATCH net-next v2 2/4] enetc: Clean up serdes configuration

2020-10-07 Thread Claudiu Manoil
Decouple internal mdio bus creation from serdes configuration, as a prerequisite to offloading serdes configuration to a different module. Group together mdio bus creation routines, cleanup. Signed-off-by: Claudiu Manoil --- v2: none .../net/ethernet/freescale/enetc/enetc_pf.c | 101 +

[PATCH net-next v2 1/4] enetc: Clean up MAC and link configuration

2020-10-07 Thread Claudiu Manoil
Decouple level MAC configuration based on phy interface type from general port configuration. Group together MAC and link configuration code. Decouple external mdio bus creation from interface type parsing. No longer return an (unhandled) error code when phy_node not found, use phy_node to indicat

[PATCH net-next v2 4/4] enetc: Migrate to PHYLINK and PCS_LYNX

2020-10-07 Thread Claudiu Manoil
This is a methodical transition of the driver from phylib to phylink, following the guidelines from sfp-phylink.rst. The MAC register configurations based on interface mode were moved from the probing path to the mac_config() hook. MAC enable and disable commands (enabling Rx and Tx paths at MAC le

[PATCH net-next v2 3/4] arm64: dts: fsl-ls1028a-rdb: Specify in-band mode for ENETC port 0

2020-10-07 Thread Claudiu Manoil
As part of the transition of the enetc ethernet driver from phylib to phylink, the in-band operation mode of the SGMII interface from enetc port 0 needs to be specified explicitly for phylink. Signed-off-by: Claudiu Manoil --- v3: none arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts | 1 + 1

[PATCH net-next v2 0/4] enetc: Migrate to PHYLINK and PCS_LYNX

2020-10-07 Thread Claudiu Manoil
Transitioning the enetc driver from phylib to phylink. Offloading the serdes configuration to the PCS_LYNX module is a mandatory part of this transition. Aiming for a cleaner, more maintainable design, and better code reuse. The first 2 patches are clean up prerequisites. Tested on a p1028rdb boar

Re: PHY reset question

2020-10-07 Thread Fabio Estevam
Hi Oleksij, On Tue, Oct 6, 2020 at 5:05 AM Oleksij Rempel wrote: > > Hello PHY experts, > > Short version: > what is the proper way to handle the PHY reset before identifying PHY? > > Long version: > I stumbled over following issue: > If PHY reset is registered within PHY node. Then, sometimes,

RE: [PATCH net-next 4/4] enetc: Migrate to PHYLINK and PCS_LYNX

2020-10-07 Thread Claudiu Manoil
>-Original Message- >From: Ioana Ciornei >Sent: Tuesday, October 6, 2020 9:09 AM [...] > >Shouldn't the driver reject any interface mode which it does not support? >Either here in the validate callback or directly where the pf->if_mode is set. > Agreed on the 2 findings. v2 sent. Thanks I

[net-next v2 4/8] net: mac802154: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Acked-by: Stefan Schmidt Signed-off-by: Romain Perier Signed-off-by: Allen

[net-next v2 0/8] net: convert tasklets to use new

2020-10-07 Thread Allen Pais
From: Allen Pais Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' introduced a new tasklet initialization API. This series converts all the net/* drivers to use the new tasklet_setup() API The following series is based on net-next (9faebeb2d) v1: fix kerneldoc Allen Pais (8

[net-next v2 5/8] net: rds: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/rds/ib_cm.c

[net-next v2 3/8] net: mac80211: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/mac80211/ie

[net-next v2 1/8] net: dccp: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/dccp/timer.

[net-next v2 6/8] net: sched: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/sched/sch_a

[net-next v2 2/8] net: ipv4: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/ipv4/tcp_ou

[net-next v2 8/8] net: xfrm: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/xfrm/xfrm_i

[net-next v2 7/8] net: smc: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- net/smc/smc_cdc

[PATCH 0/2] net, mac80211: enable KCOV remote coverage collection for 802.11 frame handling

2020-10-07 Thread Aleksandr Nogikh
From: Aleksandr Nogikh This patch series enables remote KCOV coverage collection for the mac80211 code that processes incoming 802.11 frames. These changes make it possible to perform coverage-guided fuzzing in search of remotely triggerable bugs. The series consists of two commits. 1. Remember

[PATCH 1/2] net: store KCOV remote handle in sk_buff

2020-10-07 Thread Aleksandr Nogikh
From: Aleksandr Nogikh Remote KCOV coverage collection enables coverage-guided fuzzing of the code that is not reachable during normal system call execution. It is especially helpful for fuzzing networking subsystems, where it is common to perform packet handling in separate work queues even for

[PATCH 2/2] mac80211: add KCOV remote annotations to incoming frame processing

2020-10-07 Thread Aleksandr Nogikh
From: Aleksandr Nogikh Add KCOV remote annotations to ieee80211_iface_work and ieee80211_tasklet_handler. This will enable coverage-guided fuzzing of mac80211 code that processes incoming 802.11 frames. Signed-off-by: Aleksandr Nogikh --- net/mac80211/iface.c | 2 ++ net/mac80211/main.c | 2 +

[PATCH 0/7] wfx: move out from the staging area

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller I think the wfx driver is now mature enough to be accepted in the drivers/net/wireless directory. There is still one item on the TODO list. It is an idea to improve the rate control in some particular cases[1]. However, the current performances of the driver seem to satisfy

[PATCH 1/7] staging: wfx: fix handling of MMIC error

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller As expected, when the device detect a MMIC error, it returns a specific status. However, it also strip IV from the frame (don't ask me why). So, with the current code, mac80211 detects a corrupted frame and it drops it before it handle the MMIC error. The expected behavior

[PATCH 2/7] staging: wfx: remove remaining code of 'secure link' feature

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller Commit e8d607ce0c81 ("staging: wfx: drop 'secure link' feature") had removed the 'secure link' feature. However, a few lines of codes were yet here. Fixes: e8d607ce0c81 ("staging: wfx: drop 'secure link' feature") Signed-off-by: Jérôme Pouiller --- .../bindings/net/wirele

[PATCH 3/7] staging: wfx: fix BA sessions for older firmwares

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller Firmwares with API < 3.6 do not forward DELBA requests. Thus, when a Block Ack session is restarted, the reordering buffer is not flushed and the received sequence number is not contiguous. Therefore, mac80211 starts to wait some missing frames that it will never receive. T

[PATCH 4/7] staging: wfx: fix QoS priority for slow buses

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller The device is in charge of respecting the QoS constraints. The driver have to ensure that all the queues contain data and the device choose the right queue to send. The things starts to be more difficult when the bandwidth of the bus is lower than the bandwidth of the WiFi.

[PATCH 7/7] wfx: move out from the staging area

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller The wfx driver is now mature enough to leave the staging area. Signed-off-by: Jérôme Pouiller --- .../bindings/net/wireless/silabs,wfx.yaml | 0 MAINTAINERS | 2 +- drivers/net/wireless/Kconfig| 1 + drivers

[PATCH 6/7] dt-bindings: staging: wfx: silabs,wfx yaml conversion

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller The device can be connected on SPI or on SDIO. The original file described the two options separately. So, most of the file had to be rewritten in order to match with the Yaml requirements. Some device requirements are still written in the comments since they cannot been ex

[PATCH 5/7] staging: wfx: update copyrights dates

2020-10-07 Thread Jerome Pouiller
From: Jérôme Pouiller Most of the files have been modified in 2020, so update the copyright notices. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/bh.h | 2 +- drivers/staging/wfx/bus.h | 2 +- drivers/staging/wfx/

Re: [PATCH net-next v2 3/4] arm64: dts: fsl-ls1028a-rdb: Specify in-band mode for ENETC port 0

2020-10-07 Thread Vladimir Oltean
On Wed, Oct 07, 2020 at 12:48:22PM +0300, Claudiu Manoil wrote: > As part of the transition of the enetc ethernet driver from phylib > to phylink, the in-band operation mode of the SGMII interface > from enetc port 0 needs to be specified explicitly for phylink. > > Signed-off-by: Claudiu Manoil

[PATCH v2 2/3] wireless: mt7601u: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/wir

[PATCH v2 1/3] wireless: mt76: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/wir

[PATCH v2 3/3] ath11k: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/wir

[PATCH v2 0/3] wireless: convert tasklets to use new

2020-10-07 Thread Allen Pais
From: Allen Pais This series converts the remaining drivers to use new tasklet_setup() API. The patches are based on wireless-drivers-next (c2568c8c9e63) v2: Split mt76 and mt7601u Allen Pais (3): wireless: mt76: convert tasklets to use new tasklet_setup() API wireless: mt7601u: convert

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-07 Thread Kurt Kanzenbach
On Tue Oct 06 2020, Vladimir Oltean wrote: > On Tue, Oct 06, 2020 at 03:56:31PM +0200, Kurt Kanzenbach wrote: >> On Tue Oct 06 2020, Vladimir Oltean wrote: >> > On Tue, Oct 06, 2020 at 03:30:36PM +0200, Kurt Kanzenbach wrote: >> >> That's the point. The user (or anybody else) cannot disable hardwar

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 10:29:01AM +0200, Johannes Berg wrote: > On Wed, 2020-10-07 at 11:24 +0300, Leon Romanovsky wrote: > > On Wed, Oct 07, 2020 at 09:30:51AM +0200, Johannes Berg wrote: > > > On Wed, 2020-10-07 at 09:27 +0300, Leon Romanovsky wrote: > > > > This series and my guess that it come

Re: PHY reset question

2020-10-07 Thread Marco Felsch
On 20-10-07 11:20, Marek Vasut wrote: > On 10/7/20 11:06 AM, Marco Felsch wrote: ... > > You're right, just wanted to provide you a link :) > > Can you CC me on the next version of those patches ? I seems the LAN8710 > is causing grief to many. No need to since this serie was already applied.

Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 10:52:47AM +0200, Michal Kubecek wrote: > On Wed, Oct 07, 2020 at 11:24:37AM +0300, Leon Romanovsky wrote: > > Yes, it fixed KASAN, but it we got new failure after that. > > > > 11:07:51 player_id: 1 shell.py:62 [LinuxEthtoolAgent] DEBUG : running > > command(/opt/mellanox/

Re: [PATCH net-next v2 01/10] dt-bindings: net: add the dpaa2-mac DTS definition

2020-10-07 Thread Ioana Ciornei
On Tue, Oct 06, 2020 at 03:56:35PM -0500, Rob Herring wrote: > On Sat, Oct 03, 2020 at 12:07:28AM +0300, Ioana Ciornei wrote: > > Add a documentation entry for the DTS bindings needed and supported by > > the dpaa2-mac driver. > > > > Signed-off-by: Ioana Ciornei > > --- > > Changes in v2: > > -

Re: [PATCH net-next v2 4/4] enetc: Migrate to PHYLINK and PCS_LYNX

2020-10-07 Thread Ioana Ciornei
On Wed, Oct 07, 2020 at 12:48:23PM +0300, Claudiu Manoil wrote: > This is a methodical transition of the driver from phylib > to phylink, following the guidelines from sfp-phylink.rst. > The MAC register configurations based on interface mode > were moved from the probing path to the mac_config() h

[PATCH 1/2] ethtool: strset: allow ETHTOOL_A_STRSET_COUNTS_ONLY attr

2020-10-07 Thread Johannes Berg
From: Johannes Berg The ETHTOOL_A_STRSET_COUNTS_ONLY flag attribute was previously not allowed to be used, but now due to the policy size reduction we would access the tb[] array out of bounds since we tried to check for the attribute despite it not being accepted. Fix both issues by adding it c

Re: [PATCH 0/7] wfx: move out from the staging area

2020-10-07 Thread Greg Kroah-Hartman
On Wed, Oct 07, 2020 at 12:19:36PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller > > I think the wfx driver is now mature enough to be accepted in the > drivers/net/wireless directory. > > There is still one item on the TODO list. It is an idea to improve the rate > control in some parti

[PATCH 2/2] ethtool: correct policy for ETHTOOL_MSG_CHANNELS_SET

2020-10-07 Thread Johannes Berg
From: Johannes Berg This accidentally got wired up to the *get* policy instead of the *set* policy, causing operations to be rejected. Fix it by wiring up the correct policy instead. Fixes: 5028588b62cb ("ethtool: wire up set policies to ops") Reported-by: Leon Romanovsky Signed-off-by: Johanne

Re: [PATCH net-next v6 4/7] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-07 Thread Vladimir Oltean
On Wed, Oct 07, 2020 at 12:39:49PM +0200, Kurt Kanzenbach wrote: > On Tue Oct 06 2020, Vladimir Oltean wrote: > > On Tue, Oct 06, 2020 at 03:56:31PM +0200, Kurt Kanzenbach wrote: > >> Yeah, sure. That use case makes sense. What's the problem exactly? > > > > The SO_TIMESTAMPING / SO_TIMESTAMPNS cms

Re: [PATCH net-next v2 1/4] enetc: Clean up MAC and link configuration

2020-10-07 Thread Ioana Ciornei
On Wed, Oct 07, 2020 at 12:48:20PM +0300, Claudiu Manoil wrote: > Decouple level MAC configuration based on phy interface type > from general port configuration. > Group together MAC and link configuration code. > Decouple external mdio bus creation from interface type > parsing. No longer return

Re: [PATCH net-next v2 2/4] enetc: Clean up serdes configuration

2020-10-07 Thread Ioana Ciornei
On Wed, Oct 07, 2020 at 12:48:21PM +0300, Claudiu Manoil wrote: > Decouple internal mdio bus creation from serdes > configuration, as a prerequisite to offloading > serdes configuration to a different module. > Group together mdio bus creation routines, cleanup. > > Signed-off-by: Claudiu Manoil

Re: [net-next v2 3/8] net: mac80211: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Johannes Berg
On Wed, 2020-10-07 at 15:42 +0530, Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly. > Reviewed-

Re: [net-next v2 3/8] net: mac80211: convert tasklets to use new tasklet_setup() API

2020-10-07 Thread Allen Pais
On 07/10/20 4:25 pm, Johannes Berg wrote: On Wed, 2020-10-07 at 15:42 +0530, Allen Pais wrote: From: Allen Pais In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the taskl

Re: [PATCH 1/2] ethtool: strset: allow ETHTOOL_A_STRSET_COUNTS_ONLY attr

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 12:53:50PM +0200, Johannes Berg wrote: > From: Johannes Berg > > The ETHTOOL_A_STRSET_COUNTS_ONLY flag attribute was previously > not allowed to be used, but now due to the policy size reduction > we would access the tb[] array out of bounds since we tried to > check for th

Re: [PATCH 2/2] ethtool: correct policy for ETHTOOL_MSG_CHANNELS_SET

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 12:53:51PM +0200, Johannes Berg wrote: > From: Johannes Berg > > This accidentally got wired up to the *get* policy instead > of the *set* policy, causing operations to be rejected. Fix > it by wiring up the correct policy instead. > > Fixes: 5028588b62cb ("ethtool: wire up

[PATCH net] r8169: consider that PHY reset may still be in progress after applying firmware

2020-10-07 Thread Heiner Kallweit
Some firmware files trigger a PHY soft reset and don't wait for it to be finished. PHY register writes directly after applying the firmware may fail or provide unexpected results therefore. Fix this by waiting for bit BMCR_RESET to be cleared after applying firmware. There's nothing wrong with the

[PATCH bpf-next v2] libbpf: fix compatibility problem in xsk_socket__create

2020-10-07 Thread Magnus Karlsson
From: Magnus Karlsson Fix a compatibility problem when the old XDP_SHARED_UMEM mode is used together with the xsk_socket__create() call. In the old XDP_SHARED_UMEM mode, only sharing of the same device and queue id was allowed, and in this mode, the fill ring and completion ring were shared betwe

Re: [PATCH 0/2] net, mac80211: enable KCOV remote coverage collection for 802.11 frame handling

2020-10-07 Thread Johannes Berg
On Wed, 2020-10-07 at 10:17 +, Aleksandr Nogikh wrote: > From: Aleksandr Nogikh > > This patch series enables remote KCOV coverage collection for the > mac80211 code that processes incoming 802.11 frames. These changes > make it possible to perform coverage-guided fuzzing in search of > remot

Re: [PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C driver

2020-10-07 Thread Andrew Lunn
On Wed, Oct 07, 2020 at 11:30:49AM +0200, Christian Eggers wrote: > Add support for the KSZ9563 3-Port Gigabit Ethernet Switch to the > ksz9477 driver. The KSZ9563 supports both SPI (already in) and I2C. The > ksz9563 is already in the device tree binding documentation. Hi Christian What chip_id

Re: [PATCH net-next v2 03/16] devlink: Add devlink reload limit option

2020-10-07 Thread Vasundhara Volam
On Wed, Oct 7, 2020 at 11:32 AM Moshe Shemesh wrote: > > Add reload limit to demand restrictions on reload actions. > Reload limits supported: > no_reset: No reset allowed, no down time allowed, no link flap and no > configuration is lost. > > By default reload limit is unspecified and s

[PATCH net] net:ipv6: Discard next-hop MTU less than minimum link MTU

2020-10-07 Thread Georg Kohmann
When a ICMPV6_PKT_TOOBIG report a next-hop MTU that is less than the IPv6 minimum link MTU, the estimated path MTU is reduced to the minimum link MTU. This behaviour breaks TAHI IPv6 Core Conformance Test v6LC4.1.6: Packet Too Big Less than IPv6 MTU. Referring to RFC 8201 section 4: "If a node rec

RE: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Saleem, Shiraz
> Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote: > > > > On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote: > > > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > > > > > On Tue, Oct 06, 2020 at 05:09:09

Re: [PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C driver

2020-10-07 Thread Christian Eggers
Hi Andrew, > What chip_id values does it use? I don't see it listed in > ksz9477_switch_chips. here a short dump of the first chip registers: > Chip ID0 00 > Chip ID1_2 9893 Chip ID 9893 > Chip ID3 60Revision ID 6 Reset >

Re: [PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C driver

2020-10-07 Thread Andrew Lunn
On Wed, Oct 07, 2020 at 03:13:15PM +0200, Christian Eggers wrote: > Hi Andrew, > > > What chip_id values does it use? I don't see it listed in > > ksz9477_switch_chips. > > here a short dump of the first chip registers: > > > Chip ID0 00 > > Chip ID1_2 9893 Chip ID

Re: [PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C driver

2020-10-07 Thread Andrew Lunn
On Wed, Oct 07, 2020 at 11:30:49AM +0200, Christian Eggers wrote: > Add support for the KSZ9563 3-Port Gigabit Ethernet Switch to the > ksz9477 driver. The KSZ9563 supports both SPI (already in) and I2C. The > ksz9563 is already in the device tree binding documentation. > > Signed-off-by: Christia

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-07 Thread Greg Kroah-Hartman
On Mon, Oct 05, 2020 at 08:58:33PM +0200, Marcel Holtmann wrote: > Hi Greg, > > >> This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > >> as it > >> breaks all bluetooth connections on my machine. > >> > >> Cc: Marcel Holtman

Re: [PATCH v2 1/6] Add ancillary bus support

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 01:09:55PM +, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support > > > > On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote: > > > > > > On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote: > > > > > Subject: Re: [PATCH v2 1/6]

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-07 Thread Greg Kroah-Hartman
On Wed, Oct 07, 2020 at 03:23:21PM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 05, 2020 at 08:58:33PM +0200, Marcel Holtmann wrote: > > Hi Greg, > > > > >> This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > >> as it > > >> breaks all bluetooth

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-07 Thread Greg Kroah-Hartman
On Wed, Oct 07, 2020 at 03:40:25PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 07, 2020 at 03:23:21PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Oct 05, 2020 at 08:58:33PM +0200, Marcel Holtmann wrote: > > > Hi Greg, > > > > > > >> This reverts commit > > > >> 0eee35b

Re: WARNING in ieee80211_free_ack_frame

2020-10-07 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1693362790 kernel config: https://syzkaller.appspot.com/x/.config?x=c06bcf3

Re: [PATCH net] macsec: avoid use-after-free in macsec_handle_frame()

2020-10-07 Thread Paolo Abeni
Hi, On Wed, 2020-10-07 at 01:42 -0700, Eric Dumazet wrote: > @@ -1232,9 +1233,10 @@ static rx_handler_result_t macsec_handle_frame(struct > sk_buff **pskb) > macsec_rxsc_put(rx_sc); > > skb_orphan(skb); > + len = skb->len; > ret = gro_cells_receive(&macsec->gro_cells, skb)

Re: [PATCH 0/2] net, mac80211: enable KCOV remote coverage collection for 802.11 frame handling

2020-10-07 Thread Aleksandr Nogikh
On Wed, 7 Oct 2020 at 14:48, Johannes Berg wrote: > > On Wed, 2020-10-07 at 10:17 +, Aleksandr Nogikh wrote: [...] > > Aleksandr Nogikh (2): > > net: store KCOV remote handle in sk_buff > > Can you explain that a bit better? What is a "remote handle"? What does > it do in the SKB? > > I gues

Re: [PATCH net] macsec: avoid use-after-free in macsec_handle_frame()

2020-10-07 Thread Paolo Abeni
On Wed, 2020-10-07 at 16:31 +0200, Eric Dumazet wrote: > On Wed, Oct 7, 2020 at 4:09 PM Paolo Abeni wrote: > > Hi, > > > > On Wed, 2020-10-07 at 01:42 -0700, Eric Dumazet wrote: > > > @@ -1232,9 +1233,10 @@ static rx_handler_result_t > > > macsec_handle_frame(struct sk_buff **pskb) > > > m

Re: [PATCH net] bridge: Netlink interface fix.

2020-10-07 Thread Nikolay Aleksandrov
On Wed, 2020-10-07 at 12:07 +, Henrik Bjoernlund wrote: > This commit is correcting NETLINK br_fill_ifinfo() to be able to > handle 'filter_mask' with multiple flags asserted. > > Fixes: 36a8e8e265420 ("bridge: Extend br_fill_ifinfo to return MPR status") > > Signed-off-by: Henrik Bjoernlund

Re: [PATCH net 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2020-10-07 Thread Jakub Kicinski
On Wed, 7 Oct 2020 11:55:02 +0800 Hangbin Liu wrote: > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then that fragment should be discarded and > an ICMP Parameter Problem, Code 3, message sho

Re: [PATCH 1/2] ethtool: strset: allow ETHTOOL_A_STRSET_COUNTS_ONLY attr

2020-10-07 Thread Jakub Kicinski
On Wed, 7 Oct 2020 12:53:50 +0200 Johannes Berg wrote: > From: Johannes Berg > > The ETHTOOL_A_STRSET_COUNTS_ONLY flag attribute was previously > not allowed to be used, but now due to the policy size reduction > we would access the tb[] array out of bounds since we tried to > check for the attr

Re: [PATCH 2/2] ethtool: correct policy for ETHTOOL_MSG_CHANNELS_SET

2020-10-07 Thread Jakub Kicinski
On Wed, 7 Oct 2020 12:53:51 +0200 Johannes Berg wrote: > From: Johannes Berg > > This accidentally got wired up to the *get* policy instead > of the *set* policy, causing operations to be rejected. Fix > it by wiring up the correct policy instead. > > Fixes: 5028588b62cb ("ethtool: wire up set

[RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL

2020-10-07 Thread Kenny Ho
This is a skeleton implementation to invite comments and generate discussion around the idea of introducing a bpf-cgroup program type to control ioctl access. This is modelled after BPF_PROG_TYPE_CGROUP_DEVICE. The premise is to allow system admins to write bpf programs to block some ioctl access

[PATCH 1/7] igb: XDP xmit back fix error code

2020-10-07 Thread sven . auhagen
From: Sven Auhagen The igb XDP xmit back function should only return defined error codes. Signed-off-by: Sven Auhagen --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ether

[PATCH 0/7] igb: xdp patches followup

2020-10-07 Thread sven . auhagen
From: Sven Auhagen This patch series addresses some of the comments that came back after the igb XDP patch was accepted. Most of it is code cleanup. The last patch contains a fix for a tx queue timeout that can occur when using xdp. Signed-off-by: Sven Auhagen Sven Auhagen (7): igb: XDP xmit

[PATCH 3/7] igb: XDP extack message on error

2020-10-07 Thread sven . auhagen
From: Sven Auhagen Add an extack error message when the RX buffer size is too small for the frame size. Signed-off-by: Sven Auhagen --- drivers/net/ethernet/intel/igb/igb_main.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_

[PATCH 4/7] igb: skb add metasize for xdp

2020-10-07 Thread sven . auhagen
From: Sven Auhagen add metasize if it is set in xdp Signed-off-by: Sven Auhagen --- drivers/net/ethernet/intel/igb/igb_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 088f9ddb0093..36ff8

[PATCH 6/7] igb: use xdp_do_flush

2020-10-07 Thread sven . auhagen
From: Sven Auhagen Since it is a new XDP implementation change xdp_do_flush_map to xdp_do_flush. Signed-off-by: Sven Auhagen --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/ne

Re: [PATCH net] ipv4: Update exception handling for multipath routes via same device

2020-10-07 Thread Tobias Brunner
Hi David, > @@ -2668,8 +2673,6 @@ struct rtable *ip_route_output_key_hash_rcu(struct net > *net, struct flowi4 *fl4, > fib_select_path(net, res, fl4, skb); > > dev_out = FIB_RES_DEV(*res); > - fl4->flowi4_oif = dev_out->ifindex; > - > > make_route: > rth = __mkroute_out

  1   2   3   >